npm - github-issue-tower-defence-management - Versions diffs - 1.144.0 → 1.144.2 - Mend

github-issue-tower-defence-management 1.144.0 → 1.144.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (26) hide show

package/src/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-y6LyqXlu.js"></script>
+    <script type="module" crossorigin src="/assets/index-BYoG8oQb.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-CKX2ny-z.css">
   </head>
   <body>

package/src/domain/usecases/console/GenerateConsoleListsUseCase.test.ts CHANGED Viewed

@@ -152,6 +152,36 @@ describe('GenerateConsoleListsUseCase', () => {
       const result = run([makeIssue({ status: 'Unread' })]);
       expect(result.unread.items).toHaveLength(1);
     });
+    it('accepts an unread issue that has no assignee', () => {
+      const result = run([makeIssue({ status: 'Unread', assignees: [] })]);
+      expect(result.unread.items).toHaveLength(1);
+    });
+    it('accepts an unread pull request that has no assignee', () => {
+      const result = run([
+        makeIssue({ status: 'Unread', assignees: [], isPr: true }),
+      ]);
+      expect(result.unread.items).toHaveLength(1);
+    });
+    it('accepts a todo-by-human issue that has no assignee', () => {
+      const result = run([
+        makeIssue({ status: 'Todo by human', assignees: [] }),
+      ]);
+      expect(result['todo-by-human'].items).toHaveLength(1);
+    });
+    it('keeps rejecting an unassigned issue that is blocked by a depended issue url', () => {
+      const result = run([
+        makeIssue({
+          status: 'Unread',
+          assignees: [],
+          dependedIssueUrls: ['https://github.com/demo/repo/issues/99'],
+        }),
+      ]);
+      expect(result.unread.items).toHaveLength(0);
+    });
   });
   describe('per-tab selectors', () => {
@@ -378,6 +408,7 @@ describe('GenerateConsoleListsUseCase', () => {
           'nextActionHour',
           'number',
           'projectItemId',
+          'relatedOpenPullRequestUrls',
           'repo',
           'status',
           'story',
@@ -582,6 +613,67 @@ describe('GenerateConsoleListsUseCase', () => {
     });
   });
+  describe('related open pull requests', () => {
+    const awaitingQualityCheckIssue = (): Issue =>
+      makeIssue({ status: 'Awaiting Quality Check' });
+    it('projects the open pull request that closes the issue', () => {
+      const issue = awaitingQualityCheckIssue();
+      const pullRequest = makeIssue({
+        status: 'Awaiting Quality Check',
+        isPr: true,
+        url: 'https://github.com/demo/repo/pull/501',
+        closingIssueReferenceUrls: [issue.url],
+      });
+      const result = run([issue, pullRequest]);
+      const projected = result.prs.items.find((item) => item.url === issue.url);
+      expect(projected?.relatedOpenPullRequestUrls).toEqual([
+        'https://github.com/demo/repo/pull/501',
+      ]);
+    });
+    it('ignores a closed pull request that closes the issue', () => {
+      const issue = awaitingQualityCheckIssue();
+      const pullRequest = makeIssue({
+        isPr: true,
+        isClosed: true,
+        url: 'https://github.com/demo/repo/pull/502',
+        closingIssueReferenceUrls: [issue.url],
+      });
+      const result = run([issue, pullRequest]);
+      const projected = result.prs.items.find((item) => item.url === issue.url);
+      expect(projected?.relatedOpenPullRequestUrls).toEqual([]);
+    });
+    it('collects the linkage from a pull request that no tab shows', () => {
+      const issue = awaitingQualityCheckIssue();
+      const pullRequest = makeIssue({
+        status: 'In Tmux by agent',
+        assignees: ['another-person'],
+        isPr: true,
+        url: 'https://github.com/demo/repo/pull/503',
+        closingIssueReferenceUrls: [issue.url],
+      });
+      const result = run([issue, pullRequest]);
+      const projected = result.prs.items.find((item) => item.url === issue.url);
+      expect(projected?.relatedOpenPullRequestUrls).toEqual([
+        'https://github.com/demo/repo/pull/503',
+      ]);
+    });
+    it('leaves the list empty when no open pull request closes the issue', () => {
+      const issue = awaitingQualityCheckIssue();
+      const unrelatedPullRequest = makeIssue({
+        isPr: true,
+        url: 'https://github.com/demo/repo/pull/504',
+        closingIssueReferenceUrls: ['https://github.com/demo/repo/issues/999'],
+      });
+      const result = run([issue, unrelatedPullRequest]);
+      const projected = result.prs.items.find((item) => item.url === issue.url);
+      expect(projected?.relatedOpenPullRequestUrls).toEqual([]);
+    });
+  });
   describe('project without a story field', () => {
     const projectNoStory = baseProject(null);

package/src/domain/usecases/console/GenerateConsoleListsUseCase.ts CHANGED Viewed

@@ -25,6 +25,7 @@ export type ConsoleListItem = {
   dependedIssueUrls: string[];
   labels: string[];
   createdAt: string;
+  relatedOpenPullRequestUrls: string[];
 };
 export type ConsoleFieldOption = {
@@ -96,6 +97,9 @@ export class GenerateConsoleListsUseCase {
     const storyOrder = storyOptions.map((option) => option.name);
     const statusOptions = project.status.statuses;
+    const relatedOpenPullRequestUrlsByIssueUrl =
+      this.buildRelatedOpenPullRequestUrlsByIssueUrl(issues);
     const visibleIssues = issues.filter(
       (issue) =>
         issue.status?.toLowerCase() !==
@@ -117,7 +121,14 @@ export class GenerateConsoleListsUseCase {
       storyOrder,
       storyColors: this.buildStoryColorsObject(storyOptions),
       items: this.sortByStoryOrder(
-        sourceIssues.filter(selector).map((issue) => this.projectItem(issue)),
+        sourceIssues
+          .filter(selector)
+          .map((issue) =>
+            this.projectItem(
+              issue,
+              relatedOpenPullRequestUrlsByIssueUrl.get(issue.url) ?? [],
+            ),
+          ),
         storyOrder,
       ),
     });
@@ -183,7 +194,12 @@ export class GenerateConsoleListsUseCase {
                 issue.status?.toLowerCase() !==
                   IN_TMUX_BY_AGENT_STATUS_NAME.toLowerCase(),
             )
-            .map((issue) => this.projectItem(issue)),
+            .map((issue) =>
+              this.projectItem(
+                issue,
+                relatedOpenPullRequestUrlsByIssueUrl.get(issue.url) ?? [],
+              ),
+            ),
           storyOrder,
         ),
       },
@@ -192,11 +208,17 @@ export class GenerateConsoleListsUseCase {
   private isActionable = (issue: Issue, assigneeLogin: string): boolean =>
     issue.isClosed === false &&
-    issue.assignees.includes(assigneeLogin) &&
+    this.isOwnedByNobodyElse(issue, assigneeLogin) &&
     issue.dependedIssueUrls.length === 0 &&
     issue.nextActionDate === null &&
     issue.nextActionHour === null;
+  private isOwnedByNobodyElse = (
+    issue: Issue,
+    assigneeLogin: string,
+  ): boolean =>
+    issue.assignees.length === 0 || issue.assignees.includes(assigneeLogin);
   private workflowBlockerSelector = (
     workflowBlockerStoryName: string | null,
   ): ((issue: Issue) => boolean) => {
@@ -208,7 +230,32 @@ export class GenerateConsoleListsUseCase {
       issue.story !== null && issue.story.toLowerCase() === target;
   };
-  private projectItem = (issue: Issue): ConsoleListItem => ({
+  private buildRelatedOpenPullRequestUrlsByIssueUrl = (
+    issues: Issue[],
+  ): Map<string, string[]> => {
+    const urlsByIssueUrl = new Map<string, string[]>();
+    for (const issue of issues) {
+      if (!issue.isPr || issue.isClosed) {
+        continue;
+      }
+      for (const referencedIssueUrl of issue.closingIssueReferenceUrls) {
+        const existing = urlsByIssueUrl.get(referencedIssueUrl);
+        if (existing === undefined) {
+          urlsByIssueUrl.set(referencedIssueUrl, [issue.url]);
+          continue;
+        }
+        if (!existing.includes(issue.url)) {
+          existing.push(issue.url);
+        }
+      }
+    }
+    return urlsByIssueUrl;
+  };
+  private projectItem = (
+    issue: Issue,
+    relatedOpenPullRequestUrls: string[],
+  ): ConsoleListItem => ({
     number: issue.number,
     title: issue.title,
     url: issue.url,
@@ -225,6 +272,7 @@ export class GenerateConsoleListsUseCase {
     dependedIssueUrls: issue.dependedIssueUrls,
     labels: issue.labels,
     createdAt: issue.createdAt.toISOString(),
+    relatedOpenPullRequestUrls,
   });
   private buildFieldOptions = (

package/types/domain/usecases/console/GenerateConsoleListsUseCase.d.ts CHANGED Viewed

@@ -17,6 +17,7 @@ export type ConsoleListItem = {
     dependedIssueUrls: string[];
     labels: string[];
     createdAt: string;
+    relatedOpenPullRequestUrls: string[];
 };
 export type ConsoleFieldOption = {
     id: string;
@@ -62,7 +63,9 @@ export type GenerateConsoleListsInput = {
 export declare class GenerateConsoleListsUseCase {
     run: (input: GenerateConsoleListsInput) => ConsoleLists;
     private isActionable;
+    private isOwnedByNobodyElse;
     private workflowBlockerSelector;
+    private buildRelatedOpenPullRequestUrlsByIssueUrl;
     private projectItem;
     private buildFieldOptions;
     private buildStoryColorsObject;

package/types/domain/usecases/console/GenerateConsoleListsUseCase.d.ts.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"GenerateConsoleListsUseCase.d.ts","sourceRoot":"","sources":["../../../../src/domain/usecases/console/GenerateConsoleListsUseCase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,sBAAsB,CAAC;AAC7C,OAAO,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,wBAAwB,CAAC;AAQ9D,MAAM,MAAM,YAAY,GAAG,WAAW,CAAC,OAAO,CAAC,CAAC;AAEhD,MAAM,MAAM,eAAe,GAAG;IAC5B,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,GAAG,EAAE,MAAM,CAAC;IACZ,IAAI,EAAE,MAAM,CAAC;IACb,aAAa,EAAE,MAAM,CAAC;IACtB,aAAa,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,OAAO,CAAC;IACd,KAAK,EAAE,MAAM,CAAC;IACd,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,cAAc,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,cAAc,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,CAAC;~~CACnB~~,CAAC;AAEF,MAAM,MAAM,kBAAkB,GAAG;IAC/B,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,YAAY,CAAC;CACrB,CAAC;AAEF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,aAAa,EAAE,kBAAkB,EAAE,CAAC;IACpC,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE;QAAE,KAAK,EAAE,YAAY,CAAA;KAAE,CAAC,CAAC;IACrD,KAAK,EAAE,eAAe,EAAE,CAAC;CAC1B,CAAC;AAEF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,kBAAkB,EAAE,CAAC;IACnC,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,YAAY,CAAC,CAAC;IAC1C,KAAK,EAAE,eAAe,EAAE,CAAC;CAC1B,CAAC;AAEF,MAAM,MAAM,cAAc,GACtB,kBAAkB,GAClB,KAAK,GACL,QAAQ,GACR,QAAQ,GACR,oBAAoB,GACpB,eAAe,GACf,eAAe,CAAC;AAEpB,MAAM,MAAM,YAAY,GAAG;IACzB,kBAAkB,EAAE,gBAAgB,CAAC;IACrC,GAAG,EAAE,gBAAgB,CAAC;IACtB,MAAM,EAAE,gBAAgB,CAAC;IACzB,MAAM,EAAE,gBAAgB,CAAC;IACzB,oBAAoB,EAAE,gBAAgB,CAAC;IACvC,eAAe,EAAE,gBAAgB,CAAC;IAClC,eAAe,EAAE,gBAAgB,CAAC;CACnC,CAAC;AAEF,MAAM,MAAM,yBAAyB,GAAG;IACtC,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,KAAK,EAAE,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;IACf,aAAa,EAAE,MAAM,CAAC;IACtB,WAAW,EAAE,MAAM,CAAC;IACpB,wBAAwB,EAAE,MAAM,GAAG,IAAI,CAAC;CACzC,CAAC;AAIF,qBAAa,2BAA2B;IACtC,GAAG,GAAI,OAAO,yBAAyB,KAAG,YAAY,~~CA0GpD~~;IAEF,OAAO,CAAC,YAAY,CAKY;IAEhC,OAAO,CAAC,uBAAuB,CAS7B;IAEF,OAAO,CAAC,WAAW,~~CAiBhB~~;IAEH,OAAO,CAAC,iBAAiB,CAYjB;IAER,OAAO,CAAC,sBAAsB,CAQ5B;IAEF,OAAO,CAAC,sBAAsB,CAQ5B;IAEF,OAAO,CAAC,gBAAgB,CAetB;CACH"}
1	+ {"version":3,"file":"GenerateConsoleListsUseCase.d.ts","sourceRoot":"","sources":["../../../../src/domain/usecases/console/GenerateConsoleListsUseCase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,sBAAsB,CAAC;AAC7C,OAAO,EAAE,WAAW,EAAE,OAAO,EAAE,MAAM,wBAAwB,CAAC;AAQ9D,MAAM,MAAM,YAAY,GAAG,WAAW,CAAC,OAAO,CAAC,CAAC;AAEhD,MAAM,MAAM,eAAe,GAAG;IAC5B,MAAM,EAAE,MAAM,CAAC;IACf,KAAK,EAAE,MAAM,CAAC;IACd,GAAG,EAAE,MAAM,CAAC;IACZ,IAAI,EAAE,MAAM,CAAC;IACb,aAAa,EAAE,MAAM,CAAC;IACtB,aAAa,EAAE,MAAM,CAAC;IACtB,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,OAAO,CAAC;IACd,KAAK,EAAE,MAAM,CAAC;IACd,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC;IACtB,cAAc,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,cAAc,EAAE,MAAM,GAAG,IAAI,CAAC;IAC9B,iBAAiB,EAAE,MAAM,EAAE,CAAC;IAC5B,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,SAAS,EAAE,MAAM,CAAC;IAClB,0BAA0B,EAAE,MAAM,EAAE,CAAC;CACtC,CAAC;AAEF,MAAM,MAAM,kBAAkB,GAAG;IAC/B,EAAE,EAAE,MAAM,CAAC;IACX,IAAI,EAAE,MAAM,CAAC;IACb,KAAK,EAAE,YAAY,CAAC;CACrB,CAAC;AAEF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,aAAa,EAAE,kBAAkB,EAAE,CAAC;IACpC,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE;QAAE,KAAK,EAAE,YAAY,CAAA;KAAE,CAAC,CAAC;IACrD,KAAK,EAAE,eAAe,EAAE,CAAC;CAC1B,CAAC;AAEF,MAAM,MAAM,gBAAgB,GAAG;IAC7B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,YAAY,EAAE,kBAAkB,EAAE,CAAC;IACnC,UAAU,EAAE,MAAM,EAAE,CAAC;IACrB,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,YAAY,CAAC,CAAC;IAC1C,KAAK,EAAE,eAAe,EAAE,CAAC;CAC1B,CAAC;AAEF,MAAM,MAAM,cAAc,GACtB,kBAAkB,GAClB,KAAK,GACL,QAAQ,GACR,QAAQ,GACR,oBAAoB,GACpB,eAAe,GACf,eAAe,CAAC;AAEpB,MAAM,MAAM,YAAY,GAAG;IACzB,kBAAkB,EAAE,gBAAgB,CAAC;IACrC,GAAG,EAAE,gBAAgB,CAAC;IACtB,MAAM,EAAE,gBAAgB,CAAC;IACzB,MAAM,EAAE,gBAAgB,CAAC;IACzB,oBAAoB,EAAE,gBAAgB,CAAC;IACvC,eAAe,EAAE,gBAAgB,CAAC;IAClC,eAAe,EAAE,gBAAgB,CAAC;CACnC,CAAC;AAEF,MAAM,MAAM,yBAAyB,GAAG;IACtC,OAAO,EAAE,OAAO,CAAC;IACjB,MAAM,EAAE,KAAK,EAAE,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;IACf,aAAa,EAAE,MAAM,CAAC;IACtB,WAAW,EAAE,MAAM,CAAC;IACpB,wBAAwB,EAAE,MAAM,GAAG,IAAI,CAAC;CACzC,CAAC;AAIF,qBAAa,2BAA2B;IACtC,GAAG,GAAI,OAAO,yBAAyB,KAAG,YAAY,CAyHpD;IAEF,OAAO,CAAC,YAAY,CAKY;IAEhC,OAAO,CAAC,mBAAmB,CAI+C;IAE1E,OAAO,CAAC,uBAAuB,CAS7B;IAEF,OAAO,CAAC,yCAAyC,CAoB/C;IAEF,OAAO,CAAC,WAAW,CAqBhB;IAEH,OAAO,CAAC,iBAAiB,CAYjB;IAER,OAAO,CAAC,sBAAsB,CAQ5B;IAEF,OAAO,CAAC,sBAAsB,CAQ5B;IAEF,OAAO,CAAC,gBAAgB,CAetB;CACH"}