github-issue-tower-defence-management 1.143.6 → 1.144.1

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsoleItemDetailContainer.test.tsx

@@ -26,6 +26,7 @@ const issueItem = consoleListItemsFixture[2];
 type CachesOverrides = {
   relatedPrs?: ConsoleRelatedPullRequest[];
   prFiles?: ConsoleChangedFile[];
+  relatedPrsNeverResolve?: boolean;
 };
 
 const buildCaches = (overrides: CachesOverrides = {}): ConsoleCaches => {
@@ -34,7 +35,10 @@ const buildCaches = (overrides: CachesOverrides = {}): ConsoleCaches => {
     fetchComments: async () => [],
     fetchPrFiles: async () => overrides.prFiles ?? [],
     fetchPrCommits: async () => [],
-    fetchRelatedPrs: async () => overrides.relatedPrs ?? [],
+    fetchRelatedPrs: async () =>
+      overrides.relatedPrsNeverResolve === true
+        ? new Promise<ConsoleRelatedPullRequest[]>(() => {})
+        : (overrides.relatedPrs ?? []),
     fetchIssueState: async () => ({
       state: 'open',
       merged: false,
@@ -75,6 +79,7 @@ const buildOperations = (): ConsoleOperationsApi => ({
     body: 'comment body',
     createdAt: '2026-06-19T11:58:00.000Z',
   })),
+  uploadAttachment: jest.fn(async () => ''),
   addInlineReviewComment: jest.fn(async () => {}),
 });
 
@@ -115,6 +120,43 @@ describe('ConsoleItemDetailContainer', () => {
     );
   });
 
+  it('shows Approve for an issue item from the generated related open pull request urls before the related pull requests are fetched', () => {
+    const operations = buildOperations();
+    const onQueueAction = jest.fn();
+    const bakedPullRequestUrl =
+      'https://github.com/HiromiShikata/npm-cli-github-issue-tower-defence-management/pull/1372';
+    const itemWithBakedPullRequest = {
+      ...issueItem,
+      relatedOpenPullRequestUrls: [bakedPullRequestUrl],
+    };
+    const { getByText } = render(
+      <ConsoleItemDetailContainer
+        tab="prs"
+        item={itemWithBakedPullRequest}
+        caches={buildCaches({ relatedPrsNeverResolve: true })}
+        operations={operations}
+        statusOptions={consoleStatusOptionsFixture}
+        storyOptions={consoleStoryOptionsFixture}
+        storyColors={consoleStoryColorsFixture}
+        storyName="TDPM Console port"
+        overlayStatus={null}
+        now={Date.parse('2026-06-19T12:00:00.000Z')}
+        onQueueAction={onQueueAction}
+      />,
+    );
+
+    expect(getByText('Approve')).toBeInTheDocument();
+    fireEvent.click(getByText('Approve'));
+    const input = onQueueAction.mock.calls[0][0];
+    input.commit();
+    expect(operations.reviewPullRequest).toHaveBeenCalledWith(
+      itemWithBakedPullRequest,
+      bakedPullRequestUrl,
+      'approve',
+      [],
+    );
+  });
+
   it('disables Reject until an inline comment is entered and then commits it as the request-changes review', async () => {
     const operations = buildOperations();
     const onQueueAction = jest.fn();

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsoleItemDetailContainer.tsx

@@ -71,7 +71,10 @@ export const ConsoleItemDetailContainer = ({
     ),
     [caches.state],
   );
-  const hasPullRequest = item.isPr || detail.relatedPullRequests.length > 0;
+  const hasPullRequest =
+    item.isPr ||
+    item.relatedOpenPullRequestUrls.length > 0 ||
+    detail.relatedPullRequests.length > 0;
   const [pendingReviewComments, setPendingReviewComments] = useState<
     ConsolePendingReviewComment[]
   >([]);
@@ -89,7 +92,9 @@ export const ConsoleItemDetailContainer = ({
     onReview: (action) => {
       const prUrl = item.isPr
         ? item.url
-        : (detail.relatedPullRequests[0]?.pullRequest.url ?? item.url);
+        : (detail.relatedPullRequests[0]?.pullRequest.url ??
+          item.relatedOpenPullRequestUrls[0] ??
+          item.url);
       const reviewComments =
         action === 'request_changes' ? pendingReviewComments : [];
       onQueueAction({
@@ -173,6 +178,7 @@ export const ConsoleItemDetailContainer = ({
           isPr={item.isPr}
           now={now}
           onSubmit={(body) => operations.addComment(item, body)}
+          onUploadFile={(file) => operations.uploadAttachment(item, file)}
         />
       }
       operationBar={

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.test.tsx

@@ -37,6 +37,7 @@ const listPayload = (tab: string) => ({
             projectItemId: 'PVTI_1',
             itemId: 'PVTI_1',
             isPr: true,
+            relatedOpenPullRequestUrls: [],
             story: 'TDPM Console port',
             status: 'Awaiting Quality Check',
             nextActionDate: null,
@@ -57,6 +58,7 @@ const listPayload = (tab: string) => ({
               projectItemId: 'PVTI_2',
               itemId: 'PVTI_2',
               isPr: false,
+              relatedOpenPullRequestUrls: [],
               story: 'TDPM Console port',
               status: 'Unread',
               nextActionDate: null,
@@ -266,6 +268,7 @@ describe('ConsolePage', () => {
         projectItemId: 'PVTI_B1',
         itemId: 'PVTI_B1',
         isPr: false,
+        relatedOpenPullRequestUrls: [],
         story: 'TDPM Console port',
         status: 'In Progress',
         nextActionDate: null,
@@ -283,6 +286,7 @@ describe('ConsolePage', () => {
         projectItemId: 'PVTI_B2',
         itemId: 'PVTI_B2',
         isPr: false,
+        relatedOpenPullRequestUrls: [],
         story: 'TDPM Console port',
         status: 'In Progress',
         nextActionDate: null,
@@ -348,6 +352,7 @@ describe('ConsolePage', () => {
         projectItemId: 'PVTI_B1',
         itemId: 'PVTI_B1',
         isPr: false,
+        relatedOpenPullRequestUrls: [],
         story: 'TDPM Console port',
         status: 'In Progress',
         nextActionDate: null,
@@ -472,6 +477,7 @@ const twoItemPrPayload = () => ({
       projectItemId: 'PVTI_1',
       itemId: 'PVTI_1',
       isPr: true,
+      relatedOpenPullRequestUrls: [],
       story: 'TDPM Console port',
       status: 'Awaiting Quality Check',
       nextActionDate: null,
@@ -489,6 +495,7 @@ const twoItemPrPayload = () => ({
       projectItemId: 'PVTI_2',
       itemId: 'PVTI_2',
       isPr: true,
+      relatedOpenPullRequestUrls: [],
       story: 'TDPM Console port',
       status: 'Awaiting Quality Check',
       nextActionDate: null,

package/src/adapter/entry-points/console/ui/src/features/console/testing/fixtures.ts

@@ -56,6 +56,7 @@ export const consoleListItemsFixture: ConsoleListItem[] = [
     projectItemId: 'PVTI_lADOABCD1234zgABCD01',
     itemId: 'PVTI_lADOABCD1234zgABCD01',
     isPr: true,
+    relatedOpenPullRequestUrls: [],
     story: 'TDPM Console port',
     status: 'Awaiting Quality Check',
     nextActionDate: null,
@@ -77,6 +78,7 @@ export const consoleListItemsFixture: ConsoleListItem[] = [
     projectItemId: 'PVTI_lADOABCD1234zgABCD02',
     itemId: 'PVTI_lADOABCD1234zgABCD02',
     isPr: true,
+    relatedOpenPullRequestUrls: [],
     story: 'TDPM Console port',
     status: 'Preparation',
     nextActionDate: null,
@@ -95,6 +97,7 @@ export const consoleListItemsFixture: ConsoleListItem[] = [
     projectItemId: 'PVTI_lADOABCD1234zgABCD03',
     itemId: 'PVTI_lADOABCD1234zgABCD03',
     isPr: false,
+    relatedOpenPullRequestUrls: [],
     story: 'TDPM Console port',
     status: 'Todo by human',
     nextActionDate: '2026-06-20T07:00:00.000Z',
@@ -113,6 +116,7 @@ export const consoleListItemsFixture: ConsoleListItem[] = [
     projectItemId: 'PVTI_lADOABCD1234zgABCD04',
     itemId: 'PVTI_lADOABCD1234zgABCD04',
     isPr: false,
+    relatedOpenPullRequestUrls: [],
     story: 'regular / workflow improvement',
     status: null,
     nextActionDate: null,
@@ -131,6 +135,7 @@ export const consoleListItemsFixture: ConsoleListItem[] = [
     projectItemId: 'PVTI_lADOABCD1234zgABCD05',
     itemId: 'PVTI_lADOABCD1234zgABCD05',
     isPr: false,
+    relatedOpenPullRequestUrls: [],
     story: 'Publish product documentation site',
     status: 'Icebox',
     nextActionDate: null,