npm - github-issue-tower-defence-management - Versions diffs - 1.143.0 → 1.143.1 - Mend

github-issue-tower-defence-management 1.143.0 → 1.143.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (13) hide show

package/bin/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-C1KKZ_a1.js"></script>
+    <script type="module" crossorigin src="/assets/index-BWy8G--c.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-Bp-p-XOs.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.143.0",
+  "version": "1.143.1",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/ui/e2e/consoleScenario.spec.ts CHANGED Viewed

@@ -234,3 +234,39 @@ test('collects an inline comment on a related pull request diff without hover on
   await touchContext.close();
 });
+test('lists a still-open item and keeps its tab visible when the browser overlay marked it done before the served snapshot was generated', async ({
+  page,
+}) => {
+  await page.goto(harness.appRootUrl);
+  await expect(tabByLabel(page, 'Todo by human')).toBeVisible();
+  await page.evaluate(() => {
+    localStorage.setItem(
+      'pv_overlay_umino',
+      JSON.stringify({
+        PVTI_lADOABCD1234zgTODO00869: {
+          done: true,
+          ts: Date.parse('2026-06-18T00:30:00.000Z'),
+          mode: 'todo-by-human',
+        },
+      }),
+    );
+  });
+  await page.reload();
+  await page.locator('.console-tabbar').screenshot({
+    path: '/tmp/console-tabbar-after-regeneration.png',
+  });
+  await expect(tabByLabel(page, 'Todo by human')).toBeVisible();
+  await expect(tabBadge(page, 'Todo by human')).toHaveText('1');
+  await tabByLabel(page, 'Todo by human').click();
+  await expect(
+    itemRowByText(
+      page,
+      'Auto-advance to the next non-empty console tab when one empties',
+    ),
+  ).toBeVisible();
+});

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts CHANGED Viewed

@@ -2,6 +2,7 @@ import {
   countPendingItems,
   filterPendingItems,
   isOverlayEntryActed,
+  overlayEntriesActedSinceSnapshot,
   overlayKeyForItem,
   overlayStorageKey,
   writeOverlayEntry,
@@ -149,6 +150,60 @@ describe('workflow-blocker items are filtered by the done overlay like every oth
   });
 });
+describe('overlayEntriesActedSinceSnapshot', () => {
+  it('drops an entry written before the snapshot was generated so the item is pending again', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: {
+        ts: Date.parse('2026-08-04T00:20:00.000Z'),
+        mode: 'todo-by-human',
+        done: true,
+      },
+    };
+    const acted = overlayEntriesActedSinceSnapshot(
+      overlay,
+      '2026-08-04T00:26:06Z',
+    );
+    expect(acted).toEqual({});
+    expect(countPendingItems([item(1)], acted)).toBe(1);
+    expect(filterPendingItems([item(1)], acted)).toEqual([item(1)]);
+  });
+  it('keeps an entry written after the snapshot was generated so the item stays hidden', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: {
+        ts: Date.parse('2026-08-04T00:30:00.000Z'),
+        mode: 'todo-by-human',
+        done: true,
+      },
+    };
+    const acted = overlayEntriesActedSinceSnapshot(
+      overlay,
+      '2026-08-04T00:26:06Z',
+    );
+    expect(countPendingItems([item(1)], acted)).toBe(0);
+  });
+  it('keeps an entry written at the exact snapshot generation time', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: {
+        ts: Date.parse('2026-08-04T00:26:06Z'),
+        mode: 'todo-by-human',
+        done: true,
+      },
+    };
+    expect(
+      overlayEntriesActedSinceSnapshot(overlay, '2026-08-04T00:26:06Z'),
+    ).toEqual(overlay);
+  });
+  it('suppresses nothing when the snapshot carries no parsable generation time', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: { ts: 500, mode: 'todo-by-human', done: true },
+    };
+    expect(overlayEntriesActedSinceSnapshot(overlay, '')).toEqual({});
+  });
+});
 describe('writeOverlayEntry', () => {
   it('stamps the timestamp and mode on write', () => {
     const next = writeOverlayEntry({}, 'PVTI_1', { done: true }, 'prs', 1234);

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.ts CHANGED Viewed

@@ -30,6 +30,23 @@ export const filterPendingItems = (
     (item) => !isOverlayEntryActed(overlay[overlayKeyForItem(item)]),
   );
+export const overlayEntriesActedSinceSnapshot = (
+  overlay: ConsoleOverlay,
+  snapshotGeneratedAt: string,
+): ConsoleOverlay => {
+  const snapshotGeneratedAtMs = Date.parse(snapshotGeneratedAt);
+  if (Number.isNaN(snapshotGeneratedAtMs)) {
+    return {};
+  }
+  const acted: ConsoleOverlay = {};
+  for (const [key, entry] of Object.entries(overlay)) {
+    if (entry.ts >= snapshotGeneratedAtMs) {
+      acted[key] = entry;
+    }
+  }
+  return acted;
+};
 export const writeOverlayEntry = (
   overlay: ConsoleOverlay,
   key: string,

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.test.tsx CHANGED Viewed

@@ -310,7 +310,11 @@ describe('ConsolePage', () => {
     localStorage.setItem(
       'pv_overlay_umino',
       JSON.stringify({
-        PVTI_B1: { ts: 1, mode: 'workflow-blocker', done: true },
+        PVTI_B1: {
+          ts: Date.parse('2026-06-19T00:05:00.000Z'),
+          mode: 'workflow-blocker',
+          done: true,
+        },
       }),
     );
     window.history.replaceState(
@@ -333,6 +337,69 @@ describe('ConsolePage', () => {
     );
   });
+  it('lists an item again when the overlay marked it done before the served snapshot was generated', async () => {
+    const blockerItems = [
+      {
+        number: 701,
+        title: 'Blocked deployment task',
+        url: 'https://github.com/o/r/issues/701',
+        repo: 'o/r',
+        nameWithOwner: 'o/r',
+        projectItemId: 'PVTI_B1',
+        itemId: 'PVTI_B1',
+        isPr: false,
+        story: 'TDPM Console port',
+        status: 'In Progress',
+        nextActionDate: null,
+        nextActionHour: null,
+        dependedIssueUrls: [],
+        labels: [],
+        createdAt: '2026-06-17T00:00:00.000Z',
+      },
+    ];
+    const fetchMock = jest.fn(async (url: string) => {
+      const listMatch = url.match(/\/projects\/[^/]+\/([^/]+)\/list\.json/);
+      if (listMatch !== null) {
+        return {
+          ok: true,
+          status: 200,
+          json: async () =>
+            listMatch[1] === 'workflow-blocker'
+              ? { ...listPayload('workflow-blocker'), items: blockerItems }
+              : listPayload(listMatch[1]),
+        };
+      }
+      return { ok: true, status: 200, json: async () => ({ body: '# body' }) };
+    });
+    global.fetch = fetchMock as unknown as typeof fetch;
+    localStorage.setItem(
+      'pv_overlay_umino',
+      JSON.stringify({
+        PVTI_B1: {
+          ts: Date.parse('2026-06-18T23:00:00.000Z'),
+          mode: 'workflow-blocker',
+          done: true,
+        },
+      }),
+    );
+    window.history.replaceState(
+      {},
+      '',
+      '/projects/umino/workflow-blocker?k=token',
+    );
+    const { getByText } = render(<ConsolePage />);
+    await waitFor(() => {
+      expect(getByText('Blocked deployment task')).toBeInTheDocument();
+    });
+    const blockerTab = within(tabBar())
+      .getByText('Workflow Blocker')
+      .closest('a');
+    expect(blockerTab?.querySelector('.console-tab-badge')?.textContent).toBe(
+      '1',
+    );
+  });
   it('renders the failure toast in English without any Japanese characters', async () => {
     const fetchMock = jest.fn(
       async (url: string, init?: { method?: string }) => {

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx CHANGED Viewed

@@ -28,6 +28,7 @@ import {
 import {
   countPendingItems,
   filterPendingItems,
+  overlayEntriesActedSinceSnapshot,
   overlayKeyForItem,
 } from '../logic/overlay';
 import type { ConsoleSwipeDirection } from '../logic/swipe';
@@ -67,7 +68,10 @@ export const ConsolePage = () => {
       }
       result[tab.name] = countPendingItems(
         snapshot.items,
-        overlayState.overlay,
+        overlayEntriesActedSinceSnapshot(
+          overlayState.overlay,
+          snapshot.generatedAt,
+        ),
       );
     }
     return result;
@@ -92,7 +96,13 @@ export const ConsolePage = () => {
     if (activeSnapshot === null) {
       return [];
     }
-    return filterPendingItems(activeSnapshot.items, overlayState.overlay);
+    return filterPendingItems(
+      activeSnapshot.items,
+      overlayEntriesActedSinceSnapshot(
+        overlayState.overlay,
+        activeSnapshot.generatedAt,
+      ),
+    );
   }, [activeSnapshot, overlayState.overlay]);
   const orderedPendingKeys = useMemo(