github-issue-tower-defence-management 1.139.1 → 1.140.1

package/src/domain/usecases/NotifySilentLiveSessionsUseCase.test.ts

@@ -10,7 +10,6 @@ import {
   DEFAULT_NOTIFICATION_STAGGER_SECONDS,
   DEFAULT_CANDIDATE_DEBOUNCE_RECENCY_WINDOW_SECONDS,
   DEFAULT_HUB_TASK_STATUS_CACHE_TTL_SECONDS,
-  IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS,
 } from './NotifySilentLiveSessionsUseCase';
 import { Issue } from '../entities/Issue';
 import { LiveSessionProcessSnapshotProvider } from './adapter-interfaces/LiveSessionProcessSnapshotProvider';
@@ -268,7 +267,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -299,7 +297,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -323,7 +320,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: pullRequestSession,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -345,7 +341,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: 'workbench',
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -379,13 +374,11 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
         {
           sessionName: 'orchestrator',
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -501,7 +494,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS + 1,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -529,7 +521,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -550,7 +541,7 @@ describe('NotifySilentLiveSessionsUseCase', () => {
     ).toHaveBeenCalledWith(GITHUB_SESSION, MAIN_STALLED_SECTION);
   });
 
-  it('does not send the main stalled section when the session is silent past the threshold but is waiting on a running tool call', async () => {
+  it('sends the main stalled section for a session silent past the threshold regardless of any in-progress tool call, because apparent busyness never suppresses the reminder', async () => {
     setupLiveInteractiveSession(GITHUB_SESSION);
     mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
       [
@@ -558,34 +549,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: true,
-        },
-      ],
-    );
-    mockOwnerCallStatusProvider.listUnansweredOwnerCallEpochSecondsBySessionName.mockResolvedValue(
-      new Map<string, number>(),
-    );
-
-    await useCase.run(runParams());
-
-    expect(
-      mockMessageComposer.composeMainStalledSection,
-    ).not.toHaveBeenCalled();
-    expect(
-      mockNotificationRepository.sendSelfCheckNotification,
-    ).not.toHaveBeenCalled();
-  });
-
-  it('sends the main stalled section when the in-progress tool call has been pending longer than the suppression bound', async () => {
-    setupLiveInteractiveSession(GITHUB_SESSION);
-    const pendingToolCallAgeSeconds =
-      IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS + 60 * 60;
-    mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
-      [
-        {
-          sessionName: GITHUB_SESSION,
-          lastOutputEpochSeconds: nowEpochSeconds - pendingToolCallAgeSeconds,
-          hasInProgressToolCall: true,
         },
       ],
     );
@@ -596,7 +559,7 @@ describe('NotifySilentLiveSessionsUseCase', () => {
     await useCase.run(runParams());
 
     expect(mockMessageComposer.composeMainStalledSection).toHaveBeenCalledWith(
-      pendingToolCallAgeSeconds,
+      DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
     );
     expect(
       mockNotificationRepository.sendSelfCheckNotification,
@@ -611,7 +574,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS + 1,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -738,7 +700,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -763,14 +724,12 @@ describe('NotifySilentLiveSessionsUseCase', () => {
         sessionName: GITHUB_SESSION,
         lastOutputEpochSeconds:
           nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-        hasInProgressToolCall: false,
       },
     ];
     const active = [
       {
         sessionName: GITHUB_SESSION,
         lastOutputEpochSeconds: nowEpochSeconds,
-        hasInProgressToolCall: false,
       },
     ];
 
@@ -808,7 +767,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
             sessionName: GITHUB_SESSION,
             lastOutputEpochSeconds:
               nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-            hasInProgressToolCall: false,
           },
         ],
       );
@@ -898,7 +856,7 @@ describe('NotifySilentLiveSessionsUseCase', () => {
     });
   });
 
-  describe('fire-once latch and input-state gating', () => {
+  describe('fire-once latch', () => {
     const setupSilentGithubSession = (): void => {
       setupLiveInteractiveSession(GITHUB_SESSION);
       mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
@@ -907,19 +865,11 @@ describe('NotifySilentLiveSessionsUseCase', () => {
             sessionName: GITHUB_SESSION,
             lastOutputEpochSeconds:
               nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-            hasInProgressToolCall: false,
           },
         ],
       );
     };
 
-    const idleSubAgent = (label: string): SubAgentActivity => ({
-      label,
-      silentSeconds: DEFAULT_SUBAGENT_SILENT_THRESHOLD_SECONDS,
-      runningSeconds: 60,
-      waitingOnExternalProcess: false,
-    });
-
     it('loads the fire-once latch using the configured recency window', async () => {
       setupSilentGithubSession();
 
@@ -973,69 +923,17 @@ describe('NotifySilentLiveSessionsUseCase', () => {
       ).toHaveBeenCalledWith({ sessionNames: [], now });
     });
 
-    it('does not inject into a session whose main REPL has an in-progress tool call even when a sub-agent advisory qualifies', async () => {
-      setupLiveInteractiveSession(GITHUB_SESSION);
-      mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
-        [
-          {
-            sessionName: GITHUB_SESSION,
-            lastOutputEpochSeconds: nowEpochSeconds,
-            hasInProgressToolCall: true,
-          },
-        ],
-      );
-      mockSubAgentActivityRepository.listSubAgentActivitiesBySessionName.mockResolvedValue(
-        new Map([[GITHUB_SESSION, [idleSubAgent('sub-process-1')]]]),
-      );
+    it('sends the reminder for a silent session even when its main REPL is mid-turn, because apparent busyness no longer defers delivery', async () => {
+      setupSilentGithubSession();
 
       await useCase.run(runParams());
 
-      expect(mockMessageComposer.composeSubAgentSection).toHaveBeenCalled();
       expect(
         mockNotificationRepository.sendSelfCheckNotification,
-      ).not.toHaveBeenCalled();
+      ).toHaveBeenCalledWith(GITHUB_SESSION, MAIN_STALLED_SECTION);
       expect(
         mockNotifiedStateRepository.saveNotifiedSessionNames,
-      ).toHaveBeenCalledWith({ sessionNames: [], now });
-    });
-
-    it('delivers the deferred reminder once the main REPL becomes input-ready', async () => {
-      wireStatefulNotifiedLatch();
-      setupLiveInteractiveSession(GITHUB_SESSION);
-      mockSubAgentActivityRepository.listSubAgentActivitiesBySessionName.mockResolvedValue(
-        new Map([[GITHUB_SESSION, [idleSubAgent('sub-process-1')]]]),
-      );
-
-      mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
-        [
-          {
-            sessionName: GITHUB_SESSION,
-            lastOutputEpochSeconds: nowEpochSeconds,
-            hasInProgressToolCall: true,
-          },
-        ],
-      );
-      await useCase.run(runParams());
-      expect(
-        mockNotificationRepository.sendSelfCheckNotification,
-      ).not.toHaveBeenCalled();
-
-      mockSessionOutputActivityRepository.listSessionOutputActivities.mockResolvedValue(
-        [
-          {
-            sessionName: GITHUB_SESSION,
-            lastOutputEpochSeconds: nowEpochSeconds,
-            hasInProgressToolCall: false,
-          },
-        ],
-      );
-      await useCase.run(runParams());
-      expect(
-        mockNotificationRepository.sendSelfCheckNotification,
-      ).toHaveBeenCalledTimes(1);
-      expect(
-        mockNotificationRepository.sendSelfCheckNotification,
-      ).toHaveBeenCalledWith(GITHUB_SESSION, SUBAGENT_SECTION);
+      ).toHaveBeenCalledWith({ sessionNames: [GITHUB_SESSION], now });
     });
   });
 
@@ -1218,13 +1116,11 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION_ALPHA,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
         {
           sessionName: GITHUB_SESSION_BRAVO,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -1260,7 +1156,6 @@ describe('NotifySilentLiveSessionsUseCase', () => {
           sessionName: GITHUB_SESSION,
           lastOutputEpochSeconds:
             nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-          hasInProgressToolCall: false,
         },
       ],
     );
@@ -1802,13 +1697,11 @@ describe('NotifySilentLiveSessionsUseCase', () => {
             sessionName: GITHUB_SESSION_ALPHA,
             lastOutputEpochSeconds:
               nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-            hasInProgressToolCall: false,
           },
           {
             sessionName: GITHUB_SESSION_BRAVO,
             lastOutputEpochSeconds:
               nowEpochSeconds - DEFAULT_MAIN_SILENT_THRESHOLD_SECONDS,
-            hasInProgressToolCall: false,
           },
         ],
       );

package/src/domain/usecases/NotifySilentLiveSessionsUseCase.ts

@@ -26,15 +26,6 @@ export const DEFAULT_SUBAGENT_RUNNING_THRESHOLD_SECONDS = 15 * 60;
 export const DEFAULT_NOTIFICATION_STAGGER_SECONDS = 25;
 export const DEFAULT_CANDIDATE_DEBOUNCE_RECENCY_WINDOW_SECONDS = 15 * 60;
 export const DEFAULT_HUB_TASK_STATUS_CACHE_TTL_SECONDS = 5 * 60;
-// Upper bound on how long an in-progress tool call suppresses the main-stall
-// reminder. Set to 2 hours: comfortably above the ~1-hour maximum duration of
-// the longest legitimate single tool call (the Monitor tool's own timeout
-// ceiling), so every legitimate long-running tool call is still suppressed,
-// while a session whose transcript tail has been an unanswered tool_use for
-// longer than this — for example because the tool call itself hung and never
-// returned — still receives the stall reminder instead of being suppressed
-// forever.
-export const IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS = 2 * 60 * 60;
 
 const GITHUB_ISSUE_OR_PULL_URL_PATTERN =
   /^https:\/\/github\.com\/([^/]+)\/([^/]+)\/(?:issues|pull)\/(\d+)$/;
@@ -71,7 +62,6 @@ type NotifyCandidate = {
   sessionName: string;
   message: string;
   sectionLabels: string[];
-  mainInputBusy: boolean;
 };
 
 export class NotifySilentLiveSessionsUseCase {
@@ -212,20 +202,6 @@ export class NotifySilentLiveSessionsUseCase {
         );
         continue;
       }
-      // Input-state gating: a session whose main REPL is mid-turn — currently
-      // running an in-progress tool call, which includes waiting on a
-      // long-running sub-agent — cannot accept an injected prompt cleanly, so
-      // the reminder is deferred rather than piled into a busy input box. The
-      // session stays a candidate, so it is reminded once it becomes
-      // input-ready. A tool call pending past
-      // IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS is treated as hung and no
-      // longer counts as busy (see composeCandidate).
-      if (candidate.mainInputBusy) {
-        console.log(
-          `Skipping ${candidate.sessionName}: main REPL is not in an input-accepting state (in-progress tool call); deferring reminder until it is idle.`,
-        );
-        continue;
-      }
       if (
         !(await this.isHubTaskActive(
           candidate.sessionName,
@@ -404,16 +380,11 @@ export class NotifySilentLiveSessionsUseCase {
         transcriptPathBySessionName,
       );
     const lastOutputBySessionName = new Map<string, number>();
-    const inProgressToolCallBySessionName = new Map<string, boolean>();
     for (const activity of activities) {
       lastOutputBySessionName.set(
         activity.sessionName,
         activity.lastOutputEpochSeconds,
       );
-      inProgressToolCallBySessionName.set(
-        activity.sessionName,
-        activity.hasInProgressToolCall,
-      );
     }
 
     const subAgentsBySessionName =
@@ -439,8 +410,6 @@ export class NotifySilentLiveSessionsUseCase {
       return {
         sessionName,
         mainSilentSeconds,
-        mainHasInProgressToolCall:
-          inProgressToolCallBySessionName.get(sessionName) ?? false,
         subAgents: subAgentsBySessionName.get(sessionName) ?? [],
         unansweredOwnerCallAgeSeconds:
           unansweredOwnerCallEpochSeconds === undefined
@@ -476,30 +445,17 @@ export class NotifySilentLiveSessionsUseCase {
     // call signature and is intentionally ignored (treated as infinite).
     const suppressedByUnansweredOwnerCall =
       unansweredOwnerCallAgeSeconds !== null;
-    // A session whose transcript tail is an assistant tool_use with no matching
-    // tool_result is legitimately busy running one long tool call (e.g. a Bash
-    // command near its timeout, or a Monitor waiting up to an hour): it appends
-    // no new assistant line while the tool runs, so mainSilentSeconds crosses
-    // the threshold even though the session is working, not stalled. Suppress
-    // the main-stall reminder in that case. Genuine thrashing silence — where
-    // the last assistant tool_use was already answered (or there is none) — has
-    // no pending tool call and is still flagged.
-    // The suppression is bounded by the pending tool call's own age
-    // (mainSilentSeconds, which for an in-progress tool call equals the age of
-    // the pending tool_use line) so it cannot last forever: a session stuck
-    // inside a tool call that never returns is reminded once that age exceeds
-    // IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS, restoring the ~10-minute
-    // stall reminder for a truly hung session instead of suppressing it
-    // indefinitely.
-    const suppressedByInProgressToolCall =
-      snapshot.mainHasInProgressToolCall &&
-      mainSilentSeconds !== null &&
-      mainSilentSeconds < IN_PROGRESS_TOOL_CALL_MAX_SUPPRESS_SECONDS;
+    // The main-stall reminder is driven purely by silence: a session that has
+    // produced no assistant output for longer than the threshold is reminded
+    // regardless of whether its transcript tail is an in-progress tool_use. A
+    // session that merely looks busy (mid-tool-call) can in fact be stuck, so
+    // its apparent busyness MUST NOT suppress the reminder; the reminder queues
+    // cleanly into the session even when it is mid-turn. The only main-stall
+    // suppression is an unanswered owner call, which is a real wait on the owner.
     const mainTriggered =
       mainSilentSeconds !== null &&
       mainSilentSeconds >= thresholds.mainSilentThresholdSeconds &&
-      !suppressedByUnansweredOwnerCall &&
-      !suppressedByInProgressToolCall;
+      !suppressedByUnansweredOwnerCall;
     if (mainTriggered) {
       sections.push(
         this.messageComposer.composeMainStalledSection(mainSilentSeconds),
@@ -547,7 +503,6 @@ export class NotifySilentLiveSessionsUseCase {
       sessionName: snapshot.sessionName,
       message: sections.join('\n\n'),
       sectionLabels,
-      mainInputBusy: suppressedByInProgressToolCall,
     };
   };
 }