github-issue-tower-defence-management 1.128.0 → 1.128.1

package/src/adapter/entry-points/console/ui/src/features/console/lib/consoleApi.test.ts

@@ -4,9 +4,6 @@ import {
   postConsoleReviewComment,
 } from './consoleApi';
 
-const appendToken = (url: string): string =>
-  url.includes('?') ? `${url}&k=token` : `${url}?k=token`;
-
 const mockFetchOnce = (body: unknown, ok = true): jest.Mock => {
   const fetchMock = jest.fn().mockResolvedValue({
     ok,
@@ -29,19 +26,19 @@ const mockFetchFailureOnce = (status: number, rawBody: string): jest.Mock => {
 };
 
 describe('createConsoleApiClient', () => {
-  it('reads the item body and appends the token to the url query', async () => {
+  it('reads the item body from the api root without a token query', async () => {
     const fetchMock = mockFetchOnce({ body: '# Title' });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const body = await client.fetchItemBody('https://github.com/o/r/issues/1');
     expect(body).toBe('# Title');
     const requested = fetchMock.mock.calls[0][0] as string;
     expect(requested).toContain('/api/itembody?url=');
-    expect(requested).toContain('&k=token');
+    expect(requested).not.toContain('k=');
   });
 
   it('anchors every read endpoint at the server root regardless of route', async () => {
     const readers: ((url: string) => Promise<unknown>)[] = [];
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     readers.push((url) => client.fetchItemBody(url));
     readers.push((url) => client.fetchComments(url));
     readers.push((url) => client.fetchPrFiles(url));
@@ -75,7 +72,7 @@ describe('createConsoleApiClient', () => {
         { author: 'a', body: 'hello', createdAt: '2026-06-19T00:00:00.000Z' },
       ],
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const comments = await client.fetchComments(
       'https://github.com/o/r/issues/1',
     );
@@ -91,14 +88,14 @@ describe('createConsoleApiClient', () => {
         { filename: 'b.ts', additions: 9, deletions: 0, status: 'added' },
       ],
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const files = await client.fetchPrFiles('https://github.com/o/r/pull/1');
     expect(files.map((file) => file.path)).toEqual(['a.ts', 'b.ts']);
   });
 
   it('returns no files when the response files array is null', async () => {
     mockFetchOnce({ files: null });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     expect(await client.fetchPrFiles('https://github.com/o/r/pull/1')).toEqual(
       [],
     );
@@ -111,7 +108,7 @@ describe('createConsoleApiClient', () => {
       isPullRequest: true,
       title: 'Decorate PR links',
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     expect(
       await client.fetchIssueState('https://github.com/o/r/pull/1'),
     ).toEqual({
@@ -124,7 +121,7 @@ describe('createConsoleApiClient', () => {
 
   it('defaults the title to an empty string when absent', async () => {
     mockFetchOnce({ state: 'open', merged: false, isPullRequest: false });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     expect(
       await client.fetchIssueState('https://github.com/o/r/issues/1'),
     ).toEqual({
@@ -146,7 +143,7 @@ describe('createConsoleApiClient', () => {
         },
       ],
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const commits = await client.fetchPrCommits(
       'https://github.com/o/r/pull/1',
     );
@@ -177,7 +174,7 @@ describe('createConsoleApiClient', () => {
         },
       ],
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const related = await client.fetchRelatedPrs(
       'https://github.com/o/r/issues/1',
     );
@@ -198,7 +195,7 @@ describe('createConsoleApiClient', () => {
         missingRequiredCheckNames: ['build', 'test'],
       },
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     expect(
       await client.fetchPullRequestStatus('https://github.com/o/r/pull/1'),
     ).toEqual({
@@ -223,7 +220,7 @@ describe('createConsoleApiClient', () => {
         missingRequiredCheckNames: [],
       },
     });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     const status = await client.fetchPullRequestStatus(
       'https://github.com/o/r/pull/1',
     );
@@ -232,7 +229,7 @@ describe('createConsoleApiClient', () => {
 
   it('returns a not-found pull request status when the server reports none', async () => {
     mockFetchOnce({ found: false, status: null });
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     expect(
       await client.fetchPullRequestStatus('https://github.com/o/r/pull/1'),
     ).toEqual({
@@ -248,7 +245,7 @@ describe('createConsoleApiClient', () => {
 
   it('throws on a non-ok response', async () => {
     mockFetchOnce({}, false);
-    const client = createConsoleApiClient(appendToken);
+    const client = createConsoleApiClient();
     await expect(
       client.fetchComments('https://github.com/o/r/issues/1'),
     ).rejects.toThrow('HTTP 500');
@@ -256,21 +253,21 @@ describe('createConsoleApiClient', () => {
 });
 
 describe('postConsoleOperation', () => {
-  it('posts a JSON body and appends the token', async () => {
+  it('posts a JSON body to the operation endpoint', async () => {
     const fetchMock = mockFetchOnce({ ok: true });
-    await postConsoleOperation(appendToken, '/api/review', {
+    await postConsoleOperation('/api/review', {
       pjcode: 'umino',
       action: 'approve',
       prUrl: 'https://github.com/o/r/pull/1',
       projectItemId: 'PVTI_1',
     });
     const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('/api/review?k=token');
+    expect(url).toBe('/api/review');
     expect(init).toMatchObject({ method: 'POST' });
   });
 
   const failingReview = (): Promise<void> =>
-    postConsoleOperation(appendToken, '/api/review', {
+    postConsoleOperation('/api/review', {
       pjcode: 'umino',
       action: 'approve',
       prUrl: 'https://github.com/o/r/pull/1',
@@ -301,7 +298,7 @@ describe('postConsoleOperation', () => {
 describe('postConsoleReviewComment', () => {
   it('posts the inline review comment body to the reviewcomment endpoint', async () => {
     const fetchMock = mockFetchOnce({ ok: true });
-    await postConsoleReviewComment(appendToken, {
+    await postConsoleReviewComment({
       pjcode: 'umino',
       url: 'https://github.com/o/r/pull/1',
       path: 'src/index.ts',
@@ -310,7 +307,7 @@ describe('postConsoleReviewComment', () => {
       body: 'Consider extracting this into a helper.',
     });
     const [url, init] = fetchMock.mock.calls[0];
-    expect(url).toBe('/api/reviewcomment?k=token');
+    expect(url).toBe('/api/reviewcomment');
     expect(init).toMatchObject({ method: 'POST' });
     expect(JSON.parse((init as { body: string }).body)).toEqual({
       pjcode: 'umino',
@@ -331,7 +328,7 @@ describe('postConsoleReviewComment', () => {
       }),
     );
     await expect(
-      postConsoleReviewComment(appendToken, {
+      postConsoleReviewComment({
         pjcode: 'umino',
         url: 'https://github.com/o/r/pull/1',
         path: 'src/index.ts',

package/src/adapter/entry-points/console/ui/src/features/console/lib/consoleApi.ts

@@ -57,8 +57,6 @@ export type ConsoleReviewCommentRequest = {
   body: string;
 };
 
-type AppendToken = (url: string) => string;
-
 const isRecord = (value: unknown): value is Record<string, unknown> =>
   value !== null && typeof value === 'object' && !Array.isArray(value);
 
@@ -71,14 +69,12 @@ const getNumber = (value: unknown): number =>
 const getBoolean = (value: unknown): boolean => value === true;
 
 const requestJson = async (
-  appendToken: AppendToken,
   apiPath: string,
   resourceUrl: string,
 ): Promise<unknown> => {
-  const target = appendToken(
+  const response = await fetch(
     `${apiPath}?url=${encodeURIComponent(resourceUrl)}`,
   );
-  const response = await fetch(target);
   if (!response.ok) {
     throw new Error(`HTTP ${response.status}`);
   }
@@ -207,27 +203,23 @@ const parseState = (payload: unknown): ConsoleIssueState => {
   };
 };
 
-export const createConsoleApiClient = (
-  appendToken: AppendToken,
-): ConsoleApiClient => ({
+export const createConsoleApiClient = (): ConsoleApiClient => ({
   fetchItemBody: async (url) => {
-    const payload = await requestJson(appendToken, '/api/itembody', url);
+    const payload = await requestJson('/api/itembody', url);
     return isRecord(payload) ? getString(payload.body) : '';
   },
   fetchComments: async (url) =>
-    parseComments(await requestJson(appendToken, '/api/comments', url)),
+    parseComments(await requestJson('/api/comments', url)),
   fetchPrFiles: async (url) =>
-    parseFiles(await requestJson(appendToken, '/api/prfiles', url)),
+    parseFiles(await requestJson('/api/prfiles', url)),
   fetchPrCommits: async (url) =>
-    parseCommits(await requestJson(appendToken, '/api/prcommits', url)),
+    parseCommits(await requestJson('/api/prcommits', url)),
   fetchRelatedPrs: async (url) =>
-    parseRelatedPrs(await requestJson(appendToken, '/api/relatedprs', url)),
+    parseRelatedPrs(await requestJson('/api/relatedprs', url)),
   fetchIssueState: async (url) =>
-    parseState(await requestJson(appendToken, '/api/issuetitle', url)),
+    parseState(await requestJson('/api/issuetitle', url)),
   fetchPullRequestStatus: async (url) =>
-    parsePullRequestStatus(
-      await requestJson(appendToken, '/api/pullrequeststatus', url),
-    ),
+    parsePullRequestStatus(await requestJson('/api/pullrequeststatus', url)),
 });
 
 const readOperationErrorReason = async (
@@ -249,11 +241,10 @@ const readOperationErrorReason = async (
 };
 
 export const postConsoleOperation = async (
-  appendToken: AppendToken,
   apiPath: string,
   body: ConsoleReviewRequest | ConsoleTriageRequest | ConsoleIntmuxRequest,
 ): Promise<void> => {
-  const response = await fetch(appendToken(apiPath), {
+  const response = await fetch(apiPath, {
     method: 'POST',
     headers: { 'Content-Type': 'application/json' },
     body: JSON.stringify(body),
@@ -283,10 +274,9 @@ const parsePostedComment = (payload: unknown): ConsoleComment => {
 };
 
 export const postConsoleComment = async (
-  appendToken: AppendToken,
   request: ConsoleCommentRequest,
 ): Promise<ConsoleComment> => {
-  const response = await fetch(appendToken(COMMENT_OPERATION_PATH), {
+  const response = await fetch(COMMENT_OPERATION_PATH, {
     method: 'POST',
     headers: { 'Content-Type': 'application/json' },
     body: JSON.stringify(request),
@@ -300,10 +290,9 @@ export const postConsoleComment = async (
 export const REVIEW_COMMENT_OPERATION_PATH = '/api/reviewcomment';
 
 export const postConsoleReviewComment = async (
-  appendToken: AppendToken,
   request: ConsoleReviewCommentRequest,
 ): Promise<void> => {
-  const response = await fetch(appendToken(REVIEW_COMMENT_OPERATION_PATH), {
+  const response = await fetch(REVIEW_COMMENT_OPERATION_PATH, {
     method: 'POST',
     headers: { 'Content-Type': 'application/json' },
     body: JSON.stringify(request),

package/src/adapter/entry-points/console/ui/src/features/console/lib/imageProxy.test.ts

@@ -27,31 +27,28 @@ describe('isProxyableImageUrl', () => {
 });
 
 describe('buildImageProxyUrl', () => {
-  it('encodes the source url and appends the token', () => {
+  it('encodes the source url without appending a token', () => {
     const src = 'https://github.com/user-attachments/assets/abc?x=1';
-    expect(buildImageProxyUrl(src, 'tk')).toBe(
-      `/api/img?url=${encodeURIComponent(src)}&k=tk`,
+    expect(buildImageProxyUrl(src)).toBe(
+      `/api/img?url=${encodeURIComponent(src)}`,
     );
   });
 
-  it('omits the token when it is null', () => {
+  it('does not include a token query parameter', () => {
     const src = 'https://github.com/user-attachments/assets/abc';
-    expect(buildImageProxyUrl(src, null)).toBe(
-      `/api/img?url=${encodeURIComponent(src)}`,
-    );
+    expect(buildImageProxyUrl(src)).not.toContain('k=');
   });
 });
 
 describe('rewriteGitHubImageSources', () => {
-  const buildProxyUrl = (src: string): string =>
-    buildImageProxyUrl(src, 'console-token');
+  const buildProxyUrl = (src: string): string => buildImageProxyUrl(src);
 
   it('rewrites an allow-listed github image src to the proxy url', () => {
     const githubSrc = 'https://github.com/user-attachments/assets/abc';
     const html = `<p><img src="${githubSrc}" alt="shot" /></p>`;
     const result = rewriteGitHubImageSources(html, buildProxyUrl);
     expect(result).toContain(`/api/img?url=${encodeURIComponent(githubSrc)}`);
-    expect(result).toContain('k=console-token');
+    expect(result).not.toContain('k=');
     expect(result).not.toContain(`src="${githubSrc}"`);
   });
 

package/src/adapter/entry-points/console/ui/src/features/console/lib/imageProxy.ts

@@ -6,15 +6,8 @@ export const isProxyableImageUrl = (src: string): boolean =>
 
 export type ImageProxyUrlBuilder = (src: string) => string;
 
-export const buildImageProxyUrl = (
-  src: string,
-  token: string | null,
-): string => {
-  if (token === null) {
-    return `/api/img?url=${encodeURIComponent(src)}`;
-  }
-  return `/api/img?url=${encodeURIComponent(src)}&k=${encodeURIComponent(token)}`;
-};
+export const buildImageProxyUrl = (src: string): string =>
+  `/api/img?url=${encodeURIComponent(src)}`;
 
 export const rewriteGitHubImageSources = (
   html: string,

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsoleItemDetailContainer.tsx

@@ -6,7 +6,6 @@ import { ConsoleOperationMenu } from '../components/operations/ConsoleOperationM
 import type { ConsoleCaches } from '../hooks/useConsoleCaches';
 import { useConsoleItemDetailData } from '../hooks/useConsoleItemDetailData';
 import type { ConsoleOperationsApi } from '../hooks/useConsoleOperations';
-import { useConsoleToken } from '../hooks/useConsoleToken';
 import { buildImageProxyUrl } from '../lib/imageProxy';
 import type { ConsoleActionKind } from '../logic/actionToast';
 import { resolveStoryColorEnum } from '../logic/grouping';
@@ -58,10 +57,9 @@ export const ConsoleItemDetailContainer = ({
   onQueueAction,
 }: ConsoleItemDetailContainerProps) => {
   const detail = useConsoleItemDetailData(caches, item);
-  const { token } = useConsoleToken();
   const resolveImageProxyUrl = useCallback(
-    (src: string): string => buildImageProxyUrl(src, token),
-    [token],
+    (src: string): string => buildImageProxyUrl(src),
+    [],
   );
   const renderReferenceLink = useCallback(
     (href: string, fallbackText: string) => (