npm - github-issue-tower-defence-management - Versions diffs - 1.122.1 → 1.122.2 - Mend

github-issue-tower-defence-management 1.122.1 → 1.122.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (16) hide show

package/bin/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-syKbd_lW.js"></script>
+    <script type="module" crossorigin src="/assets/index-CC-RYye2.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-D0RwhyOM.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.122.1",
+  "version": "1.122.2",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/consoleDataDelivery.test.ts CHANGED Viewed

@@ -129,6 +129,28 @@ describe('buildConsoleDataResponse', () => {
     });
   });
+  it('applies the done exclusion to the workflow-blocker list', () => {
+    writeJson('umino/workflow-blocker/list.json', {
+      pjcode: 'umino',
+      items: [
+        { projectItemId: 'PVTI_1', title: 'keep' },
+        { projectItemId: 'PVTI_2', title: 'processed blocker' },
+      ],
+    });
+    recordDoneProjectItemId(baseDir, 'umino', 'workflow-blocker', 'PVTI_2');
+    const response = buildConsoleDataResponse(baseDir, {
+      kind: 'list',
+      pjcode: 'umino',
+      tab: 'workflow-blocker',
+    });
+    expect(response.statusCode).toBe(200);
+    const parsed: unknown = JSON.parse(response.body);
+    expect(parsed).toEqual({
+      pjcode: 'umino',
+      items: [{ projectItemId: 'PVTI_1', title: 'keep' }],
+    });
+  });
   it('serves a list file without an items array unchanged', () => {
     writeJson('umino/prs/list.json', { pjcode: 'umino' });
     const response = buildConsoleDataResponse(baseDir, {

package/src/adapter/entry-points/console/consoleDoneStore.test.ts CHANGED Viewed

@@ -94,5 +94,13 @@ describe('consoleDoneStore', () => {
         ]);
       }
     });
+    it('includes the workflow-blocker tab so processed blockers are excluded', () => {
+      expect(CONSOLE_DONE_TAB_NAMES).toContain('workflow-blocker');
+      recordDoneProjectItemIdAcrossTabs(baseDir, 'umino', 'PVTI_7');
+      expect(
+        readDoneProjectItemIds(baseDir, 'umino', 'workflow-blocker'),
+      ).toEqual(['PVTI_7']);
+    });
   });
 });

package/src/adapter/entry-points/console/consoleDoneStore.ts CHANGED Viewed

@@ -72,6 +72,7 @@ export const recordDoneProjectItemId = (
 };
 export const CONSOLE_DONE_TAB_NAMES: string[] = [
+  'workflow-blocker',
   'prs',
   'triage',
   'unread',

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts CHANGED Viewed

@@ -1,12 +1,9 @@
 import {
   countPendingItems,
-  countTabPendingItems,
   filterPendingItems,
-  filterTabPendingItems,
   isOverlayEntryActed,
   overlayKeyForItem,
   overlayStorageKey,
-  tabIgnoresDoneOverlay,
   writeOverlayEntry,
 } from './overlay';
 import type { ConsoleListItem, ConsoleOverlay } from './types';
@@ -126,59 +123,29 @@ describe('filterPendingItems', () => {
   });
 });
-describe('tabIgnoresDoneOverlay', () => {
-  it('ignores the done overlay on the workflow-blocker tab', () => {
-    expect(tabIgnoresDoneOverlay('workflow-blocker')).toBe(true);
-  });
-  it('applies the done overlay on every other tab', () => {
-    expect(tabIgnoresDoneOverlay('prs')).toBe(false);
-    expect(tabIgnoresDoneOverlay('triage')).toBe(false);
-    expect(tabIgnoresDoneOverlay('unread')).toBe(false);
-    expect(tabIgnoresDoneOverlay('failed-preparation')).toBe(false);
-    expect(tabIgnoresDoneOverlay('todo-by-human')).toBe(false);
-  });
-});
-describe('countTabPendingItems', () => {
-  it('counts every workflow-blocker item even when all are marked done', () => {
+describe('workflow-blocker items are filtered by the done overlay like every other tab', () => {
+  it('subtracts a processed workflow-blocker item from the count', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
-      PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    expect(
-      countTabPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
-    ).toBe(2);
+    expect(countPendingItems([item(1), item(2)], overlay)).toBe(1);
   });
-  it('subtracts done items on tabs other than workflow-blocker', () => {
+  it('removes a processed workflow-blocker item from the list', () => {
     const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'prs', done: true },
+      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    expect(countTabPendingItems([item(1), item(2)], overlay, 'prs')).toBe(1);
+    const result = filterPendingItems([item(1), item(2)], overlay);
+    expect(result.map((entry) => entry.number)).toEqual([2]);
   });
-});
-describe('filterTabPendingItems', () => {
-  it('keeps every workflow-blocker item even when all are marked done', () => {
+  it('drives the count to zero when every workflow-blocker item is processed', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
       PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    const result = filterTabPendingItems(
-      [item(1), item(2)],
-      overlay,
-      'workflow-blocker',
-    );
-    expect(result.map((entry) => entry.number)).toEqual([1, 2]);
-  });
-  it('drops done items on tabs other than workflow-blocker', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'prs', done: true },
-    };
-    const result = filterTabPendingItems([item(1), item(2)], overlay, 'prs');
-    expect(result.map((entry) => entry.number)).toEqual([2]);
+    expect(countPendingItems([item(1), item(2)], overlay)).toBe(0);
+    expect(filterPendingItems([item(1), item(2)], overlay)).toEqual([]);
   });
 });

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.ts CHANGED Viewed

@@ -30,23 +30,6 @@ export const filterPendingItems = (
     (item) => !isOverlayEntryActed(overlay[overlayKeyForItem(item)]),
   );
-export const tabIgnoresDoneOverlay = (tab: ConsoleTabName): boolean =>
-  tab === 'workflow-blocker';
-export const countTabPendingItems = (
-  items: ConsoleListItem[],
-  overlay: ConsoleOverlay,
-  tab: ConsoleTabName,
-): number =>
-  tabIgnoresDoneOverlay(tab) ? items.length : countPendingItems(items, overlay);
-export const filterTabPendingItems = (
-  items: ConsoleListItem[],
-  overlay: ConsoleOverlay,
-  tab: ConsoleTabName,
-): ConsoleListItem[] =>
-  tabIgnoresDoneOverlay(tab) ? items : filterPendingItems(items, overlay);
 export const writeOverlayEntry = (
   overlay: ConsoleOverlay,
   key: string,

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.test.tsx CHANGED Viewed

@@ -255,7 +255,7 @@ describe('ConsolePage', () => {
     expect(queryByText('project: umino')).toBeNull();
   });
-  it('keeps the workflow-blocker tab visible and lists its items even when every item is marked done in the overlay', async () => {
+  it('removes a processed workflow-blocker item from the list and decrements its tab badge, like every other tab', async () => {
     const blockerItems = [
       {
         number: 701,
@@ -311,7 +311,6 @@ describe('ConsolePage', () => {
       'pv_overlay_umino',
       JSON.stringify({
         PVTI_B1: { ts: 1, mode: 'workflow-blocker', done: true },
-        PVTI_B2: { ts: 1, mode: 'workflow-blocker', done: true },
       }),
     );
     window.history.replaceState(
@@ -320,17 +319,17 @@ describe('ConsolePage', () => {
       '/projects/umino/workflow-blocker?k=token',
     );
-    const { getByText } = render(<ConsolePage />);
+    const { getByText, queryByText } = render(<ConsolePage />);
     await waitFor(() => {
-      expect(getByText('Blocked deployment task')).toBeInTheDocument();
+      expect(getByText('Blocked rollout task')).toBeInTheDocument();
     });
-    expect(getByText('Blocked rollout task')).toBeInTheDocument();
+    expect(queryByText('Blocked deployment task')).toBeNull();
     const blockerTab = within(tabBar())
       .getByText('Workflow Blocker')
       .closest('a');
     expect(blockerTab).not.toBeNull();
     expect(blockerTab?.querySelector('.console-tab-badge')?.textContent).toBe(
-      '2',
+      '1',
     );
   });

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx CHANGED Viewed

@@ -26,8 +26,8 @@ import {
   previousPendingKeyBefore,
 } from '../logic/navigation';
 import {
-  countTabPendingItems,
-  filterTabPendingItems,
+  countPendingItems,
+  filterPendingItems,
   overlayKeyForItem,
 } from '../logic/overlay';
 import type { ConsoleSwipeDirection } from '../logic/swipe';
@@ -65,10 +65,9 @@ export const ConsolePage = () => {
       if (snapshot === null) {
         continue;
       }
-      result[tab.name] = countTabPendingItems(
+      result[tab.name] = countPendingItems(
         snapshot.items,
         overlayState.overlay,
-        tab.name,
       );
     }
     return result;
@@ -93,12 +92,8 @@ export const ConsolePage = () => {
     if (activeSnapshot === null) {
       return [];
     }
-    return filterTabPendingItems(
-      activeSnapshot.items,
-      overlayState.overlay,
-      activeTab,
-    );
-  }, [activeSnapshot, overlayState.overlay, activeTab]);
+    return filterPendingItems(activeSnapshot.items, overlayState.overlay);
+  }, [activeSnapshot, overlayState.overlay]);
   const orderedPendingKeys = useMemo(
     () => pendingItems.map((item) => overlayKeyForItem(item)),