github-issue-tower-defence-management 1.116.1 → 1.116.4

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.test.ts

@@ -526,6 +526,236 @@ describe('ApiV3CheerioRestIssueRepository', () => {
         ),
       ).rejects.toThrow('422');
     });
+
+    it("should surface GitHub's reason together with the status when the API rejects the approval", async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            message: 'Review Can not approve your own pull request',
+          }),
+          {
+            status: 422,
+            headers: { 'Content-Type': 'application/json' },
+          },
+        ),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.approvePullRequest(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+        ),
+      ).rejects.toThrow(
+        'Failed to approve PR https://github.com/HiromiShikata/test-repository/pull/42: HTTP 422 Review Can not approve your own pull request',
+      );
+    });
+  });
+
+  describe('closePullRequest', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
+    it("should surface GitHub's reason together with the status when the close fails", async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(JSON.stringify({ message: 'Not Found' }), {
+          status: 404,
+          headers: { 'Content-Type': 'application/json' },
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.closePullRequest(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+        ),
+      ).rejects.toThrow(
+        'Failed to close PR https://github.com/HiromiShikata/test-repository/pull/42: HTTP 404 Not Found',
+      );
+    });
+
+    it('should fall back to the status alone when the error body is not JSON', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response('Internal Server Error', {
+          status: 500,
+          statusText: 'Internal Server Error',
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.closePullRequest(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+        ),
+      ).rejects.toThrow(
+        'Failed to close PR https://github.com/HiromiShikata/test-repository/pull/42: HTTP 500',
+      );
+    });
+  });
+
+  describe('rate-limit-aware retry on console operations', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
+    it('retries a transient 403 rate-limit response and resolves the operation after a success', async () => {
+      const fetchSpy = jest
+        .spyOn(global, 'fetch')
+        .mockResolvedValueOnce(
+          new Response(JSON.stringify({ message: 'API rate limit exceeded' }), {
+            status: 403,
+            headers: { 'x-ratelimit-remaining': '0' },
+          }),
+        )
+        .mockResolvedValueOnce(
+          new Response(JSON.stringify({ state: 'closed' }), { status: 200 }),
+        );
+
+      const { repository, sleep } = createApiV3CheerioRestIssueRepository();
+      await repository.closeIssueByUrl(
+        'https://github.com/HiromiShikata/test-repository/issues/42',
+        'completed',
+      );
+
+      expect(fetchSpy).toHaveBeenCalledTimes(2);
+      expect(sleep).toHaveBeenCalledTimes(1);
+    });
+
+    it('retries a transient 429 secondary-rate-limit response and resolves the operation after a success', async () => {
+      const fetchSpy = jest
+        .spyOn(global, 'fetch')
+        .mockResolvedValueOnce(
+          new Response(
+            JSON.stringify({
+              message: 'You have exceeded a secondary rate limit',
+            }),
+            { status: 429, headers: { 'retry-after': '1' } },
+          ),
+        )
+        .mockResolvedValueOnce(
+          new Response(JSON.stringify({ state: 'open', merged: false }), {
+            status: 200,
+          }),
+        );
+
+      const { repository, sleep } = createApiV3CheerioRestIssueRepository();
+      const result = await repository.getIssueOrPullRequestState(
+        'https://github.com/HiromiShikata/test-repository/issues/42',
+      );
+
+      expect(result.state).toBe('open');
+      expect(fetchSpy).toHaveBeenCalledTimes(2);
+      expect(sleep).toHaveBeenCalledTimes(1);
+    });
+
+    it('does not retry a genuine permission 403 and surfaces a clear permission message', async () => {
+      const fetchSpy = jest.spyOn(global, 'fetch').mockResolvedValue(
+        new Response(
+          JSON.stringify({
+            message: 'Resource not accessible by integration',
+          }),
+          { status: 403, headers: { 'x-ratelimit-remaining': '4999' } },
+        ),
+      );
+
+      const { repository, sleep } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.closeIssueByUrl(
+          'https://github.com/HiromiShikata/test-repository/issues/42',
+          'completed',
+        ),
+      ).rejects.toThrow(
+        'Failed to close issue https://github.com/HiromiShikata/test-repository/issues/42: HTTP 403 permission denied, the token cannot perform this operation Resource not accessible by integration',
+      );
+
+      expect(fetchSpy).toHaveBeenCalledTimes(1);
+      expect(sleep).not.toHaveBeenCalled();
+    });
+
+    it('surfaces a clear rate-limit message including the reset time after the bounded retries are exhausted', async () => {
+      const resetEpochSeconds = 1700000000;
+      const fetchSpy = jest.spyOn(global, 'fetch').mockResolvedValue(
+        new Response(JSON.stringify({ message: 'API rate limit exceeded' }), {
+          status: 403,
+          headers: {
+            'x-ratelimit-remaining': '0',
+            'x-ratelimit-reset': String(resetEpochSeconds),
+          },
+        }),
+      );
+
+      const { repository, sleep } = createApiV3CheerioRestIssueRepository();
+      const expectedResetIso = new Date(resetEpochSeconds * 1000).toISOString();
+      await expect(
+        repository.closeIssueByUrl(
+          'https://github.com/HiromiShikata/test-repository/issues/42',
+          'completed',
+        ),
+      ).rejects.toThrow(
+        `Failed to close issue https://github.com/HiromiShikata/test-repository/issues/42: HTTP 403 GitHub rate limit exceeded, please retry shortly (resets at ${expectedResetIso})`,
+      );
+
+      expect(fetchSpy).toHaveBeenCalledTimes(4);
+      expect(sleep).toHaveBeenCalledTimes(3);
+    });
+  });
+
+  describe('requestChangesWithInlineComment', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
+    it("should surface GitHub's validation reason together with the status when the review POST fails", async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            message: 'Validation Failed',
+            errors: [{ message: 'path must be part of the diff' }],
+          }),
+          {
+            status: 422,
+            headers: { 'Content-Type': 'application/json' },
+          },
+        ),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.requestChangesWithInlineComment(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+          'src/index.ts',
+          'Please address this.',
+        ),
+      ).rejects.toThrow(
+        'Failed to request changes on PR https://github.com/HiromiShikata/test-repository/pull/42: HTTP 422 Validation Failed: path must be part of the diff',
+      );
+    });
+
+    it('should surface string entries in the GitHub errors array', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            message: 'Validation Failed',
+            errors: ['position is required'],
+          }),
+          {
+            status: 422,
+            headers: { 'Content-Type': 'application/json' },
+          },
+        ),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.requestChangesWithInlineComment(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+          'src/index.ts',
+          'Please address this.',
+        ),
+      ).rejects.toThrow(
+        'Failed to request changes on PR https://github.com/HiromiShikata/test-repository/pull/42: HTTP 422 Validation Failed: position is required',
+      );
+    });
   });
 
   describe('createPullRequestReviewComment', () => {
@@ -610,7 +840,9 @@ describe('ApiV3CheerioRestIssueRepository', () => {
           'RIGHT',
           'Please rename this variable.',
         ),
-      ).rejects.toThrow('Validation Failed: line must be part of the diff');
+      ).rejects.toThrow(
+        'HTTP 422 Validation Failed: line must be part of the diff',
+      );
     });
 
     it('should throw when the head commit cannot be fetched', async () => {
@@ -1511,6 +1743,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
     const graphqlProjectItemRepository = mock<GraphqlProjectItemRepository>();
     const localStorageCacheRepository = mock<LocalStorageCacheRepository>();
     const localStorageRepository = mock<LocalStorageRepository>();
+    const sleep = jest.fn().mockResolvedValue(undefined);
 
     const repository = new ApiV3CheerioRestIssueRepository(
       apiV3IssueRepository,
@@ -1518,6 +1751,8 @@ describe('ApiV3CheerioRestIssueRepository', () => {
       graphqlProjectItemRepository,
       localStorageCacheRepository,
       localStorageRepository,
+      'dummy',
+      sleep,
     );
     restIssueRepository.getIssue.mockResolvedValue({
       labels: [],
@@ -1534,6 +1769,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
       restIssueRepository,
       graphqlProjectItemRepository,
       localStorageCacheRepository,
+      sleep,
     };
   };
 });