npm - github-issue-tower-defence-management - Versions diffs - 1.111.2 → 1.111.3 - Mend

github-issue-tower-defence-management 1.111.2 → 1.111.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (10) hide show

package/bin/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-CT3t4Yje.js"></script>
+    <script type="module" crossorigin src="/assets/index-Bu5bQZyP.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-BPH6W1yn.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.111.2",
+  "version": "1.111.3",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts CHANGED Viewed

@@ -1,9 +1,12 @@
 import {
   countPendingItems,
+  countTabPendingItems,
   filterPendingItems,
+  filterTabPendingItems,
   isOverlayEntryActed,
   overlayKeyForItem,
   overlayStorageKey,
+  tabIgnoresDoneOverlay,
   writeOverlayEntry,
 } from './overlay';
 import type { ConsoleListItem, ConsoleOverlay } from './types';
@@ -123,6 +126,62 @@ describe('filterPendingItems', () => {
   });
 });
+describe('tabIgnoresDoneOverlay', () => {
+  it('ignores the done overlay on the workflow-blocker tab', () => {
+    expect(tabIgnoresDoneOverlay('workflow-blocker')).toBe(true);
+  });
+  it('applies the done overlay on every other tab', () => {
+    expect(tabIgnoresDoneOverlay('prs')).toBe(false);
+    expect(tabIgnoresDoneOverlay('triage')).toBe(false);
+    expect(tabIgnoresDoneOverlay('unread')).toBe(false);
+    expect(tabIgnoresDoneOverlay('failed-preparation')).toBe(false);
+    expect(tabIgnoresDoneOverlay('todo-by-human')).toBe(false);
+  });
+});
+describe('countTabPendingItems', () => {
+  it('counts every workflow-blocker item even when all are marked done', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
+      PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
+    };
+    expect(
+      countTabPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
+    ).toBe(2);
+  });
+  it('subtracts done items on tabs other than workflow-blocker', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: { ts: 100, mode: 'prs', done: true },
+    };
+    expect(countTabPendingItems([item(1), item(2)], overlay, 'prs')).toBe(1);
+  });
+});
+describe('filterTabPendingItems', () => {
+  it('keeps every workflow-blocker item even when all are marked done', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
+      PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
+    };
+    const result = filterTabPendingItems(
+      [item(1), item(2)],
+      overlay,
+      'workflow-blocker',
+    );
+    expect(result.map((entry) => entry.number)).toEqual([1, 2]);
+  });
+  it('drops done items on tabs other than workflow-blocker', () => {
+    const overlay: ConsoleOverlay = {
+      PVTI_1: { ts: 100, mode: 'prs', done: true },
+    };
+    const result = filterTabPendingItems([item(1), item(2)], overlay, 'prs');
+    expect(result.map((entry) => entry.number)).toEqual([2]);
+  });
+});
 describe('writeOverlayEntry', () => {
   it('stamps the timestamp and mode on write', () => {
     const next = writeOverlayEntry({}, 'PVTI_1', { done: true }, 'prs', 1234);

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.ts CHANGED Viewed

@@ -30,6 +30,23 @@ export const filterPendingItems = (
     (item) => !isOverlayEntryActed(overlay[overlayKeyForItem(item)]),
   );
+export const tabIgnoresDoneOverlay = (tab: ConsoleTabName): boolean =>
+  tab === 'workflow-blocker';
+export const countTabPendingItems = (
+  items: ConsoleListItem[],
+  overlay: ConsoleOverlay,
+  tab: ConsoleTabName,
+): number =>
+  tabIgnoresDoneOverlay(tab) ? items.length : countPendingItems(items, overlay);
+export const filterTabPendingItems = (
+  items: ConsoleListItem[],
+  overlay: ConsoleOverlay,
+  tab: ConsoleTabName,
+): ConsoleListItem[] =>
+  tabIgnoresDoneOverlay(tab) ? items : filterPendingItems(items, overlay);
 export const writeOverlayEntry = (
   overlay: ConsoleOverlay,
   key: string,

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.test.tsx CHANGED Viewed

@@ -255,6 +255,85 @@ describe('ConsolePage', () => {
     expect(queryByText('project: umino')).toBeNull();
   });
+  it('keeps the workflow-blocker tab visible and lists its items even when every item is marked done in the overlay', async () => {
+    const blockerItems = [
+      {
+        number: 701,
+        title: 'Blocked deployment task',
+        url: 'https://github.com/o/r/issues/701',
+        repo: 'o/r',
+        nameWithOwner: 'o/r',
+        projectItemId: 'PVTI_B1',
+        itemId: 'PVTI_B1',
+        isPr: false,
+        story: 'TDPM Console port',
+        status: 'In Progress',
+        nextActionDate: null,
+        nextActionHour: null,
+        dependedIssueUrls: [],
+        labels: [],
+        createdAt: '2026-06-17T00:00:00.000Z',
+      },
+      {
+        number: 702,
+        title: 'Blocked rollout task',
+        url: 'https://github.com/o/r/issues/702',
+        repo: 'o/r',
+        nameWithOwner: 'o/r',
+        projectItemId: 'PVTI_B2',
+        itemId: 'PVTI_B2',
+        isPr: false,
+        story: 'TDPM Console port',
+        status: 'In Progress',
+        nextActionDate: null,
+        nextActionHour: null,
+        dependedIssueUrls: [],
+        labels: [],
+        createdAt: '2026-06-17T01:00:00.000Z',
+      },
+    ];
+    const fetchMock = jest.fn(async (url: string) => {
+      const listMatch = url.match(/\/projects\/[^/]+\/([^/]+)\/list\.json/);
+      if (listMatch !== null) {
+        return {
+          ok: true,
+          status: 200,
+          json: async () =>
+            listMatch[1] === 'workflow-blocker'
+              ? { ...listPayload('workflow-blocker'), items: blockerItems }
+              : listPayload(listMatch[1]),
+        };
+      }
+      return { ok: true, status: 200, json: async () => ({ body: '# body' }) };
+    });
+    global.fetch = fetchMock as unknown as typeof fetch;
+    localStorage.setItem(
+      'pv_overlay_umino',
+      JSON.stringify({
+        PVTI_B1: { ts: 1, mode: 'workflow-blocker', done: true },
+        PVTI_B2: { ts: 1, mode: 'workflow-blocker', done: true },
+      }),
+    );
+    window.history.replaceState(
+      {},
+      '',
+      '/projects/umino/workflow-blocker?k=token',
+    );
+    const { getByText } = render(<ConsolePage />);
+    await waitFor(() => {
+      expect(getByText('Blocked deployment task')).toBeInTheDocument();
+    });
+    expect(getByText('Blocked rollout task')).toBeInTheDocument();
+    const blockerTab = within(tabBar())
+      .getByText('Workflow Blocker')
+      .closest('a');
+    expect(blockerTab).not.toBeNull();
+    expect(blockerTab?.querySelector('.console-tab-badge')?.textContent).toBe(
+      '2',
+    );
+  });
   it('renders the failure toast in English without any Japanese characters', async () => {
     const fetchMock = jest.fn(
       async (url: string, init?: { method?: string }) => {

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx CHANGED Viewed

@@ -25,8 +25,8 @@ import {
   previousPendingKeyBefore,
 } from '../logic/navigation';
 import {
-  countPendingItems,
-  filterPendingItems,
+  countTabPendingItems,
+  filterTabPendingItems,
   overlayKeyForItem,
 } from '../logic/overlay';
 import type { ConsoleSwipeDirection } from '../logic/swipe';
@@ -64,9 +64,10 @@ export const ConsolePage = () => {
       if (snapshot === null) {
         continue;
       }
-      result[tab.name] = countPendingItems(
+      result[tab.name] = countTabPendingItems(
         snapshot.items,
         overlayState.overlay,
+        tab.name,
       );
     }
     return result;
@@ -86,8 +87,12 @@ export const ConsolePage = () => {
     if (activeSnapshot === null) {
       return [];
     }
-    return filterPendingItems(activeSnapshot.items, overlayState.overlay);
-  }, [activeSnapshot, overlayState.overlay]);
+    return filterTabPendingItems(
+      activeSnapshot.items,
+      overlayState.overlay,
+      activeTab,
+    );
+  }, [activeSnapshot, overlayState.overlay, activeTab]);
   const orderedPendingKeys = useMemo(
     () => pendingItems.map((item) => overlayKeyForItem(item)),