github-issue-tower-defence-management 1.104.0 → 1.104.2

package/src/domain/usecases/RevertNotReadyReviewQueueIssueUseCase.test.ts

@@ -79,7 +79,7 @@ const createMockIssue = (overrides: Partial<Issue> = {}): Issue => ({
   isInProgress: false,
   isClosed: false,
   createdAt: new Date(),
-  author: '',
+  author: 'owner',
   closingIssueReferenceUrls: [],
   ...overrides,
 });
@@ -93,7 +93,20 @@ const createMockPullRequest = (overrides: Partial<Issue> = {}): Issue =>
     ...overrides,
   });
 
-const createReadyPr = (url = 'https://github.com/user/repo/pull/1') => ({
+type RelatedPrLike = {
+  url: string;
+  isConflicted: boolean;
+  isPassedAllCiJob: boolean;
+  isCiStateSuccess: boolean;
+  isResolvedAllReviewComments: boolean;
+  isBranchOutOfDate: boolean;
+  missingRequiredCheckNames: string[];
+  isDraft?: boolean;
+};
+
+const createReadyPr = (
+  url = 'https://github.com/user/repo/pull/1',
+): RelatedPrLike => ({
   url,
   isConflicted: false,
   isPassedAllCiJob: true,
@@ -103,6 +116,37 @@ const createReadyPr = (url = 'https://github.com/user/repo/pull/1') => ({
   missingRequiredCheckNames: [],
 });
 
+// Builds the in-memory linkage the production code now relies on instead of the
+// per-issue findRelatedOpenPRs timeline query: each related pull request becomes
+// an open PR project item whose closingIssueReferenceUrls points at the AQC
+// issue, and getOpenPullRequest is routed by URL to return that PR's status.
+// This proves the review-readiness outcome is identical to the previous
+// findRelatedOpenPRs-based path while removing the per-issue timeline call.
+const linkRelatedOpenPrsToIssue = (
+  mockIssueRepository: {
+    getAllIssues: jest.Mock;
+    getOpenPullRequest: jest.Mock;
+  },
+  issue: Issue,
+  relatedPrs: RelatedPrLike[],
+): void => {
+  const prItems = relatedPrs.map((pr, index) =>
+    createMockPullRequest({
+      url: pr.url,
+      number: 1000 + index,
+      closingIssueReferenceUrls: [issue.url],
+    }),
+  );
+  mockIssueRepository.getAllIssues.mockResolvedValue({
+    issues: [issue, ...prItems],
+    cacheUsed: false,
+  });
+  const prByUrl = new Map(relatedPrs.map((pr) => [pr.url, pr]));
+  mockIssueRepository.getOpenPullRequest.mockImplementation((prUrl: string) =>
+    Promise.resolve(prByUrl.get(prUrl) ?? null),
+  );
+};
+
 describe('RevertNotReadyReviewQueueIssueUseCase', () => {
   let mockProjectRepository: {
     findProjectIdByUrl: jest.Mock;
@@ -171,6 +215,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -190,6 +235,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -204,11 +250,11 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         issues: [issue],
         cacheUsed: false,
       });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -235,12 +281,12 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         issues: [issue],
         cacheUsed: false,
       });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: ['story', 'chore', 'accounting'],
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -256,12 +302,12 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         issues: [issue],
         cacheUsed: false,
       });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: ['story', 'chore'],
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -277,11 +323,11 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         issues: [issue],
         cacheUsed: false,
       });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -304,12 +350,12 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         issues: [issue],
         cacheUsed: false,
       });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: null,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -323,17 +369,12 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
-        createReadyPr(),
-      ]);
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [createReadyPr()]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -344,17 +385,14 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         { ...createReadyPr(), isConflicted: true },
       ]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -376,11 +414,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         {
           ...createReadyPr(),
           isPassedAllCiJob: false,
@@ -391,6 +425,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -412,17 +447,14 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         { ...createReadyPr(), isResolvedAllReviewComments: false },
       ]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -444,17 +476,14 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         { ...createReadyPr(), isDraft: true },
       ]);
 
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -476,11 +505,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         createReadyPr('https://github.com/user/repo/pull/1'),
         createReadyPr('https://github.com/user/repo/pull/2'),
       ]);
@@ -488,6 +513,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -509,11 +535,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       const issue = createMockIssue({
         status: 'Awaiting Quality Check',
       });
-      mockIssueRepository.getAllIssues.mockResolvedValue({
-        issues: [issue],
-        cacheUsed: false,
-      });
-      mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+      linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
         {
           ...createReadyPr(),
           isPassedAllCiJob: false,
@@ -525,6 +547,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -542,17 +565,151 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       );
     });
 
-    describe('change-target label auto-approve', () => {
-      const setupReadyIssue = (labels: string[]) => {
+    describe('in-memory related-PR derivation (no per-issue timeline call)', () => {
+      it('should never call findRelatedOpenPRs while sweeping Awaiting Quality Check issues', async () => {
+        const readyIssue = createMockIssue({
+          status: 'Awaiting Quality Check',
+          url: 'https://github.com/user/repo/issues/1',
+        });
+        const notReadyIssue = createMockIssue({
+          status: 'Awaiting Quality Check',
+          number: 2,
+          url: 'https://github.com/user/repo/issues/2',
+        });
+        const readyPrItem = createMockPullRequest({
+          status: 'In Progress',
+          url: 'https://github.com/user/repo/pull/100',
+          number: 100,
+          closingIssueReferenceUrls: ['https://github.com/user/repo/issues/1'],
+        });
+        const conflictedPrItem = createMockPullRequest({
+          status: 'In Progress',
+          url: 'https://github.com/user/repo/pull/200',
+          number: 200,
+          closingIssueReferenceUrls: ['https://github.com/user/repo/issues/2'],
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [readyIssue, notReadyIssue, readyPrItem, conflictedPrItem],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockImplementation(
+          (prUrl: string) => {
+            if (prUrl === 'https://github.com/user/repo/pull/100') {
+              return Promise.resolve(createReadyPr(prUrl));
+            }
+            if (prUrl === 'https://github.com/user/repo/pull/200') {
+              return Promise.resolve({
+                ...createReadyPr(prUrl),
+                isConflicted: true,
+              });
+            }
+            return Promise.resolve(null);
+          },
+        );
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
+        });
+
+        expect(mockIssueRepository.findRelatedOpenPRs).not.toHaveBeenCalled();
+        expect(mockIssueRepository.getOpenPullRequest).toHaveBeenCalledWith(
+          'https://github.com/user/repo/pull/100',
+        );
+        expect(mockIssueRepository.getOpenPullRequest).toHaveBeenCalledWith(
+          'https://github.com/user/repo/pull/200',
+        );
+        expect(mockIssueRepository.updateStatus).toHaveBeenCalledTimes(1);
+        expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
+          mockProject,
+          notReadyIssue,
+          'awaiting-workspace-id',
+        );
+        expect(mockIssueCommentRepository.createComment).toHaveBeenCalledWith(
+          notReadyIssue,
+          expect.stringContaining('PULL_REQUEST_CONFLICTED'),
+        );
+      });
+
+      it('should match a PR to its issue via closingIssueReferenceUrls even when the PR item is listed before the issue', async () => {
         const issue = createMockIssue({
           status: 'Awaiting Quality Check',
-          labels,
+          url: 'https://github.com/user/repo/issues/42',
+          number: 42,
+        });
+        const prItem = createMockPullRequest({
+          status: 'In Progress',
+          url: 'https://github.com/user/repo/pull/77',
+          number: 77,
+          closingIssueReferenceUrls: ['https://github.com/user/repo/issues/42'],
         });
         mockIssueRepository.getAllIssues.mockResolvedValue({
-          issues: [issue],
+          issues: [prItem, issue],
           cacheUsed: false,
         });
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue(
+          createReadyPr('https://github.com/user/repo/pull/77'),
+        );
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
+        });
+
+        expect(mockIssueRepository.getOpenPullRequest).toHaveBeenCalledWith(
+          'https://github.com/user/repo/pull/77',
+        );
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should not match a closed PR even when its closingIssueReferenceUrls points at the issue', async () => {
+        const issue = createMockIssue({
+          status: 'Awaiting Quality Check',
+          url: 'https://github.com/user/repo/issues/9',
+          number: 9,
+        });
+        const closedPrItem = createMockPullRequest({
+          status: 'In Progress',
+          url: 'https://github.com/user/repo/pull/9',
+          number: 9,
+          isClosed: true,
+          state: 'CLOSED',
+          closingIssueReferenceUrls: ['https://github.com/user/repo/issues/9'],
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [issue, closedPrItem],
+          cacheUsed: false,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
+        });
+
+        expect(mockIssueRepository.getOpenPullRequest).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
+          mockProject,
+          issue,
+          'awaiting-workspace-id',
+        );
+        expect(mockIssueCommentRepository.createComment).toHaveBeenCalledWith(
+          issue,
+          expect.stringContaining('PULL_REQUEST_NOT_FOUND'),
+        );
+      });
+    });
+
+    describe('change-target label auto-approve', () => {
+      const setupReadyIssue = (labels: string[]) => {
+        const issue = createMockIssue({
+          status: 'Awaiting Quality Check',
+          labels,
+        });
+        linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
           createReadyPr(),
         ]);
         return issue;
@@ -562,6 +719,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
         });
 
       it('should not approve PR when issue has no change-target label', async () => {
@@ -684,11 +842,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           status: 'Awaiting Quality Check',
           labels: ['change-target:src/domain'],
         });
-        mockIssueRepository.getAllIssues.mockResolvedValue({
-          issues: [issue],
-          cacheUsed: false,
-        });
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
+        linkRelatedOpenPrsToIssue(mockIssueRepository, issue, []);
 
         await runCycle();
 
@@ -708,11 +862,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           status: 'Awaiting Quality Check',
           labels: ['change-target:src/domain'],
         });
-        mockIssueRepository.getAllIssues.mockResolvedValue({
-          issues: [issue],
-          cacheUsed: false,
-        });
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+        linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
           { ...createReadyPr(), isConflicted: true },
         ]);
 
@@ -734,11 +884,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           status: 'Awaiting Quality Check',
           labels: ['llm-agent', 'change-target:src/domain'],
         });
-        mockIssueRepository.getAllIssues.mockResolvedValue({
-          issues: [issue],
-          cacheUsed: false,
-        });
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([
+        linkRelatedOpenPrsToIssue(mockIssueRepository, issue, [
           createReadyPr(),
         ]);
 
@@ -773,6 +919,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         await useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
           changeTargetPathAliases: {
             adapters: 'src/domain/usecases/adapter-interfaces',
           },
@@ -792,6 +939,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         await useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
           changeTargetPathAliases: {
             adapters: 'src/domain/usecases/adapter-interfaces',
           },
@@ -815,6 +963,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -836,6 +985,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -856,6 +1006,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -876,6 +1027,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -899,6 +1051,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -938,6 +1091,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -972,6 +1126,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1008,6 +1163,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1042,6 +1198,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1073,6 +1230,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1110,6 +1268,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1154,6 +1313,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -1223,7 +1383,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         );
       });
 
-      it('should act on an Unread pull request authored by a dependency-update bot not in allowedIssueAuthors', async () => {
+      it('should skip an Unread pull request authored by a dependency-update bot not in allowedIssueAuthors', async () => {
         const pullRequest = createMockPullRequest({
           status: 'Unread',
           author: 'dependabot[bot]',
@@ -1243,6 +1403,31 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           allowedIssueAuthors: ['owner'],
         });
 
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should act on a dependency-update bot only when it is explicitly listed in allowedIssueAuthors', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'dependabot[bot]',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner', 'dependabot[bot]'],
+        });
+
         expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
           mockProject,
           pullRequest,
@@ -1254,7 +1439,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         );
       });
 
-      it('should act on every author when allowedIssueAuthors is null', async () => {
+      it('should process no author when allowedIssueAuthors is null', async () => {
         const pullRequest = createMockPullRequest({
           status: 'Unread',
           author: 'outside-contributor',
@@ -1274,15 +1459,58 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           allowedIssueAuthors: null,
         });
 
-        expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
-          mockProject,
-          pullRequest,
-          'awaiting-workspace-id',
-        );
-        expect(mockIssueCommentRepository.createComment).toHaveBeenCalledWith(
-          pullRequest,
-          expect.stringContaining('Auto Status Check: REJECTED'),
-        );
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should process no author when allowedIssueAuthors is undefined', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'owner',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+        });
+
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should process no author when allowedIssueAuthors is an empty list', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'owner',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: [],
+        });
+
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
       });
     });
   });