github-issue-tower-defence-management 1.104.0 → 1.104.1

package/bin/domain/usecases/resolveAllowedIssueAuthors.js

@@ -0,0 +1,8 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.resolveAllowedIssueAuthors = void 0;
+const resolveAllowedIssueAuthors = (source) => {
+    return source.topLevel ?? source.startPreparation ?? null;
+};
+exports.resolveAllowedIssueAuthors = resolveAllowedIssueAuthors;
+//# sourceMappingURL=resolveAllowedIssueAuthors.js.map

package/bin/domain/usecases/resolveAllowedIssueAuthors.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"resolveAllowedIssueAuthors.js","sourceRoot":"","sources":["../../../src/domain/usecases/resolveAllowedIssueAuthors.ts"],"names":[],"mappings":";;;AAAO,MAAM,0BAA0B,GAAG,CAAC,MAG1C,EAAmB,EAAE;IACpB,OAAO,MAAM,CAAC,QAAQ,IAAI,MAAM,CAAC,gBAAgB,IAAI,IAAI,CAAC;AAC5D,CAAC,CAAC;AALW,QAAA,0BAA0B,8BAKrC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.104.0",
+  "version": "1.104.1",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/handlers/HandleScheduledEventUseCaseHandler.test.ts

@@ -384,6 +384,42 @@ allowedIssueAuthors: 'user1, user2, user3'
         projectUrl: validConfig.projectUrl,
       });
     });
+
+    it('should accept a top-level allowedIssueAuthors from the YAML config and pass it through', async () => {
+      mockFetchReturningReadme(null);
+      const configWithTopLevelAllowedIssueAuthors = {
+        ...validConfig,
+        allowedIssueAuthors: ['owner', 'dependabot[bot]'],
+      };
+      jest
+        .mocked(fs.readFileSync)
+        .mockReturnValue(YAML.stringify(configWithTopLevelAllowedIssueAuthors));
+
+      const handler = new HandleScheduledEventUseCaseHandler();
+      await handler.handle('config.yml', false);
+
+      expect(capturedRunInputs[0][0]).toMatchObject({
+        allowedIssueAuthors: ['owner', 'dependabot[bot]'],
+      });
+    });
+
+    it('should split a comma-separated top-level allowedIssueAuthors string from the YAML config', async () => {
+      mockFetchReturningReadme(null);
+      const configWithCommaSeparatedAuthors = {
+        ...validConfig,
+        allowedIssueAuthors: 'owner, umino-bot ,dependabot[bot]',
+      };
+      jest
+        .mocked(fs.readFileSync)
+        .mockReturnValue(YAML.stringify(configWithCommaSeparatedAuthors));
+
+      const handler = new HandleScheduledEventUseCaseHandler();
+      await handler.handle('config.yml', false);
+
+      expect(capturedRunInputs[0][0]).toMatchObject({
+        allowedIssueAuthors: ['owner', 'umino-bot', 'dependabot[bot]'],
+      });
+    });
   });
 
   describe('Claude OAuth token rotation wiring', () => {

package/src/adapter/entry-points/handlers/HandleScheduledEventUseCaseHandler.ts

@@ -67,7 +67,11 @@ export class HandleScheduledEventUseCaseHandler {
   } | null> => {
     const configFileContent = fs.readFileSync(configFilePath, 'utf8');
     const input: unknown = YAML.parse(configFileContent);
-    type inputType = Parameters<HandleScheduledEventUseCase['run']>[0] & {
+    type inputType = Omit<
+      Parameters<HandleScheduledEventUseCase['run']>[0],
+      'allowedIssueAuthors'
+    > & {
+      allowedIssueAuthors?: string | string[] | null;
       claudeCodeOauthTokenListJsonPath?: string;
       consoleDataOutputDir?: string;
       workflowBlockerStoryName?: string;
@@ -111,8 +115,26 @@ export class HandleScheduledEventUseCaseHandler {
       ? parseProjectReadmeConfig(readme, input.projectUrl)
       : {};
 
+    const normalizeAllowedIssueAuthors = (
+      value: string | string[] | null | undefined,
+    ): string[] | null => {
+      if (value === null || value === undefined) {
+        return null;
+      }
+      if (Array.isArray(value)) {
+        return value;
+      }
+      return value
+        .split(',')
+        .map((s) => s.trim())
+        .filter(Boolean);
+    };
+
     const mergedInput = {
       ...input,
+      allowedIssueAuthors: normalizeAllowedIssueAuthors(
+        input.allowedIssueAuthors,
+      ),
       allowIssueCacheMinutes:
         readmeConfig.allowIssueCacheMinutes ?? input.allowIssueCacheMinutes,
       claudeCodeOauthTokenListJsonPath:

package/src/domain/usecases/HandleScheduledEventUseCase.test.ts

@@ -379,6 +379,115 @@ describe('HandleScheduledEventUseCase', () => {
       ).toHaveBeenCalledTimes(1);
     });
 
+    it('should pass a top-level allowedIssueAuthors to revertNotReadyReviewQueueIssueUseCase', async () => {
+      const input = {
+        projectName: 'test-project',
+        org: 'test-org',
+        projectUrl: 'https://github.com/test-org/test-project',
+        manager: 'test-manager',
+        workingReport: {
+          repo: 'test-repo',
+          members: ['member1'],
+          spreadsheetUrl: 'https://docs.google.com/spreadsheets/test',
+        },
+        urlOfStoryView: 'https://github.com/test-org/test-project/issues',
+        disabled: false,
+        allowIssueCacheMinutes: 60,
+        allowedIssueAuthors: ['top-level-author'],
+      };
+
+      mockProjectRepository.getProject.mockResolvedValue(mock<Project>());
+      await useCase.run(input);
+
+      expect(
+        mockRevertNotReadyReviewQueueIssueUseCase.run,
+      ).toHaveBeenCalledWith(
+        expect.objectContaining({
+          allowedIssueAuthors: ['top-level-author'],
+        }),
+      );
+    });
+
+    it('should prefer a top-level allowedIssueAuthors over the startPreparation one', async () => {
+      const input = {
+        projectName: 'test-project',
+        org: 'test-org',
+        projectUrl: 'https://github.com/test-org/test-project',
+        manager: 'test-manager',
+        workingReport: {
+          repo: 'test-repo',
+          members: ['member1'],
+          spreadsheetUrl: 'https://docs.google.com/spreadsheets/test',
+        },
+        urlOfStoryView: 'https://github.com/test-org/test-project/issues',
+        disabled: false,
+        allowIssueCacheMinutes: 60,
+        allowedIssueAuthors: ['top-level-author'],
+        startPreparation: {
+          defaultAgentName: 'agent1',
+          configFilePath: '/path/to/config.yml',
+          maximumPreparingIssuesCount: null,
+          allowedIssueAuthors: ['nested-author'],
+        },
+      };
+
+      mockProjectRepository.getProject.mockResolvedValue(mock<Project>());
+      mockStartPreparationUseCase.run.mockResolvedValue({
+        rotationOrder: null,
+      });
+      await useCase.run(input);
+
+      expect(
+        mockRevertNotReadyReviewQueueIssueUseCase.run,
+      ).toHaveBeenCalledWith(
+        expect.objectContaining({
+          allowedIssueAuthors: ['top-level-author'],
+        }),
+      );
+      expect(mockStartPreparationUseCase.run).toHaveBeenCalledWith(
+        expect.objectContaining({
+          allowedIssueAuthors: ['top-level-author'],
+        }),
+      );
+    });
+
+    it('should fall back to startPreparation allowedIssueAuthors when no top-level value is set', async () => {
+      const input = {
+        projectName: 'test-project',
+        org: 'test-org',
+        projectUrl: 'https://github.com/test-org/test-project',
+        manager: 'test-manager',
+        workingReport: {
+          repo: 'test-repo',
+          members: ['member1'],
+          spreadsheetUrl: 'https://docs.google.com/spreadsheets/test',
+        },
+        urlOfStoryView: 'https://github.com/test-org/test-project/issues',
+        disabled: false,
+        allowIssueCacheMinutes: 60,
+        startPreparation: {
+          defaultAgentName: 'agent1',
+          configFilePath: '/path/to/config.yml',
+          maximumPreparingIssuesCount: null,
+          allowedIssueAuthors: ['nested-author'],
+        },
+      };
+
+      mockProjectRepository.getProject.mockResolvedValue(mock<Project>());
+      mockStartPreparationUseCase.run.mockResolvedValue({
+        rotationOrder: null,
+      });
+      await useCase.run(input);
+
+      expect(
+        mockRevertNotReadyReviewQueueIssueUseCase.run,
+      ).toHaveBeenCalledWith(
+        expect.objectContaining({
+          allowedIssueAuthors: ['nested-author'],
+        }),
+      );
+    });
+
     it('should invoke UpdateRateLimitCacheUseCase before StartPreparationUseCase when startPreparation is configured', async () => {
       const callOrder: string[] = [];
       mockUpdateRateLimitCacheUseCase.run.mockImplementation(async () => {

package/src/domain/usecases/HandleScheduledEventUseCase.ts

@@ -27,6 +27,7 @@ import {
 import { RevertOrphanedPreparationUseCase } from './RevertOrphanedPreparationUseCase';
 import { RevertNotReadyReviewQueueIssueUseCase } from './RevertNotReadyReviewQueueIssueUseCase';
 import { resolveLabelsAsLlmAgentName } from './resolveLabelsAsLlmAgentName';
+import { resolveAllowedIssueAuthors } from './resolveAllowedIssueAuthors';
 import { SetupTowerDefenceProjectUseCase } from './SetupTowerDefenceProjectUseCase';
 import { UpdateRateLimitCacheUseCase } from './UpdateRateLimitCacheUseCase';
 import {
@@ -86,6 +87,7 @@ export class HandleScheduledEventUseCase {
     allowIssueCacheMinutes: number;
     labelsAsLlmAgentName?: string[] | null;
     changeTargetPathAliases?: Record<string, string> | null;
+    allowedIssueAuthors?: string[] | null;
     startPreparation?: {
       defaultAgentName: string;
       defaultLlmModelName?: string | null;
@@ -293,12 +295,16 @@ ${JSON.stringify(e)}
       topLevel: input.labelsAsLlmAgentName,
       startPreparation: input.startPreparation?.labelsAsLlmAgentName,
     });
+    const allowedIssueAuthors = resolveAllowedIssueAuthors({
+      topLevel: input.allowedIssueAuthors,
+      startPreparation: input.startPreparation?.allowedIssueAuthors,
+    });
     await this.revertNotReadyReviewQueueIssueUseCase.run({
       projectUrl: input.projectUrl,
       allowIssueCacheMinutes: input.allowIssueCacheMinutes,
       labelsAsLlmAgentName,
       changeTargetPathAliases: input.changeTargetPathAliases,
-      allowedIssueAuthors: input.startPreparation?.allowedIssueAuthors ?? null,
+      allowedIssueAuthors,
     });
     if (this.dailySecurityScanUseCase !== null && input.dailySecurityScan) {
       await this.dailySecurityScanUseCase.run({
@@ -341,7 +347,7 @@ ${JSON.stringify(e)}
           input.startPreparation.maximumPreparingIssuesCount,
         utilizationPercentageThreshold:
           input.startPreparation.utilizationPercentageThreshold ?? 90,
-        allowedIssueAuthors: input.startPreparation.allowedIssueAuthors ?? null,
+        allowedIssueAuthors,
         codexHomeCandidates: input.startPreparation.codexHomeCandidates ?? null,
         allowIssueCacheMinutes: input.allowIssueCacheMinutes,
         labelsAsLlmAgentName,

package/src/domain/usecases/RevertNotReadyReviewQueueIssueUseCase.test.ts

@@ -79,7 +79,7 @@ const createMockIssue = (overrides: Partial<Issue> = {}): Issue => ({
   isInProgress: false,
   isClosed: false,
   createdAt: new Date(),
-  author: '',
+  author: 'owner',
   closingIssueReferenceUrls: [],
   ...overrides,
 });
@@ -171,6 +171,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -190,6 +191,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -209,6 +211,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -241,6 +244,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: ['story', 'chore', 'accounting'],
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -262,6 +266,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: ['story', 'chore'],
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -282,6 +287,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -310,6 +316,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
         labelsAsLlmAgentName: null,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -334,6 +341,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -355,6 +363,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -391,6 +400,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -423,6 +433,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -455,6 +466,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -488,6 +500,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -525,6 +538,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -562,6 +576,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
         });
 
       it('should not approve PR when issue has no change-target label', async () => {
@@ -773,6 +788,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         await useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
           changeTargetPathAliases: {
             adapters: 'src/domain/usecases/adapter-interfaces',
           },
@@ -792,6 +808,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         await useCase.run({
           projectUrl: 'https://github.com/users/user/projects/1',
           allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner'],
           changeTargetPathAliases: {
             adapters: 'src/domain/usecases/adapter-interfaces',
           },
@@ -815,6 +832,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -836,6 +854,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -856,6 +875,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -876,6 +896,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -899,6 +920,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -938,6 +960,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -972,6 +995,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1008,6 +1032,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1042,6 +1067,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1073,6 +1099,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1110,6 +1137,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
@@ -1154,6 +1182,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
       await useCase.run({
         projectUrl: 'https://github.com/users/user/projects/1',
         allowIssueCacheMinutes: 10,
+        allowedIssueAuthors: ['owner'],
       });
 
       expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
@@ -1223,7 +1252,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         );
       });
 
-      it('should act on an Unread pull request authored by a dependency-update bot not in allowedIssueAuthors', async () => {
+      it('should skip an Unread pull request authored by a dependency-update bot not in allowedIssueAuthors', async () => {
         const pullRequest = createMockPullRequest({
           status: 'Unread',
           author: 'dependabot[bot]',
@@ -1243,6 +1272,31 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           allowedIssueAuthors: ['owner'],
         });
 
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should act on a dependency-update bot only when it is explicitly listed in allowedIssueAuthors', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'dependabot[bot]',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: ['owner', 'dependabot[bot]'],
+        });
+
         expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
           mockProject,
           pullRequest,
@@ -1254,7 +1308,7 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
         );
       });
 
-      it('should act on every author when allowedIssueAuthors is null', async () => {
+      it('should process no author when allowedIssueAuthors is null', async () => {
         const pullRequest = createMockPullRequest({
           status: 'Unread',
           author: 'outside-contributor',
@@ -1274,15 +1328,58 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           allowedIssueAuthors: null,
         });
 
-        expect(mockIssueRepository.updateStatus).toHaveBeenCalledWith(
-          mockProject,
-          pullRequest,
-          'awaiting-workspace-id',
-        );
-        expect(mockIssueCommentRepository.createComment).toHaveBeenCalledWith(
-          pullRequest,
-          expect.stringContaining('Auto Status Check: REJECTED'),
-        );
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should process no author when allowedIssueAuthors is undefined', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'owner',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+        });
+
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
+      });
+
+      it('should process no author when allowedIssueAuthors is an empty list', async () => {
+        const pullRequest = createMockPullRequest({
+          status: 'Unread',
+          author: 'owner',
+        });
+        mockIssueRepository.getAllIssues.mockResolvedValue({
+          issues: [pullRequest],
+          cacheUsed: false,
+        });
+        mockIssueRepository.getOpenPullRequest.mockResolvedValue({
+          ...createReadyPr(),
+          isConflicted: true,
+        });
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          allowedIssueAuthors: [],
+        });
+
+        expect(mockIssueRepository.updateStatus).not.toHaveBeenCalled();
+        expect(mockIssueRepository.updateStory).not.toHaveBeenCalled();
+        expect(mockIssueCommentRepository.createComment).not.toHaveBeenCalled();
       });
     });
   });

package/src/domain/usecases/RevertNotReadyReviewQueueIssueUseCase.ts

@@ -9,17 +9,15 @@ import {
   DEFAULT_STATUS_NAME,
 } from '../entities/WorkflowStatus';
 
-const DEPENDENCY_UPDATE_BOT_AUTHORS = ['dependabot[bot]', 'renovate[bot]'];
-
 const isAuthorAuthorizedForAutoStatusCheck = (
   author: string,
-  allowedIssueAuthors: string[] | null,
+  allowedIssueAuthors: string[] | null | undefined,
 ): boolean => {
-  if (DEPENDENCY_UPDATE_BOT_AUTHORS.includes(author)) {
-    return true;
+  if (allowedIssueAuthors === null || allowedIssueAuthors === undefined) {
+    return false;
   }
-  if (allowedIssueAuthors === null) {
-    return true;
+  if (allowedIssueAuthors.length === 0) {
+    return false;
   }
   return allowedIssueAuthors.includes(author);
 };