gitbash 1.3.3 → 1.3.4

package/commands/cleanstash.sh

@@ -126,9 +126,9 @@ EOF
     # 4. Extract stash IDs safely
     # -----------------------------
     local stash_ids=()
+    local stash_id line
     while IFS= read -r line; do
-        local stash_id
-        stash_id=$(echo "$line" | grep -o 'stash@{[0-9]\+}')
+        stash_id=$(echo "$line" | grep -o 'stash@{[0-9]\+}' || true)
         if [[ -n "$stash_id" ]]; then
             stash_ids+=("$stash_id")
         fi
@@ -157,6 +157,7 @@ EOF
             echo "Deleting stashes..."
             # Sort by stash number in descending order to delete safely
             local sorted_ids=()
+            local id
             while IFS= read -r id; do
                 sorted_ids+=("$id")
             done < <(printf '%s\n' "${stash_ids[@]}" | sort -t'{' -k2 -rn)

package/commands/cleanup.sh

@@ -163,6 +163,10 @@ EOF
     stale_branches=()
     recent_branches=()
 
+    # Variables for loop (declared once to avoid zsh output on redeclaration)
+    local last_commit_ts relative_date author_email author_name
+    local has_remote configured_upstream entry
+
     # Process each local branch
     while IFS= read -r branch; do
         # Skip base branch
@@ -170,24 +174,22 @@ EOF
         [[ -z "$branch" ]] && continue
 
         # Get last commit info for all branches
-        local last_commit_ts relative_date author_email author_name
         last_commit_ts=$(git log -1 --format='%ct' "$branch" 2>/dev/null)
         relative_date=$(git log -1 --format='%cr' "$branch" 2>/dev/null)
         author_email=$(git log -1 --format='%ae' "$branch" 2>/dev/null)
         author_name=$(git log -1 --format='%an' "$branch" 2>/dev/null)
         
         # Check if remote branch exists
-        local has_remote=false
+        has_remote=false
         if echo "$remote_branches" | grep -qx "$branch"; then
             has_remote=true
         fi
 
         # Check if it HAD an upstream (was pushed before)
-        local configured_upstream
         configured_upstream=$(git config "branch.$branch.remote" 2>/dev/null)
 
         # Entry format: timestamp|branch|relative_date|author_email|author_name
-        local entry="$last_commit_ts|$branch|$relative_date|$author_email|$author_name"
+        entry="$last_commit_ts|$branch|$relative_date|$author_email|$author_name"
 
         if [[ "$has_remote" == false && -n "$configured_upstream" ]]; then
             # Had upstream but remote is gone = merged and deleted remotely
@@ -205,9 +207,9 @@ EOF
     _sort_desc() {
         local _var="$1"
         shift
-        local _out=()
-        while IFS= read -r line; do
-            _out+=("$line")
+        local _out=() _line
+        while IFS= read -r _line; do
+            _out+=("$_line")
         done < <(printf '%s\n' "$@" | sort -t'|' -k1 -rn)
         # shellcheck disable=SC2034  # assigned via eval to caller var
         eval "$_var=(\"\${_out[@]}\")"
@@ -427,10 +429,10 @@ Found $total_count branches ($preselect_count pre-selected for deletion)" \
     local branches_to_delete=()
     local need_switch=false
     local only_merged=true
+    local branch_name line
 
     while IFS= read -r line; do
         [[ "$line" == "✖ Abort"* ]] && continue
-        local branch_name
         branch_name=$(echo "$line" | cut -f2)
         if [[ -n "$branch_name" ]]; then
             branches_to_delete+=("$branch_name")

package/commands/create.sh

@@ -196,13 +196,13 @@ TYPES
         print_info "No Jira link provided. Using NOISSUE."
     else
         # First try to match just the issue number pattern (e.g., PROJ-123)
-        issue_number=$(echo "$jira_link" | grep -o -E '^[A-Z]+-[0-9]+$' | head -1)
+        issue_number=$(echo "$jira_link" | grep -o -E '^[A-Z]+-[0-9]+$' | head -1 || true)
         
         # If not a direct match, try to extract from URL
         if [[ -z "$issue_number" ]]; then
             # Match patterns like PROJ-123, ABC-456, etc.
             # Supports both /browse/PROJ-123 and selectedIssue=PROJ-123 formats
-            issue_number=$(echo "$jira_link" | grep -o -E '(browse/|selectedIssue=)[A-Z]+-[0-9]+' | grep -o '[A-Z]\+-[0-9]\+' | head -1)
+            issue_number=$(echo "$jira_link" | grep -o -E '(browse/|selectedIssue=)[A-Z]+-[0-9]+' | grep -o '[A-Z]\+-[0-9]\+' | head -1 || true)
         fi
 
         if [[ -z "$issue_number" ]]; then
@@ -218,7 +218,6 @@ TYPES
             echo "Parsed issue number: $issue_number"
         fi
     fi
-    echo
 
     # -----------------------------
     # 3. Get branch title from user (if not already provided)
@@ -242,9 +241,7 @@ TYPES
     # branch_prefix is set earlier from type menu, flag, or config
     local branch_name="${branch_prefix}${issue_number}-${branch_title}"
     
-    echo
     echo "Branch name: $branch_name"
-    echo
 
     # -----------------------------
     # 5. Check if branch already exists

package/commands/unstash.sh

@@ -129,7 +129,7 @@ EOF
     # 4. Extract stash ID safely
     # -----------------------------
     local stash_id
-    stash_id=$(echo "$selection" | grep -o 'stash@{[0-9]\+}')
+    stash_id=$(echo "$selection" | grep -o 'stash@{[0-9]\+}' || true)
 
     if [[ -z "$stash_id" ]]; then
         echo "Error: Could not determine stash ID."

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitbash",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "description": "Opinionated git utilities for bash with fzf-powered menus",
   "author": "jaggli",
   "license": "MIT",