gitarsenal-cli 1.9.39 → 1.9.41

package/.venv_status.json

@@ -1 +1 @@
-{"created":"2025-08-11T11:27:54.801Z","packages":["modal","gitingest","requests","anthropic"],"uv_version":"uv 0.8.4 (Homebrew 2025-07-30)"}
+{"created":"2025-08-11T14:42:03.859Z","packages":["modal","gitingest","requests","anthropic"],"uv_version":"uv 0.8.4 (Homebrew 2025-07-30)"}

package/bin/gitarsenal.js

@@ -41,7 +41,6 @@ function activateVirtualEnvironment() {
   if (fs.existsSync(statusFile)) {
     try {
       const status = JSON.parse(fs.readFileSync(statusFile, 'utf8'));
-      // console.log(chalk.gray(`✅ Virtual environment created: ${status.created}`));
       console.log(chalk.gray(`📦 Packages: ${status.packages.join(', ')}`));
     } catch (error) {
       console.log(chalk.gray('✅ Virtual environment found'));
@@ -105,19 +104,39 @@ function activateVirtualEnvironment() {
 }
 
 // Lightweight preview of GPU/Torch/CUDA recommendations prior to GPU selection
-async function previewRecommendations(repoUrl) {
-  const spinner = ora('Analyzing repository for GPU/Torch/CUDA recommendations...').start();
+async function previewRecommendations(repoUrl, optsOrShowSummary = true) {
+  const showSummary = typeof optsOrShowSummary === 'boolean' ? optsOrShowSummary : (optsOrShowSummary?.showSummary ?? true);
+  const externalSignal = typeof optsOrShowSummary === 'object' ? optsOrShowSummary.abortSignal : undefined;
+  const hideSpinner = typeof optsOrShowSummary === 'object' ? optsOrShowSummary.hideSpinner : false;
+  
+  const spinner = hideSpinner ? null : ora('Analyzing repository for GPU/Torch/CUDA recommendations...').start();
+  const previewTimeoutMs = Number(process.env.GITARSENAL_PREVIEW_TIMEOUT_MS || 90000);
+  const controller = new AbortController();
+  const abortOnExternal = () => controller.abort();
+  const timeoutId = setTimeout(() => controller.abort(), previewTimeoutMs);
+  
+  // Add periodic spinner updates to show progress (only if we have a spinner)
+  let elapsedTime = 0;
+  const progressInterval = spinner ? setInterval(() => {
+    elapsedTime += 10;
+    const minutes = Math.floor(elapsedTime / 60);
+    const seconds = elapsedTime % 60;
+    const timeStr = minutes > 0 ? `${minutes}m ${seconds}s` : `${seconds}s`;
+    spinner.text = `Analyzing repository for GPU/Torch/CUDA recommendations... (${timeStr})`;
+  }, 10000) : null; // Update every 10 seconds
+  
   try {
+    // Bridge external abort signal to our controller (for stopping spinner when full fetch returns)
+    if (externalSignal) {
+      if (externalSignal.aborted) controller.abort();
+      else externalSignal.addEventListener('abort', abortOnExternal, { once: true });
+    }
+
     const envUrl = process.env.GITARSENAL_API_URL;
-    const endpoints = envUrl
-      ? [envUrl]
-      : [
-          'https://www.gitarsenal.dev/api/best_gpu'
-        ];
+    const endpoints = envUrl ? [envUrl] : ['https://www.gitarsenal.dev/api/best_gpu'];
 
     const payload = {
       repoUrl,
-      // Minimal GitIngest data to allow backend to run LLM analysis
       gitingestData: {
         system_info: {
           platform: process.platform,
@@ -137,42 +156,22 @@ async function previewRecommendations(repoUrl) {
         },
         success: true
       },
-      // Hint server to do lightweight preview if supported
       preview: true
     };
 
-    // Increase timeout to allow server to compute recommendations before GPU selection
-    const previewTimeoutMs = Number(process.env.GITARSENAL_PREVIEW_TIMEOUT_MS || 90000);
+    let data = null;
+    let lastErrorText = '';
 
-    const fetchWithTimeout = async (url, body, timeoutMs = previewTimeoutMs) => {
-      const controller = new AbortController();
-      const id = setTimeout(() => controller.abort(), timeoutMs);
+    for (const url of endpoints) {
       try {
+        if (spinner) spinner.text = `Analyzing (preview): ${url}`;
         const res = await fetch(url, {
           method: 'POST',
-          headers: {
-            'Content-Type': 'application/json',
-            'User-Agent': 'GitArsenal-CLI/1.0'
-          },
-          body: JSON.stringify(body),
+          headers: { 'Content-Type': 'application/json', 'User-Agent': 'GitArsenal-CLI/1.0' },
+          body: JSON.stringify(payload),
           redirect: 'follow',
           signal: controller.signal
         });
-        clearTimeout(id);
-        return res;
-      } catch (e) {
-        clearTimeout(id);
-        throw e;
-      }
-    };
-
-    let data = null;
-    let lastErrorText = '';
-
-    for (const url of endpoints) {
-      try {
-        spinner.text = `Analyzing (preview): ${url}`;
-        const res = await fetchWithTimeout(url, payload, previewTimeoutMs);
         if (!res.ok) {
           const text = await res.text().catch(() => '');
           lastErrorText = `${res.status} ${text.slice(0, 300)}`;
@@ -181,25 +180,37 @@ async function previewRecommendations(repoUrl) {
         data = await res.json().catch(() => null);
         if (data) break;
       } catch (err) {
+        if (err && (err.name === 'AbortError' || err.code === 'ABORT_ERR')) {
+          // Silent stop on external abort (e.g., full fetch succeeded)
+          return null;
+        }
         lastErrorText = err && err.message ? err.message : 'request failed';
         continue;
       }
     }
 
-    spinner.stop();
-
     if (!data) {
-      console.log(chalk.yellow('⚠️ Preview unavailable (timeout or server error).'));
-      if (lastErrorText) console.log(chalk.gray(`Reason: ${lastErrorText}`));
+      if (!hideSpinner) {
+        console.log(chalk.yellow('⚠️ Preview unavailable (timeout or server error).'));
+        if (lastErrorText) console.log(chalk.gray(`Reason: ${lastErrorText}`));
+      }
       return null;
     }
 
-    printGpuTorchCudaSummary(data);
+    if (showSummary) {
+      printGpuTorchCudaSummary(data);
+    }
     return data;
   } catch (e) {
-    spinner.stop();
-    console.log(chalk.yellow(`⚠️ Preview failed: ${e.message}`));
+    if (!(e && (e.name === 'AbortError' || e.code === 'ABORT_ERR')) && !hideSpinner) {
+      console.log(chalk.yellow(`⚠️ Preview failed: ${e.message}`));
+    }
     return null;
+  } finally {
+    clearTimeout(timeoutId);
+    if (progressInterval) clearInterval(progressInterval);
+    if (spinner) spinner.stop();
+    if (externalSignal) externalSignal.removeEventListener('abort', abortOnExternal);
   }
 }
 
@@ -299,7 +310,7 @@ function printGpuTorchCudaSummary(result) {
 // Full fetch to get both setup commands and recommendations in one request
 async function fetchFullSetupAndRecs(repoUrl) {
   const envUrl = process.env.GITARSENAL_API_URL;
-  const endpoints = envUrl ? [envUrl] : ['https://www.gitarsenal.dev/api/gitingest-setup-commands'];
+  const endpoints = envUrl ? [envUrl] : ['https://www.gitarsenal.dev/api/best_gpu'];
   const payload = {
     repoUrl,
     gitingestData: {
@@ -387,7 +398,7 @@ async function sendUserData(userId, userName, userEmail) {
       webhookUrl = process.env.GITARSENAL_WEBHOOK_URL;
     }
     
-    console.log(chalk.gray(`📡 Sending to: ${webhookUrl}`));
+    // console.log(chalk.gray(`📡 Sending to: ${webhookUrl}`));
     console.log(chalk.gray(`📦 Data: ${data}`));
     
     const urlObj = new URL(webhookUrl);
@@ -414,8 +425,6 @@ async function sendUserData(userId, userName, userEmail) {
           responseData += chunk;
         });
         res.on('end', () => {
-          console.log(chalk.gray(`📊 Response status: ${res.statusCode}`));
-          console.log(chalk.gray(`📄 Response: ${responseData}`));
           
           if (res.statusCode >= 200 && res.statusCode < 300) {
             console.log(chalk.green('✅ User registered on GitArsenal dashboard'));
@@ -465,6 +474,35 @@ async function collectUserCredentials(options) {
     try {
       const config = JSON.parse(fs.readFileSync(userConfigPath, 'utf8'));
       if (config.userId && config.userName && config.userEmail) {
+        // Check if the email is a fake one (contains @example.com)
+        if (config.userEmail.includes('@example.com')) {
+          console.log(chalk.yellow('⚠️  Detected placeholder email address. Please update your credentials.'));
+          console.log(chalk.gray('We need your real email address for proper registration.'));
+          
+          // Prompt for real email address
+          const emailUpdate = await inquirer.prompt([
+            {
+              type: 'input',
+              name: 'userEmail',
+              message: 'Enter your real email address:',
+              validate: (input) => {
+                const email = input.trim();
+                if (email === '') return 'Email address is required';
+                if (!/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) {
+                  return 'Please enter a valid email address (e.g., user@example.com)';
+                }
+                return true;
+              }
+            }
+          ]);
+          
+          // Update the config with real email
+          config.userEmail = emailUpdate.userEmail;
+          config.updatedAt = new Date().toISOString();
+          fs.writeFileSync(userConfigPath, JSON.stringify(config, null, 2));
+          console.log(chalk.green('✅ Email address updated successfully!'));
+        }
+        
         userId = config.userId;
         userName = config.userName;
         userEmail = config.userEmail;
@@ -496,10 +534,10 @@ async function collectUserCredentials(options) {
 
     if (authChoice.action === 'register') {
       console.log(chalk.blue('\n📝 Create New Account'));
-      const credentials = await inquirer.prompt([
-        {
-          type: 'input',
-          name: 'userId',
+    const credentials = await inquirer.prompt([
+      {
+        type: 'input',
+        name: 'userId',
           message: 'Choose a username:',
           validate: (input) => {
             const username = input.trim();
@@ -521,14 +559,14 @@ async function collectUserCredentials(options) {
             }
             return true;
           }
-        },
-        {
-          type: 'input',
-          name: 'userName',
+      },
+      {
+        type: 'input',
+        name: 'userName',
           message: 'Enter your full name:',
-          validate: (input) => input.trim() !== '' ? true : 'Name is required'
-        },
-        {
+        validate: (input) => input.trim() !== '' ? true : 'Name is required'
+      },
+      {
           type: 'password',
           name: 'password',
           message: 'Create a password (min 8 characters):',
@@ -545,11 +583,11 @@ async function collectUserCredentials(options) {
             if (input !== answers.password) return 'Passwords do not match';
             return true;
           }
-        }
-      ]);
-      
-      userId = credentials.userId;
-      userName = credentials.userName;
+      }
+    ]);
+    
+    userId = credentials.userId;
+    userName = credentials.userName;
       userEmail = credentials.userEmail;
       
       console.log(chalk.green('✅ Account created successfully!'));
@@ -558,9 +596,34 @@ async function collectUserCredentials(options) {
       const credentials = await inquirer.prompt([
         {
           type: 'input',
-          name: 'userIdentifier',
-          message: 'Enter your username or email:',
-          validate: (input) => input.trim() !== '' ? true : 'Username/email is required'
+          name: 'userId',
+          message: 'Enter your username:',
+          validate: (input) => {
+            const username = input.trim();
+            if (username === '') return 'Username is required';
+            if (username.length < 3) return 'Username must be at least 3 characters';
+            if (!/^[a-zA-Z0-9_-]+$/.test(username)) return 'Username can only contain letters, numbers, _ and -';
+            return true;
+          }
+        },
+        {
+          type: 'input',
+          name: 'userEmail',
+          message: 'Enter your email address:',
+          validate: (input) => {
+            const email = input.trim();
+            if (email === '') return 'Email address is required';
+            if (!/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) {
+              return 'Please enter a valid email address (e.g., user@example.com)';
+            }
+            return true;
+          }
+        },
+        {
+          type: 'input',
+          name: 'userName',
+          message: 'Enter your full name:',
+          validate: (input) => input.trim() !== '' ? true : 'Name is required'
         },
         {
           type: 'password',
@@ -570,12 +633,9 @@ async function collectUserCredentials(options) {
         }
       ]);
       
-      // For now, we'll simulate successful login
-      // In a real implementation, you'd validate against a user database
-      const identifier = credentials.userIdentifier;
-      userId = identifier.includes('@') ? identifier.split('@')[0] : identifier;
-      userName = `User ${userId}`; // Would be fetched from database
-      userEmail = identifier.includes('@') ? identifier : `${identifier}@example.com`;
+      userId = credentials.userId;
+      userName = credentials.userName;
+      userEmail = credentials.userEmail;
       
       console.log(chalk.green('✅ Login successful!'));
     }
@@ -587,15 +647,15 @@ async function collectUserCredentials(options) {
         fs.mkdirSync(userConfigDir, { recursive: true });
       }
       
-      const config = {
-        userId,
-        userName,
+        const config = {
+          userId,
+          userName,
         userEmail,
         savedAt: new Date().toISOString()
-      };
+        };
       fs.writeFileSync(userConfigPath, JSON.stringify(config, null, 2));
       console.log(chalk.green('✅ Credentials saved locally'));
-    } catch (error) {
+      } catch (error) {
       console.log(chalk.yellow('⚠️  Could not save credentials locally'));
     }
   }
@@ -742,18 +802,49 @@ async function runContainerCommand(options) {
       repoUrl = answers.repoUrl;
     }
 
-    // Attempt full fetch first to get both commands and recommendations; fallback to preview on failure
+    // Attempt full fetch first to get both commands and recommendations; now start preview concurrently
     if (useApi && repoUrl) {
-      const fullData = await fetchFullSetupAndRecs(repoUrl).catch(() => null);
-      if (fullData) {
-        printGpuTorchCudaSummary(fullData);
-        if (Array.isArray(fullData.commands) && fullData.commands.length) {
-          setupCommands = fullData.commands;
-          // Disable auto-detection since we already have commands
-          useApi = false;
+      // Start a main spinner that will show overall progress
+      const mainSpinner = ora('Analyzing repository...').start();
+      
+      try {
+        // Start preview immediately so we get early feedback; suppress summary here to avoid duplicates.
+        // Provide an AbortController so we can stop the preview spinner as soon as full fetch returns.
+        const previewAbort = new AbortController();
+        mainSpinner.text = 'Analyzing repository for GPU/Torch/CUDA recommendations...';
+        const previewPromise = previewRecommendations(repoUrl, { showSummary: false, abortSignal: previewAbort.signal, hideSpinner: true }).catch(() => null);
+
+        // Run full fetch in parallel; prefer its results if available.
+        mainSpinner.text = 'Finding the best machine for your code...';
+        const fullData = await fetchFullSetupAndRecs(repoUrl).catch(() => null);
+        
+        if (fullData) {
+          // Stop preview spinner immediately since we have a response
+          previewAbort.abort();
+          mainSpinner.succeed('Analysis complete!');
+          printGpuTorchCudaSummary(fullData);
+          if (Array.isArray(fullData.commands) && fullData.commands.length) {
+            setupCommands = fullData.commands;
+            // Disable auto-detection since we already have commands
+            useApi = false;
+          }
+        } else {
+          // Full fetch failed, wait for preview and show its results
+          mainSpinner.text = 'Waiting for preview analysis to complete...';
+          const previewData = await previewPromise;
+          if (previewData) {
+            mainSpinner.succeed('Preview analysis complete!');
+            printGpuTorchCudaSummary(previewData);
+          } else {
+            mainSpinner.fail('Analysis failed - both preview and full analysis timed out or failed');
+            console.log(chalk.yellow('⚠️ Unable to analyze repository automatically.'));
+            console.log(chalk.gray('You can still proceed with manual setup commands.'));
+          }
         }
-      } else {
-        await previewRecommendations(repoUrl);
+      } catch (error) {
+        mainSpinner.fail(`Analysis failed: ${error.message}`);
+        console.log(chalk.yellow('⚠️ Unable to analyze repository automatically.'));
+        console.log(chalk.gray('You can still proceed with manual setup commands.'));
       }
     }
 
@@ -883,7 +974,10 @@ async function runContainerCommand(options) {
         volumeName,
         setupCommands,
         useApi,
-        yes: skipConfirmation
+        yes: skipConfirmation,
+        userId,
+        userName,
+        userEmail
       });
       
     } catch (containerError) {

package/lib/sandbox.js

@@ -44,7 +44,10 @@ async function runContainer(options) {
     setupCommands = [], 
     useApi = true,
     showExamples = false,
-    yes = false
+    yes = false,
+    userId,
+    userName,
+    userEmail
   } = options;
   
   // Get the path to the Python script
@@ -107,6 +110,14 @@ async function runContainer(options) {
     console.log(chalk.gray(`🔍 Debug: Adding --yes flag to Python script`));
   }
   
+  // Add user credentials if provided
+  if (userId && userEmail && userName) {
+    args.push('--user-id', userEmail);
+    args.push('--user-name', userId);
+    args.push('--display-name', userName);
+    console.log(chalk.gray(`🔍 Debug: Passing user credentials to Python script`));
+  }
+  
   // Handle manual setup commands if provided
   if (setupCommands.length > 0) {
     // Create a temporary file to store setup commands

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitarsenal-cli",
-  "version": "1.9.39",
+  "version": "1.9.41",
   "description": "CLI tool for creating Modal sandboxes with GitHub repositories",
   "main": "index.js",
   "bin": {

package/python/command_manager.py

@@ -253,6 +253,24 @@ class CommandListManager:
         
         print("="*60)
     
+    def print_all_commands(self):
+        """Print all commands in the list for debugging/transparency."""
+        if not self.commands:
+            print("📋 No commands in the list")
+            return
+        
+        print("\n" + "="*80)
+        print("📋 ALL SETUP COMMANDS")
+        print("="*80)
+        for i, cmd in enumerate(self.commands):
+            status_icon = {
+                'pending': '⏳',
+                'success': '✅',
+                'failed': '❌'
+            }.get(cmd['status'], '❓')
+            print(f"  {i+1:2d}. {status_icon} {cmd['command']}")
+        print("="*80 + "\n")
+    
     def get_failed_commands_for_llm(self):
         """Get failed commands for LLM analysis."""
         failed_commands = []

package/python/test_modalSandboxScript.py

@@ -398,6 +398,14 @@ def create_modal_ssh_container(gpu_type, repo_url=None, repo_name=None, setup_co
             processed_commands = preprocess_commands_with_llm(setup_commands, stored_credentials, api_key)
             print(f"⚙️ Running {len(processed_commands)} preprocessed setup commands with dynamic command list...")
             
+            # Display all setup commands that will be executed
+            print("\n" + "="*80)
+            print("📋 SETUP COMMANDS TO BE EXECUTED")
+            print("="*80)
+            for i, cmd in enumerate(processed_commands, 1):
+                print(f"  {i:2d}. {cmd}")
+            print("="*80 + "\n")
+            
             # Create command list manager with processed commands
             cmd_manager = CommandListManager(processed_commands)
             
@@ -1611,7 +1619,7 @@ def get_setup_commands_from_gitingest(repo_url):
                 url=api_url,
                 payload=payload,
                 max_retries=2,
-                timeout=180  # 3 minute timeout
+                timeout=180,  # 3 minute timeout
             )
             
             if not response:
@@ -2115,6 +2123,11 @@ if __name__ == "__main__":
     parser.add_argument('--store-api-key', type=str, help='Store API key for a service (e.g., openai, modal)')
     parser.add_argument('--skip-auth', action='store_true', help='Skip authentication check (for development)')
     
+    # User credential arguments (passed from JavaScript CLI)
+    parser.add_argument('--user-id', type=str, help='User email address (passed from JavaScript CLI)')
+    parser.add_argument('--user-name', type=str, help='Username (passed from JavaScript CLI)')
+    parser.add_argument('--display-name', type=str, help='Display name (passed from JavaScript CLI)')
+    
     args = parser.parse_args()
     
     # Initialize authentication manager
@@ -2149,8 +2162,11 @@ if __name__ == "__main__":
         show_usage_examples()
         sys.exit(0)
     
-    # Check authentication (unless skipped for development)
-    if not args.skip_auth:
+    # Authentication is handled by the JavaScript CLI when credentials are passed
+    if args.user_id and args.user_name and args.display_name:
+        print(f"✅ Authenticated as: {args.display_name} ({args.user_id})")
+    elif not args.skip_auth:
+        # Only perform authentication check if running Python script directly (not from CLI)
         if not _check_authentication(auth_manager):
             print("\n❌ Authentication required. Please login or register first.")
             print("Use --login to login or --register to create an account.")