gitarsenal-cli 1.6.3 → 1.6.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitarsenal-cli",
-  "version": "1.6.3",
+  "version": "1.6.5",
   "description": "CLI tool for creating Modal sandboxes with GitHub repositories",
   "main": "index.js",
   "bin": {

package/python/credentials_manager.py

@@ -187,4 +187,37 @@ class CredentialsManager:
     
     def clear_all_credentials(self):
         """Clear all saved credentials"""
-        return self.save_credentials({}) 
+        return self.save_credentials({})
+    
+    def cleanup_security_files(self):
+        """Clean up all security-related files including legacy files"""
+        try:
+            # Clear all credentials from the main file
+            self.clear_all_credentials()
+            
+            # Remove legacy OpenAI key file
+            openai_key_file = self.config_dir / "openai_key"
+            if openai_key_file.exists():
+                openai_key_file.unlink()
+                print("✅ Removed legacy OpenAI API key file")
+            
+            # Remove environment variables
+            import os
+            security_vars = [
+                "OPENAI_API_KEY", 
+                "HUGGINGFACE_TOKEN", 
+                "WANDB_API_KEY",
+                "MODAL_TOKEN_ID",
+                "MODAL_TOKEN", 
+                "MODAL_TOKEN_SECRET"
+            ]
+            
+            for var in security_vars:
+                if var in os.environ:
+                    del os.environ[var]
+            
+            print("✅ Security cleanup completed successfully")
+            return True
+        except Exception as e:
+            print(f"❌ Error during security cleanup: {e}")
+            return False 

package/python/modal_proxy_service.py

@@ -210,23 +210,22 @@ def setup_modal_auth():
         logger.error(f"Error setting up Modal authentication: {e}")
         return False
 
-def cleanup_modal_token():
-    """Delete Modal token files and environment variables after SSH container is started"""
-    logger.info("🧹 Cleaning up Modal token for security...")
+def cleanup_security_tokens():
+    """Delete all security tokens and API keys after SSH container is started"""
+    logger.info("🧹 Cleaning up security tokens and API keys...")
     
     try:
-        # Remove token from environment variables
-        if "MODAL_TOKEN_ID" in os.environ:
-            del os.environ["MODAL_TOKEN_ID"]
-            logger.info("✅ Removed MODAL_TOKEN_ID from environment")
-        
-        if "MODAL_TOKEN" in os.environ:
-            del os.environ["MODAL_TOKEN"]
-            logger.info("✅ Removed MODAL_TOKEN from environment")
-            
-        if "MODAL_TOKEN_SECRET" in os.environ:
-            del os.environ["MODAL_TOKEN_SECRET"]
-            logger.info("✅ Removed MODAL_TOKEN_SECRET from environment")
+        # Remove Modal tokens from environment variables
+        modal_env_vars = ["MODAL_TOKEN_ID", "MODAL_TOKEN", "MODAL_TOKEN_SECRET"]
+        for var in modal_env_vars:
+            if var in os.environ:
+                del os.environ[var]
+                logger.info(f"✅ Removed {var} from environment")
+        
+        # Remove OpenAI API key from environment
+        if "OPENAI_API_KEY" in os.environ:
+            del os.environ["OPENAI_API_KEY"]
+            logger.info("✅ Removed OpenAI API key from environment")
         
         # Delete ~/.modal.toml file
         from pathlib import Path
@@ -235,9 +234,20 @@ def cleanup_modal_token():
             modal_toml.unlink()
             logger.info(f"✅ Deleted Modal token file at {modal_toml}")
         
-        logger.info("✅ Modal token cleanup completed successfully")
+        # Delete ~/.gitarsenal/openai_key file
+        openai_key_file = Path.home() / ".gitarsenal" / "openai_key"
+        if openai_key_file.exists():
+            openai_key_file.unlink()
+            logger.info(f"✅ Deleted OpenAI API key file at {openai_key_file}")
+        
+        logger.info("✅ Security cleanup completed successfully")
     except Exception as e:
-        logger.error(f"❌ Error during Modal token cleanup: {e}")
+        logger.error(f"❌ Error during security cleanup: {e}")
+
+# Keep the old function for backward compatibility
+def cleanup_modal_token():
+    """Legacy function - now calls the comprehensive cleanup"""
+    cleanup_security_tokens()
 
 @app.route('/api/health', methods=['GET'])
 def health_check():

package/python/test_modalSandboxScript.py

@@ -1396,7 +1396,7 @@ def create_modal_ssh_container(gpu_type, repo_url=None, repo_name=None, setup_co
     try:
         print("📦 Building SSH-enabled image...")
         ssh_image = (
-            modal.Image.debian_slim()
+            modal.Image.from_registry("nvidia/cuda:12.4.0-devel-ubuntu22.04", add_python="3.11")
             .apt_install(
                 "openssh-server", "sudo", "curl", "wget", "vim", "htop", "git", 
                 "python3", "python3-pip", "build-essential", "tmux", "screen", "nano",
@@ -2278,6 +2278,45 @@ def cleanup_modal_token():
     except Exception as e:
         print(f"❌ Error during token cleanup: {e}")
 
+def cleanup_security_tokens():
+    """Delete all security tokens and API keys after SSH container is started"""
+    print("🧹 Cleaning up security tokens and API keys...")
+    
+    try:
+        # Remove Modal tokens from environment variables
+        modal_env_vars = ["MODAL_TOKEN_ID", "MODAL_TOKEN", "MODAL_TOKEN_SECRET"]
+        for var in modal_env_vars:
+            if var in os.environ:
+                del os.environ[var]
+                # print(f"✅ Removed {var} from environment")
+        
+        # Remove OpenAI API key from environment
+        if "OPENAI_API_KEY" in os.environ:
+            del os.environ["OPENAI_API_KEY"]
+            # print("✅ Removed OpenAI API key from environment")
+        
+        # Delete ~/.modal.toml file
+        home_dir = os.path.expanduser("~")
+        modal_toml = os.path.join(home_dir, ".modal.toml")
+        if os.path.exists(modal_toml):
+            os.remove(modal_toml)
+            # print(f"✅ Deleted Modal token file at {modal_toml}")
+        
+        # Delete ~/.gitarsenal/openai_key file
+        openai_key_file = os.path.join(home_dir, ".gitarsenal", "openai_key")
+        if os.path.exists(openai_key_file):
+            os.remove(openai_key_file)
+            # print(f"✅ Deleted OpenAI API key file at {openai_key_file}")
+        
+        # print("✅ Security cleanup completed successfully")
+    except Exception as e:
+        print(f"❌ Error during security cleanup: {e}")
+
+# Keep the old function for backward compatibility
+def cleanup_modal_token():
+    """Legacy function - now calls the comprehensive cleanup"""
+    cleanup_security_tokens()
+
 def show_usage_examples():
     """Display usage examples for the script."""
     print("Usage Examples\n")

package/test_modalSandboxScript.py

@@ -1396,7 +1396,7 @@ def create_modal_ssh_container(gpu_type, repo_url=None, repo_name=None, setup_co
     try:
         print("📦 Building SSH-enabled image...")
         ssh_image = (
-            modal.Image.debian_slim()
+            modal.Image.from_registry("nvidia/cuda:12.4.0-devel-ubuntu22.04", add_python="3.11")
             .apt_install(
                 "openssh-server", "sudo", "curl", "wget", "vim", "htop", "git", 
                 "python3", "python3-pip", "build-essential", "tmux", "screen", "nano",
@@ -2278,6 +2278,45 @@ def cleanup_modal_token():
     except Exception as e:
         print(f"❌ Error during token cleanup: {e}")
 
+def cleanup_security_tokens():
+    """Delete all security tokens and API keys after SSH container is started"""
+    print("🧹 Cleaning up security tokens and API keys...")
+    
+    try:
+        # Remove Modal tokens from environment variables
+        modal_env_vars = ["MODAL_TOKEN_ID", "MODAL_TOKEN", "MODAL_TOKEN_SECRET"]
+        for var in modal_env_vars:
+            if var in os.environ:
+                del os.environ[var]
+                # print(f"✅ Removed {var} from environment")
+        
+        # Remove OpenAI API key from environment
+        if "OPENAI_API_KEY" in os.environ:
+            del os.environ["OPENAI_API_KEY"]
+            # print("✅ Removed OpenAI API key from environment")
+        
+        # Delete ~/.modal.toml file
+        home_dir = os.path.expanduser("~")
+        modal_toml = os.path.join(home_dir, ".modal.toml")
+        if os.path.exists(modal_toml):
+            os.remove(modal_toml)
+            # print(f"✅ Deleted Modal token file at {modal_toml}")
+        
+        # Delete ~/.gitarsenal/openai_key file
+        openai_key_file = os.path.join(home_dir, ".gitarsenal", "openai_key")
+        if os.path.exists(openai_key_file):
+            os.remove(openai_key_file)
+            # print(f"✅ Deleted OpenAI API key file at {openai_key_file}")
+        
+        # print("✅ Security cleanup completed successfully")
+    except Exception as e:
+        print(f"❌ Error during security cleanup: {e}")
+
+# Keep the old function for backward compatibility
+def cleanup_modal_token():
+    """Legacy function - now calls the comprehensive cleanup"""
+    cleanup_security_tokens()
+
 def show_usage_examples():
     """Display usage examples for the script."""
     print("Usage Examples\n")