gip-remote 1.2.4 → 1.2.5

package/index.js

@@ -182,7 +182,9 @@ class Remote extends ReadyResource {
       if (!obj) throw new Error('Object not found: ' + resolvedOid)
     }
 
-    if (obj.type !== 'commit') throw new Error('Expected commit, got ' + obj.type + ': ' + resolvedOid)
+    if (obj.type !== 'commit') {
+      throw new Error('Expected commit, got ' + obj.type + ': ' + resolvedOid)
+    }
 
     const commit = parseCommit(obj.data)
     if (!commit.tree) throw new Error('Commit has no tree: ' + resolvedOid)
@@ -190,7 +192,26 @@ class Remote extends ReadyResource {
     // 3. Walk tree to enumerate files
     const files = walkTree(objects, commit.tree, '')
 
-    // 4. Insert file records
+    // 4a. Reconcile deletions — remove file records whose paths no longer
+    //     exist in the new tree. Without this, files removed in a commit
+    //     would persist in the index forever (only `deleteBranch` cleans
+    //     them up, and only on full branch deletion). The drive view would
+    //     keep showing ghost files; consumers iterating @gip/files would
+    //     emit stale entries.
+    //
+    //     We rebuild the new path set first, then sweep the existing
+    //     records — O(N) in the size of the indexed tree, same order as
+    //     the insert step that follows.
+    const newPaths = new Set(files.map((f) => f.path))
+    const existingFiles = this._db.find('@gip/files', { branch: refName })
+    for await (const file of existingFiles) {
+      if (!newPaths.has(file.path)) {
+        await this._db.delete('@gip/files', { branch: refName, path: file.path })
+      }
+    }
+
+    // 4b. Insert file records (idempotent w.r.t. (branch, path) — acts as
+    //     upsert for paths whose blob/mode/metadata changed).
     for (const file of files) {
       await this._db.insert('@gip/files', {
         branch: refName,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gip-remote",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "Git+Pear remote DB for handling git data",
   "main": "index.js",
   "scripts": {

package/schema/hyperdb/db.json

@@ -12,9 +12,7 @@
       "indexes": [],
       "schema": "@gip/repos",
       "derived": false,
-      "key": [
-        "name"
-      ],
+      "key": ["name"],
       "trigger": null
     },
     {
@@ -27,9 +25,7 @@
       "indexes": [],
       "schema": "@gip/branches",
       "derived": false,
-      "key": [
-        "name"
-      ],
+      "key": ["name"],
       "trigger": null
     },
     {
@@ -39,15 +35,10 @@
       "type": 1,
       "version": 1,
       "versionField": null,
-      "indexes": [
-        "@gip/files-by-branch"
-      ],
+      "indexes": ["@gip/files-by-branch"],
       "schema": "@gip/files",
       "derived": false,
-      "key": [
-        "branch",
-        "path"
-      ],
+      "key": ["branch", "path"],
       "trigger": null
     },
     {
@@ -60,9 +51,7 @@
       "indexes": [],
       "schema": "@gip/objects",
       "derived": false,
-      "key": [
-        "oid"
-      ],
+      "key": ["oid"],
       "trigger": null
     },
     {
@@ -74,9 +63,7 @@
       "collection": "@gip/files",
       "unique": false,
       "deprecated": false,
-      "key": [
-        "branch"
-      ]
+      "key": ["branch"]
     },
     {
       "name": "head",
@@ -101,10 +88,8 @@
       "indexes": [],
       "schema": "@gip/tags",
       "derived": false,
-      "key": [
-        "name"
-      ],
+      "key": ["name"],
       "trigger": null
     }
   ]
-}
+}

package/schema/hyperdb/index.js

@@ -7,11 +7,9 @@ const { version, getEncoding, setVersion } = require('./messages.js')
 const versions = { schema: version, db: 3 }
 
 // '@gip/repos' collection key
-const collection0_key = new IndexEncoder([
-  IndexEncoder.STRING
-], { prefix: 0 })
+const collection0_key = new IndexEncoder([IndexEncoder.STRING], { prefix: 0 })
 
-function collection0_indexify (record) {
+function collection0_indexify(record) {
   const a = record.name
   return a === undefined ? [] : [a]
 }
@@ -20,7 +18,7 @@ function collection0_indexify (record) {
 const collection0_enc = getEncoding('@gip/repos/hyperdb#0')
 
 // '@gip/repos' reconstruction function
-function collection0_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection0_reconstruct(schemaVersion, keyBuf, valueBuf) {
   const key = collection0_key.decode(keyBuf)
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
@@ -32,7 +30,7 @@ function collection0_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/repos' key reconstruction function
-function collection0_reconstruct_key (keyBuf) {
+function collection0_reconstruct_key(keyBuf) {
   const key = collection0_key.decode(keyBuf)
   return {
     name: key[0]
@@ -44,11 +42,11 @@ const collection0 = {
   name: '@gip/repos',
   id: 0,
   version: 1,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = [record.name]
     return collection0_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection0_key.encodeRange({
       gt: gt ? collection0_indexify(gt) : null,
       lt: lt ? collection0_indexify(lt) : null,
@@ -56,7 +54,7 @@ const collection0 = {
       lte: lte ? collection0_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection0_enc.preencode(state, record)
@@ -74,11 +72,9 @@ const collection0 = {
 }
 
 // '@gip/branches' collection key
-const collection1_key = new IndexEncoder([
-  IndexEncoder.STRING
-], { prefix: 1 })
+const collection1_key = new IndexEncoder([IndexEncoder.STRING], { prefix: 1 })
 
-function collection1_indexify (record) {
+function collection1_indexify(record) {
   const a = record.name
   return a === undefined ? [] : [a]
 }
@@ -87,7 +83,7 @@ function collection1_indexify (record) {
 const collection1_enc = getEncoding('@gip/branches/hyperdb#1')
 
 // '@gip/branches' reconstruction function
-function collection1_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection1_reconstruct(schemaVersion, keyBuf, valueBuf) {
   const key = collection1_key.decode(keyBuf)
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
@@ -99,7 +95,7 @@ function collection1_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/branches' key reconstruction function
-function collection1_reconstruct_key (keyBuf) {
+function collection1_reconstruct_key(keyBuf) {
   const key = collection1_key.decode(keyBuf)
   return {
     name: key[0]
@@ -111,11 +107,11 @@ const collection1 = {
   name: '@gip/branches',
   id: 1,
   version: 1,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = [record.name]
     return collection1_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection1_key.encodeRange({
       gt: gt ? collection1_indexify(gt) : null,
       lt: lt ? collection1_indexify(lt) : null,
@@ -123,7 +119,7 @@ const collection1 = {
       lte: lte ? collection1_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection1_enc.preencode(state, record)
@@ -141,12 +137,9 @@ const collection1 = {
 }
 
 // '@gip/files' collection key
-const collection2_key = new IndexEncoder([
-  IndexEncoder.STRING,
-  IndexEncoder.STRING
-], { prefix: 2 })
+const collection2_key = new IndexEncoder([IndexEncoder.STRING, IndexEncoder.STRING], { prefix: 2 })
 
-function collection2_indexify (record) {
+function collection2_indexify(record) {
   const arr = []
 
   const a0 = record.branch
@@ -164,7 +157,7 @@ function collection2_indexify (record) {
 const collection2_enc = getEncoding('@gip/files/hyperdb#2')
 
 // '@gip/files' reconstruction function
-function collection2_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection2_reconstruct(schemaVersion, keyBuf, valueBuf) {
   const key = collection2_key.decode(keyBuf)
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
@@ -177,7 +170,7 @@ function collection2_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/files' key reconstruction function
-function collection2_reconstruct_key (keyBuf) {
+function collection2_reconstruct_key(keyBuf) {
   const key = collection2_key.decode(keyBuf)
   return {
     branch: key[0],
@@ -190,11 +183,11 @@ const collection2 = {
   name: '@gip/files',
   id: 2,
   version: 1,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = [record.branch, record.path]
     return collection2_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection2_key.encodeRange({
       gt: gt ? collection2_indexify(gt) : null,
       lt: lt ? collection2_indexify(lt) : null,
@@ -202,7 +195,7 @@ const collection2 = {
       lte: lte ? collection2_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection2_enc.preencode(state, record)
@@ -220,11 +213,9 @@ const collection2 = {
 }
 
 // '@gip/objects' collection key
-const collection3_key = new IndexEncoder([
-  IndexEncoder.STRING
-], { prefix: 3 })
+const collection3_key = new IndexEncoder([IndexEncoder.STRING], { prefix: 3 })
 
-function collection3_indexify (record) {
+function collection3_indexify(record) {
   const a = record.oid
   return a === undefined ? [] : [a]
 }
@@ -233,7 +224,7 @@ function collection3_indexify (record) {
 const collection3_enc = getEncoding('@gip/objects/hyperdb#3')
 
 // '@gip/objects' reconstruction function
-function collection3_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection3_reconstruct(schemaVersion, keyBuf, valueBuf) {
   const key = collection3_key.decode(keyBuf)
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
@@ -245,7 +236,7 @@ function collection3_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/objects' key reconstruction function
-function collection3_reconstruct_key (keyBuf) {
+function collection3_reconstruct_key(keyBuf) {
   const key = collection3_key.decode(keyBuf)
   return {
     oid: key[0]
@@ -257,11 +248,11 @@ const collection3 = {
   name: '@gip/objects',
   id: 3,
   version: 1,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = [record.oid]
     return collection3_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection3_key.encodeRange({
       gt: gt ? collection3_indexify(gt) : null,
       lt: lt ? collection3_indexify(lt) : null,
@@ -269,7 +260,7 @@ const collection3 = {
       lte: lte ? collection3_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection3_enc.preencode(state, record)
@@ -287,13 +278,12 @@ const collection3 = {
 }
 
 // '@gip/files-by-branch' collection key
-const index4_key = new IndexEncoder([
-  IndexEncoder.STRING,
-  IndexEncoder.STRING,
-  IndexEncoder.STRING
-], { prefix: 4 })
+const index4_key = new IndexEncoder(
+  [IndexEncoder.STRING, IndexEncoder.STRING, IndexEncoder.STRING],
+  { prefix: 4 }
+)
 
-function index4_indexify (record) {
+function index4_indexify(record) {
   const arr = []
 
   const a0 = record.branch
@@ -316,10 +306,10 @@ const index4 = {
   name: '@gip/files-by-branch',
   version: 1,
   id: 4,
-  encodeKey (record) {
+  encodeKey(record) {
     return index4_key.encode(index4_indexify(record))
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return index4_key.encodeRange({
       gt: gt ? index4_indexify(gt) : null,
       lt: lt ? index4_indexify(lt) : null,
@@ -328,7 +318,7 @@ const index4 = {
     })
   },
   encodeValue: (record) => index4.collection.encodeKey(record),
-  encodeIndexKeys (record, context) {
+  encodeIndexKeys(record, context) {
     return [index4_key.encode([record.branch, record.branch, record.path])]
   },
   reconstruct: (keyBuf, valueBuf) => valueBuf,
@@ -338,10 +328,9 @@ const index4 = {
 collection2.indexes.push(index4)
 
 // '@gip/head' collection key
-const collection5_key = new IndexEncoder([
-], { prefix: 5 })
+const collection5_key = new IndexEncoder([], { prefix: 5 })
 
-function collection5_indexify (record) {
+function collection5_indexify(record) {
   return []
 }
 
@@ -349,7 +338,7 @@ function collection5_indexify (record) {
 const collection5_enc = getEncoding('@gip/head')
 
 // '@gip/head' reconstruction function
-function collection5_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection5_reconstruct(schemaVersion, keyBuf, valueBuf) {
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
   const type = c.uint.decode(state)
@@ -359,7 +348,7 @@ function collection5_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/head' key reconstruction function
-function collection5_reconstruct_key (keyBuf) {
+function collection5_reconstruct_key(keyBuf) {
   return {}
 }
 
@@ -368,11 +357,11 @@ const collection5 = {
   name: '@gip/head',
   id: 5,
   version: 2,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = []
     return collection5_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection5_key.encodeRange({
       gt: gt ? collection5_indexify(gt) : null,
       lt: lt ? collection5_indexify(lt) : null,
@@ -380,7 +369,7 @@ const collection5 = {
       lte: lte ? collection5_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection5_enc.preencode(state, record)
@@ -398,11 +387,9 @@ const collection5 = {
 }
 
 // '@gip/tags' collection key
-const collection6_key = new IndexEncoder([
-  IndexEncoder.STRING
-], { prefix: 6 })
+const collection6_key = new IndexEncoder([IndexEncoder.STRING], { prefix: 6 })
 
-function collection6_indexify (record) {
+function collection6_indexify(record) {
   const a = record.name
   return a === undefined ? [] : [a]
 }
@@ -411,7 +398,7 @@ function collection6_indexify (record) {
 const collection6_enc = getEncoding('@gip/tags/hyperdb#6')
 
 // '@gip/tags' reconstruction function
-function collection6_reconstruct (schemaVersion, keyBuf, valueBuf) {
+function collection6_reconstruct(schemaVersion, keyBuf, valueBuf) {
   const key = collection6_key.decode(keyBuf)
   setVersion(schemaVersion)
   const state = { start: 0, end: valueBuf.byteLength, buffer: valueBuf }
@@ -423,7 +410,7 @@ function collection6_reconstruct (schemaVersion, keyBuf, valueBuf) {
   return record
 }
 // '@gip/tags' key reconstruction function
-function collection6_reconstruct_key (keyBuf) {
+function collection6_reconstruct_key(keyBuf) {
   const key = collection6_key.decode(keyBuf)
   return {
     name: key[0]
@@ -435,11 +422,11 @@ const collection6 = {
   name: '@gip/tags',
   id: 6,
   version: 3,
-  encodeKey (record) {
+  encodeKey(record) {
     const key = [record.name]
     return collection6_key.encode(key)
   },
-  encodeKeyRange ({ gt, lt, gte, lte } = {}) {
+  encodeKeyRange({ gt, lt, gte, lte } = {}) {
     return collection6_key.encodeRange({
       gt: gt ? collection6_indexify(gt) : null,
       lt: lt ? collection6_indexify(lt) : null,
@@ -447,7 +434,7 @@ const collection6 = {
       lte: lte ? collection6_indexify(lte) : null
     })
   },
-  encodeValue (schemaVersion, collectionVersion, record) {
+  encodeValue(schemaVersion, collectionVersion, record) {
     setVersion(schemaVersion)
     const state = { start: 0, end: 2, buffer: null }
     collection6_enc.preencode(state, record)
@@ -464,36 +451,36 @@ const collection6 = {
   decodedVersion: 0
 }
 
-const collections = [
-  collection0,
-  collection1,
-  collection2,
-  collection3,
-  collection5,
-  collection6
-]
+const collections = [collection0, collection1, collection2, collection3, collection5, collection6]
 
-const indexes = [
-  index4
-]
+const indexes = [index4]
 
 module.exports = { versions, collections, indexes, resolveCollection, resolveIndex }
 
-function resolveCollection (name) {
+function resolveCollection(name) {
   switch (name) {
-    case '@gip/repos': return collection0
-    case '@gip/branches': return collection1
-    case '@gip/files': return collection2
-    case '@gip/objects': return collection3
-    case '@gip/head': return collection5
-    case '@gip/tags': return collection6
-    default: return null
+    case '@gip/repos':
+      return collection0
+    case '@gip/branches':
+      return collection1
+    case '@gip/files':
+      return collection2
+    case '@gip/objects':
+      return collection3
+    case '@gip/head':
+      return collection5
+    case '@gip/tags':
+      return collection6
+    default:
+      return null
   }
 }
 
-function resolveIndex (name) {
+function resolveIndex(name) {
   switch (name) {
-    case '@gip/files-by-branch': return index4
-    default: return null
+    case '@gip/files-by-branch':
+      return index4
+    default:
+      return null
   }
 }

package/schema/hyperdb/messages.js

@@ -151,10 +151,10 @@ const encoding3_enum = {
 
 // @gip/object-type enum
 const encoding3 = {
-  preencode (state, m) {
+  preencode(state, m) {
     state.end++ // max enum is 4 so always one byte
   },
-  encode (state, m) {
+  encode(state, m) {
     switch (m) {
       case 'blob':
         c.uint.encode(state, 1)
@@ -172,7 +172,7 @@ const encoding3 = {
         throw new Error('Unknown enum')
     }
   },
-  decode (state) {
+  decode(state) {
     switch (c.uint.decode(state)) {
       case 1:
         return 'blob'
@@ -182,7 +182,8 @@ const encoding3 = {
         return 'commit'
       case 4:
         return 'tag'
-      default: return null
+      default:
+        return null
     }
   }
 }
@@ -252,10 +253,10 @@ const encoding6 = {
   },
   encode(state, m) {
     const flags =
-      ((version >= 3 && m.tagger) ? 1 : 0) |
-      ((version >= 3 && m.message) ? 2 : 0) |
-      ((version >= 3 && m.timestamp) ? 4 : 0) |
-      ((version >= 3 && m.objects) ? 8 : 0)
+      (version >= 3 && m.tagger ? 1 : 0) |
+      (version >= 3 && m.message ? 2 : 0) |
+      (version >= 3 && m.timestamp ? 4 : 0) |
+      (version >= 3 && m.objects ? 8 : 0)
 
     c.string.encode(state, m.name)
     c.string.encode(state, m.oid)
@@ -280,10 +281,10 @@ const encoding6 = {
       oid: r1,
       commitOid: r2,
       treeOid: r3,
-      tagger: (version >= 3 && (flags & 1) !== 0) ? c.string.decode(state) : null,
-      message: (version >= 3 && (flags & 2) !== 0) ? c.string.decode(state) : null,
-      timestamp: (version >= 3 && (flags & 4) !== 0) ? c.uint.decode(state) : 0,
-      objects: (version >= 3 && (flags & 8) !== 0) ? encoding6_7.decode(state) : null
+      tagger: version >= 3 && (flags & 1) !== 0 ? c.string.decode(state) : null,
+      message: version >= 3 && (flags & 2) !== 0 ? c.string.decode(state) : null,
+      timestamp: version >= 3 && (flags & 4) !== 0 ? c.uint.decode(state) : 0,
+      objects: version >= 3 && (flags & 8) !== 0 ? encoding6_7.decode(state) : null
     }
   }
 }
@@ -451,10 +452,10 @@ const encoding11 = {
   },
   encode(state, m) {
     const flags =
-      ((version >= 3 && m.tagger) ? 1 : 0) |
-      ((version >= 3 && m.message) ? 2 : 0) |
-      ((version >= 3 && m.timestamp) ? 4 : 0) |
-      ((version >= 3 && m.objects) ? 8 : 0)
+      (version >= 3 && m.tagger ? 1 : 0) |
+      (version >= 3 && m.message ? 2 : 0) |
+      (version >= 3 && m.timestamp ? 4 : 0) |
+      (version >= 3 && m.objects ? 8 : 0)
 
     c.string.encode(state, m.oid)
     c.string.encode(state, m.commitOid)
@@ -477,10 +478,10 @@ const encoding11 = {
       oid: r1,
       commitOid: r2,
       treeOid: r3,
-      tagger: (version >= 3 && (flags & 1) !== 0) ? c.string.decode(state) : null,
-      message: (version >= 3 && (flags & 2) !== 0) ? c.string.decode(state) : null,
-      timestamp: (version >= 3 && (flags & 4) !== 0) ? c.uint.decode(state) : 0,
-      objects: (version >= 3 && (flags & 8) !== 0) ? encoding11_7.decode(state) : null
+      tagger: version >= 3 && (flags & 1) !== 0 ? c.string.decode(state) : null,
+      message: version >= 3 && (flags & 2) !== 0 ? c.string.decode(state) : null,
+      timestamp: version >= 3 && (flags & 4) !== 0 ? c.uint.decode(state) : 0,
+      objects: version >= 3 && (flags & 8) !== 0 ? encoding11_7.decode(state) : null
     }
   }
 }

package/schema/hyperschema/index.js

@@ -151,10 +151,10 @@ const encoding3_enum = {
 
 // @gip/object-type enum
 const encoding3 = {
-  preencode (state, m) {
+  preencode(state, m) {
     state.end++ // max enum is 4 so always one byte
   },
-  encode (state, m) {
+  encode(state, m) {
     switch (m) {
       case 'blob':
         c.uint.encode(state, 1)
@@ -172,7 +172,7 @@ const encoding3 = {
         throw new Error('Unknown enum')
     }
   },
-  decode (state) {
+  decode(state) {
     switch (c.uint.decode(state)) {
       case 1:
         return 'blob'
@@ -182,7 +182,8 @@ const encoding3 = {
         return 'commit'
       case 4:
         return 'tag'
-      default: return null
+      default:
+        return null
     }
   }
 }
@@ -252,10 +253,10 @@ const encoding6 = {
   },
   encode(state, m) {
     const flags =
-      ((version >= 3 && m.tagger) ? 1 : 0) |
-      ((version >= 3 && m.message) ? 2 : 0) |
-      ((version >= 3 && m.timestamp) ? 4 : 0) |
-      ((version >= 3 && m.objects) ? 8 : 0)
+      (version >= 3 && m.tagger ? 1 : 0) |
+      (version >= 3 && m.message ? 2 : 0) |
+      (version >= 3 && m.timestamp ? 4 : 0) |
+      (version >= 3 && m.objects ? 8 : 0)
 
     c.string.encode(state, m.name)
     c.string.encode(state, m.oid)
@@ -280,10 +281,10 @@ const encoding6 = {
       oid: r1,
       commitOid: r2,
       treeOid: r3,
-      tagger: (version >= 3 && (flags & 1) !== 0) ? c.string.decode(state) : null,
-      message: (version >= 3 && (flags & 2) !== 0) ? c.string.decode(state) : null,
-      timestamp: (version >= 3 && (flags & 4) !== 0) ? c.uint.decode(state) : 0,
-      objects: (version >= 3 && (flags & 8) !== 0) ? encoding6_7.decode(state) : null
+      tagger: version >= 3 && (flags & 1) !== 0 ? c.string.decode(state) : null,
+      message: version >= 3 && (flags & 2) !== 0 ? c.string.decode(state) : null,
+      timestamp: version >= 3 && (flags & 4) !== 0 ? c.uint.decode(state) : 0,
+      objects: version >= 3 && (flags & 8) !== 0 ? encoding6_7.decode(state) : null
     }
   }
 }