gina 0.5.21 → 0.5.22

package/framework/{v0.5.21 → v0.5.22}/core/controller/controller.js

@@ -827,7 +827,16 @@ function SuperController(options) {
             local.options.conf.locales = userLocales;
 
             // user locale
-            options.conf.locale = new Collection(userLocales).findOne({ short: userCountryCode }) || {};
+            // #B101 — region rows key countries by `isoShort` (uppercase ISO
+            // 3166-1 alpha-2); the historical `short` filter matched a key the
+            // data never carried, so this resolved `{}` whenever a country code
+            // was present — and an arbitrary first record without one, because
+            // a filter whose only key is undefined-valued serializes to `{}`
+            // and matches everything. A country-less culture (bare `en`) now
+            // resolves to an explicit `{}` instead.
+            options.conf.locale = ( typeof(userCountryCode) == 'string' && userCountryCode.length > 0 )
+                ? ( new Collection(userLocales).findOne({ isoShort: userCountryCode.toUpperCase() }) || {} )
+                : {};
 
             // current date
             if ( typeof(options.conf.locale) == 'undefined' || !options.conf.locale ) {

package/framework/{v0.5.21 → v0.5.22}/core/plugins/lib/validator/src/form-validator.js

@@ -293,6 +293,15 @@ function FormValidatorUtil(data, $fields, xhrOptions, fieldsSet, culture) {
     };
 
     var compileError = function(error, data) {
+        // #B87: tolerate a non-string `error` from a future call site — the only
+        // current caller is string-gated at the query result site, but nothing in
+        // this function's own contract enforces it and `error.match()` throws on
+        // anything else. A non-string carries no `{{placeholder}}` to compile, so
+        // it is returned as-is; if it then lands in `replace()` as a label, the
+        // #B86 fail-soft degrades it to the English default with a warn.
+        if ( typeof(error) != 'string' ) {
+            return error;
+        }
         var varArr = error.match(/\{\{([^{{}}]+)\}\}/g );
         // `String.match` with a /g regex yields `null` — not [] — when nothing matches, so a
         // backend field error carrying no `{{placeholder}}` (the common shape, e.g. "Already
@@ -549,9 +558,11 @@ function FormValidatorUtil(data, $fields, xhrOptions, fieldsSet, culture) {
             }
         }
 
-        var onResult = function(result) {
+        var processQueryResult = function(result) {
 
-            _this.value      = local['data'][_this.name] = (_this.value) ? _this.value.toLowerCase() : _this.value;
+            // #B87: a boolean checkbox routed through a `query` rule carries a real
+            // boolean — `.toLowerCase()` only applies to string values
+            _this.value      = local['data'][_this.name] = (_this.value && typeof(_this.value) == 'string') ? _this.value.toLowerCase() : _this.value;
 
             var isValid     = result.isValid || false;
             if (validIf != isValid) {
@@ -661,22 +672,67 @@ function FormValidatorUtil(data, $fields, xhrOptions, fieldsSet, culture) {
             console.debug('prematurely completed event `'+ 'asyncCompleted.' + id +'`');
 
             return triggerEvent(gina, _this.target, 'asyncCompleted.' + id, self[_this['name']]);
-        } // EO onResult
+        } // EO processQueryResult
 
+        /**
+         * #B87 blanket guard: the XHR result lands asynchronously, so by the
+         * time it is processed the form may have been unbound or the field
+         * detached (e.g. a popin closed mid-flight) — a throw inside the
+         * processing used to leave `asyncCompleted.<id>` unfired, hanging the
+         * submit path's async waiter for the whole pass. Warn and release the
+         * waiter with the field state as-is: the query verdict is unknown,
+         * and the server re-validates on submit either way.
+         *
+         * @inner
+         * @param {object} err - Error thrown while handling the query result
+         *
+         * @returns {undefined}
+         */
+        var releaseQueryWaiter = function(err) {
+            console.warn('[ FormValidator ] `query` result handling failed for field `'+ (_this && _this.name) +'`: '+ ( err && err.message || err ));
+            try {
+                var _releaseId = _this.target && (_this.target.id || _this.target.getAttribute('id'));
+                if (_releaseId) {
+                    triggerEvent(gina, _this.target, 'asyncCompleted.' + _releaseId, self[_this['name']]);
+                }
+            } catch (ignore) {}
+        }
 
-        if (xhr) {
+        /**
+         * Guarded entry point for the XHR handlers below — delegates to
+         * `processQueryResult` and routes any throw to `releaseQueryWaiter`
+         * so the async waiter can never be left hanging (#B87).
+         *
+         * @inner
+         * @param {object} result - Parsed backend response
+         *
+         * @returns {undefined}
+         */
+        var onResult = function(result) {
+            try {
+                return processQueryResult(result);
+            } catch (err) {
+                return releaseQueryWaiter(err);
+            }
+        }
 
-            xhr.onerror = function(event, err) {
 
-                var error = 'Transaction error: might be due to the server CORS settings.\nPlease, check the console for more details.';
-                var result = {
-                    'status':  xhr.status, //500,
-                    'error' : error
-                };
+        if (xhr) {
 
-                console.debug('query error [2] detected !! ', err, error);
-                isOnException = true;
-                result = this.responseText;
+            xhr.onerror = function(event, err) {
+                // #B87: blanket-guarded like `xhr.onload` — a throw while shaping
+                // the error result (e.g. bad JSON under a JSON content-type) must
+                // release the async waiter, not hang it
+                try {
+                    var error = 'Transaction error: might be due to the server CORS settings.\nPlease, check the console for more details.';
+                    var result = {
+                        'status':  xhr.status, //500,
+                        'error' : error
+                    };
+
+                    console.debug('query error [2] detected !! ', err, error);
+                    isOnException = true;
+                    result = this.responseText;
                     var contentType     = this.getResponseHeader("Content-Type");
                     if ( /\/json/.test( contentType ) ) {
                         result = JSON.parse(this.responseText);
@@ -697,7 +753,9 @@ function FormValidatorUtil(data, $fields, xhrOptions, fieldsSet, culture) {
                         }
                         return onResult(result);
                     }
-
+                } catch (e) {
+                    return releaseQueryWaiter(e);
+                }
             }// Eo xhr.onerror
 
             // catching ready state cb
@@ -765,7 +823,9 @@ function FormValidatorUtil(data, $fields, xhrOptions, fieldsSet, culture) {
                         return onResult(result);
                     }
                 } catch (err) {
-                    throw err;
+                    // #B87: a malformed response (e.g. bad JSON under a JSON
+                    // content-type) must release the async waiter, not hang it
+                    return releaseQueryWaiter(err);
                 }
             }// xhr.onload = function () {
 

package/framework/{v0.5.21 → v0.5.22}/core/plugins/lib/validator/src/main.js

@@ -4782,6 +4782,27 @@ function ValidatorPlugin(rules, data, formId, culture) {
     var isCheckboxValueAsState = function($form) {
         return /^true$/i.test($form.target.dataset.ginaFormCheckboxValueAsState) ? true : false;
     }
+
+    /**
+     * #B125: tells whether the form EXPLICITLY declares the checkbox state
+     * model via `data-gina-form-checkbox-value-as-state` — any value counts:
+     * "true" is the legacy opt-in, anything else (canonically "false")
+     * declares the spec model. The #49 migration warns only fire when the
+     * attribute is entirely absent: an author who declares the model has
+     * already read it, so the migration aid has nothing left to teach — and
+     * the payload-only shape (`value="true"` with no `checked`, intended
+     * unticked) is legitimate post-#49 markup that is byte-identical to
+     * pre-#49 markup at the attribute level, so the declaration is the only
+     * intent signal available.
+     *
+     * @inner
+     * @param {object} $form - Form object (`instance.$forms[id]` shape)
+     *
+     * @returns {boolean} isCheckboxStateModelDeclared
+     */
+    var isCheckboxStateModelDeclared = function($form) {
+        return ( typeof($form.target.dataset.ginaFormCheckboxValueAsState) != 'undefined' ) ? true : false;
+    }
     // one warn per field id per page load (migration aid, #49)
     var checkboxValueStateWarned = {};
 
@@ -5108,12 +5129,13 @@ function ValidatorPlugin(rules, data, formId, culture) {
                     if (
                         /^(checkbox)$/i.test($inputs[f].type)
                         && !isCheckboxValueAsState($form)
+                        && !isCheckboxStateModelDeclared($form)
                         && !$inputs[f].hasAttribute('checked')
                         && /^(true|on)$/i.test($inputs[f].getAttribute('value'))
                         && !checkboxValueStateWarned[elId]
                     ) {
                         checkboxValueStateWarned[elId] = true;
-                        console.warn('[ FormValidator ] checkbox `'+ elId +'`: `value` no longer implies the checked state; add the `checked` attribute if it must render ticked, or set `data-gina-form-checkbox-value-as-state="true"` on the form to restore the legacy behavior');
+                        console.warn('[ FormValidator ] checkbox `'+ elId +'`: `value` no longer implies the checked state; add the `checked` attribute if it must render ticked, or set `data-gina-form-checkbox-value-as-state="true"` on the form to restore the legacy behavior. If the unticked rendering is intended, remove the `value` attribute (a boolean checkbox posts its live checked state either way), or set `data-gina-form-checkbox-value-as-state="false"` on the form to declare the current model and silence migration warnings');
                     }
 
                     // Migration aid (#49) — the mirror direction: this markup used to be
@@ -5127,12 +5149,13 @@ function ValidatorPlugin(rules, data, formId, culture) {
                     if (
                         /^(checkbox)$/i.test($inputs[f].type)
                         && !isCheckboxValueAsState($form)
+                        && !isCheckboxStateModelDeclared($form)
                         && $inputs[f].hasAttribute('checked')
                         && ( legacyUntickValue === '' || /^false$/i.test(legacyUntickValue) )
                         && !checkboxValueStateWarned[elId]
                     ) {
                         checkboxValueStateWarned[elId] = true;
-                        console.warn('[ FormValidator ] checkbox `'+ elId +'`: `value` no longer un-ticks a checked box; remove the `checked` attribute if it must render unticked, or set `data-gina-form-checkbox-value-as-state="true"` on the form to restore the legacy behavior');
+                        console.warn('[ FormValidator ] checkbox `'+ elId +'`: `value` no longer un-ticks a checked box; remove the `checked` attribute if it must render unticked, or set `data-gina-form-checkbox-value-as-state="true"` on the form to restore the legacy behavior. If the ticked rendering is intended, set `data-gina-form-checkbox-value-as-state="false"` on the form to declare the current model and silence migration warnings');
                     }
                 }
             }
@@ -7423,9 +7446,32 @@ function ValidatorPlugin(rules, data, formId, culture) {
                 if ( /^is\d+$/.test(rule) && typeof(d[field][rule]) == 'undefined' ) { // is aliases
                     d[field][rule] = function(){};
                     d[field][rule] = inherits(d[field][rule], d[field][ rule.replace(/\d+/, '') ]);
-                    d[field][rule].setAlias = (function(alias) {
-                        this._currentValidatorAlias = alias
-                    }(rule));
+                    // #B138 — arm the alias handshake PER INVOCATION, not per install.
+                    // The old install-time IIFE armed the shared `_currentValidatorAlias`
+                    // slot ONCE (this install branch is gated once-per-instance), while
+                    // form-validator's is() CONSUMES the slot with a delete on every
+                    // call — so on any re-application against the same instance (a
+                    // `conditions`/_case_ re-evaluation, forEachField recursion) the
+                    // slot was empty: every numbered rule collapsed onto the shared key
+                    // 'is', the last-declared rule overwrote its siblings there, and its
+                    // message rendered TWICE (its own key + the collapsed 'is' key — the
+                    // error-display loop has no message dedup). The wrapper re-arms the
+                    // slot immediately before every delegation, so is<N> keys stay
+                    // distinct on every application. Root resolution mirrors
+                    // form-validator's _aliasRoot (browser window / server global).
+                    // was:
+                    // d[field][rule].setAlias = (function(alias) {
+                    //     this._currentValidatorAlias = alias
+                    // }(rule));
+                    d[field][rule] = (function (aliasName, composed) {
+                        return function () {
+                            var _aliasRoot = ( typeof(window) != 'undefined' ) ? window : ( ( typeof(global) != 'undefined' ) ? global : null );
+                            if (_aliasRoot) {
+                                _aliasRoot._currentValidatorAlias = aliasName;
+                            }
+                            return composed.apply(this, arguments);
+                        };
+                    }(rule, d[field][rule]));
                 }
                 // skip when not processing rule function
                 if ( typeof(d[field][rule]) != 'function' ) {

package/framework/{v0.5.21 → v0.5.22}/core/server.js

@@ -3427,7 +3427,19 @@ function Server(options) {
 
 
 
-            request.setEncoding(self.conf[self.appName][self.env].encoding);
+            // #B103 (2026-07-20) — a multipart body must reach busboy RAW (Buffers):
+            // decoding the request stream to strings mangles every byte sequence that
+            // is not valid UTF-8 (→ U+FFFD) BEFORE busboy even parses, so binary file
+            // payloads arrived pre-corrupted (and re-encoded ~1.5-2x larger). The
+            // decode stays for every other content-type — the non-multipart branches
+            // accumulate request.body as text. Same flag is reused by the multipart
+            // branch below so the two sites cannot drift.
+            // was:
+            // request.setEncoding(self.conf[self.appName][self.env].encoding);
+            request.isMultipart = /multipart\/form-data;/.test(request.headers['content-type'] || '');
+            if ( !request.isMultipart ) {
+                request.setEncoding(self.conf[self.appName][self.env].encoding);
+            }
             // be carfull, if you are using jQuery + cross domain, you have to set the header manually in your $.ajax query -> headers: {'X-Requested-With': 'XMLHttpRequest'}
             request.isXMLRequest       = ( request.headers['x-requested-with'] && request.headers['x-requested-with'] == 'XMLHttpRequest' ) ? true : false;
 
@@ -4213,7 +4225,10 @@ function Server(options) {
                 // multipart wrapper for uploads
                 // files are available from your controller or any middlewares:
                 //  @param {object} req.files
-                if ( /multipart\/form-data;/.test(request.headers['content-type']) ) {
+                // #B103 — flag computed once at the request prologue (where it also
+                // gates request.setEncoding: a multipart body must stay RAW for busboy).
+                // was: if ( /multipart\/form-data;/.test(request.headers['content-type']) ) {
+                if ( request.isMultipart ) {
                     // TODO - get options from settings.json & settings.{env}.json ...
                     // -> https://github.com/mscdex/busboy
                     var opt = self.conf[self.appName][self.env].content.settings.upload;
@@ -4568,12 +4583,21 @@ function Server(options) {
                         var liner = new require('stream').Transform({objectMode: true});
 
                         liner._transform = function (chunk, encoding, done) {
-
-                            var str = chunk.toString();
-                            file._dataLen += str.length;
-
-                            var ab = Buffer.from(str2ab(str));
-                            this.push(ab)
+                            // #B103 (2026-07-20) — pass the Buffer through VERBATIM. The historical
+                            // toString()/str2ab round-trip utf8-decoded every chunk (invalid sequences
+                            // → U+FFFD) and then truncated each UTF-16 code unit mod 256, so any byte
+                            // sequence that is not valid UTF-8 was mangled — binary uploads corrupted,
+                            // while pure-ASCII payloads survived byte-identical, which is what hid it.
+                            // Counting chunk.length (bytes, not post-decode UTF-16 chars) also makes
+                            // req.files[].size the real on-disk size.
+                            // was:
+                            // var str = chunk.toString();
+                            // file._dataLen += str.length;
+                            //
+                            // var ab = Buffer.from(str2ab(str));
+                            // this.push(ab)
+                            file._dataLen += chunk.length;
+                            this.push(chunk);
 
                             done()
                         }
@@ -4782,7 +4806,10 @@ function Server(options) {
                 if ( typeof(request.body) == 'string' ) {
                     // get rid of encoding issues
                     try {
-                        if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        // #B103 — same header test as the request-prologue flag; read the flag
+                        // so the multipart content-type regex exists at exactly one site.
+                        // was: if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        if ( !request.isMultipart ) {
                             if ( /application\/json/i.test(request.headers['content-type']) ) {
                                 // #B28 — application/json: parse the body verbatim. JSON already
                                 // carries real types, so do NOT url-decode (a %XX inside a string
@@ -4976,7 +5003,10 @@ function Server(options) {
                 if ( typeof(request.body) == 'string' ) {
                     // get rid of encoding issues
                     try {
-                        if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        // #B103 — same header test as the request-prologue flag; read the flag
+                        // so the multipart content-type regex exists at exactly one site.
+                        // was: if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        if ( !request.isMultipart ) {
                             if ( /application\/json/i.test(request.headers['content-type']) ) {
                                 // #B28 — application/json: parse the body verbatim. JSON already
                                 // carries real types, so do NOT url-decode (a %XX inside a string
@@ -5086,7 +5116,10 @@ function Server(options) {
                 var isPatchSet = false, msg = null;
                 if ( typeof(request.body) == 'string' ) {
                     try {
-                        if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        // #B103 — same header test as the request-prologue flag; read the flag
+                        // so the multipart content-type regex exists at exactly one site.
+                        // was: if ( !/multipart\/form-data;/.test(request.headers['content-type']) ) {
+                        if ( !request.isMultipart ) {
                             if ( /application\/json/i.test(request.headers['content-type']) ) {
                                 // #B28 — application/json: parse the body verbatim. JSON already
                                 // carries real types, so do NOT url-decode (a %XX inside a string
@@ -5816,6 +5849,30 @@ function Server(options) {
                     && process.gina._i18nCatalogs[_i18nBundle] )
                     ? Object.keys(process.gina._i18nCatalogs[_i18nBundle])
                     : [];
+                // #B102 — `settings.i18n.cultures`, honoured since 0.5.22: a
+                // non-empty array constrains which cultures the USER-SIGNAL
+                // steps (URL prefix / cookie / Accept-Language) may match —
+                // e.g. a staged rollout keeps a shipped-but-unlaunched catalog
+                // out of negotiation. The bundle-default step
+                // (settings.region.culture) is deliberately NOT constrained —
+                // the operator's fallback needs no catalog match. `null`, `[]`
+                // or a non-array keep the historical derive-from-loaded-
+                // catalogs behavior.
+                if ( _i18nAvail.length > 0
+                    && _i18nBundle
+                    && self.conf[_i18nBundle]
+                    && self.conf[_i18nBundle][self.env]
+                    && self.conf[_i18nBundle][self.env].content
+                    && self.conf[_i18nBundle][self.env].content.settings
+                    && self.conf[_i18nBundle][self.env].content.settings.i18n
+                ) {
+                    var _i18nCulturesConf = self.conf[_i18nBundle][self.env].content.settings.i18n.cultures;
+                    if ( Array.isArray(_i18nCulturesConf) && _i18nCulturesConf.length > 0 ) {
+                        _i18nAvail = _i18nAvail.filter(function(c) {
+                            return _i18nCulturesConf.indexOf(c) > -1;
+                        });
+                    }
+                }
                 // #I18N — bundle-level default culture: settings.region.culture
                 // (full underscore culture, e.g. `xx_XX`, resolved at bundle:add).
                 // Ranks below URL/cookie/Accept-Language (which need loaded catalogs

package/framework/{v0.5.21 → v0.5.22}/core/template/conf/package.json

@@ -5,7 +5,7 @@
   "dependencies": {
     // "gina" : "${gina_version}"
   },
-  "engine": [
-    "node >=${node_version}"
-  ]
+  "engines": {
+    "node": ">=${node_version}"
+  }
 }

package/framework/{v0.5.21 → v0.5.22}/core/template/conf/settings.json

@@ -567,8 +567,12 @@
   //                   (specific → base → settings.region.culture →
   //                   GINA_CULTURE → "en"). `null` = use the default.
   //                   Example: ["en", "fr"] forces a fixed fallback.
-  //   cultures      — RESERVED: explicit URL-prefix allowlist. Not currently
-  //                   consumed — cultures derive from the loaded catalogs.
+  //   cultures      — explicit culture allowlist for the user-signal
+  //                   negotiation steps (URL prefix / cookie / Accept-Language),
+  //                   honoured since 0.5.22. A non-empty array constrains
+  //                   matching (staged rollouts); `null` derives from the
+  //                   loaded catalogs. The bundle-default step
+  //                   (settings.region.culture) is never constrained.
   "i18n": {
     "cookieName": "gina_culture",
     "devMissingKey": "[MISSING]",

package/framework/{v0.5.21 → v0.5.22}/lib/cmd/image/build.js

@@ -239,7 +239,7 @@ function Build(opt, cmd) {
                 tag             : self.tagRef,
                 ginaVersion     : self.ginaVersion,
                 platform        : self.platform,
-                nodeEngine      : (ginaPkg.engine && ginaPkg.engine.node) || null,
+                nodeEngine      : (ginaPkg.engines && ginaPkg.engines.node) || (ginaPkg.engine && ginaPkg.engine.node) || null,
                 hasDependencies : hasDependencies,
                 hasLockfile     : hasLockfile
             });

package/framework/{v0.5.21 → v0.5.22}/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gina-framework",
-  "version": "0.5.21",
+  "version": "0.5.22",
   "dependencies": {
     "@rhinostone/busboy": "^1.6.1",
     "@rhinostone/swig": "^2.7.2",

package/gna.js

@@ -15,14 +15,14 @@
 'use strict';
 
 // Framework core — the main gna module (lifecycle hooks, lib, etc.)
-var _gna = require('./framework/v0.5.21/core/gna');
+var _gna = require('./framework/v0.5.22/core/gna');
 
 // SuperController and EntitySuper — loaded from their source modules
-var SuperController = require('./framework/v0.5.21/core/controller');
-var EntitySuper     = require('./framework/v0.5.21/core/model/entity');
+var SuperController = require('./framework/v0.5.22/core/controller');
+var EntitySuper     = require('./framework/v0.5.22/core/model/entity');
 
 // uuid — from the lib registry
-var uuid = require('./framework/v0.5.21/lib/uuid');
+var uuid = require('./framework/v0.5.22/lib/uuid');
 
 module.exports = {