ghreview 3.0.38 → 3.0.39

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [3.0.39](https://github.com/rvagg/ghreview/compare/v3.0.38...v3.0.39) (2026-11-02)
+
+### Trivial Changes
+
+* **deps:** update simple-git@4 ([#101](https://github.com/rvagg/ghreview/issues/101)) ([e8111ae](https://github.com/rvagg/ghreview/commit/e8111ae9d290a7b6aeec049ec374dfaa255b58e0))
+
 ## [3.0.38](https://github.com/rvagg/ghreview/compare/v3.0.37...v3.0.38) (2026-11-02)
 
 ### Trivial Changes

package/lib/git.js

@@ -1,4 +1,4 @@
-import simpleGit from 'simple-git'
+import { simpleGit } from 'simple-git'
 
 export async function getCurrentBranch () {
   const git = simpleGit()
@@ -21,7 +21,10 @@ export async function hasReviewableChanges ({ all = false } = {}) {
 }
 
 export async function createReviewCommit (message, authorConfig, { all = false } = {}) {
-  const git = simpleGit()
+  const { name, email } = authorConfig ?? {}
+  // user.name and user.email set both author and committer
+  const config = name && email ? [`user.name=${name}`, `user.email=${email}`] : []
+  const git = simpleGit({ config })
 
   if (all) {
     await git.add('.')
@@ -30,17 +33,7 @@ export async function createReviewCommit (message, authorConfig, { all = false }
     await git.add(['-u'])
   }
 
-  // Set up environment for custom author if provided
-  const env = {}
-  if (authorConfig?.name && authorConfig?.email) {
-    env.GIT_AUTHOR_NAME = authorConfig.name
-    env.GIT_AUTHOR_EMAIL = authorConfig.email
-    env.GIT_COMMITTER_NAME = authorConfig.name
-    env.GIT_COMMITTER_EMAIL = authorConfig.email
-  }
-
-  // Create commit with optional custom author
-  await git.env(env).commit(message)
+  await git.commit(message)
 }
 
 export async function pushBranch (remote, branch) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ghreview",
-  "version": "3.0.38",
+  "version": "3.0.39",
   "description": "GitHub PR-based code review workflow for AI-assisted development",
   "type": "module",
   "main": "lib/index.js",
@@ -28,7 +28,7 @@
     "chalk": "^6.0.0",
     "ghauth": "^7.0.0",
     "ora": "^9.0.0",
-    "simple-git": "^3.28.0",
+    "simple-git": "^4.0.2",
     "yargs": "^18.0.0"
   },
   "devDependencies": {

package/test/git.test.js

@@ -0,0 +1,41 @@
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { execFileSync } from 'node:child_process'
+import { mkdtemp, rm, appendFile } from 'node:fs/promises'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import { createReviewCommit } from '../lib/git.js'
+
+const run = (dir, ...args) => execFileSync('git', args, { cwd: dir, encoding: 'utf8' }).trim()
+
+describe('createReviewCommit', () => {
+  let dir
+
+  beforeEach(async () => {
+    dir = await mkdtemp(join(tmpdir(), 'ghreview-git-'))
+    run(dir, 'init', '-q')
+    run(dir, 'config', 'user.name', 'Local User')
+    run(dir, 'config', 'user.email', 'local@example.com')
+    await appendFile(join(dir, 'file.txt'), 'one\n')
+    run(dir, 'add', 'file.txt')
+    run(dir, 'commit', '-q', '-m', 'initial')
+    await appendFile(join(dir, 'file.txt'), 'two\n')
+    vi.spyOn(process, 'cwd').mockReturnValue(dir)
+  })
+
+  afterEach(async () => {
+    vi.restoreAllMocks()
+    await rm(dir, { recursive: true, force: true })
+  })
+
+  const identity = () => run(dir, 'log', '-1', '--format=%an <%ae>|%cn <%ce>|%s')
+
+  it('commits as the configured author and committer', async () => {
+    await createReviewCommit('review', { name: 'AI Assistant', email: 'ai@example.com' })
+    expect(identity()).toBe('AI Assistant <ai@example.com>|AI Assistant <ai@example.com>|review')
+  })
+
+  it('commits with the git identity when no author is configured', async () => {
+    await createReviewCommit('review')
+    expect(identity()).toBe('Local User <local@example.com>|Local User <local@example.com>|review')
+  })
+})