ghost 6.64.0 → 6.65.0

package/core/frontend/services/theme-engine/handlebars/utils.js

@@ -1,7 +1,7 @@
 const _ = require('lodash');
 
 module.exports.findKey = function findKey(key /* ...objects... */) {
-  let objects = Array.prototype.slice.call(arguments, 1);
+  const objects = Array.prototype.slice.call(arguments, 1);
 
   return _.reduceRight(
     objects,
@@ -40,8 +40,8 @@ function _urlParentMatch(href, location) {
   }
 
   let parent = false;
-  let locParts = _urlClean(location).split('/');
-  let hrefParts = _urlClean(href).split('/');
+  const locParts = _urlClean(location).split('/');
+  const hrefParts = _urlClean(href).split('/');
 
   if (locParts.length <= hrefParts.length) {
     return false;
@@ -55,11 +55,11 @@ function _urlParentMatch(href, location) {
 }
 
 module.exports.buildLinkClasses = function buildLinkClasses(siteUrl, href, options) {
-  let relativeHref = href.replace(siteUrl, '');
-  let location = options.data.root.relativeUrl;
-  let classes = options.hash.class ? options.hash.class.toString().split(' ') : [];
-  let activeClass = _.has(options.hash, 'activeClass') ? options.hash.activeClass : 'nav-current';
-  let parentActiveClass = _.has(options.hash, 'parentActiveClass')
+  const relativeHref = href.replace(siteUrl, '');
+  const location = options.data.root.relativeUrl;
+  const classes = options.hash.class ? options.hash.class.toString().split(' ') : [];
+  const activeClass = _.has(options.hash, 'activeClass') ? options.hash.activeClass : 'nav-current';
+  const parentActiveClass = _.has(options.hash, 'parentActiveClass')
     ? options.hash.parentActiveClass
     : `${activeClass || 'nav-current'}-parent`;
 

package/core/frontend/services/theme-engine/i18n/i18n.js

@@ -62,10 +62,9 @@ class I18n {
    * @returns {string}
    */
   t(translationPath, bindings) {
-    let string;
     let msg;
 
-    string = this._findString(translationPath);
+    const string = this._findString(translationPath);
 
     // If the path returns an array (as in the case with anything that has multiple paragraphs such as emails), then
     // loop through them and return an array of translated/formatted strings. Otherwise, just return the normal
@@ -153,7 +152,7 @@ class I18n {
    */
   _findString(msgPath, opts) {
     const options = merge({ log: true }, opts || {});
-    let candidateString;
+
     let matchingString;
 
     // no path? no string
@@ -167,7 +166,7 @@ class I18n {
       this._handleUninitialisedError(msgPath);
     }
 
-    candidateString = this._getCandidateString(msgPath);
+    const candidateString = this._getCandidateString(msgPath);
 
     matchingString = candidateString || {};
 
@@ -219,7 +218,7 @@ class I18n {
    * @param {Object} bindings
    */
   _formatMessage(string, bindings) {
-    let currentLocale = this.locale();
+    const currentLocale = this.locale();
     let msg = new MessageFormat(string, currentLocale);
 
     try {

package/core/frontend/services/theme-engine/middleware/update-global-template-options.js

@@ -6,7 +6,7 @@ const labs = require('../../../../shared/labs');
 const activeTheme = require('../active');
 
 function getSiteData() {
-  let siteData = settingsCache.getPublic();
+  const siteData = settingsCache.getPublic();
 
   // theme-only computed property added to @site
   if (settingsCache.get('members_signup_access') === 'none') {

package/core/frontend/services/theme-engine/preview.js

@@ -27,7 +27,7 @@ function getPreviewData(previewHeader, customThemeSettingKeys = []) {
     hf: 'heading_font',
   };
 
-  let opts = new URLSearchParams(previewHeader);
+  const opts = new URLSearchParams(previewHeader);
 
   const previewData = {};
 

package/core/frontend/utils/member-count.js

@@ -11,9 +11,9 @@ const { api } = require('../services/proxy');
  * }>}
  */
 async function getMemberStats() {
-  let memberStats = this.data || (await api.stats.memberCountHistory.query());
+  const memberStats = this.data || (await api.stats.memberCountHistory.query());
   const { free, paid, comped, gift } = memberStats.meta.totals;
-  let total = free + paid + comped + gift;
+  const total = free + paid + comped + gift;
   return { free, paid, comped, gift, total };
 }
 

package/core/frontend/web/routers/serve-public-file.js

@@ -36,7 +36,7 @@ function createPublicFileMiddleware(location, file, mime, maxAge, options = {})
   // These files are built on the fly, and must be saved in the content folder
   const builtFilePath = config.getContentPath('public');
 
-  let locationPath = location === 'static' ? staticFilePath : builtFilePath;
+  const locationPath = location === 'static' ? staticFilePath : builtFilePath;
 
   const filePath = file.match(/^public/)
     ? path.join(locationPath, file.replace(/^public/, ''))

package/core/server/adapters/scheduling/README.md

@@ -19,6 +19,10 @@ and `unschedule`, and inherit a registry of reschedulers from
   a job's fire time.
 - `build-signed-job.ts` — builds an adapter job whose callback URL carries
   that signed token, from an Admin API path and fire time.
+- `get-scheduler-idempotency-key.ts` — `getSchedulerIdempotencyKey`, which
+  derives the idempotency key a job carries from its consumer namespace, fire
+  time, and final callback URL, so a persistent queue can recognise a
+  re-registration of a job it already holds.
 - `signed-flush-scheduler.ts` — `SignedFlushScheduler`, a flush-queue
   primitive on top of the two above: arms one job per fire time (deduplicated
   in memory), skips already-due times in favour of the caller's own recovery

package/core/server/adapters/scheduling/get-scheduler-idempotency-key.js

@@ -0,0 +1,21 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.getSchedulerIdempotencyKey = getSchedulerIdempotencyKey;
+const node_crypto_1 = __importDefault(require("node:crypto"));
+/**
+ * Builds the idempotency key a scheduling adapter sends alongside a job, so a
+ * queue with persistent storage can recognise a re-registration of a job it
+ * already holds instead of creating a duplicate.
+ *
+ * The key is a hash rather than the raw inputs so it stays well inside the
+ * scheduler's 255-character printable-ASCII limit whatever the URL length.
+ */
+function getSchedulerIdempotencyKey({ namespace, date, url, }) {
+    const hash = node_crypto_1.default.createHash('sha256');
+    hash.update(date.toISOString());
+    hash.update(url.href);
+    return `ghost-${namespace}-${hash.digest('hex')}`;
+}

package/core/server/adapters/storage/LocalStorageBase.js

@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 // # Local File Base Storage module
 // The (default) module for storing files using the local file system
 const fs_extra_1 = __importDefault(require("fs-extra"));
+const os_1 = __importDefault(require("os"));
 const path_1 = __importDefault(require("path"));
 const tpl_1 = __importDefault(require("@tryghost/tpl"));
 const errors_1 = __importDefault(require("@tryghost/errors"));
@@ -27,7 +28,7 @@ class LocalStorageBase extends ghost_storage_base_1.StorageBase {
     errorMessages;
     constructor({ storagePath, staticFileURLPrefix, siteUrl, errorMessages, }) {
         super();
-        this.storagePath = storagePath;
+        this.storagePath = storagePath ?? os_1.default.tmpdir();
         this.staticFileURLPrefix = staticFileURLPrefix;
         this.siteUrl = siteUrl;
         this.staticFileUrl = `${siteUrl}${staticFileURLPrefix}`;

package/core/server/api/endpoints/automated-emails.js

@@ -6,6 +6,7 @@ const memberWelcomeEmailService = require('../../services/member-welcome-emails/
 const emailAddressService = require('../../services/email-address');
 const {
   DEFAULT_EMAIL_DESIGN_SETTING_SLUG,
+  MEMBER_WELCOME_EMAIL_SLUGS,
 } = require('../../services/member-welcome-emails/constants');
 const { validateEmailSenderFields } = require('./utils/validate-email-sender-fields');
 const { restrictAdminApiQueryOptions } = require('./utils/api-filter-utils');
@@ -23,6 +24,10 @@ const AUTOMATION_FIELDS = ['status', 'name', 'slug'];
 const EMAIL_FIELDS = ['subject', 'lexical', 'email_design_setting_id'];
 const SENDER_FIELDS = ['sender_name', 'sender_email', 'sender_reply_to'];
 
+const MEMBER_WELCOME_EMAIL_FILTER = Object.values(MEMBER_WELCOME_EMAIL_SLUGS)
+  .map((slug) => `slug:${slug}`)
+  .join(',');
+
 function flattenAutomation(
   automation,
   email = automation.related('welcomeEmailAutomatedEmail'),
@@ -94,11 +99,12 @@ const controller = {
     headers: {
       cacheInvalidate: false,
     },
-    options: ['filter', 'fields', 'limit', 'order', 'page'],
+    options: ['fields', 'limit', 'order', 'page'],
     permissions: true,
     async query(frame) {
       const result = await models.Automation.findPage({
         ...restrictAdminApiQueryOptions(frame.options),
+        filter: MEMBER_WELCOME_EMAIL_FILTER,
         withRelated: [
           'welcomeEmailAutomatedEmail',
           'welcomeEmailAutomatedEmail.emailDesignSetting',
@@ -118,7 +124,7 @@ const controller = {
     headers: {
       cacheInvalidate: false,
     },
-    options: ['filter', 'fields'],
+    options: ['fields'],
     data: ['id'],
     permissions: true,
     async query(frame) {

package/core/server/api/endpoints/db.js

@@ -66,7 +66,7 @@ const controller = {
     // eslint-disable-next-line ghost/ghost-custom/max-api-complexity
     async query(frame) {
       if (frame.options.filename) {
-        let backup = await dbBackup.readBackup(frame.options.filename);
+        const backup = await dbBackup.readBackup(frame.options.filename);
 
         if (!backup) {
           throw new errors.NotFoundError();

package/core/server/api/endpoints/emails.js

@@ -134,7 +134,7 @@ const controller = {
       method: 'browse',
     },
     async query() {
-      return emailAnalytics.newsletters.service.getStatus();
+      return emailAnalytics.getNewsletters().service.getStatus();
     },
   },
 
@@ -161,7 +161,7 @@ const controller = {
             ),
           );
 
-      return emailAnalytics.newsletters.service.schedule({ begin, end });
+      return emailAnalytics.getNewsletters().service.schedule({ begin, end });
     },
   },
 
@@ -173,7 +173,7 @@ const controller = {
       method: 'browse',
     },
     async query() {
-      return emailAnalytics.newsletters.service.cancelScheduled();
+      return emailAnalytics.getNewsletters().service.cancelScheduled();
     },
   },
 };

package/core/server/api/endpoints/mail.js

@@ -2,7 +2,7 @@ const tpl = require('@tryghost/tpl');
 const mailService = require('../../services/mail');
 const api = require('./');
 let mailer;
-let _private = {};
+const _private = {};
 
 const messages = {
   unableToSendEmail: 'Ghost is currently unable to send email.',

package/core/server/api/endpoints/member-signin-urls.js

@@ -17,7 +17,7 @@ const controller = {
     data: ['id'],
     permissions: true,
     async query(frame) {
-      let model = await membersService.api.members.get(frame.data, frame.options);
+      const model = await membersService.api.members.get(frame.data, frame.options);
 
       if (!model) {
         throw new errors.NotFoundError({

package/core/server/api/endpoints/members.js

@@ -230,7 +230,7 @@ const controller = {
           },
         });
       }
-      let model = await membersService.api.memberBREADService.read(
+      const model = await membersService.api.memberBREADService.read(
         { id: frame.options.id },
         { metafieldsFor: ADMIN },
       );
@@ -273,7 +273,7 @@ const controller = {
           stripe_price_id: frame.data.stripe_price_id,
         },
       });
-      let model = await membersService.api.memberBREADService.read(
+      const model = await membersService.api.memberBREADService.read(
         { id: frame.options.id },
         { metafieldsFor: ADMIN },
       );
@@ -431,7 +431,7 @@ const controller = {
     async query() {
       const memberStats = await membersService.api.events.getStatuses();
       const last = _.last(memberStats);
-      let totalMembers = last ? last.paid + last.free + last.comped + last.gift : 0;
+      const totalMembers = last ? last.paid + last.free + last.comped + last.gift : 0;
 
       return {
         resource: 'members',

package/core/server/api/endpoints/oembed.js

@@ -12,7 +12,7 @@ const controller = {
     data: ['url', 'type'],
     options: [],
     query({ data }) {
-      let { url, type } = data;
+      const { url, type } = data;
 
       return oembed.fetchOembedDataFromUrl(url, type);
     },

package/core/server/api/endpoints/posts.js

@@ -231,7 +231,7 @@ const controller = {
       unsafeAttrs: unsafeAttrs,
     },
     async query(frame) {
-      let model = await postsService.editPost(frame, {
+      const model = await postsService.editPost(frame, {
         eventHandler: (event, dto) => {
           const cacheInvalidate = getCacheHeaderFromEventString(event, dto);
           if (cacheInvalidate === true) {

package/core/server/api/endpoints/settings.js

@@ -146,9 +146,9 @@ const controller = {
       },
     },
     async query(frame) {
-      let stripeConnectData = await getStripeConnectData(frame);
+      const stripeConnectData = await getStripeConnectData(frame);
 
-      let result = await settingsBREADService.edit(
+      const result = await settingsBREADService.edit(
         frame.data.settings,
         frame.options,
         stripeConnectData,

package/core/server/api/endpoints/themes.js

@@ -26,7 +26,7 @@ const controller = {
     },
     permissions: true,
     async query() {
-      let themeName = settingsCache.get('active_theme');
+      const themeName = settingsCache.get('active_theme');
       const themeErrors = await themeService.api.getThemeErrors(themeName);
       return themeService.api.getJSON(themeName, themeErrors);
     },
@@ -46,7 +46,7 @@ const controller = {
     },
     permissions: true,
     async query(frame) {
-      let themeName = frame.options.name;
+      const themeName = frame.options.name;
 
       if (limitService.isLimited('customThemes')) {
         await limitService.errorIfWouldGoOverLimit('customThemes', { value: themeName });
@@ -118,7 +118,7 @@ const controller = {
       // @NOTE: consistent filename uploads
       frame.options.originalname = frame.file.originalname.toLowerCase();
 
-      let zip = {
+      const zip = {
         path: frame.file.path,
         name: frame.file.originalname,
       };
@@ -150,7 +150,7 @@ const controller = {
       method: 'read',
     },
     query(frame) {
-      let themeName = frame.options.name;
+      const themeName = frame.options.name;
 
       return themeService.api.getZip(themeName);
     },
@@ -171,7 +171,7 @@ const controller = {
     },
     permissions: true,
     query(frame) {
-      let themeName = frame.options.name;
+      const themeName = frame.options.name;
 
       return themeService.api.destroy(themeName);
     },

package/core/server/api/endpoints/utils/serializers/input/pages.js

@@ -98,8 +98,8 @@ function defaultFormat(frame) {
 }
 
 function handlePostsMeta(frame) {
-  let metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
-  let meta = _.pick(frame.data.pages[0], metaAttrs);
+  const metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
+  const meta = _.pick(frame.data.pages[0], metaAttrs);
   frame.data.pages[0].posts_meta = meta;
 }
 

package/core/server/api/endpoints/utils/serializers/input/posts.js

@@ -127,8 +127,8 @@ function defaultFormat(frame) {
 }
 
 function handlePostsMeta(frame) {
-  let metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
-  let meta = _.pick(frame.data.posts[0], metaAttrs);
+  const metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
+  const meta = _.pick(frame.data.posts[0], metaAttrs);
   frame.data.posts[0].posts_meta = meta;
 }
 

package/core/server/api/endpoints/utils/serializers/input/tags.js

@@ -5,7 +5,7 @@ const utils = require('../../index');
 const { rejectTagsRestrictedOrderFields } = require('../../api-filter-utils');
 
 function setDefaultOrder(frame) {
-  let defaultOrder = 'name asc';
+  const defaultOrder = 'name asc';
 
   if (!frame.options.order && frame.options.filter) {
     frame.options.autoOrder = slugFilterOrder('tags', frame.options.filter);

package/core/server/api/endpoints/utils/serializers/input/utils/slug-filter-order.js

@@ -1,10 +1,10 @@
 const slugFilterOrder = (table, filter) => {
-  let orderMatch = filter.match(/slug:\s?\[(.*)\]/);
+  const orderMatch = filter.match(/slug:\s?\[(.*)\]/);
 
   if (orderMatch) {
-    let orderSlugs = orderMatch[1].split(',');
-    let caseParts = [];
-    let bindings = [];
+    const orderSlugs = orderMatch[1].split(',');
+    const caseParts = [];
+    const bindings = [];
 
     orderSlugs.forEach((slug, index) => {
       caseParts.push(`WHEN \`${table}\`.\`slug\` = ? THEN ?`);

package/core/server/api/endpoints/utils/serializers/output/mappers/comments.js

@@ -118,11 +118,14 @@ const commentMapper = (model, frame) => {
     url.forPost(jsonModel.post.id, jsonModel.post, frame, routerType);
     response.post = _.pick(jsonModel.post, postFields);
 
-    // Compute excerpt from custom_excerpt or plaintext (same logic as post serializer)
-    if (jsonModel.post.custom_excerpt) {
-      response.post.excerpt = jsonModel.post.custom_excerpt;
-    } else if (jsonModel.post.plaintext) {
-      response.post.excerpt = jsonModel.post.plaintext.substring(0, 500);
+    // Excerpts can contain gated post content, so only Admin gets them
+    if (!isPublicRequest) {
+      // Compute excerpt from custom_excerpt or plaintext (same logic as post serializer)
+      if (jsonModel.post.custom_excerpt) {
+        response.post.excerpt = jsonModel.post.custom_excerpt;
+      } else if (jsonModel.post.plaintext) {
+        response.post.excerpt = jsonModel.post.plaintext.substring(0, 500);
+      }
     }
   }
 

package/core/server/api/endpoints/utils/serializers/output/mappers/posts.js

@@ -121,7 +121,7 @@ module.exports = async (model, frame, options = {}) => {
   }
 
   // Transforms post/page metadata to flat structure
-  let metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
+  const metaAttrs = _.keys(_.omit(postsMetaSchema, ['id', 'post_id']));
   _(metaAttrs)
     .filter((k) => {
       return !frame.options.columns || (frame.options.columns && frame.options.columns.includes(k));

package/core/server/api/endpoints/utils/serializers/output/pages.js

@@ -17,7 +17,7 @@ module.exports = {
     if (!models) {
       return;
     }
-    let pages = [];
+    const pages = [];
 
     const tiersPage = await tiersService.api.browse({});
     const tiers =
@@ -44,8 +44,8 @@ module.exports = {
       }) || [];
 
     if (models.meta) {
-      for (let model of models.data) {
-        let page = await mappers.pages(model, frame, { tiers });
+      for (const model of models.data) {
+        const page = await mappers.pages(model, frame, { tiers });
         pages.push(page);
       }
       frame.response = {
@@ -55,7 +55,7 @@ module.exports = {
 
       return;
     }
-    let page = await mappers.pages(models, frame, { tiers });
+    const page = await mappers.pages(models, frame, { tiers });
     frame.response = {
       pages: [page],
     };

package/core/server/api/endpoints/utils/serializers/output/posts.js

@@ -21,7 +21,7 @@ module.exports = {
     if (!models) {
       return;
     }
-    let posts = [];
+    const posts = [];
 
     const tiersPage = await tiersService.api.browse({});
     const tiers =
@@ -47,8 +47,8 @@ module.exports = {
         };
       }) || [];
     if (models.meta) {
-      for (let model of models.data) {
-        let post = await mappers.posts(model, frame, { tiers });
+      for (const model of models.data) {
+        const post = await mappers.posts(model, frame, { tiers });
         posts.push(post);
       }
       frame.response = {
@@ -58,7 +58,7 @@ module.exports = {
 
       return;
     }
-    let post = await mappers.posts(models, frame, { tiers });
+    const post = await mappers.posts(models, frame, { tiers });
     frame.response = {
       posts: [post],
     };

package/core/server/api/endpoints/utils/serializers/output/search-index.js

@@ -8,8 +8,8 @@ module.exports = {
   async fetchPosts(models, apiConfig, frame) {
     debug('fetchPosts');
 
-    let posts = [];
-    let keys = [];
+    const posts = [];
+    const keys = [];
 
     if (utils.isContentAPI(frame)) {
       keys.push('id', 'slug', 'title', 'excerpt', 'url', 'updated_at', 'visibility');
@@ -17,7 +17,7 @@ module.exports = {
       keys.push('id', 'uuid', 'url', 'title', 'slug', 'status', 'published_at', 'visibility');
     }
 
-    for (let model of models.data) {
+    for (const model of models.data) {
       let post = await mappers.posts(model, frame, {});
       post = _.pick(post, keys);
       posts.push(post);
@@ -31,11 +31,11 @@ module.exports = {
   async fetchPages(models, apiConfig, frame) {
     debug('fetchPages');
 
-    let pages = [];
+    const pages = [];
 
     const keys = ['id', 'uuid', 'url', 'title', 'slug', 'status', 'published_at', 'visibility'];
 
-    for (let model of models.data) {
+    for (const model of models.data) {
       let page = await mappers.pages(model, frame, {});
       page = _.pick(page, keys);
       pages.push(page);
@@ -49,11 +49,11 @@ module.exports = {
   async fetchTags(models, apiConfig, frame) {
     debug('fetchTags');
 
-    let tags = [];
+    const tags = [];
 
     const keys = ['id', 'slug', 'name', 'url'];
 
-    for (let model of models.data) {
+    for (const model of models.data) {
       let tag = await mappers.tags(model, frame);
       tag = _.pick(tag, keys);
       tags.push(tag);
@@ -67,11 +67,11 @@ module.exports = {
   async fetchAuthors(models, apiConfig, frame) {
     debug('fetchAuthors');
 
-    let authors = [];
+    const authors = [];
 
     const keys = ['id', 'slug', 'name', 'url', 'profile_image'];
 
-    for (let model of models.data) {
+    for (const model of models.data) {
       let author = await mappers.authors(model, frame);
       author = _.pick(author, keys);
       authors.push(author);
@@ -85,11 +85,11 @@ module.exports = {
   async fetchUsers(models, apiConfig, frame) {
     debug('fetchUsers');
 
-    let users = [];
+    const users = [];
 
     const keys = ['id', 'slug', 'name', 'url', 'profile_image'];
 
-    for (let model of models.data) {
+    for (const model of models.data) {
       let user = await mappers.users(model, frame);
       user = _.pick(user, keys);
       users.push(user);

package/core/server/api/endpoints/utils/serializers/output/settings.js

@@ -12,7 +12,7 @@ const mappers = require('./mappers');
  * @returns {*}
  */
 function settingsFilter(settings, filter) {
-  let filteredGroups = filter ? filter.split(',') : [];
+  const filteredGroups = filter ? filter.split(',') : [];
   return _.filter(settings, (setting) => {
     if (filteredGroups.length > 0) {
       return _.includes(filteredGroups, setting.group);

package/core/server/api/endpoints/utils/serializers/output/utils/extra-attrs.js

@@ -23,7 +23,7 @@ module.exports.forPost = (options, model, attrs) => {
   // 1. Gets excerpt from post's plaintext. If custom_excerpt exists, it overrides the excerpt but the key remains excerpt.
   if (columnsIncludesExcerpt) {
     if (!attrs.custom_excerpt) {
-      let plaintext = model.get('plaintext');
+      const plaintext = model.get('plaintext');
       if (plaintext) {
         attrs.excerpt = plaintext.substring(0, 500);
       } else {
@@ -39,7 +39,7 @@ module.exports.forPost = (options, model, attrs) => {
   }
 
   if (columnsIncludesPlaintext || formatsIncludesPlaintext) {
-    let plaintext = model.get('plaintext');
+    const plaintext = model.get('plaintext');
     if (plaintext) {
       attrs.plaintext = plaintext;
     } else {
@@ -49,7 +49,7 @@ module.exports.forPost = (options, model, attrs) => {
 
   // 3. Displays excerpt if no columns was requested - specifically needed for the Admin Posts API
   if (noColumnsRequested) {
-    let customExcerpt = model.get('custom_excerpt');
+    const customExcerpt = model.get('custom_excerpt');
 
     if (customExcerpt !== null) {
       attrs.excerpt = customExcerpt;