ghost 6.63.0 → 6.65.0

package/core/server/models/base/plugins/raw-knex.js

@@ -66,7 +66,7 @@ module.exports = function (Bookshelf) {
             },
           };
 
-          let query = Bookshelf.knex(tableNames[modelName]);
+          const query = Bookshelf.knex(tableNames[modelName]);
 
           if (orderBy) {
             query.orderBy(orderBy);
@@ -111,7 +111,7 @@ module.exports = function (Bookshelf) {
             return [];
           }
 
-          let props = {};
+          const props = {};
 
           if (!withRelated) {
             return _.map(objects, (object) => {
@@ -136,7 +136,7 @@ module.exports = function (Bookshelf) {
             props[relation.name] = (async () => {
               debug('fetch withRelated', relation.name);
 
-              let relationQuery = Bookshelf.knex(relation.targetTable);
+              const relationQuery = Bookshelf.knex(relation.targetTable);
 
               // default fields to select
               _.each(relation.select, (fieldToSelect) => {

package/core/server/models/base/plugins/sanitize.js

@@ -134,7 +134,7 @@ module.exports = function (Bookshelf) {
             let relations = data[property];
 
             // CASE: 1:1 relation will have single data point
-            if (!_.isArray(data[property])) {
+            if (!Array.isArray(data[property])) {
               relations = [data[property]];
             }
             _.each(relations, (relation, indexInArr) => {

package/core/server/models/benefit.js

@@ -7,7 +7,7 @@ const Benefit = ghostBookshelf.Model.extend(
     async onSaving(model, attr, options) {
       ghostBookshelf.Model.prototype.onSaving.call(this, model, attr, options);
       // Make sure name is trimmed of extra spaces
-      let name = this.get('name') && this.get('name').trim();
+      const name = this.get('name') && this.get('name').trim();
       this.set('name', name);
       if (this.hasChanged('slug') || (!this.get('slug') && this.get('name'))) {
         // Pass the new slug through the generator to strip illegal characters, detect duplicates

package/core/server/models/collection.js

@@ -92,7 +92,7 @@ const Collection = ghostBookshelf.Model.extend({
   },
 
   permittedAttributes() {
-    let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
+    const filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
 
     this.relationships.forEach((key) => {
       filteredKeys.push(key);

package/core/server/models/comment.js

@@ -180,7 +180,7 @@ const Comment = ghostBookshelf.Model.extend(
     },
 
     orderAttributes: function orderAttributes() {
-      let keys = ghostBookshelf.Model.prototype.orderAttributes.call(this, arguments);
+      const keys = ghostBookshelf.Model.prototype.orderAttributes.call(this, arguments);
       keys.push('count__likes');
       keys.push('count__net_score');
       keys.push('count__reports');
@@ -209,7 +209,7 @@ const Comment = ghostBookshelf.Model.extend(
   },
   {
     destroy: function destroy(unfilteredOptions) {
-      let options = this.filterOptions(unfilteredOptions, 'destroy', {
+      const options = this.filterOptions(unfilteredOptions, 'destroy', {
         extraAllowedProperties: ['id'],
       });
 
@@ -492,7 +492,7 @@ const Comment = ghostBookshelf.Model.extend(
      * @return {Array} Keys allowed in the `options` hash of the model's method.
      */
     permittedOptions: function permittedOptions(methodName) {
-      let options = ghostBookshelf.Model.permittedOptions.call(this, methodName);
+      const options = ghostBookshelf.Model.permittedOptions.call(this, methodName);
       options.push('parentId');
       options.push('isAdmin');
       options.push('browseAll');

package/core/server/models/invite.js

@@ -15,10 +15,7 @@ const messages = {
   notAllowedToInvite: 'Not allowed to invite this role.',
 };
 
-let Invite;
-let Invites;
-
-Invite = ghostBookshelf.Model.extend(
+const Invite = ghostBookshelf.Model.extend(
   {
     tableName: 'invites',
 
@@ -142,7 +139,7 @@ Invite = ghostBookshelf.Model.extend(
   },
 );
 
-Invites = ghostBookshelf.Collection.extend({
+const Invites = ghostBookshelf.Collection.extend({
   model: Invite,
 });
 

package/core/server/models/label.js

@@ -6,10 +6,7 @@ const messages = {
   labelNotFound: 'Label not found.',
 };
 
-let Label;
-let Labels;
-
-Label = ghostBookshelf.Model.extend(
+const Label = ghostBookshelf.Model.extend(
   {
     tableName: 'labels',
 
@@ -50,7 +47,7 @@ Label = ghostBookshelf.Model.extend(
 
       ghostBookshelf.Model.prototype.onSaving.apply(this, arguments);
       // Make sure name is trimmed of extra spaces
-      let name = this.get('name') && this.get('name').trim();
+      const name = this.get('name') && this.get('name').trim();
       this.set('name', name);
       if (this.hasChanged('slug') || (!this.get('slug') && this.get('name'))) {
         // Pass the new slug through the generator to strip illegal characters, detect duplicates
@@ -139,7 +136,7 @@ Label = ghostBookshelf.Model.extend(
   },
 );
 
-Labels = ghostBookshelf.Collection.extend({
+const Labels = ghostBookshelf.Collection.extend({
   model: Label,
 });
 

package/core/server/models/member.js

@@ -2,7 +2,7 @@ const ghostBookshelf = require('./base');
 const crypto = require('crypto');
 const _ = require('lodash');
 const { chainTransformers } = require('@tryghost/mongo-utils');
-const config = require('../../shared/config');
+const { memberAvatarImage } = require('../services/members/member-avatar');
 const { MemberCommentingCodec } = require('../services/members/commenting');
 const {
   METAFIELDS_RELATION,
@@ -588,7 +588,10 @@ const Member = ghostBookshelf.Model.extend(
      * has no access to the nested relations, which should be updated.
      */
     permittedAttributes: function permittedAttributes() {
-      let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
+      const filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(
+        this,
+        arguments,
+      );
 
       this.relationships.forEach((key) => {
         filteredKeys.push(key);
@@ -632,14 +635,8 @@ const Member = ghostBookshelf.Model.extend(
     toJSON(unfilteredOptions) {
       const attrs = ghostBookshelf.Model.prototype.toJSON.call(this, unfilteredOptions);
 
-      // Inject a computed avatar url. Uses gravatar's default ?d= query param
-      // to serve a blank image if there is no gravatar for the member's email.
-      // Will not use gravatar if privacy.useGravatar is false in config
-      attrs.avatar_image = null;
-      if (attrs.email && !config.isPrivacyDisabled('useGravatar')) {
-        const { gravatar } = require('../lib/image');
-        attrs.avatar_image = gravatar.url(attrs.email, { size: 250, default: 'blank' });
-      }
+      // Inject a computed avatar url, by the rule every place that shows a member shares.
+      attrs.avatar_image = memberAvatarImage(attrs.email);
 
       // Serialize commenting domain object to API format
       if (attrs.commenting) {

package/core/server/models/newsletter.js

@@ -85,7 +85,7 @@ const Newsletter = ghostBookshelf.Model.extend(
     },
 
     subscribeMembersById(memberIds, unfilteredOptions = {}) {
-      let pivotRows = [];
+      const pivotRows = [];
       for (const memberId of memberIds) {
         pivotRows.push({
           id: ObjectID().toHexString(),

package/core/server/models/permission.js

@@ -1,9 +1,6 @@
 const ghostBookshelf = require('./base');
 
-let Permission;
-let Permissions;
-
-Permission = ghostBookshelf.Model.extend({
+const Permission = ghostBookshelf.Model.extend({
   tableName: 'permissions',
 
   relationships: ['roles'],
@@ -17,7 +14,7 @@ Permission = ghostBookshelf.Model.extend({
    * has no access to the nested relations, which should be updated.
    */
   permittedAttributes: function permittedAttributes() {
-    let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
+    const filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
 
     this.relationships.forEach((key) => {
       filteredKeys.push(key);
@@ -35,7 +32,7 @@ Permission = ghostBookshelf.Model.extend({
   },
 });
 
-Permissions = ghostBookshelf.Collection.extend({
+const Permissions = ghostBookshelf.Collection.extend({
   model: Permission,
 });
 

package/core/server/models/post.js

@@ -40,7 +40,6 @@ const POST_REVISIONS_INTERVAL_MS = 10 * 60 * 1000; // 10 minutes
 const ALL_STATUSES = ['published', 'draft', 'scheduled', 'sent'];
 
 let Post;
-let Posts;
 
 Post = ghostBookshelf.Model.extend(
   {
@@ -253,7 +252,10 @@ Post = ghostBookshelf.Model.extend(
      * has no access to the nested relations, which should be updated.
      */
     permittedAttributes: function permittedAttributes() {
-      let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
+      const filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(
+        this,
+        arguments,
+      );
 
       this.relationships.forEach((key) => {
         filteredKeys.push(key);
@@ -263,10 +265,10 @@ Post = ghostBookshelf.Model.extend(
     },
 
     orderAttributes: function orderAttributes() {
-      let keys = ghostBookshelf.Model.prototype.orderAttributes.apply(this, arguments);
+      const keys = ghostBookshelf.Model.prototype.orderAttributes.apply(this, arguments);
 
       // extend ordered keys with post_meta keys
-      let postsMetaKeys = _.without(
+      const postsMetaKeys = _.without(
         ghostBookshelf.model('PostsMeta').prototype.orderAttributes(),
         'posts_meta.id',
         'posts_meta.post_id',
@@ -379,14 +381,13 @@ Post = ghostBookshelf.Model.extend(
     },
 
     emitChange: function emitChange(event, options = {}) {
-      let eventToTrigger;
       let resourceType = this.get('type');
 
       if (options.usePreviousAttribute) {
         resourceType = this.previous('type');
       }
 
-      eventToTrigger = resourceType + '.' + event;
+      const eventToTrigger = resourceType + '.' + event;
 
       ghostBookshelf.Model.prototype.emitChange.bind(this)(this, eventToTrigger, options);
     },
@@ -694,9 +695,9 @@ Post = ghostBookshelf.Model.extend(
        * CASE: Don't create new posts_meta entry if post meta is empty
        */
       if (!_.isUndefined(this.get('posts_meta')) && !_.isNull(this.get('posts_meta'))) {
-        let postsMetaData = this.get('posts_meta');
-        let relatedModelId = model.related('posts_meta').get('id');
-        let hasNoData = !_.values(postsMetaData).some((x) => !!x);
+        const postsMetaData = this.get('posts_meta');
+        const relatedModelId = model.related('posts_meta').get('id');
+        const hasNoData = !_.values(postsMetaData).some((x) => !!x);
         if (relatedModelId && !_.isEmpty(postsMetaData)) {
           postsMetaData.id = relatedModelId;
           this.set('posts_meta', postsMetaData);
@@ -1163,7 +1164,7 @@ Post = ghostBookshelf.Model.extend(
 
     toJSON: function toJSON(unfilteredOptions) {
       const options = Post.filterOptions(unfilteredOptions, 'toJSON');
-      let attrs = ghostBookshelf.Model.prototype.toJSON.call(this, options);
+      const attrs = ghostBookshelf.Model.prototype.toJSON.call(this, options);
 
       // CASE: never expose the mobiledoc revisions
       delete attrs.mobiledoc_revisions;
@@ -1402,7 +1403,7 @@ Post = ghostBookshelf.Model.extend(
      * **See:** [ghostBookshelf.Model.edit](base.js.html#edit)
      */
     edit: function edit(data, unfilteredOptions) {
-      let options = this.filterOptions(unfilteredOptions, 'edit', {
+      const options = this.filterOptions(unfilteredOptions, 'edit', {
         extraAllowedProperties: ['id'],
       });
 
@@ -1458,7 +1459,7 @@ Post = ghostBookshelf.Model.extend(
      * **See:** [ghostBookshelf.Model.add](base.js.html#add)
      */
     add: function add(data, unfilteredOptions) {
-      let options = this.filterOptions(unfilteredOptions, 'add', {
+      const options = this.filterOptions(unfilteredOptions, 'add', {
         extraAllowedProperties: ['id'],
       });
 
@@ -1486,7 +1487,7 @@ Post = ghostBookshelf.Model.extend(
     },
 
     destroy: function destroy(unfilteredOptions) {
-      let options = this.filterOptions(unfilteredOptions, 'destroy', {
+      const options = this.filterOptions(unfilteredOptions, 'destroy', {
         extraAllowedProperties: ['id'],
       });
 
@@ -1528,11 +1529,7 @@ Post = ghostBookshelf.Model.extend(
       hasUserPermission,
       hasApiKeyPermission,
     ) {
-      let { isContributor, isOwner, isAdmin, isEitherEditor } = setIsRoles(loadedPermissions);
-      let isIntegration;
-      let isEdit;
-      let isAdd;
-      let isDestroy;
+      const { isContributor, isOwner, isAdmin, isEitherEditor } = setIsRoles(loadedPermissions);
 
       function isChanging(attr) {
         return unsafeAttrs[attr] && unsafeAttrs[attr] !== postModel.get(attr);
@@ -1546,13 +1543,13 @@ Post = ghostBookshelf.Model.extend(
         return postModel.get('status') === 'draft';
       }
 
-      isIntegration =
+      const isIntegration =
         loadedPermissions.apiKey &&
         _.some(loadedPermissions.apiKey.roles, { name: 'Admin Integration' });
 
-      isEdit = action === 'edit';
-      isAdd = action === 'add';
-      isDestroy = action === 'destroy';
+      const isEdit = action === 'edit';
+      const isAdd = action === 'add';
+      const isDestroy = action === 'destroy';
 
       if (limitService.isLimited('members')) {
         // You can't publish a post if you're over your member limit
@@ -1671,7 +1668,7 @@ Post = ghostBookshelf.Model.extend(
   },
 );
 
-Posts = ghostBookshelf.Collection.extend({
+const Posts = ghostBookshelf.Collection.extend({
   model: Post,
 });
 

package/core/server/models/product.js

@@ -105,7 +105,10 @@ const Product = ghostBookshelf.Model.extend(
      * has no access to the nested relations, which should be updated.
      */
     permittedAttributes: function permittedAttributes() {
-      let filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(this, arguments);
+      const filteredKeys = ghostBookshelf.Model.prototype.permittedAttributes.apply(
+        this,
+        arguments,
+      );
 
       this.relationships.forEach((key) => {
         filteredKeys.push(key);

package/core/server/models/relations/authors.js

@@ -139,7 +139,7 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
       },
 
       serialize: function serialize(options) {
-        let attrs = proto.serialize.call(this, options);
+        const attrs = proto.serialize.call(this, options);
 
         // CASE: e.g. you stub model response in the test
         // CASE: you delete a model without fetching before
@@ -209,7 +209,7 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
                 .where(query)
                 .fetch(Object.assign({ columns: ['id'] }, _.pick(options, 'transacting')))
                 .then((user) => {
-                  let userId = user ? user.id : ownerUser.id;
+                  const userId = user ? user.id : ownerUser.id;
 
                   // CASE: avoid attaching duplicate authors relation
                   const userExists = _.find(authorsToSet, { id: userId.id });
@@ -243,10 +243,10 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
        * @param {Object} unfilteredOptions.transacting
        */
       reassignByAuthor: async function reassignByAuthor(unfilteredOptions) {
-        let options = this.filterOptions(unfilteredOptions, 'reassignByAuthor', {
+        const options = this.filterOptions(unfilteredOptions, 'reassignByAuthor', {
           extraAllowedProperties: ['id'],
         });
-        let authorId = options.id;
+        const authorId = options.id;
 
         if (!authorId) {
           return Promise.reject(
@@ -257,8 +257,8 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
         }
 
         const reassignPost = async () => {
-          let trx = options.transacting;
-          let knex = ghostBookshelf.knex;
+          const trx = options.transacting;
+          const knex = ghostBookshelf.knex;
 
           try {
             // There's only one possible owner per Ghost instance
@@ -350,9 +350,6 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
         const postModel = postModelOrId;
         let origArgs;
         const { isContributor, isAuthor } = setIsRoles(loadedPermissions);
-        let isEdit;
-        let isAdd;
-        let isDestroy;
 
         // If we passed in an id instead of a model, get the model
         // then check the permissions
@@ -377,9 +374,9 @@ module.exports.extendModel = function extendModel(Post, Posts, ghostBookshelf) {
           });
         }
 
-        isEdit = action === 'edit';
-        isAdd = action === 'add';
-        isDestroy = action === 'destroy';
+        const isEdit = action === 'edit';
+        const isAdd = action === 'add';
+        const isDestroy = action === 'destroy';
 
         function isChangingAuthors() {
           if (!unsafeAttrs.authors) {

package/core/server/models/role.js

@@ -9,10 +9,7 @@ const messages = {
   notEnoughPermission: 'You do not have permission to perform this action',
 };
 
-let Role;
-let Roles;
-
-Role = ghostBookshelf.Model.extend(
+const Role = ghostBookshelf.Model.extend(
   {
     tableName: 'roles',
 
@@ -130,7 +127,7 @@ Role = ghostBookshelf.Model.extend(
   },
 );
 
-Roles = ghostBookshelf.Collection.extend({
+const Roles = ghostBookshelf.Collection.extend({
   model: Role,
 });
 

package/core/server/models/settings.js

@@ -16,7 +16,7 @@ const messages = {
 };
 
 const internalContext = { context: { internal: true } };
-let Settings;
+
 let defaultSettings;
 const imageSettingKeys = [
   'cover_image',
@@ -126,7 +126,7 @@ function transformNavigationIconUrls(value, transformUrl) {
     return value;
   }
 
-  if (!_.isArray(navigationItems)) {
+  if (!Array.isArray(navigationItems)) {
     return value;
   }
 
@@ -146,7 +146,7 @@ function transformNavigationIconUrls(value, transformUrl) {
 
 // Each setting is saved as a separate row in the database,
 // but the overlying API treats them as a single key:value mapping
-Settings = ghostBookshelf.Model.extend(
+const Settings = ghostBookshelf.Model.extend(
   {
     tableName: 'settings',
 

package/core/server/models/tag.js

@@ -7,10 +7,7 @@ const messages = {
   tagNotFound: 'Tag not found.',
 };
 
-let Tag;
-let Tags;
-
-Tag = ghostBookshelf.Model.extend(
+const Tag = ghostBookshelf.Model.extend(
   {
     tableName: 'tags',
 
@@ -221,7 +218,7 @@ Tag = ghostBookshelf.Model.extend(
   },
 );
 
-Tags = ghostBookshelf.Collection.extend({
+const Tags = ghostBookshelf.Collection.extend({
   model: Tag,
 });
 

package/core/server/models/user.js

@@ -7,6 +7,7 @@ const tpl = require('@tryghost/tpl');
 const errors = require('@tryghost/errors');
 const security = require('@tryghost/security');
 const { validatePassword } = require('../lib/validate-password');
+const { generatePassword } = require('../lib/generate-password');
 const permissions = require('../services/permissions');
 const urlUtils = require('../../shared/url-utils').default;
 const { setIsRoles } = require('./role-utils');
@@ -54,10 +55,8 @@ const messages = {
 const inactiveStates = ['inactive', 'locked'];
 
 const allStates = activeStates.concat(inactiveStates);
-let User;
-let Users;
 
-User = ghostBookshelf.Model.extend(
+const User = ghostBookshelf.Model.extend(
   {
     tableName: 'users',
 
@@ -66,8 +65,7 @@ User = ghostBookshelf.Model.extend(
 
     defaults: function defaults() {
       return {
-        // secretlint-disable-next-line @secretlint/secretlint-rule-pattern
-        password: security.identifier.uid(50),
+        password: generatePassword(''),
         visibility: 'public',
         status: 'active',
         comment_notifications: true,
@@ -208,8 +206,7 @@ User = ghostBookshelf.Model.extend(
      */
     lock: function lock(options) {
       const update = {
-        // secretlint-disable-next-line @secretlint/secretlint-rule-pattern
-        password: security.identifier.uid(50),
+        password: generatePassword(this.get('email') || ''),
       };
       if (this.get('status') !== 'inactive') {
         update.status = 'locked';
@@ -306,8 +303,8 @@ User = ghostBookshelf.Model.extend(
         }
 
         if (options.importing) {
-          // always set password to a random uid when importing
-          this.set('password', security.identifier.uid(50));
+          // generate a random password when importing
+          this.set('password', generatePassword(this.get('email') || ''));
 
           // lock users so they have to follow the password reset flow
           if (this.get('status') !== 'inactive') {
@@ -507,7 +504,7 @@ User = ghostBookshelf.Model.extend(
     findOne: function findOne(dataToClone, unfilteredOptions) {
       const options = this.filterOptions(unfilteredOptions, 'findOne');
       let query;
-      let status;
+
       let data = JSON.parse(JSON.stringify(dataToClone));
       const lookupRole = data.role;
 
@@ -521,7 +518,7 @@ User = ghostBookshelf.Model.extend(
       delete data.role;
       data = Object.assign({}, { status: 'all' }, data || {});
 
-      status = data.status;
+      const status = data.status;
       delete data.status;
 
       data = this.filterData(data);
@@ -989,11 +986,11 @@ User = ghostBookshelf.Model.extend(
 
       // CASE: i want to edit roles
       if (action === 'edit' && unsafeAttrs.roles && unsafeAttrs.roles[0]) {
-        let role = unsafeAttrs.roles[0];
-        let roleId = role.id || role;
-        let editedUserId = userModel.id;
+        const role = unsafeAttrs.roles[0];
+        const roleId = role.id || role;
+        const editedUserId = userModel.id;
         // @NOTE: role id of logged in user
-        let contextRoleId = loadedPermissions.user.roles[0].id;
+        const contextRoleId = loadedPermissions.user.roles[0].id;
 
         if (roleId !== contextRoleId && editedUserId === context.user) {
           return Promise.reject(
@@ -1037,10 +1034,13 @@ User = ghostBookshelf.Model.extend(
                 }),
               );
             }
-          } else if (roleId !== contextRoleId) {
+          } else if (roleId !== contextRoleId || editedUserId !== context.user) {
             // CASE: you are trying to change a role, but you are not owner
-            // @NOTE: your role is not the same than the role you try to change (!)
-            // e.g. admin can assign admin role to a user, but not owner
+            // @NOTE: assigning any role to *another* user must always go through
+            // the assign check, including your own role. Otherwise an Editor could
+            // promote an Author to Editor, which the role hierarchy disallows.
+            // The only case that skips the check is a self-edit that leaves your
+            // own role untouched, e.g. a profile update that echoes back `roles`.
 
             return permissions
               .canThis(context)
@@ -1296,7 +1296,7 @@ User = ghostBookshelf.Model.extend(
   },
 );
 
-Users = ghostBookshelf.Collection.extend({
+const Users = ghostBookshelf.Collection.extend({
   model: User,
 });
 

package/core/server/models/webhook.js

@@ -1,9 +1,7 @@
 const ghostBookshelf = require('./base');
 const ghostVersion = require('@tryghost/version');
-let Webhook;
-let Webhooks;
 
-Webhook = ghostBookshelf.Model.extend(
+const Webhook = ghostBookshelf.Model.extend(
   {
     tableName: 'webhooks',
 
@@ -87,7 +85,7 @@ Webhook = ghostBookshelf.Model.extend(
   },
 );
 
-Webhooks = ghostBookshelf.Collection.extend({
+const Webhooks = ghostBookshelf.Collection.extend({
   model: Webhook,
 });
 

package/core/server/notify.js

@@ -40,7 +40,7 @@ async function notify(type, error = null) {
   // Build our message
   // - if there's an error then the server is not ready, include the errors
   // - if there's no error then the server has started
-  let message = {};
+  const message = {};
   if (error) {
     message[type] = false;
     message.error = error;
@@ -56,7 +56,7 @@ async function notify(type, error = null) {
   }
 
   // CASE: use bootstrap socket to communicate with CLI for systemd
-  let socketAddress = config.get('bootstrap-socket');
+  const socketAddress = config.get('bootstrap-socket');
   if (socketAddress) {
     const bootstrapSocket = require('./lib/bootstrap-socket');
     return bootstrapSocket.connectAndSend(socketAddress, message);