ghost 6.61.0 → 6.63.0

package/core/server/services/{members-custom-fields → members-metafields}/values-service.js

@@ -3,20 +3,22 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.CustomFieldValuesService = void 0;
+exports.MetafieldValuesService = void 0;
 const bson_objectid_1 = __importDefault(require("bson-objectid"));
 const errors_1 = __importDefault(require("@tryghost/errors"));
 const logging_1 = __importDefault(require("@tryghost/logging"));
 const zod_1 = require("zod");
-const custom_field_types_1 = require("@tryghost/custom-field-types");
+const metafield_types_1 = require("@tryghost/metafield-types");
+const identity_1 = require("@tryghost/metafield-types/identity");
 const schema_1 = require("./schema");
 const queries_1 = require("./queries");
+const access_1 = require("./access");
 const storage_1 = require("./storage");
-const FIELDS_TABLE = 'members_custom_fields';
-const VALUES_TABLE = 'members_custom_field_values';
+const FIELDS_TABLE = 'members_metafields';
+const VALUES_TABLE = 'members_metafield_values';
 /**
  * From the canonical schema, the same source definitions-service reads, so no key a site
- * could hold is refused and this cannot drift from the `members_custom_fields.key` column.
+ * could hold is refused and this cannot drift from the `members_metafields.key` column.
  */
 const MAX_KEY_LENGTH = require('../../data/schema').tables[FIELDS_TABLE].key.maxlength;
 /**
@@ -29,15 +31,15 @@ const MAX_KEY_LENGTH = require('../../data/schema').tables[FIELDS_TABLE].key.max
  * go when that lands; until then the alternative is hand-written upsert SQL per engine.
  */
 const UPSERT_CHUNK = 400;
-// Values stay `unknown`: each is validated by its own field type, which is not known
-// until the key is resolved to a definition.
-const ValuesInput = zod_1.z.record(zod_1.z.string().max(MAX_KEY_LENGTH), zod_1.z.unknown());
+const MAX_IDENTITY_LENGTH = MAX_KEY_LENGTH * 2 + 1;
+const ValuesInput = zod_1.z.record(zod_1.z.string().max(MAX_IDENTITY_LENGTH), zod_1.z.unknown());
+const wireProperty = (identity) => [identity_1.QUALIFIER, identity].join('.');
 /**
  * What a member holds for each defined field. Separate from the definitions service
  * because a value belongs to the member and a definition belongs to the site's settings,
  * which are different aggregates rather than different layers.
  */
-class CustomFieldValuesService {
+class MetafieldValuesService {
     knex;
     /** A getter, not a number: the ceiling is an operator setting that changes between requests. */
     getMaxDefinitions;
@@ -45,23 +47,23 @@ class CustomFieldValuesService {
         this.knex = knex;
         this.getMaxDefinitions = getMaxDefinitions;
     }
-    async activeFieldsByKey(keys) {
+    async activeFieldsByIdentity(identities) {
+        const keys = identities
+            .map((identity) => (0, identity_1.parseIdentity)(identity))
+            .filter((parsed) => parsed !== null && parsed.namespace === identity_1.CUSTOM_NAMESPACE)
+            .map((parsed) => parsed.key);
         if (keys.length === 0) {
             return new Map();
         }
         const fields = await (0, queries_1.activeFields)(this.knex)
             .whereIn('key', keys)
             .select('id', 'key', 'name', 'type');
-        return new Map(fields.map((field) => [field.key, field]));
+        return new Map(fields.map((field) => [
+            (0, identity_1.formatIdentity)({ namespace: identity_1.CUSTOM_NAMESPACE, key: field.key, partPath: null }),
+            { ...field, namespace: identity_1.CUSTOM_NAMESPACE },
+        ]));
     }
-    /**
-     * Members' values, keyed by member id then field key; anything absent is unset.
-     *
-     * Archived fields are excluded to match the definitions browse: their values stay in
-     * the database and stop being addressable. A row that will not parse is dropped and
-     * logged rather than failing the read, so one stale row cannot take down a member.
-     */
-    async getValuesForMembers(memberIds) {
+    async getValuesForMembers(memberIds, audience) {
         if (memberIds.length === 0) {
             return new Map();
         }
@@ -69,7 +71,7 @@ class CustomFieldValuesService {
         // cannot carry an order. `path` is ordered so composite parts assemble the same
         // way every time.
         const rows = await this.knex(VALUES_TABLE)
-            .join(FIELDS_TABLE, `${VALUES_TABLE}.custom_field_key`, `${FIELDS_TABLE}.key`)
+            .join(FIELDS_TABLE, `${VALUES_TABLE}.metafield_key`, `${FIELDS_TABLE}.key`)
             .whereIn(`${VALUES_TABLE}.member_id`, memberIds)
             .where(`${FIELDS_TABLE}.status`, schema_1.FIELD_STATUS.active)
             .orderBy(`${VALUES_TABLE}.path`, 'asc')
@@ -77,30 +79,57 @@ class CustomFieldValuesService {
         const leaves = [];
         for (const row of rows) {
             try {
-                leaves.push(schema_1.DbCustomFieldLeaf.parse(row));
+                leaves.push(schema_1.DbMetafieldLeaf.parse(row));
             }
             catch (err) {
                 logging_1.default.warn({
-                    event: { name: 'members.custom_fields.value_unreadable' },
+                    event: { name: 'members.metafields.value_unreadable' },
                     err,
-                    customFieldKey: row.key,
+                    metafieldKey: row.key,
                     path: row.path,
-                }, 'Skipping an unreadable custom field value');
+                }, 'Skipping an unreadable metafield value');
             }
         }
-        return (0, storage_1.valuesFromLeaves)(leaves);
+        // Narrowed before assembly, not after: a composite is one value spread across
+        // several rows, and dropping some of its parts later would hand back half an
+        // address rather than no address.
+        const flat = (0, storage_1.valuesFromLeaves)((0, access_1.readableFields)(audience, leaves));
+        return new Map(memberIds.map((memberId) => [memberId, { [identity_1.CUSTOM_NAMESPACE]: flat.get(memberId) ?? {} }]));
     }
-    /** Shared by every caller so they cannot disagree on what a values object is. */
     parseValues(input) {
         const parsed = ValuesInput.safeParse(input);
         if (!parsed.success) {
             throw new errors_1.default.ValidationError({
-                message: 'Custom field values must be an object keyed by field key.',
-                property: 'custom_fields',
+                message: 'Custom field values must be an object keyed by field identity.',
+                property: identity_1.QUALIFIER,
             });
         }
         return parsed.data;
     }
+    unwrapWire(input) {
+        if (input === undefined) {
+            return undefined;
+        }
+        if (typeof input !== 'object' || input === null || Array.isArray(input)) {
+            throw new errors_1.default.ValidationError({
+                message: 'Metafields must be an object keyed by namespace.',
+                property: identity_1.QUALIFIER,
+            });
+        }
+        const identified = {};
+        for (const [namespace, values] of Object.entries(input)) {
+            if (typeof values !== 'object' || values === null || Array.isArray(values)) {
+                throw new errors_1.default.ValidationError({
+                    message: 'Metafield values must be an object keyed by field key.',
+                    property: [identity_1.QUALIFIER, namespace].join('.'),
+                });
+            }
+            for (const [key, raw] of Object.entries(values)) {
+                identified[`${namespace}.${key}`] = raw;
+            }
+        }
+        return identified;
+    }
     /**
      * Whether input names any values. Asks the shape question alone, with no catalog
      * lookup, so it can be asked before a write is known to be permitted.
@@ -116,35 +145,38 @@ class CustomFieldValuesService {
      * validate before opening a transaction it would otherwise have to unwind, then apply
      * the same plan without re-resolving it.
      */
-    async planWrite(input) {
+    async planWrite(input, audience) {
         const values = this.parseValues(input);
-        const keys = Object.keys(values);
+        const identities = Object.keys(values);
         // Bounded by the definitions ceiling, which also holds the lookup below inside
         // the driver's bound-parameter limit.
         const maxKeys = this.getMaxDefinitions();
-        if (keys.length > maxKeys) {
+        if (identities.length > maxKeys) {
             throw new errors_1.default.ValidationError({
                 message: `Custom field values are limited to ${maxKeys} fields per request.`,
-                property: 'custom_fields',
+                property: identity_1.QUALIFIER,
             });
         }
-        const byKey = await this.activeFieldsByKey(keys);
+        const byIdentity = await this.activeFieldsByIdentity(identities);
         const writes = [];
-        for (const [key, raw] of Object.entries(values)) {
-            const field = byKey.get(key);
+        for (const [identity, raw] of Object.entries(values)) {
+            const field = byIdentity.get(identity);
             if (!field) {
-                // Unknown or archived. Refused rather than ignored: a typo that silently
-                // drops what somebody typed is worse than a save that fails. The catalog
-                // applies the same rule to the parts of a composite value.
                 throw new errors_1.default.ValidationError({
-                    message: `Unknown custom field: ${key}`,
-                    property: `custom_fields.${key}`,
+                    message: `Unknown custom field: ${identity}`,
+                    property: wireProperty(identity),
+                });
+            }
+            if (!(0, access_1.canWrite)(audience, field)) {
+                throw new errors_1.default.ValidationError({
+                    message: `Cannot set custom field: ${identity}`,
+                    property: wireProperty(identity),
                 });
             }
             // `null` clears any field, and `''` clears one with no parts. For a value
             // with parts `''` names nothing, so it is left to fail validation rather than
             // being read as a silent delete.
-            if (raw === null || (raw === '' && (0, custom_field_types_1.subFieldsOf)(field.type) === null)) {
+            if (raw === null || (raw === '' && (0, metafield_types_1.subFieldsOf)(field.type) === null)) {
                 writes.push({ field });
                 continue;
             }
@@ -152,12 +184,12 @@ class CustomFieldValuesService {
             // `context` when `context` is empty and prepends it when it is not, so
             // anything added here reaches the client glued to the front of the reason.
             // Which field failed rides in `property`.
-            const value = custom_field_types_1.FIELD_TYPES[field.type].value.safeParse(raw);
+            const value = metafield_types_1.FIELD_TYPES[field.type].value.safeParse(raw);
             if (!value.success) {
                 const issue = value.error.issues[0];
                 throw new errors_1.default.ValidationError({
                     message: issue.message,
-                    property: [`custom_fields.${key}`, ...issue.path].join('.'),
+                    property: [wireProperty(identity), ...issue.path].join('.'),
                 });
             }
             writes.push({ field, value: value.data });
@@ -202,7 +234,7 @@ class CustomFieldValuesService {
                 rows.push(...set.map((leaf) => ({
                     id: new bson_objectid_1.default().toHexString(),
                     member_id: memberId,
-                    custom_field_key: field.key,
+                    metafield_key: field.key,
                     path: leaf.path,
                     value_text: leaf.value_text,
                     written_by_type: writtenBy.type,
@@ -214,7 +246,7 @@ class CustomFieldValuesService {
             if (clearedKeys.length > 0) {
                 await trx(VALUES_TABLE)
                     .where('member_id', memberId)
-                    .whereIn('custom_field_key', clearedKeys)
+                    .whereIn('metafield_key', clearedKeys)
                     .del();
             }
             if (clearedPaths.length > 0) {
@@ -223,7 +255,7 @@ class CustomFieldValuesService {
                     .where('member_id', memberId)
                     .where((builder) => {
                     for (const { fieldKey, paths } of clearedPaths) {
-                        builder.orWhere((pair) => pair.where('custom_field_key', fieldKey).whereIn('path', paths));
+                        builder.orWhere((pair) => pair.where('metafield_key', fieldKey).whereIn('path', paths));
                     }
                 })
                     .del();
@@ -236,7 +268,7 @@ class CustomFieldValuesService {
                     .insert(rows.slice(from, from + UPSERT_CHUNK))
                     // Naming the columns rather than giving values takes each from the row
                     // that lost the conflict, so every part updates to its own value.
-                    .onConflict(['member_id', 'custom_field_key', 'path'])
+                    .onConflict(['member_id', 'metafield_key', 'path'])
                     // The writer is merged with the value, so a leaf names who wrote what
                     // it currently holds rather than who wrote its first value.
                     .merge(['value_text', 'written_by_type', 'written_by_id', 'updated_at']);
@@ -251,4 +283,4 @@ class CustomFieldValuesService {
         }
     }
 }
-exports.CustomFieldValuesService = CustomFieldValuesService;
+exports.MetafieldValuesService = MetafieldValuesService;

package/core/server/services/mentions/mention-controller.js

@@ -1,4 +1,5 @@
 const logging = require('@tryghost/logging');
+const ProcessWebmentionJob = require('./process-webmention-job').default;
 
 /**
  * @typedef {import('./mentions-api')} MentionsAPI
@@ -22,11 +23,6 @@ const logging = require('@tryghost/logging');
  * @prop {Resource} resource
  */
 
-/**
- * @typedef {object} IJobService
- * @prop {(name: string, fn: Function) => void} addJob
- */
-
 /**
  * @typedef {object} IMentionResourceService
  * @prop {(id: import('bson-objectid').default)  => Promise<MentionResource>} getByID
@@ -36,8 +32,8 @@ module.exports = class MentionController {
   /** @type {import('./mentions-api')} */
   #api;
 
-  /** @type {IJobService} */
-  #jobService;
+  /** @type {import('../jobs-service/jobs-service').JobsService} */
+  #jobsService;
 
   /** @type {IMentionResourceService} */
   #mentionResourceService;
@@ -45,12 +41,12 @@ module.exports = class MentionController {
   /**
    * @param {object} deps
    * @param {import('./mentions-api')} deps.api
-   * @param {IJobService} deps.jobService
+   * @param {import('../jobs-service/jobs-service').JobsService} deps.jobsService
    * @param {IMentionResourceService} deps.mentionResourceService
    */
   async init(deps) {
     this.#api = deps.api;
-    this.#jobService = deps.jobService;
+    this.#jobsService = deps.jobsService;
     this.#mentionResourceService = deps.mentionResourceService;
   }
 
@@ -127,17 +123,23 @@ module.exports = class MentionController {
    */
   async receive(frame) {
     logging.info('[Webmention] ' + JSON.stringify(frame.data));
-    this.#jobService.addJob('processWebmention', async () => {
-      const { source, target, ...payload } = frame.data;
-      try {
-        await this.#api.processWebmention({
-          source: new URL(source),
-          target: new URL(target),
-          payload,
-        });
-      } catch (err) {
-        logging.error(err, '[Webmention] Failed processing webmention');
-      }
-    });
+    const { source, target, ...payload } = frame.data;
+    await this.#jobsService.dispatch(new ProcessWebmentionJob({ source, target, payload }));
+  }
+
+  /**
+   * @param {import('./process-webmention-job').default} job
+   * @returns {Promise<void>}
+   */
+  async processWebmention({ source, target, payload }) {
+    try {
+      await this.#api.processWebmention({
+        source: new URL(source),
+        target: new URL(target),
+        payload,
+      });
+    } catch (err) {
+      logging.error(err, '[Webmention] Failed processing webmention');
+    }
   }
 };

package/core/server/services/mentions/mention-sending-service.js

@@ -1,5 +1,6 @@
 const errors = require('@tryghost/errors');
 const logging = require('@tryghost/logging');
+const SendWebmentionsJob = require('./send-webmentions-job').default;
 
 module.exports = class MentionSendingService {
   #discoveryService;
@@ -8,8 +9,12 @@ module.exports = class MentionSendingService {
   #getPostData;
   #getPostUrl;
   #isEnabled;
-  #jobService;
+  #jobsService;
 
+  /**
+   * @param {object} deps
+   * @param {import('../jobs-service/jobs-service').JobsService} deps.jobsService
+   */
   constructor({
     discoveryService,
     externalRequest,
@@ -17,7 +22,7 @@ module.exports = class MentionSendingService {
     getPostData,
     getPostUrl,
     isEnabled,
-    jobService,
+    jobsService,
   }) {
     this.#discoveryService = discoveryService;
     this.#externalRequest = externalRequest;
@@ -25,7 +30,7 @@ module.exports = class MentionSendingService {
     this.#getPostData = getPostData;
     this.#getPostUrl = getPostUrl;
     this.#isEnabled = isEnabled;
-    this.#jobService = jobService;
+    this.#jobsService = jobsService;
   }
 
   get siteUrl() {
@@ -82,13 +87,13 @@ module.exports = class MentionSendingService {
         // Capture the source URL now, from the event's data, rather than
         // deferring the model into the job.
         const url = new URL(await this.#resolvePostUrl(post));
-        await this.#jobService.addJob('sendWebmentions', async () => {
-          await this.sendForHTMLResource({
-            url,
+        await this.#jobsService.dispatch(
+          new SendWebmentionsJob({
+            sourceUrl: url.href,
             html: html,
             previousHtml: previousHtml,
-          });
-        });
+          }),
+        );
       }
     } catch (e) {
       logging.error('Error in webmention sending service post update event handler:');
@@ -157,11 +162,23 @@ module.exports = class MentionSendingService {
     });
   }
 
+  /**
+   * Send the webmentions for a delivered job.
+   * @param {import('./send-webmentions-job').default} job
+   */
+  async sendWebmentions(job) {
+    await this.sendForHTMLResource({
+      url: new URL(job.sourceUrl),
+      html: job.html,
+      previousHtml: job.previousHtml,
+    });
+  }
+
   /**
    * Send a webmention call for the links in a resource.
    * @param {object} resource
    * @param {URL} resource.url
-   * @param {string} resource.html
+   * @param {string|null} resource.html
    * @param {string|null} [resource.previousHtml]
    */
   async sendForHTMLResource(resource) {

package/core/server/services/mentions/process-webmention-job.js

@@ -0,0 +1,16 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const job_1 = require("../jobs-service/job");
+class ProcessWebmentionJob extends job_1.Job {
+    static type = 'process-webmention';
+    source;
+    target;
+    payload;
+    constructor({ source, target, payload, }) {
+        super();
+        this.source = source;
+        this.target = target;
+        this.payload = payload;
+    }
+}
+exports.default = ProcessWebmentionJob;

package/core/server/services/mentions/send-webmentions-job.js

@@ -0,0 +1,18 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const job_1 = require("../jobs-service/job");
+// Carries the post's full html twice - the largest job payload in the system;
+// revisit if a durable backend puts size limits on envelopes.
+class SendWebmentionsJob extends job_1.Job {
+    static type = 'send-webmentions';
+    sourceUrl;
+    html;
+    previousHtml;
+    constructor({ sourceUrl, html, previousHtml, }) {
+        super();
+        this.sourceUrl = sourceUrl;
+        this.html = html ?? null;
+        this.previousHtml = previousHtml ?? null;
+    }
+}
+exports.default = SendWebmentionsJob;

package/core/server/services/mentions/service.js

@@ -14,8 +14,6 @@ const outputSerializerUrlUtil = require('../../../server/api/endpoints/utils/ser
 const urlService = require('../url');
 const settingsCache = require('../../../shared/settings-cache');
 const DomainEvents = require('@tryghost/domain-events');
-const logging = require('@tryghost/logging');
-const jobsService = require('../mentions-jobs');
 
 // Serializes a post model to the data the URL service needs, loading the
 // relations it reads for filtered collections (event-emitted models don't
@@ -38,33 +36,6 @@ function getPostUrl(id, postData) {
   return jsonModel.url;
 }
 
-// Reports the same queued/started/finished/failed lifecycle for every mentions
-// background job. The wrapped callback's result and errors pass through unchanged,
-// so job manager outcomes and retries are unaffected.
-function makeLoggingJobService() {
-  return {
-    async addJob(name, fn) {
-      logging.info(`[Background Job] ${name} queued`);
-      jobsService.addJob({
-        name,
-        job: async () => {
-          const startedAt = Date.now();
-          logging.info(`[Background Job] ${name} started`);
-          try {
-            const result = await fn();
-            logging.info(`[Background Job] ${name} completed in ${Date.now() - startedAt}ms`);
-            return result;
-          } catch (err) {
-            logging.error(err, `[Background Job] ${name} failed after ${Date.now() - startedAt}ms`);
-            throw err;
-          }
-        },
-        offloaded: false,
-      });
-    },
-  };
-}
-
 module.exports = {
   /** @type {import('./mentions-api')} */
   api: null,
@@ -75,7 +46,11 @@ module.exports = {
   /** @type {import('./mention-sending-service')} */
   sendingService: null,
   didInit: false,
-  async init() {
+  /**
+   * @param {object} deps
+   * @param {import('../jobs-service/jobs-service').JobsService} deps.jobsService
+   */
+  async init({ jobsService }) {
     if (this.didInit) {
       return;
     }
@@ -110,7 +85,7 @@ module.exports = {
 
     this.controller.init({
       api,
-      jobService: makeLoggingJobService(),
+      jobsService,
       mentionResourceService: {
         async getByID(id) {
           if (!id) {
@@ -137,7 +112,7 @@ module.exports = {
       getPostData: (post) => getPostData(post),
       getPostUrl: (id, data) => getPostUrl(id, data),
       isEnabled: () => !settingsCache.get('is_private'),
-      jobService: makeLoggingJobService(),
+      jobsService,
     });
     sendingService.listen(events);
 
@@ -148,4 +123,3 @@ module.exports = {
 // exposed for testing
 module.exports.getPostData = getPostData;
 module.exports.getPostUrl = getPostUrl;
-module.exports.makeLoggingJobService = makeLoggingJobService;

package/core/server/services/route-settings/validation-errors.js

@@ -14,7 +14,7 @@ const tpl_1 = __importDefault(require("@tryghost/tpl"));
 const messages = {
     validationError: 'The following definition "{at}" is invalid: {reason}',
 };
-const DOCS_URL = 'https://ghost.org/docs/themes/routing/';
+const DOCS_URL = 'https://docs.ghost.org/themes/routing/';
 const MAX_SHOWN_LENGTH = 40;
 /**
  * Stable, machine-readable codes describing the class of a routes.yaml failure.

package/core/server/services/route-settings/yaml-parser.js

@@ -9,7 +9,7 @@ const messages = {
   },
   invalidYamlFormat: {
     message: 'YAML input cannot be a plain string. Check the format of your YAML file.',
-    help: 'https://ghost.org/docs/themes/routing/',
+    help: 'https://docs.ghost.org/themes/routing/',
   },
 };
 

package/core/server/services/settings/settings-service.js

@@ -200,14 +200,7 @@ module.exports = {
         type: 'boolean',
         group: 'members',
         fn: settingsHelpers.allowSelfSignup.bind(settingsHelpers),
-        dependents: [
-          'members_signup_access',
-          'portal_plans',
-          'stripe_secret_key',
-          'stripe_publishable_key',
-          'stripe_connect_secret_key',
-          'stripe_connect_publishable_key',
-        ],
+        dependents: ['members_signup_access'],
       }),
     );
     fields.push(

package/core/server/services/settings-helpers/settings-helpers.js

@@ -1,7 +1,7 @@
 const net = require('net');
 const tpl = require('@tryghost/tpl');
 const errors = require('@tryghost/errors');
-const EmailAddressParser = require('../email-address/email-address-parser');
+const emailAddressParser = require('../email-address/email-address-parser');
 const logging = require('@tryghost/logging');
 const crypto = require('crypto');
 const debug = require('@tryghost/debug')('services:settings-helpers');
@@ -130,11 +130,9 @@ class SettingsHelpers {
     if (!supportAddress) {
       // In the new flow, we make a difference between an empty setting (= use default) and a 'noreply' setting (=use noreply @ domain)
       // Also keep the name of the default email!
-      return EmailAddressParser.stringify(this.getDefaultEmail());
+      return emailAddressParser.stringify(this.getDefaultEmail());
     }
 
-    supportAddress = supportAddress || 'noreply';
-
     // Any fromAddress without domain uses site domain, like default setting `noreply`
     if (supportAddress.indexOf('@') < 0) {
       return `${supportAddress}@${this.getDefaultEmailDomain()}`;
@@ -143,7 +141,7 @@ class SettingsHelpers {
   }
 
   /**
-   * @deprecated Use getDefaultEmail().address (without name) or EmailAddressParser.stringify(this.getDefaultEmail()) (with name) instead
+   * @deprecated Use getDefaultEmail().address (without name) or emailAddressParser.stringify(this.getDefaultEmail()) (with name) instead
    */
   getNoReplyAddress() {
     return this.getDefaultEmailAddress();
@@ -157,7 +155,7 @@ class SettingsHelpers {
     // parse the email here and remove the sender name
     // E.g. when set to "bar" <from@default.com>
     const configAddress = this.config.get('mail:from');
-    const parsed = EmailAddressParser.parse(configAddress);
+    const parsed = emailAddressParser.parse(configAddress);
     if (parsed) {
       return parsed;
     }

package/core/server/services/slack-ping/slack-ping-service.js

@@ -173,7 +173,7 @@ class SlackPingService {
                 this.logging.error(new errors_1.default.InternalServerError({
                     err: err,
                     context: (0, tpl_1.default)(constants_1.messages.requestFailedError, { service: 'slack' }),
-                    help: (0, tpl_1.default)(constants_1.messages.requestFailedHelp, { url: 'https://ghost.org/docs/' }),
+                    help: (0, tpl_1.default)(constants_1.messages.requestFailedHelp, { url: 'https://docs.ghost.org/' }),
                 }));
             });
         }

package/core/server/services/staff/staff-service-emails.js

@@ -2,7 +2,7 @@ const { promises: fs, readFileSync } = require('fs');
 const path = require('path');
 const moment = require('moment');
 const { globSync } = require('glob');
-const EmailAddressParser = require('../email-address/email-address-parser');
+const emailAddressParser = require('../email-address/email-address-parser');
 
 class StaffServiceEmails {
   constructor({
@@ -593,7 +593,7 @@ class StaffServiceEmails {
   }
 
   get fromEmailAddress() {
-    return EmailAddressParser.stringify(this.settingsHelpers.getDefaultEmail());
+    return emailAddressParser.stringify(this.settingsHelpers.getDefaultEmail());
   }
 
   extractInitials(name = '') {