ghost 5.36.1 → 5.38.0

package/core/built/admin/index.html

@@ -8,7 +8,7 @@
     <title>Ghost Admin</title>
 
     
-<meta name="ghost-admin/config/environment" content="%7B%22modulePrefix%22%3A%22ghost-admin%22%2C%22environment%22%3A%22production%22%2C%22rootURL%22%3A%22%22%2C%22locationType%22%3A%22trailing-hash%22%2C%22EmberENV%22%3A%7B%22FEATURES%22%3A%7B%7D%2C%22EXTEND_PROTOTYPES%22%3A%7B%22Date%22%3Afalse%2C%22Array%22%3Atrue%2C%22String%22%3Atrue%2C%22Function%22%3Afalse%7D%2C%22_APPLICATION_TEMPLATE_WRAPPER%22%3Afalse%2C%22_JQUERY_INTEGRATION%22%3Atrue%2C%22_TEMPLATE_ONLY_GLIMMER_COMPONENTS%22%3Atrue%7D%2C%22APP%22%3A%7B%22version%22%3A%225.36%22%2C%22name%22%3A%22ghost-admin%22%7D%2C%22ember-simple-auth%22%3A%7B%7D%2C%22ember-websockets%22%3A%7B%22socketIO%22%3Atrue%7D%2C%22%40sentry%2Fember%22%3A%7B%22disablePerformance%22%3Atrue%2C%22sentry%22%3A%7B%7D%7D%2C%22ember-cli-mirage%22%3A%7B%22usingProxy%22%3Afalse%2C%22useDefaultPassthroughs%22%3Atrue%7D%2C%22exportApplicationGlobal%22%3Afalse%2C%22ember-load%22%3A%7B%22loadingIndicatorClass%22%3A%22ember-load-indicator%22%7D%7D" />
+<meta name="ghost-admin/config/environment" content="%7B%22modulePrefix%22%3A%22ghost-admin%22%2C%22environment%22%3A%22production%22%2C%22rootURL%22%3A%22%22%2C%22locationType%22%3A%22trailing-hash%22%2C%22EmberENV%22%3A%7B%22FEATURES%22%3A%7B%7D%2C%22EXTEND_PROTOTYPES%22%3A%7B%22Date%22%3Afalse%2C%22Array%22%3Atrue%2C%22String%22%3Atrue%2C%22Function%22%3Afalse%7D%2C%22_APPLICATION_TEMPLATE_WRAPPER%22%3Afalse%2C%22_JQUERY_INTEGRATION%22%3Atrue%2C%22_TEMPLATE_ONLY_GLIMMER_COMPONENTS%22%3Atrue%7D%2C%22APP%22%3A%7B%22version%22%3A%225.38%22%2C%22name%22%3A%22ghost-admin%22%7D%2C%22ember-simple-auth%22%3A%7B%7D%2C%22ember-websockets%22%3A%7B%22socketIO%22%3Atrue%7D%2C%22%40sentry%2Fember%22%3A%7B%22disablePerformance%22%3Atrue%2C%22sentry%22%3A%7B%7D%7D%2C%22ember-cli-mirage%22%3A%7B%22usingProxy%22%3Afalse%2C%22useDefaultPassthroughs%22%3Atrue%7D%2C%22exportApplicationGlobal%22%3Afalse%2C%22ember-load%22%3A%7B%22loadingIndicatorClass%22%3A%22ember-load-indicator%22%7D%7D" />
 
     <meta name="HandheldFriendly" content="True" />
     <meta name="MobileOptimized" content="320" />
@@ -37,7 +37,7 @@
     </style>
 
     <link integrity="" rel="stylesheet" href="assets/vendor-3e6947aa681f0fb82b193090e520dc73.css">
-    <link integrity="" rel="stylesheet" href="assets/ghost-7ecf5c7934d90798485ee5ac2956f7fe.css" title="light">
+    <link integrity="" rel="stylesheet" href="assets/ghost-a9307c9cfe26a4bc621e02cd3bae421a.css" title="light">
 
     
 </head>
@@ -56,9 +56,9 @@
 
     <div id="ember-basic-dropdown-wormhole"></div>
 
-    <script src="assets/vendor-c4684647d4f5213e5dbb6763de430e7e.js"></script>
-<script src="assets/chunk.502.800e1515996bcc900013.js"></script>
-<script src="assets/chunk.143.26ea9f26571d656653f0.js"></script>
-    <script src="assets/ghost-b828e9e3c161aae92909c2e163656bb1.js"></script>
+    <script src="assets/vendor-b982e3bf1020bff77b2a3c44d5f59e55.js"></script>
+<script src="assets/chunk.220.9ca2950240aba3fced21.js"></script>
+<script src="assets/chunk.143.c6802c882a911797ce4f.js"></script>
+    <script src="assets/ghost-35103ff053c43f1dfa7f35821c3c2412.js"></script>
 </body>
 </html>

package/core/frontend/apps/amp/lib/helpers/amp_content.js

@@ -6,7 +6,7 @@
 //
 // Converts normal HTML into AMP HTML with Amperize module and uses a cache to return it from
 // there if available. The cacheId is a combination of `updated_at` and the `slug`.
-const {DateTime, Interval} = require('luxon');
+const {DateTime} = require('luxon');
 const errors = require('@tryghost/errors');
 const logging = require('@tryghost/logging');
 
@@ -120,8 +120,6 @@ function getAmperizeHTML(html, post) {
 
     amperize = amperize || new Amperize();
 
-    const startedAtMoment = DateTime.now();
-
     let cacheDateTime;
     let postDateTime;
 
@@ -136,8 +134,6 @@ function getAmperizeHTML(html, post) {
     if (!amperizeCache[post.id] || cacheDateTime.diff(postDateTime).valueOf() < 0) {
         return new Promise((resolve) => {
             amperize.parse(html, (err, res) => {
-                logging.info('amp.parse', post.url, Interval.fromDateTimes(startedAtMoment, DateTime.now()).length('milliseconds') + 'ms');
-
                 if (err) {
                     if (err.src) {
                         // This is a valid 500 GhostError because it means the amperize parser is unable to handle some Ghost HTML.

package/core/frontend/helpers/ghost_head.js

@@ -64,7 +64,10 @@ function getMembersHelper(data, frontendKey) {
     let membersHelper = `<script defer src="${scriptUrl}" ${dataAttributes} crossorigin="anonymous"></script>`;
     membersHelper += (`<style id="gh-members-styles">${templateStyles}</style>`);
     if (settingsCache.get('paid_members_enabled')) {
-        membersHelper += '<script async src="https://js.stripe.com/v3/"></script>';
+        // disable fraud detection for e2e tests to reduce waiting time
+        const isFraudSignalsEnabled = process.env.NODE_ENV === 'testing-browser' ? '?advancedFraudSignals=false' : '';
+
+        membersHelper += `<script async src="https://js.stripe.com/v3/${isFraudSignalsEnabled}"></script>`;
     }
     return membersHelper;
 }

package/core/frontend/meta/asset-url.js

@@ -2,6 +2,7 @@ const crypto = require('crypto');
 const config = require('../../shared/config');
 const {blogIcon} = require('../../server/lib/image');
 const urlUtils = require('../../shared/url-utils');
+const {SafeString} = require('../services/handlebars');
 
 /**
  * Serve either uploaded favicon or default
@@ -11,7 +12,15 @@ function getFaviconUrl() {
     return blogIcon.getIconUrl();
 }
 
+/**
+ * Prepare URL for an asset
+ * @param {string|SafeString} path — the asset’s path
+ * @param {boolean} hasMinFile — flag for the existence of a minified version for the asset
+ * @returns {string}
+ */
 function getAssetUrl(path, hasMinFile) {
+    path = path instanceof SafeString ? path.string : path;
+
     // CASE: favicon - this is special path with its own functionality
     if (path.match(/\/?favicon\.(ico|png)$/)) {
         // @TODO, resolve this - we should only be resolving subdirectory and extension.

package/core/frontend/services/routing/StaticPagesRouter.js

@@ -52,7 +52,7 @@ class StaticPagesRouter extends ParentRouter {
     }
 
     /**
-     * @description Prepare context for futher middleware/controllers.
+     * @description Prepare context for further middleware/controllers.
      * @param {Object} req
      * @param {Object} res
      * @param {Function} next

package/core/frontend/services/sitemap/base-generator.js

@@ -22,6 +22,10 @@ class BaseSiteMapGenerator {
         this.maxPerPage = 50000;
     }
 
+    hasCanonicalUrl(datum) {
+        return Boolean(datum?.canonical_url);
+    }
+
     generateXmlFromNodes(page) {
         // Get a mapping of node to timestamp
         let nodesToProcess = _.map(this.nodeLookup, (node, id) => {
@@ -75,7 +79,7 @@ class BaseSiteMapGenerator {
     addUrl(url, datum) {
         const node = this.createUrlNodeFromDatum(url, datum);
 
-        if (node) {
+        if (node && !this.hasCanonicalUrl(datum)) {
             this.updateLastModified(datum);
             this.updateLookups(datum, node);
             // force regeneration of xml

package/core/server/adapters/storage/LocalImagesStorage.js

@@ -27,7 +27,7 @@ class LocalImagesStorage extends LocalStorageBase {
     /**
      * Saves a buffer in the targetPath
      * @param {Buffer} buffer is an instance of Buffer
-     * @param {String} targetPath path to which the buffer should be written
+     * @param {String} targetPath relative path NOT including storage path to which the buffer should be written
      * @returns {Promise<String>} a URL to retrieve the data
      */
     async saveRaw(buffer, targetPath) {

package/core/server/api/endpoints/db.js

@@ -3,6 +3,7 @@ const moment = require('moment-timezone');
 const dbBackup = require('../../data/db/backup');
 const exporter = require('../../data/exporter');
 const importer = require('../../data/importer');
+const mediaInliner = require('../../services/media-inliner');
 const errors = require('@tryghost/errors');
 const models = require('../../models');
 const settingsCache = require('../../../shared/settings-cache');
@@ -93,6 +94,22 @@ module.exports = {
         }
     },
 
+    inlineMedia: {
+        permissions: {
+            method: 'importContent'
+        },
+        validation: {
+            options: {
+                include: {
+                    values: ['domains']
+                }
+            }
+        },
+        async query(frame) {
+            return mediaInliner.api.startMediaInliner(frame.data.domains);
+        }
+    },
+
     deleteAllContent: {
         headers: {
             cacheInvalidate: true

package/core/server/api/endpoints/email-previews.js

@@ -1,14 +1,4 @@
-const models = require('../../models');
-const tpl = require('@tryghost/tpl');
-const errors = require('@tryghost/errors');
-const mega = require('../../services/mega');
 const emailService = require('../../services/email-service');
-const labs = require('../../../shared/labs');
-const messages = {
-    postNotFound: 'Post not found.'
-};
-
-const emailPreview = new mega.EmailPreview();
 
 module.exports = {
     docName: 'email_previews',
@@ -30,25 +20,7 @@ module.exports = {
         ],
         permissions: true,
         async query(frame) {
-            if (labs.isSet('emailStability')) {
-                return await emailService.controller.previewEmail(frame);
-            }
-
-            const options = Object.assign(frame.options, {formats: 'html,plaintext', withRelated: ['authors', 'posts_meta']});
-            const data = Object.assign(frame.data, {status: 'all'});
-
-            const model = await models.Post.findOne(data, options);
-
-            if (!model) {
-                throw new errors.NotFoundError({
-                    message: tpl(messages.postNotFound)
-                });
-            }
-
-            return emailPreview.generateEmailContent(model, {
-                newsletter: frame.options.newsletter,
-                memberSegment: frame.options.memberSegment
-            });
+            return await emailService.controller.previewEmail(frame);
         }
     },
     sendTestEmail: {
@@ -66,20 +38,7 @@ module.exports = {
         },
         permissions: true,
         async query(frame) {
-            if (labs.isSet('emailStability')) {
-                return await emailService.controller.sendTestEmail(frame);
-            }
-
-            const options = Object.assign(frame.options, {status: 'all'});
-            let model = await models.Post.findOne(options, {withRelated: ['authors']});
-
-            if (!model) {
-                throw new errors.NotFoundError({
-                    message: tpl(messages.postNotFound)
-                });
-            }
-            const {emails = [], memberSegment, newsletter = ''} = frame.data;
-            return await mega.mega.sendTestEmail(model, emails, memberSegment, newsletter);
+            return await emailService.controller.sendTestEmail(frame);
         }
     }
 };

package/core/server/api/endpoints/emails.js

@@ -1,9 +1,7 @@
 const models = require('../../models');
 const tpl = require('@tryghost/tpl');
 const errors = require('@tryghost/errors');
-const megaService = require('../../services/mega');
 const emailService = require('../../services/email-service');
-const labs = require('../../../shared/labs');
 const emailAnalytics = require('../../services/email-analytics');
 
 const messages = {
@@ -63,27 +61,8 @@ module.exports = {
             'id'
         ],
         permissions: true,
-        // (complexity removed with new labs flag)
-        // eslint-disable-next-line ghost/ghost-custom/max-api-complexity
         async query(frame) {
-            if (labs.isSet('emailStability')) {
-                return await emailService.controller.retryFailedEmail(frame);
-            }
-
-            const model = await models.Email.findOne(frame.data, frame.options);
-            if (!model) {
-                throw new errors.NotFoundError({
-                    message: tpl(messages.emailNotFound)
-                });
-            }
-
-            if (model.get('status') !== 'failed') {
-                throw new errors.IncorrectUsageError({
-                    message: tpl(messages.retryNotAllowed)
-                });
-            }
-
-            return await megaService.mega.retryFailedEmail(model);
+            return await emailService.controller.retryFailedEmail(frame);
         }
     },
 

package/core/server/api/endpoints/mentions.js

@@ -9,7 +9,8 @@ module.exports = {
             'limit',
             'order',
             'page',
-            'debug'
+            'debug',
+            'unique'
         ],
         permissions: true,
         query(frame) {

package/core/server/api/endpoints/utils/serializers/output/mappers/emails.js

@@ -1,19 +1,22 @@
-const mega = require('../../../../../../services/mega');
 const labs = require('../../../../../../../shared/labs');
 const config = require('../../../../../../../shared/config');
+const emailService = require('../../../../../../services/email-service');
 
 module.exports = (model, frame) => {
     const jsonModel = model.toJSON ? model.toJSON(frame.options) : model;
 
     // Ensure we're not outputting unwanted replacement strings when viewing email contents
     // TODO: extract this to a utility, it's duplicated in the email-preview API controller
-    const replacements = mega.postEmailSerializer.parseReplacements(jsonModel);
-    replacements.forEach((replacement) => {
-        jsonModel[replacement.format] = jsonModel[replacement.format].replace(
-            replacement.regexp,
-            replacement.fallback || ''
-        );
-    });
+    if (jsonModel.html) {
+        const replacements = emailService.renderer.buildReplacementDefinitions({html: jsonModel.html, newsletterUuid: 'preview'});
+        const exampleMember = emailService.service.getDefaultExampleMember();
+
+        jsonModel.html = emailService.service.replaceDefinitions(jsonModel.html, replacements, exampleMember);
+
+        if (jsonModel.plaintext) {
+            jsonModel.plaintext = emailService.service.replaceDefinitions(jsonModel.plaintext, replacements, exampleMember);
+        }
+    }
 
     if (!labs.isSet('emailErrors') && !!(config.get('bulkEmail') && config.get('bulkEmail').mailgun)) {
         if (jsonModel.status === 'failed') {
@@ -21,5 +24,8 @@ module.exports = (model, frame) => {
         }
     }
 
+    // Removed loaded post relation if set
+    delete jsonModel.post;
+
     return jsonModel;
 };

package/core/server/api/endpoints/utils/serializers/output/posts.js

@@ -12,10 +12,10 @@ module.exports = {
         }
         let posts = [];
 
-        const tiersModels = await membersService.api.productRepository.list({
+        const tiersModels = await membersService.api?.productRepository.list({
             limit: 'all'
         });
-        const tiers = tiersModels.data ? tiersModels.data.map(tierModel => tierModel.toJSON()) : [];
+        const tiers = tiersModels?.data ? tiersModels.data.map(tierModel => tierModel.toJSON()) : [];
         if (models.meta) {
             for (let model of models.data) {
                 let post = await mappers.posts(model, frame, {tiers});

package/core/server/data/db/backup.js

@@ -3,7 +3,6 @@
 const fs = require('fs-extra');
 
 const path = require('path');
-const Promise = require('bluebird');
 const config = require('../../../shared/config');
 const logging = require('@tryghost/logging');
 const urlUtils = require('../../../shared/url-utils');
@@ -32,7 +31,7 @@ const readBackup = async (filename) => {
     const exists = await fs.pathExists(backupPath);
 
     if (exists) {
-        const backupFile = await fs.readFile(backupPath);
+        const backupFile = await fs.readFile(backupPath, 'utf8');
         return JSON.parse(backupFile);
     } else {
         return null;
@@ -40,23 +39,24 @@ const readBackup = async (filename) => {
 };
 
 /**
- * ## Backup
- * does an export, and stores this in a local file
- * @returns {Promise<*>}
+ * Does an export, and stores this in a local file
+ *
+ * @param {Object} options
+ * @returns {Promise<String>}
  */
 const backup = async function backup(options = {}) {
     logging.info('Creating database backup');
 
-    const props = {
-        data: exporter.doExport(options),
-        filename: exporter.fileName(options)
-    };
+    const filename = await exporter.fileName(options);
+    const data = await exporter.doExport(options);
 
-    const exportResult = await Promise.props(props);
-    const filename = await writeExportFile(exportResult);
+    const filePath = await writeExportFile({
+        data,
+        filename
+    });
 
-    logging.info('Database backup written to: ' + filename);
-    return filename;
+    logging.info(`Database backup written to ${filePath}`);
+    return filePath;
 };
 
 module.exports = {

package/core/server/data/importer/handlers/image.js

@@ -15,7 +15,7 @@ ImageHandler = {
         const store = storage.getStorage('images');
         const baseDirRegex = baseDir ? new RegExp('^' + baseDir + '/') : new RegExp('');
 
-        const imageFolderRegexes = _.map(urlUtils.STATIC_IMAGE_URL_PREFIX.split('/'), function (dir) {
+        const imageFolderRegexes = _.map(store.staticFileURLPrefix.split('/'), function (dir) {
             return new RegExp('^' + dir + '/');
         });
 
@@ -36,7 +36,7 @@ ImageHandler = {
 
         return Promise.all(files.map(function (image) {
             return store.getUniqueFileName(image, image.targetDir).then(function (targetFilename) {
-                image.newPath = urlUtils.urlJoin('/', urlUtils.getSubdir(), urlUtils.STATIC_IMAGE_URL_PREFIX,
+                image.newPath = urlUtils.urlJoin('/', urlUtils.getSubdir(), store.staticFileURLPrefix,
                     path.relative(config.getContentPath('images'), targetFilename));
 
                 return image;

package/core/server/data/importer/import-manager.js

@@ -11,15 +11,19 @@ const debug = require('@tryghost/debug')('import-manager');
 const logging = require('@tryghost/logging');
 const errors = require('@tryghost/errors');
 const ImageHandler = require('./handlers/image');
+const ImporterContentFileHandler = require('@tryghost/importer-handler-content-files');
 const RevueHandler = require('./handlers/revue');
 const JSONHandler = require('./handlers/json');
 const MarkdownHandler = require('./handlers/markdown');
-const ImageImporter = require('./importers/image');
+const ContentFileImporter = require('./importers/ContentFileImporter');
 const RevueImporter = require('@tryghost/importer-revue');
 const DataImporter = require('./importers/data');
 const urlUtils = require('../../../shared/url-utils');
 const {GhostMailer} = require('../../services/mail');
 const jobManager = require('../../services/jobs');
+const mediaStorage = require('../../adapters/storage').getStorage('media');
+const imageStorage = require('../../adapters/storage').getStorage('images');
+const fileStorage = require('../../adapters/storage').getStorage('files');
 
 const emailTemplate = require('./email-template');
 const ghostMailer = new GhostMailer();
@@ -51,15 +55,55 @@ let defaults = {
 
 class ImportManager {
     constructor() {
+        const mediaHandler = new ImporterContentFileHandler({
+            type: 'media',
+            // @NOTE: making the second parameter strict folder "content/media" brakes the glob pattern
+            //        in the importer, so we need to keep it as general "content" unless
+            //        it becomes a strict requirement
+            directories: ['media', 'content'],
+            extensions: config.get('uploads').media.extensions,
+            contentTypes: config.get('uploads').media.contentTypes,
+            contentPath: config.getContentPath('media'),
+            urlUtils: urlUtils,
+            storage: mediaStorage
+        });
+
+        const filesHandler = new ImporterContentFileHandler({
+            type: 'files',
+            // @NOTE: making the second parameter strict folder "content/files" brakes the glob pattern
+            //        in the importer, so we need to keep it as general "content" unless
+            //        it becomes a strict requirement
+            directories: ['files', 'content'],
+            extensions: config.get('uploads').files.extensions,
+            contentTypes: config.get('uploads').files.contentTypes,
+            contentPath: config.getContentPath('files'),
+            urlUtils: urlUtils,
+            storage: fileStorage
+        });
+
+        const imageImporter = new ContentFileImporter({
+            type: 'images',
+            store: imageStorage
+        });
+        const mediaImporter = new ContentFileImporter({
+            type: 'media',
+            store: mediaStorage
+        });
+
+        const contentFilesImporter = new ContentFileImporter({
+            type: 'files',
+            store: fileStorage
+        });
+
         /**
          * @type {Importer[]} importers
          */
-        this.importers = [ImageImporter, RevueImporter, DataImporter];
+        this.importers = [imageImporter, mediaImporter, contentFilesImporter, RevueImporter, DataImporter];
 
         /**
          * @type {Handler[]}
          */
-        this.handlers = [ImageHandler, RevueHandler, JSONHandler, MarkdownHandler];
+        this.handlers = [ImageHandler, mediaHandler, filesHandler, RevueHandler, JSONHandler, MarkdownHandler];
 
         // Keep track of file to cleanup at the end
         /**
@@ -257,7 +301,14 @@ class ImportManager {
         const baseDir = this.getBaseDirectory(zipDirectory);
 
         for (const handler of this.handlers) {
-            const files = this.getFilesFromZip(handler, zipDirectory);
+            let files = [];
+            if (handler.directories?.length > 0) {
+                for (const dir of handler.directories) {
+                    files.push(...this.getFilesFromZip(handler, path.join(zipDirectory, (baseDir || ''), dir)));
+                }
+            } else {
+                files.push(...this.getFilesFromZip(handler, zipDirectory));
+            }
 
             debug('handler', handler.type, files);
 
@@ -294,7 +345,15 @@ class ImportManager {
      */
     async processFile(file, ext) {
         const fileHandlers = _.filter(this.handlers, function (handler) {
-            return _.includes(handler.extensions, ext);
+            let match = _.includes(handler.extensions, ext);
+
+            // CASE: content file handlers should ignore files in the root directory
+            if (match && handler.directories && handler.directories.length) {
+                const dir = path.dirname(file.path)?.split('/')[1];
+                match = _.includes(handler.directories, dir);
+            }
+
+            return match;
         });
 
         const importData = {};

package/core/server/data/importer/importers/ContentFileImporter.js

@@ -0,0 +1,128 @@
+const _ = require('lodash');
+let replaceImage;
+let preProcessPosts;
+let preProcessTags;
+let preProcessUsers;
+
+replaceImage = function (markdown, image) {
+    if (!markdown) {
+        return;
+    }
+
+    // Normalizes to include a trailing slash if there was one
+    const regex = new RegExp('(/)?' + image.originalPath, 'gm');
+
+    return markdown.replace(regex, image.newPath);
+};
+
+/**
+ * @param {Object} data
+ * @param {Object[]} data.posts
+ * @param {Object} contentFile
+ * @param {String} contentFile.originalPath
+ * @param {String} contentFile.newPath
+ */
+preProcessPosts = function (data, contentFile) {
+    _.each(data.posts, function (post) {
+        post.markdown = replaceImage(post.markdown, contentFile);
+        if (post.html) {
+            post.html = replaceImage(post.html, contentFile);
+        }
+        if (post.feature_image) {
+            post.feature_image = replaceImage(post.feature_image, contentFile);
+        }
+    });
+};
+
+preProcessTags = function (data, image) {
+    _.each(data.tags, function (tag) {
+        if (tag.feature_image) {
+            tag.feature_image = replaceImage(tag.feature_image, image);
+        }
+    });
+};
+
+preProcessUsers = function (data, image) {
+    _.each(data.users, function (user) {
+        if (user.cover_image) {
+            user.cover_image = replaceImage(user.cover_image, image);
+        }
+        if (user.profile_image) {
+            user.profile_image = replaceImage(user.profile_image, image);
+        }
+    });
+};
+
+class ContentFileImporter {
+    /** @property {string} */
+    type;
+
+    /** @property {import('ghost-storage-base')} */
+    #store;
+
+    /**
+     *
+     * @param {Object} deps
+     * @param {'images' | 'media' | 'files'} deps.type - importer type
+     * @param {import('ghost-storage-base')} deps.store
+     */
+    constructor(deps) {
+        this.type = deps.type;
+        this.#store = deps.store;
+    }
+
+    preProcess(importData) {
+        if (this.type === 'images') {
+            if (importData.images && importData.data && importData.data.data) {
+                _.each(importData.images, function (image) {
+                    preProcessPosts(importData.data.data, image);
+                    preProcessTags(importData.data.data, image);
+                    preProcessUsers(importData.data.data, image);
+                });
+            }
+
+            importData.preProcessedByImage = true;
+        }
+
+        // @NOTE: the type === 'media' check does not belong here and should be abstracted away
+        //        to make this importer more generic
+        if (this.type === 'media') {
+            if (importData.media && importData.data && importData.data.data) {
+                _.each(importData.media, function (file) {
+                    preProcessPosts(importData.data.data, file);
+                });
+            }
+
+            importData.preProcessedByMedia = true;
+        }
+
+        if (this.type === 'files') {
+            if (importData.files && importData.data && importData.data.data) {
+                _.each(importData.files, function (file) {
+                    preProcessPosts(importData.data.data, file);
+                });
+            }
+
+            importData.preProcessedByFiles = true;
+        }
+
+        return importData;
+    }
+
+    /**
+     *
+     * @param {Object[]} contentFilesData
+     * @returns
+     */
+    doImport(contentFilesData) {
+        const store = this.#store;
+
+        return Promise.all(contentFilesData.map(function (contentFile) {
+            return store.save(contentFile, contentFile.targetDir).then(function (result) {
+                return {originalPath: contentFile.originalPath, newPath: contentFile.newPath, stored: result};
+            });
+        }));
+    }
+}
+
+module.exports = ContentFileImporter;

package/core/server/data/migrations/versions/4.9/05-fix-missed-mobiledoc-url-transforms.js

@@ -4,7 +4,7 @@ const htmlToPlaintext = require('@tryghost/html-to-plaintext');
 const mobiledocLib = require('../../../../lib/mobiledoc');
 const {createTransactionalMigration} = require('../../utils');
 
-// in Ghost versions 4.6.1-4.8.4 the 4.0 migration that transfored URLs had a bug
+// in Ghost versions 4.6.1-4.8.4 the 4.0 migration that transformed URLs had a bug
 // that meant urls inside cards in mobiledoc content was not being transformed
 //
 // if the migrations table indicates an upgrade was made from 3.x to 4.6-4.8 then