ghost 4.48.0 → 5.0.0

package/core/server/api/canary/utils/serializers/output/mappers/settings.js

@@ -1,36 +1,10 @@
 const _ = require('lodash');
 
-const extraAttrs = require('../utils/extra-attrs');
-const url = require('../utils/url');
-
-module.exports = (attrs, frame) => {
-    url.forSettings(attrs);
-    extraAttrs.forSettings(attrs, frame);
-
-    // NOTE: The cleanup of deprecated ghost_head/ghost_foot has to happen here
-    //       because codeinjection_head/codeinjection_foot are assigned on a previous
-    //      `forSettings` step. This logic can be rewritten once we get rid of deprecated
-    //      fields completely.
-    if (_.isArray(attrs)) {
-        const keysToFilter = ['ghost_head', 'ghost_foot'];
-
-        // NOTE: to support edits of deprecated 'slack' setting artificial 'slack_url' and 'slack_username'
-        //       were added to the request body in the input serializer. These should not be returned in response
-        //       body unless directly requested
-        if (frame.original.body && frame.original.body.settings) {
-            const requestedEditSlackUrl = frame.original.body.settings.find(s => s.key === 'slack_url');
-            const requestedEditSlackUsername = frame.original.body.settings.find(s => s.key === 'slack_username');
-
-            if (!requestedEditSlackUrl) {
-                keysToFilter.push('slack_url');
-            }
-
-            if (!requestedEditSlackUsername) {
-                keysToFilter.push('slack_username');
-            }
-        }
-
-        attrs = _.filter(attrs, attr => !(keysToFilter.includes(attr.key)));
+module.exports = (attrs) => {
+    if (Array.isArray(attrs)) {
+        return attrs.map((setting) => {
+            return _.pick(setting, ['key', 'value']);
+        });
     }
 
     return attrs;

package/core/server/api/canary/utils/serializers/output/members.js

@@ -4,8 +4,6 @@ const {unparse} = require('@tryghost/members-csv');
 const labsService = require('../../../../../../shared/labs');
 
 module.exports = {
-    hasActiveStripeSubscriptions: createSerializer('hasActiveStripeSubscriptions', passthrough),
-
     browse: createSerializer('browse', paginatedMembers),
     read: createSerializer('read', singleMember),
     edit: createSerializer('edit', singleMember),
@@ -124,7 +122,24 @@ function serializeMember(member, options) {
     };
 
     if (json.products) {
-        serialized.products = json.products;
+        serialized.tiers = json.products;
+    }
+
+    // Rename subscriptions.price.product to subscriptions.price.tier
+    for (const subscription of serialized.subscriptions) {
+        if (!subscription.price) {
+            continue;
+        }
+        
+        if (!subscription.price.tier && subscription.price.product) {
+            subscription.price.tier = subscription.price.product;
+            
+            if (!subscription.price.tier.tier_id) {
+                subscription.price.tier.tier_id = subscription.price.tier.product_id;
+            }
+            delete subscription.price.tier.product_id;
+        }
+        delete subscription.price.product;
     }
 
     if (labsService.isSet('multipleNewsletters')) {

package/core/server/api/canary/utils/serializers/output/offers.js

@@ -1,8 +1,16 @@
 const debug = require('@tryghost/debug')('api:canary:utils:serializers:output:offers');
+const utils = require('../../index');
 
 module.exports = {
-    all() {
+    all(_models, _apiConfig, frame) {
         debug('all');
         // Offers has frame.response already set
+
+        // Cleanup response for content API
+        // TODO: remove and set explicit allowlist when moved to mapper
+        if (utils.isContentAPI(frame) && frame.response?.offers?.[0]) {
+            delete frame.response.offers[0].redemption_count;
+            delete frame.response.offers[0].code;
+        }
     }
 };

package/core/server/api/canary/utils/serializers/output/{preview.js → previews.js}

@@ -10,8 +10,8 @@ module.exports = {
 
         const data = await mappers.posts(model, frame, {tiers});
         frame.response = {
-            preview: [data]
+            previews: [data]
         };
-        frame.response.preview[0].page = model.get('type') === 'page';
+        frame.response.previews[0].type = model.get('type');
     }
 };

package/core/server/api/canary/utils/serializers/output/settings.js

@@ -38,20 +38,14 @@ function serializeSettings(models, apiConfig, frame) {
     }
 
     frame.response = {
-        settings: mappers.settings(filteredSettings, frame),
+        settings: mappers.settings(filteredSettings),
         meta: {}
     };
 
-    if (frame.options.type || frame.options.group) {
-        frame.response.meta.filters = {};
-
-        if (frame.options.type) {
-            frame.response.meta.filters.type = frame.options.type;
-        }
-
-        if (frame.options.group) {
-            frame.response.meta.filters.group = frame.options.group;
-        }
+    if (frame.options.group) {
+        frame.response.meta.filters = {
+            group: frame.options.group
+        };
     }
 }
 
@@ -86,7 +80,5 @@ module.exports = {
     download: serializeData,
     upload: serializeData,
 
-    updateMembersEmail: passthrough,
-    validateMembersEmailUpdate: passthrough,
-    disconnectStripeConnectIntegration: passthrough
+    validateMembersEmailUpdate: passthrough
 };

package/core/server/api/canary/utils/serializers/output/site.js

@@ -14,7 +14,6 @@ module.exports = {
                 'accent_color',
                 'url',
                 'version',
-                'oauth',
                 'sentry_dsn',
                 'sentry_env'
             ])

package/core/server/api/canary/utils/serializers/output/tiers.js

@@ -1,6 +1,5 @@
 //@ts-check
 const debug = require('@tryghost/debug')('api:canary:utils:serializers:output:tiers');
-const _ = require('lodash');
 
 const allowedIncludes = ['monthly_price', 'yearly_price'];
 const utils = require('../../../../shared/utils');
@@ -60,15 +59,12 @@ function singleTier(model, _apiConfig, frame) {
 /**
  * @param {import('bookshelf').Model} tier
  * @param {object} options
- * @param {'content'|'admin'} apiType
  *
  * @returns {SerializedTier}
  */
-function serializeTier(tier, options, apiType) {
+function serializeTier(tier, options) {
     const json = tier.toJSON(options);
 
-    const hideStripeData = apiType === 'content';
-
     const serialized = {
         id: json.id,
         name: json.name,
@@ -79,47 +75,23 @@ function serializeTier(tier, options, apiType) {
         welcome_page_url: json.welcome_page_url,
         created_at: json.created_at,
         updated_at: json.updated_at,
-        stripe_prices: json.stripePrices ? json.stripePrices.map(price => serializeStripePrice(price, hideStripeData)) : null,
-        monthly_price: serializeStripePrice(json.monthlyPrice, hideStripeData),
-        yearly_price: serializeStripePrice(json.yearlyPrice, hideStripeData),
-        benefits: json.benefits || null,
-        visibility: json.visibility
+        visibility: json.visibility,
+        benefits: null
     };
 
-    return serialized;
-}
-
-/**
- * @param {object} data
- * @param {boolean} hideStripeData
- *
- * @returns {StripePrice}
- */
-function serializeStripePrice(data, hideStripeData) {
-    if (_.isEmpty(data)) {
-        return null;
+    if (Array.isArray(json.benefits)) {
+        serialized.benefits = json.benefits.map(benefit => benefit.name);
+    } else {
+        serialized.benefits = null;
     }
-    const price = {
-        id: data.id,
-        stripe_tier_id: data.stripe_product_id,
-        stripe_price_id: data.stripe_price_id,
-        active: data.active,
-        nickname: data.nickname,
-        description: data.description,
-        currency: data.currency,
-        amount: data.amount,
-        type: data.type,
-        interval: data.interval,
-        created_at: data.created_at,
-        updated_at: data.updated_at
-    };
 
-    if (hideStripeData) {
-        delete price.stripe_price_id;
-        delete price.stripe_tier_id;
+    if (serialized.type === 'paid') {
+        serialized.currency = json.monthlyPrice?.currency;
+        serialized.monthly_price = json.monthlyPrice?.amount;
+        serialized.yearly_price = json.yearlyPrice?.amount;
     }
 
-    return price;
+    return serialized;
 }
 
 /**
@@ -160,7 +132,7 @@ function createSerializer(debugString, serialize) {
 }
 
 /**
- * @typedef {Object} SerializedTier
+ * @typedef {Object} FreeTier
  * @prop {string} id
  * @prop {string} name
  * @prop {string} slug
@@ -170,34 +142,21 @@ function createSerializer(debugString, serialize) {
  * @prop {string} welcome_page_url
  * @prop {Date} created_at
  * @prop {Date} updated_at
- * @prop {StripePrice} [monthly_price]
- * @prop {StripePrice} [yearly_price]
- * @prop {Benefit[]} [benefits]
+ * @prop {string[]} [benefits]
  */
 
 /**
- * @typedef {object} Benefit
- * @prop {string} id
- * @prop {string} name
- * @prop {string} slug
- * @prop {Date} created_at
- * @prop {Date} updated_at
+ * @typedef {FreeTier} PaidTier
+ * @prop {string} currency
+ * @prop {number} monthly_price
+ * @prop {number} yearly_price
  */
 
 /**
- * @typedef {object} StripePrice
- * @prop {string} id
- * @prop {string|null} stripe_tier_id
- * @prop {string|null} stripe_price_id
- * @prop {boolean} active
- * @prop {string} nickname
- * @prop {string} description
+ * @typedef {FreeTier | PaidTier} SerializedTier
  * @prop {string} currency
- * @prop {number} amount
- * @prop {'recurring'|'one-time'} type
- * @prop {'day'|'week'|'month'|'year'} interval
- * @prop {Date} created_at
- * @prop {Date} updated_at
+ * @prop {number} monthly_price
+ * @prop {number} yearly_price
  */
 
 /**

package/core/server/api/canary/utils/serializers/output/utils/clean.js

@@ -73,10 +73,10 @@ const post = (attrs, frame) => {
     const columns = frame && frame.options && frame.options.columns || null;
     const fields = frame && frame.original && frame.original.query && frame.original.query.fields || null;
     if (localUtils.isContentAPI(frame)) {
-        // @TODO: https://github.com/TryGhost/Ghost/issues/10335
-        // delete attrs.page;
         delete attrs.status;
         delete attrs.email_only;
+        delete attrs.newsletter;
+        delete attrs.email_segment;
 
         // We are standardising on returning null from the Content API for any empty values
         if (attrs.twitter_title === '') {
@@ -101,16 +101,10 @@ const post = (attrs, frame) => {
         if (columns && columns.includes('visibility') && fields && !fields.includes('visibility')) {
             delete attrs.visibility;
         }
-    } else {
-        delete attrs.page;
     }
 
-    if (columns && columns.includes('email_recipient_filter') && fields && !fields.includes('email_recipient_filter')) {
-        delete attrs.email_recipient_filter;
-    }
-
-    if (fields && !fields.includes('send_email_when_published')) {
-        delete attrs.send_email_when_published;
+    if (columns && columns.includes('email_segment') && fields && !fields.includes('email_segment')) {
+        delete attrs.email_segment;
     }
 
     if (!attrs.tags) {
@@ -124,6 +118,7 @@ const post = (attrs, frame) => {
     delete attrs.locale;
     delete attrs.author;
     delete attrs.type;
+    delete attrs.newsletter_id;
 
     return attrs;
 };

package/core/server/api/canary/utils/serializers/output/utils/extra-attrs.js

@@ -31,129 +31,3 @@ module.exports.forPost = (frame, model, attrs) => {
         }
     }
 };
-
-module.exports.forSettings = (attrs, frame) => {
-    const _ = require('lodash');
-
-    // @TODO: https://github.com/TryGhost/Ghost/issues/10106
-    // @NOTE: Admin & Content API return a different format, needs two mappers
-    if (_.isArray(attrs)) {
-        // CASE: read single setting
-        if (frame.original.params && frame.original.params.key) {
-            if (frame.original.params.key === 'ghost_head') {
-                attrs[0].key = 'ghost_head';
-                return;
-            }
-
-            if (frame.original.params.key === 'ghost_foot') {
-                attrs[0].key = 'ghost_foot';
-                return;
-            }
-
-            if (frame.original.params.key === 'active_timezone') {
-                attrs[0].key = 'active_timezone';
-                return;
-            }
-
-            if (frame.original.params.key === 'default_locale') {
-                attrs[0].key = 'default_locale';
-                return;
-            }
-
-            if (frame.original.params.key === 'timezone') {
-                return;
-            }
-
-            if (frame.original.params.key === 'lang') {
-                return;
-            }
-
-            if (frame.original.params.key === 'slack_url'
-                || frame.original.params.key === 'slack_username') {
-                return;
-            }
-        }
-        // CASE: edit
-        if (frame.original.body && frame.original.body.settings) {
-            frame.original.body.settings.forEach((setting) => {
-                if (setting.key === 'ghost_head') {
-                    const target = _.find(attrs, {key: 'codeinjection_head'});
-                    target.key = 'ghost_head';
-                } else if (setting.key === 'ghost_foot') {
-                    const target = _.find(attrs, {key: 'codeinjection_foot'});
-                    target.key = 'ghost_foot';
-                } else if (setting.key === 'active_timezone') {
-                    const target = _.find(attrs, {key: 'timezone'});
-                    target.key = 'active_timezone';
-                } else if (setting.key === 'default_locale') {
-                    const target = _.find(attrs, {key: 'lang'});
-                    target.key = 'default_locale';
-                } else if (setting.key === 'locale') {
-                    const target = _.find(attrs, {key: 'lang'});
-                    target.key = 'locale';
-                } else if (setting.key === 'slack') {
-                    const slackURL = _.cloneDeep(_.find(attrs, {key: 'slack_url'}));
-                    const slackUsername = _.cloneDeep(_.find(attrs, {key: 'slack_username'}));
-
-                    if (slackURL || slackUsername) {
-                        const slack = slackURL || slackUsername;
-                        slack.key = 'slack';
-                        slack.value = JSON.stringify([{
-                            url: slackURL && slackURL.value,
-                            username: slackUsername && slackUsername.value
-                        }]);
-
-                        attrs.push(slack);
-                    }
-                }
-            });
-
-            return;
-        }
-
-        // CASE: browse all settings, add extra keys and keep deprecated
-        const ghostHead = _.cloneDeep(_.find(attrs, {key: 'codeinjection_head'}));
-        const ghostFoot = _.cloneDeep(_.find(attrs, {key: 'codeinjection_foot'}));
-        const timezone = _.cloneDeep(_.find(attrs, {key: 'timezone'}));
-        const lang = _.cloneDeep(_.find(attrs, {key: 'lang'}));
-        const slackURL = _.cloneDeep(_.find(attrs, {key: 'slack_url'}));
-        const slackUsername = _.cloneDeep(_.find(attrs, {key: 'slack_username'}));
-        const locale = _.cloneDeep(_.find(attrs, {key: 'lang'}));
-
-        if (ghostHead) {
-            ghostHead.key = 'ghost_head';
-            attrs.push(ghostHead);
-        }
-
-        if (ghostFoot) {
-            ghostFoot.key = 'ghost_foot';
-            attrs.push(ghostFoot);
-        }
-
-        if (timezone) {
-            timezone.key = 'active_timezone';
-            attrs.push(timezone);
-        }
-
-        if (lang) {
-            lang.key = 'default_locale';
-            attrs.push(lang);
-        }
-
-        if (slackURL || slackUsername) {
-            const slack = slackURL || slackUsername;
-            slack.key = 'slack';
-            slack.value = JSON.stringify([{
-                url: slackURL && slackURL.value,
-                username: slackUsername && slackUsername.value
-            }]);
-
-            attrs.push(slack);
-        }
-
-        if (locale) {
-            locale.key = 'locale';
-            attrs.push(locale);
-        }
-    }
-};

package/core/server/api/canary/utils/serializers/output/utils/post-gating.js

@@ -15,7 +15,7 @@ const forPost = (attrs, frame) => {
 
         if (paywallIndex !== -1) {
             attrs.html = attrs.html.slice(0, paywallIndex);
-            attrs.plaintext = htmlToPlaintext(attrs.html);
+            attrs.plaintext = htmlToPlaintext.excerpt(attrs.html);
 
             if (!attrs.custom_excerpt && attrs.excerpt) {
                 attrs.excerpt = attrs.plaintext.substring(0, 500);

package/core/server/api/canary/utils/serializers/output/utils/url.js

@@ -58,10 +58,6 @@ const forTag = (id, attrs, options) => {
     return attrs;
 };
 
-const forSettings = (attrs) => {
-    return attrs;
-};
-
 const forImage = (path) => {
     return urlUtils.urlFor('image', {image: path}, true);
 };
@@ -69,5 +65,4 @@ const forImage = (path) => {
 module.exports.forPost = forPost;
 module.exports.forUser = forUser;
 module.exports.forTag = forTag;
-module.exports.forSettings = forSettings;
 module.exports.forImage = forImage;

package/core/server/api/canary/utils/validators/input/index.js

@@ -5,8 +5,8 @@
 /* eslint-disable max-lines */
 
 module.exports = {
-    get passwordreset() {
-        return require('./passwordreset');
+    get password_reset() {
+        return require('./password_reset');
     },
 
     get setup() {

package/core/server/api/canary/utils/validators/input/{passwordreset.js → password_reset.js}

@@ -13,7 +13,7 @@ module.exports = {
     resetPassword(apiConfig, frame) {
         debug('resetPassword');
 
-        const data = frame.data.passwordreset[0];
+        const data = frame.data.password_reset[0];
 
         if (data.newPassword !== data.ne2Password) {
             return Promise.reject(new errors.ValidationError({
@@ -25,7 +25,7 @@ module.exports = {
     generateResetToken(apiConfig, frame) {
         debug('generateResetToken');
 
-        const email = frame.data.passwordreset[0].email;
+        const email = frame.data.password_reset[0].email;
 
         if (typeof email !== 'string' || !validator.isEmail(email)) {
             throw new errors.BadRequestError({

package/core/server/api/canary/utils/validators/input/settings.js

@@ -1,7 +1,6 @@
 const Promise = require('bluebird');
 const _ = require('lodash');
-const tpl = require('@tryghost/tpl');
-const {NotFoundError, ValidationError, BadRequestError} = require('@tryghost/errors');
+const {ValidationError, BadRequestError} = require('@tryghost/errors');
 const validator = require('@tryghost/validator');
 
 const messages = {
@@ -11,30 +10,10 @@ const messages = {
 };
 
 module.exports = {
-    read(apiConfig, frame) {
-        // @NOTE: was removed https://github.com/TryGhost/Ghost/issues/10373
-        if (frame.options.key === 'ghost_head' || frame.options.key === 'ghost_foot') {
-            return Promise.reject(new NotFoundError({
-                message: tpl(messages.problemFindingSetting, {
-                    key: frame.options.key
-                })
-            }));
-        }
-    },
-
     edit(apiConfig, frame) {
         const errors = [];
 
         _.each(frame.data.settings, (setting) => {
-            if (setting.key === 'ghost_head' || setting.key === 'ghost_foot') {
-                // @NOTE: was removed https://github.com/TryGhost/Ghost/issues/10373
-                errors.push(new NotFoundError({
-                    message: tpl(messages.problemFindingSetting, {
-                        key: setting.key
-                    })
-                }));
-            }
-
             // TODO: the below array is INCOMPLETE
             //       it should include all setting values that have array as a type
             const arrayTypeSettings = [
@@ -80,7 +59,7 @@ module.exports = {
             });
         }
 
-        if (!type || !['fromAddressUpdate', 'supportAddressUpdate'].includes(type)) {
+        if (!type || !['supportAddressUpdate'].includes(type)) {
             throw new BadRequestError({
                 message: messages.invalidEmailTypeReceived
             });

package/core/server/api/canary/utils/validators/utils/json-schema.js

@@ -10,8 +10,7 @@ const jsonSchema = require('@tryghost/admin-api-schema');
  */
 const validate = async (apiConfig, frame) => await jsonSchema.validate({
     data: frame.data,
-    schema: `${apiConfig.docName}-${apiConfig.method}`,
-    version: 'canary'
+    schema: `${apiConfig.docName}-${apiConfig.method}`
 });
 
 module.exports.validate = validate;

package/core/server/api/index.js

@@ -1,9 +1,3 @@
-const defaultAPI = require('./canary');
-
-module.exports = defaultAPI;
-module.exports.canary = defaultAPI;
-module.exports.v4 = defaultAPI;
-module.exports.v3 = require('./v3');
-module.exports.v2 = require('./v2');
+module.exports.endpoints = require('./canary');
 
 module.exports.shared = require('./shared');

package/core/server/api/shared/serializers/input/utils/settings-key-group-mapper.js

@@ -6,7 +6,7 @@ const keyGroupMapping = {
     db_hash: 'core',
     next_update_check: 'core',
     notifications: 'core',
-    session_secret: 'core',
+    admin_session_secret: 'core',
     theme_session_secret: 'core',
     ghost_public_key: 'core',
     ghost_private_key: 'core',
@@ -16,7 +16,7 @@ const keyGroupMapping = {
     cover_image: 'site',
     icon: 'site',
     accent_color: 'site',
-    lang: 'site',
+    locale: 'site',
     timezone: 'site',
     codeinjection_head: 'site',
     codeinjection_foot: 'site',

package/core/server/api/shared/serializers/input/utils/settings-key-type-mapper.js

@@ -1,7 +1,7 @@
 // NOTE: mapping is based on maping present in migration - 3.22/07-update-type-for-settings
 const keyTypeMapping = {
     db_hash: 'string',
-    session_secret: 'string',
+    admin_session_secret: 'string',
     theme_session_secret: 'string',
     ghost_public_key: 'string',
     ghost_private_key: 'string',
@@ -11,7 +11,7 @@ const keyTypeMapping = {
     cover_image: 'string',
     icon: 'string',
     accent_color: 'string',
-    lang: 'string',
+    locale: 'string',
     timezone: 'string',
     codeinjection_head: 'string',
     codeinjection_foot: 'string',
@@ -32,8 +32,6 @@ const keyTypeMapping = {
     members_private_key: 'string',
     members_email_auth_secret: 'string',
     default_content_visibility: 'string',
-    members_from_address: 'string',
-    stripe_product_name: 'string',
     stripe_secret_key: 'string',
     stripe_publishable_key: 'string',
     stripe_connect_publishable_key: 'string',

package/core/server/data/db/connection.js

@@ -36,19 +36,6 @@ function configure(dbConfig) {
         dbConfig.connection.timezone = 'Z';
         dbConfig.connection.charset = 'utf8mb4';
         dbConfig.connection.decimalNumbers = true;
-
-        // NOTE: disabled so that worker processes can use the db without
-        // requiring logging and causing file desriptor leaks.
-        // See https://github.com/TryGhost/Ghost/issues/12496
-        //
-        // const logging = require('@tryghost/logging');
-        // const errors = require('@tryghost/errors');
-        // dbConfig.connection.loggingHook = function loggingHook(err) {
-        //     logging.error(new errors.InternalServerError({
-        //         code: 'MYSQL_LOGGING_HOOK',
-        //         err: err
-        //     }));
-        // };
     }
 
     return dbConfig;

package/core/server/data/exporter/table-lists.js

@@ -14,7 +14,6 @@ const BACKUP_TABLES = [
     'members_stripe_customers_subscriptions',
     'migrations',
     'migrations_lock',
-    'oauth',
     'permissions',
     'permissions_roles',
     'permissions_users',
@@ -71,8 +70,6 @@ const SETTING_KEYS_BLOCKLIST = [
     'stripe_publishable_key',
     'members_stripe_webhook_id',
     'members_stripe_webhook_secret',
-    'oauth_client_id',
-    'oauth_client_secret',
     'email_verification_required'
 ];