ghagga 2.8.1 → 3.1.0

package/dist/lib/cli-github-client-port.test.js

@@ -0,0 +1,47 @@
+/**
+ * resolveGitHubRepoId — numeric repo id resolution for RepoRef.nativeId.
+ *
+ * The CLI `--pr` flow resolves the IMMUTABLE numeric GitHub repo id once before
+ * the post-back (mirroring the GitLab `--mr` flow's resolveGitLabProjectId). We
+ * mock ONLY `fetch` (the network seam) so this exercises the genuine GET
+ * /repos/{owner}/{repo} → .id call + its error handling.
+ */
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { resolveGitHubRepoId } from './cli-github-client-port.js';
+const mockFetch = vi.fn();
+vi.stubGlobal('fetch', mockFetch);
+function jsonResponse(status, body) {
+    return {
+        ok: status >= 200 && status < 300,
+        status,
+        statusText: status === 200 ? 'OK' : 'ERR',
+        text: () => Promise.resolve(JSON.stringify(body)),
+        json: () => Promise.resolve(body),
+    };
+}
+describe('resolveGitHubRepoId (numeric repo id resolution → RepoRef.nativeId)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    it('GET /repos/{owner}/{repo} → numeric id as string', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { id: 555000111, full_name: 'acme/widgets' }));
+        const id = await resolveGitHubRepoId('acme', 'widgets', 'ghp');
+        // Stringified to match RepoRef.nativeId's string type (consistent with GitLab).
+        expect(id).toBe('555000111');
+        const [url] = mockFetch.mock.calls[0];
+        expect(url).toBe('https://api.github.com/repos/acme/widgets');
+    });
+    it('passes an AbortSignal (timeout) so CI cannot hang', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { id: 1 }));
+        await resolveGitHubRepoId('acme', 'widgets', 'ghp');
+        const [, init] = mockFetch.mock.calls[0];
+        expect(init.signal).toBeInstanceOf(AbortSignal);
+    });
+    it('throws on a non-ok response (e.g. 404)', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(404, { message: 'Not Found' }));
+        await expect(resolveGitHubRepoId('nope', 'nope', 'ghp')).rejects.toThrow(/resolving repo id/);
+    });
+    it('throws when the response has no numeric "id"', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { full_name: 'acme/widgets' }));
+        await expect(resolveGitHubRepoId('acme', 'widgets', 'ghp')).rejects.toThrow(/no numeric "id"/);
+    });
+});
+//# sourceMappingURL=cli-github-client-port.test.js.map

package/dist/lib/cli-github-client-port.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-github-client-port.test.js","sourceRoot":"","sources":["../../src/lib/cli-github-client-port.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,mBAAmB,EAAE,MAAM,6BAA6B,CAAC;AAElE,MAAM,SAAS,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC1B,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;AAElC,SAAS,YAAY,CAAC,MAAc,EAAE,IAAa;IACjD,OAAO;QACL,EAAE,EAAE,MAAM,IAAI,GAAG,IAAI,MAAM,GAAG,GAAG;QACjC,MAAM;QACN,UAAU,EAAE,MAAM,KAAK,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK;QACzC,IAAI,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC;QACjD,IAAI,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC,IAAI,CAAC;KACtB,CAAC;AAChB,CAAC;AAED,QAAQ,CAAC,qEAAqE,EAAE,GAAG,EAAE;IACnF,UAAU,CAAC,GAAG,EAAE,CAAC,SAAS,CAAC,SAAS,EAAE,CAAC,CAAC;IAExC,EAAE,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;QAChE,SAAS,CAAC,qBAAqB,CAC7B,YAAY,CAAC,GAAG,EAAE,EAAE,EAAE,EAAE,SAAS,EAAE,SAAS,EAAE,cAAc,EAAE,CAAC,CAChE,CAAC;QACF,MAAM,EAAE,GAAG,MAAM,mBAAmB,CAAC,MAAM,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;QAC/D,gFAAgF;QAChF,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAC7B,MAAM,CAAC,GAAG,CAAC,GAAG,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QAC/D,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,2CAA2C,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mDAAmD,EAAE,KAAK,IAAI,EAAE;QACjE,SAAS,CAAC,qBAAqB,CAAC,YAAY,CAAC,GAAG,EAAE,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;QAC9D,MAAM,mBAAmB,CAAC,MAAM,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;QACpD,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,SAAS,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QAClE,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,cAAc,CAAC,WAAW,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wCAAwC,EAAE,KAAK,IAAI,EAAE;QACtD,SAAS,CAAC,qBAAqB,CAAC,YAAY,CAAC,GAAG,EAAE,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC,CAAC;QAC7E,MAAM,MAAM,CAAC,mBAAmB,CAAC,MAAM,EAAE,MAAM,EAAE,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC;IAChG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,SAAS,CAAC,qBAAqB,CAAC,YAAY,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,cAAc,EAAE,CAAC,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,mBAAmB,CAAC,MAAM,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,iBAAiB,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/lib/cli-gitlab-client-port.d.ts

@@ -0,0 +1,62 @@
+/**
+ * CLI-side implementation of the forge `GitLabClientPort` + numeric-project-id
+ * resolution for the `ghagga review --mr N` MR summary post-back.
+ *
+ * The `GitLabForgeAdapter` (packages/forge) depends on an injected
+ * {@link GitLabClientPort} (dependency inversion — forge MUST NOT import any
+ * concrete HTTP client). The CLI provides the real native-fetch implementation
+ * here, on the same `AbortSignal.timeout` + error-class pattern as
+ * `cli-github-client-port.ts`.
+ *
+ * AUTH: we send ONLY the `PRIVATE-TOKEN: <pat>` header — GitLab's recommended
+ * header for Personal/Project/Group Access Tokens (the kind `ghagga` uses). We do
+ * NOT also send `Authorization: Bearer`, which is for OAuth2 access tokens; mixing
+ * both is unnecessary and the PAT header is the canonical PAT auth path.
+ *
+ * HOST: the API base is derived from the resolved GitLab host
+ * (`https://<host>/api/v4`) so self-managed instances work, with a `GITLAB_HOST`
+ * env override for the rare case the API host differs from the git remote host.
+ *
+ * SCOPE (P4 — MR summary post-back): the four note members the adapter's
+ * `upsertSummaryComment` folds over (list/create/delete/update) plus
+ * `publishInline` (create). All four route through the NUMERIC project id (the
+ * canonical R-GITLAB identity). `resolveGitLabProjectId` is the pre-construction
+ * step that turns the mutable group/project path into that numeric id.
+ */
+import type { GitLabClientPort } from 'ghagga-forge';
+/**
+ * Resolve the GitLab API base (`https://<host>/api/v4`) for a remote host.
+ *
+ * Precedence:
+ *   1. `GITLAB_API_BASE` — a FULL API base override. Required for a self-managed
+ *      GitLab served under a SUBPATH (e.g. `https://example.com/gitlab`), where a
+ *      host-only value cannot express the `/gitlab` prefix. Used verbatim (only a
+ *      trailing slash is trimmed); supply the complete `.../api/v4` URL.
+ *   2. `GITLAB_HOST` — a host-only override (for when the API host differs from
+ *      the git remote host, e.g. a reverse proxy on a different hostname).
+ *   3. the host parsed from the git remote.
+ * For (2)/(3) a bare host is expected; a stray scheme/trailing slash is tolerated.
+ */
+export declare function resolveGitLabApiBase(host: string, env?: NodeJS.ProcessEnv): string;
+/**
+ * Resolve the GitLab NUMERIC project id from a group/project path (R-GITLAB).
+ *
+ * `GET /projects/:url-encoded-path` → `.id`. The path is mutable, so the numeric
+ * id is the canonical `RepoRef.nativeId`. This runs ONCE before constructing the
+ * adapter; it is NOT part of the {@link GitLabClientPort} (the adapter only ever
+ * speaks numeric ids).
+ *
+ * @param apiBase the resolved API base (`https://<host>/api/v4`) — see
+ *   {@link resolveGitLabApiBase}. Defaults to gitlab.com for back-compat callers.
+ * @returns the numeric project id as a STRING (RepoRef.nativeId is a string).
+ */
+export declare function resolveGitLabProjectId(path: string, token: string, apiBase?: string): Promise<string>;
+/**
+ * Build a {@link GitLabClientPort} backed by native fetch for the CLI `--mr`
+ * post-back. All members route through the numeric project id.
+ *
+ * @param apiBase the resolved API base (`https://<host>/api/v4`) — see
+ *   {@link resolveGitLabApiBase}. Defaults to gitlab.com for back-compat callers.
+ */
+export declare function createCliGitLabClientPort(apiBase?: string): GitLabClientPort;
+//# sourceMappingURL=cli-gitlab-client-port.d.ts.map

package/dist/lib/cli-gitlab-client-port.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-gitlab-client-port.d.ts","sourceRoot":"","sources":["../../src/lib/cli-gitlab-client-port.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AAEH,OAAO,KAAK,EAAE,gBAAgB,EAAc,MAAM,cAAc,CAAC;AAUjE;;;;;;;;;;;;GAYG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,GAAE,MAAM,CAAC,UAAwB,GAAG,MAAM,CAU/F;AAwBD;;;;;;;;;;;GAWG;AACH,wBAAsB,sBAAsB,CAC1C,IAAI,EAAE,MAAM,EACZ,KAAK,EAAE,MAAM,EACb,OAAO,SAA8B,GACpC,OAAO,CAAC,MAAM,CAAC,CAgBjB;AAED;;;;;;GAMG;AACH,wBAAgB,yBAAyB,CAAC,OAAO,SAA8B,GAAG,gBAAgB,CA2GjG"}

package/dist/lib/cli-gitlab-client-port.js

@@ -0,0 +1,209 @@
+/**
+ * CLI-side implementation of the forge `GitLabClientPort` + numeric-project-id
+ * resolution for the `ghagga review --mr N` MR summary post-back.
+ *
+ * The `GitLabForgeAdapter` (packages/forge) depends on an injected
+ * {@link GitLabClientPort} (dependency inversion — forge MUST NOT import any
+ * concrete HTTP client). The CLI provides the real native-fetch implementation
+ * here, on the same `AbortSignal.timeout` + error-class pattern as
+ * `cli-github-client-port.ts`.
+ *
+ * AUTH: we send ONLY the `PRIVATE-TOKEN: <pat>` header — GitLab's recommended
+ * header for Personal/Project/Group Access Tokens (the kind `ghagga` uses). We do
+ * NOT also send `Authorization: Bearer`, which is for OAuth2 access tokens; mixing
+ * both is unnecessary and the PAT header is the canonical PAT auth path.
+ *
+ * HOST: the API base is derived from the resolved GitLab host
+ * (`https://<host>/api/v4`) so self-managed instances work, with a `GITLAB_HOST`
+ * env override for the rare case the API host differs from the git remote host.
+ *
+ * SCOPE (P4 — MR summary post-back): the four note members the adapter's
+ * `upsertSummaryComment` folds over (list/create/delete/update) plus
+ * `publishInline` (create). All four route through the NUMERIC project id (the
+ * canonical R-GITLAB identity). `resolveGitLabProjectId` is the pre-construction
+ * step that turns the mutable group/project path into that numeric id.
+ */
+import { GitLabApiError } from './gitlab-api.js';
+/**
+ * Per-request timeout for the CLI's GitLab fetch calls. Mirrors the GitHub CLI
+ * port's `AbortSignal.timeout(10_000)` so a slow/hung GitLab can never hang a CI
+ * job indefinitely.
+ */
+const REQUEST_TIMEOUT_MS = 10_000;
+/**
+ * Resolve the GitLab API base (`https://<host>/api/v4`) for a remote host.
+ *
+ * Precedence:
+ *   1. `GITLAB_API_BASE` — a FULL API base override. Required for a self-managed
+ *      GitLab served under a SUBPATH (e.g. `https://example.com/gitlab`), where a
+ *      host-only value cannot express the `/gitlab` prefix. Used verbatim (only a
+ *      trailing slash is trimmed); supply the complete `.../api/v4` URL.
+ *   2. `GITLAB_HOST` — a host-only override (for when the API host differs from
+ *      the git remote host, e.g. a reverse proxy on a different hostname).
+ *   3. the host parsed from the git remote.
+ * For (2)/(3) a bare host is expected; a stray scheme/trailing slash is tolerated.
+ */
+export function resolveGitLabApiBase(host, env = process.env) {
+    const apiBaseOverride = env.GITLAB_API_BASE?.trim();
+    if (apiBaseOverride) {
+        return apiBaseOverride.replace(/\/+$/, '');
+    }
+    const hostOverride = env.GITLAB_HOST?.trim();
+    const chosen = hostOverride || host;
+    // Tolerate an override that includes a scheme and/or trailing slash.
+    const bare = chosen.replace(/^https?:\/\//i, '').replace(/\/+$/, '');
+    return `https://${bare}/api/v4`;
+}
+/** Auth headers — PRIVATE-TOKEN only (GitLab's recommended header for PATs). */
+function apiHeaders(token) {
+    return {
+        'PRIVATE-TOKEN': token,
+        'Content-Type': 'application/json',
+    };
+}
+async function failOn(res, action) {
+    const body = await res.text();
+    throw new GitLabApiError(`GitLab API error ${action}: ${res.status} ${res.statusText}`, res.status, body);
+}
+/** Encode a path segment that itself contains slashes (group/subgroup/project). */
+function encodeProjectPath(path) {
+    return encodeURIComponent(path);
+}
+/**
+ * Resolve the GitLab NUMERIC project id from a group/project path (R-GITLAB).
+ *
+ * `GET /projects/:url-encoded-path` → `.id`. The path is mutable, so the numeric
+ * id is the canonical `RepoRef.nativeId`. This runs ONCE before constructing the
+ * adapter; it is NOT part of the {@link GitLabClientPort} (the adapter only ever
+ * speaks numeric ids).
+ *
+ * @param apiBase the resolved API base (`https://<host>/api/v4`) — see
+ *   {@link resolveGitLabApiBase}. Defaults to gitlab.com for back-compat callers.
+ * @returns the numeric project id as a STRING (RepoRef.nativeId is a string).
+ */
+export async function resolveGitLabProjectId(path, token, apiBase = 'https://gitlab.com/api/v4') {
+    const url = `${apiBase}/projects/${encodeProjectPath(path)}`;
+    const res = await fetch(url, {
+        headers: apiHeaders(token),
+        signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+    });
+    if (!res.ok)
+        await failOn(res, 'resolving project id');
+    const data = (await res.json());
+    if (typeof data.id !== 'number') {
+        throw new GitLabApiError(`GitLab API error resolving project id: response had no numeric "id" for path "${path}"`, res.status, JSON.stringify(data));
+    }
+    return String(data.id);
+}
+/**
+ * Build a {@link GitLabClientPort} backed by native fetch for the CLI `--mr`
+ * post-back. All members route through the numeric project id.
+ *
+ * @param apiBase the resolved API base (`https://<host>/api/v4`) — see
+ *   {@link resolveGitLabApiBase}. Defaults to gitlab.com for back-compat callers.
+ */
+export function createCliGitLabClientPort(apiBase = 'https://gitlab.com/api/v4') {
+    return {
+        async listMrNotes(projectId, mrIid, token) {
+            // Paginate until exhausted (a page with < 100 items is the last page),
+            // like the GitHub port. MAX_PAGES is a safety upper bound (50 × 100 = 5000
+            // notes) so a pathological MR can't loop forever; if hit we log rather
+            // than silently truncate, since a stale marker beyond the bound would
+            // yield a DUPLICATE note. (Was 5 pages / 500 items — backlog #6.)
+            const baseUrl = `${apiBase}/projects/${projectId}/merge_requests/${mrIid}/notes`;
+            const MAX_PAGES = 50;
+            const out = [];
+            for (let page = 1; page <= MAX_PAGES; page++) {
+                const url = `${baseUrl}?per_page=100&page=${page}&sort=asc&order_by=created_at`;
+                const res = await fetch(url, {
+                    headers: apiHeaders(token),
+                    signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+                });
+                if (!res.ok)
+                    await failOn(res, 'listing MR notes');
+                const notes = (await res.json());
+                for (const note of notes) {
+                    out.push({ id: note.id, body: note.body });
+                }
+                if (notes.length < 100)
+                    break;
+                if (page === MAX_PAGES) {
+                    console.warn(`[ghagga] listMrNotes hit MAX_PAGES (${MAX_PAGES}) for project ${projectId} MR !${mrIid}; note listing may be truncated`);
+                }
+            }
+            return out;
+        },
+        async createMrNote(projectId, mrIid, body, token) {
+            const url = `${apiBase}/projects/${projectId}/merge_requests/${mrIid}/notes`;
+            const res = await fetch(url, {
+                method: 'POST',
+                headers: apiHeaders(token),
+                body: JSON.stringify({ body }),
+                signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+            });
+            if (!res.ok)
+                await failOn(res, 'creating MR note');
+            const data = (await res.json());
+            return { id: data.id };
+        },
+        async deleteMrNote(projectId, mrIid, noteId, token) {
+            const url = `${apiBase}/projects/${projectId}/merge_requests/${mrIid}/notes/${noteId}`;
+            const res = await fetch(url, {
+                method: 'DELETE',
+                headers: apiHeaders(token),
+                signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+            });
+            // The adapter's upsert tolerates delete failures (best-effort), but we
+            // still surface a non-2xx (except 404) so `deleted[]` only reflects
+            // genuinely-removed ids.
+            if (!res.ok && res.status !== 404)
+                await failOn(res, 'deleting MR note');
+        },
+        async createMrDiscussion(projectId, mrIid, body, position, token) {
+            // True diff-anchored discussion: POST /merge_requests/:iid/discussions with
+            // position[position_type]=text + the three SHAs + old/new path + line(s).
+            const url = `${apiBase}/projects/${projectId}/merge_requests/${mrIid}/discussions`;
+            const payload = {
+                body,
+                position: {
+                    position_type: 'text',
+                    base_sha: position.baseSha,
+                    head_sha: position.headSha,
+                    start_sha: position.startSha,
+                    old_path: position.oldPath,
+                    new_path: position.newPath,
+                    ...(position.oldLine != null ? { old_line: position.oldLine } : {}),
+                    ...(position.newLine != null ? { new_line: position.newLine } : {}),
+                },
+            };
+            const res = await fetch(url, {
+                method: 'POST',
+                headers: apiHeaders(token),
+                body: JSON.stringify(payload),
+                signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+            });
+            if (!res.ok)
+                await failOn(res, 'creating MR discussion');
+            // The discussion response nests its notes; box the FIRST note's id so the
+            // result matches the createMrNote contract ({ id: number }).
+            const data = (await res.json());
+            const firstNoteId = data.notes?.[0]?.id;
+            if (typeof firstNoteId !== 'number') {
+                throw new GitLabApiError('GitLab API error creating MR discussion: response had no numeric notes[0].id', res.status, JSON.stringify(data));
+            }
+            return { id: firstNoteId };
+        },
+        async updateMrNote(projectId, mrIid, noteId, body, token) {
+            const url = `${apiBase}/projects/${projectId}/merge_requests/${mrIid}/notes/${noteId}`;
+            const res = await fetch(url, {
+                method: 'PUT',
+                headers: apiHeaders(token),
+                body: JSON.stringify({ body }),
+                signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
+            });
+            if (!res.ok)
+                await failOn(res, 'updating MR note');
+        },
+    };
+}
+//# sourceMappingURL=cli-gitlab-client-port.js.map

package/dist/lib/cli-gitlab-client-port.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-gitlab-client-port.js","sourceRoot":"","sources":["../../src/lib/cli-gitlab-client-port.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AAGH,OAAO,EAAE,cAAc,EAAE,MAAM,iBAAiB,CAAC;AAEjD;;;;GAIG;AACH,MAAM,kBAAkB,GAAG,MAAM,CAAC;AAElC;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,oBAAoB,CAAC,IAAY,EAAE,MAAyB,OAAO,CAAC,GAAG;IACrF,MAAM,eAAe,GAAG,GAAG,CAAC,eAAe,EAAE,IAAI,EAAE,CAAC;IACpD,IAAI,eAAe,EAAE,CAAC;QACpB,OAAO,eAAe,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IAC7C,CAAC;IACD,MAAM,YAAY,GAAG,GAAG,CAAC,WAAW,EAAE,IAAI,EAAE,CAAC;IAC7C,MAAM,MAAM,GAAG,YAAY,IAAI,IAAI,CAAC;IACpC,qEAAqE;IACrE,MAAM,IAAI,GAAG,MAAM,CAAC,OAAO,CAAC,eAAe,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACrE,OAAO,WAAW,IAAI,SAAS,CAAC;AAClC,CAAC;AAED,gFAAgF;AAChF,SAAS,UAAU,CAAC,KAAa;IAC/B,OAAO;QACL,eAAe,EAAE,KAAK;QACtB,cAAc,EAAE,kBAAkB;KACnC,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,MAAM,CAAC,GAAa,EAAE,MAAc;IACjD,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,IAAI,EAAE,CAAC;IAC9B,MAAM,IAAI,cAAc,CACtB,oBAAoB,MAAM,KAAK,GAAG,CAAC,MAAM,IAAI,GAAG,CAAC,UAAU,EAAE,EAC7D,GAAG,CAAC,MAAM,EACV,IAAI,CACL,CAAC;AACJ,CAAC;AAED,mFAAmF;AACnF,SAAS,iBAAiB,CAAC,IAAY;IACrC,OAAO,kBAAkB,CAAC,IAAI,CAAC,CAAC;AAClC,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,CAAC,KAAK,UAAU,sBAAsB,CAC1C,IAAY,EACZ,KAAa,EACb,OAAO,GAAG,2BAA2B;IAErC,MAAM,GAAG,GAAG,GAAG,OAAO,aAAa,iBAAiB,CAAC,IAAI,CAAC,EAAE,CAAC;IAC7D,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;QAC3B,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;QAC1B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;KAChD,CAAC,CAAC;IACH,IAAI,CAAC,GAAG,CAAC,EAAE;QAAE,MAAM,MAAM,CAAC,GAAG,EAAE,sBAAsB,CAAC,CAAC;IACvD,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAmB,CAAC;IAClD,IAAI,OAAO,IAAI,CAAC,EAAE,KAAK,QAAQ,EAAE,CAAC;QAChC,MAAM,IAAI,cAAc,CACtB,iFAAiF,IAAI,GAAG,EACxF,GAAG,CAAC,MAAM,EACV,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CACrB,CAAC;IACJ,CAAC;IACD,OAAO,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;AACzB,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,yBAAyB,CAAC,OAAO,GAAG,2BAA2B;IAC7E,OAAO;QACL,KAAK,CAAC,WAAW,CAAC,SAAS,EAAE,KAAK,EAAE,KAAK;YACvC,uEAAuE;YACvE,2EAA2E;YAC3E,uEAAuE;YACvE,sEAAsE;YACtE,kEAAkE;YAClE,MAAM,OAAO,GAAG,GAAG,OAAO,aAAa,SAAS,mBAAmB,KAAK,QAAQ,CAAC;YACjF,MAAM,SAAS,GAAG,EAAE,CAAC;YACrB,MAAM,GAAG,GAAiB,EAAE,CAAC;YAC7B,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,IAAI,SAAS,EAAE,IAAI,EAAE,EAAE,CAAC;gBAC7C,MAAM,GAAG,GAAG,GAAG,OAAO,sBAAsB,IAAI,+BAA+B,CAAC;gBAChF,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;oBAC3B,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;oBAC1B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;iBAChD,CAAC,CAAC;gBACH,IAAI,CAAC,GAAG,CAAC,EAAE;oBAAE,MAAM,MAAM,CAAC,GAAG,EAAE,kBAAkB,CAAC,CAAC;gBACnD,MAAM,KAAK,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAwC,CAAC;gBACxE,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;oBACzB,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,IAAI,CAAC,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;gBAC7C,CAAC;gBACD,IAAI,KAAK,CAAC,MAAM,GAAG,GAAG;oBAAE,MAAM;gBAC9B,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;oBACvB,OAAO,CAAC,IAAI,CACV,uCAAuC,SAAS,iBAAiB,SAAS,QAAQ,KAAK,iCAAiC,CACzH,CAAC;gBACJ,CAAC;YACH,CAAC;YACD,OAAO,GAAG,CAAC;QACb,CAAC;QAED,KAAK,CAAC,YAAY,CAAC,SAAS,EAAE,KAAK,EAAE,IAAI,EAAE,KAAK;YAC9C,MAAM,GAAG,GAAG,GAAG,OAAO,aAAa,SAAS,mBAAmB,KAAK,QAAQ,CAAC;YAC7E,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;gBAC3B,MAAM,EAAE,MAAM;gBACd,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;gBAC1B,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,CAAC;gBAC9B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;aAChD,CAAC,CAAC;YACH,IAAI,CAAC,GAAG,CAAC,EAAE;gBAAE,MAAM,MAAM,CAAC,GAAG,EAAE,kBAAkB,CAAC,CAAC;YACnD,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAmB,CAAC;YAClD,OAAO,EAAE,EAAE,EAAE,IAAI,CAAC,EAAE,EAAE,CAAC;QACzB,CAAC;QAED,KAAK,CAAC,YAAY,CAAC,SAAS,EAAE,KAAK,EAAE,MAAM,EAAE,KAAK;YAChD,MAAM,GAAG,GAAG,GAAG,OAAO,aAAa,SAAS,mBAAmB,KAAK,UAAU,MAAM,EAAE,CAAC;YACvF,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;gBAC3B,MAAM,EAAE,QAAQ;gBAChB,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;gBAC1B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;aAChD,CAAC,CAAC;YACH,uEAAuE;YACvE,oEAAoE;YACpE,yBAAyB;YACzB,IAAI,CAAC,GAAG,CAAC,EAAE,IAAI,GAAG,CAAC,MAAM,KAAK,GAAG;gBAAE,MAAM,MAAM,CAAC,GAAG,EAAE,kBAAkB,CAAC,CAAC;QAC3E,CAAC;QAED,KAAK,CAAC,kBAAkB,CAAC,SAAS,EAAE,KAAK,EAAE,IAAI,EAAE,QAAQ,EAAE,KAAK;YAC9D,4EAA4E;YAC5E,0EAA0E;YAC1E,MAAM,GAAG,GAAG,GAAG,OAAO,aAAa,SAAS,mBAAmB,KAAK,cAAc,CAAC;YACnF,MAAM,OAAO,GAA4B;gBACvC,IAAI;gBACJ,QAAQ,EAAE;oBACR,aAAa,EAAE,MAAM;oBACrB,QAAQ,EAAE,QAAQ,CAAC,OAAO;oBAC1B,QAAQ,EAAE,QAAQ,CAAC,OAAO;oBAC1B,SAAS,EAAE,QAAQ,CAAC,QAAQ;oBAC5B,QAAQ,EAAE,QAAQ,CAAC,OAAO;oBAC1B,QAAQ,EAAE,QAAQ,CAAC,OAAO;oBAC1B,GAAG,CAAC,QAAQ,CAAC,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,QAAQ,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;oBACnE,GAAG,CAAC,QAAQ,CAAC,OAAO,IAAI,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,QAAQ,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;iBACpE;aACF,CAAC;YACF,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;gBAC3B,MAAM,EAAE,MAAM;gBACd,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;gBAC1B,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;gBAC7B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;aAChD,CAAC,CAAC;YACH,IAAI,CAAC,GAAG,CAAC,EAAE;gBAAE,MAAM,MAAM,CAAC,GAAG,EAAE,wBAAwB,CAAC,CAAC;YACzD,0EAA0E;YAC1E,6DAA6D;YAC7D,MAAM,IAAI,GAAG,CAAC,MAAM,GAAG,CAAC,IAAI,EAAE,CAAsC,CAAC;YACrE,MAAM,WAAW,GAAG,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;YACxC,IAAI,OAAO,WAAW,KAAK,QAAQ,EAAE,CAAC;gBACpC,MAAM,IAAI,cAAc,CACtB,8EAA8E,EAC9E,GAAG,CAAC,MAAM,EACV,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CACrB,CAAC;YACJ,CAAC;YACD,OAAO,EAAE,EAAE,EAAE,WAAW,EAAE,CAAC;QAC7B,CAAC;QAED,KAAK,CAAC,YAAY,CAAC,SAAS,EAAE,KAAK,EAAE,MAAM,EAAE,IAAI,EAAE,KAAK;YACtD,MAAM,GAAG,GAAG,GAAG,OAAO,aAAa,SAAS,mBAAmB,KAAK,UAAU,MAAM,EAAE,CAAC;YACvF,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,GAAG,EAAE;gBAC3B,MAAM,EAAE,KAAK;gBACb,OAAO,EAAE,UAAU,CAAC,KAAK,CAAC;gBAC1B,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,CAAC;gBAC9B,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,kBAAkB,CAAC;aAChD,CAAC,CAAC;YACH,IAAI,CAAC,GAAG,CAAC,EAAE;gBAAE,MAAM,MAAM,CAAC,GAAG,EAAE,kBAAkB,CAAC,CAAC;QACrD,CAAC;KACF,CAAC;AACJ,CAAC"}

package/dist/lib/cli-gitlab-client-port.test.d.ts

@@ -0,0 +1,9 @@
+/**
+ * R-GITLAB / R-LEAK-PUBLISH: the `--mr` post-back routes through the REAL
+ * GitLabForgeAdapter folding over the CLI's own GitLabClientPort. We mock ONLY
+ * `fetch` (the network seam), so this exercises the genuine adapter
+ * find→delete→repost idempotency AND the genuine CLI port REST calls — a
+ * faithful simulation against a mocked GitLab.
+ */
+export {};
+//# sourceMappingURL=cli-gitlab-client-port.test.d.ts.map

package/dist/lib/cli-gitlab-client-port.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-gitlab-client-port.test.d.ts","sourceRoot":"","sources":["../../src/lib/cli-gitlab-client-port.test.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG"}

package/dist/lib/cli-gitlab-client-port.test.js

@@ -0,0 +1,278 @@
+/**
+ * R-GITLAB / R-LEAK-PUBLISH: the `--mr` post-back routes through the REAL
+ * GitLabForgeAdapter folding over the CLI's own GitLabClientPort. We mock ONLY
+ * `fetch` (the network seam), so this exercises the genuine adapter
+ * find→delete→repost idempotency AND the genuine CLI port REST calls — a
+ * faithful simulation against a mocked GitLab.
+ */
+import { GitLabForgeAdapter } from 'ghagga-forge';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { createCliGitLabClientPort, resolveGitLabApiBase, resolveGitLabProjectId, } from './cli-gitlab-client-port.js';
+import { postSummaryComment } from './pr-postback.js';
+const mockFetch = vi.fn();
+vi.stubGlobal('fetch', mockFetch);
+function jsonResponse(status, body) {
+    return {
+        ok: status >= 200 && status < 300,
+        status,
+        statusText: status === 200 ? 'OK' : status === 201 ? 'Created' : 'ERR',
+        text: () => Promise.resolve(JSON.stringify(body)),
+        json: () => Promise.resolve(body),
+    };
+}
+const MARKER = { html: '<!-- ghagga-review -->' };
+const PROJECT_ID = '12345';
+const REF = {
+    repo: { kind: 'gitlab', nativeId: PROJECT_ID, path: 'acme/widgets' },
+    iid: 7,
+};
+function buildAdapter(token = 'glpat') {
+    return new GitLabForgeAdapter({
+        client: createCliGitLabClientPort(),
+        token,
+        projectId: PROJECT_ID,
+    });
+}
+describe('resolveGitLabProjectId (numeric project id resolution, R-GITLAB)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    it('GET /projects/:url-encoded-path → numeric id as string', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { id: 12345, path_with_namespace: 'acme/widgets' }));
+        const id = await resolveGitLabProjectId('acme/widgets', 'glpat');
+        expect(id).toBe('12345');
+        const [url] = mockFetch.mock.calls[0];
+        // path is URL-encoded (nested-group safe).
+        expect(url).toBe('https://gitlab.com/api/v4/projects/acme%2Fwidgets');
+    });
+    it('URL-encodes nested-group paths', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { id: 99 }));
+        await resolveGitLabProjectId('group/subgroup/project', 'glpat');
+        const [url] = mockFetch.mock.calls[0];
+        expect(url).toContain('projects/group%2Fsubgroup%2Fproject');
+    });
+    it('throws on a non-ok response', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(404, { message: '404 Project Not Found' }));
+        await expect(resolveGitLabProjectId('nope/nope', 'glpat')).rejects.toThrow(/resolving project id/);
+    });
+});
+describe('postSummaryComment via CLI GitLab port + GitLabForgeAdapter', () => {
+    beforeEach(() => mockFetch.mockReset());
+    it('creates a fresh note when none exists (no stale to delete)', async () => {
+        // listMrNotes: empty
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, []));
+        // createMrNote → { id }
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 9001 }));
+        const adapter = buildAdapter();
+        const body = `${MARKER.html}\n## body`;
+        const result = await postSummaryComment(adapter, REF, body, MARKER);
+        expect(result.createdNativeId).toBe(9001);
+        expect(result.deletedNativeIds).toEqual([]);
+        expect(mockFetch).toHaveBeenCalledTimes(2);
+        const [listUrl] = mockFetch.mock.calls[0];
+        expect(listUrl).toContain('/projects/12345/merge_requests/7/notes');
+        const [postUrl, postInit] = mockFetch.mock.calls[1];
+        expect(postUrl).toBe('https://gitlab.com/api/v4/projects/12345/merge_requests/7/notes');
+        expect(postInit.method).toBe('POST');
+        expect(JSON.parse(postInit.body)).toEqual({ body });
+    });
+    it('finds stale by marker → deletes ALL → reposts fresh (idempotent upsert)', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, [
+            { id: 100, body: `old ${MARKER.html}` },
+            { id: 200, body: 'someone else' },
+            { id: 300, body: `newer ${MARKER.html}` },
+        ]));
+        // delete latest=300, delete stale=100
+        mockFetch.mockResolvedValueOnce(jsonResponse(204, {}));
+        mockFetch.mockResolvedValueOnce(jsonResponse(204, {}));
+        // create fresh
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 400 }));
+        const adapter = buildAdapter();
+        const result = await postSummaryComment(adapter, REF, 'body', MARKER);
+        expect(result.createdNativeId).toBe(400);
+        expect(result.deletedNativeIds).toEqual([300, 100]);
+        const del1 = mockFetch.mock.calls[1];
+        const del2 = mockFetch.mock.calls[2];
+        expect(del1[0]).toContain('/notes/300');
+        expect(del1[1].method).toBe('DELETE');
+        expect(del2[0]).toContain('/notes/100');
+        // foreign note 200 never deleted.
+        const allUrls = mockFetch.mock.calls.map((c) => c[0]).join('\n');
+        expect(allUrls).not.toContain('/notes/200');
+    });
+    it('sends ONLY PRIVATE-TOKEN (no Bearer) + an AbortSignal (FIX E)', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, []));
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 1 }));
+        const adapter = buildAdapter('secret-pat');
+        await postSummaryComment(adapter, REF, 'body', MARKER);
+        const [, postInit] = mockFetch.mock.calls[1];
+        const headers = postInit.headers;
+        expect(headers['PRIVATE-TOKEN']).toBe('secret-pat');
+        expect(headers.Authorization).toBeUndefined();
+        for (const call of mockFetch.mock.calls) {
+            expect(call[1].signal).toBeInstanceOf(AbortSignal);
+        }
+    });
+    it('a 401 with the static PAT is fatal (no retry loop)', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(401, { message: '401 Unauthorized' }));
+        const adapter = buildAdapter();
+        await expect(postSummaryComment(adapter, REF, 'body', MARKER)).rejects.toThrow();
+        expect(mockFetch).toHaveBeenCalledTimes(1);
+    });
+});
+describe('CLI GitLab port — publishInline partial failure end-to-end (R-LEAK-PUBLISH)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    it('5 inline notes, 3 fail (500) → posted 2, failed 3, never aborts', async () => {
+        // create calls in order: ok, 500, 500, ok, 500
+        mockFetch
+            .mockResolvedValueOnce(jsonResponse(201, { id: 11 }))
+            .mockResolvedValueOnce(jsonResponse(500, { message: 'boom' }))
+            .mockResolvedValueOnce(jsonResponse(500, { message: 'boom' }))
+            .mockResolvedValueOnce(jsonResponse(201, { id: 14 }))
+            .mockResolvedValueOnce(jsonResponse(500, { message: 'boom' }));
+        const adapter = buildAdapter();
+        const report = await adapter.publishInline(REF, [
+            { path: 'a.ts', line: 1, body: 'c0' },
+            { path: 'b.ts', line: 2, body: 'c1' },
+            { path: 'c.ts', line: 3, body: 'c2' },
+            { path: 'd.ts', line: 4, body: 'c3' },
+            { path: 'e.ts', line: 5, body: 'c4' },
+        ]);
+        expect(report.posted).toEqual([
+            { kind: 'gitlab', raw: '11' },
+            { kind: 'gitlab', raw: '14' },
+        ]);
+        expect(report.failed.map((f) => f.index)).toEqual([1, 2, 4]);
+        expect(mockFetch).toHaveBeenCalledTimes(5);
+    });
+});
+describe('resolveGitLabApiBase (FIX A — derive API base from host + env overrides)', () => {
+    it('defaults to https://<host>/api/v4 for the parsed remote host', () => {
+        expect(resolveGitLabApiBase('gitlab.com', {})).toBe('https://gitlab.com/api/v4');
+        expect(resolveGitLabApiBase('gitlab.example.com', {})).toBe('https://gitlab.example.com/api/v4');
+    });
+    it('GITLAB_HOST overrides the remote host', () => {
+        expect(resolveGitLabApiBase('gitlab.com', { GITLAB_HOST: 'api.internal' })).toBe('https://api.internal/api/v4');
+    });
+    it('GITLAB_API_BASE is a full override (subpath self-hosted)', () => {
+        expect(resolveGitLabApiBase('gitlab.com', {
+            GITLAB_API_BASE: 'https://example.com/gitlab/api/v4',
+        })).toBe('https://example.com/gitlab/api/v4');
+    });
+    it('GITLAB_API_BASE wins over GITLAB_HOST + trims trailing slash', () => {
+        expect(resolveGitLabApiBase('gitlab.com', {
+            GITLAB_HOST: 'ignored.example',
+            GITLAB_API_BASE: 'https://example.com/gitlab/api/v4/',
+        })).toBe('https://example.com/gitlab/api/v4');
+    });
+});
+describe('CLI GitLab port — self-hosted API base (FIX A)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    function buildSelfHostedAdapter() {
+        return new GitLabForgeAdapter({
+            client: createCliGitLabClientPort('https://gitlab.example.com/api/v4'),
+            token: 'glpat',
+            projectId: PROJECT_ID,
+        });
+    }
+    it('routes note calls + project-id resolution against the self-hosted host', async () => {
+        // resolveGitLabProjectId against the self-hosted base.
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, { id: 12345 }));
+        const id = await resolveGitLabProjectId('team/repo', 'glpat', 'https://gitlab.example.com/api/v4');
+        expect(id).toBe('12345');
+        const [idUrl] = mockFetch.mock.calls[0];
+        expect(idUrl).toBe('https://gitlab.example.com/api/v4/projects/team%2Frepo');
+        mockFetch.mockReset();
+        // upsert against the self-hosted base.
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, []));
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 9001 }));
+        const adapter = buildSelfHostedAdapter();
+        await postSummaryComment(adapter, REF, 'body', MARKER);
+        const [postUrl, postInit] = mockFetch.mock.calls[1];
+        expect(postUrl).toBe('https://gitlab.example.com/api/v4/projects/12345/merge_requests/7/notes');
+        // PRIVATE-TOKEN only.
+        const headers = postInit.headers;
+        expect(headers['PRIVATE-TOKEN']).toBe('glpat');
+        expect(headers.Authorization).toBeUndefined();
+    });
+});
+describe('CLI GitLab port — listMrNotes pagination (backlog #6)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    function makeNotes(count, startId = 0, markerAt) {
+        return Array.from({ length: count }, (_, i) => ({
+            id: startId + i,
+            body: i === markerAt ? `summary ${startId + i} ${MARKER.html}` : `noise ${startId + i}`,
+        }));
+    }
+    it('single page (< 100 notes) → exactly one list call, no extra fetch', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, makeNotes(20, 0)));
+        const port = createCliGitLabClientPort();
+        const notes = await port.listMrNotes('12345', 7, 'glpat');
+        expect(notes).toHaveLength(20);
+        expect(mockFetch).toHaveBeenCalledTimes(1);
+        const [url] = mockFetch.mock.calls[0];
+        expect(url).toContain('page=1');
+    });
+    it('multi-page → full page 1 forces page 2 fetch; stale-on-page-2 found + deleted (no duplicate)', async () => {
+        // page 1: 100 notes, NO marker → must fetch page 2; page 2 carries the stale marker.
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, makeNotes(100, 0)));
+        mockFetch.mockResolvedValueOnce(jsonResponse(200, makeNotes(15, 100, 5))); // marker id 105
+        // adapter then deletes the found stale (id 105) and reposts fresh.
+        mockFetch.mockResolvedValueOnce(jsonResponse(204, {})); // delete 105
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 999 })); // repost
+        const adapter = buildAdapter();
+        const result = await postSummaryComment(adapter, REF, 'body', MARKER);
+        // Stale on page 2 WAS found and deleted — not duplicated.
+        expect(result.deletedNativeIds).toEqual([105]);
+        expect(result.createdNativeId).toBe(999);
+        // page 1 + page 2 list calls happened.
+        expect(mockFetch.mock.calls[0][0]).toContain('page=1');
+        expect(mockFetch.mock.calls[1][0]).toContain('page=2');
+        const delCall = mockFetch.mock.calls[2];
+        expect(delCall[0]).toContain('/notes/105');
+        expect(delCall[1].method).toBe('DELETE');
+    });
+    it('safety bound → stops at MAX_PAGES (50) and warns instead of looping forever', async () => {
+        for (let page = 0; page < 50; page++) {
+            mockFetch.mockResolvedValueOnce(jsonResponse(200, makeNotes(100, page * 100)));
+        }
+        const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => { });
+        const port = createCliGitLabClientPort();
+        const notes = await port.listMrNotes('12345', 7, 'glpat');
+        expect(notes).toHaveLength(5000);
+        expect(mockFetch).toHaveBeenCalledTimes(50);
+        expect(mockFetch.mock.calls[49][0]).toContain('page=50');
+        expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining('MAX_PAGES (50)'));
+        warnSpy.mockRestore();
+    });
+});
+describe('CLI GitLab port — createMrDiscussion (FIX C true positioning)', () => {
+    beforeEach(() => mockFetch.mockReset());
+    it('posts a positioned inline comment to /discussions and boxes notes[0].id', async () => {
+        mockFetch.mockResolvedValueOnce(jsonResponse(201, { id: 'disc-1', notes: [{ id: 555 }] }));
+        const adapter = buildAdapter();
+        const report = await adapter.publishInline(REF, [
+            {
+                path: 'src/x.ts',
+                line: 4,
+                side: 'new',
+                body: 'anchored',
+                position: { baseSha: 'B', headSha: 'H', startSha: 'S', newLine: 4 },
+            },
+        ]);
+        expect(report.posted).toEqual([{ kind: 'gitlab', raw: '555' }]);
+        const [discUrl, discInit] = mockFetch.mock.calls[0];
+        expect(discUrl).toBe('https://gitlab.com/api/v4/projects/12345/merge_requests/7/discussions');
+        expect(discInit.method).toBe('POST');
+        const payload = JSON.parse(discInit.body);
+        expect(payload.body).toBe('anchored');
+        expect(payload.position).toEqual({
+            position_type: 'text',
+            base_sha: 'B',
+            head_sha: 'H',
+            start_sha: 'S',
+            old_path: 'src/x.ts',
+            new_path: 'src/x.ts',
+            new_line: 4,
+        });
+    });
+});
+//# sourceMappingURL=cli-gitlab-client-port.test.js.map