gh-here 3.0.3 → 3.2.0

package/lib/git.js

@@ -1,13 +1,14 @@
-const { exec } = require('child_process');
-const path = require('path');
-const fs = require('fs');
-const octicons = require('@primer/octicons');
-
 /**
  * Git operations module
- * Handles git status, commits, diffs, and branch operations
+ * Handles git status, diffs, and branch operations (read-only)
+ * @module git
  */
 
+const { exec } = require('child_process');
+const fs = require('fs');
+const octicons = require('@primer/octicons');
+const path = require('path');
+
 // Check if current directory or any parent is a git repository
 function findGitRepo(dir) {
   if (fs.existsSync(path.join(dir, '.git'))) {
@@ -130,49 +131,6 @@ function getGitBranch(gitRepoRoot) {
   });
 }
 
-// Commit operations
-async function commitAllChanges(gitRepoRoot, message) {
-  const util = require('util');
-  const execAsync = util.promisify(exec);
-  
-  try {
-    // Add all changes
-    await execAsync('git add -A', { cwd: gitRepoRoot });
-    
-    // Commit with message
-    const escapedMessage = message.replace(/"/g, '\\"');
-    await execAsync(`git commit -m "${escapedMessage}"`, { cwd: gitRepoRoot });
-    
-    return { success: true, message: 'Changes committed successfully' };
-  } catch (gitError) {
-    throw new Error(gitError.message || 'Git commit failed');
-  }
-}
-
-async function commitSelectedFiles(gitRepoRoot, message, files) {
-  const util = require('util');
-  const execAsync = util.promisify(exec);
-  
-  try {
-    // Add selected files one by one
-    for (const file of files) {
-      const escapedFile = file.replace(/"/g, '\\"');
-      await execAsync(`git add "${escapedFile}"`, { cwd: gitRepoRoot });
-    }
-    
-    // Commit with message
-    const escapedMessage = message.replace(/"/g, '\\"');
-    await execAsync(`git commit -m "${escapedMessage}"`, { cwd: gitRepoRoot });
-    
-    return { 
-      success: true, 
-      message: `${files.length} file${files.length === 1 ? '' : 's'} committed successfully` 
-    };
-  } catch (gitError) {
-    throw new Error(gitError.message || 'Git commit failed');
-  }
-}
-
 // Get git diff for a specific file
 function getGitDiff(gitRepoRoot, filePath, staged = false) {
   return new Promise((resolve, reject) => {
@@ -197,11 +155,9 @@ function getGitDiff(gitRepoRoot, filePath, staged = false) {
 
 module.exports = {
   findGitRepo,
-  getGitStatusIcon,
-  getGitStatusDescription,
-  getGitStatus,
   getGitBranch,
-  commitAllChanges,
-  commitSelectedFiles,
-  getGitDiff
+  getGitDiff,
+  getGitStatus,
+  getGitStatusDescription,
+  getGitStatusIcon
 };

package/lib/gitignore.js

@@ -1,41 +1,52 @@
-const fs = require('fs');
-const path = require('path');
-
 /**
  * Gitignore handling module
  * Parses .gitignore files and filters files/directories
+ * @module gitignore
  */
 
-// Cache for gitignore rules
+const fs = require('fs');
+const path = require('path');
+
+// ============================================================================
+// Cache
+// ============================================================================
+
 let gitignoreCache = null;
 let gitignoreCacheTime = 0;
+const CACHE_TTL_MS = 5000;
 
-function parseGitignore(gitignorePath) {
-  try {
-    if (!fs.existsSync(gitignorePath)) {
-      return [];
-    }
-    
-    const content = fs.readFileSync(gitignorePath, 'utf8');
-    return content
-      .split('\n')
-      .map(line => line.trim())
-      .filter(line => line && !line.startsWith('#'))
-      .map(pattern => {
-        // Convert gitignore patterns to regex-like matching
-        if (pattern.endsWith('/')) {
-          // Directory pattern
-          return { pattern: pattern.slice(0, -1), isDirectory: true };
-        }
-        return { pattern, isDirectory: false };
-      });
-  } catch (error) {
-    return [];
+// ============================================================================
+// Functions
+// ============================================================================
+
+/**
+ * Gets cached gitignore rules or parses fresh from disk
+ * @param {string} workingDir - Working directory path
+ * @returns {Array<{pattern: string, isDirectory: boolean}>} Parsed rules
+ */
+function getGitignoreRules(workingDir) {
+  const gitignorePath = path.join(workingDir, '.gitignore');
+  const now = Date.now();
+  
+  if (gitignoreCache && (now - gitignoreCacheTime) < CACHE_TTL_MS) {
+    return gitignoreCache;
   }
+  
+  gitignoreCache = parseGitignore(gitignorePath);
+  gitignoreCacheTime = now;
+  return gitignoreCache;
 }
 
+/**
+ * Checks if a file path matches any gitignore rules
+ * @param {string} filePath - File path to check
+ * @param {Array} gitignoreRules - Parsed gitignore rules
+ * @param {string} workingDir - Working directory for relative path calculation
+ * @param {boolean} [isDirectory=false] - Whether the path is a directory
+ * @returns {boolean} True if path should be ignored
+ */
 function isIgnoredByGitignore(filePath, gitignoreRules, workingDir, isDirectory = false) {
-  if (!gitignoreRules || gitignoreRules.length === 0) {
+  if (!gitignoreRules?.length) {
     return false;
   }
   
@@ -45,12 +56,11 @@ function isIgnoredByGitignore(filePath, gitignoreRules, workingDir, isDirectory
   for (const rule of gitignoreRules) {
     const { pattern, isDirectory: ruleIsDirectory } = rule;
     
-    // Skip directory rules for files and vice versa (unless rule applies to both)
+    // Skip directory rules for files
     if (ruleIsDirectory && !isDirectory) {
       continue;
     }
     
-    // Simple pattern matching (this is a basic implementation)
     if (pattern.includes('*')) {
       // Wildcard matching
       const regex = new RegExp('^' + pattern.replace(/\*/g, '.*') + '$');
@@ -70,22 +80,41 @@ function isIgnoredByGitignore(filePath, gitignoreRules, workingDir, isDirectory
   return false;
 }
 
-function getGitignoreRules(workingDir) {
-  const gitignorePath = path.join(workingDir, '.gitignore');
-  const now = Date.now();
-  
-  // Cache for 5 seconds to avoid excessive file reads
-  if (gitignoreCache && (now - gitignoreCacheTime) < 5000) {
-    return gitignoreCache;
+/**
+ * Parses a .gitignore file into structured rules
+ * @param {string} gitignorePath - Path to .gitignore file
+ * @returns {Array<{pattern: string, isDirectory: boolean}>} Parsed rules
+ */
+function parseGitignore(gitignorePath) {
+  try {
+    if (!fs.existsSync(gitignorePath)) {
+      return [];
+    }
+    
+    const content = fs.readFileSync(gitignorePath, 'utf8');
+    return content
+      .split('\n')
+      .map(line => line.trim())
+      .filter(line => line && !line.startsWith('#'))
+      .map(pattern => {
+        // Convert gitignore patterns to regex-like matching
+        if (pattern.endsWith('/')) {
+          // Directory pattern
+          return { pattern: pattern.slice(0, -1), isDirectory: true };
+        }
+        return { pattern, isDirectory: false };
+      });
+  } catch (error) {
+    return [];
   }
-  
-  gitignoreCache = parseGitignore(gitignorePath);
-  gitignoreCacheTime = now;
-  return gitignoreCache;
 }
 
+// ============================================================================
+// Exports (alpha-sorted)
+// ============================================================================
+
 module.exports = {
-  parseGitignore,
+  getGitignoreRules,
   isIgnoredByGitignore,
-  getGitignoreRules
+  parseGitignore
 };

package/lib/renderers.js

@@ -53,13 +53,11 @@ function renderDirectory(currentPath, items, showGitignored = false, gitBranch =
     const rowStatusClass = statusKey ? ` file-row--${statusKey}` : '';
     return `
     <tr class="file-row${rowStatusClass}" data-name="${item.name.toLowerCase()}" data-type="${item.isDirectory ? 'dir' : 'file'}" data-path="${item.path}">
-      <td class="icon">
+      <td class="col-icon">
         ${item.isDirectory ? octicons['file-directory-fill'].toSVG({ class: 'octicon-directory' }) : getFileIcon(item.name)}
-      </td>
-      <td class="git-status-col">
         ${item.gitStatus ? (item.gitStatus.status === '??' ? `<span class="git-status git-status-untracked" title="Untracked file">${require('./git').getGitStatusIcon('??')}</span>` : `<span class="git-status git-status-${item.gitStatus.status.replace(' ', '')}" title="Git Status: ${getGitStatusDescription(item.gitStatus.status)}">${getGitStatusIcon(item.gitStatus.status)}</span>`) : ''}
       </td>
-      <td class="name">
+      <td class="col-name">
         <a href="/?path=${encodeURIComponent(item.path)}">${item.name}</a>
         <div class="quick-actions">
           <button class="quick-btn copy-path-btn" title="Copy path" data-path="${item.path}">
@@ -75,24 +73,12 @@ function renderDirectory(currentPath, items, showGitignored = false, gitBranch =
               ${octicons.download.toSVG({ class: 'quick-icon' })}
             </a>
           ` : ''}
-          ${!item.isDirectory ? `
-            <button class="quick-btn edit-file-btn" title="Edit file" data-path="${item.path}">
-              ${octicons.pencil.toSVG({ class: 'quick-icon' })}
-            </button>
-          ` : `
-            <button class="quick-btn rename-btn" title="Rename" data-path="${item.path}" data-name="${item.name}" data-is-directory="${item.isDirectory}">
-              ${octicons.pencil.toSVG({ class: 'quick-icon' })}
-            </button>
-          `}
-          <button class="quick-btn delete-btn" title="Delete" data-path="${item.path}" data-name="${item.name}" data-is-directory="${item.isDirectory}">
-            ${octicons.trash.toSVG({ class: 'quick-icon' })}
-          </button>
         </div>
       </td>
-      <td class="size">
+      <td class="col-size">
         ${item.isDirectory ? '-' : formatBytes(item.size)}
       </td>
-      <td class="modified">
+      <td class="col-modified">
         ${item.modified.toLocaleDateString()}
       </td>
     </tr>
@@ -103,7 +89,7 @@ function renderDirectory(currentPath, items, showGitignored = false, gitBranch =
     <html data-theme="dark">
     <head>
       <title>gh-here: ${currentPath || 'Root'}</title>
-      <link rel="stylesheet" href="/static/styles.css?v=3.0.5">
+      <link rel="stylesheet" href="/static/css/main.css?v=3.2.0">
       <script>
         // Check localStorage and add showGitignored param if needed (before page renders)
         (function() {
@@ -195,23 +181,21 @@ function renderDirectory(currentPath, items, showGitignored = false, gitBranch =
               <table class="file-table" id="file-table">
             <thead>
               <tr>
-                <th></th>
-                <th></th>
-                <th>Name</th>
-                <th>Size</th>
-                <th>Modified</th>
+                <th class="col-icon"></th>
+                <th class="col-name">Name</th>
+                <th class="col-size">Size</th>
+                <th class="col-modified">Modified</th>
               </tr>
             </thead>
             <tbody>
               ${currentPath && currentPath !== '.' ? `
                 <tr class="file-row" data-name=".." data-type="dir">
-                  <td class="icon">${octicons['arrow-up'].toSVG({ class: 'octicon-directory' })}</td>
-                  <td class="git-status-col"></td>
-                  <td class="name">
+                  <td class="col-icon">${octicons['arrow-up'].toSVG({ class: 'octicon-directory' })}</td>
+                  <td class="col-name">
                     <a href="/?path=${encodeURIComponent(path.dirname(currentPath))}">.</a>
                   </td>
-                  <td class="size">-</td>
-                  <td class="modified">-</td>
+                  <td class="col-size">-</td>
+                  <td class="col-modified">-</td>
                 </tr>
               ` : ''}
               ${itemsHtml}
@@ -407,8 +391,8 @@ async function renderFileDiff(filePath, ext, gitInfo, gitRepoRoot, workingDir =
         <html data-theme="dark">
         <head>
           <title>gh-here: ${path.basename(filePath)} (diff)</title>
-          <link rel="stylesheet" href="/static/styles.css?v=3.0.5">
-          <link rel="stylesheet" href="/static/highlight.css?v=${Date.now()}">
+          <link rel="stylesheet" href="/static/css/main.css?v=3.2.0">
+          
           <script>
             // Check localStorage and add showGitignored param if needed (before page renders)
             (function() {
@@ -787,8 +771,8 @@ async function renderFile(filePath, content, ext, viewMode = 'rendered', gitStat
     <html data-theme="dark">
     <head>
       <title>gh-here: ${path.basename(filePath)}</title>
-      <link rel="stylesheet" href="/static/styles.css?v=3.0.5">
-      <link rel="stylesheet" href="/static/highlight.css?v=${Date.now()}">
+      <link rel="stylesheet" href="/static/css/main.css?v=3.2.0">
+      
       <script>
         // Check localStorage and add showGitignored param if needed (before page renders)
         (function() {

package/lib/server.js

@@ -2,11 +2,13 @@ const express = require('express');
 const fs = require('fs');
 const path = require('path');
 
-const { getGitStatus, getGitBranch, commitAllChanges, commitSelectedFiles, getGitDiff } = require('./git');
-const { isIgnoredByGitignore, getGitignoreRules } = require('./gitignore');
-const { renderDirectory, renderFileDiff, renderFile, renderNewFile } = require('./renderers');
-const { isImageFile, isBinaryFile } = require('./file-utils');
 const { buildFileTree } = require('./file-tree-builder');
+const { getGitBranch, getGitDiff, getGitStatus } = require('./git');
+const { getGitignoreRules, isIgnoredByGitignore } = require('./gitignore');
+const { groupSymbolsByKind, parseSymbols } = require('./symbol-parser');
+const { isBinaryFile, isImageFile } = require('./file-utils');
+const { renderDirectory, renderFile, renderFileDiff } = require('./renderers');
+const { searchContent } = require('./content-search');
 
 /**
  * Express server setup and route handlers
@@ -97,6 +99,70 @@ function setupRoutes(app, workingDir, isGitRepo, gitRepoRoot) {
     }
   });
 
+  // API endpoint for full-text content search
+  app.get('/api/search-content', (req, res) => {
+    try {
+      const query = req.query.q || '';
+      if (!query.trim()) {
+        return res.json({ success: true, results: [], total: 0, query: '' });
+      }
+
+      const regex = req.query.regex === 'true';
+      const caseSensitive = req.query.caseSensitive === 'true';
+      const maxResults = parseInt(req.query.maxResults || '1000', 10);
+      const fileTypes = req.query.fileTypes ? req.query.fileTypes.split(',') : null;
+
+      const result = searchContent(workingDir, query, {
+        regex,
+        caseSensitive,
+        maxResults,
+        fileTypes
+      });
+
+      res.json({ success: true, ...result });
+    } catch (error) {
+      res.status(400).json({ success: false, error: error.message });
+    }
+  });
+
+  // API endpoint for code symbols (functions, classes, etc.)
+  app.get('/api/symbols', (req, res) => {
+    try {
+      const filePath = req.query.path;
+      if (!filePath) {
+        return res.status(400).json({ success: false, error: 'Path is required' });
+      }
+
+      // Validate path is within working directory
+      const fullPath = path.resolve(path.join(workingDir, filePath));
+      if (!fullPath.startsWith(workingDir)) {
+        return res.status(403).json({ success: false, error: 'Access denied' });
+      }
+
+      // Check file exists
+      if (!fs.existsSync(fullPath) || fs.statSync(fullPath).isDirectory()) {
+        return res.status(404).json({ success: false, error: 'File not found' });
+      }
+
+      // Read file content
+      const content = fs.readFileSync(fullPath, 'utf8');
+      
+      // Parse symbols
+      const symbols = parseSymbols(content, filePath);
+      const grouped = groupSymbolsByKind(symbols);
+
+      res.json({ 
+        success: true, 
+        symbols, 
+        grouped,
+        total: symbols.length,
+        path: filePath
+      });
+    } catch (error) {
+      res.status(500).json({ success: false, error: error.message });
+    }
+  });
+
   // Download route
   app.get('/download', (req, res) => {
     const filePath = req.query.path || '';
@@ -202,13 +268,7 @@ function setupRoutes(app, workingDir, isGitRepo, gitRepoRoot) {
     }
   });
 
-  // Route for creating new files
-  app.get('/new', (req, res) => {
-    const currentPath = req.query.path || '';
-    res.send(renderNewFile(currentPath, workingDir));
-  });
-
-  // API endpoint to get file content for editing
+  // API endpoint to get raw file content (for copy raw feature)
   app.get('/api/file-content', (req, res) => {
     try {
       const currentPath = req.query.path || '';
@@ -219,9 +279,9 @@ function setupRoutes(app, workingDir, isGitRepo, gitRepoRoot) {
         return res.status(403).send('Access denied');
       }
       
-      // Check if it's a binary file - prevent editing
+      // Skip binary files
       if (isBinaryFile(fullPath)) {
-        return res.status(400).json({ error: 'Cannot edit binary files' });
+        return res.status(400).json({ error: 'Cannot read binary files as text' });
       }
       
       const content = fs.readFileSync(fullPath, 'utf-8');
@@ -237,189 +297,6 @@ function setupRoutes(app, workingDir, isGitRepo, gitRepoRoot) {
     }
   });
 
-  // API endpoint to save file changes
-  app.post('/api/save-file', express.json(), (req, res) => {
-    try {
-      const { path: filePath, content } = req.body;
-      const fullPath = path.join(workingDir, filePath || '');
-      
-      // Security check - ensure we're not accessing files outside the current directory
-      if (!fullPath.startsWith(workingDir)) {
-        return res.status(403).json({ success: false, error: 'Access denied' });
-      }
-      
-      fs.writeFileSync(fullPath, content, 'utf-8');
-      res.json({ success: true });
-    } catch (error) {
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // API endpoint to create new file
-  app.post('/api/create-file', express.json(), (req, res) => {
-    try {
-      const { path: dirPath, filename } = req.body;
-      const fullDirPath = path.join(workingDir, dirPath || '');
-      const fullFilePath = path.join(fullDirPath, filename);
-      
-      // Security checks
-      if (!fullDirPath.startsWith(workingDir) || !fullFilePath.startsWith(workingDir)) {
-        return res.status(403).json({ success: false, error: 'Access denied' });
-      }
-      
-      // Check if file already exists
-      if (fs.existsSync(fullFilePath)) {
-        return res.status(400).json({ success: false, error: 'File already exists' });
-      }
-      
-      // Create the file with empty content
-      fs.writeFileSync(fullFilePath, '', 'utf-8');
-      res.json({ success: true });
-    } catch (error) {
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // API endpoint to create new folder
-  app.post('/api/create-folder', express.json(), (req, res) => {
-    try {
-      const { path: dirPath, foldername } = req.body;
-      const fullDirPath = path.join(workingDir, dirPath || '');
-      const fullFolderPath = path.join(fullDirPath, foldername);
-      
-      // Security checks
-      if (!fullDirPath.startsWith(workingDir) || !fullFolderPath.startsWith(workingDir)) {
-        return res.status(403).json({ success: false, error: 'Access denied' });
-      }
-      
-      // Check if folder already exists
-      if (fs.existsSync(fullFolderPath)) {
-        return res.status(400).json({ success: false, error: 'Folder already exists' });
-      }
-      
-      // Create the folder
-      fs.mkdirSync(fullFolderPath);
-      res.json({ success: true });
-    } catch (error) {
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // API endpoint to delete file or folder
-  app.post('/api/delete', express.json(), (req, res) => {
-    try {
-      const { path: itemPath } = req.body;
-      const fullPath = path.join(workingDir, itemPath);
-      
-      // Security check
-      if (!fullPath.startsWith(workingDir)) {
-        return res.status(403).json({ success: false, error: 'Access denied' });
-      }
-      
-      // Check if item exists
-      if (!fs.existsSync(fullPath)) {
-        return res.status(404).json({ success: false, error: 'Item not found' });
-      }
-      
-      // Delete the item
-      const stats = fs.statSync(fullPath);
-      if (stats.isDirectory()) {
-        fs.rmSync(fullPath, { recursive: true, force: true });
-      } else {
-        fs.unlinkSync(fullPath);
-      }
-      
-      res.json({ success: true });
-    } catch (error) {
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // API endpoint to rename file or folder
-  app.post('/api/rename', express.json(), (req, res) => {
-    try {
-      const { path: oldPath, newName } = req.body;
-      const fullOldPath = path.join(workingDir, oldPath);
-      const dirPath = path.dirname(fullOldPath);
-      const fullNewPath = path.join(dirPath, newName);
-      
-      // Security checks
-      if (!fullOldPath.startsWith(workingDir) || !fullNewPath.startsWith(workingDir)) {
-        return res.status(403).json({ success: false, error: 'Access denied' });
-      }
-      
-      // Check if old item exists
-      if (!fs.existsSync(fullOldPath)) {
-        return res.status(404).json({ success: false, error: 'Item not found' });
-      }
-      
-      // Check if new name already exists
-      if (fs.existsSync(fullNewPath)) {
-        return res.status(400).json({ success: false, error: 'Name already exists' });
-      }
-      
-      // Rename the item
-      fs.renameSync(fullOldPath, fullNewPath);
-      res.json({ success: true });
-    } catch (error) {
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // Git commit all endpoint
-  app.post('/api/git-commit-all', express.json(), async (req, res) => {
-    try {
-      if (!isGitRepo) {
-        return res.status(404).json({ success: false, error: 'Not a git repository' });
-      }
-      
-      const { message } = req.body;
-      if (!message || !message.trim()) {
-        return res.status(400).json({ success: false, error: 'Commit message is required' });
-      }
-      
-      try {
-        const result = await commitAllChanges(gitRepoRoot, message);
-        res.json(result);
-      } catch (gitError) {
-        console.error('Git commit error:', gitError);
-        res.status(500).json({ success: false, error: gitError.message });
-      }
-    } catch (error) {
-      console.error('Commit endpoint error:', error);
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
-  // Git commit selected files endpoint
-  app.post('/api/git-commit-selected', express.json(), async (req, res) => {
-    try {
-      if (!isGitRepo) {
-        return res.status(404).json({ success: false, error: 'Not a git repository' });
-      }
-      
-      const { message, files } = req.body;
-      if (!message || !message.trim()) {
-        return res.status(400).json({ success: false, error: 'Commit message is required' });
-      }
-      
-      if (!files || files.length === 0) {
-        return res.status(400).json({ success: false, error: 'No files selected' });
-      }
-      
-      try {
-        const result = await commitSelectedFiles(gitRepoRoot, message, files);
-        res.json(result);
-      } catch (gitError) {
-        console.error('Git commit error:', gitError);
-        res.status(500).json({ success: false, error: gitError.message });
-      }
-    } catch (error) {
-      console.error('Commit selected endpoint error:', error);
-      res.status(500).json({ success: false, error: error.message });
-    }
-  });
-
   // Get git changes endpoint (with directory filtering)
   app.get('/api/git-status', async (req, res) => {
     try {