gg.easy.airship 0.1.2141 → 0.1.2144

package/Editor/LuauPluginUpdateCheck.cs

@@ -57,7 +57,7 @@ public static class LuauPluginUpdateCheck {
         if (lastHash != "") {
             // Check if user wants to restart
             var acceptsRestart = EditorUtility.DisplayDialog("Luau Plugin Updated",
-                "The Luau plugin has updated. Restart Unity to apply changes.", "Quit", "Cancel");
+                "The Luau plugin has updated. Restart Unity to apply changes. We're sorry for this..", "Quit", "Cancel");
             if (acceptsRestart) {
                 // Verify any unsaved changes are saved
                 var confirmedSaveState = EditorSceneManager.SaveCurrentModifiedScenesIfUserWantsTo();

package/Editor/TypescriptServices/Editor/TypescriptLogService.cs

@@ -75,8 +75,7 @@ namespace Airship.Editor {
                     }
                 }
                 
-                
-                await Task.Delay(1); // tune as needed
+                await Task.Delay(100); // tune as needed
             }
         }
 

package/Runtime/Code/AirshipConst.cs

@@ -1,11 +1,11 @@
 // ReSharper disable InconsistentNaming
 namespace Code {
     public static class AirshipConst {
-        public const int playerVersion = 8;
+        public const int playerVersion = 9;
 
         /// <summary>
         /// The server will kick clients that have a playerVersion lower than this value.
         /// </summary>
-        public const int minAcceptedPlayerVersionOnServer = 8;
+        public const int minAcceptedPlayerVersionOnServer = 9;
     }
 }

package/Runtime/Code/Authentication/EasyAuthenticator.cs

@@ -205,14 +205,14 @@ namespace Code.Authentication {
                 }
 
             })).Then((res) => {
-                // print($"[Transfer Packet] userIdToken: {userIdToken}, packet response: " + res.Text);
+                // print($"[Transfer Packet] {res.Text}");
                 string fullTransferPacket = res.Text;
                 TransferData transferData = JsonUtility.FromJson<TransferData>(fullTransferPacket);
                 tcs.SetResult(new UserData() {
                     uid = transferData.user.uid,
                     username = transferData.user.username,
                     profileImageId = transferData.user.profileImageId,
-                    orgRoleName = transferData.user.orgRoleName,
+                    orgRoleName = transferData.orgRoleName,
                     fullTransferPacket = fullTransferPacket
                 });
             }).Catch((err) => {

package/Runtime/Code/Authentication/TransferData.cs

@@ -12,11 +12,11 @@ public class User {
     public string usernameLower;
     public string lastUsernameChangeTime;
     public string profileImageId;
-    public string orgRoleName;
 }
 
 
 [Serializable]
 public class TransferData {
     public User user;
+    public string orgRoleName;
 }

package/Runtime/Code/Bootstrap/LuauScriptsDtoSerializer.cs

@@ -1,14 +1,36 @@
 using System;
+using System.Buffers;
 using System.Collections.Generic;
 using System.IO;
 using System.IO.Compression;
 using Mirror;
 using UnityEngine;
+using UnityEngine.Profiling;
 
 namespace Code.Bootstrap {
+
+    class CachedCompressedFile {
+        public byte[] compressedBytes;
+        public int compressedLength;
+
+        public CachedCompressedFile(byte[] compressedBytes, int compressedLength) {
+            this.compressedBytes = compressedBytes;
+            this.compressedLength = compressedLength;
+        }
+    }
+    
     public static class LuauScriptsDtoSerializer {
+        private static Zstd.Zstd zstd = new(1024 * 4);
+        private static readonly Dictionary<string, CachedCompressedFile> compressedFileCache = new();
+
+        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)]
+        private static void OnReload() {
+            compressedFileCache.Clear();
+        }
+        
         public static void WriteLuauScriptsDto(this NetworkWriter writer, LuauScriptsDto scripts) {
-            writer.WriteInt(scripts.files.Count);;
+            Profiler.BeginSample("WriteLuauScriptsDto");
+            writer.WriteInt(scripts.files.Count);
             foreach (var pair in scripts.files) {
                 string packageId = pair.Key;
                 writer.WriteString(packageId);
@@ -16,22 +38,30 @@ namespace Code.Bootstrap {
                 foreach (var file in pair.Value) {
                     writer.WriteString(file.path);
 
-                    // Compress the byte array
-                    byte[] compressedBytes;
-                    using (MemoryStream ms = new MemoryStream()) {
-                        using (DeflateStream deflateStream = new DeflateStream(ms, CompressionMode.Compress)) {
-                            deflateStream.Write(file.bytes, 0, file.bytes.Length);
-                        }
-                        compressedBytes = ms.ToArray();
+                    string cacheId = $"{packageId}:{file.path}";
+                    if (compressedFileCache.TryGetValue(cacheId, out var cache)) {
+                        writer.WriteInt(cache.compressedLength);
+                        writer.WriteBytes(cache.compressedBytes, 0, cache.compressedLength);
+                    } else {
+                        // Compress the byte array
+                        Profiler.BeginSample("Luau Compress");
+                        var maxCompressionSize = Zstd.Zstd.GetCompressionBound(file.bytes);
+                        byte[] compressedBytes = new byte[maxCompressionSize];
+                        var compressedSize = zstd.Compress(file.bytes, compressedBytes);
+                        writer.WriteInt(compressedSize);
+                        writer.WriteBytes(compressedBytes, 0, compressedSize);
+                        
+                        compressedFileCache.Add(cacheId, new CachedCompressedFile(compressedBytes, compressedSize));
                     }
-                    writer.WriteArray(compressedBytes);
+                    
                     writer.WriteBool(file.airshipBehaviour);
+                    Profiler.EndSample();
                 }
             }
+            Profiler.EndSample();
         }
 
         public static LuauScriptsDto ReadLuauScriptsDto(this NetworkReader reader) {
-            var totalBytes = reader.Remaining;
             LuauScriptsDto dto = new LuauScriptsDto();
             int packagesLength = reader.ReadInt();
             for (int pkgI = 0; pkgI < packagesLength; pkgI++) {
@@ -44,15 +74,14 @@ namespace Code.Bootstrap {
                     LuauFileDto script = new LuauFileDto();
                     script.path = reader.ReadString();
 
-                    var byteArray = reader.ReadArray<byte>();
-                    using (MemoryStream compressedStream = new MemoryStream(byteArray)) {
-                        using (DeflateStream deflateStream = new DeflateStream(compressedStream, CompressionMode.Decompress)) {
-                            using (MemoryStream outputStream = new MemoryStream()) {
-                                deflateStream.CopyTo(outputStream);
-                                script.bytes = outputStream.ToArray();
-                            }
-                        }
-                    }
+                    // Read the compressed bytes
+                    var compressedBytesLen = reader.ReadInt();
+                    byte[] compressedBytes = ArrayPool<byte>.Shared.Rent(compressedBytesLen);
+                    reader.ReadBytes(compressedBytes, compressedBytesLen);
+
+                    // Decompress the bytes
+                    script.bytes = new byte[Zstd.Zstd.GetDecompressionBound(compressedBytes)];
+                    zstd.Decompress(new ReadOnlySpan<byte>(compressedBytes, 0, compressedBytesLen), script.bytes);
 
                     script.airshipBehaviour = reader.ReadBool();
 

package/Runtime/Code/Bundles/SystemRoot.cs

@@ -267,20 +267,24 @@ public class SystemRoot : Singleton<SystemRoot> {
 		this.networkCollectionIdCounter = 1;
 
 		// sort packages by load order
-		List<List<IEnumerator>> loadLists = new(3);
+		List<List<IEnumerator>> loadLists = new(2);
 		for (int i = 0; i < loadLists.Capacity; i++) {
 			loadLists.Add(new());
 		}
 
 		List<IEnumerator> GetLoadList(AirshipPackage package) {
-			return loadLists[0];
-			// if (package.id == "@Easy/CoreMaterials") {
+			// // Load core first because packages may depend them
+			// if (package.id == "@Easy/CoreMaterials" || package.id == "@Easy/Core") {
 			// 	return loadLists[0];
 			// }
-			// if (package.id == "@Easy/Core") {
-			// 	return loadLists[1];
-			// }
-			// return loadLists[2];
+
+			// All packages first
+			if (package.packageType == AirshipPackageType.Package) {
+				return loadLists[0];
+			}
+
+			// Games go last
+			return loadLists[1];
 		}
 
 		// Find packages to load
@@ -334,7 +338,10 @@ public class SystemRoot : Singleton<SystemRoot> {
 			}
 #endif
 
+			Debug.Log("Loading packages...");
 			yield return this.WaitAll(loadLists[0].ToArray());
+			Debug.Log("Loading game...");
+			yield return this.WaitAll(loadLists[1].ToArray());
 			
 			foreach (var ao in this.extraBundleLoadRequests) {
 				if (!ao.isDone) {

package/Runtime/Code/Easy.Airship.asmdef

@@ -52,7 +52,8 @@
         "GUID:325984b52e4128546bc7558552f8b1d2",
         "GUID:3b5390adca4e2bb4791cb930316d6f3e",
         "GUID:725ee7191c021de4dbf9269590ded755",
-        "GUID:2a0340569ab0e1245a38e0d6c7b2529b"
+        "GUID:2a0340569ab0e1245a38e0d6c7b2529b",
+        "GUID:befe48b9a36afc04ea625c93daad910e"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],

package/Runtime/Code/Health/AirshipProfileExporter.cs

@@ -1,11 +1,10 @@
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Threading.Tasks;
 using Airship.DevConsole;
 using Code.Http.Internal;
 using Code.Platform.Shared;
-using Code.UI;
+using Code.Player;
 using JetBrains.Annotations;
 using Mirror;
 using UnityEngine;
@@ -56,6 +55,7 @@ namespace Code.Health
     
     public struct StartServerProfileMessage : NetworkMessage {
         public int DurationSecs;
+        public bool CallstacksEnabled;
     }
 
     public struct ServerProfileCompleteMessage : NetworkMessage
@@ -88,13 +88,14 @@ namespace Code.Health
                 NetworkClient.RegisterHandler<ClientProfileUploadResponse>(OnClientUploadResponse);
             }
 
-            DevConsole.AddCommand(Command.Create<string, int>(
+            DevConsole.AddCommand(Command.Create<string, int, bool>(
                 "profile", 
                 "",
                 "Starts and uploads a profile. Once complete the download link will be printed.", 
                     Parameter.Create("Context", "Options: Server | Client"),
                 Parameter.Create("Duration", "Duration of profile in seconds (max 5s)"),
-                (context, d) => {
+                Parameter.Create("Callstacks", "Enable callstacks for profile (this is laggy)"), 
+                (context, d, callstacks) => {
                     if (d is < 0 or > 5) {
                         Debug.LogError("You can only profile for a max of 5s.");
                         return;
@@ -106,10 +107,10 @@ namespace Code.Health
                                 "Unable to capture profile log because debug mode is not enabled. Use the development build branch on Steam to enable debug mode.");
                             return;
                         }
-                        StartProfiling(d, null);
+                        StartProfiling(d, null, callstacks);
                     } else if (context.Equals("server", StringComparison.OrdinalIgnoreCase)) {
                         Debug.Log("Starting a server profile, view server console to monitor progress.");
-                        NetworkClient.Send(new StartServerProfileMessage { DurationSecs = d });
+                        NetworkClient.Send(new StartServerProfileMessage { DurationSecs = d, CallstacksEnabled = callstacks });
                     }
                 }));
         }
@@ -142,8 +143,10 @@ namespace Code.Health
         }
 
         public void OnStartProfilingMessage(NetworkConnectionToClient sender, StartServerProfileMessage msg) {
-            // TODO Validate sender is dev
-            StartProfiling(msg.DurationSecs, sender);
+            var player = PlayerManagerBridge.Instance.GetPlayerInfoByConnectionId(sender.connectionId);
+            if (player.IsInGameOrg()) {
+                StartProfiling(msg.DurationSecs, sender, msg.CallstacksEnabled);
+            }
         }
 
         public async void OnServerProfileCompleteMessage(ServerProfileCompleteMessage msg)
@@ -163,7 +166,7 @@ namespace Code.Health
             GUIUtility.systemCopyBuffer = data.url;
         }
 
-        public void StartProfiling(int durationSecs, [CanBeNull] NetworkConnectionToClient profileInitiator) {
+        public void StartProfiling(int durationSecs, [CanBeNull] NetworkConnectionToClient profileInitiator, bool enableCallstacks) {
             // TODO check that sender is game dev
             // if (Profiler.enabled) {
             //     Debug.LogWarning("Profiler is already running.");
@@ -183,12 +186,14 @@ namespace Code.Health
             
             Debug.Log($"Starting profiler for {durationSecs} seconds.");
             Profiler.enabled = true;
+            Profiler.enableAllocationCallstacks = enableCallstacks;
             StopProfilingAfterDelay(logPath, fileName, durationSecs, profileInitiator);
         }
 
         private async void StopProfilingAfterDelay(string logPath, string fileName, float durationSecs, [CanBeNull] NetworkConnectionToClient profileInitiator) {
             await Task.Delay((int)(durationSecs * 1000));
             Profiler.enabled = false;
+            Profiler.enableAllocationCallstacks = false;
             var info = new FileInfo(logPath);
 
             Debug.Log($"Profiling completed. Retrieving upload URL...");

package/Runtime/Code/Luau/LuauCore.cs

@@ -173,8 +173,8 @@ public partial class LuauCore : MonoBehaviour {
                 requirePathCallback = requirePathCallback_holder,
                 constructorCallback = constructorCallback_holder,
                 toStringCallback = toStringCallback_holder,
-                toggleProfilerCallback = toggleProfilerCallback_holder,
                 isObjectDestroyedCallback = isObjectDestroyedCallback_holder,
+                getUnityObjectNameCallback = getUnityObjectNameCallback_holder,
                 staticList = stringAddresses.AddrOfPinnedObject(),
                 staticCount = stringCount,
                 isServer = RunCore.IsServer() ? 1 : 0,

package/Runtime/Code/Luau/LuauCoreCallbacks.cs

@@ -41,8 +41,8 @@ public partial class LuauCore : MonoBehaviour {
     private LuauPlugin.ConstructorCallback constructorCallback_holder;
     private LuauPlugin.RequirePathCallback requirePathCallback_holder;
     private LuauPlugin.ToStringCallback toStringCallback_holder;
-    private LuauPlugin.ToggleProfilerCallback toggleProfilerCallback_holder;
     private LuauPlugin.IsObjectDestroyedCallback isObjectDestroyedCallback_holder;
+    private LuauPlugin.GetUnityObjectName getUnityObjectNameCallback_holder;
     
 
     private struct AwaitingTask {
@@ -116,8 +116,8 @@ public partial class LuauCore : MonoBehaviour {
         requirePathCallback_holder = RequirePathCallback;
         toStringCallback_holder = ToStringCallback;
         componentSetEnabledCallback_holder = SetComponentEnabledCallback;
-        toggleProfilerCallback_holder = ToggleProfilerCallback;
         isObjectDestroyedCallback_holder = IsObjectDestroyedCallback;
+        getUnityObjectNameCallback_holder = GetUnityObjectNameCallback;
     }
 
     private static int LuauError(IntPtr thread, string err) {
@@ -190,41 +190,27 @@ public partial class LuauCore : MonoBehaviour {
 
         Marshal.Copy(bytes, 0, str, len);
     }
-    
-    [AOT.MonoPInvokeCallback(typeof(LuauPlugin.ToggleProfilerCallback))]
-    static void ToggleProfilerCallback(int componentId, IntPtr strPtr, int strLen) {
-        // Disable
-        if (componentId == -1) {
-            Profiler.EndSample();
-            return;
-        }
-        // Not tagged to component
-        if (componentId < -1) {
-            if (strLen > 0) {
-                // No need to free strPtr -- it is stack allocated
-                var str = PtrToStringUTF8(strPtr, strLen);
-                Profiler.BeginSample($"{str}");
-                return;
-            }
-        }
-        
-
-        if (AirshipComponent.ComponentIdToScriptName.TryGetValue(componentId, out var componentName)) {
-            if (strLen > 0) {
-                var str = PtrToStringUTF8(strPtr, strLen);
-                Profiler.BeginSample($"{componentName}{str}");
-            }
-            else {
-                Profiler.BeginSample($"{componentName}");
-            }
-        }
-    }
 
     [AOT.MonoPInvokeCallback(typeof(LuauPlugin.IsObjectDestroyedCallback))]
     static int IsObjectDestroyedCallback(int instanceId) {
         return ThreadDataManager.IsUnityObjectReferenceDestroyed(instanceId) ? 1 : 0;
     }
 
+    [AOT.MonoPInvokeCallback(typeof(LuauPlugin.GetUnityObjectName))]
+    static void GetUnityObjectNameCallback(IntPtr thread, int instanceId, IntPtr str, int maxLen, out int len) {
+        var obj = ThreadDataManager.GetObjectReference(thread, instanceId, true, true);
+        if (obj is UnityEngine.Object unityObj) {
+            var n = unityObj.name;
+            var bytes = Encoding.UTF8.GetBytes(n);
+            len = bytes.Length > maxLen ? maxLen : bytes.Length;
+            Marshal.Copy(bytes, 0, str, len);
+            
+            return;
+        }
+
+        len = 0;
+    }
+
     //when a lua thread gc releases an object, make sure our GC knows too
     [AOT.MonoPInvokeCallback(typeof(LuauPlugin.ObjectGCCallback))]
     static unsafe int ObjectGcCallback(int instanceId, IntPtr objectDebugPointer) {
@@ -713,16 +699,22 @@ public partial class LuauCore : MonoBehaviour {
     private static int GetPropertySafeCallback(LuauContext context, IntPtr thread, int instanceId, IntPtr classNamePtr, int classNameSize, IntPtr propertyName, int propertyNameLength) {
         var ret = 0;
         try {
-            ret = GetProperty(context, thread, instanceId, classNamePtr, classNameSize, propertyName, propertyNameLength);
-        } catch (Exception e) {
+            Profiler.BeginSample("GetProperty");
+            ret = GetProperty(context, thread, instanceId, classNamePtr, classNameSize, propertyName,
+                propertyNameLength);
+        }
+        catch (Exception e) {
             ret = LuauError(thread, e.Message);
+        } finally {
+            Profiler.EndSample();
         }
 
         return ret;
     }
 
+    // private static readonly ProfilerMarker<string> getPropertyMarker = new ProfilerMarker<string>("LuauCore.GetProperty", "asd");
+
     private static int GetProperty(LuauContext context, IntPtr thread, int instanceId, IntPtr classNamePtr, int classNameSize, IntPtr propertyName, int propertyNameLength) {
-        Profiler.BeginSample("LuauCore.GetProperty");
         CurrentContext = context;
 
         string propName = LuauCore.PtrToStringUTF8(propertyName, propertyNameLength, out ulong propNameHash);
@@ -756,14 +748,12 @@ public partial class LuauCore : MonoBehaviour {
                 // Type t = propertyInfo.PropertyType;
                 System.Object value = cacheData.Value.propertyInfo.GetValue(null);
                 WritePropertyToThread(thread, value, cacheData.Value.t);
-                Profiler.EndSample();
                 return 1;
             }
 
             // Get C# event:
             var eventInfo = objectType.GetRuntimeEvent(propName);
             if (eventInfo != null) {
-                Profiler.EndSample();
                 return LuauSignalWrapper.HandleCsEvent(context, thread, staticClassApi, instanceId, propNameHash,
                     eventInfo, true);
             }
@@ -774,11 +764,9 @@ public partial class LuauCore : MonoBehaviour {
                 Type t = fieldInfo.FieldType;
                 System.Object value = fieldInfo.GetValue(null);
                 WritePropertyToThread(thread, value, t);
-                Profiler.EndSample();
                 return 1;
             }
 
-            Profiler.EndSample();
             return LuauError(thread, "ERROR - " + propName + " get property not found on class " + staticClassName);
         }
         else {
@@ -788,7 +776,6 @@ public partial class LuauCore : MonoBehaviour {
             System.Object objectReference = ThreadDataManager.GetObjectReference(thread, instanceId);
             // Profiler.EndSample();
             if (objectReference == null) {
-                Profiler.EndSample();
                 return LuauError(thread,
                     "Error: InstanceId not currently available:" + instanceId + ". propName=" + propName);
             }
@@ -801,7 +788,6 @@ public partial class LuauCore : MonoBehaviour {
                 if (objectReference is GameObject targetGo) {
                     // var target = (GameObject)objectReference;
                     if (IsAccessBlocked(context, targetGo)) {
-                        Profiler.EndSample();
                         return LuauError(thread,
                             "[Airship] Access denied when trying to read " + targetGo.name + ".");
                     }
@@ -809,7 +795,6 @@ public partial class LuauCore : MonoBehaviour {
                 else if (sourceType.IsAssignableFrom(typeof(Component))) {
                     var target = (Component)objectReference;
                     if (target && IsAccessBlocked(context, target.gameObject)) {
-                        Profiler.EndSample();
                         return LuauError(thread,
                             "[Airship] Access denied when trying to read " + target.name + ".");
                     }
@@ -821,7 +806,6 @@ public partial class LuauCore : MonoBehaviour {
             if (valueTypeAPI != null) {
                 var retValue = valueTypeAPI.OverrideMemberGetter(context, thread, objectReference, propName);
                 if (retValue >= 0) {
-                    Profiler.EndSample();
                     return retValue;
                 }
             }
@@ -841,7 +825,6 @@ public partial class LuauCore : MonoBehaviour {
                 try {
                     // Try a fast write on value type (Vector3, int, etc. Not objects)
                     if (FastGetAndWriteValueProperty(thread, objectReference, cacheData.Value)) {
-                        Profiler.EndSample();
                         return 1;
                     }
 
@@ -876,16 +859,11 @@ public partial class LuauCore : MonoBehaviour {
                             }
                         }
 
-                        // Profiler.BeginSample("WriteToThread");
                         WritePropertyToThread(thread, value, t);
-                        // Profiler.EndSample();
-                        Profiler.EndSample();
                         return 1;
                     }
                     else {
-                        // Debug.Log("Value was null in dictionary. propName=" + propName + ", object=" + sourceType.Name);
                         WritePropertyToThread(thread, null, null);
-                        Profiler.EndSample();
                         return 1;
                     }
                 }
@@ -902,11 +880,8 @@ public partial class LuauCore : MonoBehaviour {
                     // If we failed to get a reference to a non-primitive, just assume a null value (write nil to the stack):
                     if (!cacheData.Value.propertyInfo.PropertyType.IsPrimitive) {
                         WritePropertyToThread(thread, null, null);
-                        Profiler.EndSample();
                         return 1;
                     }
-
-                    Profiler.EndSample();
                     return LuauError(thread, "Failed to get property in dictionary. propName=" + propName +
                                              ", object=" +
                                              sourceType.Name + ", msg=" + e.Message);
@@ -936,7 +911,6 @@ public partial class LuauCore : MonoBehaviour {
                     // print("key: " + propName + " " + keyInt);
                     // Debug.Log("[Luau]: Dictionary had key but value was null. propName=" + propName + ", sourceType=" + sourceType.Name + ", obj=" + objectReference);
                     WritePropertyToThread(thread, null, null);
-                    Profiler.EndSample();
                     return 1;
                 }
 
@@ -944,14 +918,12 @@ public partial class LuauCore : MonoBehaviour {
                     object value = dict[propName];
                     Type t = value.GetType();
                     WritePropertyToThread(thread, value, t);
-                    Profiler.EndSample();
                     return 1;
                 }
                 else {
                     // Debug.Log("[Luau]: Dictionary was found but key was not found. propName=" + propName +
                     //           ", sourceType=" + sourceType.Name);
                     WritePropertyToThread(thread, null, null);
-                    Profiler.EndSample();
                     return 1;
                 }
             }
@@ -959,7 +931,6 @@ public partial class LuauCore : MonoBehaviour {
             // Get C# event:
             var eventInfo = sourceType.GetRuntimeEvent(propName);
             if (eventInfo != null) {
-                Profiler.EndSample();
                 return LuauSignalWrapper.HandleCsEvent(context, thread, objectReference, instanceId, propNameHash,
                     eventInfo, false);
             }
@@ -970,11 +941,9 @@ public partial class LuauCore : MonoBehaviour {
                 Type t = field.FieldType;
                 System.Object value = field.GetValue(objectReference);
                 WritePropertyToThread(thread, value, t);
-                Profiler.EndSample();
                 return 1;
             }
 
-            Profiler.EndSample();
             return LuauError(thread, $"ERROR - ({sourceType.Name}).{propName} property/field not found");
         }
     }

package/Runtime/Code/Luau/LuauCoreReflection.cs

@@ -483,6 +483,13 @@ public partial class LuauCore : MonoBehaviour
             return true;
         }
         
+        if (t == byteType) {
+            byte byteVal = (byte)value;
+            System.Int32 integer = byteVal;
+            LuauPlugin.LuauPushValueToThread(thread, (int)PODTYPE.POD_INT32, new IntPtr(value: &integer), 0); // 0, because we know how big an intPtr is
+            return true;
+        }
+        
         if (t == longType) {
             Int64 intVal = (Int64)value;
             System.Int32 integer = unchecked((int)intVal);

package/Runtime/Code/Luau/LuauPlugin.cs

@@ -22,8 +22,8 @@ public static class LuauPlugin {
 	public delegate void RequirePathCallback(LuauContext context, IntPtr thread, IntPtr scriptName, int scriptNameLen, IntPtr fileName, int fileNameLen);
 	public delegate void ToStringCallback(IntPtr thread, int instanceId, IntPtr str, int maxLen, out int len);
 	public delegate void ComponentSetEnabledCallback(IntPtr thread, int instanceId, int componentId, int enabled);
-	public delegate void ToggleProfilerCallback(int componentId, IntPtr str, int strLen);
 	public delegate int IsObjectDestroyedCallback(int instanceId);
+	public delegate void GetUnityObjectName(IntPtr thread, int instanceId, IntPtr str, int maxLen, out int len); 
 
 	public static int unityMainThreadId = -1;
 	public static bool s_currentlyExecuting = false;
@@ -62,8 +62,8 @@ public static class LuauPlugin {
 		public RequirePathCallback requirePathCallback;
 		public ConstructorCallback constructorCallback;
 		public ToStringCallback toStringCallback;
-		public ToggleProfilerCallback toggleProfilerCallback;
 		public IsObjectDestroyedCallback isObjectDestroyedCallback;
+		public GetUnityObjectName getUnityObjectNameCallback;
 		
 		public IntPtr staticList;
 		public int staticCount;

package/Runtime/Code/Network/ServerConsole.cs

@@ -35,7 +35,9 @@ namespace Code.RemoteConsole {
         private Task writeTask;
 
         private void Awake() {
-            writeTask = Task.Run(ProcessQueue);
+            if (RunCore.IsClient() && !RunCore.IsServer()) {
+                writeTask = Task.Run(ProcessQueue);
+            }
         }
 
         private async Task ProcessQueue() {
@@ -48,7 +50,7 @@ namespace Code.RemoteConsole {
                     }
                 }
 
-                await Task.Delay(1); // tune as needed
+                await Task.Delay(100); // tune as needed
             }
         }
 
@@ -74,8 +76,11 @@ namespace Code.RemoteConsole {
                 Application.logMessageReceived += LogCallback;
             }
             NetworkServer.RegisterHandler<RequestServerConsoleStartupLogs>((conn, data) => {
-                foreach (var startupMessage in startupMessages) {
-                    conn.Send(startupMessage);
+                var player = PlayerManagerBridge.Instance.GetPlayerInfoByConnectionId(conn.connectionId);
+                if (player.IsInGameOrg()) {
+                    foreach (var startupMessage in startupMessages) {
+                        conn.Send(startupMessage);
+                    }   
                 }
             }, false);
         }
@@ -127,7 +132,10 @@ namespace Code.RemoteConsole {
         }
 
         private void SendServerLogMessage(string message, LogType logType = LogType.Log, string stackTrace = "") {
-            if (RunCore.IsServer() && !RunCore.IsEditor()) {
+            if (RunCore.IsEditor()) {
+                return;
+            }
+            if (RunCore.IsServer()) {
                 var time = DateTime.Now.ToString("HH:mm:ss");
                 if (this.startupMessages.Count < maxStartupMessages) {
                     this.startupMessages.Add(new ServerConsoleBroadcast() {
@@ -147,10 +155,9 @@ namespace Code.RemoteConsole {
                         stackTrace = stackTrace,
                         time = time,
                     };
-                    // bool sendToReadyOnly = Application.isEditor;
                     foreach (var player in PlayerManagerBridge.Instance.players) {
-                        if (!string.IsNullOrEmpty(player.orgRoleName)) {
-                            player.connectionToClient.Send(packet, Channels.Reliable);
+                        if (player.IsInGameOrg()) {
+                            player.connectionToClient.Send(packet);
                         }
                     }
                 }