getgloss 0.8.3 → 0.8.4

package/dist/server/daemon.js

@@ -1,5 +1,4 @@
 // src/server/daemon.ts
-import { rm as rm3 } from "fs/promises";
 import { serve } from "@hono/node-server";
 
 // src/shared/paths.ts
@@ -10,7 +9,7 @@ import path from "path";
 // package.json
 var package_default = {
   name: "getgloss",
-  version: "0.8.3",
+  version: "0.8.4",
   description: "Local browser-based diff review for coding-agent loops.",
   type: "module",
   packageManager: "pnpm@10.33.2",
@@ -153,7 +152,9 @@ async function ensureDir(dir) {
 }
 
 // src/shared/server-info.ts
-import { readFile } from "fs/promises";
+import { randomUUID as randomUUID2 } from "crypto";
+import { readFile, rm as rm2, writeFile as writeFile2 } from "fs/promises";
+import path3 from "path";
 
 // src/shared/errors.ts
 function formatError(error) {
@@ -162,6 +163,9 @@ function formatError(error) {
 function isFileNotFound(error) {
   return error instanceof Error && "code" in error && error.code === "ENOENT";
 }
+function isPermissionError(error) {
+  return error instanceof Error && "code" in error && (error.code === "EACCES" || error.code === "EPERM");
+}
 
 // src/shared/json.ts
 import { randomUUID } from "crypto";
@@ -357,6 +361,9 @@ async function readServerInfo() {
     if (isFileNotFound(error)) {
       return null;
     }
+    if (isPermissionError(error)) {
+      throw new Error(serverInfoPermissionMessage("read", error), { cause: error });
+    }
     throw new Error(`Could not read server info at ${globalServerFile()}: ${formatError(error)}`, {
       cause: error
     });
@@ -370,13 +377,70 @@ async function readServerInfo() {
   }
 }
 async function writeServerInfo(info) {
-  await ensureDir(globalStateDir());
-  await writeJsonFile(globalServerFile(), info);
+  try {
+    await ensureDir(globalStateDir());
+  } catch (error) {
+    if (isPermissionError(error)) {
+      throw new Error(serverInfoPermissionMessage("create", error), { cause: error });
+    }
+    throw error;
+  }
+  try {
+    await writeJsonFile(globalServerFile(), info);
+  } catch (error) {
+    if (!isPermissionError(error)) {
+      throw error;
+    }
+    await assertStateDirWritable();
+    try {
+      await writeFile2(globalServerFile(), serializeServerInfo(info));
+    } catch (directWriteError) {
+      throw new Error(serverInfoPermissionMessage("write", directWriteError), {
+        cause: directWriteError
+      });
+    }
+  }
+}
+async function removeServerInfoFile() {
+  try {
+    await rm2(globalServerFile(), { force: true });
+    return null;
+  } catch (error) {
+    return serverInfoPermissionMessage("remove", error);
+  }
+}
+function serverInfoPermissionMessage(action, error) {
+  const stateDir = globalStateDir();
+  const source = process.env.GLOSS_STATE_DIR ? `GLOSS_STATE_DIR=${stateDir}` : "GLOSS_STATE_DIR is not set; defaulting to ~/.gloss";
+  return [
+    `Could not ${action} Gloss server state at ${globalServerFile()}: ${formatError(error)}.`,
+    "`server.json` is not a review lock, so there is nothing to unlock after a review.",
+    `Check that ${stateDir} and ${globalServerFile()} are owned and writable by your user.`,
+    `On macOS, if the file is immutable, run \`chflags nouchg "${globalServerFile()}"\`.`,
+    `For sandboxed agents, set GLOSS_STATE_DIR to a writable directory. ${source}.`
+  ].join(" ");
+}
+function serializeServerInfo(info) {
+  return `${JSON.stringify(info, null, 2)}
+`;
+}
+async function assertStateDirWritable() {
+  const probePath = path3.join(
+    globalStateDir(),
+    `.server.json.${process.pid}.${randomUUID2()}.probe`
+  );
+  try {
+    await writeFile2(probePath, "");
+    await rm2(probePath, { force: true });
+  } catch (error) {
+    await rm2(probePath, { force: true }).catch(() => void 0);
+    throw new Error(serverInfoPermissionMessage("write", error), { cause: error });
+  }
 }
 
 // src/server/index.ts
 import { readFile as readFile4, realpath, stat } from "fs/promises";
-import path5 from "path";
+import path6 from "path";
 import { fileURLToPath } from "url";
 import { Hono } from "hono";
 import { streamSSE } from "hono/streaming";
@@ -412,7 +476,7 @@ function resolutionCounts(feedback, resolvedComments = []) {
 import { execa } from "execa";
 
 // src/shared/language.ts
-import path3 from "path";
+import path4 from "path";
 var languageByExtension = {
   cjs: "js",
   css: "css",
@@ -434,7 +498,7 @@ var languageByExtension = {
   yml: "yaml"
 };
 function languageForPath(filePath) {
-  const ext = path3.extname(filePath).slice(1).toLowerCase();
+  const ext = path4.extname(filePath).slice(1).toLowerCase();
   if (!ext) {
     return null;
   }
@@ -611,11 +675,11 @@ async function openLocalPath(filePath) {
 // src/server/store.ts
 import { createHash } from "crypto";
 import { readdir as readdir2, readFile as readFile3 } from "fs/promises";
-import path4 from "path";
+import path5 from "path";
 import { ulid } from "ulid";
 
 // src/shared/cleanup.ts
-import { readdir, readFile as readFile2, rm as rm2 } from "fs/promises";
+import { readdir, readFile as readFile2, rm as rm3 } from "fs/promises";
 var DEFAULT_REVIEW_RETENTION_DAYS = 30;
 var clearableStatuses = /* @__PURE__ */ new Set(["submitted", "resolved", "cancelled"]);
 var millisecondsPerDay = 24 * 60 * 60 * 1e3;
@@ -659,7 +723,7 @@ async function clearReviewArtifacts(options = {}) {
     }
     candidates.push(candidate);
     if (!dryRun) {
-      await rm2(artifactDir, { recursive: true, force: true });
+      await rm3(artifactDir, { recursive: true, force: true });
       deleted.push(candidate);
     }
   }
@@ -1566,9 +1630,9 @@ function reconcileTurn(meta, diff, feedback, resolution) {
     status,
     submittedAt: feedback?.timestamp ?? meta.submittedAt,
     resolvedAt: status === "resolved" ? resolution?.resolvedAt ?? meta.resolvedAt : void 0,
-    feedbackPath: feedback ? meta.feedbackPath ?? path4.join(meta.artifactDir, "feedback.json") : void 0,
-    markdownPath: feedback ? meta.markdownPath ?? path4.join(meta.artifactDir, "feedback.md") : void 0,
-    resolvedPath: resolution ? meta.resolvedPath ?? path4.join(meta.artifactDir, "resolved.json") : void 0,
+    feedbackPath: feedback ? meta.feedbackPath ?? path5.join(meta.artifactDir, "feedback.json") : void 0,
+    markdownPath: feedback ? meta.markdownPath ?? path5.join(meta.artifactDir, "feedback.md") : void 0,
+    resolvedPath: resolution ? meta.resolvedPath ?? path5.join(meta.artifactDir, "resolved.json") : void 0,
     diff,
     ...feedback ? { feedback } : {},
     ...resolution ? { resolution } : {}
@@ -1863,11 +1927,11 @@ function createApp(origin2, options = {}) {
       return parsed.response;
     }
     const { filePath, turnId } = parsed.body;
-    if (!filePath || filePath.includes("\0") || path5.isAbsolute(filePath)) {
+    if (!filePath || filePath.includes("\0") || path6.isAbsolute(filePath)) {
       return c.json({ error: "filePath must be a repo-relative path" }, 400);
     }
-    const repoRoot = path5.resolve(existing.diff.cwd);
-    const requestedAbsolutePath = path5.resolve(repoRoot, filePath);
+    const repoRoot = path6.resolve(existing.diff.cwd);
+    const requestedAbsolutePath = path6.resolve(repoRoot, filePath);
     if (!isPathWithin(repoRoot, requestedAbsolutePath)) {
       return c.json({ error: "filePath must stay within the review cwd" }, 400);
     }
@@ -1983,13 +2047,13 @@ function createApp(origin2, options = {}) {
 }
 async function serveAsset(c) {
   const requestPath = new URL(c.req.url).pathname.replace(/^\/assets\//, "");
-  const normalized = path5.normalize(requestPath).replace(/^(\.\.(\/|\\|$))+/, "");
-  const assetPath = path5.join(webRoot, "assets", normalized);
+  const normalized = path6.normalize(requestPath).replace(/^(\.\.(\/|\\|$))+/, "");
+  const assetPath = path6.join(webRoot, "assets", normalized);
   try {
     const body = await readFile4(assetPath);
     return new Response(body, {
       headers: {
-        "content-type": mimeTypes[path5.extname(assetPath)] ?? "application/octet-stream"
+        "content-type": mimeTypes[path6.extname(assetPath)] ?? "application/octet-stream"
       }
     });
   } catch (error) {
@@ -2001,7 +2065,7 @@ async function serveAsset(c) {
 }
 async function serveIndex() {
   try {
-    const body = await readFile4(path5.join(webRoot, "index.html"));
+    const body = await readFile4(path6.join(webRoot, "index.html"));
     return new Response(body, {
       headers: { "content-type": "text/html; charset=utf-8" }
     });
@@ -2015,7 +2079,7 @@ async function serveIndex() {
 function serveRootFile(fileName, contentType) {
   return async () => {
     try {
-      const body = await readFile4(path5.join(webRoot, fileName));
+      const body = await readFile4(path6.join(webRoot, fileName));
       return new Response(body, {
         headers: { "content-type": contentType }
       });
@@ -2047,8 +2111,8 @@ async function readJsonBody(c, guard, label) {
   }
 }
 function isPathWithin(parentPath, childPath) {
-  const relative = path5.relative(parentPath, childPath);
-  return relative === "" || !relative.startsWith("..") && !path5.isAbsolute(relative);
+  const relative = path6.relative(parentPath, childPath);
+  return relative === "" || !relative.startsWith("..") && !path6.isAbsolute(relative);
 }
 function activeTurnSummary(meta) {
   if (!meta.activeTurnId) {
@@ -2180,7 +2244,11 @@ async function shutdown(exitCode) {
 async function removeCurrentServerInfo() {
   const info = await readServerInfo().catch(() => null);
   if (!info || info.pid === process.pid) {
-    await rm3(globalServerFile(), { force: true });
+    const warning = await removeServerInfoFile();
+    if (warning) {
+      process.stderr.write(`Warning: ${warning}
+`);
+    }
   }
 }
 //# sourceMappingURL=daemon.js.map