getgloss 0.12.1 → 0.13.0

package/README.md

@@ -122,9 +122,16 @@ choose a different retention window.
 ## Review UI
 
 In the browser review, drag over a changed line or range to open a draft
-comment. Use `Command+Enter` to save the active draft comment. Use
-`Command+Shift+Enter` to submit the review; this matches the Submit button and
-includes already-saved comments only.
+comment. Add review-level general comments from the submit bar when the feedback
+is not tied to one line. Use `Command+Enter` to save the active draft comment.
+Use `Command+Shift+Enter` to submit the review; this matches the Submit button
+and includes already-saved comments only.
+
+Lockfiles are hidden by default in the browser review and stay one click away in
+the hidden-files banner. Use the file filter menu to also hide boring files such
+as snapshots, generated files, and vendored files. These filters affect only the
+browser view: submitted feedback and review artifacts still keep the full
+captured diff.
 
 When branch reviews include per-commit diffs, the commit picker changes only the
 current preview. Gloss persists that selected scope when the review is submitted,
@@ -148,9 +155,10 @@ Submitted reviews are written to:
 ```
 
 `feedback.json` is the machine-readable payload and includes `reviewScope` for
-submitted commit-preview scope. `feedback.md` is a readable summary ordered by
-file and line. `resolved.json` is mutable resolution progress for individual
-comments and the turn. After applying feedback, use
+submitted commit-preview scope. `feedback.md` is a readable summary with
+general comments first, then file comments ordered by path and line.
+`resolved.json` is mutable resolution progress for individual comments and the
+turn. After applying feedback, use
 `gloss resolve <reviewId> --comment <commentId> --summary "..."` for a single
 comment or `gloss resolve <reviewId> --turn <id-or-index> --summary "..."` for a
 specific turn. Without `--turn`, whole-review resolution targets the latest

package/dist/cli/index.js

@@ -30,7 +30,7 @@ import path from "path";
 // package.json
 var package_default = {
   name: "getgloss",
-  version: "0.12.1",
+  version: "0.13.0",
   description: "Local browser-based diff review for coding-agent loops.",
   type: "module",
   packageManager: "pnpm@10.33.2",
@@ -87,8 +87,8 @@ var package_default = {
     tsup: "8.5.1",
     tsx: "4.22.3",
     typescript: "5.9.3",
-    vite: "6.4.2",
-    vitest: "3.2.4"
+    vite: "6.4.3",
+    vitest: "3.2.6"
   },
   keywords: [
     "diff",
@@ -339,7 +339,13 @@ function isDiffLine(value) {
   return isRecord(value) && isOneOf(value.type, DIFF_LINE_TYPES) && isNullableNumber(value.oldLine) && isNullableNumber(value.newLine) && isString(value.content);
 }
 function isComment(value) {
-  return isRecord(value) && isString(value.id) && isString(value.filePath) && isNumber(value.startLine) && isNumber(value.endLine) && isOneOf(value.side, SIDES) && isString(value.body) && isString(value.originalSnippet) && isString(value.createdAt);
+  if (!isRecord(value)) {
+    return false;
+  }
+  if (value.kind === "general") {
+    return isString(value.id) && isString(value.body) && isString(value.createdAt);
+  }
+  return isString(value.id) && (value.kind === void 0 || value.kind === "line") && isString(value.filePath) && isNumber(value.startLine) && isNumber(value.endLine) && isOneOf(value.side, SIDES) && isString(value.body) && isString(value.originalSnippet) && isString(value.createdAt);
 }
 function isResolvedComment(value) {
   return isRecord(value) && isString(value.commentId) && value.status === "resolved" && isOptionalString(value.summary) && isString(value.resolvedAt);
@@ -892,6 +898,17 @@ function summarizeDiffFiles(files) {
   );
 }
 
+// src/shared/file-order.ts
+function compareFilePaths(leftPath, rightPath, leftTieBreaker = "", rightTieBreaker = "") {
+  return leftPath.localeCompare(rightPath, void 0, { sensitivity: "base" }) || leftPath.localeCompare(rightPath) || leftTieBreaker.localeCompare(rightTieBreaker, void 0, { sensitivity: "base" }) || leftTieBreaker.localeCompare(rightTieBreaker);
+}
+function compareDiffFiles(left, right) {
+  return compareFilePaths(left.path, right.path, left.oldPath ?? "", right.oldPath ?? "");
+}
+function sortDiffFiles(files) {
+  return files.toSorted(compareDiffFiles);
+}
+
 // src/cli/git.ts
 var DIFF_ARGS = ["diff", "--no-color", "--find-renames", "--find-copies"];
 async function git(args, cwd = process.cwd()) {
@@ -923,7 +940,7 @@ function buildPayload({
   fallbackReason,
   commitDiffs
 }) {
-  const files = parseUnifiedDiff(rawDiff);
+  const files = sortDiffFiles(parseUnifiedDiff(rawDiff));
   return {
     base,
     branch,
@@ -1030,7 +1047,7 @@ async function captureCommitDiffs(baseSha, comparisonRef, repoRoot) {
   const commitDiffs = [];
   for (const commit of commits) {
     const rawDiff = await git([...DIFF_ARGS, `${commit.sha}^`, commit.sha, "--"], repoRoot);
-    const files = parseUnifiedDiff(rawDiff);
+    const files = sortDiffFiles(parseUnifiedDiff(rawDiff));
     commitDiffs.push({
       commit,
       stats: summarizeDiffFiles(files),
@@ -1662,11 +1679,28 @@ import path6 from "path";
 import { ulid } from "ulid";
 
 // src/shared/comments.ts
+function isLineComment(comment) {
+  return comment.kind === void 0 || comment.kind === "line";
+}
 function compareCommentsByLocation(a, b) {
+  const aIsLine = isLineComment(a);
+  const bIsLine = isLineComment(b);
+  if (!aIsLine || !bIsLine) {
+    if (aIsLine !== bIsLine) {
+      return aIsLine ? 1 : -1;
+    }
+    return a.createdAt.localeCompare(b.createdAt) || a.id.localeCompare(b.id);
+  }
   return a.filePath.localeCompare(b.filePath) || a.startLine - b.startLine || a.endLine - b.endLine || a.side.localeCompare(b.side);
 }
 function countCommentFiles(comments) {
-  return new Set(comments.map((comment) => comment.filePath)).size;
+  const filePaths = /* @__PURE__ */ new Set();
+  for (const comment of comments) {
+    if (isLineComment(comment)) {
+      filePaths.add(comment.filePath);
+    }
+  }
+  return filePaths.size;
 }
 function formatLineRange(range, options = {}) {
   const startLine = Math.min(range.startLine, range.endLine);
@@ -1757,9 +1791,11 @@ function languageForSnippet(filePath, snippet) {
 }
 function serializeFeedbackMarkdown(bundle) {
   const comments = bundle.comments.toSorted(compareCommentsByLocation);
+  const generalComments = comments.filter((comment) => !isLineComment(comment));
+  const lineComments = comments.filter(isLineComment);
   const commentsByFile = /* @__PURE__ */ new Map();
   const files = [];
-  for (const comment of comments) {
+  for (const comment of lineComments) {
     const fileComments = commentsByFile.get(comment.filePath);
     if (fileComments) {
       fileComments.push(comment);
@@ -1777,6 +1813,12 @@ function serializeFeedbackMarkdown(bundle) {
     `Files: ${files.length}   Comments: ${comments.length}`,
     ""
   ];
+  if (generalComments.length > 0) {
+    lines.push("## General comments", "");
+    for (const comment of generalComments) {
+      lines.push(`### ${comment.id}`, comment.body.trim(), "");
+    }
+  }
   for (const filePath of files) {
     lines.push(`## ${filePath}`, "");
     for (const comment of commentsByFile.get(filePath) ?? []) {
@@ -2748,7 +2790,7 @@ async function watchReviewWithReconnect(reviewId, initialInfo, timeoutSeconds, o
       return { event, info };
     } catch (error) {
       if (isWatchTimeout(error)) {
-        throw error;
+        throw new Error(`watch timed out after ${timeoutSeconds} seconds`);
       }
       if (!isReconnectableWatchError(error)) {
         throw error;