geonetwork-ui 2.6.0-dev.01f702fed → 2.6.0-dev.02631a41f

package/src/libs/api/metadata-converter/src/lib/gn4/gn4.field.mapper.ts

@@ -26,8 +26,12 @@ import {
 } from '../../../../../../libs/common/domain/src/lib/model/record'
 import { matchProtocol } from '../common/distribution.mapper'
 import { Thesaurus } from './types'
-import { LANG_3_TO_2_MAPPER, LangService } from '../../../../../../libs/util/i18n/src'
 import { getResourceType, getReuseType } from '../common/resource-types'
+import { TranslateService } from '@ngx-translate/core'
+import {
+  getLang2FromLang3,
+  getLocalizedIndexKey,
+} from '../../../../../../libs/util/i18n/src'
 
 type ESResponseSource = SourceWithUnknownProps
 
@@ -42,10 +46,12 @@ type EsFieldMapperFn = (
 export class Gn4FieldMapper {
   constructor(
     private metadataUrlService: MetadataUrlService,
-    private langService: LangService
+    private translateService: TranslateService
   ) {}
 
-  private lang3 = this.langService.gnLang
+  private get lang3() {
+    return getLocalizedIndexKey(this.translateService.currentLang)
+  }
 
   protected fields: Record<string, EsFieldMapperFn> = {
     id: (output, source) =>
@@ -150,14 +156,24 @@ export class Gn4FieldMapper {
       const langList = getAsArray(
         selectField<string>(source, 'resourceLanguage')
       )
-      const languages = langList.map((lang) => LANG_3_TO_2_MAPPER[lang])
+      const languages = langList.map(getLang2FromLang3)
       const defaultLanguage = output.defaultLanguage ?? languages[0] ?? null // set the first language as main one as fallback
+
+      return {
+        ...output,
+        defaultLanguage,
+      }
+    },
+    otherLanguage: (output, source) => {
+      const langList = getAsArray(selectField<string>(source, 'otherLanguage'))
+      const languages = langList.map(getLang2FromLang3)
+      const defaultLanguage = output.defaultLanguage ?? languages[0] ?? null
       const otherLanguages = languages.filter(
         (lang) => lang !== defaultLanguage
       )
+
       return {
         ...output,
-        defaultLanguage,
         otherLanguages,
       }
     },
@@ -165,7 +181,7 @@ export class Gn4FieldMapper {
       const language = selectField<string>(source, 'mainLanguage')
       return {
         ...output,
-        defaultLanguage: language ? LANG_3_TO_2_MAPPER[language] : null,
+        defaultLanguage: language ? getLang2FromLang3(language) : null,
       }
     },
     link: (output, source) => {
@@ -294,12 +310,52 @@ export class Gn4FieldMapper {
         ) ?? {},
         '_source'
       )
-      const featureCatalogIdentifier = selectField(
+      const featureCatalogIdentifier: string = selectField(
         <SourceWithUnknownProps>fcatSource,
         'uuid'
       )
-      return featureCatalogIdentifier
-        ? this.addExtra({ featureCatalogIdentifier }, output)
+      const sourceOfLinks = getAsArray(
+        selectField(
+          <SourceWithUnknownProps>selectField(source, 'related'),
+          'hassources'
+        )
+      )
+      const sourceOfIdentifiers: string[] = sourceOfLinks
+        .filter((link) => link['origin'] === 'catalog')
+        .map((link) => {
+          return selectField(
+            selectField(<SourceWithUnknownProps>link, '_source'),
+            'uuid'
+          )
+        })
+      const extraValues: Record<string, string | string[]> = {}
+      if (featureCatalogIdentifier) {
+        extraValues.featureCatalogIdentifier = featureCatalogIdentifier
+      }
+      if (sourceOfIdentifiers && sourceOfIdentifiers.length > 0) {
+        extraValues.sourceOfIdentifiers = sourceOfIdentifiers
+      }
+      return Object.keys(extraValues).length > 0
+        ? this.addExtra(extraValues, output)
+        : output
+    },
+    recordLink: (output, source) => {
+      const recordLinks = getAsArray(
+        selectField<SourceWithUnknownProps[]>(source, 'recordLink')
+      )
+      const sourcesIdentifiers: string[] = recordLinks
+        .filter(
+          (link) => link['origin'] === 'catalog' && link['type'] === 'sources'
+        )
+        .map((link) => selectField(<SourceWithUnknownProps>link, 'to'))
+
+      return sourcesIdentifiers && sourcesIdentifiers.length > 0
+        ? this.addExtra(
+            {
+              sourcesIdentifiers,
+            },
+            output
+          )
         : output
     },
     isPublishedToAll: (output, source) =>
@@ -309,6 +365,13 @@ export class Gn4FieldMapper {
         },
         output
       ),
+    isHarvested: (output, source) =>
+      this.addExtra(
+        {
+          isHarvested: selectField(source, 'isHarvested') !== 'false',
+        },
+        output
+      ),
     edit: (output, source) =>
       this.addExtra(
         {
@@ -430,6 +493,7 @@ export class Gn4FieldMapper {
       /^OGC:WMS/.test(protocol) ||
       /^OGC:WFS/.test(protocol) ||
       /^OGC:WMTS/.test(protocol) ||
+      /TMS/i.test(protocol) ||
       /ogc\W*api\W*features/i.test(protocol) ||
       (/^WWW:DOWNLOAD-/.test(protocol) && /data.geopf.fr/.test(url)) // TO DO : change with the good protocol when decided
     ) {

package/src/libs/api/metadata-converter/src/lib/gn4/metadata-url.service.ts

@@ -1,7 +1,7 @@
 import { Inject, Injectable } from '@angular/core'
 import { Configuration } from '../../../../../../libs/data-access/gn4/src'
 import { TranslateService } from '@ngx-translate/core'
-import { LANG_2_TO_3_MAPPER } from '../../../../../../libs/util/i18n/src'
+import { getLang3FromLang2 } from '../../../../../../libs/util/i18n/src'
 
 @Injectable({
   providedIn: 'root',
@@ -14,8 +14,8 @@ export class MetadataUrlService {
 
   getUrl(uuid: string, apiPath: string = this.apiConfiguration.basePath) {
     const prefix = `${apiPath}/../`
-    return `${prefix}${
-      LANG_2_TO_3_MAPPER[this.translate.currentLang]
-    }/catalog.search#/metadata/${uuid}`
+    return `${prefix}${getLang3FromLang2(
+      this.translate.currentLang
+    )}/catalog.search#/metadata/${uuid}`
   }
 }

package/src/libs/api/metadata-converter/src/lib/gn4/types/metadata.model.ts

@@ -164,7 +164,6 @@ export type MetadataObject = Partial<{
   resourceDate: ResourceDate[]
   resourceEdition: string
   resourceIdentifier: ResourceIdentifier[]
-  resourceLanguage: string[]
   resourceTemporalDateRange: ResourceTemporalDateRange[]
   resourceTemporalExtentDateRange: ResourceTemporalDateRange[]
   resourceTitleObject: MultilingualField

package/src/libs/api/metadata-converter/src/lib/iso19115-3/read-parts.ts

@@ -22,9 +22,9 @@ import {
   extractDatasetOnlineResources,
   extractDateTime,
   extractLocalizedCharacterString,
+  extractReuseOnlineResources,
   extractRole,
   extractServiceOnlineResources,
-  extractReuseOnlineResources,
   extractUrl,
   findIdentification,
 } from '../iso19139/read-parts'
@@ -41,7 +41,7 @@ import {
 } from '../../../../../../libs/common/domain/src/lib/model/record'
 import { matchMimeType } from '../common/distribution.mapper'
 import { fullNameToParts } from '../iso19139/utils/individual-name'
-import { LANG_3_TO_2_MAPPER } from '../../../../../../libs/util/i18n/src/lib/language-codes'
+import { getLang2FromLang3 } from '../../../../../../libs/util/i18n/src/lib/language-codes'
 import { getResourceType, getReuseType } from '../common/resource-types'
 
 export function readKind(rootEl: XmlElement): RecordKind {
@@ -363,11 +363,14 @@ export function readOnlineResources(rootEl: XmlElement): OnlineResource[] {
   )(rootEl)
 }
 
-function readLocaleElement(): ChainableFunction<XmlElement, LanguageCode> {
+export function readLocaleElement(): ChainableFunction<
+  XmlElement,
+  LanguageCode
+> {
   return pipe(
     findChildElement('lan:LanguageCode'),
     readAttribute('codeListValue'),
-    map((lang) => (lang ? LANG_3_TO_2_MAPPER[lang.toLowerCase()] : null))
+    map((lang) => getLang2FromLang3(lang?.toLowerCase()) ?? lang)
   )
 }
 
@@ -381,6 +384,9 @@ export function readDefaultLanguage(rootEl: XmlElement): LanguageCode {
 export function readOtherLanguages(rootEl: XmlElement): LanguageCode[] {
   return pipe(
     findChildrenElement('mdb:otherLocale', false),
-    mapArray(readLocaleElement())
+    mapArray(readLocaleElement()),
+    map((languages) =>
+      languages.filter((lang): lang is LanguageCode => lang !== null)
+    )
   )(rootEl)
 }

package/src/libs/api/metadata-converter/src/lib/iso19115-3/write-parts.ts

@@ -49,7 +49,7 @@ import {
 } from '../iso19139/write-parts'
 import { findIdentification } from '../iso19139/read-parts'
 import { namePartsToFull } from '../iso19139/utils/individual-name'
-import { LANG_2_TO_3_MAPPER } from '../../../../../../libs/util/i18n/src/lib/language-codes'
+import { getLang3FromLang2 } from '../../../../../../libs/util/i18n/src/lib/language-codes'
 import { kindToCodeListValue } from '../common/resource-types'
 
 export function writeUniqueIdentifier(
@@ -529,7 +529,7 @@ export function writeOnlineResources(
 }
 
 function writeLocaleElement(language: LanguageCode) {
-  const lang3 = LANG_2_TO_3_MAPPER[language.toLowerCase()]
+  const lang3 = getLang3FromLang2(language.toLowerCase()) ?? language
   return pipe(
     findChildOrCreate('lan:PT_Locale'),
     writeAttribute('id', language.toUpperCase()),

package/src/libs/api/metadata-converter/src/lib/iso19139/iso19139.converter.ts

@@ -11,6 +11,7 @@ import {
 import { XmlElement } from '@rgrove/parse-xml'
 import { BaseConverter } from '../base.converter'
 import { isEqual } from '../convert-utils'
+import { isFieldTranslatable } from '../translate-utils'
 import {
   createDocument,
   createElement,
@@ -160,7 +161,7 @@ export class Iso19139Converter extends BaseConverter<string> {
     // TODO
     extras: () => undefined,
     landingPage: () => undefined,
-    translations: () => undefined,
+    translations: () => undefined, // NB. translations are handled in properties
   }
 
   protected beforeDocumentCreation(rootElement: XmlElement) {
@@ -189,6 +190,7 @@ export class Iso19139Converter extends BaseConverter<string> {
         }
       }
     }
+
     fixLanguages(record)
     record.keywords.map(fixLanguages)
     record.onlineResources.map(fixLanguages)
@@ -275,7 +277,6 @@ export class Iso19139Converter extends BaseConverter<string> {
   async readRecord(document: string): Promise<CatalogRecord> {
     const doc = parseXmlString(document)
     const rootEl = getRootElement(doc)
-
     const tr: RecordTranslations = {}
     const kind = this.readers['kind'](rootEl, tr) as RecordKind
 
@@ -326,15 +327,19 @@ export class Iso19139Converter extends BaseConverter<string> {
     let rootEl: XmlElement
     let fieldChanged: (name: string) => boolean
     if (reference) {
+      // eslint-disable-next-line prefer-const
+      let languagesChanged: boolean
       const originalDoc = parseXmlString(reference)
       const originalRecord = await this.readRecord(reference)
       rootEl = getRootElement(originalDoc)
 
       fieldChanged = (name: string) => {
         return originalRecord !== null
-          ? !isEqual(record[name], originalRecord[name])
+          ? !isEqual(record[name], originalRecord[name]) ||
+              (languagesChanged && isFieldTranslatable(name))
           : true
       }
+      languagesChanged = fieldChanged('otherLanguages')
     } else {
       rootEl = createElement('gmd:MD_Metadata')()
       fieldChanged = () => true
@@ -357,9 +362,10 @@ export class Iso19139Converter extends BaseConverter<string> {
       this.writers['recordCreated'](record, rootEl)
     fieldChanged('recordPublished') &&
       this.writers['recordPublished'](record, rootEl)
-
-    fieldChanged('title') && this.writers['title'](record, rootEl)
-    fieldChanged('abstract') && this.writers['abstract'](record, rootEl)
+    ;(fieldChanged('title') || fieldChanged('translations')) &&
+      this.writers['title'](record, rootEl)
+    ;(fieldChanged('abstract') || fieldChanged('translations')) &&
+      this.writers['abstract'](record, rootEl)
 
     fieldChanged('resourceCreated') &&
       this.writers['resourceCreated'](record, rootEl)
@@ -396,9 +402,9 @@ export class Iso19139Converter extends BaseConverter<string> {
         this.writers['temporalExtents'](record, rootEl)
       fieldChanged('spatialExtents') &&
         this.writers['spatialExtents'](record, rootEl)
-      fieldChanged('lineage') && this.writers['lineage'](record, rootEl)
+      ;(fieldChanged('lineage') || fieldChanged('translations')) &&
+        this.writers['lineage'](record, rootEl)
     }
-
     fieldChanged('otherLanguages') &&
       this.writers['otherLanguages'](record, rootEl)
 

package/src/libs/api/metadata-converter/src/lib/iso19139/read-parts.ts

@@ -55,7 +55,7 @@ import { getKeywordTypeFromKeywordTypeCode } from './utils/keyword.mapper'
 import { getRoleFromRoleCode } from './utils/role.mapper'
 import { getStatusFromStatusCode } from './utils/status.mapper'
 import { getUpdateFrequencyFromFrequencyCode } from './utils/update-frequency.mapper'
-import { LANG_3_TO_2_MAPPER } from '../../../../../../libs/util/i18n/src/lib/language-codes'
+import { getLang2FromLang3 } from '../../../../../../libs/util/i18n/src/lib/language-codes'
 import { getResourceType, getReuseType } from '../common/resource-types'
 
 export function extractCharacterString(): ChainableFunction<
@@ -65,7 +65,8 @@ export function extractCharacterString(): ChainableFunction<
   return pipe(
     fallback(
       findChildElement('gco:CharacterString', false),
-      findChildElement('gmx:Anchor', false)
+      findChildElement('gmx:Anchor', false),
+      findChildElement('gmx:MimeFileType', false)
     ),
     readText()
   )
@@ -1161,11 +1162,14 @@ export function readOtherLanguages(rootEl: XmlElement): LanguageCode[] {
     findChildrenElement('gmd:locale', false),
     mapArray(
       pipe(
-        findChildElement('gmd:LanguageCode'),
+        findChildElement('lan:LanguageCode'),
         readAttribute('codeListValue'),
-        map((lang) => LANG_3_TO_2_MAPPER[lang.toLowerCase()])
+        map((lang) => getLang2FromLang3(lang?.toLowerCase()) ?? lang)
       )
     ),
+    map((languages) =>
+      languages.filter((lang): lang is LanguageCode => lang !== null)
+    ),
     map((languages) => (languages.length ? languages : [defaultLanguage]))
   )(rootEl)
 }
@@ -1173,9 +1177,9 @@ export function readOtherLanguages(rootEl: XmlElement): LanguageCode[] {
 export function readDefaultLanguage(rootEl: XmlElement): LanguageCode {
   return pipe(
     findChildElement('gmd:language', false),
-    findChildElement('gmd:LanguageCode'),
+    findChildElement('lan:LanguageCode'),
     readAttribute('codeListValue'),
-    map((lang) => (lang ? LANG_3_TO_2_MAPPER[lang.toLowerCase()] : null))
+    map((lang) => (lang ? getLang2FromLang3(lang.toLowerCase()) : null))
   )(rootEl)
 }
 

package/src/libs/api/metadata-converter/src/lib/iso19139/write-parts.ts

@@ -53,7 +53,7 @@ import {
 import { readKind } from './read-parts'
 import { writeGeometry } from './utils/geometry'
 import { namePartsToFull } from './utils/individual-name'
-import { LANG_2_TO_3_MAPPER } from '../../../../../../libs/util/i18n/src/lib/language-codes'
+import { getLang3FromLang2 } from '../../../../../../libs/util/i18n/src/lib/language-codes'
 import { kindToCodeListValue } from '../common/resource-types'
 
 function writeLocalizedElement(
@@ -62,7 +62,8 @@ function writeLocalizedElement(
   translations: FieldTranslation,
   defaultLanguage: LanguageCode
 ): ChainableFunction<XmlElement, XmlElement> {
-  if (!translations) return writeFn
+  if (!translations)
+    return pipe(writeFn, removeChildrenByName('gmd:PT_FreeText')) // If no translations, remove existing if any
   function createLocalized(lang: LanguageCode, translation: string) {
     return pipe(
       createNestedElement('gmd:textGroup', 'gmd:LocalisedCharacterString'),
@@ -1471,7 +1472,7 @@ export function writeLanguages(record: DatasetRecord, rootEl: XmlElement) {
       writeAttribute('id', lang.toUpperCase()),
       createNestedChild('gmd:languageCode', 'gmd:LanguageCode'),
       writeAttribute('codeList', 'http://www.loc.gov/standards/iso639-2/'),
-      writeAttribute('codeListValue', LANG_2_TO_3_MAPPER[lang])
+      writeAttribute('codeListValue', getLang3FromLang2(lang) ?? lang)
     )
 
   // add new languages (only if other than default one)
@@ -1485,7 +1486,7 @@ export function writeDefaultLanguage(
   record: DatasetRecord,
   rootEl: XmlElement
 ) {
-  const lang3 = LANG_2_TO_3_MAPPER[record.defaultLanguage.toLowerCase()]
+  const lang3 = getLang3FromLang2(record.defaultLanguage.toLowerCase())
   return pipe(
     findNestedChildOrCreate('gmd:language', 'gmd:LanguageCode'),
     writeAttribute('codeList', 'http://www.loc.gov/standards/iso639-2/'),

package/src/libs/api/metadata-converter/src/lib/translate-utils.ts

@@ -0,0 +1,17 @@
+const TRANSLATABLE_GN4_FIELDS = [
+  'abstract',
+  'constraint',
+  'keywords',
+  'lineage',
+  'onlineResources',
+  'spatialExtents',
+  'title',
+  // TODO, also add these fields in writers
+  // 'contact',
+  // 'pointOfContact'
+  // 'extent'
+] as const
+
+export function isFieldTranslatable(fieldName: string) {
+  return (TRANSLATABLE_GN4_FIELDS as unknown as string[]).includes(fieldName)
+}

package/src/libs/api/repository/src/lib/gn4/auth/auth.service.ts

@@ -1,5 +1,5 @@
 import { Inject, Injectable, InjectionToken, Optional } from '@angular/core'
-import { LANG_2_TO_3_MAPPER } from '../../../../../../../libs/util/i18n/src'
+import { getLang3FromLang2 } from '../../../../../../../libs/util/i18n/src'
 import { TranslateService } from '@ngx-translate/core'
 import { Location } from '@angular/common'
 
@@ -36,10 +36,7 @@ export class AuthService {
         new URL(this.location.path(), window.location.href).toString()
       )
       .replace('${lang2}', this.translateService.currentLang)
-      .replace(
-        '${lang3}',
-        LANG_2_TO_3_MAPPER[this.translateService.currentLang]
-      )
+      .replace('${lang3}', getLang3FromLang2(this.translateService.currentLang))
   }
 
   get logoutUrl() {
@@ -49,7 +46,7 @@ export class AuthService {
   get settingsUrl() {
     return this.baseSettingsUrl.replace(
       '${lang3}',
-      LANG_2_TO_3_MAPPER[this.translateService.currentLang]
+      getLang3FromLang2(this.translateService.currentLang)
     )
   }
 

package/src/libs/api/repository/src/lib/gn4/elasticsearch/constant.ts

@@ -8,6 +8,7 @@ export const ES_SOURCE_SUMMARY = [
   'overview',
   'logo',
   'codelist_status_text',
+  'link',
   'linkProtocol',
   'contactForResource.organisation',
   'contact.organisation',
@@ -17,8 +18,10 @@ export const ES_SOURCE_SUMMARY = [
   'cl_topic',
   'cl_maintenanceAndUpdateFrequency',
   'tag',
-  'MD_LegalConstraintsUseLimitationObject',
+  'MD_LegalConstraints*Object',
   'qualityScore',
+  'allKeywords',
+  'recordLink',
 ]
 
 export type EsQueryFieldsPriorityType = Record<string, number>

package/src/libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.ts

@@ -1,4 +1,4 @@
-import { Inject, Injectable, Optional } from '@angular/core'
+import { Injectable, Injector } from '@angular/core'
 import { Geometry } from 'geojson'
 import {
   ES_QUERY_FIELDS_PRIORITY,
@@ -26,9 +26,10 @@ import {
   SortParams,
   TermsAggregationResult,
 } from '../../../../../../../libs/api/metadata-converter/src'
-import { LangService } from '../../../../../../../libs/util/i18n/src'
+import { getLang3FromLang2 } from '../../../../../../../libs/util/i18n/src'
 import { formatDate, isDateRange } from './date-range.utils'
 import { CatalogRecord } from '../../../../../../../libs/common/domain/src/lib/model/record'
+import { TranslateService } from '@ngx-translate/core'
 
 export type DateRange = { start?: Date; end?: Date }
 
@@ -39,11 +40,18 @@ export class ElasticsearchService {
   // runtime fields are computed using a Painless script
   // see: https://www.elastic.co/guide/en/elasticsearch/reference/current/runtime-mapping-fields.html
   private runtimeFields: Record<string, string> = {}
-  private lang3 = this.langService.iso3
+
+  // we're using getters in case the defined languages change over time
+  private get lang3() {
+    return getLang3FromLang2(this.translateService.currentLang)
+  }
+  private get metadataLang() {
+    return this.injector.get(METADATA_LANGUAGE, null)
+  }
 
   constructor(
-    private langService: LangService,
-    @Optional() @Inject(METADATA_LANGUAGE) private metadataLang: string
+    private translateService: TranslateService,
+    private injector: Injector
   ) {}
 
   getSearchRequestBody(
@@ -124,11 +132,11 @@ export class ElasticsearchService {
     this.runtimeFields[fieldName] = expression
   }
 
-  getMetadataByIdPayload(uuid: string): EsSearchParams {
+  getMetadataByIdsPayload(uuids: string[]): EsSearchParams {
     return {
       query: {
         ids: {
-          values: [uuid],
+          values: uuids,
         },
       },
     }
@@ -137,7 +145,7 @@ export class ElasticsearchService {
   getRelatedRecordPayload(
     record: CatalogRecord,
     size = 6,
-    _source = [...ES_SOURCE_SUMMARY, 'allKeywords', 'createDate']
+    _source = [...ES_SOURCE_SUMMARY, 'createDate']
   ): EsSearchParams {
     return {
       query: {