geonetwork-ui 2.6.0-dev.01d2b5fc0 → 2.6.0-dev.025a2f85d

package/src/libs/common/fixtures/src/lib/record-link.fixtures.ts

@@ -1,26 +1,26 @@
 export const wmsRecordLinkFixture = () => ({
   description: 'Lieu de surveillance (point)',
   name: 'surval_parametre_point',
-  protocol: 'OGC:WMS',
+  accessServiceProtocol: 'OGC:WMS',
   url: 'https://www.ifremer.fr/services/wms/surveillance_littorale',
 })
 
 export const wpsRecordLinkFixture = () => ({
   description: "Extraction des données d'observation",
   name: 'r:survalextraction',
-  protocol: 'OGC:WPS',
+  accessServiceProtocol: 'OGC:WPS',
   url: 'https://www.ifremer.fr/services/wps/surval',
 })
 
 export const wwwRecordLinkFixture = () => ({
   description: '',
   name: 'La base de données Quadrige',
-  protocol: 'WWW:LINK',
+  praccessServiceProtocolotocol: 'WWW:LINK',
   url: 'http://envlit.ifremer.fr/resultats/quadrige',
 })
 
 export const doiRecordLinkFixture = () => ({
-  protocol: 'WWW:DOI',
+  accessServiceProtocol: 'WWW:DOI',
   description: 'DOI for the resource',
   url: 'http://doi.org/123-456-678',
 })
@@ -28,6 +28,6 @@ export const doiRecordLinkFixture = () => ({
 export const wfsRecordLinkFixture = () => ({
   description: 'Lieu de surveillance (point)',
   name: 'surval_parametre_point',
-  protocol: 'OGC:WFS',
+  accessServiceProtocol: 'OGC:WFS',
   url: 'https://www.ifremer.fr/services/wfs/surveillance_littorale',
 })

package/src/libs/common/fixtures/src/lib/records.fixtures.ts

@@ -187,8 +187,24 @@ As such, **it is not very interesting at all.**`,
           ],
           code: '',
           aliases: '',
-          typeName: "Catalogue d'attributs",
-          definition: '',
+          typeName: "Catalogue d'attributs N°1",
+          definition: 'Définition du catalogue d attributs N°1',
+          isAbstract: 'false',
+        },
+        {
+          attributeTable: [
+            {
+              code: 'UniqueObject',
+              name: 'unique object ',
+              link: '',
+              definition: 'this is the only object of this catalog',
+              type: 'String (50)',
+            },
+          ],
+          code: '',
+          aliases: '',
+          typeName: "Catalogue d'attributs N°2",
+          definition: 'Définition du catalogue d attributs N°2',
           isAbstract: 'false',
         },
       ],

package/src/libs/feature/dataviz/src/lib/chart-view/chart-view.component.html

@@ -40,6 +40,7 @@
     class="relative h-full mt-2 bg-white border border-gray-300 rounded-lg overflow-hidden"
   >
     <gn-ui-chart
+      *ngIf="!error"
       [data]="chartData$ | async"
       [type]="chartType$.value"
       [labelProperty]="labelProperty"

package/src/libs/feature/dataviz/src/lib/chart-view/chart-view.component.ts

@@ -137,6 +137,10 @@ export class ChartViewComponent {
     switchMap((link) => {
       this.error = null
       this.loading = true
+      if (link.accessRestricted) {
+        this.handleError('dataset.error.restrictedAccess')
+        return EMPTY
+      }
       return this.dataService.getDataset(link, this.cacheActive).pipe(
         catchError((error) => {
           this.handleError(error)

package/src/libs/feature/dataviz/src/lib/service/data.service.ts

@@ -30,6 +30,7 @@ import {
 
 marker('wfs.unreachable.cors')
 marker('wfs.unreachable.http')
+marker('dataset.error.forbidden')
 marker('wfs.unreachable.unknown')
 marker('wfs.featuretype.notfound')
 marker('wfs.geojsongml.notsupported')

package/src/libs/feature/dataviz/src/lib/table-view/table-view.component.html

@@ -11,13 +11,15 @@
       class="absolute inset-0"
       [message]="'table.loading.data' | translate"
     ></gn-ui-loading-mask>
-    <gn-ui-popup-alert
-      *ngIf="error"
-      type="warning"
-      icon="matErrorOutlineOutline"
-      class="absolute m-2 inset-0"
-    >
-      <span translate>{{ error }}</span>
-    </gn-ui-popup-alert>
+    <ng-content *ngIf="error">
+      <div class="border border-gray-300 rounded-lg bg-white h-full"></div>
+      <gn-ui-popup-alert
+        type="warning"
+        icon="matErrorOutlineOutline"
+        class="absolute m-2 inset-0"
+      >
+        <span translate>{{ error }}</span>
+      </gn-ui-popup-alert>
+    </ng-content>
   </div>
 </div>

package/src/libs/feature/dataviz/src/lib/table-view/table-view.component.ts

@@ -46,6 +46,10 @@ export class TableViewComponent {
     switchMap((link) => {
       this.error = null
       if (!link) return of(undefined)
+      if (link.accessRestricted) {
+        this.handleError('dataset.error.restrictedAccess')
+        return of([])
+      }
       this.loading = true
       return this.getDatasetReader(link).pipe(
         catchError((error) => {

package/src/libs/feature/editor/src/lib/components/online-resource-card/online-resource-card.component.ts

@@ -66,9 +66,8 @@ export class OnlineResourceCardComponent {
   get subtitle(): string {
     switch (this.onlineResource.type) {
       case 'service':
-        return `${this.onlineResource.accessServiceProtocol}`
       case 'endpoint':
-        return `${this.onlineResource.protocol}`
+        return `${this.onlineResource.accessServiceProtocol}`
       case 'link':
       case 'download':
         return this.getFormat(this.onlineResource)

package/src/libs/feature/editor/src/lib/components/online-service-resource-input/online-service-resource-input.component.ts

@@ -81,8 +81,8 @@ export class OnlineServiceResourceInputComponent {
   errorMessage = false
   resetUrlOnChange = Math.random()
 
-  layersSubject = new BehaviorSubject<{ name: string; title: string }[]>([])
-  layers$: Observable<{ name: string; title: string }[]> =
+  layersSubject = new BehaviorSubject<{ name?: string; title?: string }[]>([])
+  layers$: Observable<{ name?: string; title?: string }[]> =
     this.layersSubject.asObservable()
 
   protocolOptions: {

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field-spatial-extent/form-field-spatial-extent.component.html

@@ -8,8 +8,8 @@
   >
   </gn-ui-generic-keywords>
   <div class="w-full h-96 mt-2">
-    <gn-ui-form-field-map-container
+    <gn-ui-spatial-extent
       [spatialExtents]="spatialExtents$ | async"
-    ></gn-ui-form-field-map-container>
+    ></gn-ui-spatial-extent>
   </div>
 </div>

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field-spatial-extent/form-field-spatial-extent.component.ts

@@ -9,9 +9,9 @@ import { PlatformServiceInterface } from '../../../../../../../../../libs/common
 import { firstValueFrom, map, shareReplay } from 'rxjs'
 import { EditorFacade } from '../../../../+state/editor.facade'
 import { switchMap } from 'rxjs/operators'
-import { FormFieldMapContainerComponent } from '../form-field-map-container/form-field-map-container.component'
 import { TranslateModule, TranslateService } from '@ngx-translate/core'
 import { SPATIAL_SCOPES } from '../../../../fields.config'
+import { SpatialExtentComponent } from '../../../../../../../../../libs/ui/map/src'
 
 // This intermediary type will let us keep track of which keyword is bound to
 // which extent; these properties will not be persisted
@@ -35,8 +35,8 @@ type KeywordWithExtent = Keyword & {
   imports: [
     CommonModule,
     GenericKeywordsComponent,
-    FormFieldMapContainerComponent,
     TranslateModule,
+    SpatialExtentComponent,
   ],
 })
 export class FormFieldSpatialExtentComponent {

package/src/libs/feature/map/src/lib/utils/map-utils.service.ts

@@ -1,7 +1,6 @@
 import { Injectable } from '@angular/core'
 import { extend, Extent } from 'ol/extent'
 import GeoJSON from 'ol/format/GeoJSON'
-import { transformExtent } from 'ol/proj'
 import { CatalogRecord } from '../../../../../../libs/common/domain/src/lib/model/record'
 
 const GEOJSON = new GeoJSON()
@@ -15,7 +14,7 @@ export class MapUtilsService {
       return null
     }
     // extend all the spatial extents into an including bbox
-    const totalExtent = record.spatialExtents.reduce(
+    return record.spatialExtents.reduce(
       (prev, curr) => {
         if ('bbox' in curr) return extend(prev, curr.bbox)
         else if ('geometry' in curr) {
@@ -26,6 +25,5 @@ export class MapUtilsService {
       },
       [Infinity, Infinity, -Infinity, -Infinity]
     )
-    return transformExtent(totalExtent, 'EPSG:4326', 'EPSG:3857')
   }
 }

package/src/libs/feature/record/src/index.ts

@@ -1,5 +1,4 @@
 export * from './lib/feature-record.module'
-export * from './lib/gn-ui-version.token'
 export * from './lib/state'
 export * from './lib/data-view-permalink/data-view-permalink.component'
 export * from './lib/data-view/data-view.component'

package/src/libs/feature/record/src/lib/data-view-permalink/data-view-permalink.component.ts

@@ -9,10 +9,10 @@ import {
 import { Configuration } from '../../../../../../libs/data-access/gn4/src'
 import { BehaviorSubject, combineLatest, map } from 'rxjs'
 import { MdViewFacade } from '../state'
-import { GN_UI_VERSION } from '../gn-ui-version.token'
 import { CopyTextButtonComponent } from '../../../../../../libs/ui/inputs/src'
 import { CommonModule } from '@angular/common'
 import { TranslateModule } from '@ngx-translate/core'
+import { GEONETWORK_UI_TAG_NAME } from '../../../../../../libs/util/shared/src'
 
 export const WEB_COMPONENT_EMBEDDER_URL = new InjectionToken<string>(
   'webComponentEmbedderUrl'
@@ -40,7 +40,7 @@ export class DataViewPermalinkComponent {
   ]).pipe(
     map(([viewType, config, metadata]) => {
       const url = new URL(`${this.wcEmbedderBaseUrl}`, window.location.origin)
-      url.searchParams.set('v', `${this.version}`)
+      url.searchParams.set('v', `${GEONETWORK_UI_TAG_NAME}`)
       if (viewType === 'chart') {
         if (config) {
           const { aggregation, xProperty, yProperty, chartType } = config
@@ -74,7 +74,6 @@ export class DataViewPermalinkComponent {
     @Optional()
     @Inject(WEB_COMPONENT_EMBEDDER_URL)
     protected wcEmbedderBaseUrl: string,
-    @Inject(GN_UI_VERSION) private version: string,
     private facade: MdViewFacade
   ) {}
 }

package/src/libs/feature/record/src/lib/data-view-web-component/data-view-web-component.component.ts

@@ -7,10 +7,10 @@ import {
 import { Configuration } from '../../../../../../libs/data-access/gn4/src'
 import { MdViewFacade } from '../state'
 import { BehaviorSubject, combineLatest, map } from 'rxjs'
-import { GN_UI_VERSION } from '../gn-ui-version.token'
 import { CopyTextButtonComponent } from '../../../../../../libs/ui/inputs/src'
 import { CommonModule } from '@angular/common'
 import { TranslateModule } from '@ngx-translate/core'
+import { GEONETWORK_UI_TAG_NAME } from '../../../../../../libs/util/shared/src'
 
 @Component({
   selector: 'gn-ui-data-view-web-component',
@@ -36,7 +36,7 @@ export class DataViewWebComponentComponent {
         if (config) {
           const { aggregation, xProperty, yProperty, chartType } = config
           return `<script src="https://cdn.jsdelivr.net/gh/geonetwork/geonetwork-ui@wc-dist-${
-            this.version
+            GEONETWORK_UI_TAG_NAME
           }/gn-wc.js"></script>
   <gn-dataset-view-chart
           api-url="${new URL(
@@ -59,7 +59,7 @@ export class DataViewWebComponentComponent {
         return ''
       } else if (viewType === 'table') {
         return `<script src="https://cdn.jsdelivr.net/gh/geonetwork/geonetwork-ui@wc-dist-${
-          this.version
+          GEONETWORK_UI_TAG_NAME
         }/gn-wc.js"></script>
   <gn-dataset-view-table
           api-url="${new URL(
@@ -76,7 +76,7 @@ export class DataViewWebComponentComponent {
   ></gn-dataset-view-table>`
       } else {
         return `<script src="https://cdn.jsdelivr.net/gh/geonetwork/geonetwork-ui@wc-dist-${
-          this.version
+          GEONETWORK_UI_TAG_NAME
         }/gn-wc.js"></script>
 <gn-dataset-view-map
         api-url="${new URL(
@@ -97,7 +97,6 @@ export class DataViewWebComponentComponent {
 
   constructor(
     @Inject(Configuration) private config: Configuration,
-    @Inject(GN_UI_VERSION) private version: string,
     private facade: MdViewFacade
   ) {}
 }

package/src/libs/feature/record/src/lib/map-view/map-view.component.html

@@ -31,6 +31,7 @@
         #mapContainer
         [context]="mapContext$ | async"
         (featuresClick)="onMapFeatureSelect($event)"
+        (sourceLoadError)="onSourceLoadError($event)"
       ></gn-ui-map-container>
       <div
         class="top-[1em] right-[1em] p-3 bg-white absolute overflow-y-auto overflow-x-hidden max-h-72 w-56"

package/src/libs/feature/record/src/lib/map-view/map-view.component.ts

@@ -34,6 +34,7 @@ import {
   createViewFromLayer,
   MapContext,
   MapContextLayer,
+  SourceLoadErrorEvent,
 } from '@geospatial-sdk/core'
 import {
   FeatureDetailComponent,
@@ -49,16 +50,18 @@ import {
   ButtonComponent,
   DropdownSelectorComponent,
 } from '../../../../../../libs/ui/inputs/src'
-import { TranslateModule } from '@ngx-translate/core'
+import { TranslateModule, TranslateService } from '@ngx-translate/core'
 import { ExternalViewerButtonComponent } from '../external-viewer-button/external-viewer-button.component'
 import {
   LoadingMaskComponent,
   PopupAlertComponent,
 } from '../../../../../../libs/ui/widgets/src'
 import { marker } from '@biesbjerg/ngx-translate-extract-marker'
+import { FetchError } from '../../../../../../libs/util/data-fetcher/src'
 
 marker('map.dropdown.placeholder')
 marker('wfs.feature.limit')
+marker('dataset.error.restrictedAccess')
 
 @Component({
   selector: 'gn-ui-map-view',
@@ -100,9 +103,6 @@ export class MapViewComponent implements AfterViewInit {
 
   onLegendStatusChange(status: boolean) {
     this.legendExists = status
-    if (!status) {
-      this.showLegend = false
-    }
   }
 
   compatibleMapLinks$ = combineLatest([
@@ -146,11 +146,14 @@ export class MapViewComponent implements AfterViewInit {
       this.hidePreview = false
       this.loading = true
       this.error = null
+      if (link.accessRestricted) {
+        this.handleError('dataset.error.restrictedAccess')
+        return of([])
+      }
       return this.getLayerFromLink(link).pipe(
         map((layer) => [layer]),
         catchError((e) => {
-          this.error = e.message
-          console.warn(e.stack || e.message)
+          this.handleError(e)
           return of([])
         }),
         finalize(() => (this.loading = false))
@@ -192,7 +195,8 @@ export class MapViewComponent implements AfterViewInit {
     private mdViewFacade: MdViewFacade,
     private mapUtils: MapUtilsService,
     private dataService: DataService,
-    private changeRef: ChangeDetectorRef
+    private changeRef: ChangeDetectorRef,
+    private translateService: TranslateService
   ) {}
 
   async ngAfterViewInit() {
@@ -210,6 +214,16 @@ export class MapViewComponent implements AfterViewInit {
     this.changeRef.detectChanges()
   }
 
+  onSourceLoadError(error: SourceLoadErrorEvent) {
+    if (error.httpStatus === 403 || error.httpStatus === 401) {
+      this.error = this.translateService.instant(`dataset.error.forbidden`)
+    } else {
+      this.error = this.translateService.instant(`dataset.error.http`, {
+        info: error.httpStatus,
+      })
+    }
+  }
+
   resetSelection(): void {
     if (this.selection) {
       // FIXME: restore styling of selected feature
@@ -255,4 +269,24 @@ export class MapViewComponent implements AfterViewInit {
   selectLinkToDisplay(link: number) {
     this.selectedLinkIndex$.next(link)
   }
+
+  handleError(error: FetchError | Error | string) {
+    if (error instanceof FetchError) {
+      this.error = this.translateService.instant(
+        `dataset.error.${error.type}`,
+        {
+          info: error.info,
+        }
+      )
+      console.warn(error.message)
+    } else if (error instanceof Error) {
+      this.error = this.translateService.instant(error.message)
+      console.warn(error.stack || error)
+    } else {
+      this.error = this.translateService.instant(error)
+      console.warn(error)
+    }
+    this.loading = false
+    this.changeRef.detectChanges()
+  }
 }

package/src/libs/feature/record/src/lib/record-meta/record-meta.component.ts

@@ -6,7 +6,7 @@ import {
   OnDestroy,
 } from '@angular/core'
 import { Meta } from '@angular/platform-browser'
-import { DatasetRecord } from '../../../../../../libs/common/domain/src/lib/model/record'
+import { CatalogRecord } from '../../../../../../libs/common/domain/src/lib/model/record'
 
 @Component({
   selector: 'gn-ui-record-meta',
@@ -15,7 +15,7 @@ import { DatasetRecord } from '../../../../../../libs/common/domain/src/lib/mode
   standalone: true,
 })
 export class RecordMetaComponent implements OnDestroy, OnChanges {
-  @Input() metadata: DatasetRecord
+  @Input() metadata: CatalogRecord
 
   constructor(private meta: Meta) {}
 

package/src/libs/feature/record/src/lib/state/mdview.effects.ts

@@ -1,16 +1,18 @@
 import { Injectable } from '@angular/core'
 import { Actions, createEffect, ofType } from '@ngrx/effects'
 import { exhaustMap, mergeMap, of } from 'rxjs'
-import { catchError, filter, map, switchMap, take } from 'rxjs/operators'
+import { catchError, filter, map, switchMap } from 'rxjs/operators'
 import * as MdViewActions from './mdview.actions'
 import { RecordsRepositoryInterface } from '../../../../../../libs/common/domain/src/lib/repository/records-repository.interface'
 import { PlatformServiceInterface } from '../../../../../../libs/common/domain/src/lib/platform.service.interface'
+import { Router } from '@angular/router'
 @Injectable()
 export class MdViewEffects {
   constructor(
     private actions$: Actions,
     private recordsRepository: RecordsRepositoryInterface,
-    private platformServiceInterface: PlatformServiceInterface
+    private platformServiceInterface: PlatformServiceInterface,
+    private router: Router
   ) {}
 
   /*
@@ -21,7 +23,7 @@ export class MdViewEffects {
       ofType(MdViewActions.loadFullMetadata),
       switchMap(({ uuid }) => this.recordsRepository.getRecord(uuid)),
       map((record) => {
-        if (record === null) {
+        if (record === null || !this.router.url.includes(record.kind)) {
           return MdViewActions.loadFullMetadataFailure({ notFound: true })
         }
         return MdViewActions.loadFullMetadataSuccess({ full: record })

package/src/libs/feature/record/src/lib/state/mdview.facade.ts

@@ -16,6 +16,7 @@ import { DatavizConfigurationModel } from '../../../../../../libs/common/domain/
 import {
   CatalogRecord,
   DatasetServiceDistribution,
+  ServiceEndpoint,
   UserFeedback,
 } from '../../../../../../libs/common/domain/src/lib/model/record'
 import { AvatarServiceInterface } from '../../../../../../libs/api/repository/src'
@@ -79,11 +80,7 @@ export class MdViewFacade {
   chartConfig$ = this.store.pipe(select(MdViewSelectors.getChartConfig))
 
   allLinks$ = this.metadata$.pipe(
-    map((record) =>
-      record.kind === 'dataset' && 'onlineResources' in record
-        ? record.onlineResources
-        : []
-    )
+    map((record) => ('onlineResources' in record ? record.onlineResources : []))
   )
 
   apiLinks$ = this.allLinks$.pipe(
@@ -92,8 +89,8 @@ export class MdViewFacade {
         .filter((link) => this.linkClassifier.hasUsage(link, LinkUsage.API))
         // Put links to IGN Géoplateforme first
         .sort((dd1, dd2) => {
-          return (dd2 as DatasetServiceDistribution).accessServiceProtocol ===
-            'GPFDL'
+          return (dd2 as DatasetServiceDistribution | ServiceEndpoint)
+            .accessServiceProtocol === 'GPFDL'
             ? 1
             : undefined // do not change the sorting otherwise
         })

package/src/libs/feature/router/src/lib/default/constants.ts

@@ -4,6 +4,8 @@ export const ROUTER_STATE_KEY = 'router'
 
 export const ROUTER_ROUTE_SEARCH = 'search'
 export const ROUTER_ROUTE_DATASET = 'dataset'
+export const ROUTER_ROUTE_SERVICE = 'service'
+export const ROUTER_ROUTE_REUSE = 'reuse'
 export const ROUTER_ROUTE_ORGANIZATION = 'organization'
 
 export enum ROUTE_PARAMS {

package/src/libs/feature/router/src/lib/default/router.config.ts

@@ -4,6 +4,8 @@ export interface RouterConfigModel {
   searchStateId: string
   searchRouteComponent: Type<any>
   recordRouteComponent: Type<any>
+  serviceRouteComponent: Type<any>
+  reuseRouteComponent: Type<any>
   organizationRouteComponent: Type<any>
 }
 

package/src/libs/feature/router/src/lib/default/router.service.ts

@@ -3,6 +3,8 @@ import {
   ROUTER_ROUTE_DATASET,
   ROUTER_ROUTE_ORGANIZATION,
   ROUTER_ROUTE_SEARCH,
+  ROUTER_ROUTE_SERVICE,
+  ROUTER_ROUTE_REUSE,
 } from '.'
 import { Router, Routes } from '@angular/router'
 import { ROUTER_CONFIG, RouterConfigModel } from './router.config'
@@ -34,6 +36,14 @@ export class RouterService {
         path: `${ROUTER_ROUTE_DATASET}/:metadataUuid`,
         component: this.routerConfig.recordRouteComponent,
       },
+      {
+        path: `${ROUTER_ROUTE_SERVICE}/:metadataUuid`,
+        component: this.routerConfig.recordRouteComponent,
+      },
+      {
+        path: `${ROUTER_ROUTE_REUSE}/:metadataUuid`,
+        component: this.routerConfig.recordRouteComponent,
+      },
       {
         path: `${ROUTER_ROUTE_ORGANIZATION}/:name`,
         component: this.routerConfig.organizationRouteComponent,

package/src/libs/feature/router/src/lib/default/state/router.facade.ts

@@ -7,6 +7,8 @@ import { distinctUntilChanged, filter, map, take } from 'rxjs/operators'
 import {
   ROUTER_ROUTE_DATASET,
   ROUTER_ROUTE_SEARCH,
+  ROUTER_ROUTE_SERVICE,
+  ROUTER_ROUTE_REUSE,
   SearchRouteParams,
 } from '../constants'
 import {
@@ -32,12 +34,19 @@ export class RouterFacade {
     map(expandQueryParams)
   )
 
+  routeMap = {
+    dataset: ROUTER_ROUTE_DATASET,
+    service: ROUTER_ROUTE_SERVICE,
+    reuse: ROUTER_ROUTE_REUSE,
+  }
+
   constructor(
     private store: Store<RouterReducerState>,
     private routerService: RouterService
   ) {}
 
   goToMetadata(metadata: CatalogRecord) {
+    const selectedRoute = this.routeMap[metadata.kind] || ROUTER_ROUTE_DATASET
     this.pathParams$
       .pipe(
         take(1),
@@ -45,7 +54,7 @@ export class RouterFacade {
       )
       .subscribe(() => {
         this.go({
-          path: `${ROUTER_ROUTE_DATASET}/${metadata.uniqueIdentifier}`,
+          path: `${selectedRoute}/${metadata.uniqueIdentifier}`,
         })
         this.store.dispatch(
           MdViewActions.setIncompleteMetadata({ incomplete: metadata })

package/src/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.html

@@ -1,6 +1,6 @@
 <div class="flex flex-row items-center">
   <span
-    class="align-text-top mr-1.5"
+    class="align-text-top mr-1.5 mt-0.5"
     data-test="favorite-count"
     *ngIf="hasFavoriteCount && displayCount"
     >{{ favoriteCount }}</span
@@ -10,10 +10,4 @@
     (newValue)="toggleFavorite($event)"
     [disabled]="loading || (isAnonymous$ | async)"
   ></gn-ui-star-toggle>
-  <span
-    class="align-text-top ml-1.5"
-    data-test="favorite-count"
-    *ngIf="!displayCount"
-    translate="datahub.record.addToFavorites"
-  ></span>
 </div>

package/src/libs/feature/search/src/lib/favorites/favorite-star/favorite-star.component.ts

@@ -8,9 +8,15 @@ import {
   OnDestroy,
   ViewChild,
 } from '@angular/core'
-import { map, pairwise, withLatestFrom } from 'rxjs/operators'
+import {
+  map,
+  pairwise,
+  startWith,
+  switchMap,
+  withLatestFrom,
+} from 'rxjs/operators'
 import tippy from 'tippy.js'
-import { TranslateService } from '@ngx-translate/core'
+import { TranslateModule, TranslateService } from '@ngx-translate/core'
 import { StarToggleComponent } from '../../../../../../../libs/ui/inputs/src'
 import { Observable, Subscription } from 'rxjs'
 import { CatalogRecord } from '../../../../../../../libs/common/domain/src/lib/model/record'
@@ -24,7 +30,7 @@ import { CommonModule } from '@angular/common'
   styleUrls: ['./favorite-star.component.css'],
   changeDetection: ChangeDetectionStrategy.OnPush,
   standalone: true,
-  imports: [CommonModule, StarToggleComponent],
+  imports: [CommonModule, StarToggleComponent, TranslateModule],
 })
 export class FavoriteStarComponent implements AfterViewInit, OnDestroy {
   @Input() displayCount? = true
@@ -46,11 +52,13 @@ export class FavoriteStarComponent implements AfterViewInit, OnDestroy {
   favoriteCount: number | null
   loading = false
   loginUrl = this.authService.loginUrl
-  loginMessage$: Observable<string> = this.translateService.get(
-    'favorite.not.authenticated.tooltip',
-    {
-      link: this.loginUrl,
-    }
+  loginMessage$: Observable<string> = this.translateService.onLangChange.pipe(
+    startWith(null), // make sure to wait for translations to be loaded with and without language change
+    switchMap(() =>
+      this.translateService.get('favorite.not.authenticated.tooltip', {
+        link: this.loginUrl,
+      })
+    )
   )
   @ViewChild(StarToggleComponent, { read: ElementRef })
   starToggleRef: ElementRef