geonetwork-ui 2.5.0-dev.f8f8616a0 → 2.6.0-dev.01d2b5fc0

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field-contacts-for-resource/form-field-contacts-for-resource.component.ts

@@ -40,6 +40,7 @@ import {
   provideNgIconsConfig,
 } from '@ng-icons/core'
 import { iconoirPlus } from '@ng-icons/iconoir'
+import { RoleValues } from '../../../../../../../../../libs/common/domain/src/lib/model/record'
 
 @Component({
   selector: 'gn-ui-form-field-contacts-for-resource',
@@ -72,15 +73,11 @@ export class FormFieldContactsForResourceComponent
   @Output() valueChange: EventEmitter<Individual[]> = new EventEmitter()
 
   contactsForRessourceByRole: Map<Role, Individual[]> = new Map()
+  roleValues = RoleValues
 
-  rolesToPick: Role[] = [
-    'resource_provider',
-    'custodian',
-    'owner',
-    'point_of_contact',
-    'author',
-    'publisher',
-  ]
+  rolesToPick: Role[] = this.roleValues.filter(
+    (role) => role !== 'other' && role !== 'unspecified'
+  )
 
   roleSectionsToDisplay: Role[] = []
 
@@ -178,9 +175,11 @@ export class FormFieldContactsForResourceComponent
    * gn-ui-autocomplete
    */
   displayWithFn: (user: UserModel) => string = (user) =>
-    `${user.name} ${user.surname} ${
-      user.organisation ? `(${user.organisation})` : ''
-    }`
+    user.name
+      ? `${user.name} ${user.surname} ${
+          user.organisation ? `(${user.organisation})` : ''
+        }`
+      : ``
 
   /**
    * gn-ui-autocomplete

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field-overviews/form-field-overviews.component.ts

@@ -64,7 +64,7 @@ export class FormFieldOverviewsComponent {
             this.cd.detectChanges()
             this.emitOverview({
               url: event.attachment.url,
-              description: event.attachment.fileName,
+              description: event.attachment.fileName.replace(/\.[^/.]+$/, ''),
             })
           }
         },

package/src/libs/feature/search/src/lib/fuzzy-search/fuzzy-search.component.html

@@ -5,9 +5,11 @@
   (itemSelected)="handleItemSelection($event)"
   (inputSubmitted)="handleInputSubmission($event)"
   (inputCleared)="handleInputCleared()"
+  (isSearchActive)="handleSearchActive($event)"
   [value]="searchInputValue$ | async"
   [preventCompleteOnSelection]="true"
   [autoFocus]="autoFocus"
   [allowSubmit]="true"
   [forceTrackPosition]="forceTrackPosition"
+  [enterButton]="enterButton"
 ></gn-ui-autocomplete>

package/src/libs/feature/search/src/lib/fuzzy-search/fuzzy-search.component.ts

@@ -29,8 +29,10 @@ export class FuzzySearchComponent implements OnInit {
   @ViewChild(AutocompleteComponent) autocomplete: AutocompleteComponent
   @Input() autoFocus = false
   @Input() forceTrackPosition = false
+  @Input() enterButton = false
   @Output() itemSelected = new EventEmitter<CatalogRecord>()
   @Output() inputSubmitted = new EventEmitter<string>()
+  @Output() isSearchActive = new EventEmitter<boolean>()
   searchInputValue$: Observable<{ title: string }>
 
   displayWithFn: (record: CatalogRecord) => string = (record) => record.title
@@ -85,4 +87,8 @@ export class FuzzySearchComponent implements OnInit {
       this.searchService.updateFilters({ any: '' })
     }
   }
+
+  handleSearchActive(event: boolean) {
+    this.isSearchActive.emit(event)
+  }
 }

package/src/libs/ui/dataviz/src/lib/data-table/data-table.component.html

@@ -32,7 +32,9 @@
         mat-row
         *matRowDef="let row; columns: properties"
         (click)="selected.emit(row)"
-        [class.active]="row.id === activeId"
+        [class.active]="
+          activeId !== undefined && activeId !== null && row.id === activeId
+        "
       ></tr>
     </table>
     <gn-ui-loading-mask

package/src/libs/ui/elements/src/lib/image-input/image-input.component.html

@@ -11,10 +11,13 @@
       [value]="altText ?? ''"
       (valueChange)="handleAltTextChange($event)"
       extraClass="gn-ui-editor-textarea"
-      [disabled]="true"
     ></gn-ui-text-input>
     <div class="flex flex-row gap-2 mt-2">
-      <gn-ui-button type="gray" (buttonClick)="handleDelete()">
+      <gn-ui-button
+        type="gray"
+        (buttonClick)="handleDelete()"
+        data-cy="delete-image"
+      >
         <ng-icon class="me-1 text-primary" name="iconoirBin"></ng-icon>
         {{ 'input.image.delete' | translate }}
       </gn-ui-button>
@@ -38,20 +41,17 @@
       [ngClass]="{
         'border-primary-lighter bg-primary-white': dragFilesOver,
         'border-gray-300': !dragFilesOver,
-        'cursor-pointer hover:border-gray-500':
-          !isUploadInProgress && !uploadError && !showUrlInput && !disabled,
+        'cursor-pointer hover:border-gray-500': !getIsActionBlocked(),
         'cursor-not-allowed': disabled,
       }"
-      [attr.tabindex]="
-        isUploadInProgress || uploadError || showUrlInput || disabled ? null : 0
-      "
+      [attr.tabindex]="getIsActionBlocked() ? null : 0"
       (keydown.enter)="fileInput.click()"
       (dragFilesOver)="handleDragFilesOver($event)"
       (dropFiles)="handleDropFiles($event)"
     >
       <div
         class="w-14 h-14 rounded-md bg-gray-50 grid"
-        *ngIf="!isUploadInProgress && !uploadError"
+        *ngIf="!isUploadInProgress && !imageFileError"
       >
         <ng-icon
           *ngIf="!dragFilesOver"
@@ -66,7 +66,7 @@
       </div>
 
       <div
-        *ngIf="isUploadInProgress && !uploadError"
+        *ngIf="isUploadInProgress && !imageFileError"
         class="w-14 h-14 grid items-center justify-center relative"
       >
         <div class="text-gray-100 absolute">
@@ -88,19 +88,23 @@
         <span class="text-sm text-main font-bold">{{ uploadProgress }}%</span>
       </div>
 
-      <div class="w-14 h-14 rounded-md bg-gray-50 grid" *ngIf="uploadError">
+      <div class="w-14 h-14 rounded-md bg-gray-50 grid" *ngIf="imageFileError">
         <ng-icon
           name="iconoirMediaImageXmark"
           class="place-self-center text-rose-500"
+          data-cy="imgErrorIcon"
         ></ng-icon>
       </div>
 
       <div class="flex flex-col items-center gap-1">
-        <p class="font-medium">{{ getPrimaryText() | translate }}</p>
+        <p class="font-medium" data-cy="imgInputMsgPrimary">
+          {{ getPrimaryText() | translate }}
+        </p>
         <p
           class="text-sm"
+          data-cy="imgInputMsgSecondary"
           [class]="
-            isUploadInProgress || uploadError
+            isUploadInProgress
               ? 'font-bold text-blue-500 cursor-pointer'
               : 'font-medium text-gray-500'
           "
@@ -111,17 +115,17 @@
       </div>
       <input
         #fileInput
+        accept="image/*"
         type="file"
         class="hidden"
         (change)="handleFileInput($event)"
-        [disabled]="
-          showUrlInput || isUploadInProgress || uploadError || disabled
-        "
+        [disabled]="isUploadInProgress || disabled"
       />
     </label>
 
     <div *ngIf="!showUrlInput" class="flex-none mt-2">
       <gn-ui-button
+        data-cy="imgUrlBtn"
         (buttonClick)="displayUrlInput()"
         type="gray"
         [disabled]="disabled"
@@ -135,6 +139,7 @@
     <gn-ui-url-input
       *ngIf="showUrlInput"
       class="mt-3.5"
+      data-cy="imgUrlInput"
       (uploadClick)="downloadUrl($event)"
       [disabled]="isUploadInProgress || disabled"
     >

package/src/libs/ui/elements/src/lib/image-input/image-input.component.ts

@@ -66,9 +66,22 @@ import { ImageOverlayPreviewComponent } from '../image-overlay-preview/image-ove
   ],
 })
 export class ImageInputComponent {
-  @Input() maxSizeMB: number
+  private _altText?: string
+
   @Input() previewUrl?: string
-  @Input() altText?: string
+  @Input()
+  get altText(): string | undefined {
+    return this._altText
+  }
+  set altText(value: string | undefined) {
+    if (value !== 'KO' && this._altText === 'KO') {
+      //This is a dataset rollback after upload error
+      this.resetErrors()
+    }
+    this._altText = value
+  }
+
+  @Input() maxSizeMB: number
   @Input() uploadProgress?: number
   @Input() uploadError?: boolean
   @Input() disabled?: boolean = false
@@ -80,11 +93,9 @@ export class ImageInputComponent {
 
   dragFilesOver = false
   showUrlInput = false
-  downloadError = false
+  imageFileError = this.uploadError
   showAltTextInput = false
-
-  lastUploadType?: 'file' | 'url'
-  lastUploadContent?: string | File
+  pendingAltText: string
 
   get isUploadInProgress() {
     return this.uploadProgress !== undefined
@@ -95,8 +106,12 @@ export class ImageInputComponent {
     private cd: ChangeDetectorRef
   ) {}
 
+  getIsActionBlocked() {
+    return this.isUploadInProgress || this.disabled
+  }
+
   getPrimaryText() {
-    if (this.uploadError) {
+    if (this.imageFileError) {
       return marker('input.image.uploadErrorLabel')
     }
     if (this.uploadProgress) {
@@ -106,8 +121,8 @@ export class ImageInputComponent {
   }
 
   getSecondaryText() {
-    if (this.uploadError) {
-      return marker('input.image.uploadErrorRetry')
+    if (this.imageFileError) {
+      return '\u00A0' // (only to keep same spacing, next step is to handle "Retry")
     }
     if (this.uploadProgress) {
       return marker('input.image.uploadProgressCancel')
@@ -123,19 +138,26 @@ export class ImageInputComponent {
   }
 
   handleDropFiles(files: File[]) {
-    if (!this.showUrlInput) {
-      const validFiles = this.filterTypeImage(files)
-      if (validFiles.length > 0) {
-        this.resizeAndEmit(validFiles[0])
-      }
+    this.resetErrors()
+    const validFiles = this.filterTypeImage(files)
+    if (validFiles.length > 0) {
+      this.showUrlInput = false
+      this.resizeAndEmit(validFiles[0])
+    } else {
+      this.imageFileError = true
+      this.handleAltTextChange('KO')
     }
   }
 
   handleFileInput(event: Event) {
+    this.resetErrors()
     const inputFiles = Array.from((event.target as HTMLInputElement).files)
     const validFiles = this.filterTypeImage(inputFiles)
     if (validFiles.length > 0) {
       this.resizeAndEmit(validFiles[0])
+    } else {
+      this.imageFileError = true
+      this.handleAltTextChange('KO')
     }
   }
 
@@ -145,9 +167,8 @@ export class ImageInputComponent {
   }
 
   async downloadUrl(url: string) {
-    this.downloadError = false
+    this.resetErrors()
     const name = url.split('/').pop()
-
     try {
       const response = await firstValueFrom(
         this.http.head(url, { observe: 'response' })
@@ -164,47 +185,41 @@ export class ImageInputComponent {
             this.fileChange.emit(file)
           },
           error: () => {
-            this.downloadError = true
+            this.imageFileError = true
+            this.handleAltTextChange('KO')
             this.cd.markForCheck()
             this.urlChange.emit(url)
           },
         })
       }
     } catch {
-      this.downloadError = true
+      this.imageFileError = true
+      this.handleAltTextChange('KO')
       this.cd.markForCheck()
       return
     }
   }
 
   handleSecondaryTextClick(event: Event) {
-    if (this.uploadError) {
-      this.handleRetry()
-    } else if (this.uploadProgress) {
-      this.handleCancel()
+    if (this.uploadProgress) {
+      this.handleCancelUpload()
       event.preventDefault()
     }
   }
 
-  handleCancel() {
+  handleCancelUpload() {
     this.uploadCancel.emit()
   }
 
-  handleRetry() {
-    switch (this.lastUploadType) {
-      case 'file':
-        this.fileChange.emit(this.lastUploadContent as File)
-        break
-      case 'url':
-        this.urlChange.emit(this.lastUploadContent as string)
-        break
-    }
-  }
-
   handleDelete() {
     this.delete.emit()
   }
 
+  resetErrors() {
+    this.imageFileError = false
+    this.uploadError = false
+  }
+
   toggleAltTextInput() {
     this.showAltTextInput = !this.showAltTextInput
   }
@@ -212,7 +227,6 @@ export class ImageInputComponent {
   handleAltTextChange(altText: string) {
     this.altTextChange.emit(altText)
   }
-
   private filterTypeImage(files: File[]) {
     return files.filter((file) => {
       return file.type.startsWith('image/')

package/src/libs/ui/elements/src/lib/metadata-quality/metadata-quality.component.html

@@ -1,13 +1,25 @@
 <div *ngIf="metadataQualityDisplay" class="mb-6 metadata-quality">
-  <gn-ui-popover [content]="popoverItems" theme="light-border">
-    <div class="min-w-[200px]" [class]="smaller ? 'leading-[8px]' : ''">
-      <gn-ui-progress-bar
-        tabindex="0"
-        [value]="qualityScore"
-        type="primary"
-      ></gn-ui-progress-bar>
-    </div>
-  </gn-ui-popover>
+  <div
+    class="flex items-center"
+    [class]="smaller ? 'leading-[8px] min-w-[120px]' : 'min-w-[200px]'"
+  >
+    <gn-ui-progress-bar
+      tabindex="0"
+      [value]="qualityScore"
+      [type]="'light'"
+      class="flex-grow"
+    ></gn-ui-progress-bar>
+    <gn-ui-popover
+      [content]="popoverItems"
+      theme="light-border"
+      [class]="smaller ? 'ml-2' : 'ml-2 mt-1'"
+    >
+      <ng-icon
+        name="matInfoOutline"
+        class="flex-shrink-0 text-gray-600"
+      ></ng-icon>
+    </gn-ui-popover>
+  </div>
 </div>
 <ng-template #popoverItems>
   <div class="p-2 py-4">

package/src/libs/ui/elements/src/lib/metadata-quality/metadata-quality.component.ts

@@ -16,6 +16,9 @@ import {
 } from '../../../../../../libs/ui/widgets/src'
 import { CommonModule } from '@angular/common'
 import { TranslateModule } from '@ngx-translate/core'
+import { NgIcon } from '@ng-icons/core'
+import { matInfoOutline } from '@ng-icons/material-icons/outline'
+import { provideIcons, provideNgIconsConfig } from '@ng-icons/core'
 
 @Component({
   selector: 'gn-ui-metadata-quality',
@@ -29,6 +32,16 @@ import { TranslateModule } from '@ngx-translate/core'
     ProgressBarComponent,
     MetadataQualityItemComponent,
     TranslateModule,
+    NgIcon,
+  ],
+  providers: [
+    provideIcons({
+      matInfoOutline,
+    }),
+    provideNgIconsConfig({
+      size: '1.2em',
+      strokeWidth: '1.5px',
+    }),
   ],
 })
 export class MetadataQualityComponent implements OnChanges {

package/src/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.html

@@ -5,31 +5,48 @@
   >
     <ng-icon name="iconoirSearch" class="text-primary search"></ng-icon>
   </div>
-  <input
-    #searchInput
-    type="text"
-    class="gn-ui-text-input"
-    [ngClass]="{
-      'px-[--icon-width]': !allowSubmit,
-    }"
-    [placeholder]="placeholder"
-    [formControl]="control"
-    [matAutocomplete]="auto"
-    (keyup.enter)="handleEnter(searchInput.value)"
-  />
+  <div class="flex flex-row">
+    <input
+      #searchInput
+      type="text"
+      class="gn-ui-text-input"
+      (input)="handleInput($event)"
+      [placeholder]="placeholder"
+      [formControl]="control"
+      [matAutocomplete]="auto"
+      (keyup.enter)="handleEnter(searchInput.value)"
+      [ngClass]="{
+        'text-primary': searchActive && enterButton,
+        'text-gray-900': !searchActive,
+        'px-[--icon-width]': !allowSubmit,
+      }"
+    />
+    <gn-ui-button
+      type="gray"
+      *ngIf="searchInput.value && displayEnterBtn"
+      extraClass="w-32 h-8 !opacity-100"
+      [ngStyle]="{ left: enterBtnPosition + 'px' }"
+      class="absolute"
+      disabled="true"
+    >
+      <ng-icon
+        name="iconoirLongArrowDownLeft"
+        class="!w-4 text-gray-900 font-bold"
+      ></ng-icon>
+      <span translate class="text-bold text-gray-900 font-bold">
+        Enter to search
+      </span>
+    </gn-ui-button>
+  </div>
   <gn-ui-button
-    type="light"
-    extraClass="border-0 text-primary-lightest hover:text-primary focus:text-primary absolute inset-y-[--icon-padding] {{
-      allowSubmit
-        ? 'right-[calc(var(--icon-width)+var(--icon-padding))]'
-        : 'right-[--icon-padding]'
-    }}"
+    type="primary"
+    [extraClass]="getExtraClass()"
     data-test="clear-btn"
     *ngIf="searchInput.value"
     aria-label="Clear"
     (buttonClick)="clear()"
   >
-    <ng-icon name="matClose"></ng-icon>
+    <ng-icon class="text-white" name="matClose"></ng-icon>
   </gn-ui-button>
   <gn-ui-button
     type="light"

package/src/libs/ui/inputs/src/lib/autocomplete/autocomplete.component.ts

@@ -41,7 +41,7 @@ import {
   provideIcons,
   provideNgIconsConfig,
 } from '@ng-icons/core'
-import { iconoirSearch } from '@ng-icons/iconoir'
+import { iconoirLongArrowDownLeft, iconoirSearch } from '@ng-icons/iconoir'
 import { matClose } from '@ng-icons/material-icons/baseline'
 
 export type AutocompleteItem = unknown
@@ -65,9 +65,10 @@ export type AutocompleteItem = unknown
     provideIcons({
       iconoirSearch,
       matClose,
+      iconoirLongArrowDownLeft,
     }),
     provideNgIconsConfig({
-      size: '1.5rem',
+      size: '1.75rem',
     }),
   ],
 })
@@ -75,6 +76,7 @@ export class AutocompleteComponent
   implements OnInit, AfterViewInit, OnDestroy, OnChanges
 {
   @Input() placeholder: string
+  @Input() enterButton = false
   @Input() action: (value: string) => Observable<AutocompleteItem[]>
   @Input() value?: AutocompleteItem
   @Input() clearOnSelection = false
@@ -87,6 +89,7 @@ export class AutocompleteComponent
   @Output() itemSelected = new EventEmitter<AutocompleteItem>()
   @Output() inputSubmitted = new EventEmitter<string>()
   @Output() inputCleared = new EventEmitter<void>()
+  @Output() isSearchActive = new EventEmitter<boolean>()
   @ViewChild(MatAutocompleteTrigger) triggerRef: MatAutocompleteTrigger
   @ViewChild(MatAutocomplete) autocomplete: MatAutocomplete
   @ViewChild('searchInput') inputRef: ElementRef<HTMLInputElement>
@@ -101,15 +104,36 @@ export class AutocompleteComponent
   subscription = new Subscription()
   private lastPosition: DOMRect | null = null
   private intervalIdPosition: number | undefined
+  enterBtnPosition = 0
+  searchActive = false
 
   @Input() displayWithFn: (item: AutocompleteItem) => string = (item) =>
     item.toString()
 
+  get displayEnterBtn() {
+    return this.enterButton && this.allowSubmit && !this.searchActive
+  }
+
   displayWithFnInternal = (item?: AutocompleteItem) => {
     if (item === null || item === undefined) return null
     return this.displayWithFn(item)
   }
 
+  getExtraClass(): string {
+    if (this.allowSubmit) {
+      if (this.enterButton) {
+        return 'border rounded-lg absolute w-8 h-8 right-[calc(var(--icon-width)+var(--icon-padding))] inset-y-[--icon-padding]'
+      } else {
+        return 'border rounded-lg absolute w-8 h-8 right-[calc(var(--icon-width)+0.25*var(--icon-width))] inset-y-[calc(0.25*var(--icon-width))]'
+      }
+    } else {
+      if (!this.enterButton) {
+        return 'border rounded-lg absolute w-8 h-8 right-2 inset-y-2'
+      }
+    }
+    return 'border rounded-lg absolute w-8 h-8'
+  }
+
   constructor(private cdRef: ChangeDetectorRef) {}
   ngOnChanges(changes: SimpleChanges): void {
     const { value } = changes
@@ -117,6 +141,13 @@ export class AutocompleteComponent
       const previousTextValue = this.displayWithFnInternal(value.previousValue)
       const currentTextValue = this.displayWithFnInternal(value.currentValue)
       if (previousTextValue !== currentTextValue) {
+        if (currentTextValue) {
+          this.searchActive = true
+          this.isSearchActive.emit(true)
+        } else {
+          this.searchActive = false
+          this.isSearchActive.emit(false)
+        }
         this.updateInputValue(value.currentValue)
       }
     }
@@ -256,6 +287,8 @@ export class AutocompleteComponent
 
   clear(): void {
     this.inputRef.nativeElement.value = ''
+    this.searchActive = false
+    this.isSearchActive.emit(false)
     this.inputCleared.emit()
     this.selectionSubject
       .pipe(take(1))
@@ -265,6 +298,8 @@ export class AutocompleteComponent
 
   handleEnter(any: string) {
     if (!this.cancelEnter && this.allowSubmit) {
+      this.isSearchActive.emit(true)
+      this.searchActive = true
       this.inputSubmitted.emit(any)
     }
   }
@@ -294,4 +329,10 @@ export class AutocompleteComponent
       this.control.setValue('')
     }
   }
+
+  handleInput(event: InputEvent) {
+    this.searchActive = false
+    this.isSearchActive.emit(false)
+    this.enterBtnPosition = event.target['value'].length * 8 + 80
+  }
 }

package/src/libs/ui/inputs/src/lib/url-input/url-input.component.ts

@@ -31,7 +31,7 @@ import { iconoirArrowUp, iconoirLink } from '@ng-icons/iconoir'
   ],
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
-export class UrlInputComponent {
+export class UrlInputComponent implements OnChanges {
   @Input() set value(v: string) {
     // we're making sure to only update the input if the URL representation of it has changed; otherwise we keep it identical
     // to avoid glitches when starting to write a URL and having some characters added/replaced automatically
@@ -48,6 +48,7 @@ export class UrlInputComponent {
   @Input() placeholder = 'https://'
   @Input() disabled: boolean
   @Input() showValidateButton = true
+  @Input() resetUrlOnChange: number
 
   /**
    * This will emit null if the field is emptied
@@ -59,6 +60,12 @@ export class UrlInputComponent {
 
   constructor(private cd: ChangeDetectorRef) {}
 
+  ngOnChanges(changes: SimpleChanges) {
+    if (changes['resetUrlOnChange']) {
+      this.inputValue = ''
+    }
+  }
+
   handleInput(event: Event) {
     const value = (event.target as HTMLInputElement).value
     this.inputValue = value

package/src/libs/ui/search/src/lib/record-preview-row/record-preview-row.component.html

@@ -64,7 +64,7 @@
       class="col-start-2 row-start-4 sm:row-start-3 absolute right-[4em] sm:right-[5em]"
     >
       <gn-ui-metadata-quality
-        smaller="true"
+        [smaller]="true"
         [metadata]="record"
         [metadataQualityDisplay]="metadataQualityDisplay"
       ></gn-ui-metadata-quality>