geonetwork-ui 2.11.0-dev.80a8b0bfa → 2.11.0-dev.840dcc932

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.html

@@ -7,23 +7,22 @@
   ></gn-ui-form-field-open-data>
 </ng-container> -->
 <div class="flex flex-col h-full">
-  <ng-container *ngIf="withoutWrapper; else withGenericWrapper">
+  @if (withoutWrapper) {
     <ng-container *ngTemplateOutlet="fieldContent"></ng-container>
-  </ng-container>
-  <ng-template #withGenericWrapper>
+  } @else {
     <gn-ui-form-field-wrapper
       [label]="config.labelKey! | translate: { recordKind }"
       [hint]="config.hintKey! | translate: { recordKind }"
     >
       <ng-container *ngTemplateOutlet="fieldContent"></ng-container>
     </gn-ui-form-field-wrapper>
-  </ng-template>
+  }
 </div>
 
 <ng-template #fieldContent>
-  <ng-container [ngSwitch]="model">
-    <ng-container *ngSwitchCase="'title'">
-      <div class="flex flex-row flex-start items-center gap-3 mb-[12px]">
+  @switch (model) {
+    @case ('title') {
+      <div class="flex flex-row flex-start items-center gap-3">
         <textarea
           #titleInput
           cdkTextareaAutosize
@@ -45,158 +44,171 @@
             class="m-2 cursor-pointer"
             (click)="focusTitleInput()"
           ></ng-icon>
-          <ng-icon
-            *ngIf="config.hintKey"
-            name="matHelpOutline"
-            size="16"
-            class="m-2"
-            [matTooltip]="config.hintKey! | translate: { recordKind }"
-            matTooltipPosition="above"
-          ></ng-icon>
+          @if (config.hintKey) {
+            <ng-icon
+              name="matHelpOutline"
+              size="16"
+              class="m-2"
+              [matTooltip]="config.hintKey! | translate: { recordKind }"
+              matTooltipPosition="above"
+            ></ng-icon>
+          }
         </div>
       </div>
-    </ng-container>
-    <ng-container *ngSwitchCase="'abstract'">
+    }
+    @case ('abstract') {
       <gn-ui-form-field-rich
         [label]="config.labelKey! | translate: { recordKind }"
         [hint]="config.hintKey! | translate: { recordKind }"
         [value]="valueAsString"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-rich>
-    </ng-container>
-    <ng-container *ngSwitchCase="'overviews'">
+    }
+    @case ('overviews') {
       <gn-ui-form-field-overviews
         [metadataUuid]="uniqueIdentifier"
         [recordKind]="recordKind"
         [value]="valueAsOverviews"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-overviews>
-    </ng-container>
-    <ng-container *ngSwitchCase="'resourceIdentifiers'">
+    }
+    @case ('resourceIdentifiers') {
       <gn-ui-form-field-simple
         [type]="'text'"
         [value]="valueAsResourceIdentifierCode"
         (valueChange)="handleResourceIdentifierChange($event)"
       ></gn-ui-form-field-simple>
-    </ng-container>
-    <ng-container *ngSwitchCase="'resourceCreated'">
+    }
+    @case ('resourceCreated') {
       <gn-ui-form-field-date
         [value]="valueAsDate"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-date>
-    </ng-container>
-    <ng-container *ngSwitchCase="'resourceUpdated'">
+    }
+    @case ('resourceUpdated') {
       <gn-ui-form-field-date
         [value]="valueAsDate"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-date>
-    </ng-container>
-    <ng-container *ngSwitchCase="'updateFrequency'">
+    }
+    @case ('updateFrequency') {
       <gn-ui-form-field-update-frequency
         [value]="valueAsUpdateFrequency"
         (valueChange)="valueChange.emit($event)"
         [recordKind]="recordKind"
       ></gn-ui-form-field-update-frequency>
-    </ng-container>
-    <ng-container *ngSwitchCase="'associatedRecords'">
+    }
+    @case ('associatedRecords') {
       <gn-ui-form-field-associated-records
         [value]="valueAsAssociatedRecords"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-associated-records>
-    </ng-container>
-    <ng-container *ngSwitchCase="'temporalExtents'">
+    }
+    @case ('temporalExtents') {
       <gn-ui-form-field-temporal-extents
         [value]="valueAsTemporalExtents"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-temporal-extents>
-    </ng-container>
-    <ng-container *ngSwitchCase="'spatialExtents'">
+    }
+    @case ('spatialExtents') {
       <gn-ui-form-field-spatial-extent></gn-ui-form-field-spatial-extent>
-    </ng-container>
-    <ng-container *ngSwitchCase="'keywords'">
+    }
+    @case ('keywords') {
       <gn-ui-form-field-keywords
         [value]="valueAsKeywords"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-keywords>
-    </ng-container>
-    <ng-container *ngSwitchCase="'topics'">
+    }
+    @case ('topics') {
       <gn-ui-form-field-topics
         [value]="valueAsTopics"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-topics>
-    </ng-container>
-    <ng-container *ngSwitchCase="'licenses'">
+    }
+    @case ('licenses') {
       <gn-ui-form-field-license
         [label]="config.labelKey! | translate: { recordKind }"
         [recordLicences]="valueAsConstraints"
         (recordLicencesChange)="valueChange.emit($event)"
       ></gn-ui-form-field-license>
-    </ng-container>
+    }
 
-    <ng-container *ngSwitchCase="'legalConstraints'">
-      <ng-container *ngTemplateOutlet="formFieldConstraints"></ng-container>
-    </ng-container>
-    <ng-container *ngSwitchCase="'securityConstraints'">
-      <ng-container *ngTemplateOutlet="formFieldConstraints"></ng-container>
-    </ng-container>
-    <ng-container *ngSwitchCase="'otherConstraints'">
-      <ng-container *ngTemplateOutlet="formFieldConstraints"></ng-container
-    ></ng-container>
-    <ng-template #formFieldConstraints>
+    <!-- TODO: merge these cases together when migrated to angular 21 -->
+    @case ('legalConstraints') {
+      <gn-ui-form-field-constraints
+        [label]="config.labelKey"
+        [value]="valueAsConstraints"
+        [constraintType]="model"
+        (valueChange)="valueChange.emit($event)"
+      ></gn-ui-form-field-constraints>
+    }
+    @case ('securityConstraints') {
+      <gn-ui-form-field-constraints
+        [label]="config.labelKey"
+        [value]="valueAsConstraints"
+        [constraintType]="model"
+        (valueChange)="valueChange.emit($event)"
+      ></gn-ui-form-field-constraints>
+    }
+    @case ('otherConstraints') {
       <gn-ui-form-field-constraints
         [label]="config.labelKey"
         [value]="valueAsConstraints"
         [constraintType]="model"
         (valueChange)="valueChange.emit($event)"
-      ></gn-ui-form-field-constraints
-    ></ng-template>
+      ></gn-ui-form-field-constraints>
+    }
 
-    <ng-container *ngSwitchCase="'contactsForResource'">
+    @case ('contactsForResource') {
       <gn-ui-form-field-contacts-for-resource
         [value]="valueAsIndividuals"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-contacts-for-resource>
-    </ng-container>
-    <ng-container *ngSwitchCase="'contacts'">
+    }
+    @case ('contacts') {
       <gn-ui-form-field-contacts
         [value]="valueAsIndividuals"
         [modelSpecifier]="modelSpecifier"
         (valueChange)="valueChange.emit($event)"
       ></gn-ui-form-field-contacts>
-    </ng-container>
-    <ng-container *ngSwitchCase="'onlineResources'">
-      <gn-ui-form-field-online-resources
-        *ngIf="modelSpecifier === 'onlineResourceType:!link'"
-        [metadataUuid]="uniqueIdentifier"
-        [value]="valueAsOnlineResources"
-        (valueChange)="valueChange.emit($event)"
-      ></gn-ui-form-field-online-resources>
-    </ng-container>
-    <ng-container *ngSwitchCase="'onlineResources'">
-      <gn-ui-form-field-online-link-resources
-        *ngIf="modelSpecifier === 'onlineResourceType:link'"
-        [metadataUuid]="uniqueIdentifier"
-        [value]="valueAsOnlineResources"
-        (valueChange)="valueChange.emit($event)"
-      ></gn-ui-form-field-online-link-resources>
-    </ng-container>
-    <ng-container *ngSwitchCase="'onlineResources'">
-      <gn-ui-form-field-online-single-link-resource
-        *ngIf="modelSpecifier === 'onlineResourceType:singleLink'"
-        [value]="valueAsOnlineResources"
-        (valueChange)="valueChange.emit($event)"
-      ></gn-ui-form-field-online-single-link-resource>
-    </ng-container>
-  </ng-container>
+    }
+    @case ('onlineResources') {
+      @if (modelSpecifier === 'onlineResourceType:!link') {
+        <gn-ui-form-field-online-resources
+          [metadataUuid]="uniqueIdentifier"
+          [value]="valueAsOnlineResources"
+          (valueChange)="valueChange.emit($event)"
+        ></gn-ui-form-field-online-resources>
+      } @else if (modelSpecifier === 'onlineResourceType:link') {
+        <gn-ui-form-field-online-link-resources
+          [metadataUuid]="uniqueIdentifier"
+          [value]="valueAsOnlineResources"
+          (valueChange)="valueChange.emit($event)"
+        ></gn-ui-form-field-online-link-resources>
+      } @else if (modelSpecifier === 'onlineResourceType:singleLink') {
+        <gn-ui-form-field-online-single-link-resource
+          [value]="valueAsOnlineResources"
+          (valueChange)="valueChange.emit($event)"
+        ></gn-ui-form-field-online-single-link-resource>
+      }
+    }
+    @case ('flags') {
+      <gn-ui-form-field-record-flag
+        [flagName]="recordFlag"
+        [labelKey]="config.labelKey"
+        [hintKey]="config.hintKey"
+      ></gn-ui-form-field-record-flag>
+    }
+  }
 
-  <ng-container *ngIf="!model">
-    <ng-container [ngSwitch]="componentName">
-      <ng-container *ngSwitchCase="'form-field-constraints-shortcuts'">
+  @if (!model) {
+    @switch (componentName) {
+      @case ('form-field-constraints-shortcuts') {
         <gn-ui-form-field-constraints-shortcuts></gn-ui-form-field-constraints-shortcuts>
-      </ng-container>
-      <ng-container *ngSwitchCase="'form-field-spatial-toggle'">
+      }
+      @case ('form-field-spatial-toggle') {
         <gn-ui-form-field-spatial-toggle></gn-ui-form-field-spatial-toggle>
-      </ng-container>
-    </ng-container>
-  </ng-container>
+      }
+    }
+  }
 </ng-template>

package/src/libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.ts

@@ -12,13 +12,13 @@ import {
 import { MatTooltipModule } from '@angular/material/tooltip'
 import {
   AssociatedRecord,
-  CatalogRecordKeys,
   Constraint,
   DatasetTemporalExtent,
   GraphicOverview,
   Individual,
   Keyword,
   OnlineResource,
+  RecordFlag,
   RecordKind,
   UpdateFrequency,
 } from '../../../../../../../../libs/common/domain/src/lib/model/record'
@@ -36,9 +36,10 @@ import {
   FormFieldTemporalExtentsComponent,
 } from '.'
 import {
-  FieldModelSpecifier,
   FormFieldComponentName,
   FormFieldConfig,
+  FormFieldModel,
+  FormFieldModelSpecifier,
 } from '../../../models'
 import { FormFieldAssociatedRecordsComponent } from './form-field-associated-records/form-field-associated-records.component'
 import { FormFieldContactsForResourceComponent } from './form-field-contacts-for-resource/form-field-contacts-for-resource.component'
@@ -57,6 +58,7 @@ import { FormFieldConstraintsComponent } from './form-field-constraints/form-fie
 import { TextFieldModule } from '@angular/cdk/text-field'
 import { FormFieldSpatialToggleComponent } from './form-field-spatial-toggle/form-field-spatial-toggle.component'
 import { FormFieldTopicsComponent } from './form-field-topics/form-field-topics.component'
+import { FormFieldRecordFlagComponent } from './form-field-record-flags/form-field-record-flag-component'
 
 @Component({
   selector: 'gn-ui-form-field',
@@ -90,6 +92,7 @@ import { FormFieldTopicsComponent } from './form-field-topics/form-field-topics.
     FormFieldTopicsComponent,
     TextFieldModule,
     NgIconComponent,
+    FormFieldRecordFlagComponent,
   ],
   providers: [provideIcons({ matEditOutline, matHelpOutline })],
   hostDirectives: [FieldFocusDirective],
@@ -97,8 +100,8 @@ import { FormFieldTopicsComponent } from './form-field-topics/form-field-topics.
 export class FormFieldComponent {
   @Input() uniqueIdentifier: string
   @Input() recordKind: RecordKind
-  @Input() model: CatalogRecordKeys
-  @Input() modelSpecifier: FieldModelSpecifier
+  @Input() model: FormFieldModel
+  @Input() modelSpecifier: FormFieldModelSpecifier
   @Input() componentName: FormFieldComponentName
 
   @Input() config: FormFieldConfig
@@ -126,6 +129,7 @@ export class FormFieldComponent {
       this.model === 'legalConstraints' ||
       this.model === 'securityConstraints' ||
       this.model === 'otherConstraints' ||
+      this.model === 'flags' ||
       this.componentName === 'form-field-constraints-shortcuts'
     )
   }
@@ -172,6 +176,9 @@ export class FormFieldComponent {
     }>
     return identifiers?.[0]?.code || ''
   }
+  get recordFlag() {
+    return this.modelSpecifier?.replace(/^flags:/, '') as RecordFlag
+  }
 
   handleResourceIdentifierChange(code: string) {
     const identifiers = this.value as Array<{

package/src/libs/feature/editor/src/lib/components/record-form/record-form.component.ts

@@ -11,7 +11,7 @@ import {
   viewChildren,
 } from '@angular/core'
 import { EditorFacade } from '../../+state/editor.facade'
-import { EditorFieldValue } from '../../models'
+import { EditorFieldValue, FormFieldModel } from '../../models'
 import { FieldFocusDirective, FormFieldComponent } from './form-field'
 import { TranslateDirective } from '@ngx-translate/core'
 import {
@@ -24,6 +24,7 @@ import { switchMap } from 'rxjs/operators'
 import { toSignal } from '@angular/core/rxjs-interop'
 import { evaluate, isExpression } from '../../expressions'
 import { NotificationsService } from '../../../../../../../libs/feature/notifications/src'
+import { PlatformServiceInterface } from '../../../../../../../libs/common/domain/src/lib/platform.service.interface'
 
 @Component({
   selector: 'gn-ui-record-form',
@@ -41,6 +42,7 @@ import { NotificationsService } from '../../../../../../../libs/feature/notifica
 export class RecordFormComponent implements OnInit, OnDestroy {
   facade = inject(EditorFacade)
   notifications = inject(NotificationsService)
+  platform = inject(PlatformServiceInterface)
   subscription = new Subscription()
 
   recordUniqueIdentifier$ = this.facade.record$.pipe(
@@ -90,8 +92,8 @@ export class RecordFormComponent implements OnInit, OnDestroy {
     this.subscription.unsubscribe()
   }
 
-  handleFieldValueChange(model: CatalogRecordKeys, newValue: EditorFieldValue) {
-    if (!model) {
+  handleFieldValueChange(model: FormFieldModel, newValue: EditorFieldValue) {
+    if (!model || model === 'flags') {
       return
     }
     this.facade.updateRecordField(model, newValue)
@@ -122,6 +124,8 @@ export class RecordFormComponent implements OnInit, OnDestroy {
   }
 
   private recordSignal = toSignal(this.facade.record$, { requireSync: true })
+  private userSignal = toSignal(this.platform.getMe())
+  private isAdminSignal = toSignal(this.platform.isAdministrator())
   private expressionCache = new Map<string, Signal<EditorFieldValue>>()
 
   // only compiles the expression into an evaluator the first time;
@@ -149,7 +153,17 @@ ${errors.map((err) => `> ${err}`).join('\n')}`)
     }
     this.expressionCache.set(
       expression,
-      computed(() => evaluator({ globals: { record: this.recordSignal() } }))
+      computed(() =>
+        evaluator({
+          globals: {
+            record: this.recordSignal(),
+            user: {
+              ...this.userSignal(),
+              isAdmin: this.isAdminSignal(),
+            },
+          },
+        })
+      )
     )
     return this.expressionCache.get(expression)
   }

package/src/libs/feature/editor/src/lib/expressions.ts

@@ -17,10 +17,14 @@ const TOKEN_OPERATOR_LOGICAL = ['==', '!=']
 const TOKEN_STRING_LITERAL = ["'", '"']
 const TOKEN_GROUP_START = '('
 const TOKEN_GROUP_END = ')'
+const TOKEN_OPERATOR_BOOLEAN = ['&&', '||']
+const TOKEN_OPERATOR_NOT = '!'
 
 // See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_precedence
 const OPERATORS_BY_PRECEDENCE: string[][] = [
   [TOKEN_OPERATOR_TERNARY_FIRST, TOKEN_OPERATOR_TERNARY_SECOND],
+  TOKEN_OPERATOR_BOOLEAN,
+  [TOKEN_OPERATOR_NOT],
   TOKEN_OPERATOR_LOGICAL,
 ]
 const ALL_OPERATORS = OPERATORS_BY_PRECEDENCE.flat()
@@ -161,6 +165,18 @@ function evaluateInternal(
       continue
     }
 
+    // BOOLEAN LITERAL
+    const isBooleanLiteral =
+      readNext(expression, pos, 4) === 'true' ||
+      readNext(expression, pos, 5) === 'false'
+    if (isBooleanLiteral) {
+      const literal = readNext(expression, pos, 4) === 'true' ? 'true' : 'false'
+      pos += literal.length
+      const booleanLiteral = literal === 'true'
+      currentEvaluator = () => booleanLiteral
+      continue
+    }
+
     // SYMBOL (NAME)
     const isSymbol = /[a-zA-Z]/.test(readNext(expression, pos))
     if (isSymbol) {
@@ -291,6 +307,57 @@ function evaluateInternal(
       continue
     }
 
+    // BOOLEAN OPERATORS
+    const isBooleanOperator = TOKEN_OPERATOR_BOOLEAN.some(
+      (token) => readNext(expression, pos, token.length) === token
+    )
+    if (isBooleanOperator) {
+      const matchingOperator = TOKEN_OPERATOR_BOOLEAN.find(
+        (token) => readNext(expression, pos, token.length) === token
+      )
+      const isAnd = matchingOperator === '&&'
+      pos += matchingOperator.length
+      const leftEvaluator = currentEvaluator
+      const rightExpression = readUntilNextOperator(
+        expression,
+        pos,
+        matchingOperator
+      )
+      pos += rightExpression.length
+      const rightEvaluator = evaluateInternal(
+        rightExpression,
+        currentContext
+      ).evaluator
+
+      currentEvaluator = (context) => {
+        return isAnd
+          ? Boolean(leftEvaluator(context) && rightEvaluator(context))
+          : Boolean(leftEvaluator(context) || rightEvaluator(context))
+      }
+      continue
+    }
+
+    // PREFIX OPERATORS
+    const isNotOperator = readNext(expression, pos) === TOKEN_OPERATOR_NOT
+    if (isNotOperator) {
+      pos++
+      const operandExpression = readUntilNextOperator(
+        expression,
+        pos,
+        TOKEN_OPERATOR_NOT
+      )
+      pos += operandExpression.length
+      const operandEvaluator = evaluateInternal(
+        operandExpression,
+        currentContext
+      ).evaluator
+
+      currentEvaluator = (context) => {
+        return !operandEvaluator(context)
+      }
+      continue
+    }
+
     // TERNARY OPERATOR
     const isTernary = readNext(expression, pos) === TOKEN_OPERATOR_TERNARY_FIRST
     if (isTernary) {

package/src/libs/feature/editor/src/lib/fields.config.ts

@@ -37,6 +37,19 @@ export const DEFAULT_CONFIGURATION: EditorConfig = {
                 labelKey: marker('editor.record.form.field.title'),
               },
             },
+            {
+              model: 'flags',
+              modelSpecifier: 'flags:IS_REFERENCE_DATASET',
+              formFieldConfig: {
+                labelKey: marker(
+                  'editor.record.form.field.flags.IS_REFERENCE_DATASET'
+                ),
+                hintKey: marker(
+                  'editor.record.form.field.hint.flags.IS_REFERENCE_DATASET'
+                ),
+              },
+              hidden: '${record.kind != "dataset" || !user.isAdmin}',
+            },
             {
               model: 'abstract',
               formFieldConfig: {

package/src/libs/feature/editor/src/lib/models/editor-config.model.ts

@@ -1,4 +1,7 @@
-import { CatalogRecordKeys } from '../../../../../../libs/common/domain/src/lib/model/record'
+import {
+  CatalogRecordKeys,
+  RecordFlag,
+} from '../../../../../../libs/common/domain/src/lib/model/record'
 
 // Expressions should be enclosed in `${}` to be recognized as such
 // eg. ${dateNow()}
@@ -15,6 +18,8 @@ export interface FormFieldConfig {
   invalidHintKey?: string
 }
 
+export type FormFieldModel = CatalogRecordKeys | 'flags'
+
 // Specifiers let us use specific components
 // This is used for instance to target only certain online resources in a field
 type OnlineLinkResourceSpecifier = `onlineResourceType:link`
@@ -25,11 +30,12 @@ type OnlineSingleLinkResourceSpecifier = `onlineResourceType:singleLink`
 // When set on the `contacts` field, contacts are rendered as editable detail
 // fields (ContactDetailsFormComponent) instead of cards (ContactCardComponent)
 type EditableContactDetailsSpecifier = `contact:editableDetails`
-export type FieldModelSpecifier =
+export type FormFieldModelSpecifier =
   | OnlineLinkResourceSpecifier
   | DatasetDistributionsSpecifier
   | OnlineSingleLinkResourceSpecifier
   | EditableContactDetailsSpecifier
+  | `flags:${RecordFlag}`
 
 export type FormFieldComponentName =
   | 'form-field-constraints-shortcuts'
@@ -37,8 +43,8 @@ export type FormFieldComponentName =
 
 export interface EditorFieldIdentification {
   // name of the target field in the record; will not change the record directly if not defined
-  model?: CatalogRecordKeys
-  modelSpecifier?: FieldModelSpecifier
+  model?: FormFieldModel
+  modelSpecifier?: FormFieldModelSpecifier
 
   // if no model is given, a component can be shown instead
   componentName?: FormFieldComponentName

package/src/libs/feature/map/src/index.ts

@@ -6,8 +6,6 @@ export * from './lib/feature-map.module'
 export * from './lib/map-state-container/map-state-container.component'
 export * from './lib/constant'
 export * from './lib/utils'
-export * from './lib/style'
 export * from './lib/layers-panel/layers-panel.component'
 export * from './lib/add-layer-from-catalog/add-layer-from-catalog.component'
 export * from './lib/add-layer-from-catalog/add-layer-record-preview/add-layer-record-preview.component'
-export * from './lib/geocoding/geocoding.component'

package/src/libs/feature/map/src/lib/add-layer-from-file/add-layer-from-file.component.html

@@ -5,6 +5,7 @@
         (fileChange)="handleFileChange($event)"
         [accept]="acceptedMimeType.join(',')"
         [placeholder]="'map.addFromFile.placeholder' | translate"
+        textClass="text-gray-900 pl-2 py-2"
         class="placeholder-grey"
       ></gn-ui-drag-and-drop-file-input>
     </div>

package/src/libs/feature/map/src/lib/feature-map.module.ts

@@ -2,18 +2,11 @@ import { NgModule } from '@angular/core'
 import { StoreModule } from '@ngrx/store'
 import * as fromMap from './+state/map.reducer'
 import { MapFacade } from './+state/map.facade'
-import { GEOCODING_PROVIDER, GeocodingProvider } from './geocoding.service'
 
 @NgModule({
   imports: [
     StoreModule.forFeature(fromMap.MAP_FEATURE_KEY, fromMap.mapReducer),
   ],
-  providers: [
-    MapFacade,
-    {
-      provide: GEOCODING_PROVIDER,
-      useValue: ['geonames', { maxRows: 5 }] as GeocodingProvider,
-    },
-  ],
+  providers: [MapFacade],
 })
 export class FeatureMapModule {}

package/src/libs/feature/notifications/src/lib/notifications.service.ts

@@ -18,10 +18,12 @@ export class NotificationsService {
     error && console.error(error)
     const id = Math.floor(Math.random() * 1000000)
     this.notifications$.next([...this.notifications$.value, { ...content, id }])
-    if (typeof timeoutMs === 'undefined') return
-    setTimeout(() => {
-      this.removeNotificationById(id)
-    }, timeoutMs)
+    if (typeof timeoutMs !== 'undefined') {
+      setTimeout(() => {
+        this.removeNotificationById(id)
+      }, timeoutMs)
+    }
+    return id
   }
 
   removeNotificationById(id: number) {