geojs 1.8.4 → 1.8.5

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # GeoJS Change Log
 
+## Version 1.8.5
+
+### Improvements
+
+-Optimize reordering fetch queue ([#1203](../../pull/1203))
+
 ## Version 1.8.4
 
 ### Improvements

package/geo.js

@@ -10905,9 +10905,8 @@ var fetchQueue = function fetchQueue(options) {
       var pos = $.inArray(defer, m_this._queue);
 
       if (pos >= 0) {
-        m_this._queue.splice(pos, 1);
-
-        m_this._addToQueue(defer, atEnd);
+        // m_this._queue.splice(pos, 1);
+        m_this._addToQueue(defer, atEnd, pos);
 
         return defer;
       }
@@ -10941,24 +10940,40 @@ var fetchQueue = function fetchQueue(options) {
    * @param {boolean} atEnd If falsy, add the item to the front of the queue
    *  if batching is turned off or at the end of the current batch if it is
    *  turned on.  If truthy, always add the item to the end of the queue.
+   * @param {number} [pos] If specified, the current location in the queue of
+   *   the object being added.  This avoids having to splice, push, or unshift
+   *   the queue.
    */
 
 
-  this._addToQueue = function (defer, atEnd) {
+  this._addToQueue = function (defer, atEnd, pos) {
+    var move = atEnd ? m_this._queue.length - 1 : 0;
     defer.__fetchQueue._batch = m_this._batch;
 
-    if (atEnd) {
-      m_this._queue.push(defer);
-    } else if (!m_this._batch) {
-      m_this._queue.unshift(defer);
-    } else {
-      for (var i = 0; i < m_this._queue.length; i += 1) {
-        if (m_this._queue[i].__fetchQueue._batch !== m_this._batch) {
+    if (!atEnd && m_this._batch) {
+      for (move = 0; move < m_this._queue.length - (pos === undefined ? 0 : 1); move += 1) {
+        if (m_this._queue[move].__fetchQueue._batch !== m_this._batch) {
           break;
         }
       }
+    }
+
+    if (pos === undefined) {
+      if (atEnd) {
+        m_this._queue.push(defer);
+      } else if (!move) {
+        m_this._queue.unshift(defer);
+      } else {
+        m_this._queue.splice(move, 0, defer);
+      }
+    } else if (pos !== move) {
+      var dir = pos < move ? 1 : -1;
+
+      for (var i = pos; i !== move; i += dir) {
+        m_this._queue[i] = m_this._queue[i + dir];
+      }
 
-      m_this._queue.splice(i, 0, defer);
+      m_this._queue[move] = defer;
     }
   };
   /**
@@ -26856,7 +26871,7 @@ module.exports = sceneObject;
  * @constant
  * @type {string}
  */
-module.exports = "aa7a52c0facebedfe694ae91d1f9a295ade8765e";
+module.exports = "c8c9edda606de6cb2990b41bfdfe2c4a82c885cb";
 
 /***/ }),
 
@@ -39346,7 +39361,7 @@ module.exports = vectorFeature;
  * @constant
  * @type {string}
  */
-module.exports = "1.8.4";
+module.exports = "1.8.5";
 
 /***/ }),
 

package/geo.lean.js

@@ -10905,9 +10905,8 @@ var fetchQueue = function fetchQueue(options) {
       var pos = $.inArray(defer, m_this._queue);
 
       if (pos >= 0) {
-        m_this._queue.splice(pos, 1);
-
-        m_this._addToQueue(defer, atEnd);
+        // m_this._queue.splice(pos, 1);
+        m_this._addToQueue(defer, atEnd, pos);
 
         return defer;
       }
@@ -10941,24 +10940,40 @@ var fetchQueue = function fetchQueue(options) {
    * @param {boolean} atEnd If falsy, add the item to the front of the queue
    *  if batching is turned off or at the end of the current batch if it is
    *  turned on.  If truthy, always add the item to the end of the queue.
+   * @param {number} [pos] If specified, the current location in the queue of
+   *   the object being added.  This avoids having to splice, push, or unshift
+   *   the queue.
    */
 
 
-  this._addToQueue = function (defer, atEnd) {
+  this._addToQueue = function (defer, atEnd, pos) {
+    var move = atEnd ? m_this._queue.length - 1 : 0;
     defer.__fetchQueue._batch = m_this._batch;
 
-    if (atEnd) {
-      m_this._queue.push(defer);
-    } else if (!m_this._batch) {
-      m_this._queue.unshift(defer);
-    } else {
-      for (var i = 0; i < m_this._queue.length; i += 1) {
-        if (m_this._queue[i].__fetchQueue._batch !== m_this._batch) {
+    if (!atEnd && m_this._batch) {
+      for (move = 0; move < m_this._queue.length - (pos === undefined ? 0 : 1); move += 1) {
+        if (m_this._queue[move].__fetchQueue._batch !== m_this._batch) {
           break;
         }
       }
+    }
+
+    if (pos === undefined) {
+      if (atEnd) {
+        m_this._queue.push(defer);
+      } else if (!move) {
+        m_this._queue.unshift(defer);
+      } else {
+        m_this._queue.splice(move, 0, defer);
+      }
+    } else if (pos !== move) {
+      var dir = pos < move ? 1 : -1;
+
+      for (var i = pos; i !== move; i += dir) {
+        m_this._queue[i] = m_this._queue[i + dir];
+      }
 
-      m_this._queue.splice(i, 0, defer);
+      m_this._queue[move] = defer;
     }
   };
   /**
@@ -26856,7 +26871,7 @@ module.exports = sceneObject;
  * @constant
  * @type {string}
  */
-module.exports = "aa7a52c0facebedfe694ae91d1f9a295ade8765e";
+module.exports = "c8c9edda606de6cb2990b41bfdfe2c4a82c885cb";
 
 /***/ }),
 
@@ -39346,7 +39361,7 @@ module.exports = vectorFeature;
  * @constant
  * @type {string}
  */
-module.exports = "1.8.4";
+module.exports = "1.8.5";
 
 /***/ }),