gentle-pi 4.5.0 → 4.5.1

package/docs/gentle-music.md

@@ -42,7 +42,9 @@ When you quit Pi after using `/gentle:music`, Gentle Shell runs `gentle-stream c
 
 ## Installation
 
-Gentle Shell looks for gentle-stream in this order:
+gentle-stream runs on macOS and Linux, including Gentle Shell inside WSL. It needs POSIX features native Windows lacks (file locks, a Unix control socket, process groups), so on native Windows `/gentle:music` only says it is not available yet: it never offers, installs, or runs the player.
+
+On macOS and Linux, Gentle Shell looks for gentle-stream in this order:
 
 1. `gentle-stream` on `PATH`.
 2. In a bundled Gentle Shell, the gentle-stream it installed inside its own folder (see below).
@@ -57,13 +59,13 @@ uv tool install 'gentle-stream[samples] @ git+https://github.com/Gentleman-Progr
 
 ### Installed by a bundled Gentle Shell
 
-A bundled Gentle Shell (the one the web installer sets up) offers to install the player for you the first time `/gentle:music` finds none:
+On macOS and Linux, a bundled Gentle Shell (the one the web installer sets up) offers to install the player for you the first time `/gentle:music` finds none:
 
 > Install the gentle-stream music player inside Gentle Shell? It downloads uv, Python 3.13 and the player (about 150 MB) into the Gentle Shell folder.
 
 Decline and you get the manual hint above; nothing is downloaded. Accept and Gentle Shell shows its progress, installs the player, and starts the music. Later runs use it directly, with no question.
 
-Everything stays inside the Gentle Shell folder (`~/.gentle-shell`, or `%LOCALAPPDATA%\gentle-shell` on Windows). Nothing is added to your `PATH`, and your own Python, uv, and uv settings are never used or changed:
+Everything stays inside the Gentle Shell folder (`~/.gentle-shell`). Nothing is added to your `PATH`, and your own Python, uv, and uv settings are never used or changed:
 
 | What | Where | Size on disk |
 | :-- | :-- | :-- |
@@ -77,6 +79,7 @@ The player is installed with its `samples` extra (pyfluidsynth). If that extra c
 
 ## Limits
 
+- Native Windows is not supported yet (see [Installation](#installation)); use WSL.
 - The player needs the interactive terminal. In RPC, JSON, and print modes, `/gentle:music` shows a notice and does nothing.
 - There is no default shortcut.
 - gentle-stream starts its own `gentle-shell` process to interpret moods; Gentle Shell does not pass its own launcher path.

package/docs/gentle-shell.md

@@ -397,7 +397,7 @@ The canvas server binds `127.0.0.1` on a random port and needs a random per-serv
 
 ### Gentle Music
 
-`/gentle:music [mood]` hands the terminal to the [gentle-stream](https://github.com/Gentleman-Programming/gentle-stream) player, like Pi's external editor, passing the mood and the session model. In the player, `b` returns to Pi with the music playing and `q` returns and stops it. `/gentle:music next`, `pause`, `play`, `stop`, and `status` control the music without leaving Pi. Quitting Pi after using the command stops the music. gentle-stream runs from `PATH`, or through `uvx`/`uv` when it is not installed. A bundled Gentle Shell without any of them offers, with your consent, to install the player inside its own folder: a pinned, checksum-verified uv 0.13.6 in `runtime/`, and the uv-managed Python 3.13 and gentle-stream in `music/` (about 150 MB to download, about 210 MB on disk). A pnpm or npm install keeps the manual install hint. See [Gentle Music](gentle-music.md).
+`/gentle:music [mood]` hands the terminal to the [gentle-stream](https://github.com/Gentleman-Programming/gentle-stream) player, like Pi's external editor, passing the mood and the session model. In the player, `b` returns to Pi with the music playing and `q` returns and stops it. `/gentle:music next`, `pause`, `play`, `stop`, and `status` control the music without leaving Pi. Quitting Pi after using the command stops the music. gentle-stream runs from `PATH`, or through `uvx`/`uv` when it is not installed. On native Windows the player is not available yet (it needs POSIX; WSL works), so the command only says so. A bundled Gentle Shell on macOS or Linux without any of them offers, with your consent, to install the player inside its own folder: a pinned, checksum-verified uv 0.13.6 in `runtime/`, and the uv-managed Python 3.13 and gentle-stream in `music/` (about 150 MB to download, about 210 MB on disk). A pnpm or npm install keeps the manual install hint. See [Gentle Music](gentle-music.md).
 
 ### Bridge providers
 

package/docs/readme-reference.md

@@ -988,7 +988,9 @@ Delegation contract:
 | Persona     | Behavior                                                                                                      |
 | ----------- | ------------------------------------------------------------------------------------------------------------- |
 | `gentleman` | Senior architect, teacher, direct technical feedback, Rioplatense Spanish/voseo when the user writes Spanish. |
-| `neutral`   | Same discipline, warmer professional language, no regional expression.                                        |
+| `neutral`   | Same discipline, warmer professional language, no regional expression, no voseo in any verb form.             |
+
+Both modes reply in the language of the user's latest message and never default to Spanish, so an English message gets an English reply even after context compaction.
 
 Saved globally at:
 

package/extensions/gentle-ai.ts

@@ -1405,7 +1405,7 @@ const PERSONA_OPTIONS = ["gentleman", "neutral"] as const;
 
 const GENTLEMAN_PERSONA_PROMPT = `Persona:
 - Be direct, technical, and concise.
-- Always respond in the same language the user writes in.
+- Always respond in the same language the user writes in. Judge it by the user's latest message, never by earlier context or a compaction summary, and never default to Spanish: a message in English gets a reply in English.
 - When the user writes Spanish, answer in natural Rioplatense Spanish with voseo.
 - Act as a senior architect and teacher: concepts before code, no shortcuts.
 - Treat AI as a tool directed by the human; never present yourself as a default chatbot.
@@ -1414,9 +1414,9 @@ const GENTLEMAN_PERSONA_PROMPT = `Persona:
 
 const NEUTRAL_PERSONA_PROMPT = `Persona:
 - Be direct, technical, concise, warm, and professional.
-- Always respond in the same language the user writes in.
+- Always respond in the same language the user writes in. Judge it by the user's latest message, never by earlier context or a compaction summary, and never default to Spanish: a message in English gets a reply in English.
 - Do not use slang or regional expressions.
-- When the user writes Spanish, use neutral/professional Spanish. Do NOT use voseo (vos tenés, vos querés, hacé, andá, etc.) or any regional conjugations.
+- When the user writes Spanish, use neutral/professional Spanish. Do NOT use voseo or any regional conjugations, regular or irregular: use tú or usted forms, never vos forms (tienes, not tenés; ajustas, not ajustás; vives, not vivís; mira, not mirá; haz, not hacé).
 - Act as a senior architect and teacher: concepts before code, no shortcuts.
 - Treat AI as a tool directed by the human; never present yourself as a default chatbot.
 - Push back when the user asks for code without enough context or understanding.
@@ -4519,10 +4519,12 @@ function routingScreenNotices(
 	const unmatched = unmatchedProfileKeys(Object.fromEntries(profileKeys.map((key) => [key, { model: undefined, thinking: undefined }])), known);
 	const ignored = unmatched.filter((entry) => entry.suggestion === undefined).map((entry) => entry.key);
 	if (ignored.length > 0) {
-		notices.push(`No agent matches ${ignored.map((key) => `"${key}"`).join(", ")} in this profile, so ${ignored.length === 1 ? "it is" : "they are"} ignored at launch.`);
+		notices.push(
+			`Profile key${ignored.length === 1 ? "" : "s"} ${ignored.map((key) => `"${key}"`).join(", ")} match${ignored.length === 1 ? "es" : ""} no agent configured in gentle-shell, so ${ignored.length === 1 ? "it is" : "they are"} ignored at launch.`,
+		);
 	}
 	for (const entry of unmatched) {
-		if (entry.suggestion !== undefined) notices.push(`No agent is named "${entry.key}" in this profile; did you mean ${entry.suggestion}?`);
+		if (entry.suggestion !== undefined) notices.push(`Profile key "${entry.key}" matches no agent configured in gentle-shell; did you mean ${entry.suggestion}?`);
 	}
 	// Issue #2400: model_profiles keys in subagents.json that match nothing and
 	// suggest nothing. A session binding or a winning pin replaces those launches'

package/extensions/gentle-music.ts

@@ -27,6 +27,9 @@ export type MusicControlCommand = (typeof MUSIC_CONTROL_COMMANDS)[number];
 
 export const MUSIC_INSTALL_TITLE = "Install the music player?";
 export const MUSIC_INSTALL_OFFER = "Install the gentle-stream music player inside Gentle Shell? It downloads uv, Python 3.13 and the player (about 150 MB) into the Gentle Shell folder.";
+// gentle-stream needs POSIX (fcntl locks, an AF_UNIX control socket, process
+// groups), so a native Windows Pi can neither install nor run it; WSL is Linux.
+export const MUSIC_WINDOWS_UNSUPPORTED = "/gentle:music is not available on Windows yet: the gentle-stream player runs on macOS and Linux. It works when Gentle Shell runs inside WSL.";
 const UV_INSTALL_URL = "https://docs.astral.sh/uv/getting-started/installation/";
 const CTL_TIMEOUT_MS = 30_000;
 const SHUTDOWN_TIMEOUT_MS = 2_000;
@@ -85,6 +88,8 @@ export interface GentleMusicDeps {
 	which?: MusicWhich;
 	/** The bundled install's player, or undefined outside a bundled install. */
 	bundled?: () => Promise<BundledMusicPlayer | undefined>;
+	/** The platform Pi runs on; gentle-stream does not run on native Windows. */
+	platform?: NodeJS.Platform;
 	spawn?: MusicSpawn;
 	signals?: MusicSignals;
 	usage?: MusicUsage;
@@ -259,6 +264,7 @@ export default function gentleMusic(pi: ExtensionAPI, deps: GentleMusicDeps = {}
 	const usage = deps.usage ?? processUsage();
 	const shutdownTimeoutMs = deps.shutdownTimeoutMs ?? SHUTDOWN_TIMEOUT_MS;
 	const bundled = deps.bundled ?? defaultBundled;
+	const platform = deps.platform ?? process.platform;
 
 	const findPlayer = async (): Promise<{ stream?: GentleStreamCommand; offer?: BundledMusicPlayer }> => {
 		let player: BundledMusicPlayer | undefined;
@@ -326,6 +332,10 @@ export default function gentleMusic(pi: ExtensionAPI, deps: GentleMusicDeps = {}
 		description: "Open gentle-stream full screen (optional mood text); b returns with the music playing, q stops it. next, pause, play, stop, status control the music without leaving Pi.",
 		handler: async (args, ctx) => {
 			if (!ctx.hasUI) return;
+			if (platform === "win32") {
+				ctx.ui.notify(MUSIC_WINDOWS_UNSUPPORTED, "warning");
+				return;
+			}
 			if (ctx.mode !== "tui") {
 				ctx.ui.notify("/gentle:music needs the interactive terminal.", "warning");
 				return;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "gentle-pi",
-	"version": "4.5.0",
+	"version": "4.5.1",
 	"description": "Turn Pi into el Gentleman: an ODD development harness with focused subagents, configured TDD evidence, native review, and skill discovery.",
 	"license": "MIT",
 	"type": "module",

package/tests/design-canvas-server.test.ts

@@ -562,9 +562,13 @@ function openEvents(port: number) {
 		req.on("error", reject);
 	});
 	req.end();
-	const waitFor = (pattern: RegExp) => new Promise<RegExpExecArray>((resolve) => {
+	// A waiter that never matches must fail loud, not hang the whole suite:
+	// an exhausted inotify limit silently stops the server's change events.
+	const waitFor = (pattern: RegExp) => new Promise<RegExpExecArray>((resolve, reject) => {
+		const timeout = setTimeout(() => reject(new Error(`events never matched ${pattern} within 5s; got: ${JSON.stringify(buffer.slice(-200))}`)), 5000);
+		const settle = (match: RegExpExecArray) => { clearTimeout(timeout); resolve(match); };
 		const match = pattern.exec(buffer);
-		if (match) resolve(match); else waiters.push({ pattern, resolve });
+		if (match) settle(match); else waiters.push({ pattern, resolve: settle });
 	});
 	return { ready, waitFor, req };
 }

package/tests/fixtures/primary-session-prompt/gentleman.golden.md

@@ -13,7 +13,7 @@ Identity contract:
 
 Persona:
 - Be direct, technical, and concise.
-- Always respond in the same language the user writes in.
+- Always respond in the same language the user writes in. Judge it by the user's latest message, never by earlier context or a compaction summary, and never default to Spanish: a message in English gets a reply in English.
 - When the user writes Spanish, answer in natural Rioplatense Spanish with voseo.
 - Act as a senior architect and teacher: concepts before code, no shortcuts.
 - Treat AI as a tool directed by the human; never present yourself as a default chatbot.

package/tests/gentle-ai.test.ts

@@ -1539,10 +1539,10 @@ test("models screen offers only the effort levels each model supports and shows
 test("models screen lists configuration problems under the profile name without cutting them", () => {
 	const notices = [
 		"The local pin file /home/user/project/.git/gentle-ai/profile-pin.json is not a valid pin and is ignored. Fix or remove it.",
-		'No agent matches "sdd-design" in this profile, so it is ignored at launch.',
+		'Profile key "sdd-design" matches no agent configured in gentle-shell, so it is ignored at launch.',
 	];
 	const plain = renderScreen([], [], [], { width: 80, notices }).map(stripAnsi);
-	assert.ok(plain.some((line) => line.includes('⚠ No agent matches "sdd-design"')));
+	assert.ok(plain.some((line) => line.includes('⚠ Profile key "sdd-design"')));
 	assert.ok(!plain.some((line) => line.includes("…")));
 });
 
@@ -3531,7 +3531,7 @@ test("the models screen flags profile keys no agent matches and never flags prov
 	await fixture.run("gentle:profiles");
 	const flat = (rendered: string) => rendered.replace(/\s*│\s*/g, " ").replace(/\s+/g, " ");
 	assert.equal(rendered.split("\n").length, 24, "the frame spans the terminal height");
-	assert.match(flat(rendered), /⚠ No agent matches "sdd-design" in this profile, so it is ignored at launch\./);
+	assert.match(flat(rendered), /⚠ Profile key "sdd-design" matches no agent configured in gentle-shell, so it is ignored at launch\./);
 	assert.doesNotMatch(flat(rendered), /review-refuter"/, "provider review roles are never flagged");
 	assert.match(rendered, /Orchestrator\s+nan\/glm5\.3\s+high/);
 	assert.match(rendered, /worker\s+openai\/alpha\s+high/);
@@ -3555,7 +3555,7 @@ test("at 60 columns the unmatched-key notice wraps instead of being cut", async
 	assert.ok(panel);
 	const narrow = stripAnsi(panel.render(60).join("\n"));
 	const flat = (rendered: string) => rendered.replace(/\s*│\s*/g, " ").replace(/\s+/g, " ");
-	assert.match(flat(narrow), /⚠ No agent matches "sdd-design" in this profile, so it is ignored at launch\./);
+	assert.match(flat(narrow), /⚠ Profile key "sdd-design" matches no agent configured in gentle-shell, so it is ignored at launch\./);
 	assert.ok(!narrow.split("\n").some((line) => line.includes("…")), "nothing is cut");
 });
 

package/tests/gentle-music.test.ts

@@ -5,13 +5,14 @@ import { tmpdir } from "node:os";
 import { delimiter, join } from "node:path";
 import test, { type TestContext } from "node:test";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
-import gentleMusic, {
+import gentleMusicExtension, {
 	findOnPath,
 	formatMusicStatus,
 	GENTLE_STREAM_SPEC,
 	installHint,
 	MUSIC_COMMAND_NAME,
 	MUSIC_INSTALL_OFFER,
+	MUSIC_WINDOWS_UNSUPPORTED,
 	MUSIC_INSTALL_TITLE,
 	musicTuiArgs,
 	parseMusicArgs,
@@ -20,6 +21,11 @@ import gentleMusic, {
 	type MusicSpawn,
 } from "../extensions/gentle-music.ts";
 
+// The music tests describe a supported (POSIX) host unless they pass `platform`,
+// so they hold on every OS the suite runs on, Windows included.
+const gentleMusic = (pi: Parameters<typeof gentleMusicExtension>[0], deps: Parameters<typeof gentleMusicExtension>[1] = {}) =>
+	gentleMusicExtension(pi, { platform: "linux", ...deps });
+
 // /gentle:music hands the terminal to gentle-stream's own TUI, the way Pi's
 // external editor does, and controls the background player with
 // `gentle-stream ctl …` without taking the terminal.
@@ -411,6 +417,35 @@ test("accepting the offer installs the player with progress, then starts the mus
 	assert.deepEqual(spawned[0]!.args, ["--model", "anthropic/claude-sonnet-5-5", "--mood", "calm"]);
 });
 
+test("on Windows /gentle:music explains it is not available yet and never offers, installs or runs anything", async () => {
+	assert.equal(MUSIC_WINDOWS_UNSUPPORTED, "/gentle:music is not available on Windows yet: the gentle-stream player runs on macOS and Linux. It works when Gentle Shell runs inside WSL.");
+	for (const args of ["", "calm", "status", "stop"]) {
+		const { pi, commands } = fakePi();
+		const context = fakeContext();
+		const asked = withConfirm(context, true);
+		const { spawn, spawned } = fakeSpawn([{ code: 0 }], context.calls);
+		const { state, bundled } = fakeBundled({ installed: true });
+		gentleMusic(pi, { which: onPath({ "gentle-stream": "C:\\bin\\gentle-stream.exe", uvx: "C:\\bin\\uvx.exe" }), spawn, bundled, signals: fakeSignals().signals, platform: "win32" });
+		await commands.get(MUSIC_COMMAND_NAME)!.handler(args, context.ctx);
+		assert.deepEqual(context.notices, [[MUSIC_WINDOWS_UNSUPPORTED, "warning"]], args);
+		assert.deepEqual(asked, [], args);
+		assert.equal(state.installs, 0, args);
+		assert.equal(spawned.length, 0, args);
+	}
+});
+
+test("on Windows the not-available notice wins over the interactive-terminal notice", async () => {
+	for (const mode of ["rpc", "json", "print"]) {
+		const { pi, commands } = fakePi();
+		const context = fakeContext(mode);
+		const { spawn, spawned } = fakeSpawn([{ code: 0 }], context.calls);
+		gentleMusic(pi, { which: onPath({ uvx: "C:\\bin\\uvx.exe" }), spawn, platform: "win32" });
+		await commands.get(MUSIC_COMMAND_NAME)!.handler("", context.ctx);
+		assert.deepEqual(context.notices, [[MUSIC_WINDOWS_UNSUPPORTED, "warning"]], mode);
+		assert.equal(spawned.length, 0, mode);
+	}
+});
+
 test("an installed prefix player is used without asking; PATH gentle-stream still comes first", async () => {
 	const { bundled } = fakeBundled({ installed: true });
 	for (const [names, expected] of [[{}, "/prefix/music/bin/gentle-stream"], [{ uvx: "/bin/uvx" }, "/prefix/music/bin/gentle-stream"], [{ "gentle-stream": "/bin/gentle-stream" }, "/bin/gentle-stream"]] as const) {

package/tests/installer-server.test.ts

@@ -306,8 +306,8 @@ test("/api/plan names the found and required version of an older Gentle Shell an
 		const view = await plan(port, await login());
 		assert.deepEqual(view.blockers.map((blocker: { code: string; tool: string }) => [blocker.code, blocker.tool]), [["incompatible-tool", "shell"]]);
 		assert.equal(view.blockers[0].guidance,
-			"Gentle Shell 3.4.0 is installed globally with pnpm, but this installer needs 4.5.0 or newer. Nothing was replaced. " +
-			"Update it with `pnpm add -g gentle-pi@4.5.0`, or remove it with `pnpm remove -g gentle-pi`, then select Check again.");
+			"Gentle Shell 3.4.0 is installed globally with pnpm, but this installer needs 4.5.1 or newer. Nothing was replaced. " +
+			"Update it with `pnpm add -g gentle-pi@4.5.1`, or remove it with `pnpm remove -g gentle-pi`, then select Check again.");
 		assert.deepEqual(view.actions, []);
 	} finally {
 		await host.close("test");

package/tests/package-manifest.test.ts

@@ -1793,9 +1793,9 @@ test("pi-pretty wrapper uses cached ESM loading for compiled and pnpm symlink in
 	assert.match(wrapper, /quietToolsEnabled/);
 });
 
-test("Gentle Shell v4.5.0 package manifest declares the release version", () => {
+test("Gentle Shell v4.5.1 package manifest declares the release version", () => {
 	const packageJson = readPackageJson();
-	assert.equal(packageJson.version, "4.5.0", "the release manifest must be explicitly pinned to v4.5.0");
+	assert.equal(packageJson.version, "4.5.1", "the release manifest must be explicitly pinned to v4.5.1");
 	assert.equal(packageJson.scripts?.test, "node scripts/run-test-suite.mjs");
 	assert.ok(packageJson.files?.includes("assets/"));
 	assert.ok(packageJson.files?.includes("contracts/"));

package/tests/persona-reply-language.test.ts

@@ -0,0 +1,42 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { __testing } from "../extensions/gentle-ai.ts";
+
+// gentle-shell #55 / #57 / #125: the reply language is inferred every turn,
+// never stored, so the persona prompt itself must say how to infer it. The
+// rule lives on the single existing language-match bullet (the concept-level
+// duplication guard allows exactly one), so these tests read the rendered
+// prompt rather than a second rule.
+
+for (const persona of ["gentleman", "neutral"] as const) {
+	test(`[${persona}] the reply language follows the user's latest message, never a Spanish default (#125, #57)`, () => {
+		const prompt = __testing.buildGentlePrompt(persona);
+		assert.match(prompt, /Always respond in the same language the user writes in\./);
+		assert.match(
+			prompt,
+			/latest message, never by earlier context or a compaction summary/,
+			`${persona} prompt must judge the reply language by the user's latest message, so a compaction summary cannot flip it (#57)`,
+		);
+		assert.match(
+			prompt,
+			/never default to Spanish: a message in English gets a reply in English/,
+			`${persona} prompt must forbid a Spanish default, so an English message never gets a Spanish reply (#125)`,
+		);
+	});
+}
+
+test("[neutral] the voseo prohibition covers regular and irregular forms, not only four irregular verbs (#55)", () => {
+	const prompt = __testing.buildGentlePrompt("neutral");
+	assert.match(prompt, /Do NOT use voseo/);
+	assert.match(prompt, /regular or irregular: use tú or usted forms, never vos forms/);
+	for (const pair of ["ajustas, not ajustás", "vives, not vivís", "mira, not mirá", "haz, not hacé"]) {
+		assert.ok(prompt.includes(pair), `neutral prompt must name the voseo replacement "${pair}"`);
+	}
+});
+
+test("[gentleman] Spanish replies keep Rioplatense voseo and get no neutral-only rule", () => {
+	const prompt = __testing.buildGentlePrompt("gentleman");
+	assert.match(prompt, /When the user writes Spanish, answer in natural Rioplatense Spanish with voseo\./);
+	assert.match(prompt, /Language: natural Rioplatense Spanish with voseo when the user writes Spanish\./);
+	assert.doesNotMatch(prompt, /never vos forms/, "gentleman prompt must not inherit the neutral voseo prohibition");
+});