gentle-pi 4.3.0 → 4.4.0

package/lib/review-host-relay.ts

@@ -630,8 +630,15 @@ function snapshotReviewHostRelayRequest(request: ReviewHostRelayRequest): Review
 	// are TypeErrors — a programmer mistake, never a typed relay refusal — and
 	// are checked before the business-level reviewer selection below.
 	assertTokens("capture", request.captureArgumentTokens);
-	const gentleAiExecutable = request.gentleAiExecutable ?? resolveGentleAiBinary();
-	if (!isAbsolute(gentleAiExecutable)) throw new TypeError("Pi host relay requires an absolute gentle-ai executable path");
+	// A caller-supplied executable path is input, validated like every other
+	// input before anything else. Only the environment-dependent resolution of
+	// an unspecified executable is deferred below: the executable supply is
+	// environment state (a missing pinned binary, an invalid dev override, a
+	// transient filesystem error under load), and letting its untyped errors
+	// escape ahead of the config check turned the typed configuration refusal
+	// into an environment-dependent unknown failure (gentle-shell#2256).
+	const suppliedExecutable = request.gentleAiExecutable;
+	if (suppliedExecutable !== undefined && !isAbsolute(suppliedExecutable)) throw new TypeError("Pi host relay requires an absolute gentle-ai executable path");
 	// Caller-owned reviewer selection is validated before any process launches:
 	// a broken configuration is a typed refusal, never a mid-review transport
 	// failure (gentle-pi#311 P2).
@@ -640,6 +647,8 @@ function snapshotReviewHostRelayRequest(request: ReviewHostRelayRequest): Review
 	// slot without a provider-owned submission is a typed contract mismatch,
 	// never a synthesized invocation.
 	resolveReviewHostRelaySubmission(request.submission);
+	const gentleAiExecutable = suppliedExecutable ?? resolveGentleAiBinary();
+	if (!isAbsolute(gentleAiExecutable)) throw new TypeError("Pi host relay requires an absolute gentle-ai executable path");
 	const environment = Object.freeze({ ...(request.environment ?? process.env) }) as NodeJS.ProcessEnv;
 	const submission = request.submission === undefined ? undefined : Object.freeze({
 		operationToken: request.submission.operationToken,

package/lib/review-reminder-receipt.ts

@@ -6,6 +6,9 @@ export const REVIEW_REMINDER_RECEIPT = "gentle-pi.review-reminder-receipt/v1";
 export interface ReceiptSession {
 	getSessionId(): string;
 	getBranch(): readonly { type: string; customType?: string; data?: unknown }[];
+	/** Append-only identity for memoizing repeated scans; hosts without it stay uncached. */
+	getLeafId?(): string | null;
+	getEntryCount?(): number;
 }
 interface ReceiptHost { appendEntry(type: string, data: unknown): void }
 export interface MutationEvidence {
@@ -59,7 +62,14 @@ function receipts(session: ReceiptSession, root: string): Receipt[] {
 
 // The first receipt per mutation id, in branch order, plus the index of the
 // last consumed one (-1 when nothing was consumed).
-function mutationLedger(session: ReceiptSession, root: string): { mutations: Mutation[]; consumed: number } {
+type Ledger = { mutations: Mutation[]; consumed: number };
+// Entries are append-only, so an unchanged (leafId, entryCount) identity means
+// the scan result is unchanged: each (session, root) ledger is memoized until
+// the next append (which moves the leaf) invalidates it. Hosts without leaf
+// identity stay uncached, the same way sessionStats must.
+const ledgerMemo = new WeakMap<object, Map<string, Ledger>>();
+
+function scanLedger(session: ReceiptSession, root: string): Ledger {
 	const mutations: Mutation[] = [];
 	let consumed = -1;
 	for (const receipt of receipts(session, root)) {
@@ -74,6 +84,19 @@ function mutationLedger(session: ReceiptSession, root: string): { mutations: Mut
 	return { mutations, consumed };
 }
 
+function mutationLedger(session: ReceiptSession, root: string): Ledger {
+	const leafId = typeof session.getLeafId === "function" ? session.getLeafId() : null;
+	if (leafId === null) return scanLedger(session, root);
+	const key = JSON.stringify([session.getSessionId(), leafId, session.getEntryCount?.(), root] as const);
+	let byKey = ledgerMemo.get(session);
+	const cached = byKey?.get(key);
+	if (cached) return cached;
+	const ledger = scanLedger(session, root);
+	if (!byKey) ledgerMemo.set(session, (byKey = new Map()));
+	byKey.set(key, ledger);
+	return ledger;
+}
+
 export function pendingReviewMutation(session: ReceiptSession, root: string, captured?: string): string | undefined {
 	const { mutations, consumed } = mutationLedger(session, root);
 	if (captured !== undefined) return mutations.findIndex((mutation) => mutation.id === captured) > consumed ? captured : undefined;