gentle-pi 3.6.0 → 4.0.0

package/tests/foreign-target-grants.test.ts

@@ -0,0 +1,58 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { ForeignTargetGrants } from "../lib/foreign-target-grants.ts";
+
+const target = { root: "/foreign", commonDir: "/foreign/.git" };
+function context(confirm?: () => Promise<boolean>) {
+	let id = "session-one";
+	let calls = 0;
+	const ctx = { sessionManager: { getSessionId: () => id }, hasUI: !!confirm, ui: confirm ? { confirm: async () => { calls++; return confirm(); } } : undefined };
+	return { ctx, setId: (next: string) => { id = next; }, calls: () => calls };
+}
+
+test("foreign grant requires interactive consent and reuses only the same live session and clone", async () => {
+	const grants = new ForeignTargetGrants();
+	const h = context(async () => true);
+	await grants.authorize(h.ctx as never, target);
+	await grants.authorize(h.ctx as never, target);
+	assert.equal(h.calls(), 1);
+	await grants.authorize(h.ctx as never, { root: "/another", commonDir: "/another/.git" });
+	assert.equal(h.calls(), 2);
+	h.setId("session-two");
+	assert.throws(() => grants.assertCurrent(h.ctx as never, target), /no longer live/);
+	await grants.authorize(h.ctx as never, target);
+	assert.equal(h.calls(), 3);
+	await new ForeignTargetGrants().authorize(h.ctx as never, target);
+	assert.equal(h.calls(), 4);
+});
+
+test("continuation after a reload cannot recreate a lost grant by prompting", async () => {
+	const h = context(async () => true);
+	const original = new ForeignTargetGrants();
+	await original.authorize(h.ctx as never, target);
+	const reloaded = new ForeignTargetGrants();
+	await assert.rejects(reloaded.authorize(h.ctx as never, target, { continuation: true }), /grant.*lost|grant.*live/i);
+	assert.equal(h.calls(), 1, "a lost continuation grant must never prompt again");
+});
+
+test("same-ID session-manager replacement revokes a grant without resurrecting it on continuation", async () => {
+	const h = context(async () => true);
+	const grants = new ForeignTargetGrants();
+	await grants.authorize(h.ctx as never, target);
+	const replacement = { ...h.ctx, sessionManager: { getSessionId: () => "session-one" } };
+	assert.throws(() => grants.assertCurrent(replacement as never, target), /no longer live/);
+	await assert.rejects(grants.authorize(replacement as never, target, { continuation: true }), /grant.*lost/i);
+	assert.equal(h.calls(), 1);
+	assert.throws(() => grants.assertCurrent(h.ctx as never, target), /no longer live/);
+});
+
+test("foreign grant fails closed on no UI, decline, cancellation, and identity change during consent", async () => {
+	await assert.rejects(new ForeignTargetGrants().authorize(context().ctx as never, target), /interactive/);
+	await assert.rejects(new ForeignTargetGrants().authorize(context(async () => false).ctx as never, target), /interactive/);
+	const cancelled = context(async () => { throw new Error("cancelled"); });
+	await assert.rejects(new ForeignTargetGrants().authorize(cancelled.ctx as never, target), /cancelled/);
+	const changed = context(async () => { changed.setId("replacement"); return true; });
+	const grants = new ForeignTargetGrants();
+	await assert.rejects(grants.authorize(changed.ctx as never, target), /identity changed/);
+	assert.throws(() => grants.assertCurrent(changed.ctx as never, target), /no longer live/);
+});

package/tests/generic-agent-tools.test.ts

@@ -0,0 +1,54 @@
+import assert from "node:assert/strict";
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import test from "node:test";
+
+const agents = join(process.cwd(), "assets", "agents");
+const roles: Record<string, string[]> = {
+	"gentle-ai-explore.md": ["read", "grep", "find", "codegraph"],
+	"gentle-ai-worker.md": ["read", "grep", "find", "edit", "write", "bash", "mem_save"],
+	"gentle-ai-verify.md": ["read", "grep", "find", "bash"],
+};
+
+function tools(file: string): string[] {
+	const source = readFileSync(join(agents, file), "utf8");
+	const frontmatter = source.match(/^---\n([\s\S]*?)\n---/)?.[1];
+	assert.ok(frontmatter, `${file} must have YAML frontmatter`);
+	const lines = frontmatter.split("\n");
+	const index = lines.indexOf("tools:");
+	assert.ok(index >= 0, `${file} must declare YAML tools`);
+	const result: string[] = [];
+	for (const line of lines.slice(index + 1)) {
+		if (!line.startsWith("  - ")) break;
+		result.push(line.slice(4).trim());
+	}
+	assert.ok(result.length > 0, `${file} must declare at least one tool`);
+	return result;
+}
+
+test("generic ODD agents declare exact role tool allowlists without child delegation", () => {
+	for (const [file, expected] of Object.entries(roles)) {
+		assert.ok(existsSync(join(agents, file)), `${file} must exist`);
+		assert.deepEqual(tools(file), expected);
+		assert.ok(tools(file).every(tool => !tool.startsWith("subagent_")));
+	}
+});
+
+test("ODD explorer and verifier remain read-only while writer is bounded", () => {
+	for (const file of ["gentle-ai-explore.md", "gentle-ai-verify.md"]) {
+		const source = readFileSync(join(agents, file), "utf8");
+		assert.match(source, /generic ODD work/);
+		assert.match(source, /Do not edit, write|read and search only/);
+		assert.ok(!tools(file).includes("edit") && !tools(file).includes("write"));
+		assert.match(source, /RDD review remains independent and parent-owned/);
+	}
+	const worker = readFileSync(join(agents, "gentle-ai-worker.md"), "utf8");
+	assert.match(worker, /exact allowed edit surfaces/);
+	assert.match(worker, /Work-unit commit decisions and the independent RDD review lifecycle remain parent-owned/);
+});
+
+test("retired Pi adversarial role agents are not packaged", () => {
+	for (const retired of ["review-refuter.md", "review-validator.md"]) {
+		assert.equal(existsSync(join(agents, retired)), false);
+	}
+});