gentle-pi 3.2.1 → 3.3.0

package/lib/native-review-cli.ts

@@ -1004,6 +1004,20 @@ export const NATIVE_CLI_CONTRACTS = Object.freeze({
 	// remain dark because neither is proven to reach the negotiated START
 	// path Pi consumes.
 	"3.2.1": Object.freeze({ start: true, finalize: true, validate: true, bindSdd: true, status: true, inventory: true, reclaim: true, recover: true, abandon: true, quarantineLegacy: true, reconcileAuthority: true, repairLegacyAlias: true, mode: true, riskEvidence: false, hint: false, delivery: true }),
+	// v3.4.0 (gentle-pi never pinned the intervening v3.3.0 tag, so it gets no
+	// row here) added capabilities/v2.6 and status/v8-v9, and extended
+	// `review assess` with review_due/review_due_reason/next_transition
+	// (gentle-ai #4714 follow-up). Ground-truthed by diffing
+	// contracts/review-integration/v2 and contracts/review-provider-contract
+	// between the v3.2.1 and v3.4.0 tags in the gentle-ai source tree: the
+	// provider contract stays byte-identical at 1.2.0, and every
+	// review-integration/v2 change is an additive superset (new optional
+	// schema/fields) that decodeReviewStatusV3 and the capabilities
+	// negotiator already accept without touching the closed START/STATUS
+	// fields this row negotiates, so it repeats 3.2.1 exactly. riskEvidence
+	// and hint remain dark because neither is proven to reach the negotiated
+	// START path Pi consumes.
+	"3.4.0": Object.freeze({ start: true, finalize: true, validate: true, bindSdd: true, status: true, inventory: true, reclaim: true, recover: true, abandon: true, quarantineLegacy: true, reconcileAuthority: true, repairLegacyAlias: true, mode: true, riskEvidence: false, hint: false, delivery: true }),
 });
 
 export interface NativeReviewProcessDiagnostics {

package/lib/odd-runtime-delegation-gate.ts

@@ -0,0 +1,88 @@
+import { realpathSync } from "node:fs";
+import { basename, dirname, isAbsolute, relative, resolve, sep } from "node:path";
+import { resolveSessionWorktree } from "./session-worktree-registry.ts";
+
+export interface OddDelegationRefusal {
+	block: true;
+	reason: string;
+}
+
+interface SessionState {
+	primary: boolean;
+	childDepth: number;
+	firstSuccessfulPath?: string;
+}
+
+function canonicalTarget(path: string): string {
+	let candidate = path;
+	const missing: string[] = [];
+	while (true) {
+		try { return resolve(realpathSync(candidate), ...missing); }
+		catch {
+			const parent = dirname(candidate);
+			if (parent === candidate) return path;
+			missing.unshift(basename(candidate));
+			candidate = parent;
+		}
+	}
+}
+
+function sessionPath(toolName: string, input: unknown, cwd: string): string | undefined {
+	if ((toolName !== "edit" && toolName !== "write") || !input || typeof input !== "object") return undefined;
+	const path = (input as { path?: unknown }).path;
+	if (typeof path !== "string" || path.trim().length === 0) return undefined;
+	const root = resolveSessionWorktree(cwd, cwd)?.root;
+	if (!root) return undefined;
+	const spelling = path.replace(/^@/, "");
+	const canonicalCwd = realpathSync(cwd);
+	const lexicalTarget = isAbsolute(spelling)
+		? resolve(spelling)
+		: resolve(canonicalCwd, spelling);
+	const target = canonicalTarget(lexicalTarget);
+	const repositoryPath = relative(root, target);
+	if (repositoryPath === "" || repositoryPath === ".." || repositoryPath.startsWith(`..${sep}`) || isAbsolute(repositoryPath)) return undefined;
+	const canonical = repositoryPath.split(sep).join("/");
+	return canonical === "odd/tasks" || canonical.startsWith("odd/tasks/") ? undefined : canonical;
+}
+
+export class OddRuntimeDelegationGate {
+	private readonly sessions = new Map<string, SessionState>();
+
+	start(sessionId: string, primary: boolean): void {
+		const state = this.sessions.get(sessionId);
+		if (primary) this.sessions.set(sessionId, { primary: true, childDepth: 0 });
+		else if (state?.primary) state.childDepth += 1;
+		else this.sessions.set(sessionId, { primary: false, childDepth: 1 });
+	}
+
+	endChild(sessionId: string): void {
+		const state = this.sessions.get(sessionId);
+		if (state && state.childDepth > 0) state.childDepth -= 1;
+	}
+
+	beforeTool(
+		sessionId: string,
+		toolName: string,
+		input: unknown,
+		cwd: string,
+		availableTools: readonly string[],
+	): OddDelegationRefusal | undefined {
+		const state = this.sessions.get(sessionId);
+		if (!state?.primary || state.childDepth > 0) return undefined;
+		const path = sessionPath(toolName, input, cwd);
+		if (!path || !state.firstSuccessfulPath || path === state.firstSuccessfulPath) return undefined;
+		return {
+			block: true,
+			reason: availableTools.includes("subagent_run")
+				? `ODD multi-file write refused before mutation: direct edits already changed ${state.firstSuccessfulPath}. Delegate this additional file through subagent_run, preferring gentle-ai-worker and then worker.`
+				: "ODD multi-file write refused before mutation: direct edits already changed another file, but subagent_run is not callable. Stop and report that no delegation mechanism is callable.",
+		};
+	}
+
+	recordSuccess(sessionId: string, toolName: string, input: unknown, cwd: string): void {
+		const state = this.sessions.get(sessionId);
+		if (!state?.primary || state.childDepth > 0 || state.firstSuccessfulPath) return;
+		const path = sessionPath(toolName, input, cwd);
+		if (path) state.firstSuccessfulPath = path;
+	}
+}