gentle-pi 2.7.0 → 3.0.0

package/tests/package-manifest.test.ts

@@ -12,6 +12,7 @@ import {
 import { homedir, tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import test from "node:test";
+import ts from "typescript";
 import { fileURLToPath } from "node:url";
 import { applyModelConfig } from "../extensions/gentle-ai.ts";
 import { resolveGentlePiAgentHome } from "../lib/agent-home.ts";
@@ -182,7 +183,7 @@ test("npm publication is bound to the exact package tag and triggering commit",
 		packageJson.repository,
 		{
 			type: "git",
-			url: "git+https://github.com/Gentleman-Programming/gentle-pi.git",
+			url: "git+https://github.com/Gentleman-Programming/gentle-shell.git",
 		},
 		"trusted publishing requires the exact case-sensitive npm repository identity",
 	);
@@ -218,11 +219,29 @@ test("generated runtime modules and packed-package checks are deterministic", ()
 	assert.match(ci, /pnpm run check:runtime-modules/);
 	assert.match(ci, /pnpm run test:packed-package/);
 	assert.match(generator, /Generated by scripts\/build-runtime-modules\.mjs/);
-	assert.match(packedRunner, /\["install"[^\]]*"--ignore-scripts=false"/s, "packed install must explicitly enable postinstall");
-	assert.doesNotMatch(packedRunner, /\["install"[^\]]*"--ignore-scripts"(?!\=false)/s);
-	assert.match(packedRunner, /execFileSync\("where\.exe", \["npm"\]/);
-	assert.match(packedRunner, /could not resolve npm-cli\.js without a command shell/);
-	assert.doesNotMatch(packedRunner, /ComSpec|cmd\.exe/);
+	const ordinaryPostinstall = readNamedFunction(packedRunner, "testHookedPackedRunner");
+	assert.match(ordinaryPostinstall, /\["install"[^\]]*"--ignore-scripts=false"/s, "ordinary packed install must explicitly enable postinstall");
+	assert.doesNotMatch(ordinaryPostinstall, /\["install"[^\]]*"--ignore-scripts"(?!\=false)/s);
+	for (const name of [
+		"testSdkLifecyclePackedSession",
+		"testWindowsStartupTimingPackedHelper",
+		"testWindowsStartupTimingEnvironmentExperiment",
+		"testUnhookedPackedImports",
+	]) {
+		const isolatedInstall = readNamedFunction(packedRunner, name);
+		assert.match(isolatedInstall, /\["install"[^\]]*"--ignore-scripts"(?!\=false)/s, `${name} must isolate installation scripts`);
+		assert.doesNotMatch(isolatedInstall, /\["install"[^\]]*"--ignore-scripts=false"/s, `${name} must not enable postinstall`);
+	}
+	const windowsNpmInvocation = readNamedFunction(packedRunner, "windowsNpmInvocation");
+	const runNpmWithEnv = readNamedFunction(packedRunner, "runNpmWithEnv");
+	assert.match(windowsNpmInvocation, /execFileSync\("where\.exe", \["npm"\]/);
+	assert.match(windowsNpmInvocation, /return \{ file: process\.execPath, prefix: \[installedCli\] \}/);
+	assert.match(windowsNpmInvocation, /return \{ file: path, prefix: \[\] \}/);
+	assert.match(windowsNpmInvocation, /could not resolve npm-cli\.js without a command shell/);
+	assert.doesNotMatch(windowsNpmInvocation, /ComSpec|cmd\.exe/);
+	assert.match(runNpmWithEnv, /execFileSync\(invocation\.file, \[\.\.\.invocation\.prefix, \.\.\.arguments_\]/);
+	assert.match(runNpmWithEnv, /\.\.\.options, env/);
+	assert.doesNotMatch(packedRunner, /shell\s*:\s*true/);
 	assert.match(packedRunner, /review", "capabilities", "--contract", "gentle-ai\.review-integration\/v2"/);
 	assert.doesNotMatch(packedRunner, /git-commit-transaction|transaction runner/i);
 });
@@ -247,8 +266,8 @@ test("package manifest installs pi-pretty through a wrapper without bundling nat
 
 	assert.equal(
 		packageJson.dependencies?.["@heyhuynhgiabuu/pi-pretty"],
-		"0.6.14",
-		"gentle-pi must install the tested pi-pretty version as a normal dependency",
+		"0.6.27",
+		"gentle-pi must install the tested pi-pretty version containing the model-visible result integrity fix",
 	);
 	assert.ok(
 		packageJson.pi?.extensions?.includes("./extensions"),
@@ -260,10 +279,22 @@ test("package manifest installs pi-pretty through a wrapper without bundling nat
 		),
 		"gentle-pi must not reference pnpm-unportable nested node_modules paths",
 	);
+	const piPrettyWrapperPath = join(PACKAGE_ROOT, "extensions", "pi-pretty.ts");
 	assert.ok(
-		existsSync(join(PACKAGE_ROOT, "extensions", "pi-pretty.ts")),
+		existsSync(piPrettyWrapperPath),
 		"gentle-pi must expose pi-pretty through a packaged wrapper extension",
 	);
+	const piPrettyWrapper = readFileSync(piPrettyWrapperPath, "utf8");
+	assert.match(
+		piPrettyWrapper,
+		/import\("@heyhuynhgiabuu\/pi-pretty"\)/,
+		"the wrapper must use the compiled-runtime-safe ESM loader",
+	);
+	assert.doesNotMatch(
+		piPrettyWrapper,
+		/requireFromRealPackage\("@heyhuynhgiabuu\/pi-pretty"\)/,
+		"the wrapper must not resolve the pi-pretty package root through createRequire",
+	);
 	assert.ok(
 		existsSync(join(PACKAGE_ROOT, "extensions", "quiet-tools.ts")),
 		"gentle-pi must expose quiet built-in tool rendering through a packaged extension",
@@ -355,6 +386,46 @@ function nestedContractFields(contract: string, parent: string): string[] {
 	return contractFields(nestedBlock.join("\n"), 2);
 }
 
+function readNamedFunction(source: string, name: string): string {
+	const fileName = "test-packed-runner.mjs";
+	const options: ts.CompilerOptions = {
+		allowJs: true,
+		noLib: true,
+		noResolve: true,
+		target: ts.ScriptTarget.Latest,
+	};
+	const host = ts.createCompilerHost(options, true);
+	host.getSourceFile = (requested, languageVersion) =>
+		requested === fileName
+			? ts.createSourceFile(requested, source, languageVersion, true, ts.ScriptKind.JS)
+			: undefined;
+	host.fileExists = (requested) => requested === fileName;
+	host.readFile = (requested) => requested === fileName ? source : undefined;
+	host.getCurrentDirectory = () => ".";
+	host.writeFile = () => {};
+	const program = ts.createProgram([fileName], options, host);
+	const sourceFile = program.getSourceFile(fileName);
+	assert.ok(sourceFile, "packed runner source must be available to the in-memory compiler host");
+	assert.equal(program.getSyntacticDiagnostics(sourceFile).length, 0, "packed runner source must have no syntactic diagnostics");
+	const declarations = sourceFile.statements.filter(
+		(statement): statement is ts.FunctionDeclaration =>
+			ts.isFunctionDeclaration(statement) && statement.name?.text === name,
+	);
+	assert.equal(declarations.length, 1, `packed runner must define exactly one top-level ${name}`);
+	const declaration = declarations[0];
+	assert.ok(declaration.body, `${name} must have a complete function body`);
+	assert.ok(declaration.body.end > declaration.body.pos, `${name} must have a non-empty function body`);
+	return source.slice(declaration.getStart(sourceFile), declaration.end);
+}
+
+test("readNamedFunction fails closed for missing, duplicate, and incomplete declarations", () => {
+	assert.equal(readNamedFunction("function target() { return 1; }\nfunction neighbor() { return 2; }\n", "target"), "function target() { return 1; }");
+	assert.throws(() => readNamedFunction("const target = () => {};\n", "target"), /exactly one top-level target/);
+	assert.throws(() => readNamedFunction("function target() {}\nfunction target() {}\n", "target"), /exactly one top-level target/);
+	assert.throws(() => readNamedFunction("function target() {\n", "target"), /packed runner source must have no syntactic diagnostics/);
+	assert.throws(() => readNamedFunction("function target() {}\nfunction neighbor( {}\n", "target"), /packed runner source must have no syntactic diagnostics/);
+});
+
 function readMarkdownSection(source: string, heading: string): string {
 	const lines = source.split(/\r?\n/);
 	const matches = lines.flatMap((line, index) => {
@@ -548,7 +619,7 @@ const EXPECTED_OWNER_ASSETS: Record<PackageAssetOwner, readonly string[]> = {
 		"agents/sdd-apply.md", "agents/sdd-archive.md", "agents/sdd-design.md",
 		"agents/sdd-explore.md", "agents/sdd-init.md", "agents/sdd-onboard.md",
 		"agents/sdd-proposal.md", "agents/sdd-remediate.md", "agents/sdd-research.md", "agents/sdd-spec.md",
-		"agents/sdd-status.md", "agents/sdd-sync.md", "agents/sdd-tasks.md", "agents/sdd-verify.md",
+		"agents/sdd-status.md", "agents/sdd-tasks.md", "agents/sdd-verify.md",
 		"chains/sdd-full.chain.md", "chains/sdd-plan.chain.md", "chains/sdd-verify.chain.md",
 		"gentle-ai/support/sdd-status-contract.md", "gentle-ai/support/strict-tdd-verify.md",
 		"gentle-ai/support/strict-tdd.md",
@@ -591,10 +662,10 @@ test("legacy all-assets installation covers every packaged file with explicit ow
 		assert.equal(getPackageAssetOwner(key), undefined, "unknown assets must not default to SDD");
 	}
 	withIsolatedAssetHome((agentHome) => {
-		assert.deepEqual(installSddAssets(agentHome, false), { agents: 24, chains: 4, support: 3, skipped: 0 });
+		assert.deepEqual(installSddAssets(agentHome, false), { agents: 23, chains: 4, support: 3, skipped: 0 });
 		assert.deepEqual(Object.keys(installedAssetManifest(agentHome).assets).sort(), packaged);
-		assert.deepEqual(installSddAssets(agentHome, false), { agents: 0, chains: 0, support: 0, skipped: 31 });
-		assert.deepEqual(installSddAssets(agentHome, true), { agents: 24, chains: 4, support: 3, skipped: 0 });
+		assert.deepEqual(installSddAssets(agentHome, false), { agents: 0, chains: 0, support: 0, skipped: 30 });
+		assert.deepEqual(installSddAssets(agentHome, true), { agents: 23, chains: 4, support: 3, skipped: 0 });
 	});
 });
 
@@ -651,14 +722,8 @@ test("selective review migration adopts only untouched legacy copies and preserv
 });
 
 test("unowned legacy research migrates by exact normalized hash, preserving routing and user edits", () => {
-	const packaged = readFileSync(join(PACKAGE_ROOT, "assets", "agents", "sdd-research.md"), "utf8");
-	const oldAdmission = "- Evidence grants for this runtime are `documentation=[]; open-web=[]`. Never infer evidence capability from bash, persistence tools, or any inherited tool; persistence tools are not evidence grants. Unsupported or undeclared classes deny admission and emit no claims.\n- Because this runtime declares no evidence grants, retain the selected request, persist a `blocked` outcome with no claims, and stop.\n";
-	const legacy = packaged
-		.replace(/## Parent Preflight Transport\n[\s\S]*?(?=## Skill Resolution Contract)/, "")
-		.replace(/## Bounded artifact handoff\n[\s\S]*?(?=## Memory Contract)/, "")
-		.replace(/  - fetch_content\n  - web_search\n  - source_check\n  - get_search_content\n/, "")
-		.replace(/- Use the injected `## SDD Research Capabilities`[\s\S]*?(?=- Admission denial)/, oldAdmission)
-		.replace(/Use `done` only when all selected questions[\s\S]*?product decisions remain separately confirmed by the parent\./i, "For this runtime the outcome is `blocked` with an admission denial and no claims.");
+	// Historical bytes must not be reconstructed from the evolving current agent.
+	const legacy = readFileSync(join(PACKAGE_ROOT, "tests/fixtures/legacy/sdd-research-v2.5.0.md"), "utf8");
 	const manifest = JSON.parse(readFileSync(join(PACKAGE_ROOT, "assets", "migrations", "managed-assets-v2.5.0.json"), "utf8"));
 	assert.equal(sha256(legacy), manifest.assets["agents/sdd-research.md"], "fixture reconstruction must match observed old package bytes");
 	const temporary = mkdtempSync(join(tmpdir(), "gentle-research-migration-"));
@@ -1496,22 +1561,22 @@ test("orchestrator routes generic roles without static RDD lens routing", () =>
 	assert.match(core, /this package invents no lifecycle instructions/);
 });
 
-test("pi-pretty wrapper uses real package path resolution for pnpm symlink installs", () => {
+test("pi-pretty wrapper uses cached ESM loading for compiled and pnpm symlink installs", () => {
 	const wrapper = readFileSync(
 		join(PACKAGE_ROOT, "extensions", "pi-pretty.ts"),
 		"utf8",
 	);
 
-	assert.match(wrapper, /realpathSync/);
-	assert.match(wrapper, /createRequire/);
-	assert.match(wrapper, /@heyhuynhgiabuu\/pi-pretty/);
+	assert.doesNotMatch(wrapper, /realpathSync|createRequire/);
+	assert.match(wrapper, /piPrettyExtensionPromise/);
+	assert.match(wrapper, /import\("@heyhuynhgiabuu\/pi-pretty"\)/);
 	assert.match(wrapper, /PI_PRETTY_SUPPRESSED_TOOL_NAMES/);
 	assert.match(wrapper, /quietToolsEnabled/);
 });
 
-test("v2.7.0 release package and runtime stop before publication", () => {
+test("v3.0.0 release package and runtime stop before publication", () => {
 	const packageJson = readPackageJson();
-	assert.equal(packageJson.version, "2.7.0", "the release manifest must remain explicitly pinned to v2.7.0");
+	assert.equal(packageJson.version, "3.0.0", "the release manifest must remain explicitly pinned to v3.0.0");
 	assert.equal(
 		packageJson.scripts?.test,
 		"node --experimental-strip-types --test tests/*.test.ts && pnpm run check:provider-contract && pnpm run test:harness",
@@ -1559,3 +1624,26 @@ test("technical reference documents dynamic Gentle AI RDD ownership and the inst
 test("package verification explicitly requires the managed remediation actor", () => {
 	assert.match(readFileSync(join(PACKAGE_ROOT, "scripts/verify-package-files.mjs"), "utf8"), /assets\/agents\/sdd-remediate\.md/);
 });
+
+test("SDD installation retires owned sync but preserves modified copies and unrelated owners", () => {
+	withIsolatedAssetHome((agentHome) => {
+		installSddAssets(agentHome, false);
+		const path = join(agentHome, "agents/sdd-sync.md");
+		const manifestPath = join(agentHome, "gentle-ai/managed-assets.json");
+		const legacy = "Previously managed sync executor\n";
+		const manifest = installedAssetManifest(agentHome);
+		manifest.assets["agents/sdd-sync.md"] = sha256(legacy);
+		writeFileSync(path, legacy);
+		writeFileSync(manifestPath, JSON.stringify(manifest));
+		installPackageAssets(agentHome, true, ["delegation"]);
+		assert.equal(readFileSync(path, "utf8"), legacy);
+		installPackageAssets(agentHome, true, ["sdd"]);
+		assert.equal(existsSync(path), false);
+		assert.equal(installedAssetManifest(agentHome).assets["agents/sdd-sync.md"], undefined);
+		writeFileSync(path, "User-modified sync instructions\n");
+		writeFileSync(manifestPath, JSON.stringify(manifest));
+		installPackageAssets(agentHome, true, ["sdd"]);
+		assert.equal(readFileSync(path, "utf8"), "User-modified sync instructions\n");
+		assert.equal(installedAssetManifest(agentHome).assets["agents/sdd-sync.md"], undefined);
+	});
+});

package/tests/persona-single-channel.test.ts

@@ -262,7 +262,7 @@ test("Table A rule: wrapper :180/:181 + orchestrator :9,:12 self-description MER
 		);
 		assert.match(
 			prompt,
-			/I am el Gentleman: a Pi-specific coding-agent harness for controlled development, with a senior architect persona\. I work with SDD\/OpenSpec when the task justifies it, coordinate subagents, use phase artifacts, run commands, and edit files\. I am not a generic chatbot\./,
+			/I am el Gentleman: a Pi-specific coding-agent harness for controlled development, with a senior architect persona\. I run Organic Driven Development by default and SDD\/OpenSpec when explicitly selected, coordinate subagents, use phase artifacts, run commands, and edit files\. I am not a generic chatbot\./,
 			`[${persona}] the richer translated self-description paragraph (orchestrator :9,:12) must survive in the wrapper`,
 		);
 	}
@@ -295,7 +295,7 @@ test("Table A rule: SDD/OpenSpec artifacts + subagents core-capabilities bullet
 		const prompt = __testing.buildGentlePrompt(persona);
 		assert.match(
 			prompt,
-			/Mention SDD\/OpenSpec phase artifacts and subagents as core capabilities\./,
+			/Mention ODD as the default workflow, SDD\/OpenSpec phase artifacts, and subagents as core capabilities\./,
 			`[${persona}] wrapper :182 rule must survive`,
 		);
 	}
@@ -439,7 +439,7 @@ test("dup guard (exact-string): 'Do not claim portability outside the Pi runtime
 
 test("dup guard (exact-string): identity self-description sentence occurs exactly once", () => {
 	const selfDescription =
-		"I am el Gentleman: a Pi-specific coding-agent harness for controlled development, with a senior architect persona. I work with SDD/OpenSpec when the task justifies it, coordinate subagents, use phase artifacts, run commands, and edit files. I am not a generic chatbot.";
+		"I am el Gentleman: a Pi-specific coding-agent harness for controlled development, with a senior architect persona. I run Organic Driven Development by default and SDD/OpenSpec when explicitly selected, coordinate subagents, use phase artifacts, run commands, and edit files. I am not a generic chatbot.";
 	for (const persona of ["gentleman", "neutral"] as const) {
 		const prompt = __testing.buildGentlePrompt(persona);
 		assert.equal(

package/tests/pi-pretty.test.ts

@@ -0,0 +1,45 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import pretty from "../extensions/pi-pretty.ts";
+
+test("bundled pretty cannot replace or restore an editor owned by the host", async () => {
+	const handlers = new Map<string, Function[]>();
+	const pi = { on(name: string, handler: Function) { handlers.set(name, [...(handlers.get(name) ?? []), handler]); } };
+	const owner = () => "custom";
+	let editor: unknown = owner;
+	let indicator: unknown;
+	let message: unknown;
+	let visible = true;
+	const ctx = { mode: "tui", ui: {
+		getEditorComponent: () => editor,
+		setEditorComponent: (value: unknown) => { editor = value; },
+		setWorkingIndicator: (value: unknown) => { indicator = value; },
+		setWorkingMessage: (value: unknown) => { message = value; },
+		setWorkingVisible(value: boolean) { visible = value; },
+		theme: { fg: (role: string, text: string) => `<${role}>${text}</${role}>`, bold: (text: string) => text },
+	} };
+	await pretty(pi, undefined, async (api: any) => {
+		api.on("session_start", (_event: unknown, context: any) => {
+			context.ui.setEditorComponent(() => "pretty");
+			context.ui.setWorkingIndicator({ frames: ["foreign"] });
+		});
+		api.on("session_shutdown", (_event: unknown, context: any) => context.ui.setEditorComponent(undefined));
+	}, {});
+	for (const handler of handlers.get("session_start") ?? []) await handler({}, ctx);
+	assert.equal(editor, owner);
+	assert.equal(visible, false, "the prompt frame owns the live working state without a duplicate loader row");
+	assert.equal(indicator, undefined);
+	assert.equal(message, undefined);
+	for (const handler of handlers.get("session_shutdown") ?? []) await handler({}, ctx);
+	assert.equal(editor, owner);
+	assert.equal(visible, true);
+	assert.equal(indicator, undefined);
+	assert.equal(message, undefined);
+});
+
+test("disabled shell leaves bundled editor behavior untouched", async () => {
+	let received: unknown;
+	const pi = {};
+	await pretty(pi, undefined, async (api: unknown) => { received = api; }, { GENTLE_PI_SHELL: "0" });
+	assert.equal(received, pi);
+});