gentle-pi 2.2.0 → 2.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (160) hide show
  1. package/README.md +76 -79
  2. package/assets/agents/review-readability.md +0 -2
  3. package/assets/agents/review-reliability.md +0 -2
  4. package/assets/agents/review-resilience.md +0 -2
  5. package/assets/agents/review-risk.md +0 -2
  6. package/assets/agents/sdd-apply.md +5 -3
  7. package/assets/agents/sdd-explore.md +1 -0
  8. package/assets/agents/sdd-proposal.md +2 -0
  9. package/assets/agents/sdd-research.md +54 -0
  10. package/assets/agents/sdd-status.md +4 -4
  11. package/assets/agents/sdd-tasks.md +2 -3
  12. package/assets/agents/sdd-verify.md +21 -1
  13. package/assets/chains/sdd-full.chain.md +1 -1
  14. package/assets/chains/sdd-verify.chain.md +1 -1
  15. package/assets/orchestrator-delegation.md +56 -249
  16. package/assets/orchestrator-memory.md +2 -0
  17. package/assets/orchestrator.md +20 -40
  18. package/assets/sdd-orchestrator-workflow.md +30 -37
  19. package/assets/support/sdd-status-contract.md +7 -7
  20. package/contracts/review-integration/v1/schemas/transition-execution.schema.json +42 -0
  21. package/contracts/review-integration/v2/schemas/last-event-closure.schema.json +66 -0
  22. package/contracts/review-integration/v2/schemas/opencode-provider-role.schema.json +14 -0
  23. package/contracts/review-provider-contract-mirror/provider-contract.lock.json +8 -7
  24. package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/README.md +10 -0
  25. package/contracts/review-provider-contract-mirror/v1.2.0/bundle/manifest.json +74 -0
  26. package/contracts/review-provider-contract-mirror/v1.2.0/bundle/orchestration/pi.md +53 -0
  27. package/contracts/review-provider-contract-mirror/v1.2.0/bundle/schemas/targeted-validator.schema.json +1 -0
  28. package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/generated/provider-capabilities.baseline.json +9 -2
  29. package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/generated/provider-roles.baseline.json +2 -2
  30. package/docs/native-authority-architecture.md +9 -11
  31. package/docs/review-integration.md +27 -373
  32. package/extensions/ask-user-choice.ts +151 -0
  33. package/extensions/gentle-ai.ts +2349 -3785
  34. package/extensions/quiet-tools.ts +515 -32
  35. package/extensions/sdd-init.ts +4 -8
  36. package/lib/agent-home.ts +8 -0
  37. package/lib/gentle-ai-renderer.ts +70 -0
  38. package/lib/model-routing-authority.ts +133 -0
  39. package/lib/native-review-cli.ts +387 -940
  40. package/lib/opaque-pi-reviewer-adapter.ts +284 -0
  41. package/lib/provider-contract-bundle.ts +88 -6
  42. package/lib/review-candidate-view.ts +341 -132
  43. package/lib/review-host-relay.ts +324 -96
  44. package/lib/review-integration-v2.ts +868 -307
  45. package/lib/review-last-event-controller.ts +35 -0
  46. package/lib/sdd-preflight.ts +179 -68
  47. package/lib/sdd-status.ts +66 -111
  48. package/lib/terminal-theme.ts +1 -1
  49. package/package.json +83 -82
  50. package/runtime/gentle-ai-binary.mjs +1 -1
  51. package/runtime/native-review-cli.mjs +337 -890
  52. package/runtime/review-integration-v2.mjs +816 -255
  53. package/runtime/review-relay-contract.mjs +1 -1
  54. package/scripts/{build-git-commit-transaction-runner.mjs → build-runtime-modules.mjs} +4 -5
  55. package/scripts/gentle-ai-installer.mjs +75 -22
  56. package/scripts/maintainer/provider-relay-matrix.mjs +195 -11
  57. package/scripts/test-packed-runner.mjs +4 -7
  58. package/scripts/verify-package-files.mjs +23 -23
  59. package/skills/_shared/review-ledger-contract.md +14 -14
  60. package/skills/chained-pr/SKILL.md +3 -0
  61. package/skills/cognitive-doc-design/SKILL.md +1 -1
  62. package/skills/comment-writer/SKILL.md +1 -1
  63. package/skills/gentle-ai/SKILL.md +7 -74
  64. package/skills/issue-creation/SKILL.md +53 -93
  65. package/skills/judgment-day/SKILL.md +5 -7
  66. package/skills/rdd-defect-workflow/SKILL.md +3 -3
  67. package/skills/release/SKILL.md +3 -3
  68. package/skills/skill-registry/SKILL.md +1 -1
  69. package/skills/work-unit-commits/SKILL.md +3 -1
  70. package/tests/artifact-language.test.ts +24 -11
  71. package/tests/ask-user-choice.test.ts +264 -0
  72. package/tests/codegraph-tools.test.ts +3 -3
  73. package/tests/crosslane/cross-lane.mjs +15 -1168
  74. package/tests/delegated-key-learnings-contract.test.ts +8 -6
  75. package/tests/devbinary/native-review-parity.devtest.ts +167 -250
  76. package/tests/devbinary/pi-host-relay.devtest.ts +867 -0
  77. package/tests/fixtures/devbinary/last-event-capture-correction-plan.captured.json +10 -0
  78. package/tests/fixtures/devbinary/last-event-capture-refuter-approved.captured.json +20 -0
  79. package/tests/fixtures/devbinary/last-event-capture-refuter-correction-required.captured.json +26 -0
  80. package/tests/fixtures/devbinary/last-event-capture-result-approved.captured.json +8 -0
  81. package/tests/fixtures/devbinary/last-event-capture-result-correction-required.captured.json +26 -0
  82. package/tests/fixtures/devbinary/last-event-capture-validation-approved.captured.json +8 -0
  83. package/tests/fixtures/devbinary/last-event-closure.provenance.md +13 -0
  84. package/tests/fixtures/devbinary/review-acknowledged-v1.captured.json +9 -0
  85. package/tests/fixtures/devbinary/review-acknowledged.provenance.md +31 -0
  86. package/tests/fixtures/devbinary/start-v3-zero-lens-closed.captured.json +21 -0
  87. package/tests/fixtures/native-review-cli/v2.5.0-rc.1/PROVENANCE.txt +15 -0
  88. package/tests/fixtures/provider-contract-bundle/v1.2.0/README.md +22 -0
  89. package/{contracts/review-provider-contract-mirror/v1.1.0/bundle → tests/fixtures/provider-contract-bundle/v1.2.0}/manifest.json +11 -2
  90. package/tests/fixtures/provider-contract-bundle/v1.2.0/orchestration/pi.md +97 -0
  91. package/tests/fixtures/provider-contract-bundle/v1.2.0/schemas/lens.schema.json +16 -0
  92. package/tests/fixtures/provider-contract-bundle/v1.2.0/schemas/refuter.schema.json +1 -0
  93. package/tests/fixtures/provider-contract-bundle/v1.2.0/vectors/lens.json +1 -0
  94. package/tests/fixtures/provider-contract-bundle/v1.2.0/vectors/refuter.json +1 -0
  95. package/tests/fixtures/provider-contract-bundle/v1.2.0/vectors/targeted-validator.json +1 -0
  96. package/tests/gentle-ai-binary.test.ts +83 -13
  97. package/tests/gentle-ai-dev-binary.test.ts +51 -228
  98. package/tests/gentle-ai-installer.test.ts +137 -47
  99. package/tests/gentle-ai.test.ts +821 -131
  100. package/tests/gentle-theme.test.ts +133 -0
  101. package/tests/issue-creation-skill.test.ts +103 -0
  102. package/tests/maintainer/provider-relay.maintest.ts +340 -4
  103. package/tests/model-routing-authority.test.ts +257 -0
  104. package/tests/native-review-capability-contract.test.ts +45 -1
  105. package/tests/native-review-cli.test.ts +586 -962
  106. package/tests/native-review-consent.test.ts +150 -66
  107. package/tests/native-review-parity-runtime.test.ts +80 -359
  108. package/tests/native-review-parity.test.ts +674 -925
  109. package/tests/opaque-pi-reviewer-adapter.test.ts +266 -0
  110. package/tests/orchestrator-budget.test.ts +132 -88
  111. package/tests/orchestrator-rdd-ownership.test.ts +103 -0
  112. package/tests/package-manifest.test.ts +152 -36
  113. package/tests/provider-contract-bundle.test.ts +76 -0
  114. package/tests/provider-contract-mirror.test.ts +19 -0
  115. package/tests/provider-defect-handoff.test.ts +15 -118
  116. package/tests/quiet-tool-rendering.test.ts +1055 -28
  117. package/tests/review-agent-end-preflight.test.ts +408 -0
  118. package/tests/review-authority-recovery-docs.test.ts +1 -2
  119. package/tests/review-candidate-view.test.ts +409 -3
  120. package/tests/review-compact-contract.test.ts +4 -30
  121. package/tests/review-contract-prompt.test.ts +139 -0
  122. package/tests/review-controller-lock-status.test.ts +2 -2
  123. package/tests/review-controller-native-recovery.test.ts +363 -1450
  124. package/tests/review-controller-native-routing.test.ts +1251 -5642
  125. package/tests/review-controller-retired-ops.test.ts +1 -1
  126. package/tests/review-controller-workspace-root.test.ts +222 -71
  127. package/tests/review-controller.test.ts +26 -816
  128. package/tests/review-corrected-finalize-binding.test.ts +112 -153
  129. package/tests/review-dispatch-hydration-gap.test.ts +1 -53
  130. package/tests/review-gate.test.ts +0 -45
  131. package/tests/review-host-relay-restart-parity.test.ts +360 -0
  132. package/tests/review-host-relay-routing.test.ts +328 -91
  133. package/tests/review-host-relay.test.ts +436 -14
  134. package/tests/review-integration-v2-forward.test.ts +623 -553
  135. package/tests/review-integration-v2.test.ts +239 -165
  136. package/tests/review-last-event-closure.test.ts +408 -0
  137. package/tests/review-ledger-contract.test.ts +97 -35
  138. package/tests/review-recovered-lineage-routing.test.ts +0 -47
  139. package/tests/review-relay-transport-agent.test.ts +119 -46
  140. package/tests/review-snapshot.test.ts +3 -2
  141. package/tests/runtime-harness.mjs +362 -196
  142. package/tests/sdd-agent-tools.test.ts +36 -0
  143. package/tests/sdd-preflight.test.ts +81 -15
  144. package/tests/sdd-status.test.ts +109 -110
  145. package/tests/skill-collision-prefixes.test.ts +5 -8
  146. package/tests/writer-edit-surface-scope.test.ts +366 -0
  147. package/themes/Gentleman-Cute.json +94 -0
  148. package/themes/Gentleman-Sexy.json +92 -0
  149. package/lib/git-commit-transaction.ts +0 -861
  150. package/runtime/git-commit-transaction.mjs +0 -862
  151. package/scripts/run-git-commit-transaction.mjs +0 -35
  152. package/tests/fixtures/native-review-cli/v2.1.3/sdd-status-engram.json +0 -139
  153. package/tests/fixtures/native-review-cli/v2.1.3/sdd-status.json +0 -200
  154. package/tests/git-commit-transaction.test.ts +0 -530
  155. /package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/schemas/lens.schema.json +0 -0
  156. /package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/schemas/refuter.schema.json +0 -0
  157. /package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/vectors/lens.json +0 -0
  158. /package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/vectors/refuter.json +0 -0
  159. /package/contracts/review-provider-contract-mirror/{v1.1.0 → v1.2.0}/bundle/vectors/targeted-validator.json +0 -0
  160. /package/{contracts/review-provider-contract-mirror/v1.1.0/bundle → tests/fixtures/provider-contract-bundle/v1.2.0}/schemas/targeted-validator.schema.json +0 -0
@@ -1,14 +1,10 @@
1
- // Generated by scripts/build-git-commit-transaction-runner.mjs. Do not edit.
1
+ // Generated by scripts/build-runtime-modules.mjs. Do not edit.
2
2
  export const REVIEW_INTEGRATION_CONTRACT = "gentle-ai.review-integration/v2";
3
3
 
4
4
  export const REVIEW_INTEGRATION_OPERATION = {
5
- BIND_SDD: "review.bind_sdd",
6
- CAPABILITIES: "review.capabilities",
7
- FINALIZE: "review.finalize",
8
5
  REPAIR: "review.repair",
9
6
  START: "review.start",
10
7
  STATUS: "review.status",
11
- VALIDATE: "review.validate",
12
8
  } ;
13
9
 
14
10
 
@@ -79,30 +75,27 @@ export const REVIEW_START_STATE = {
79
75
  } ;
80
76
 
81
77
 
82
- const START_ACTIONS = ["created", "resumed", "reuse-receipt", "blocked-scope-action"] ;
78
+ const START_ACTIONS = ["created", "resumed", "closed", "blocked-scope-action"] ;
83
79
  const RISK_LEVELS = ["low", "medium", "high"] ;
84
80
  const REVIEW_LENSES = ["review-risk", "review-resilience", "review-readability", "review-reliability"] ;
85
81
  const RISK_REASON_CODES = ["configuration_change", "empty_content", "executable_change", "executable_mode", "hot_path", "large_change", "non_executable_only", "process_boundary", "process_scan_limit", "service_token", "shell_source"] ;
86
82
  const RISK_SIGNALS = ["auth", "update", "security", "payments", "permissions", "shell_process"] ;
87
- const STATUS_ACTIONS = ["start", "finalize", "validate", "recover", "retry_final_verification", "maintainer_action", "select_lineage", "repair_authority", "reconcile_finalize", "stop"] ;
83
+ const STATUS_ACTIONS = ["start", "recover", "maintainer_action", "select_lineage", "repair_authority", "stop"] ;
84
+ const RECEIPT_STATUSES = ["expected_missing", "present", "publication_pending", "not_applicable"] ;
85
+
88
86
  export const REVIEW_STATUS_ACTION_DISPOSITION = {
89
87
  SCOPE_CHANGED: "scope_changed",
90
88
  INVALIDATED: "invalidated",
91
89
  ESCALATED: "escalated",
92
- FINAL_VERIFICATION_RETRY: "final_verification_retry",
93
90
  } ;
94
91
 
95
- const RECEIPT_STATUSES = ["expected_missing", "present", "publication_pending", "not_applicable"] ;
96
92
  const REQUIRED_OPERATIONS = Object.freeze(Object.values(REVIEW_INTEGRATION_OPERATION));
97
- // failure/v2 operations: the capability floor plus the four collect-capture
98
- // verbs that emit typed refusals on the gentle-ai main line (commit a2d57117,
99
- // fix/capture-evidence-typed-refusal; exact strings from that branch's
100
- // published failure.schema.json 12-value operation enum). Additive forward
101
- // surface: every operation outside the published enum still rejects.
93
+ // Typed failures are accepted only for the supported start, status, repair,
94
+ // and last-event capture operations. Retired lifecycle verbs fail closed.
102
95
  const FAILURE_OPERATIONS = Object.freeze([
103
96
  ...REQUIRED_OPERATIONS,
104
97
  "review.capture-result",
105
- "review.capture-evidence",
98
+ "review.capture-correction-plan",
106
99
  "review.capture-refuter",
107
100
  "review.capture-validation",
108
101
  ] );
@@ -125,7 +118,6 @@ const REQUIRED_SCHEMAS_COMMON = Object.freeze([
125
118
  "gentle-ai.review-integration.operation/v2",
126
119
  "gentle-ai.review-integration.projection/v1",
127
120
  "gentle-ai.review-integration.repair/v2",
128
- "gentle-ai.review-integration.start/v3",
129
121
  "gentle-ai.review-receipt/v1",
130
122
  "gentle-ai.review-receipt/v2",
131
123
  "gentle-ai.review-result-artifact/v2",
@@ -135,18 +127,75 @@ const REQUIRED_SCHEMAS_COMMON = Object.freeze([
135
127
  "https://gentle-ai.dev/schema/review/reviewer/v1",
136
128
  "https://gentle-ai.dev/schema/review/validator/v1",
137
129
  ] );
138
- const CAPABILITIES_SCHEMA_IDENTITIES = Object.freeze({
130
+ // The v2.3 provider contract (first advertised by the pinned v2.5.0-rc.3
131
+ // runtime) retired exact_receipt_replay, five_delivery_gates, and
132
+ // sdd_receipt_binding from the mandatory feature set and
133
+ // exact_gate_receipt_discovery, one_shot_final_verification_retry, and
134
+ // outcome_bound_verification_evidence from the optional set; none of them is
135
+ // consumed by Pi's negotiated v2 lane. Earlier minors keep their frozen
136
+ // requirement sets unchanged.
137
+ const REQUIRED_MANDATORY_FEATURES_V23 = Object.freeze([
138
+ "compact_v2_authority",
139
+ "immutable_snapshot",
140
+ "legacy_v1_target_scoped_read_only",
141
+ "repository_independent_capabilities",
142
+ "restart_safe_projection",
143
+ "target_scoped_status",
144
+ "uniform_failure_envelope",
145
+ ] );
146
+ // v2.3 (first advertised by the pinned v2.5.0-rc.3 provider) retired three
147
+ // v1-era identities from its advertisement. Pi never decodes those envelopes
148
+ // on the negotiated v2 lane, so the v2.3 requirement list is the exact set the
149
+ // v2.3 provider contract defines; earlier minors keep the full common list.
150
+ // The load-time length assertion keeps this filter honest: if the common-list
151
+ // identifier form ever drifts away from these bare identifiers, the module
152
+ // fails loudly instead of silently requiring schemas the provider retired.
153
+ const RETIRED_SCHEMAS_V23 = Object.freeze([
154
+ "gentle-ai.review-final-verification-incident/v1",
155
+ "gentle-ai.review-receipt/v2",
156
+ "gentle-ai.review-verification-evidence/v2",
157
+ ]);
158
+ const REQUIRED_SCHEMAS_COMMON_V23 = Object.freeze(REQUIRED_SCHEMAS_COMMON.filter((schema) => !RETIRED_SCHEMAS_V23.includes(schema)));
159
+ if (REQUIRED_SCHEMAS_COMMON_V23.length !== REQUIRED_SCHEMAS_COMMON.length - RETIRED_SCHEMAS_V23.length) {
160
+ throw new TypeError("v2.3 retired-schema filter must remove exactly the retired identities from the common schema list");
161
+ }
162
+ const CAPABILITIES_SCHEMA_IDENTITIES = Object.freeze({
139
163
  "gentle-ai.review-integration.capabilities/v2": Object.freeze({
140
164
  protocolMinor: 0,
141
- requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2", "gentle-ai.review-integration.consent/v2", "gentle-ai.review-integration.status/v3"]),
165
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2", "gentle-ai.review-integration.consent/v2", "gentle-ai.review-integration.start/v3", "gentle-ai.review-integration.status/v3"]),
142
166
  }),
143
167
  "gentle-ai.review-integration.capabilities/v2.1": Object.freeze({
144
168
  protocolMinor: 1,
145
- requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2.1", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.status/v3"]),
169
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2.1", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.start/v3", "gentle-ai.review-integration.status/v3"]),
146
170
  }),
147
171
  "gentle-ai.review-integration.capabilities/v2.2": Object.freeze({
148
172
  protocolMinor: 2,
149
- requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2.2", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.status/v5"]),
173
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON, "gentle-ai.review-integration.capabilities/v2.2", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.start/v3", "gentle-ai.review-integration.status/v5"]),
174
+ }),
175
+ "gentle-ai.review-integration.capabilities/v2.3": Object.freeze({
176
+ protocolMinor: 3,
177
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON_V23, "gentle-ai.review-integration.capabilities/v2.3", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.start/v4", "gentle-ai.review-integration.status/v5"]),
178
+ requiredMandatoryFeatures: REQUIRED_MANDATORY_FEATURES_V23,
179
+ optionalFeatureFloor: 14,
180
+ }),
181
+ "gentle-ai.review-integration.capabilities/v2.4": Object.freeze({
182
+ protocolMinor: 4,
183
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON_V23, "gentle-ai.review-integration.capabilities/v2.4", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.start/v4", "gentle-ai.review-integration.status/v6", "gentle-ai.review-intended-untracked-selection/v1"]),
184
+ requiredMandatoryFeatures: REQUIRED_MANDATORY_FEATURES_V23,
185
+ optionalFeatureFloor: 14,
186
+ }),
187
+ // Ground-truthed against the published v2.6.0 binary: capabilities/v2.5
188
+ // advertises the same required surface as v2.4 (status/v6 is still
189
+ // advertised for compatibility) plus the new status/v7 schema, which is a
190
+ // superset-checked addition, not a requirement -- decodeReviewStatusV3
191
+ // accepts v7 as an additive extension of v6, so the required-schema floor
192
+ // stays unchanged. The v2.6.0 binary advertised 15 optional features
193
+ // (floor stays at 14, its established minimum).
194
+ "gentle-ai.review-integration.capabilities/v2.5": Object.freeze({
195
+ protocolMinor: 5,
196
+ requiredSchemas: Object.freeze([...REQUIRED_SCHEMAS_COMMON_V23, "gentle-ai.review-integration.capabilities/v2.5", "gentle-ai.review-integration.consent/v3", "gentle-ai.review-integration.start/v4", "gentle-ai.review-integration.status/v6", "gentle-ai.review-intended-untracked-selection/v1"]),
197
+ requiredMandatoryFeatures: REQUIRED_MANDATORY_FEATURES_V23,
198
+ optionalFeatureFloor: 14,
150
199
  }),
151
200
  });
152
201
  const OPTIONAL_FEATURE_NAMES = Object.freeze([
@@ -272,7 +321,6 @@ const REQUIRED_MANDATORY_FEATURES = Object.freeze(FEATURE_NAMES.filter((name) =>
272
321
 
273
322
 
274
323
 
275
-
276
324
 
277
325
 
278
326
  const REPOSITORY_CONTEXT_OUTCOMES = ["applied", "pending", "blocked_conflict", "durability_limited"] ;
@@ -346,6 +394,12 @@ const REPOSITORY_CONTEXT_OUTCOMES = ["applied", "pending", "blocked_conflict", "
346
394
 
347
395
 
348
396
 
397
+
398
+
399
+
400
+
401
+
402
+
349
403
 
350
404
 
351
405
 
@@ -376,6 +430,8 @@ const REPOSITORY_CONTEXT_OUTCOMES = ["applied", "pending", "blocked_conflict", "
376
430
 
377
431
 
378
432
 
433
+
434
+
379
435
 
380
436
 
381
437
  // The two Go-owned non-lens provider role capture operations (gentle-pi#311
@@ -422,10 +478,6 @@ export const REVIEW_PROVIDER_ROLE_CAPTURE_OPERATIONS = Object.freeze(Object.valu
422
478
 
423
479
 
424
480
 
425
- // The two v5 Go-owned submission descriptor forms (finalize carries one
426
- // singular `value`; capture-evidence carries an outcome/input `values` pair).
427
- // Distinct from the host-relay ReviewCaptureSubmissionV1 form, which stays
428
- // exactly as it is.
429
481
 
430
482
 
431
483
 
@@ -525,11 +577,11 @@ export const REVIEW_PROVIDER_ROLE_CAPTURE_OPERATIONS = Object.freeze(Object.valu
525
577
 
526
578
 
527
579
 
580
+  
528
581
 
529
582
 
530
583
 
531
584
 
532
-  
533
585
 
534
586
 
535
587
 
@@ -567,6 +619,14 @@ export const REVIEW_PROVIDER_ROLE_CAPTURE_OPERATIONS = Object.freeze(Object.valu
567
619
  // blocking question with one net-new required member, the provider-fixed
568
620
  // `agent` runtime binding. Everything shared with v2 keeps its exact shape so
569
621
  // consumers of either identity read one structural surface.
622
+ export const REVIEW_CONSENT_AGENT_V3 = {
623
+ CLAUDE_CODE: "claude-code",
624
+ OPENCODE: "opencode",
625
+ CODEX: "codex",
626
+ PI: "pi",
627
+ } ;
628
+
629
+
570
630
 
571
631
 
572
632
 
@@ -586,12 +646,11 @@ const FAILURE_REQUIRED_INPUTS = [
586
646
  "disposition",
587
647
  "reason",
588
648
  "actor",
589
- "incident",
590
649
  "maintainer_authorization",
591
650
  "base_ref",
592
651
  ] ;
593
652
 
594
- const FAILURE_NEXT_ACTIONS = ["correct_request", "retry", "retry_with_bounded_backoff", "review.status", "review.finalize", "review.repair", "review.bind_sdd", "explicit-maintainer-action", "stop"] ;
653
+ const FAILURE_NEXT_ACTIONS = ["correct_request", "retry", "retry_with_bounded_backoff", "review.status", "review.repair", "explicit-maintainer-action", "stop"] ;
595
654
 
596
655
  // Known cause_category values: the vendored failure.schema.json enum plus
597
656
  // "incomplete_store_entry", which the v2.1.8 emitter produces beyond that enum.
@@ -650,6 +709,27 @@ const FAILURE_CAUSE_CATEGORIES = ["inventory_io_or_layout", "lock_ambiguous", "r
650
709
 
651
710
 
652
711
 
712
+ export const REVIEW_ADVISORY_FINDING_SEVERITY = {
713
+ BLOCKER: "BLOCKER",
714
+ CRITICAL: "CRITICAL",
715
+ WARNING: "WARNING",
716
+ SUGGESTION: "SUGGESTION",
717
+ } ;
718
+
719
+
720
+ export const REVIEW_ADVISORY_FINDING_DISPOSITION = {
721
+ INFORMATIONAL: "informational",
722
+ FOLLOW_UP: "follow_up",
723
+ REFUTED: "refuted",
724
+ } ;
725
+
726
+
727
+
728
+
729
+
730
+
731
+
732
+
653
733
 
654
734
 
655
735
 
@@ -906,11 +986,12 @@ export function decodeReviewCapabilitiesV2(value , verifiedExecutableDig
906
986
  assertSupersetOf(advertisedSchemas, identity.requiredSchemas, "capabilities schemas");
907
987
 
908
988
  const features = exactRecord(body.features, "capabilities.features", ["mandatory", "optional"]);
909
- const mandatory = array(features.mandatory, "capabilities.features.mandatory", (entry, label) => decodeFeature(entry, label), { minimum: 10 });
910
- const optional = array(features.optional, "capabilities.features.optional", (entry, label) => decodeOptionalFeature(entry, label), { minimum: 17, unique: true });
989
+ const requiredMandatoryFeatures = identity.requiredMandatoryFeatures ?? REQUIRED_MANDATORY_FEATURES;
990
+ const mandatory = array(features.mandatory, "capabilities.features.mandatory", (entry, label) => decodeFeature(entry, label), { minimum: requiredMandatoryFeatures.length });
991
+ const optional = array(features.optional, "capabilities.features.optional", (entry, label) => decodeOptionalFeature(entry, label), { minimum: identity.optionalFeatureFloor ?? 17, unique: true });
911
992
  const mandatoryNames = mandatory.map((feature) => feature.name);
912
993
  const optionalNames = optional.map((feature) => feature.name);
913
- assertExactSet(mandatoryNames, REQUIRED_MANDATORY_FEATURES, "mandatory capabilities");
994
+ assertExactSet(mandatoryNames, requiredMandatoryFeatures, "mandatory capabilities");
914
995
  if (new Set(optionalNames).size !== optionalNames.length) throw new TypeError("optional capabilities contain duplicate names");
915
996
  if (optionalNames.some((name) => mandatoryNames.includes(name ))) throw new TypeError("mandatory and optional capabilities overlap");
916
997
  if (mandatory.some((feature) => !feature.supported)) throw new TypeError("mandatory capability is unsupported");
@@ -1002,12 +1083,12 @@ function decodeChangedPathEntry(value , label )
1002
1083
  // start/v3
1003
1084
  // ---------------------------------------------------------------------------
1004
1085
 
1005
- export function decodeReviewStartV3(value ) {
1086
+ export function decodeReviewStartV3(value , overlayIdentitySatisfiesRepositoryContext = false) {
1006
1087
  const overlayFields = ["target_mode", "target_identity", "base_tree", "candidate_tree"] ;
1007
1088
  const body = exactRecord(value, "start", [
1008
1089
  "schema", "contract", "operation", "action", "lenses_required", "lineage_id", "state", "risk_level",
1009
1090
  "selected_lenses", "projection", "changed_files", "changed_lines", "correction_budget", "risk_reasons", "artifact_subjects",
1010
- ], [...overlayFields, "changed_path_manifest", "repository_context"]);
1091
+ ], [...overlayFields, "changed_path_manifest", "repository_context", "acknowledgement"]);
1011
1092
  requireIdentity(body, "gentle-ai.review-integration.start/v3", REVIEW_INTEGRATION_OPERATION.START);
1012
1093
 
1013
1094
  // dependentRequired binds base_tree<->candidate_tree bidirectionally, and
@@ -1036,9 +1117,12 @@ export function decodeReviewStartV3(value ) {
1036
1117
  throw new TypeError("start with selected_lenses requires base_tree, candidate_tree, and changed_path_manifest");
1037
1118
  }
1038
1119
 
1039
- const requiresRepositoryContext = (action === "created" || action === "resumed") && state === REVIEW_START_STATE.REVIEWING;
1120
+ const reviewingCreatedOrResumed = (action === "created" || action === "resumed") && state === REVIEW_START_STATE.REVIEWING;
1121
+ // START/v4 may render the frozen target as the overlay identity instead of
1122
+ // repository_context; absence is only excused when that identity is present.
1123
+ const requiresRepositoryContext = reviewingCreatedOrResumed && !(overlayIdentitySatisfiesRepositoryContext && targetIdentity !== undefined);
1040
1124
  if (requiresRepositoryContext && body.repository_context === undefined) throw new TypeError("start.repository_context is required when action is created/resumed and state is reviewing");
1041
- if (!requiresRepositoryContext && body.repository_context !== undefined) throw new TypeError("start.repository_context is only valid when action is created/resumed and state is reviewing");
1125
+ if (!reviewingCreatedOrResumed && body.repository_context !== undefined) throw new TypeError("start.repository_context is only valid when action is created/resumed and state is reviewing");
1042
1126
 
1043
1127
  let repositoryContext ;
1044
1128
  if (body.repository_context !== undefined) {
@@ -1046,7 +1130,7 @@ export function decodeReviewStartV3(value ) {
1046
1130
  if (source.capability !== "review.opaque_repository_context") throw new TypeError("start.repository_context.capability is unsupported");
1047
1131
  repositoryContext = {
1048
1132
  capability: "review.opaque_repository_context",
1049
- handle: text(source.handle, "start.repository_context.handle", { pattern: /^rctx1_[0-9a-f]{64}$/ }),
1133
+ handle: text(source.handle, "start.repository_context.handle", { pattern: /^rctx[12]_[0-9a-f]{64}$/ }),
1050
1134
  revision: sha256(source.revision, "start.repository_context.revision"),
1051
1135
  targetIdentity: sha256(source.target_identity, "start.repository_context.target_identity"),
1052
1136
  ...(source.event_id === undefined ? {} : { eventId: sha256(source.event_id, "start.repository_context.event_id") }),
@@ -1091,6 +1175,78 @@ export function decodeReviewStartV3(value ) {
1091
1175
  };
1092
1176
  }
1093
1177
 
1178
+ function assertReviewStartV4StatusBinding(execute , start ) {
1179
+ const expectedTargetIdentity = start.repositoryContext?.targetIdentity ?? start.targetIdentity;
1180
+ const targetIdentityConflicts = expectedTargetIdentity === undefined || execute.binding.targetIdentity !== expectedTargetIdentity
1181
+ || (start.targetIdentity !== undefined && start.targetIdentity !== expectedTargetIdentity)
1182
+ || start.artifactSubjects.some((subject) => subject.targetIdentity !== expectedTargetIdentity);
1183
+ if (targetIdentityConflicts) throw new TypeError("START/v4 status target identity binding conflicts with frozen START");
1184
+ if (execute.binding.lineageId !== undefined && execute.binding.lineageId !== start.lineageId) {
1185
+ throw new TypeError("START/v4 status lineage binding conflicts with frozen START");
1186
+ }
1187
+ const optionalSelectors = {
1188
+ "base-ref": start.baseTree,
1189
+ "base-tree": start.baseTree,
1190
+ projection: start.projection,
1191
+ target: expectedTargetIdentity,
1192
+ };
1193
+ const argumentsByName = new Map ();
1194
+ for (const argument of execute.arguments) {
1195
+ if (argumentsByName.has(argument.name)) throw new TypeError(`START/v4 status arguments duplicate ${argument.name} binding`);
1196
+ argumentsByName.set(argument.name, argument.value);
1197
+ if (Object.hasOwn(optionalSelectors, argument.name) && argument.value !== optionalSelectors[argument.name]) throw new TypeError(`START/v4 status ${argument.name} binding conflicts with frozen START`);
1198
+ }
1199
+ if (argumentsByName.get("lineage") !== start.lineageId) throw new TypeError("START/v4 status requires exactly one lineage binding for the frozen START");
1200
+ if (execute.arguments.find((argument) => argument.name === "lineage")?.token !== `--lineage=${start.lineageId}`) throw new TypeError("START/v4 status lineage binding conflicts with frozen START");
1201
+ for (const [name, value] of [["contract", REVIEW_INTEGRATION_CONTRACT], ["next-transition", "true"], ["agent", "pi"]]) {
1202
+ if (argumentsByName.get(name) !== value || execute.arguments.find((argument) => argument.name === name)?.token !== `--${name}=${value}`) throw new TypeError(`START/v4 status ${name} binding conflicts with frozen START`);
1203
+ }
1204
+ const selectorArguments = execute.selectorArguments;
1205
+ if (selectorArguments === undefined || selectorArguments.length === 0) throw new TypeError("START/v4 status selector arguments are required");
1206
+ const selectorsByName = new Map ();
1207
+ for (const selector of selectorArguments) {
1208
+ const full = execute.arguments.find((argument) => argument.name === selector.name);
1209
+ if (selectorsByName.has(selector.name) || full === undefined || full.value !== selector.value || full.token !== selector.token) throw new TypeError(`START/v4 status selector ${selector.name} binding conflicts with full arguments`);
1210
+ selectorsByName.set(selector.name, selector);
1211
+ }
1212
+ const selector = (name , value ) => {
1213
+ if (selectorsByName.get(name)?.value !== value || selectorsByName.get(name)?.token !== `--${name}=${value}` || execute.arguments.find((argument) => argument.name === name)?.token !== `--${name}=${value}`) throw new TypeError(`START/v4 status selector ${name} binding conflicts with frozen START`);
1214
+ };
1215
+ const baseRef = argumentsByName.get("base-ref");
1216
+ if (start.targetMode === "base-workspace-overlay") {
1217
+ if (baseRef !== start.baseTree || argumentsByName.has("committed-only")) throw new TypeError("START/v4 status workspace overlay binding conflicts with frozen START");
1218
+ selector("base-ref", start.baseTree ); selector("workspace-overlay", "true");
1219
+ } else if (baseRef !== undefined) {
1220
+ if (baseRef !== start.baseTree || argumentsByName.has("workspace-overlay")) throw new TypeError("START/v4 status committed range binding conflicts with frozen START");
1221
+ selector("base-ref", start.baseTree ); selector("committed-only", "true");
1222
+ } else {
1223
+ if (argumentsByName.has("committed-only") || argumentsByName.has("workspace-overlay")) throw new TypeError("START/v4 status current projection binding conflicts with frozen START");
1224
+ selector("projection", start.projection);
1225
+ }
1226
+ }
1227
+
1228
+ export function decodeReviewStartV4(value ) {
1229
+ const overlayFields = ["target_mode", "target_identity", "base_tree", "candidate_tree"] ;
1230
+ const body = exactRecord(value, "start", [
1231
+ "schema", "contract", "operation", "action", "lenses_required", "lineage_id", "state", "risk_level",
1232
+ "selected_lenses", "projection", "changed_files", "changed_lines", "correction_budget", "risk_reasons", "artifact_subjects",
1233
+ ], [...overlayFields, "changed_path_manifest", "repository_context", "acknowledgement", "next_transition"]);
1234
+ requireIdentity(body, "gentle-ai.review-integration.start/v4", REVIEW_INTEGRATION_OPERATION.START);
1235
+ const action = enumeration(body.action, ["created", "replayed", "closed", "blocked-scope-action"] , "start.action");
1236
+ const v3Action = action === "replayed" ? "resumed" : action;
1237
+ const nextTransition = body.next_transition === undefined ? undefined : decodeReviewNextTransitionV3(body.next_transition);
1238
+ const reviewing = (action === "created" || action === "replayed") && body.state === REVIEW_START_STATE.REVIEWING;
1239
+ if (reviewing && nextTransition?.kind !== "execute") throw new TypeError("reviewing created/replayed START requires next_transition.execute");
1240
+ if (reviewing && nextTransition.execute?.operation !== "review.status") throw new TypeError("reviewing created/replayed START next_transition.execute.operation must be review.status");
1241
+ const closedApprovedZeroLens = action === "closed" && body.state === REVIEW_START_STATE.APPROVED && Array.isArray(body.selected_lenses) && body.selected_lenses.length === 0;
1242
+ if (closedApprovedZeroLens && nextTransition !== undefined) throw new TypeError("closed approved zero-lens START cannot carry next_transition");
1243
+ const v3Body = { ...body };
1244
+ delete v3Body.next_transition;
1245
+ const decoded = decodeReviewStartV3({ ...v3Body, schema: "gentle-ai.review-integration.start/v3", action: v3Action }, true);
1246
+ if (reviewing) assertReviewStartV4StatusBinding(nextTransition .execute , decoded);
1247
+ return { ...decoded, action, ...(nextTransition === undefined ? {} : { nextTransition }), raw: body };
1248
+ }
1249
+
1094
1250
  // ---------------------------------------------------------------------------
1095
1251
  // projection/v1 — reused verbatim; the v2 capabilities schema still advertises
1096
1252
  // gentle-ai.review-integration.projection/v1, so renaming this decoder would
@@ -1188,36 +1344,13 @@ export function decodeAuthorityRepairAssessmentV1(value )
1188
1344
  };
1189
1345
  }
1190
1346
 
1191
- // ---------------------------------------------------------------------------
1192
- // targeted-validation-request/v1 — reused for status.validation_request,
1193
- // operation.result.validation_request, and next_transition collect inputs.
1194
- // ---------------------------------------------------------------------------
1195
-
1196
- function decodeTargetedValidationRequestV1(value , label ) {
1197
- const body = exactRecord(value, label, ["schema", "request_hash", "lineage_id", "expected_revision", "target_identity", "fix_finding_ids", "projection", "correction_candidate_tree", "correction_target_identity", "correction_paths", "correction_paths_digest"]);
1198
- if (body.schema !== "gentle-ai.review-targeted-validation-request/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-targeted-validation-request/v1`);
1199
- return {
1200
- schema: "gentle-ai.review-targeted-validation-request/v1",
1201
- requestHash: sha256(body.request_hash, `${label}.request_hash`),
1202
- lineageId: lineage(body.lineage_id, `${label}.lineage_id`),
1203
- expectedRevision: sha256(body.expected_revision, `${label}.expected_revision`),
1204
- targetIdentity: sha256(body.target_identity, `${label}.target_identity`),
1205
- fixFindingIds: stringArray(body.fix_finding_ids, `${label}.fix_finding_ids`, { minimum: 1, unique: true }),
1206
- projection: enumeration(body.projection, REQUIRED_PROJECTIONS, `${label}.projection`),
1207
- correctionCandidateTree: gitTree(body.correction_candidate_tree, `${label}.correction_candidate_tree`),
1208
- correctionTargetIdentity: sha256(body.correction_target_identity, `${label}.correction_target_identity`),
1209
- correctionPaths: stringArray(body.correction_paths, `${label}.correction_paths`, { minimum: 1, unique: true }),
1210
- correctionPathsDigest: sha256(body.correction_paths_digest, `${label}.correction_paths_digest`),
1211
- };
1212
- }
1213
-
1214
1347
  // ---------------------------------------------------------------------------
1215
1348
  // next-transition/v3 — net-new; unlike v1's decodeNextTransition (void),
1216
1349
  // this decoder returns a typed value so callers can read the manifest-bound
1217
1350
  // collect inputs and the execute binding.
1218
1351
  // ---------------------------------------------------------------------------
1219
1352
 
1220
- const NEXT_TRANSITION_OPERATIONS = ["review.start", "review.finalize", "review.recover", "review.repair", "review.validate"] ;
1353
+ const NEXT_TRANSITION_OPERATIONS = ["review.start", "review.status", "review.recover", "review.repair", "review.acknowledge-approved"] ;
1221
1354
 
1222
1355
  function decodeTransitionArguments(value , label ) {
1223
1356
  return array(value, label, (entry, entryLabel) => {
@@ -1229,7 +1362,29 @@ function decodeTransitionArguments(value , label )
1229
1362
  });
1230
1363
  }
1231
1364
 
1232
- function decodeCaptureSubmission(value , label , v5 ) {
1365
+ function decodeCaptureSubmission(value , label , v5 , v6 , captureOperation ) {
1366
+ // status/v6 adds the provider-owned intended-untracked selection form.
1367
+ if (v6 && captureOperation === "external.select_intended_untracked" && typeof value === "object" && value !== null && (value ).operation_token === "status") {
1368
+ const submission = exactRecord(value, label, ["operation_token", "argument_tokens", "value"]);
1369
+ const expectedTokens = [
1370
+ "--contract=gentle-ai.review-integration/v2", "--next-transition=true", "--agent=pi",
1371
+ "--projection=workspace", "--intended-untracked-selection={{value}}",
1372
+ ] ;
1373
+ const operationToken = enumeration(submission.operation_token, ["status"] , `${label}.operation_token`);
1374
+ const argumentTokens = stringArray(submission.argument_tokens, `${label}.argument_tokens`, { minimum: expectedTokens.length, maximum: expectedTokens.length });
1375
+ if (argumentTokens.some((token, index) => token !== expectedTokens[index])) throw new TypeError(`${label}.argument_tokens substitution binding is invalid`);
1376
+ const row = exactRecord(submission.value, `${label}.value`, ["slot", "domain", "schema", "substitution_location"]);
1377
+ return {
1378
+ operationToken,
1379
+ argumentTokens,
1380
+ values: [{
1381
+ slot: enumeration(row.slot, ["intended_untracked_selection"] , `${label}.value.slot`),
1382
+ domain: enumeration(row.domain, ["schema_bound_json"] , `${label}.value.domain`),
1383
+ schema: enumeration(row.schema, ["gentle-ai.review-intended-untracked-selection/v1"] , `${label}.value.schema`),
1384
+ substitutionLocation: integer(row.substitution_location, `${label}.value.substitution_location`, 4, 4),
1385
+ }],
1386
+ };
1387
+ }
1233
1388
  // status/v5: the live 2.4.0-main binary emits the materialize
1234
1389
  // capture-result submission as a SINGULAR `value` object carrying a
1235
1390
  // `schema` key (captured 2026-08-16 from 2.4.0-main.b1afef46; the
@@ -1240,16 +1395,22 @@ function decodeCaptureSubmission(value , label , v5 )
1240
1395
  // through to the legacy decoder, which rejects the unknown `value` key.
1241
1396
  if (v5 && typeof value === "object" && value !== null && "value" in value && !("values" in value)) {
1242
1397
  const submission = exactRecord(value, label, ["operation_token", "argument_tokens", "value"]);
1243
- if (submission.operation_token !== "capture-result") throw new TypeError(`${label}.operation_token must be capture-result for the singular value form`);
1398
+ const operationToken = enumeration(submission.operation_token, ["capture-result", "capture-correction-plan"] , `${label}.operation_token`);
1244
1399
  const argumentTokens = stringArray(submission.argument_tokens, `${label}.argument_tokens`, { minimum: 1 });
1245
- const row = exactRecord(submission.value, `${label}.value`, ["slot", "domain", "schema", "substitution_location"]);
1400
+ const row = operationToken === "capture-result"
1401
+ ? exactRecord(submission.value, `${label}.value`, ["slot", "domain", "schema", "substitution_location"])
1402
+ : exactRecord(submission.value, `${label}.value`, ["slot", "domain", "minimum", "maximum", "substitution_location"]);
1246
1403
  return {
1247
- operationToken: "capture-result",
1404
+ operationToken,
1248
1405
  argumentTokens,
1249
1406
  values: [{
1250
- slot: enumeration(row.slot, ["reviewer_result"] , `${label}.value.slot`),
1407
+ slot: operationToken === "capture-result"
1408
+ ? enumeration(row.slot, ["reviewer_result"] , `${label}.value.slot`)
1409
+ : enumeration(row.slot, ["correction_lines"] , `${label}.value.slot`),
1251
1410
  domain: nonempty(row.domain, `${label}.value.domain`),
1252
- schema: nonempty(row.schema, `${label}.value.schema`),
1411
+ ...(row.schema === undefined ? {} : { schema: nonempty(row.schema, `${label}.value.schema`) }),
1412
+ ...(row.minimum === undefined ? {} : { minimum: integer(row.minimum, `${label}.value.minimum`, 1, 200) }),
1413
+ ...(row.maximum === undefined ? {} : { maximum: integer(row.maximum, `${label}.value.maximum`, 1, 200) }),
1253
1414
  substitutionLocation: integer(row.substitution_location, `${label}.value.substitution_location`, 0, argumentTokens.length - 1),
1254
1415
  }],
1255
1416
  };
@@ -1280,40 +1441,6 @@ function decodeProviderTask(value , label )
1280
1441
  };
1281
1442
  }
1282
1443
 
1283
- function decodeSubmissionDescriptorV5(value , label , operationToken ) {
1284
- if (operationToken === "finalize") {
1285
- const descriptor = exactRecord(value, label, ["operation_token", "argument_tokens", "value"]);
1286
- const argumentTokens = stringArray(descriptor.argument_tokens, `${label}.argument_tokens`, { minimum: 7 });
1287
- const source = exactRecord(descriptor.value, `${label}.value`, ["slot", "domain", "substitution_location"], ["schema", "minimum", "maximum"]);
1288
- const slot = enumeration(source.slot, ["correction_lines", "validation"] , `${label}.value.slot`);
1289
- return {
1290
- operationToken,
1291
- argumentTokens,
1292
- value: {
1293
- slot,
1294
- domain: nonempty(source.domain, `${label}.value.domain`),
1295
- substitutionLocation: integer(source.substitution_location, `${label}.value.substitution_location`, 0, argumentTokens.length - 1),
1296
- ...(source.schema === undefined ? {} : { schema: nonempty(source.schema, `${label}.value.schema`) }),
1297
- ...(source.minimum === undefined ? {} : { minimum: integer(source.minimum, `${label}.value.minimum`, 1, 200) }),
1298
- ...(source.maximum === undefined ? {} : { maximum: integer(source.maximum, `${label}.value.maximum`, 1, 200) }),
1299
- },
1300
- };
1301
- }
1302
- const descriptor = exactRecord(value, label, ["operation_token", "argument_tokens", "values"]);
1303
- const argumentTokens = stringArray(descriptor.argument_tokens, `${label}.argument_tokens`, { minimum: 6, maximum: 6 });
1304
- const values = array(descriptor.values, `${label}.values`, (entry, entryLabel) => {
1305
- const source = exactRecord(entry, entryLabel, ["slot", "domain", "substitution_location"], ["schema", "allowed_values"]);
1306
- return {
1307
- slot: nonempty(source.slot, `${entryLabel}.slot`),
1308
- domain: nonempty(source.domain, `${entryLabel}.domain`),
1309
- substitutionLocation: integer(source.substitution_location, `${entryLabel}.substitution_location`, 0, argumentTokens.length - 1),
1310
- ...(source.schema === undefined ? {} : { schema: nonempty(source.schema, `${entryLabel}.schema`) }),
1311
- ...(source.allowed_values === undefined ? {} : { allowedValues: stringArray(source.allowed_values, `${entryLabel}.allowed_values`, { minimum: 1, unique: true }) }),
1312
- };
1313
- }, { minimum: 2, maximum: 2 });
1314
- return { operationToken, argumentTokens, values };
1315
- }
1316
-
1317
1444
  function decodeCorrectionPlanRequestV1(value , label ) {
1318
1445
  const body = exactRecord(value, label, ["schema", "request_hash", "lineage_id", "expected_revision", "target_identity", "correction_budget", "fix_finding_ids", "findings"]);
1319
1446
  if (body.schema !== "gentle-ai.review-correction-plan-request/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-correction-plan-request/v1`);
@@ -1342,6 +1469,59 @@ function decodeCorrectionPlanRequestV1(value , label )
1342
1469
  };
1343
1470
  }
1344
1471
 
1472
+ export function decodeReviewTargetedValidationRequestV1(value , label = "targeted_validation_request") {
1473
+ const body = exactRecord(value, label, [
1474
+ "schema", "request_hash", "lineage_id", "expected_revision", "target_identity", "fix_finding_ids", "policy_content", "fix_findings", "fix_classifications",
1475
+ "projection", "correction_candidate_tree", "correction_target_identity", "correction_paths", "correction_paths_digest",
1476
+ ]);
1477
+ if (body.schema !== "gentle-ai.review-targeted-validation-request/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-targeted-validation-request/v1`);
1478
+ const fixFindingIds = stringArray(body.fix_finding_ids, `${label}.fix_finding_ids`, { minimum: 1, unique: true });
1479
+ const fixFindings = array(body.fix_findings, `${label}.fix_findings`, (entry, entryLabel) => {
1480
+ const finding = exactRecord(entry, entryLabel, ["id", "lens", "location", "severity", "claim", "proof_refs", "evidence_class", "causal_disposition"]);
1481
+ return {
1482
+ id: nonempty(finding.id, `${entryLabel}.id`),
1483
+ lens: enumeration(finding.lens, ["risk", "resilience", "readability", "reliability"] , `${entryLabel}.lens`),
1484
+ location: nonempty(finding.location, `${entryLabel}.location`),
1485
+ severity: enumeration(finding.severity, ["BLOCKER", "CRITICAL"] , `${entryLabel}.severity`),
1486
+ claim: nonempty(finding.claim, `${entryLabel}.claim`),
1487
+ proofRefs: stringArray(finding.proof_refs, `${entryLabel}.proof_refs`, { minimum: 1 }),
1488
+ evidenceClass: enumeration(finding.evidence_class, ["deterministic", "inferential"] , `${entryLabel}.evidence_class`),
1489
+ causalDisposition: enumeration(finding.causal_disposition, ["introduced", "behavior-activated", "worsened"] , `${entryLabel}.causal_disposition`),
1490
+ };
1491
+ }, { minimum: 1 });
1492
+ const fixClassifications = array(body.fix_classifications, `${label}.fix_classifications`, (entry, entryLabel) => {
1493
+ const classification = exactRecord(entry, entryLabel, ["finding_id", "class", "causal_disposition", "proof"], ["severity"]);
1494
+ const severity = classification.severity === undefined ? undefined : nonempty(classification.severity, `${entryLabel}.severity`);
1495
+ return {
1496
+ findingId: nonempty(classification.finding_id, `${entryLabel}.finding_id`),
1497
+ ...(severity === undefined ? {} : { severity }),
1498
+ class: enumeration(classification.class, ["deterministic", "inferential"] , `${entryLabel}.class`),
1499
+ causalDisposition: enumeration(classification.causal_disposition, ["introduced", "behavior-activated", "worsened"] , `${entryLabel}.causal_disposition`),
1500
+ proof: nonempty(classification.proof, `${entryLabel}.proof`),
1501
+ };
1502
+ }, { minimum: 1 });
1503
+ const findingIds = fixFindings.map((finding) => finding.id);
1504
+ const classificationFindingIds = fixClassifications.map((classification) => classification.findingId);
1505
+ assertExactSet(findingIds, fixFindingIds, `${label}.fix_findings`);
1506
+ assertExactSet(classificationFindingIds, fixFindingIds, `${label}.fix_classifications`);
1507
+ return {
1508
+ schema: "gentle-ai.review-targeted-validation-request/v1",
1509
+ requestHash: sha256(body.request_hash, `${label}.request_hash`),
1510
+ lineageId: lineage(body.lineage_id, `${label}.lineage_id`),
1511
+ expectedRevision: sha256(body.expected_revision, `${label}.expected_revision`),
1512
+ targetIdentity: sha256(body.target_identity, `${label}.target_identity`),
1513
+ fixFindingIds,
1514
+ policyContent: nonempty(body.policy_content, `${label}.policy_content`),
1515
+ fixFindings,
1516
+ fixClassifications,
1517
+ projection: enumeration(body.projection, REQUIRED_PROJECTIONS, `${label}.projection`),
1518
+ correctionCandidateTree: gitTree(body.correction_candidate_tree, `${label}.correction_candidate_tree`),
1519
+ correctionTargetIdentity: sha256(body.correction_target_identity, `${label}.correction_target_identity`),
1520
+ correctionPaths: stringArray(body.correction_paths, `${label}.correction_paths`, { minimum: 1, unique: true }),
1521
+ correctionPathsDigest: sha256(body.correction_paths_digest, `${label}.correction_paths_digest`),
1522
+ };
1523
+ }
1524
+
1345
1525
  export function decodeReviewForecastV1(value , label = "status.forecast") {
1346
1526
  const body = exactRecord(value, label, ["horizon", "steps"]);
1347
1527
  const horizon = enumeration(body.horizon, ["partial", "terminal"] , `${label}.horizon`);
@@ -1365,24 +1545,15 @@ export function decodeReviewForecastV1(value , label = "status.forecast"
1365
1545
  // request; every other reason code must not.
1366
1546
  const CORRECTION_REQUEST_REASON_CODES = Object.freeze(["correction_plan_required", "corrected_candidate_unavailable"] );
1367
1547
  // v5 capture operations that must carry a submission descriptor.
1368
- const V5_SUBMISSION_CAPTURE_OPERATIONS = Object.freeze(["external.plan_correction", "external.run_targeted_validation", "review.capture-evidence"] );
1548
+ const V5_SUBMISSION_CAPTURE_OPERATIONS = Object.freeze(["review.capture-correction-plan"] );
1369
1549
 
1370
- function decodeCollectInput(value , label , v5 ) {
1371
- const input = exactRecord(value, label, ["name", "schema", "capture_operation", "arguments"], ["artifact_subject", "base_tree", "candidate_tree", "changed_path_manifest", "validation_request", "submission", ...(v5 ? ["provider_task"] : [])]);
1550
+ function decodeCollectInput(value , label , v5 , v6 ) {
1551
+ const input = exactRecord(value, label, ["name", "schema", "capture_operation", "arguments"], ["artifact_subject", "base_tree", "candidate_tree", "changed_path_manifest", "submission", ...(v5 ? ["provider_task", "validation_request"] : [])]);
1372
1552
  const name = text(input.name, `${label}.name`, { minimum: 1, pattern: /^[a-z0-9_]+$/ });
1373
1553
  const schema = nonempty(input.schema, `${label}.schema`);
1374
1554
  const captureOperation = nonempty(input.capture_operation, `${label}.capture_operation`);
1375
1555
  const argumentsList = decodeTransitionArguments(input.arguments, `${label}.arguments`);
1376
1556
 
1377
- if (captureOperation === "external.run_targeted_validation") {
1378
- if (input.validation_request === undefined) throw new TypeError(`${label}.validation_request is required`);
1379
- if (schema !== "gentle-ai.review-targeted-validation-request/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-targeted-validation-request/v1`);
1380
- } else if (captureOperation === REVIEW_PROVIDER_ROLE_CAPTURE_OPERATION.CAPTURE_VALIDATION) {
1381
- if (input.validation_request === undefined) throw new TypeError(`${label}.validation_request is required`);
1382
- } else if (input.validation_request !== undefined) {
1383
- throw new TypeError(`${label}.validation_request is only valid for external.run_targeted_validation or review.capture-validation`);
1384
- }
1385
-
1386
1557
  // v5-only surfaces (vendored status-v5.schema.json): the provider role task
1387
1558
  // rides exactly the external.run_provider_role vector, and the finalize/
1388
1559
  // capture-evidence submission descriptor forms ride their own vectors.
@@ -1394,11 +1565,39 @@ function decodeCollectInput(value , label , v5 )
1394
1565
  }
1395
1566
  if ((V5_SUBMISSION_CAPTURE_OPERATIONS ).includes(captureOperation)) {
1396
1567
  if (input.submission === undefined) throw new TypeError(`${label}.submission is required for ${captureOperation}`);
1397
- if (captureOperation === "external.plan_correction" && schema !== "gentle-ai.review-correction-plan/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-correction-plan/v1`);
1398
- if (captureOperation === "review.capture-evidence" && schema !== "https://gentle-ai.dev/schema/review/verification-evidence/v1") throw new TypeError(`${label}.schema must be https://gentle-ai.dev/schema/review/verification-evidence/v1`);
1568
+ if (captureOperation === "review.capture-correction-plan" && schema !== "gentle-ai.review-correction-plan/v1") throw new TypeError(`${label}.schema must be gentle-ai.review-correction-plan/v1`);
1399
1569
  }
1400
1570
  }
1401
1571
 
1572
+ const intendedUntracked = v6
1573
+ && name === "intended_untracked_selection"
1574
+ && schema === "gentle-ai.review-intended-untracked-selection/v1"
1575
+ && captureOperation === "external.select_intended_untracked";
1576
+ if (captureOperation === "external.select_intended_untracked" && (name !== "intended_untracked_selection" || schema !== "gentle-ai.review-intended-untracked-selection/v1")) {
1577
+ throw new TypeError(`${label} external.select_intended_untracked requires the intended_untracked_selection binding`);
1578
+ }
1579
+ if (intendedUntracked) {
1580
+ const expectedNames = ["target_identity", "projection", "base_tree", "candidate_tree", "eligible_paths_json", "expected_untracked_inventory"] ;
1581
+ if (argumentsList.length !== expectedNames.length || argumentsList.some((argument, index) => argument.name !== expectedNames[index] || argument.token !== undefined)) {
1582
+ throw new TypeError(`${label}.arguments must preserve the exact intended-untracked metadata binding`);
1583
+ }
1584
+ sha256(argumentsList[0] .value, `${label}.arguments[0].value`);
1585
+ enumeration(argumentsList[1] .value, ["workspace"] , `${label}.arguments[1].value`);
1586
+ gitTree(argumentsList[2] .value, `${label}.arguments[2].value`);
1587
+ gitTree(argumentsList[3] .value, `${label}.arguments[3].value`);
1588
+ const eligiblePathsJson = argumentsList[4] .value;
1589
+ let eligiblePaths ;
1590
+ try { eligiblePaths = JSON.parse(eligiblePathsJson); } catch { throw new TypeError(`${label}.arguments[4].value must be canonical JSON`); }
1591
+ if (!Array.isArray(eligiblePaths) || eligiblePaths.length === 0 || eligiblePaths.some((path) => {
1592
+ if (typeof path !== "string" || path.length === 0 || path.startsWith("/") || /^[A-Za-z]:\//.test(path) || path.includes("\\") || path.includes("\0")) return true;
1593
+ const segments = path.split("/");
1594
+ return segments.some((segment) => segment === "" || segment === "." || segment === "..");
1595
+ }) || new Set(eligiblePaths).size !== eligiblePaths.length || JSON.stringify(eligiblePaths) !== eligiblePathsJson) {
1596
+ throw new TypeError(`${label}.arguments[4].value must contain unique canonical repository-relative paths`);
1597
+ }
1598
+ sha256(argumentsList[5] .value, `${label}.arguments[5].value`);
1599
+ }
1600
+
1402
1601
  // gentle-pi#311 P4-roles: the two Go-owned non-lens provider role capture
1403
1602
  // operations render SELF-CONTAINED authority-advancing vectors. Executing
1404
1603
  // the exact rendered tokens makes Go materialize the role prompt, run its
@@ -1412,6 +1611,30 @@ function decodeCollectInput(value , label , v5 )
1412
1611
  if (captureOperation === REVIEW_PROVIDER_ROLE_CAPTURE_OPERATION.CAPTURE_VALIDATION && schema !== "https://gentle-ai.dev/schema/review/validator/v1") {
1413
1612
  throw new TypeError(`${label}.schema must be https://gentle-ai.dev/schema/review/validator/v1`);
1414
1613
  }
1614
+ const targetedValidatorInput = v5
1615
+ && name === "provider_targeted_validator"
1616
+ && captureOperation === REVIEW_PROVIDER_ROLE_CAPTURE_OPERATION.CAPTURE_VALIDATION
1617
+ && schema === "https://gentle-ai.dev/schema/review/validator/v1";
1618
+ if (input.validation_request !== undefined && !targetedValidatorInput) {
1619
+ throw new TypeError(`${label}.validation_request is only valid for the v5 provider-targeted-validator capture input`);
1620
+ }
1621
+ if (targetedValidatorInput && input.validation_request === undefined) {
1622
+ throw new TypeError(`${label}.validation_request is required for the v5 provider-targeted-validator capture input`);
1623
+ }
1624
+ const validationRequest = input.validation_request === undefined
1625
+ ? undefined
1626
+ : decodeReviewTargetedValidationRequestV1(input.validation_request, `${label}.validation_request`);
1627
+ if (validationRequest !== undefined) {
1628
+ const providerArgument = (argumentName ) => {
1629
+ const matches = argumentsList.filter((argument) => argument.name === argumentName);
1630
+ if (matches.length !== 1) throw new TypeError(`${label}.arguments must carry exactly one ${argumentName} binding`);
1631
+ return matches[0] .value;
1632
+ };
1633
+ if (providerArgument("lineage") !== validationRequest.lineageId) throw new TypeError(`${label}.arguments lineage must bind validation_request.lineage_id`);
1634
+ if (providerArgument("expected-revision") !== validationRequest.expectedRevision) throw new TypeError(`${label}.arguments expected-revision must bind validation_request.expected_revision`);
1635
+ if (providerArgument("target") !== validationRequest.correctionTargetIdentity) throw new TypeError(`${label}.arguments target must bind validation_request.correction_target_identity`);
1636
+ if (providerArgument("request-hash") !== validationRequest.requestHash) throw new TypeError(`${label}.arguments request-hash must bind validation_request.request_hash`);
1637
+ }
1415
1638
  if (input.submission !== undefined && (REVIEW_PROVIDER_ROLE_CAPTURE_OPERATIONS ).includes(captureOperation)) {
1416
1639
  throw new TypeError(`${label}.submission is not allowed on the self-contained ${captureOperation} vector`);
1417
1640
  }
@@ -1424,23 +1647,17 @@ function decodeCollectInput(value , label , v5 )
1424
1647
  } else if (input.artifact_subject !== undefined || input.base_tree !== undefined || input.candidate_tree !== undefined || input.changed_path_manifest !== undefined) {
1425
1648
  throw new TypeError(`${label} carries capture-result fields without review.capture-result`);
1426
1649
  }
1427
- const submissionOperations = v5 ? ["review.capture-result", ...V5_SUBMISSION_CAPTURE_OPERATIONS] : ["review.capture-result"];
1650
+ const submissionOperations = v5
1651
+ ? ["review.capture-result", "review.capture-correction-plan", ...(v6 ? ["external.select_intended_untracked"] : [])]
1652
+ : ["review.capture-result"];
1428
1653
  if (input.submission !== undefined && !submissionOperations.includes(captureOperation)) {
1429
1654
  throw new TypeError(v5 ? `${label}.submission is only valid for ${submissionOperations.join(", ")}` : `${label}.submission is only valid for review.capture-result`);
1430
1655
  }
1656
+ if (intendedUntracked && input.submission === undefined) throw new TypeError(`${label}.submission is required for external.select_intended_untracked`);
1431
1657
 
1432
- // The v5 descriptor forms are discriminated by their closed operation
1433
- // tokens; every other submission stays the host-relay completing form.
1434
- let submission ;
1435
- let submissionDescriptor ;
1436
- if (input.submission !== undefined) {
1437
- const operationToken = (input.submission )?.operation_token;
1438
- if (v5 && (operationToken === "finalize" || operationToken === "capture-evidence")) {
1439
- submissionDescriptor = decodeSubmissionDescriptorV5(input.submission, `${label}.submission`, operationToken);
1440
- } else {
1441
- submission = decodeCaptureSubmission(input.submission, `${label}.submission`, v5);
1442
- }
1443
- }
1658
+ const submission = input.submission === undefined
1659
+ ? undefined
1660
+ : decodeCaptureSubmission(input.submission, `${label}.submission`, v5, v6, captureOperation);
1444
1661
 
1445
1662
  return {
1446
1663
  name,
@@ -1451,15 +1668,15 @@ function decodeCollectInput(value , label , v5 )
1451
1668
  ...(input.base_tree === undefined ? {} : { baseTree: gitTree(input.base_tree, `${label}.base_tree`) }),
1452
1669
  ...(input.candidate_tree === undefined ? {} : { candidateTree: gitTree(input.candidate_tree, `${label}.candidate_tree`) }),
1453
1670
  ...(input.changed_path_manifest === undefined ? {} : { changedPathManifest: array(input.changed_path_manifest, `${label}.changed_path_manifest`, decodeChangedPathEntry, { unique: true }) }),
1454
- ...(input.validation_request === undefined ? {} : { validationRequest: decodeTargetedValidationRequestV1(input.validation_request, `${label}.validation_request`) }),
1455
1671
  ...(submission === undefined ? {} : { submission }),
1456
- ...(submissionDescriptor === undefined ? {} : { submissionDescriptor }),
1457
1672
  ...(v5 && input.provider_task !== undefined ? { providerTask: decodeProviderTask(input.provider_task, `${label}.provider_task`) } : {}),
1673
+ ...(validationRequest === undefined ? {} : { validationRequest }),
1458
1674
  };
1459
1675
  }
1460
1676
 
1461
- export function decodeReviewNextTransitionV3(value , options = {}) {
1462
- const v5 = options.v5 === true;
1677
+ export function decodeReviewNextTransitionV3(value , options = {}) {
1678
+ const v6 = options.v6 === true;
1679
+ const v5 = options.v5 === true || v6;
1463
1680
  const transition = exactRecord(value, "next_transition", ["kind", "reason_code"], ["execute", "collect", ...(v5 ? ["correction_request"] : [])]);
1464
1681
  const kind = enumeration(transition.kind, ["execute", "collect", "stop"] , "next_transition.kind");
1465
1682
  const reasonCode = text(transition.reason_code, "next_transition.reason_code", { minimum: 1, pattern: /^[a-z0-9_]+$/ });
@@ -1489,6 +1706,7 @@ export function decodeReviewNextTransitionV3(value , options
1489
1706
  const execute = exactRecord(transition.execute, "next_transition.execute", ["operation", "arguments", "preconditions", "binding"], ["command", "selector_arguments", "artifacts"]);
1490
1707
  const operation = enumeration(execute.operation, NEXT_TRANSITION_OPERATIONS, "next_transition.execute.operation");
1491
1708
  const argumentsList = decodeTransitionArguments(execute.arguments, "next_transition.execute.arguments");
1709
+ const selectorArguments = execute.selector_arguments === undefined ? undefined : decodeTransitionArguments(execute.selector_arguments, "next_transition.execute.selector_arguments");
1492
1710
  const preconditions = decodeTransitionArguments(execute.preconditions, "next_transition.execute.preconditions");
1493
1711
  // The schema gives `binding` no declared properties and no required list:
1494
1712
  // it is an OPEN object. Closing it here made Pi stricter than the
@@ -1499,12 +1717,14 @@ export function decodeReviewNextTransitionV3(value , options
1499
1717
  const lineageId = binding.lineage_id === undefined ? undefined : lineage(binding.lineage_id, "next_transition.execute.binding.lineage_id");
1500
1718
  const revision = binding.revision === undefined ? undefined : sha256(binding.revision, "next_transition.execute.binding.revision");
1501
1719
  const command = execute.command === undefined ? undefined : nonempty(execute.command, "next_transition.execute.command");
1720
+ const decodedExecute = { operation, arguments: argumentsList, ...(selectorArguments === undefined ? {} : { selectorArguments }), preconditions, binding: { targetIdentity, ...(lineageId === undefined ? {} : { lineageId }), ...(revision === undefined ? {} : { revision }) }, ...(command === undefined ? {} : { command }) };
1721
+ if (operation === "review.acknowledge-approved") assertReviewApprovedAcknowledgementExecuteV1(decodedExecute);
1502
1722
  if (transition.collect !== undefined) throw new TypeError("next_transition.collect is incompatible with execute");
1503
- return { kind, reasonCode, execute: { operation, arguments: argumentsList, preconditions, binding: { targetIdentity, ...(lineageId === undefined ? {} : { lineageId }), ...(revision === undefined ? {} : { revision }) }, ...(command === undefined ? {} : { command }) }, ...(correctionRequest === undefined ? {} : { correctionRequest }) };
1723
+ return { kind, reasonCode, execute: decodedExecute, ...(correctionRequest === undefined ? {} : { correctionRequest }) };
1504
1724
  }
1505
1725
  if (kind === "collect") {
1506
1726
  const collect = exactRecord(transition.collect, "next_transition.collect", ["inputs"]);
1507
- const inputs = array(collect.inputs, "next_transition.collect.inputs", (entry, label) => decodeCollectInput(entry, label, v5), { minimum: 1 });
1727
+ const inputs = array(collect.inputs, "next_transition.collect.inputs", (entry, label) => decodeCollectInput(entry, label, v5, v6), { minimum: 1 });
1508
1728
  if (transition.execute !== undefined) throw new TypeError("next_transition.execute is incompatible with collect");
1509
1729
  return { kind, reasonCode, collect: { inputs }, ...(correctionRequest === undefined ? {} : { correctionRequest }) };
1510
1730
  }
@@ -1520,8 +1740,8 @@ export function decodeReviewNextTransitionV3(value , options
1520
1740
  // status-v2.schema.json action_eligibility definition v2 also $refs.
1521
1741
  // ---------------------------------------------------------------------------
1522
1742
 
1523
- const ELIGIBLE_ACTIONS = ["stop", "review.start", "review.finalize", "review.validate", "review.recover", "review.repair", "review.retry_final_verification"] ;
1524
- const FORBIDDEN_ACTIONS = ["review.abandon", "review.finalize", "review.invalidate", "review.quarantine-legacy", "review.reclaim", "review.reconcile-authority", "review.reconcile-authority-batch", "review.recover", "review.repair", "review.retry_final_verification", "review.start", "review.validate"] ;
1743
+ const ELIGIBLE_ACTIONS = ["stop", "review.start", "review.recover", "review.repair"] ;
1744
+ const FORBIDDEN_ACTIONS = ["review.abandon", "review.invalidate", "review.quarantine-legacy", "review.reclaim", "review.reconcile-authority", "review.reconcile-authority-batch", "review.recover", "review.repair", "review.start"] ;
1525
1745
 
1526
1746
  function decodeEligibility(value , label ) {
1527
1747
  const eligibility = exactRecord(value, label, ["allowed_actions", "forbidden_actions"]);
@@ -1530,14 +1750,14 @@ function decodeEligibility(value , label ) {
1530
1750
  const selected = enumeration(action.action, ELIGIBLE_ACTIONS, `${entryLabel}.action`);
1531
1751
  text(action.reason_code, `${entryLabel}.reason_code`, { minimum: 1, pattern: /^[a-z0-9_]+$/ });
1532
1752
  array(action.required_inputs, `${entryLabel}.required_inputs`, (input, inputLabel) => text(input, inputLabel, { minimum: 1, pattern: /^[a-z0-9_]+$/ }), { unique: true });
1533
- if (selected === "review.recover" || selected === "review.retry_final_verification") {
1753
+ if (selected === "review.recover") {
1534
1754
  const binding = exactRecord(action.binding, `${entryLabel}.binding`, ["lineage_id", "revision", "target_identity"]);
1535
1755
  enumeration(action.disposition, Object.values(REVIEW_STATUS_ACTION_DISPOSITION), `${entryLabel}.disposition`);
1536
1756
  lineage(binding.lineage_id, `${entryLabel}.binding.lineage_id`);
1537
1757
  sha256(binding.revision, `${entryLabel}.binding.revision`);
1538
1758
  sha256(binding.target_identity, `${entryLabel}.binding.target_identity`);
1539
1759
  } else if (action.disposition !== undefined || action.binding !== undefined) {
1540
- throw new TypeError(`${entryLabel} recovery fields require review.recover or review.retry_final_verification`);
1760
+ throw new TypeError(`${entryLabel} recovery fields require review.recover`);
1541
1761
  }
1542
1762
  return action;
1543
1763
  }, { minimum: 1, maximum: 1 });
@@ -1549,21 +1769,6 @@ function decodeEligibility(value , label ) {
1549
1769
  });
1550
1770
  }
1551
1771
 
1552
- function decodeFinalVerificationRetry(value , label ) {
1553
- const body = exactRecord(value, label, ["incident_schema", "incident_class", "validating_revision", "target_identity", "failed_evidence_hash", "finalize_request_digest"], ["failed_evidence_record_digest"]);
1554
- if (body.incident_schema !== "gentle-ai.review-final-verification-incident/v1") throw new TypeError(`${label}.incident_schema is unsupported`);
1555
- if (body.incident_class !== "procedural_tooling_failure") throw new TypeError(`${label}.incident_class is unsupported`);
1556
- return {
1557
- incidentSchema: "gentle-ai.review-final-verification-incident/v1",
1558
- incidentClass: "procedural_tooling_failure",
1559
- validatingRevision: sha256(body.validating_revision, `${label}.validating_revision`),
1560
- targetIdentity: sha256(body.target_identity, `${label}.target_identity`),
1561
- failedEvidenceHash: sha256(body.failed_evidence_hash, `${label}.failed_evidence_hash`),
1562
- ...(body.failed_evidence_record_digest === undefined ? {} : { failedEvidenceRecordDigest: sha256(body.failed_evidence_record_digest, `${label}.failed_evidence_record_digest`) }),
1563
- finalizeRequestDigest: sha256(body.finalize_request_digest, `${label}.finalize_request_digest`),
1564
- };
1565
- }
1566
-
1567
1772
  // ---------------------------------------------------------------------------
1568
1773
  // status/v3
1569
1774
  // ---------------------------------------------------------------------------
@@ -1572,18 +1777,29 @@ export function decodeReviewStatusV3(value ) {
1572
1777
  // Additive forward acceptance: status/v5 (gentle-ai main; ground-truthed
1573
1778
  // against a live capture and the vendored status-v5.schema.json) is the v3
1574
1779
  // key set plus the optional forecast and the v5-only next_transition
1575
- // surfaces. The v3 identity keeps rejecting every v5-only field.
1576
- const v5 = typeof value === "object" && value !== null && (value ).schema === "gentle-ai.review-integration.status/v5";
1780
+ // surfaces. status/v6 adds the intended-untracked selection; status/v7
1781
+ // (gentle-ai v2.6.0, advertised through capabilities/v2.5 alongside v6)
1782
+ // adds only the top-level optional `eligible_untracked_inventory` digest,
1783
+ // so it is decoded on the v6 surface. v3 keeps rejecting every v5/v6/v7-only
1784
+ // field.
1785
+ const schema = typeof value === "object" && value !== null ? (value ).schema : undefined;
1786
+ const v7 = schema === "gentle-ai.review-integration.status/v7";
1787
+ const v6 = v7 || schema === "gentle-ai.review-integration.status/v6";
1788
+ const v5 = v6 || schema === "gentle-ai.review-integration.status/v5";
1577
1789
  const body = exactRecord(value, "status", [
1578
- "schema", "contract", "operation", "applicability", "receipt", "action", "replayability", "target_identity", "projection", "repair", "candidates",
1579
- ], ["authority", "frozen", "reconciliation", "action_disposition", "eligibility", "next_transition", "authority_target_identity", "validation_request", "final_verification_retry", ...(v5 ? ["forecast", "repository_context"] : [])]);
1580
- requireIdentity(body, v5 ? "gentle-ai.review-integration.status/v5" : "gentle-ai.review-integration.status/v3", REVIEW_INTEGRATION_OPERATION.STATUS);
1790
+ "schema", "contract", "operation", "applicability", "action", "replayability", "target_identity", "projection", "repair", "candidates",
1791
+ ], ["authority", "frozen", "action_disposition", "eligibility", "next_transition", "authority_target_identity", ...(v5 ? ["receipt", "forecast", "repository_context", "validation_request"] : []), ...(v7 ? ["eligible_untracked_inventory"] : [])]);
1792
+ requireIdentity(body, v7 ? "gentle-ai.review-integration.status/v7" : v6 ? "gentle-ai.review-integration.status/v6" : v5 ? "gentle-ai.review-integration.status/v5" : "gentle-ai.review-integration.status/v3", REVIEW_INTEGRATION_OPERATION.STATUS);
1581
1793
 
1582
1794
  const applicability = enumeration(body.applicability, ["current_target", "unrelated", "ambiguous", "corrupted"] , "status.applicability");
1583
- const receiptBody = exactRecord(body.receipt, "status.receipt", ["status"], ["identity"]);
1584
- const receiptStatus = enumeration(receiptBody.status, RECEIPT_STATUSES, "status.receipt.status");
1585
- const receipt = { status: receiptStatus, ...(receiptBody.identity === undefined ? {} : { identity: sha256(receiptBody.identity, "status.receipt.identity") }) };
1586
-
1795
+ let receipt ;
1796
+ if (body.receipt !== undefined) {
1797
+ const source = exactRecord(body.receipt, "status.receipt", ["status"], ["identity"]);
1798
+ receipt = {
1799
+ status: enumeration(source.status, RECEIPT_STATUSES, "status.receipt.status"),
1800
+ ...(source.identity === undefined ? {} : { identity: sha256(source.identity, "status.receipt.identity") }),
1801
+ };
1802
+ }
1587
1803
  let authority ;
1588
1804
  if (body.authority !== undefined) {
1589
1805
  const source = exactRecord(body.authority, "status.authority", ["version", "lineage_id", "state", "generation", "revision"]);
@@ -1611,52 +1827,32 @@ export function decodeReviewStatusV3(value ) {
1611
1827
  }
1612
1828
  if (authority?.version === REVIEW_AUTHORITY_VERSION.COMPACT_V2 && frozen === undefined) throw new TypeError("compact-v2 status requires frozen metadata");
1613
1829
  if (authority?.version === REVIEW_AUTHORITY_VERSION.LEGACY_V1 && (frozen !== undefined || body.authority_target_identity !== undefined)) throw new TypeError("legacy status cannot expose frozen metadata or authority_target_identity");
1614
- if (authority?.version === REVIEW_AUTHORITY_VERSION.LEGACY_V1 && receiptStatus !== "expected_missing" && receiptStatus !== "present") throw new TypeError("legacy status receipt is incompatible");
1830
+ if (authority?.version === REVIEW_AUTHORITY_VERSION.LEGACY_V1 && receipt !== undefined && receipt.status !== "expected_missing" && receipt.status !== "present") {
1831
+ throw new TypeError("legacy status receipt is incompatible");
1832
+ }
1615
1833
 
1616
1834
  const action = enumeration(body.action, STATUS_ACTIONS, "status.action");
1617
1835
  const actionDisposition = body.action_disposition === undefined ? undefined : enumeration(body.action_disposition, Object.values(REVIEW_STATUS_ACTION_DISPOSITION), "status.action_disposition");
1618
- if ((action === "recover" || action === "retry_final_verification") && actionDisposition === undefined) throw new TypeError(`${action} status requires action_disposition`);
1619
- if (action !== "recover" && action !== "retry_final_verification" && actionDisposition !== undefined) throw new TypeError("status.action_disposition is only valid for the recover or retry_final_verification action");
1836
+ if (action === "recover" && actionDisposition === undefined) throw new TypeError("recover status requires action_disposition");
1837
+ if (action !== "recover" && actionDisposition !== undefined) throw new TypeError("status.action_disposition is only valid for the recover action");
1620
1838
  if (body.eligibility !== undefined) decodeEligibility(body.eligibility, "status.eligibility");
1621
- const nextTransition = body.next_transition === undefined ? undefined : decodeReviewNextTransitionV3(body.next_transition, { v5 });
1839
+ const nextTransition = body.next_transition === undefined ? undefined : decodeReviewNextTransitionV3(body.next_transition, { v5, v6 });
1840
+ const validationRequest = v5 && body.validation_request !== undefined
1841
+ ? decodeReviewTargetedValidationRequestV1(body.validation_request, "status.validation_request")
1842
+ : undefined;
1843
+ if (validationRequest !== undefined) {
1844
+ const collectInputs = nextTransition?.kind === "collect" ? nextTransition.collect?.inputs ?? [] : [];
1845
+ const matchingInputs = collectInputs.filter((input) => input.validationRequest !== undefined);
1846
+ if (matchingInputs.length !== 1 || canonicalJson(matchingInputs[0] .validationRequest) !== canonicalJson(validationRequest)) {
1847
+ throw new TypeError("status.validation_request must exactly match the provider-targeted-validator collect input");
1848
+ }
1849
+ }
1622
1850
  // status/v5 dependentRequired: a forecast previews the transition head, so
1623
1851
  // it can only accompany an actual next_transition.
1624
1852
  const forecast = v5 && body.forecast !== undefined ? decodeReviewForecastV1(body.forecast) : undefined;
1625
1853
  if (forecast !== undefined && nextTransition === undefined) throw new TypeError("status.forecast requires status.next_transition");
1626
1854
  const replayability = enumeration(body.replayability, Object.values(REVIEW_REPLAYABILITY), "status.replayability");
1627
1855
 
1628
- let reconciliation ;
1629
- if (action === "reconcile_finalize") {
1630
- if (body.reconciliation === undefined) throw new TypeError("reconcile_finalize status requires reconciliation");
1631
- const source = exactRecord(body.reconciliation, "status.reconciliation", ["required"]);
1632
- if (source.required !== true) throw new TypeError("status.reconciliation.required must be true");
1633
- if (applicability !== REVIEW_AUTHORITY_APPLICABILITY.CURRENT_TARGET) throw new TypeError("reconcile_finalize status requires current_target applicability");
1634
- if (replayability !== REVIEW_REPLAYABILITY.STATUS_REQUIRED) throw new TypeError("reconcile_finalize status requires status_required replayability");
1635
- reconciliation = { required: true };
1636
- } else if (body.reconciliation !== undefined) {
1637
- throw new TypeError("status.reconciliation is only valid for the reconcile_finalize action");
1638
- }
1639
-
1640
- let validationRequest ;
1641
- if (body.validation_request !== undefined) {
1642
- if (applicability !== REVIEW_AUTHORITY_APPLICABILITY.CURRENT_TARGET || authority?.state !== "correction_required") {
1643
- throw new TypeError("status.validation_request requires current_target applicability and correction_required authority state");
1644
- }
1645
- validationRequest = decodeTargetedValidationRequestV1(body.validation_request, "status.validation_request");
1646
- }
1647
-
1648
- let finalVerificationRetry ;
1649
- if (action === "retry_final_verification") {
1650
- if (body.final_verification_retry === undefined) throw new TypeError("retry_final_verification status requires final_verification_retry");
1651
- if (applicability !== REVIEW_AUTHORITY_APPLICABILITY.CURRENT_TARGET || authority?.version !== REVIEW_AUTHORITY_VERSION.COMPACT_V2 || authority?.state !== "escalated") {
1652
- throw new TypeError("retry_final_verification status requires current_target compact-v2 escalated authority");
1653
- }
1654
- if (actionDisposition !== REVIEW_STATUS_ACTION_DISPOSITION.FINAL_VERIFICATION_RETRY) throw new TypeError("retry_final_verification status requires final_verification_retry disposition");
1655
- finalVerificationRetry = decodeFinalVerificationRetry(body.final_verification_retry, "status.final_verification_retry");
1656
- } else if (body.final_verification_retry !== undefined) {
1657
- throw new TypeError("status.final_verification_retry is only valid for the retry_final_verification action");
1658
- }
1659
-
1660
1856
  // status/v5 additive top-level repository context reference (captured
1661
1857
  // 2026-08-16 from 2.4.0-main.b1afef46; missing from the published
1662
1858
  // status-v5.schema.json, so the live capture is authoritative). Same
@@ -1667,7 +1863,7 @@ export function decodeReviewStatusV3(value ) {
1667
1863
  if (source.capability !== "review.opaque_repository_context") throw new TypeError("status.repository_context.capability is unsupported");
1668
1864
  repositoryContext = {
1669
1865
  capability: "review.opaque_repository_context",
1670
- handle: text(source.handle, "status.repository_context.handle", { pattern: /^rctx1_[0-9a-f]{64}$/ }),
1866
+ handle: text(source.handle, "status.repository_context.handle", { pattern: /^rctx[12]_[0-9a-f]{64}$/ }),
1671
1867
  revision: sha256(source.revision, "status.repository_context.revision"),
1672
1868
  targetIdentity: sha256(source.target_identity, "status.repository_context.target_identity"),
1673
1869
  ...(source.event_id === undefined ? {} : { eventId: sha256(source.event_id, "status.repository_context.event_id") }),
@@ -1675,26 +1871,34 @@ export function decodeReviewStatusV3(value ) {
1675
1871
  };
1676
1872
  }
1677
1873
 
1874
+ // status/v7 top-level optional digest (gentle-ai v2.6.0): resolves #4066's
1875
+ // closed loop where `sdd-attempt finish` named a digest status never
1876
+ // published. Absent on the `staged` projection, which never resolves an
1877
+ // inventory, so it stays structurally optional rather than a required v7
1878
+ // field.
1879
+ const eligibleUntrackedInventory = v7 && body.eligible_untracked_inventory !== undefined
1880
+ ? sha256(body.eligible_untracked_inventory, "status.eligible_untracked_inventory")
1881
+ : undefined;
1882
+
1678
1883
  return {
1679
1884
  contract: REVIEW_INTEGRATION_CONTRACT,
1680
1885
  applicability,
1681
1886
  ...(authority === undefined ? {} : { authority }),
1682
- receipt,
1887
+ ...(receipt === undefined ? {} : { receipt }),
1683
1888
  action,
1684
1889
  ...(actionDisposition === undefined ? {} : { actionDisposition }),
1685
1890
  replayability,
1686
1891
  ...(frozen === undefined ? {} : { frozen }),
1687
- ...(reconciliation === undefined ? {} : { reconciliation }),
1688
1892
  targetIdentity: sha256(body.target_identity, "status.target_identity"),
1689
1893
  ...(body.authority_target_identity === undefined ? {} : { authorityTargetIdentity: sha256(body.authority_target_identity, "status.authority_target_identity") }),
1690
1894
  projection: decodeReviewProjectionV1(body.projection),
1691
1895
  repair: decodeAuthorityRepairAssessmentV1(body.repair),
1692
1896
  candidates: stringArray(body.candidates, "status.candidates", { unique: true, pattern: /^[a-z0-9]+(?:-[a-z0-9]+)*$/ }),
1693
1897
  ...(nextTransition === undefined ? {} : { nextTransition }),
1694
- ...(validationRequest === undefined ? {} : { validationRequest }),
1695
- ...(finalVerificationRetry === undefined ? {} : { finalVerificationRetry }),
1696
1898
  ...(forecast === undefined ? {} : { forecast }),
1697
1899
  ...(repositoryContext === undefined ? {} : { repositoryContext }),
1900
+ ...(validationRequest === undefined ? {} : { validationRequest }),
1901
+ ...(eligibleUntrackedInventory === undefined ? {} : { eligibleUntrackedInventory }),
1698
1902
  raw: body,
1699
1903
  };
1700
1904
  }
@@ -1775,13 +1979,14 @@ export function decodeReviewConsentV2(value ) {
1775
1979
  // published v3 schema demands an `--agent claude-code` token that the live
1776
1980
  // emitter omits when the caller declared no --agent, so the capture is
1777
1981
  // authoritative and Pi replays whichever provider-owned invocation arrived.
1778
- export function decodeReviewConsentV3(value ) {
1982
+ export function decodeReviewConsentV3(value , expectedAgent ) {
1779
1983
  const body = exactRecord(value, "consent", [...CONSENT_KEYS_V2, "agent"]);
1780
1984
  requireIdentity(body, "gentle-ai.review-integration.consent/v3", "review.start");
1781
- if (body.agent !== "claude-code") throw new TypeError("consent.agent must be claude-code");
1985
+ const agent = enumeration(body.agent, Object.values(REVIEW_CONSENT_AGENT_V3), "consent.agent") ;
1986
+ if (expectedAgent !== undefined && agent !== expectedAgent) throw new TypeError("consent.agent does not match the expected runtime binding");
1782
1987
  return {
1783
1988
  schema: "gentle-ai.review-integration.consent/v3",
1784
- agent: "claude-code",
1989
+ agent,
1785
1990
  ...decodeConsentSemantics(body),
1786
1991
  raw: body,
1787
1992
  };
@@ -1883,56 +2088,21 @@ export function decodeReviewFailureV2(value ) {
1883
2088
  // operation/v2
1884
2089
  // ---------------------------------------------------------------------------
1885
2090
 
1886
- export function decodeReviewOperationV2(value ) {
1887
- const body = exactRecord(value, "operation", ["schema", "contract", "operation", "result"]);
1888
- requireIdentity(body, "gentle-ai.review-integration.operation/v2");
1889
- const operation = enumeration(body.operation, ["review.finalize", "review.validate", "review.bind_sdd", "review.retry_final_verification"] , "operation.operation");
1890
- let result ;
1891
- if (operation === REVIEW_INTEGRATION_OPERATION.FINALIZE) {
1892
- result = exactRecord(body.result, "operation.result", ["operation", "lineage_id", "state", "action", "store_revision"], ["eligibility", "next_transition", "validation_request", "escalation"]);
1893
- if (result.operation !== "review/finalize") throw new TypeError("operation.result does not match review.finalize");
1894
- nonempty(result.lineage_id, "operation.result.lineage_id");
1895
- nonempty(result.state, "operation.result.state");
1896
- nonempty(result.action, "operation.result.action");
1897
- sha256(result.store_revision, "operation.result.store_revision");
1898
- if (result.eligibility !== undefined) decodeEligibility(result.eligibility, "operation.result.eligibility");
1899
- if (result.next_transition !== undefined) decodeReviewNextTransitionV3(result.next_transition);
1900
- if (result.validation_request !== undefined) {
1901
- decodeTargetedValidationRequestV1(result.validation_request, "operation.result.validation_request");
1902
- if (result.state !== "correction_required") throw new TypeError("operation.result.validation_request requires state correction_required");
1903
- }
1904
- if (result.escalation !== undefined) nonempty(result.escalation, "operation.result.escalation");
1905
- } else if (operation === REVIEW_INTEGRATION_OPERATION.VALIDATE) {
1906
- result = exactRecord(body.result, "operation.result", ["schema", "result", "allowed", "action", "reason", "context"], ["delivery"]);
1907
- if (result.schema !== "gentle-ai.review-gate-result/v1") throw new TypeError("operation.result does not match review.validate");
1908
- enumeration(result.result, ["allow", "scope-changed", "invalidated", "escalated"] , "operation.result.result");
1909
- boolean(result.allowed, "operation.result.allowed");
1910
- nonempty(result.action, "operation.result.action");
1911
- nonempty(result.reason, "operation.result.reason");
1912
- record(result.context, "operation.result.context");
1913
- if (result.delivery !== undefined && result.delivery !== "disabled/unmanaged") throw new TypeError("operation.result.delivery is unsupported");
1914
- } else if (operation === REVIEW_INTEGRATION_OPERATION.BIND_SDD) {
1915
- result = exactRecord(body.result, "operation.result", ["schema", "revision", "change", "lineage", "authority_revision", "receipt_hash", "gate_context"]);
1916
- if (result.schema !== "gentle-ai.sdd-review-binding/v1") throw new TypeError("operation.result does not match review.bind_sdd");
1917
- sha256(result.revision, "operation.result.revision");
1918
- nonempty(result.change, "operation.result.change");
1919
- nonempty(result.lineage, "operation.result.lineage");
1920
- sha256(result.authority_revision, "operation.result.authority_revision");
1921
- sha256(result.receipt_hash, "operation.result.receipt_hash");
1922
- record(result.gate_context, "operation.result.gate_context");
1923
- } else {
1924
- result = exactRecord(body.result, "operation.result", ["operation", "predecessor_lineage_id", "predecessor_revision", "lineage_id", "state", "store_revision", "target_identity", "incident_digest", "recovery_disposition"]);
1925
- if (result.operation !== "review.retry_final_verification") throw new TypeError("operation.result does not match review.retry_final_verification");
1926
- lineage(result.predecessor_lineage_id, "operation.result.predecessor_lineage_id");
1927
- sha256(result.predecessor_revision, "operation.result.predecessor_revision");
1928
- lineage(result.lineage_id, "operation.result.lineage_id");
1929
- if (result.state !== "validating") throw new TypeError("operation.result.state must be validating");
1930
- sha256(result.store_revision, "operation.result.store_revision");
1931
- sha256(result.target_identity, "operation.result.target_identity");
1932
- sha256(result.incident_digest, "operation.result.incident_digest");
1933
- if (result.recovery_disposition !== "final_verification_retry") throw new TypeError("operation.result.recovery_disposition must be final_verification_retry");
1934
- }
1935
- return { contract: REVIEW_INTEGRATION_CONTRACT, operation, result, raw: body };
2091
+ export function decodeReviewAdvisoryFindingsV1(value , label ) {
2092
+ const body = exactRecord(value, label, ["statement", "findings"]);
2093
+ return {
2094
+ statement: nonempty(body.statement, `${label}.statement`),
2095
+ findings: array(body.findings, `${label}.findings`, (entry, itemLabel) => {
2096
+ const finding = exactRecord(entry, itemLabel, ["id", "severity", "disposition"], ["lens", "location"]);
2097
+ return {
2098
+ id: nonempty(finding.id, `${itemLabel}.id`),
2099
+ ...(finding.lens === undefined ? {} : { lens: nonempty(finding.lens, `${itemLabel}.lens`) }),
2100
+ ...(finding.location === undefined ? {} : { location: nonempty(finding.location, `${itemLabel}.location`) }),
2101
+ severity: enumeration(finding.severity, Object.values(REVIEW_ADVISORY_FINDING_SEVERITY), `${itemLabel}.severity`),
2102
+ disposition: enumeration(finding.disposition, Object.values(REVIEW_ADVISORY_FINDING_DISPOSITION), `${itemLabel}.disposition`),
2103
+ };
2104
+ }, { minimum: 1 }),
2105
+ };
1936
2106
  }
1937
2107
 
1938
2108
  // ---------------------------------------------------------------------------
@@ -2067,3 +2237,394 @@ export function decodeReviewResultArtifactV2(value )
2067
2237
  raw: body,
2068
2238
  };
2069
2239
  }
2240
+
2241
+ // Terminal capture answers are emitted directly by the native provider. Pi
2242
+ // validates their closed shape and identity, then treats all lifecycle meaning
2243
+ // as opaque provider-owned state.
2244
+ export const REVIEW_LAST_EVENT_CLOSURE_SCHEMA = "gentle-ai.review-last-event-closure/v1";
2245
+ export const REVIEW_LAST_EVENT_CLOSURE_OPERATION = {
2246
+ CAPTURE_RESULT: "review/capture-result",
2247
+ CAPTURE_CORRECTION_PLAN: "review.capture-correction-plan",
2248
+ CAPTURE_REFUTER: "review.capture-refuter",
2249
+ CAPTURE_VALIDATION: "review/capture-validation",
2250
+ } ;
2251
+
2252
+
2253
+ const REVIEW_LAST_EVENT_TERMINAL_STATES = ["approved", "correction_required", "escalated"] ;
2254
+
2255
+
2256
+ const REVIEW_STATUS_CONTINUATION_OPERATION = {
2257
+ STATUS: "review.status",
2258
+ } ;
2259
+
2260
+
2261
+
2262
+
2263
+
2264
+
2265
+
2266
+
2267
+
2268
+
2269
+
2270
+
2271
+
2272
+
2273
+
2274
+
2275
+
2276
+
2277
+
2278
+
2279
+
2280
+
2281
+
2282
+
2283
+
2284
+
2285
+
2286
+
2287
+
2288
+
2289
+
2290
+ const REVIEW_APPROVED_ACKNOWLEDGEMENT_OPERATION = "review.acknowledge-approved" ;
2291
+
2292
+ // The exact ordered argument names the provider renders for one approved
2293
+ // acknowledgement. The list is closed and positional on the wire, so decoding
2294
+ // by position is what proves the relay is replaying the provider's own
2295
+ // invocation rather than one the host assembled.
2296
+ const REVIEW_APPROVED_ACKNOWLEDGEMENT_ARGUMENTS = ["cwd", "lineage", "target", "expected-revision", "token"] ;
2297
+
2298
+
2299
+
2300
+
2301
+
2302
+
2303
+
2304
+
2305
+
2306
+
2307
+
2308
+
2309
+
2310
+
2311
+
2312
+
2313
+
2314
+
2315
+
2316
+
2317
+
2318
+
2319
+
2320
+ function assertReviewApprovedAcknowledgementExecuteShapeV1(execute ) {
2321
+ if (execute.operation !== REVIEW_APPROVED_ACKNOWLEDGEMENT_OPERATION) throw new TypeError(`acknowledgement.execute.operation must be ${REVIEW_APPROVED_ACKNOWLEDGEMENT_OPERATION}`);
2322
+ if (execute.command === undefined) throw new TypeError("acknowledgement.execute.command is required");
2323
+ text(execute.command, "acknowledgement.execute.command", { minimum: 1, pattern: /^gentle-ai review acknowledge-approved(?: |$)/ });
2324
+ if (execute.arguments.length !== REVIEW_APPROVED_ACKNOWLEDGEMENT_ARGUMENTS.length) throw new TypeError(`acknowledgement.execute.arguments must carry exactly ${REVIEW_APPROVED_ACKNOWLEDGEMENT_ARGUMENTS.length} provider-issued arguments`);
2325
+ const values = execute.arguments.map((argument, index) => { const name = REVIEW_APPROVED_ACKNOWLEDGEMENT_ARGUMENTS[index] ; if (argument.name !== name) throw new TypeError(`acknowledgement.execute.arguments[${index}].name must be ${name}`); const value = nonempty(argument.value, `acknowledgement.execute.arguments[${index}].value`); if (nonempty(argument.token, `acknowledgement.execute.arguments[${index}].token`) !== `--${name}=${value}`) throw new TypeError(`acknowledgement.execute.arguments[${index}].token must exactly match ${name}`); return value; });
2326
+ if (execute.preconditions.length !== 1 || execute.preconditions[0]?.name !== "state" || execute.preconditions[0]?.value !== "approved") throw new TypeError("acknowledgement.execute.preconditions must be the single approved state precondition");
2327
+ return { tokens: execute.arguments.map((argument) => argument.token ) , values: values , lineageId: lineage(execute.binding.lineageId, "acknowledgement.execute.binding.lineage_id"), targetIdentity: sha256(execute.binding.targetIdentity, "acknowledgement.execute.binding.target_identity"), revision: sha256(execute.binding.revision, "acknowledgement.execute.binding.revision") };
2328
+ }
2329
+
2330
+ /**
2331
+ * Proves that an approved-acknowledgement execute vector is the exact closed,
2332
+ * provider-issued burn invocation. Callers can additionally bind its values to
2333
+ * their own current STATUS before invoking the returned tokens.
2334
+ */
2335
+ export function assertReviewApprovedAcknowledgementExecuteV1(
2336
+ execute ,
2337
+ expected = {},
2338
+ ) {
2339
+ const shape = assertReviewApprovedAcknowledgementExecuteShapeV1(execute);
2340
+ if (shape.values[1] !== shape.lineageId) throw new TypeError("acknowledgement lineage argument does not match its binding");
2341
+ if (shape.values[2] !== shape.targetIdentity) throw new TypeError("acknowledgement target argument does not match its binding");
2342
+ if (shape.values[3] !== shape.revision) throw new TypeError("acknowledgement revision argument does not match its binding");
2343
+ if (expected.cwd !== undefined && shape.values[0] !== expected.cwd) throw new TypeError("acknowledgement.execute.cwd does not match the current target");
2344
+ if (expected.lineageId !== undefined && shape.lineageId !== expected.lineageId) throw new TypeError("acknowledgement.execute.lineage does not match the current target");
2345
+ if (expected.targetIdentity !== undefined && shape.targetIdentity !== expected.targetIdentity) throw new TypeError("acknowledgement.execute.target does not match the current target");
2346
+ if (expected.revision !== undefined && shape.revision !== expected.revision) throw new TypeError("acknowledgement.execute.revision does not match the current target"); return shape.tokens;
2347
+ }
2348
+
2349
+ // ---------------------------------------------------------------------------
2350
+ // review-acknowledged/v1 — the answer the burn prints (gentle-ai #3947)
2351
+ // ---------------------------------------------------------------------------
2352
+
2353
+ // Until gentle-ai #3947 a successful `review acknowledge-approved` burned its
2354
+ // authority in silence and a host could only infer the burn from a later
2355
+ // STATUS offering a fresh START. From main commit bc9f74d2 the command prints
2356
+ // exactly this envelope on success. Like result-artifact/v2 it carries no
2357
+ // `contract`: the schema constant plus the slash-form operation are its whole
2358
+ // identity, so requireIdentity (which demands the contract pair) does not
2359
+ // apply. Every published release up to v2.5.0-rc.3 still prints nothing; the
2360
+ // native client owns that distinction, this decoder only ever sees bytes.
2361
+ export const REVIEW_ACKNOWLEDGED_SCHEMA = "gentle-ai.review-acknowledged/v1" ;
2362
+ const REVIEW_ACKNOWLEDGED_OPERATION = "review/acknowledge-approved" ;
2363
+
2364
+
2365
+
2366
+
2367
+
2368
+
2369
+
2370
+
2371
+
2372
+
2373
+
2374
+
2375
+ /** The binding the caller already holds from STATUS; the envelope must name exactly that burn. */
2376
+
2377
+
2378
+
2379
+
2380
+
2381
+
2382
+ export function decodeReviewAcknowledgedV1(value , expected = {}) {
2383
+ if (record(value, "acknowledged").schema !== REVIEW_ACKNOWLEDGED_SCHEMA) throw new TypeError(`schema must be ${REVIEW_ACKNOWLEDGED_SCHEMA}`);
2384
+ const body = exactRecord(value, "acknowledged", ["schema", "operation", "action", "lineage_id", "target_identity", "consumed_revision", "authority"]);
2385
+ if (body.operation !== REVIEW_ACKNOWLEDGED_OPERATION) throw new TypeError(`acknowledged.operation must be ${REVIEW_ACKNOWLEDGED_OPERATION}`);
2386
+ if (body.action !== "acknowledged") throw new TypeError("acknowledged.action must be acknowledged");
2387
+ if (body.authority !== "burned") throw new TypeError("acknowledged.authority must be burned");
2388
+ const decoded = {
2389
+ schema: REVIEW_ACKNOWLEDGED_SCHEMA,
2390
+ operation: REVIEW_ACKNOWLEDGED_OPERATION,
2391
+ action: "acknowledged",
2392
+ lineageId: lineage(body.lineage_id, "acknowledged.lineage_id"),
2393
+ targetIdentity: sha256(body.target_identity, "acknowledged.target_identity"),
2394
+ consumedRevision: sha256(body.consumed_revision, "acknowledged.consumed_revision"),
2395
+ authority: "burned",
2396
+ raw: body,
2397
+ };
2398
+ if (expected.lineageId !== undefined && decoded.lineageId !== expected.lineageId) throw new TypeError("acknowledged.lineage_id does not name the acknowledged lineage");
2399
+ if (expected.targetIdentity !== undefined && decoded.targetIdentity !== expected.targetIdentity) throw new TypeError("acknowledged.target_identity does not name the acknowledged target");
2400
+ if (expected.revision !== undefined && decoded.consumedRevision !== expected.revision) throw new TypeError("acknowledged.consumed_revision does not name the consumed revision");
2401
+ return decoded;
2402
+ }
2403
+
2404
+
2405
+
2406
+
2407
+
2408
+
2409
+
2410
+
2411
+
2412
+
2413
+
2414
+
2415
+
2416
+
2417
+
2418
+
2419
+
2420
+
2421
+
2422
+
2423
+
2424
+
2425
+
2426
+
2427
+
2428
+
2429
+
2430
+ function decodeReviewStatusContinuationArtifactV1(value , label ) {
2431
+ const artifact = exactRecord(value, label, ["schema", "capability", "sha256", "lineage_id", "target_identity", "lens", "selected_order", "subject_hash", "admission_decision"]);
2432
+ if (artifact.schema !== "gentle-ai.review-result-artifact/v2") throw new TypeError(`${label}.schema must be gentle-ai.review-result-artifact/v2`);
2433
+ if (artifact.capability !== "review.native_result_artifact") throw new TypeError(`${label}.capability must be review.native_result_artifact`);
2434
+ if (artifact.admission_decision !== "completed") throw new TypeError(`${label}.admission_decision must be completed`);
2435
+ return {
2436
+ schema: "gentle-ai.review-result-artifact/v2",
2437
+ capability: "review.native_result_artifact",
2438
+ sha256: sha256(artifact.sha256, `${label}.sha256`),
2439
+ lineageId: lineage(artifact.lineage_id, `${label}.lineage_id`),
2440
+ targetIdentity: sha256(artifact.target_identity, `${label}.target_identity`),
2441
+ lens: nonempty(artifact.lens, `${label}.lens`),
2442
+ selectedOrder: integer(artifact.selected_order, `${label}.selected_order`, 0),
2443
+ subjectHash: sha256(artifact.subject_hash, `${label}.subject_hash`),
2444
+ admissionDecision: "completed",
2445
+ };
2446
+ }
2447
+
2448
+ // decodeReviewApprovedAcknowledgementV1 retains the closure-specific wire
2449
+ // boundary with the shared shape validator; its semantic binding stays outside
2450
+ // the defensive closure catch in the exported assertion.
2451
+ function decodeReviewApprovedAcknowledgementV1(value , label ) {
2452
+ const body = exactRecord(value, label, ["operation", "command", "arguments", "preconditions", "binding"]);
2453
+ const argumentsList = decodeTransitionArguments(body.arguments, `${label}.arguments`);
2454
+ const preconditions = decodeTransitionArguments(body.preconditions, `${label}.preconditions`);
2455
+ const sourceBinding = exactRecord(body.binding, `${label}.binding`, ["lineage_id", "revision", "target_identity"], ["repository_context"]);
2456
+ const repositoryContext = sourceBinding.repository_context === undefined
2457
+ ? undefined
2458
+ : text(sourceBinding.repository_context, `${label}.binding.repository_context`, { pattern: /^rctx[12]_[0-9a-f]{64}$/ });
2459
+ const acknowledgement = {
2460
+ operation: body.operation,
2461
+ command: body.command,
2462
+ arguments: argumentsList,
2463
+ preconditions,
2464
+ binding: {
2465
+ lineageId: sourceBinding.lineage_id,
2466
+ revision: sourceBinding.revision,
2467
+ targetIdentity: sourceBinding.target_identity,
2468
+ ...(repositoryContext === undefined ? {} : { repositoryContext }),
2469
+ },
2470
+ } ;
2471
+ const shape = assertReviewApprovedAcknowledgementExecuteShapeV1(acknowledgement);
2472
+ return {
2473
+ operation: REVIEW_APPROVED_ACKNOWLEDGEMENT_OPERATION,
2474
+ command: acknowledgement.command ,
2475
+ arguments: argumentsList,
2476
+ preconditions,
2477
+ binding: {
2478
+ lineageId: shape.lineageId,
2479
+ revision: shape.revision,
2480
+ targetIdentity: shape.targetIdentity,
2481
+ ...(repositoryContext === undefined ? {} : { repositoryContext }),
2482
+ },
2483
+ raw: body,
2484
+ };
2485
+ }
2486
+
2487
+ function decodeReviewStatusContinuationV1(value ) {
2488
+ const body = exactRecord(value, "last_event_closure.status_continuation", ["operation", "arguments", "preconditions", "binding"], ["command", "selector_arguments", "artifacts"]);
2489
+ if (body.operation !== REVIEW_STATUS_CONTINUATION_OPERATION.STATUS) throw new TypeError("last_event_closure.status_continuation.operation must be review.status");
2490
+ const argumentsList = decodeTransitionArguments(body.arguments, "last_event_closure.status_continuation.arguments");
2491
+ if (argumentsList.some((argument) => argument.token === undefined)) throw new TypeError("last_event_closure.status_continuation.arguments require exact tokens");
2492
+ const preconditions = decodeTransitionArguments(body.preconditions, "last_event_closure.status_continuation.preconditions");
2493
+ if (preconditions.length === 0) throw new TypeError("last_event_closure.status_continuation.preconditions requires at least one entry");
2494
+ const sourceBinding = exactRecord(body.binding, "last_event_closure.status_continuation.binding", ["target_identity"], ["lineage_id", "revision", "repository_context"]);
2495
+ const lineageId = sourceBinding.lineage_id === undefined ? undefined : lineage(sourceBinding.lineage_id, "last_event_closure.status_continuation.binding.lineage_id");
2496
+ const revision = sourceBinding.revision === undefined ? undefined : sha256(sourceBinding.revision, "last_event_closure.status_continuation.binding.revision");
2497
+ const repositoryContext = sourceBinding.repository_context === undefined
2498
+ ? undefined
2499
+ : text(sourceBinding.repository_context, "last_event_closure.status_continuation.binding.repository_context", { pattern: /^rctx[12]_[0-9a-f]{64}$/ });
2500
+ const selectorArguments = body.selector_arguments === undefined
2501
+ ? undefined
2502
+ : decodeTransitionArguments(body.selector_arguments, "last_event_closure.status_continuation.selector_arguments");
2503
+ const artifacts = body.artifacts === undefined
2504
+ ? undefined
2505
+ : array(body.artifacts, "last_event_closure.status_continuation.artifacts", decodeReviewStatusContinuationArtifactV1);
2506
+ const command = body.command === undefined
2507
+ ? undefined
2508
+ : text(body.command, "last_event_closure.status_continuation.command", { minimum: 1, pattern: /^gentle-ai review [a-z][a-z-]*/ });
2509
+ return {
2510
+ operation: REVIEW_STATUS_CONTINUATION_OPERATION.STATUS,
2511
+ arguments: argumentsList,
2512
+ ...(selectorArguments === undefined ? {} : { selectorArguments }),
2513
+ preconditions,
2514
+ binding: {
2515
+ targetIdentity: sha256(sourceBinding.target_identity, "last_event_closure.status_continuation.binding.target_identity"),
2516
+ ...(lineageId === undefined ? {} : { lineageId }),
2517
+ ...(revision === undefined ? {} : { revision }),
2518
+ ...(repositoryContext === undefined ? {} : { repositoryContext }),
2519
+ },
2520
+ ...(artifacts === undefined ? {} : { artifacts }),
2521
+ ...(command === undefined ? {} : { command }),
2522
+ raw: body,
2523
+ };
2524
+ }
2525
+
2526
+ export function decodeReviewLastEventClosureV1(value ) {
2527
+ const body = exactRecord(value, "last_event_closure", ["schema", "operation", "lineage_id", "state", "store_revision"], ["target_identity", "request_hash", "correction_lines", "action", "advisory_findings", "status_continuation", "acknowledgement"]);
2528
+ if (body.schema !== REVIEW_LAST_EVENT_CLOSURE_SCHEMA) throw new TypeError(`last_event_closure.schema must be ${REVIEW_LAST_EVENT_CLOSURE_SCHEMA}`);
2529
+ const operation = enumeration(body.operation, Object.values(REVIEW_LAST_EVENT_CLOSURE_OPERATION), "last_event_closure.operation") ;
2530
+ const state = enumeration(body.state, REVIEW_LAST_EVENT_TERMINAL_STATES, "last_event_closure.state") ;
2531
+ const shared = {
2532
+ schema: REVIEW_LAST_EVENT_CLOSURE_SCHEMA,
2533
+ operation,
2534
+ lineageId: lineage(body.lineage_id, "last_event_closure.lineage_id"),
2535
+ state,
2536
+ storeRevision: sha256(body.store_revision, "last_event_closure.store_revision"),
2537
+ };
2538
+ if (operation === REVIEW_LAST_EVENT_CLOSURE_OPERATION.CAPTURE_CORRECTION_PLAN) {
2539
+ if (body.action !== undefined || body.advisory_findings !== undefined || body.status_continuation !== undefined) throw new TypeError("last_event_closure correction-plan cannot carry action, advisory_findings, or status_continuation");
2540
+ if (state !== "correction_required") throw new TypeError("last_event_closure correction-plan requires correction_required state");
2541
+ return {
2542
+ ...shared,
2543
+ targetIdentity: sha256(body.target_identity, "last_event_closure.target_identity"),
2544
+ requestHash: sha256(body.request_hash, "last_event_closure.request_hash"),
2545
+ correctionLines: integer(body.correction_lines, "last_event_closure.correction_lines", 1, 200),
2546
+ };
2547
+ }
2548
+ if (body.target_identity !== undefined || body.request_hash !== undefined || body.correction_lines !== undefined) throw new TypeError("last_event_closure terminal capture cannot carry correction-plan fields");
2549
+ const requiresStatusContinuation = state === "correction_required" && (
2550
+ operation === REVIEW_LAST_EVENT_CLOSURE_OPERATION.CAPTURE_RESULT || operation === REVIEW_LAST_EVENT_CLOSURE_OPERATION.CAPTURE_REFUTER
2551
+ );
2552
+ if (requiresStatusContinuation && body.status_continuation === undefined) throw new TypeError("last_event_closure requires status_continuation for correction-required result or refuter capture");
2553
+ if (!requiresStatusContinuation && body.status_continuation !== undefined) throw new TypeError("last_event_closure status_continuation is only valid for correction-required result or refuter capture");
2554
+ const statusContinuation = body.status_continuation === undefined ? undefined : decodeReviewStatusContinuationV1(body.status_continuation);
2555
+ if (statusContinuation !== undefined) {
2556
+ if (statusContinuation.binding.lineageId !== shared.lineageId) {
2557
+ throw new TypeError("last_event_closure status continuation lineage does not match its enclosing closure");
2558
+ }
2559
+ if (statusContinuation.binding.revision !== shared.storeRevision) {
2560
+ throw new TypeError("last_event_closure status continuation revision does not match its enclosing closure");
2561
+ }
2562
+ const lineageArguments = statusContinuation.arguments.filter((argument) => argument.name === "lineage");
2563
+ if (lineageArguments.length !== 1 || lineageArguments[0]?.value !== shared.lineageId || lineageArguments[0]?.token !== `--lineage=${shared.lineageId}`) {
2564
+ throw new TypeError("last_event_closure status continuation lineage argument does not match its enclosing closure");
2565
+ }
2566
+ }
2567
+ // Only an approved closure may carry the continuation that burns its
2568
+ // authority: any other state offering an acknowledgement would be inviting
2569
+ // a burn the provider never authorized.
2570
+ //
2571
+ // It stays optional because the pinned installer binary predates it. A
2572
+ // provider that emits one is decoded strictly; a provider that does not is
2573
+ // still the contract this build ships against. Requiring it belongs with
2574
+ // the pin bump that makes it always present.
2575
+ // Decoded defensively on purpose. This decoder pins the acknowledgement to a
2576
+ // closed positional shape, and the same patch that added it already shows
2577
+ // what strictness costs when the provider moves: rejecting one omitempty
2578
+ // field made every targeted-validation STATUS that carried it undecodable.
2579
+ // Here the blast radius would be worse than a lost field. Throwing would
2580
+ // fail the whole approved closure, so the host would lose the approval
2581
+ // outcome AND the only invocation that burns the authority, leaving the
2582
+ // lineage approved and un-burnable at once. An unreadable continuation
2583
+ // degrades to a flag; everything else about the approval still arrives.
2584
+ let acknowledgement ;
2585
+ let acknowledgementUndecodable = false;
2586
+ if (body.acknowledgement !== undefined) {
2587
+ try {
2588
+ acknowledgement = decodeReviewApprovedAcknowledgementV1(body.acknowledgement, "last_event_closure.acknowledgement");
2589
+ } catch {
2590
+ acknowledgement = undefined;
2591
+ acknowledgementUndecodable = true;
2592
+ }
2593
+ }
2594
+ if (acknowledgementUndecodable && state !== "approved") {
2595
+ throw new TypeError("last_event_closure acknowledgement requires approved state");
2596
+ }
2597
+ if (acknowledgement !== undefined) {
2598
+ if (state !== "approved") throw new TypeError("last_event_closure acknowledgement requires approved state");
2599
+ assertReviewApprovedAcknowledgementExecuteV1(acknowledgement, { lineageId: shared.lineageId, revision: shared.storeRevision });
2600
+ }
2601
+ const action = nonempty(body.action, "last_event_closure.action");
2602
+ const advisoryFindings = body.advisory_findings === undefined
2603
+ ? undefined
2604
+ : decodeReviewAdvisoryFindingsV1(body.advisory_findings, "last_event_closure.advisory_findings");
2605
+ if (advisoryFindings !== undefined && state !== "approved") throw new TypeError("last_event_closure advisory_findings requires approved state");
2606
+ return {
2607
+ ...shared,
2608
+ action,
2609
+ ...(advisoryFindings === undefined ? {} : { advisoryFindings }),
2610
+ ...(statusContinuation === undefined ? {} : { statusContinuation }),
2611
+ ...(acknowledgement === undefined ? {} : { acknowledgement }),
2612
+ ...(acknowledgementUndecodable ? { acknowledgementUndecodable: true } : {}),
2613
+ };
2614
+ }
2615
+
2616
+ export function assertReviewLastEventClosureBinding(
2617
+ closure ,
2618
+ binding ,
2619
+ ) {
2620
+ if (closure.lineageId !== binding.lineageId) throw new TypeError("last_event_closure lineage does not match its provider binding");
2621
+ if (binding.targetIdentity !== undefined && closure.targetIdentity !== undefined && closure.targetIdentity !== binding.targetIdentity) {
2622
+ throw new TypeError("last_event_closure target does not match its provider binding");
2623
+ }
2624
+ if (binding.targetIdentity !== undefined && closure.statusContinuation !== undefined && closure.statusContinuation.binding.targetIdentity !== binding.targetIdentity) {
2625
+ throw new TypeError("last_event_closure status continuation target does not match its provider binding");
2626
+ }
2627
+ if (binding.requestHash !== undefined && closure.requestHash !== undefined && closure.requestHash !== binding.requestHash) {
2628
+ throw new TypeError("last_event_closure request hash does not match its provider binding");
2629
+ }
2630
+ }