gentle-pi 2.1.2 → 2.3.0

package/lib/review-refuter-adapter.ts

@@ -1,129 +0,0 @@
-import {
-	COMPACT_FINDING_OUTCOME,
-	type CompactRefuterRequest,
-	type CompactRefuterResult,
-} from "./review-compact.ts";
-
-const REFUTER_BATCH_SCHEMA = "gentle-ai.refuter-result-batch/v1";
-const DIGEST = /^[0-9a-f]{64}$/;
-
-export const REFUTER_BATCH_STATUS = {
-	NORMALIZED: "normalized",
-	INVALID: "invalid",
-} as const;
-
-export interface RefuterBatchRow {
-	finding_id: string;
-	outcome: CompactRefuterResult["outcome"];
-	proof_refs: string[];
-}
-
-export interface RefuterBatch {
-	schema: typeof REFUTER_BATCH_SCHEMA;
-	request_hash: string;
-	results: RefuterBatchRow[];
-}
-
-export interface NativeRefuterDocument {
-	results: RefuterBatchRow[];
-}
-
-interface NormalizedRefuterBatch {
-	status: typeof REFUTER_BATCH_STATUS.NORMALIZED;
-	refuter_request_hash: string;
-	refuter_results: CompactRefuterResult[];
-}
-
-interface InvalidRefuterBatch {
-	status: typeof REFUTER_BATCH_STATUS.INVALID;
-	reason_code: string;
-}
-
-export type RefuterBatchNormalization = NormalizedRefuterBatch | InvalidRefuterBatch;
-
-function invalid(reason_code: string): InvalidRefuterBatch {
-	return { status: REFUTER_BATCH_STATUS.INVALID, reason_code };
-}
-
-function record(value: unknown): Record<string, unknown> | undefined {
-	if (typeof value !== "object" || value === null || Array.isArray(value) || Object.getPrototypeOf(value) !== Object.prototype) return undefined;
-	return value as Record<string, unknown>;
-}
-
-function exact(object: Record<string, unknown>, keys: readonly string[]): boolean {
-	return Object.keys(object).length === keys.length && keys.every((key) => key in object);
-}
-
-function parseBatch(value: unknown): RefuterBatch | InvalidRefuterBatch {
-	let raw = value;
-	if (typeof raw === "string") {
-		if (raw.length === 0 || raw.trim() !== raw) return invalid("refuter-batch-prose");
-		try {
-			raw = JSON.parse(raw) as unknown;
-		} catch {
-			return invalid("refuter-batch-json");
-		}
-	}
-	const batch = record(raw);
-	if (!batch || !exact(batch, ["schema", "request_hash", "results"])) return invalid("refuter-batch-shape");
-	if (batch.schema !== REFUTER_BATCH_SCHEMA || typeof batch.request_hash !== "string" || !DIGEST.test(batch.request_hash) || !Array.isArray(batch.results)) {
-		return invalid("refuter-batch-shape");
-	}
-	const results: RefuterBatchRow[] = [];
-	for (const result of batch.results) {
-		const row = record(result);
-		if (!row || !exact(row, ["finding_id", "outcome", "proof_refs"])) return invalid("refuter-row-shape");
-		if (
-			typeof row.finding_id !== "string" || row.finding_id.length === 0 || row.finding_id.trim() !== row.finding_id ||
-			(row.outcome !== COMPACT_FINDING_OUTCOME.REFUTED && row.outcome !== COMPACT_FINDING_OUTCOME.CORROBORATED && row.outcome !== COMPACT_FINDING_OUTCOME.INCONCLUSIVE) ||
-			!Array.isArray(row.proof_refs) ||
-			row.proof_refs.length === 0 ||
-			row.proof_refs.some((proof) => typeof proof !== "string" || proof.length === 0 || proof.trim() !== proof)
-		) return invalid("refuter-row-value");
-		results.push({ finding_id: row.finding_id, outcome: row.outcome, proof_refs: [...row.proof_refs] });
-	}
-	return { schema: REFUTER_BATCH_SCHEMA, request_hash: batch.request_hash, results };
-}
-
-export function parseRefuterBatch(value: unknown): RefuterBatch {
-	const batch = parseBatch(value);
-	if ("status" in batch) throw new TypeError(batch.reason_code);
-	return batch;
-}
-
-export function toNativeRefuterDocument(batch: RefuterBatch): NativeRefuterDocument {
-	return { results: batch.results.map((row) => ({ ...row, proof_refs: [...row.proof_refs] })) };
-}
-
-export function normalizeRefuterBatch(
-	request: CompactRefuterRequest,
-	value: unknown,
-): RefuterBatchNormalization {
-	const batch = parseBatch(value);
-	if ("status" in batch) return batch;
-	if (batch.request_hash !== request.request_hash) return invalid("refuter-request-hash");
-	const frozen = new Map(request.findings.map((finding) => [finding.id, finding]));
-	const rows = new Map<string, RefuterBatchRow>();
-	for (const row of batch.results) {
-		const finding = frozen.get(row.finding_id);
-		if (!finding) return invalid("refuter-finding-id");
-		if (rows.has(row.finding_id)) return invalid("refuter-duplicate-id");
-		if (row.proof_refs.length === 0 || new Set(row.proof_refs).size !== row.proof_refs.length) return invalid("refuter-proof-refs");
-		rows.set(row.finding_id, row);
-	}
-	if (rows.size !== request.findings.length) return invalid("refuter-missing-id");
-	const refuter_results = request.findings.map((finding) => {
-		const row = rows.get(finding.id);
-		if (!row) throw new Error("Complete refuter batch lost a frozen finding");
-		return {
-			finding_id: row.finding_id,
-			outcome: row.outcome,
-			proof_refs: [...row.proof_refs].toSorted(),
-		};
-	});
-	return {
-		status: REFUTER_BATCH_STATUS.NORMALIZED,
-		refuter_request_hash: request.request_hash,
-		refuter_results,
-	};
-}

package/lib/review-runtime-contract.ts

@@ -1,68 +0,0 @@
-import { domainHashV1 } from "./review-canonical.ts";
-
-export const REVIEW_RUNTIME_INCOMPATIBLE = "REVIEW_RUNTIME_INCOMPATIBLE";
-
-export interface LoadedReviewRuntimeIdentityV1 {
-	schema: "gentle-ai.review-runtime/v1";
-	compact_contract: "gentle-ai.review-compact/v2";
-	operation_contract: string;
-	state_schema: "gentle-ai.review-state/v2";
-	record_schema: "gentle-ai.review-state-record/v2";
-	receipt_schema: "gentle-ai.review-receipt-body/v2";
-	canonicalization: "gentle-ai.canonical-json/v1";
-	identity_hash: string;
-}
-
-function identityBody(): Omit<LoadedReviewRuntimeIdentityV1, "identity_hash"> {
-	return {
-		schema: "gentle-ai.review-runtime/v1",
-		compact_contract: "gentle-ai.review-compact/v2",
-		operation_contract: "gentle-ai.review-operation/v1",
-		state_schema: "gentle-ai.review-state/v2",
-		record_schema: "gentle-ai.review-state-record/v2",
-		receipt_schema: "gentle-ai.review-receipt-body/v2",
-		canonicalization: "gentle-ai.canonical-json/v1",
-	};
-}
-
-function createIdentity(): LoadedReviewRuntimeIdentityV1 {
-	const body = identityBody();
-	return { ...body, identity_hash: domainHashV1("review-runtime-contract", body) };
-}
-
-let testIdentity: LoadedReviewRuntimeIdentityV1 | undefined;
-
-export function loadedReviewRuntimeIdentity(): LoadedReviewRuntimeIdentityV1 {
-	return testIdentity ?? createIdentity();
-}
-
-function identityHash(identity: Omit<LoadedReviewRuntimeIdentityV1, "identity_hash">): string {
-	return domainHashV1("review-runtime-contract", identity);
-}
-
-export function assertReviewRuntimeIdentity(identity: LoadedReviewRuntimeIdentityV1): void {
-	if (!hasValidIdentityHash(identity)) throw new Error(REVIEW_RUNTIME_INCOMPATIBLE);
-}
-
-function hasValidIdentityHash(identity: LoadedReviewRuntimeIdentityV1): boolean {
-	return identity.identity_hash === identityHash({
-		schema: identity.schema,
-		compact_contract: identity.compact_contract,
-		operation_contract: identity.operation_contract,
-		state_schema: identity.state_schema,
-		record_schema: identity.record_schema,
-		receipt_schema: identity.receipt_schema,
-		canonicalization: identity.canonicalization,
-	});
-}
-
-export function assertLoadedReviewRuntimeIdentity(expected: LoadedReviewRuntimeIdentityV1): void {
-	const actual = loadedReviewRuntimeIdentity();
-	assertReviewRuntimeIdentity(actual);
-	assertReviewRuntimeIdentity(expected);
-	if (actual.identity_hash !== expected.identity_hash) throw new Error(REVIEW_RUNTIME_INCOMPATIBLE);
-}
-
-export function setLoadedReviewRuntimeIdentityForTesting(identity: LoadedReviewRuntimeIdentityV1 | undefined): void {
-	testIdentity = identity;
-}

package/prompts/gcl.md

@@ -1,54 +0,0 @@
----
-description: Audit changelog entries before release
----
-Audit changelog entries for all commits since the last release.
-
-## Process
-
-1. **Find the last release tag:**
-   ```bash
-   git tag --sort=-version:refname | head -1
-   ```
-
-2. **List all commits since that tag:**
-   ```bash
-   git log <tag>..HEAD --oneline
-   ```
-
-3. **Read each package's [Unreleased] section:**
-   - packages/ai/CHANGELOG.md
-   - packages/tui/CHANGELOG.md
-   - packages/coding-agent/CHANGELOG.md
-
-4. **For each commit, check:**
-   - Skip: changelog updates, doc-only changes, release housekeeping
-   - Skip: changes to generated model catalogs (for example `packages/ai/src/models.generated.ts`) unless accompanied by an intentional product-facing change in non-generated source/docs.
-   - Determine which package(s) the commit affects (use `git show <hash> --stat`)
-   - Verify a changelog entry exists in the affected package(s)
-   - For external contributions (PRs), verify format: `Description ([#N](url) by [@user](url))`
-
-5. **Cross-package duplication rule:**
-   Changes in `ai`, `agent` or `tui` that affect end users should be duplicated to `coding-agent` changelog, since coding-agent is the user-facing package that depends on them.
-
-6. **Add New Features section after changelog fixes:**
-   - Insert a `### New Features` section at the start of `## [Unreleased]` in `packages/coding-agent/CHANGELOG.md`.
-   - Propose the top new features to the user for confirmation before writing them.
-   - Link to relevant docs and sections whenever possible.
-
-7. **Report:**
-   - List commits with missing entries
-   - List entries that need cross-package duplication
-   - Add any missing entries directly
-
-## Changelog Format Reference
-
-Sections (in order):
-- `### Breaking Changes` - API changes requiring migration
-- `### Added` - New features
-- `### Changed` - Changes to existing functionality
-- `### Fixed` - Bug fixes
-- `### Removed` - Removed features
-
-Attribution:
-- Internal: `Fixed foo ([#123](https://github.com/earendil-works/pi-mono/issues/123))`
-- External: `Added bar ([#456](https://github.com/earendil-works/pi-mono/pull/456) by [@user](https://github.com/user))`

package/prompts/gis.md

@@ -1,25 +0,0 @@
----
-description: Analyze GitHub issues (bugs or feature requests)
-argument-hint: "<issue>"
----
-Analyze GitHub issue(s): $ARGUMENTS
-
-For each issue:
-
-1. Add the `inprogress` label to the issue via GitHub CLI before analysis starts. If adding the label fails, report that explicitly and continue.
-2. Read the issue in full, including all comments and linked issues/PRs.
-3. Do not trust analysis written in the issue. Independently verify behavior and derive your own analysis from the code and execution path.
-
-4. **For bugs**:
-   - Ignore any root cause analysis in the issue (likely wrong)
-   - Read all related code files in full (no truncation)
-   - Trace the code path and identify the actual root cause
-   - Propose a fix
-
-5. **For feature requests**:
-   - Do not trust implementation proposals in the issue without verification
-   - Read all related code files in full (no truncation)
-   - Propose the most concise implementation approach
-   - List affected files and changes needed
-
-Do NOT implement unless explicitly asked. Analyze and propose only.

package/prompts/gpr.md

@@ -1,41 +0,0 @@
----
-description: Review PRs from URLs with structured issue and code analysis
-argument-hint: "<PR-URL>"
----
-You are given one or more GitHub PR URLs: $@
-
-For each PR URL, do the following in order:
-1. Add the `inprogress` label to the PR via GitHub CLI before analysis starts. If adding the label fails, report that explicitly and continue.
-2. Read the PR page in full. Include description, all comments, all commits, and all changed files.
-3. Identify any linked issues referenced in the PR body, comments, commit messages, or cross links. Read each issue in full, including all comments.
-4. Analyze the PR diff. Read all relevant code files in full with no truncation from the current main branch and compare against the diff. Do not fetch PR file blobs unless a file is missing on main or the diff context is insufficient. Include related code paths that are not in the diff but are required to validate behavior.
-5. Check for a changelog entry in the relevant `packages/*/CHANGELOG.md` files. Report whether an entry exists. If missing, state that a changelog entry is required before merge and that you will add it if the user decides to merge. Follow the changelog format rules in AGENTS.md. Verify:
-   - Entry uses correct section (`### Breaking Changes`, `### Added`, `### Fixed`, etc.)
-   - External contributions include PR link and author: `Fixed foo ([#123](https://github.com/earendil-works/pi-mono/pull/123) by [@user](https://github.com/user))`
-   - Breaking changes are in `### Breaking Changes`, not just `### Fixed`
-6. Check if packages/coding-agent/README.md, packages/coding-agent/docs/*.md, packages/coding-agent/examples/**/*.md require modification. This is usually the case when existing features have been changed, or new features have been added.
-7. Provide a structured review with these sections:
-   - Good: solid choices or improvements
-   - Bad: concrete issues, regressions, missing tests, or risks
-   - Ugly: subtle or high impact problems
-8. Add Questions or Assumptions if anything is unclear.
-9. Add Change summary and Tests.
-
-Output format per PR:
-PR: <url>
-Changelog:
-- ...
-Good:
-- ...
-Bad:
-- ...
-Ugly:
-- ...
-Questions or Assumptions:
-- ...
-Change summary:
-- ...
-Tests:
-- ...
-
-If no issues are found, say so under Bad and Ugly.

package/prompts/gwr.md

@@ -1,31 +0,0 @@
----
-description: Finish the current task end-to-end with changelog, commit, and push
-argument-hint: "[instructions]"
----
-Wrap it.
-
-Additional instructions: $ARGUMENTS
-
-Determine context from the conversation history first.
-
-Rules for context detection:
-- If the conversation already mentions a GitHub issue or PR, use that existing context.
-- If the work came from `/is` or `/pr`, assume the issue or PR context is already known from the conversation and from the analysis work already done.
-- If there is no GitHub issue or PR in the conversation history, treat this as non-GitHub work.
-
-Unless I explicitly override something in this request, do the following in order:
-
-1. Add or update the relevant package changelog entry under `## [Unreleased]` using the repo changelog rules.
-2. If this task is tied to a GitHub issue or PR and a final issue or PR comment has not already been posted in this session, draft it in my tone, preview it, and post exactly one final comment.
-3. Commit only files you changed in this session.
-4. If this task is tied to exactly one GitHub issue, include `closes #<issue>` in the commit message. If it is tied to multiple issues, stop and ask which one to use. If it is not tied to any issue, do not include `closes #` or `fixes #` in the commit message.
-5. Check the current git branch. If it is not `main`, stop and ask what to do. Do not push from another branch unless I explicitly say so.
-6. Push the current branch.
-
-Constraints:
-- Never stage unrelated files.
-- Never use `git add .` or `git add -A`.
-- Run required checks before committing if code changed.
-- Do not open a PR unless I explicitly ask.
-- If this is not GitHub issue or PR work, do not post a GitHub comment.
-- If a final issue or PR comment was already posted in this session, do not post another one unless I explicitly ask.