gentle-pi 0.7.0 → 0.9.2

package/tests/sdd-status.test.ts

@@ -5,9 +5,12 @@ import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import test from "node:test";
 import {
+	isNonAuthoritativeStatus,
 	listActiveOpenSpecChanges,
 	parseSddStatusCommandArgs,
+	renderNativeSddPhasePrompt,
 	renderPhaseInstructions,
+	renderSddDispatcherMarkdown,
 	renderSddStatusMarkdown,
 	resolveSddStatus,
 } from "../lib/sdd-status.ts";
@@ -279,6 +282,76 @@ test("renderSddStatusMarkdown includes structured JSON", async () => {
 	assert.match(markdown, /"schemaName": "gentle-pi.sdd-status"/);
 });
 
+test("resolveSddStatus with artifactStore engram returns non-authoritative status without disk scan", async () => {
+	const cwd = await workspace();
+	// No openspec directory — simulates an engram-only session
+
+	const status = resolveSddStatus({ cwd, artifactStore: "engram", changeName: "my-change" });
+
+	assert.equal(status.artifactStore, "engram");
+	assert.equal(status.changeName, "my-change");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.dependencies.apply, "not_applicable");
+	assert.equal(status.applyState, "not_applicable");
+});
+
+test("resolveSddStatus with artifactStore none returns non-authoritative status without disk scan", async () => {
+	const cwd = await workspace();
+	// No openspec directory
+
+	const status = resolveSddStatus({ cwd, artifactStore: "none", changeName: "my-change" });
+
+	assert.equal(status.artifactStore, "none");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+});
+
+test("resolveSddStatus with artifactStore both uses disk scan and reflects store", async () => {
+	const cwd = await workspace();
+	seedChange(cwd);
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "add-auth" });
+
+	assert.equal(status.artifactStore, "both");
+	assert.equal(status.changeName, "add-auth");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+});
+
+test("resolveSddStatus with undefined store and existing openspec dir defaults to openspec and blocks", async () => {
+	const cwd = await workspace();
+	// Create openspec/ directory to signal an openspec workspace
+	mkdirSync(join(cwd, "openspec", "changes"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd });
+
+	// openspec workspace with no active changes → blocked (back-compat)
+	assert.equal(status.artifactStore, "openspec");
+	assert.match(status.blockedReasons[0] ?? "", /No active SDD changes/);
+});
+
+test("resolveSddStatus with undefined store and NO openspec dir returns non-authoritative status", async () => {
+	const cwd = await workspace();
+	// No openspec directory at all — unknown store, no disk evidence
+
+	const status = resolveSddStatus({ cwd });
+
+	// Safety net: should not emit the openspec false-block
+	assert.equal(status.artifactStore, "none");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.applyState, "not_applicable");
+});
+
+test("resolveSddStatus non-authoritative status has neutral planningHome (no misleading openspec path)", async () => {
+	const cwd = await workspace();
+
+	const status = resolveSddStatus({ cwd, artifactStore: "engram", changeName: "fix-auth" });
+
+	assert.equal(status.planningHome.changesDir, "");
+	assert.equal(status.planningHome.root, status.actionContext.workspaceRoot);
+});
+
 test("parseSddStatusCommandArgs extracts change and json flag", () => {
 	assert.deepEqual(parseSddStatusCommandArgs("add-auth --json"), {
 		changeName: "add-auth",
@@ -289,3 +362,250 @@ test("parseSddStatusCommandArgs extracts change and json flag", () => {
 		json: true,
 	});
 });
+
+test("resolveSddStatus with artifactStore both and NO openspec dir returns non-authoritative status", async () => {
+	const cwd = await workspace();
+	// No openspec directory — both store without disk backing is non-authoritative
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "my-change" });
+
+	assert.equal(status.artifactStore, "both");
+	assert.equal(status.changeName, "my-change");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.applyState, "not_applicable");
+	assert.equal(status.dependencies.apply, "not_applicable");
+	assert.equal(status.dependencies.archive, "not_applicable");
+});
+
+test("resolveSddStatus with artifactStore both and existing openspec dir runs authoritative disk scan", async () => {
+	const cwd = await workspace();
+	seedChange(cwd);
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "add-auth" });
+
+	assert.equal(status.artifactStore, "both");
+	assert.equal(status.changeName, "add-auth");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.artifacts.proposal, "done");
+});
+
+// Renamed: previously "returns true only when nextRecommended is resolve-via-engram" — now
+// explicitly asserts BOTH the typed isNonAuthoritative field and the sentinel together.
+test("isNonAuthoritativeStatus reads typed isNonAuthoritative field and matches resolve-via-engram sentinel", async () => {
+	const cwd = await workspace();
+
+	const engram = resolveSddStatus({ cwd, artifactStore: "engram", changeName: "x" });
+	assert.equal(engram.isNonAuthoritative, true);
+	assert.equal(isNonAuthoritativeStatus(engram), true);
+	assert.equal(engram.nextRecommended, "resolve-via-engram");
+
+	const none = resolveSddStatus({ cwd, artifactStore: "none", changeName: "x" });
+	assert.equal(none.isNonAuthoritative, true);
+	assert.equal(isNonAuthoritativeStatus(none), true);
+	assert.equal(none.nextRecommended, "resolve-via-engram");
+
+	const bothWithoutOpenspec = resolveSddStatus({ cwd, artifactStore: "both", changeName: "x" });
+	assert.equal(bothWithoutOpenspec.isNonAuthoritative, true);
+	assert.equal(isNonAuthoritativeStatus(bothWithoutOpenspec), true);
+	assert.equal(bothWithoutOpenspec.nextRecommended, "resolve-via-engram");
+
+	seedChange(cwd);
+	const bothWithOpenspec = resolveSddStatus({ cwd, artifactStore: "both", changeName: "add-auth" });
+	assert.equal(bothWithOpenspec.isNonAuthoritative, false);
+	assert.equal(isNonAuthoritativeStatus(bothWithOpenspec), false);
+	assert.notEqual(bothWithOpenspec.nextRecommended, "resolve-via-engram");
+});
+
+// Fix 4 item 4 — isNonAuthoritative boolean is set correctly on the typed field
+test("isNonAuthoritative boolean field is set correctly across all store/disk combinations", async () => {
+	const cwd = await workspace();
+
+	// engram → non-authoritative
+	const engram = resolveSddStatus({ cwd, artifactStore: "engram", changeName: "x" });
+	assert.equal(engram.isNonAuthoritative, true);
+
+	// none → non-authoritative
+	const none = resolveSddStatus({ cwd, artifactStore: "none", changeName: "x" });
+	assert.equal(none.isNonAuthoritative, true);
+
+	// both without openspec/ → non-authoritative
+	const bothWithout = resolveSddStatus({ cwd, artifactStore: "both", changeName: "x" });
+	assert.equal(bothWithout.isNonAuthoritative, true);
+
+	// both WITH openspec/ and seeded change → authoritative
+	seedChange(cwd);
+	const bothWith = resolveSddStatus({ cwd, artifactStore: "both", changeName: "add-auth" });
+	assert.equal(bothWith.isNonAuthoritative, false);
+
+	// openspec (default disk scan, seeded) → authoritative
+	const openspec = resolveSddStatus({ cwd, artifactStore: "openspec", changeName: "add-auth" });
+	assert.equal(openspec.isNonAuthoritative, false);
+});
+
+// Fix 4 item 1 — both + openspec/ dir present + change NOT on disk → non-authoritative
+test("resolveSddStatus with artifactStore both, openspec dir present but change not on disk returns non-authoritative", async () => {
+	const cwd = await workspace();
+	// Create an openspec/changes dir with a different change — not the requested one
+	mkdirSync(join(cwd, "openspec", "changes", "other-change"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "missing-change" });
+
+	assert.equal(status.isNonAuthoritative, true);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.applyState, "not_applicable");
+	assert.equal(status.artifactStore, "both");
+	// Must NOT be treated as blocked
+	assert.notEqual(status.applyState, "blocked");
+});
+
+// Fix 4 item 2 — strengthen existing both-with-openspec-and-seeded-change test
+test("resolveSddStatus with artifactStore both, openspec dir present and change on disk is authoritative", async () => {
+	const cwd = await workspace();
+	seedChange(cwd);
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "add-auth" });
+
+	assert.equal(status.artifactStore, "both");
+	assert.equal(status.changeName, "add-auth");
+	// Must be authoritative
+	assert.equal(isNonAuthoritativeStatus(status), false);
+	assert.equal(status.isNonAuthoritative, false);
+	// Must not be not_applicable — real disk scan ran
+	assert.notEqual(status.applyState, "not_applicable");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.artifacts.proposal, "done");
+});
+
+// Fix 4 item 3 — pure openspec store + change not found STILL blocks (guard against over-broadening Fix 2)
+test("resolveSddStatus with artifactStore openspec and change not found still blocks", async () => {
+	const cwd = await workspace();
+	// Create openspec dir with a different change — simulate openspec store with no matching change
+	mkdirSync(join(cwd, "openspec", "changes", "other-change"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "openspec", changeName: "nonexistent" });
+
+	// Must block, not return non-authoritative
+	assert.equal(status.isNonAuthoritative, false);
+	assert.match(status.blockedReasons.join("\n"), /Active change not found/);
+	assert.equal(status.applyState, "blocked");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+});
+
+test("renderSddDispatcherMarkdown for both-without-openspec does NOT render Ready", async () => {
+	const cwd = await workspace();
+	// No openspec directory — both store is non-authoritative
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "fix-x" });
+	const markdown = renderSddDispatcherMarkdown(status);
+
+	assert.doesNotMatch(markdown, /### Ready/);
+	assert.match(markdown, /resolve via Engram/i);
+});
+
+test("renderNativeSddPhasePrompt for both-without-openspec emits non-authoritative line", async () => {
+	const cwd = await workspace();
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "fix-x" });
+	const prompt = renderNativeSddPhasePrompt(status, "apply");
+
+	assert.match(prompt, /non-authoritative/);
+	assert.doesNotMatch(prompt, /deterministically/);
+});
+
+test("renderPhaseInstructions for not_applicable applyState emits neutral line", async () => {
+	const cwd = await workspace();
+
+	const status = resolveSddStatus({ cwd, artifactStore: "engram", changeName: "fix-x" });
+	const instructions = renderPhaseInstructions(status);
+
+	assert.match(instructions.apply.join("\n"), /Readiness is resolved from Engram/);
+	assert.match(instructions.archive.join("\n"), /Readiness is resolved from Engram/);
+});
+
+// Fix 4 item 1 — both + openspec/ + ZERO changes + no changeName → non-authoritative
+test("resolveSddStatus both + openspec/ dir + zero active changes + no changeName returns non-authoritative", async () => {
+	const cwd = await workspace();
+	// openspec/ dir exists but holds no active changes (only the changes/ subdir)
+	mkdirSync(join(cwd, "openspec", "changes"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both" });
+
+	assert.equal(status.isNonAuthoritative, true);
+	assert.equal(status.nextRecommended, "resolve-via-engram");
+	assert.deepEqual(status.blockedReasons, []);
+	assert.equal(status.artifactStore, "both");
+	assert.equal(status.applyState, "not_applicable");
+	assert.equal(status.dependencies.apply, "not_applicable");
+	assert.equal(status.dependencies.archive, "not_applicable");
+	// Must NOT be treated as blocked
+	assert.notEqual(status.applyState, "blocked");
+});
+
+// Fix 4 item 2 — both + openspec/ + MULTIPLE changes + no changeName → authoritative select-change
+test("resolveSddStatus both + openspec/ dir + multiple active changes + no changeName stays authoritative", async () => {
+	const cwd = await workspace();
+	mkdirSync(join(cwd, "openspec", "changes", "alpha"), { recursive: true });
+	mkdirSync(join(cwd, "openspec", "changes", "beta"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both" });
+
+	// Authoritative ambiguous-selection behavior must be preserved
+	assert.equal(status.isNonAuthoritative, false);
+	assert.match(status.blockedReasons.join("\n"), /ambiguous/);
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+});
+
+// Fix 4 item 3 — both + openspec/ + ONE resolvable change → authoritative
+test("resolveSddStatus both + openspec/ dir + exactly one active change is authoritative", async () => {
+	const cwd = await workspace();
+	seedChange(cwd);
+
+	// No changeName supplied — should auto-select the single change
+	const status = resolveSddStatus({ cwd, artifactStore: "both" });
+
+	assert.equal(status.isNonAuthoritative, false);
+	assert.equal(status.changeName, "add-auth");
+	assert.equal(status.artifactStore, "both");
+	assert.notEqual(status.applyState, "not_applicable");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+	assert.equal(status.artifacts.proposal, "done");
+});
+
+// Fix 4 item 4 — pure openspec + zero/missing change STILL blocks (guard against over-broadening)
+test("resolveSddStatus openspec + zero active changes still blocks", async () => {
+	const cwd = await workspace();
+	mkdirSync(join(cwd, "openspec", "changes"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "openspec" });
+
+	assert.equal(status.isNonAuthoritative, false);
+	assert.match(status.blockedReasons.join("\n"), /No active SDD changes/);
+	assert.equal(status.applyState, "blocked");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+});
+
+test("resolveSddStatus openspec + named change missing still blocks", async () => {
+	const cwd = await workspace();
+	mkdirSync(join(cwd, "openspec", "changes", "other-change"), { recursive: true });
+
+	const status = resolveSddStatus({ cwd, artifactStore: "openspec", changeName: "nonexistent" });
+
+	assert.equal(status.isNonAuthoritative, false);
+	assert.match(status.blockedReasons.join("\n"), /Active change not found/);
+	assert.equal(status.applyState, "blocked");
+	assert.notEqual(status.nextRecommended, "resolve-via-engram");
+});
+
+// Fix 4 render test — non-authoritative both status → dispatcher shows "both" not "Engram or none"
+test("renderSddDispatcherMarkdown for non-authoritative both status shows artifact store 'both'", async () => {
+	const cwd = await workspace();
+
+	const status = resolveSddStatus({ cwd, artifactStore: "both", changeName: "fix-x" });
+	const markdown = renderSddDispatcherMarkdown(status);
+
+	assert.match(markdown, /artifact store: both/);
+	assert.doesNotMatch(markdown, /Engram or none/);
+	assert.match(markdown, /resolve via Engram/i);
+});