gentle-pi 0.3.9 → 0.4.0

package/tests/skill-registry.test.ts

@@ -3,6 +3,7 @@ import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { dirname, join } from "node:path";
 import test from "node:test";
+import { pathToFileURL } from "node:url";
 import { __testing } from "../extensions/skill-registry.ts";
 
 test("project skill dirs include supported workspace roots", () => {
@@ -13,6 +14,7 @@ test("project skill dirs include supported workspace roots", () => {
 		".opencode/skills",
 		".claude/skills",
 		".gemini/skills",
+		".trae/skills",
 		".cursor/skills",
 		".github/skills",
 		".codex/skills",
@@ -49,6 +51,17 @@ test("registry renders indexed skill paths instead of compact rules", () => {
 	assert.doesNotMatch(registry, /Rules:/);
 });
 
+test("frontmatter parser accepts CRLF line endings", () => {
+	const parsed = __testing.parseFrontmatter("---\r\nname: windows-skill\r\ndescription: >\r\n  Trigger: Windows-authored skills.\r\n  Preserve frontmatter metadata.\r\n---\r\n\r\n## Body\r\n");
+
+	assert.equal(parsed.name, "windows-skill");
+	assert.equal(
+		parsed.description,
+		"Trigger: Windows-authored skills. Preserve frontmatter metadata.",
+	);
+	assert.match(parsed.body, /## Body/);
+});
+
 test("frontmatter parser keeps full multiline descriptions", () => {
 	const parsed = __testing.parseFrontmatter(`---
 name: ai-sdk-5
@@ -101,6 +114,26 @@ test("uniqueExistingDirs normalizes duplicates and ignores missing roots", async
 	);
 });
 
+test("skill registry watchers close on shutdown", async () => {
+	const root = join(tmpdir(), `gentle-pi-watchers-${Date.now()}`);
+	const skillPath = join(root, "skills", "docs", "SKILL.md");
+	mkdirSync(dirname(skillPath), { recursive: true });
+	writeFileSync(skillPath, "---\nname: docs\ndescription: Docs.\n---\n");
+
+	await __testing.startSkillRegistryWatcher(root, () => undefined);
+	const attempted = __testing.activeWatcherCount();
+	__testing.closeSkillRegistryWatchers();
+	assert.equal(__testing.activeWatcherCount(), 0);
+
+	await __testing.startSkillRegistryWatcher(root, () => undefined);
+	assert.equal(
+		__testing.activeWatcherCount(),
+		attempted,
+		"shutdown must clear watched cwd state so a later session can re-watch",
+	);
+	__testing.closeSkillRegistryWatchers();
+});
+
 test("startup skip honors no skill registry controls", () => {
 	const enabled = { getFlag: () => true };
 	const disabled = { getFlag: () => false };
@@ -115,6 +148,43 @@ test("startup skip honors no skill registry controls", () => {
 	assert.equal(__testing.shouldSkipSkillRegistryStartup(disabled, [], {}), false);
 });
 
+test("duplicate extension load is skipped only across different sources", () => {
+	const state = {};
+
+	assert.equal(
+		__testing.shouldSkipDuplicateExtensionLoad("file:///repo/extensions/skill-registry.ts?first", "/workspace", state),
+		false,
+	);
+	assert.equal(
+		__testing.shouldSkipDuplicateExtensionLoad("file:///repo/extensions/skill-registry.ts?second", "/workspace", state),
+		false,
+	);
+	assert.equal(
+		__testing.shouldSkipDuplicateExtensionLoad("file:///home/.pi/node_modules/gentle-pi/extensions/skill-registry.ts", "/workspace", state),
+		true,
+	);
+});
+
+test("project-local skill registry extension wins over installed package copy", () => {
+	const cwd = join(tmpdir(), `gentle-pi-local-extension-${Date.now()}`);
+	const localExtension = join(cwd, "extensions", "skill-registry.ts");
+	mkdirSync(dirname(localExtension), { recursive: true });
+	writeFileSync(localExtension, "");
+
+	assert.equal(
+		__testing.shouldSkipDuplicateExtensionLoad(
+			"file:///home/.pi/agent/npm/node_modules/gentle-pi/extensions/skill-registry.ts",
+			cwd,
+			{},
+		),
+		true,
+	);
+	assert.equal(
+		__testing.shouldSkipDuplicateExtensionLoad(pathToFileURL(localExtension).href, cwd, {}),
+		false,
+	);
+});
+
 test("scope and markdown cells are represented in registry", () => {
 	const cwd = join(tmpdir(), `gentle-pi-scope-${Date.now()}`);
 	const projectPath = join(cwd, "skills", "docs", "SKILL.md");