gentle-pi 0.3.6 → 0.3.8

package/README.md

@@ -462,12 +462,17 @@ node --experimental-strip-types --check extensions/startup-banner.ts
 npm pack --dry-run
 ```
 
-Publish:
+Publish npm through GitHub Actions only:
 
 ```bash
-npm publish
+gh workflow run publish.yml --repo Gentleman-Programming/gentle-pi --ref main -f dist-tag=latest
+gh run watch <run-id> --repo Gentleman-Programming/gentle-pi --exit-status
+npm view gentle-pi@<version> version --registry=https://registry.npmjs.org/
+npm dist-tag ls gentle-pi --registry=https://registry.npmjs.org/
 ```
 
+Do not run `npm publish` locally for `gentle-pi`; the GitHub workflow provides provenance, environment protection, and registry credentials.
+
 ## Principles
 
 - Human control over agent momentum.

package/assets/orchestrator.md

@@ -6,16 +6,16 @@ Bind this to the parent Pi session only. Do not apply it to SDD executor phase a
 
 You are el Gentleman: a Pi-specific coding-agent harness for controlled development work.
 
-When the user asks who or what you are, answer in this shape:
+When the user asks who or what you are, answer with this meaning, translated into the user's language:
 
 ```text
-Soy el Gentleman: un harness específico de Pi para desarrollo controlado, con persona de arquitecto senior. Trabajo con SDD/OpenSpec cuando la tarea lo justifica, coordino subagentes, uso artifacts de fase, corro comandos y edito archivos. No soy un chatbot genérico.
+I am el Gentleman: a Pi-specific coding-agent harness for controlled development, with a senior architect persona. I work with SDD/OpenSpec when the task justifies it, coordinate subagents, use phase artifacts, run commands, and edit files. I am not a generic chatbot.
 ```
 
 Rules:
 
 - Never introduce yourself as only "your assistant" or "the default assistant".
-- Keep the response in the user's language; in Spanish, use natural Rioplatense voseo.
+- Keep the response in the user's language and follow the currently selected persona mode.
 - Mention persistent memory only when a memory package or callable memory tools are actually active.
 - Do not claim portability outside the Pi runtime.
 
@@ -45,7 +45,7 @@ el Gentleman is an ecosystem configurator and harness layer. After installation,
 
 - Small request: do it directly.
 - Substantial feature: suggest SDD organically.
-- User says "use sdd" / "hacelo con sdd": run the SDD flow.
+- User explicitly asks to use SDD: run the SDD flow.
 - Parent session orchestrates; phase agents execute.
 
 Delegation is not optional once complexity appears. If a task crosses the triggers below, use the smallest useful subagent workflow instead of continuing as a monolithic executor.
@@ -101,7 +101,7 @@ Triggers:
 - cross-cutting behavior changes;
 - expected large diff or reviewer burden;
 - need for specs/design/tasks before safe implementation;
-- user explicitly says `use sdd`, `hacelo con sdd`, `/sdd-new`, `/sdd-ff`, or `/sdd-continue`.
+- user explicitly asks to use SDD, or invokes `/sdd-new`, `/sdd-ff`, or `/sdd-continue`.
 
 If the request is large enough for SDD, do not jump directly to implementation. Calibrate context, create artifacts, and ask for approval at the appropriate gates.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gentle-pi",
-  "version": "0.3.6",
+  "version": "0.3.8",
   "description": "Turn Pi into el Gentleman: a senior-architect development harness with SDD/OpenSpec, subagents, strict TDD evidence, review guardrails, and skill discovery.",
   "license": "MIT",
   "type": "module",

package/skills/release/SKILL.md

@@ -0,0 +1,108 @@
+---
+name: release
+description: "Release gentle-pi through GitHub and npm. Trigger: release, publish, npm publish, GitHub release, version bump."
+license: Apache-2.0
+metadata:
+  author: gentleman-programming
+  version: "1.0"
+---
+
+## When to Use
+
+Use this skill when preparing, publishing, or verifying a `gentle-pi` release.
+
+## Hard Rules
+
+- Do not publish `gentle-pi` to npm from a local machine.
+- npm publishing MUST go through the GitHub Actions workflow `.github/workflows/publish.yml` so provenance, environment protection, and registry credentials are controlled by GitHub.
+- Use a clean worktree for release commits. Do not package unrelated local files or scratch artifacts.
+- Run a fresh review before pushing a code release unless the change is trivial docs-only.
+- Never skip package verification. The publish workflow runs verification again, but local validation should still pass before tagging.
+
+## Release Procedure
+
+1. **Inspect state**
+
+   ```bash
+   git status --short
+   git fetch origin main --tags
+   git log --oneline --decorate --max-count=5 origin/main
+   ```
+
+2. **Prepare the release commit**
+
+   - Apply only intended changes.
+   - Bump `package.json` to the next semver version.
+   - Keep lockfile changes out unless dependency resolution actually changed.
+
+3. **Verify locally**
+
+   ```bash
+   pnpm test
+   pnpm publish --dry-run --no-git-checks
+   ```
+
+   The dry run is allowed because it does not publish. It verifies package contents and lifecycle scripts.
+
+4. **Commit and push**
+
+   ```bash
+   git add <intended-files>
+   git commit -m "<type(scope): release-ready change>"
+   git push origin HEAD:main
+   ```
+
+5. **Create the GitHub release**
+
+   ```bash
+   git tag -a v<version> -m "gentle-pi v<version>"
+   git push origin v<version>
+   gh release create v<version> \
+     --repo Gentleman-Programming/gentle-pi \
+     --title "gentle-pi v<version>" \
+     --notes "<release notes>"
+   ```
+
+6. **Publish npm through GitHub Actions**
+
+   ```bash
+   gh workflow run publish.yml \
+     --repo Gentleman-Programming/gentle-pi \
+     --ref main \
+     -f dist-tag=latest
+   ```
+
+   Watch the run and fail the release if it fails:
+
+   ```bash
+   gh run list --repo Gentleman-Programming/gentle-pi --workflow publish.yml --limit 3
+   gh run watch <run-id> --repo Gentleman-Programming/gentle-pi --exit-status
+   ```
+
+7. **Verify npm**
+
+   ```bash
+   npm view gentle-pi@<version> version --registry=https://registry.npmjs.org/
+   npm dist-tag ls gentle-pi --registry=https://registry.npmjs.org/
+   ```
+
+## Failure Handling
+
+- If a local `npm publish` fails, do not retry locally. Use the GitHub workflow instead.
+- If the workflow fails, inspect logs with:
+
+  ```bash
+  gh run view <run-id> --repo Gentleman-Programming/gentle-pi --log
+  ```
+
+- If npm verification is briefly stale after a successful workflow, check the exact version first (`npm view gentle-pi@<version> version`) before assuming publish failed.
+
+## Output Contract
+
+Report:
+
+- Commit SHA pushed to `main`.
+- GitHub release URL.
+- Publish workflow run URL and conclusion.
+- npm exact version and `latest` dist-tag.
+- Any remaining follow-up or warnings.

package/tests/artifact-language.test.ts

@@ -0,0 +1,91 @@
+import assert from "node:assert/strict";
+import { readdir, readFile } from "node:fs/promises";
+import { dirname, extname, join, relative } from "node:path";
+import test from "node:test";
+import { fileURLToPath } from "node:url";
+import {
+	renderSddPreflightPrompt,
+	type SddPreflightPreferences,
+} from "../lib/sdd-preflight.ts";
+
+const ROOT = dirname(dirname(fileURLToPath(import.meta.url)));
+const TEXT_EXTENSIONS = new Set([".md", ".ts", ".mjs", ".json"]);
+
+async function collectTextFiles(dir: string): Promise<string[]> {
+	const entries = await readdir(dir, { withFileTypes: true });
+	const files: string[] = [];
+	for (const entry of entries) {
+		const path = join(dir, entry.name);
+		if (entry.isDirectory()) {
+			files.push(...(await collectTextFiles(path)));
+			continue;
+		}
+		if (entry.isFile() && TEXT_EXTENSIONS.has(extname(entry.name))) {
+			files.push(path);
+		}
+	}
+	return files;
+}
+
+const SPANISH_PREFLIGHT_COPY = [
+	/Antes de continuar con SDD/i,
+	/Antes de seguir con SDD/i,
+	/una opci[oó]n por grupo/i,
+	/usar recomendad[oa]/i,
+	/\bRitmo\b/i,
+	/\bArtefactos\b/i,
+	/\bPreguntarme\b/i,
+	/l[ií]neas cambiadas/i,
+	/\bhacelo\b/i,
+	/\bSoy el Gentleman\b/i,
+];
+
+test("orchestrator keeps conversation language separate from generated artifact language", async () => {
+	const orchestrator = await readFile(join(ROOT, "assets/orchestrator.md"), "utf8");
+
+	assert.match(
+		orchestrator,
+		/User-facing conversation should stay in the user's language/,
+	);
+	assert.match(
+		orchestrator,
+		/Generated artifacts[\s\S]*default to English, regardless of the user's conversation language/,
+	);
+});
+
+test("rendered SDD preflight prompt is English artifact copy", () => {
+	const prefs: SddPreflightPreferences = {
+		executionMode: "interactive",
+		artifactStore: "openspec",
+		chainedPrStrategy: "ask-always",
+		reviewBudgetLines: 400,
+		engramAvailable: false,
+		prompted: true,
+	};
+	const prompt = renderSddPreflightPrompt(prefs);
+
+	assert.match(prompt, /The user already chose these SDD preferences/);
+	assert.match(prompt, /Review budget: 400 changed lines/);
+	for (const pattern of SPANISH_PREFLIGHT_COPY) {
+		assert.doesNotMatch(prompt, pattern);
+	}
+});
+
+test("persistent harness prompt assets do not hardcode Spanish SDD artifact copy", async () => {
+	const files = [
+		...(await collectTextFiles(join(ROOT, "assets"))),
+		...(await collectTextFiles(join(ROOT, "prompts"))),
+	];
+	const failures: string[] = [];
+
+	for (const file of files) {
+		const text = await readFile(file, "utf8");
+		for (const pattern of SPANISH_PREFLIGHT_COPY) {
+			if (pattern.test(text)) {
+				failures.push(`${relative(ROOT, file)} matched ${pattern}`);
+			}
+		}
+	}
+
+	assert.deepEqual(failures, []);
+});

package/tests/runtime-harness.mjs

@@ -179,6 +179,18 @@ async function run() {
 		assert.match(promptResult.systemPrompt, /el Gentleman/);
 		assert.match(promptResult.systemPrompt, /openspec\/config\.yaml.*not session preflight/s);
 		assert.match(promptResult.systemPrompt, /Do not mark SDD preflight complete/);
+		await mkdir(join(promptCwd, ".pi", "gentle-ai"), { recursive: true });
+		await writeFile(
+			join(promptCwd, ".pi", "gentle-ai", "persona.json"),
+			'{"mode":"neutral"}\n',
+		);
+		const neutralPromptResult = await promptHook({ systemPrompt: "base" }, createCtx(promptCwd));
+		assert.match(neutralPromptResult.systemPrompt, /Do not use slang or regional expressions/);
+		assert.doesNotMatch(
+			neutralPromptResult.systemPrompt,
+			/When the user writes Spanish, answer in natural Rioplatense Spanish with voseo/,
+			"neutral persona prompt must not include unconditional voseo instructions after reload",
+		);
 		const subagentPromptResult = await promptHook(
 			{ agentName: "worker", systemPrompt: "worker base" },
 			createCtx(promptCwd),