gentle-pi 0.3.10 → 0.4.1

package/extensions/skill-registry.ts

@@ -1,5 +1,5 @@
 import { createHash } from "node:crypto";
-import { existsSync, watch } from "node:fs";
+import { existsSync, type FSWatcher, watch } from "node:fs";
 import {
 	access,
 	mkdir,
@@ -29,6 +29,7 @@ const LEGACY_PROJECT_REGISTRY_DISABLED_REL_PATH =
 	".pi/extensions/skill-registry.ts.disabled";
 const SKILL_REGISTRY_EXTENSION_SOURCE_KEY =
 	"__gentlePiSkillRegistryExtensionSource";
+const activeWatchers = new Set<FSWatcher>();
 
 interface SkillRegistryExtensionGlobal {
 	[SKILL_REGISTRY_EXTENSION_SOURCE_KEY]?: string;
@@ -62,6 +63,7 @@ function userSkillDirs(): string[] {
 		join(home, ".claude/skills"),
 		join(home, ".gemini/skills"),
 		join(home, ".gemini/antigravity/skills"),
+		join(home, ".trae/skills"),
 		join(home, ".cursor/skills"),
 		join(home, ".copilot/skills"),
 		join(home, ".codex/skills"),
@@ -78,6 +80,7 @@ function projectSkillDirs(cwd: string): string[] {
 		join(cwd, ".opencode/skills"),
 		join(cwd, ".claude/skills"),
 		join(cwd, ".gemini/skills"),
+		join(cwd, ".trae/skills"),
 		join(cwd, ".cursor/skills"),
 		join(cwd, ".github/skills"),
 		join(cwd, ".codex/skills"),
@@ -116,11 +119,12 @@ async function findSkillFiles(root: string): Promise<string[]> {
 }
 
 function parseFrontmatter(source: string): { name?: string; description?: string; body: string } {
-	if (!source.startsWith("---\n")) return { body: source };
-	const end = source.indexOf("\n---", 4);
-	if (end === -1) return { body: source };
-	const fm = source.slice(4, end);
-	const body = source.slice(end + 4).replace(/^\n/, "");
+	const normalized = source.replace(/\r\n?/g, "\n");
+	if (!normalized.startsWith("---\n")) return { body: normalized };
+	const end = normalized.indexOf("\n---", 4);
+	if (end === -1) return { body: normalized };
+	const fm = normalized.slice(4, end);
+	const body = normalized.slice(end + 4).replace(/^\n/, "");
 	const out: { name?: string; description?: string } = {};
 	const lines = fm.split("\n");
 	for (let i = 0; i < lines.length; i++) {
@@ -457,6 +461,18 @@ function shouldSkipDuplicateExtensionLoad(
 	return existingSource !== currentSource;
 }
 
+function closeSkillRegistryWatchers(): void {
+	for (const watcher of activeWatchers) {
+		try {
+			watcher.close();
+		} catch {
+			// Best-effort shutdown; stale handles must not block process exit.
+		}
+	}
+	activeWatchers.clear();
+	watchedCwds.clear();
+}
+
 async function startSkillRegistryWatcher(
 	cwd: string,
 	notify: (message: string) => void,
@@ -485,7 +501,8 @@ async function startSkillRegistryWatcher(
 	};
 	for (const dir of dirs) {
 		try {
-			watch(dir, { recursive: true }, refresh);
+			const watcher = watch(dir, { recursive: true }, refresh);
+			activeWatchers.add(watcher);
 		} catch {
 			// Some filesystems do not support recursive watches; session_start/manual refresh still work.
 		}
@@ -503,11 +520,20 @@ export const __testing = {
 	renderRegistry,
 	shouldSkipSkillRegistryStartup,
 	shouldSkipDuplicateExtensionLoad,
+	startSkillRegistryWatcher,
+	closeSkillRegistryWatchers,
+	activeWatcherCount() {
+		return activeWatchers.size;
+	},
 };
 
 export default function (pi: ExtensionAPI) {
 	if (shouldSkipDuplicateExtensionLoad()) return;
 
+	pi.on("session_shutdown", () => {
+		closeSkillRegistryWatchers();
+	});
+
 	pi.registerFlag(NO_SKILL_REGISTRY_FLAG, {
 		description: "Skip the Gentle AI skill registry refresh and watcher on startup.",
 		type: "boolean",
@@ -532,9 +558,11 @@ export default function (pi: ExtensionAPI) {
 					"warning",
 				);
 			}
-			await startSkillRegistryWatcher(ctx.cwd, (message) => {
-				if (ctx.hasUI) ctx.ui.notify(message, "info");
-			});
+			if (ctx.hasUI) {
+				await startSkillRegistryWatcher(ctx.cwd, (message) => {
+					ctx.ui.notify(message, "info");
+				});
+			}
 			if (quarantinedLegacy) {
 				setTimeout(() => {
 					void (async () => {

package/extensions/startup-banner.ts

@@ -4,10 +4,31 @@ import { truncateToWidth } from "@earendil-works/pi-tui";
 import * as os from "node:os";
 import { exec } from "node:child_process";
 import { promisify } from "node:util";
-import { readFile } from "node:fs/promises";
+import { mkdir, readFile, readdir, writeFile } from "node:fs/promises";
 import { join } from "node:path";
 
 const execAsync = promisify(exec);
+const PI_AGENT_DIR = join(os.homedir(), ".pi", "agent");
+const PI_NPM_DIR = join(PI_AGENT_DIR, "npm", "node_modules");
+
+type BannerColor = "pink" | "cyan" | "yellow" | "green";
+interface BannerConfig {
+  showRose: boolean;
+  showTextLogo: boolean;
+  color: BannerColor;
+}
+const DEFAULT_BANNER_CONFIG: BannerConfig = {
+  showRose: true,
+  showTextLogo: true,
+  color: "pink",
+};
+const BANNER_COLORS: BannerColor[] = ["pink", "cyan", "yellow", "green"];
+const BANNER_PALETTES: Record<BannerColor, { rose: [number, number, number]; label: [number, number, number]; value: [number, number, number]; logoFresh: [number, number, number]; logoDim: [number, number, number] }> = {
+  pink: { rose: [255, 118, 195], label: [200, 100, 160], value: [255, 140, 210], logoFresh: [255, 138, 206], logoDim: [95, 30, 60] },
+  cyan: { rose: [95, 210, 255], label: [85, 170, 205], value: [130, 225, 255], logoFresh: [105, 220, 255], logoDim: [25, 80, 100] },
+  yellow: { rose: [255, 210, 95], label: [210, 165, 65], value: [255, 225, 135], logoFresh: [255, 215, 105], logoDim: [105, 75, 25] },
+  green: { rose: [110, 220, 145], label: [85, 175, 115], value: [145, 240, 170], logoFresh: [120, 230, 150], logoDim: [30, 95, 50] },
+};
 
 const TEXT_LOGO = [
   "                  ▄▄▄▀▀▀▀▀██                                ▄▄▀▄▄           ▄▄█▀▀▀██   ▀▀█▄    ▄▄▄",
@@ -47,6 +68,43 @@ function rgb(r: number, g: number, b: number, text: string): string {
   return `\x1b[38;2;${r};${g};${b}m${text}\x1b[39m`;
 }
 
+function gentleAiConfigHome(): string {
+  return process.env.GENTLE_PI_CONFIG_HOME ?? join(os.homedir(), ".pi", "gentle-ai");
+}
+
+function bannerConfigPath(): string {
+  return join(gentleAiConfigHome(), "banner.json");
+}
+
+function normalizeBannerConfig(value: unknown): BannerConfig {
+  if (typeof value !== "object" || value === null || Array.isArray(value)) return { ...DEFAULT_BANNER_CONFIG };
+  const record = value as Record<string, unknown>;
+  return {
+    showRose: typeof record.showRose === "boolean" ? record.showRose : DEFAULT_BANNER_CONFIG.showRose,
+    showTextLogo: typeof record.showTextLogo === "boolean" ? record.showTextLogo : DEFAULT_BANNER_CONFIG.showTextLogo,
+    color: BANNER_COLORS.includes(record.color as BannerColor) ? record.color as BannerColor : DEFAULT_BANNER_CONFIG.color,
+  };
+}
+
+async function readBannerConfig(): Promise<BannerConfig> {
+  try {
+    return normalizeBannerConfig(JSON.parse(await readFile(bannerConfigPath(), "utf8")));
+  } catch {
+    return { ...DEFAULT_BANNER_CONFIG };
+  }
+}
+
+async function writeBannerConfig(config: BannerConfig): Promise<void> {
+  const path = bannerConfigPath();
+  await mkdir(join(path, ".."), { recursive: true });
+  await writeFile(path, `${JSON.stringify(config, null, 2)}\n`, "utf8");
+}
+
+function paletteColor(color: BannerColor, key: keyof typeof BANNER_PALETTES[BannerColor], text: string): string {
+  const [r, g, b] = BANNER_PALETTES[color][key];
+  return rgb(r, g, b, text);
+}
+
 function normalizeAscii(lines: string[]): string[] {
   const trimmed = lines.map((l) => l.replace(/\s+$/g, ""));
   const nonEmpty = trimmed.filter((l) => l.trim().length > 0);
@@ -433,7 +491,107 @@ function currentIntroMode(): IntroMode {
   return pickIntroMode(rows, cols);
 }
 
+async function countSddAgents(): Promise<number> {
+  try {
+    const entries = await readdir(join(PI_AGENT_DIR, "agents"), { withFileTypes: true });
+    return entries.filter((entry) => entry.isFile() && /^sdd-.*\.md$/.test(entry.name)).length;
+  } catch {
+    return 0;
+  }
+}
+
+function packageNameFromSpec(spec: unknown): string | undefined {
+  if (typeof spec !== "string") return undefined;
+  const clean = spec.replace(/^npm:/, "");
+  if (clean.startsWith("@")) {
+    const parts = clean.split("@");
+    return parts.length > 2 ? `@${parts[1]}` : clean;
+  }
+  return clean.split("@")[0] || undefined;
+}
+
+async function countPackageExtensions(packages: unknown[]): Promise<number> {
+  let count = 0;
+  for (const spec of packages) {
+    const name = packageNameFromSpec(spec);
+    if (!name) continue;
+    try {
+      const raw = await readFile(join(PI_NPM_DIR, name, "package.json"), "utf8");
+      const pkg = JSON.parse(raw);
+      const extensions = pkg?.pi?.extensions;
+      if (Array.isArray(extensions)) count += extensions.length;
+    } catch {
+      // Packages installed from non-npm sources may not live in PI_NPM_DIR.
+    }
+  }
+  return count;
+}
+
 export default function (pi: ExtensionAPI) {
+  const notifyBannerConfig = (ctx: any, config: BannerConfig) => {
+    ctx.ui.notify(
+      [
+        `Startup banner: rose=${config.showRose ? "on" : "off"}, text logo=${config.showTextLogo ? "on" : "off"}, color=${config.color}`,
+        `Config: ${bannerConfigPath()}`,
+        "Changes apply on the next startup banner render.",
+      ].join("\n"),
+      "info",
+    );
+  };
+
+  const registerBannerCommand = (name: string) => {
+    pi.registerCommand(name, {
+      description: "Configure the Gentle Pi startup banner.",
+      handler: async (_args, ctx) => {
+        const config = await readBannerConfig();
+        const selected = await ctx.ui.select("Startup banner", [
+          `Rose: ${config.showRose ? "on" : "off"}`,
+          `Text logo: ${config.showTextLogo ? "on" : "off"}`,
+          `Color: ${config.color}`,
+        ]);
+        if (!selected) return;
+        if (selected.startsWith("Rose:")) config.showRose = !config.showRose;
+        else if (selected.startsWith("Text logo:")) config.showTextLogo = !config.showTextLogo;
+        else if (selected.startsWith("Color:")) {
+          config.color = await ctx.ui.select("Startup banner color", [...BANNER_COLORS]) as BannerColor;
+        }
+        await writeBannerConfig(config);
+        notifyBannerConfig(ctx, config);
+      },
+    });
+  };
+  const registerToggleCommand = (name: string, key: "showRose" | "showTextLogo") => {
+    pi.registerCommand(name, {
+      description: `Toggle startup banner ${key === "showRose" ? "rose" : "text logo"}.`,
+      handler: async (_args, ctx) => {
+        const config = await readBannerConfig();
+        config[key] = !config[key];
+        await writeBannerConfig(config);
+        notifyBannerConfig(ctx, config);
+      },
+    });
+  };
+  const registerColorCommand = (name: string) => {
+    pi.registerCommand(name, {
+      description: "Set startup banner color preset.",
+      handler: async (args, ctx) => {
+        const config = await readBannerConfig();
+        const requested = String(args ?? "").trim() as BannerColor;
+        config.color = BANNER_COLORS.includes(requested)
+          ? requested
+          : await ctx.ui.select("Startup banner color", [...BANNER_COLORS]) as BannerColor;
+        await writeBannerConfig(config);
+        notifyBannerConfig(ctx, config);
+      },
+    });
+  };
+  for (const prefix of ["gentle", "gentle-ai"] as const) {
+    registerBannerCommand(`${prefix}:banner`);
+    registerToggleCommand(`${prefix}:toggle-rose`, "showRose");
+    registerToggleCommand(`${prefix}:toggle-text-logo`, "showTextLogo");
+    registerColorCommand(`${prefix}:banner-color`);
+  }
+
   pi.on("session_start", async (_event, ctx) => {
     if (!ctx.hasUI) return;
 
@@ -451,6 +609,8 @@ export default function (pi: ExtensionAPI) {
 
     process.stdout.write("\x1b[2J\x1b[3J\x1b[H");
 
+    const bannerConfig = await readBannerConfig();
+    const palette = BANNER_PALETTES[bannerConfig.color];
     const roseBase = padLines(normalizeAscii(ROSE_LARGE_RAW));
     const logoBase = padLines(TEXT_LOGO);
 
@@ -458,6 +618,7 @@ export default function (pi: ExtensionAPI) {
     let mcpServersCount = 0;
     let extensionsCount = 0;
     let packagesCount = 0;
+    let sddAgentsCount = 0;
 
     const allCommands = pi.getCommands();
     const skills = allCommands.filter((c) => c.source === "skill");
@@ -493,15 +654,15 @@ export default function (pi: ExtensionAPI) {
     setTimeout(() => {
       (async () => {
         try {
+          sddAgentsCount = await countSddAgents();
           const raw = await readFile(
-            join(os.homedir(), ".pi", "agent", "settings.json"),
+            join(PI_AGENT_DIR, "settings.json"),
             "utf8",
           );
           const cfg = JSON.parse(raw);
-          extensionsCount = Array.isArray(cfg.extensions)
-            ? cfg.extensions.length
-            : 0;
-          packagesCount = Array.isArray(cfg.packages) ? cfg.packages.length : 0;
+          const packages = Array.isArray(cfg.packages) ? cfg.packages : [];
+          packagesCount = packages.length;
+          extensionsCount = await countPackageExtensions(packages);
         } catch {
           extensionsCount = 0;
           packagesCount = 0;
@@ -595,7 +756,7 @@ export default function (pi: ExtensionAPI) {
             const sideBySideMinWidth = roseBase.width + 3 + logoBase.width + 4;
             const wideStatsMinWidth = 122;
             const horizontal =
-              state.mode === "full" && width >= sideBySideMinWidth;
+              state.mode === "full" && bannerConfig.showRose && bannerConfig.showTextLogo && width >= sideBySideMinWidth;
             const wideStats = width >= wideStatsMinWidth;
 
             const b = new LayoutBuilder();
@@ -603,7 +764,7 @@ export default function (pi: ExtensionAPI) {
             b.center(width);
 
             if (state.mode === "minimal") {
-              for (let logoI = 0; logoI < logoBase.lines.length; logoI++) {
+              if (bannerConfig.showTextLogo) for (let logoI = 0; logoI < logoBase.lines.length; logoI++) {
                 const logoLine = logoBase.lines[logoI];
                 b.addRow();
                 b.lines[b.lines.length - 1].push(
@@ -660,8 +821,8 @@ export default function (pi: ExtensionAPI) {
                 b.center(width);
               }
             } else {
-              const showBanner = width >= logoBase.width + 2;
-              const showRose = width >= roseBase.width + 2;
+              const showBanner = bannerConfig.showTextLogo && width >= logoBase.width + 2;
+              const showRose = bannerConfig.showRose && width >= roseBase.width + 2;
               if (showBanner) {
                 for (let logoI = 0; logoI < logoBase.lines.length; logoI++) {
                   const logoLine = logoBase.lines[logoI];
@@ -690,7 +851,7 @@ export default function (pi: ExtensionAPI) {
               }
             }
 
-            if (state.mode === "full") {
+            if (state.mode === "full" || (!bannerConfig.showRose && !bannerConfig.showTextLogo)) {
               b.addRow();
               b.center(width);
 
@@ -720,8 +881,9 @@ export default function (pi: ExtensionAPI) {
                 ["GIT:", gitBranch],
                 ["PATH:", ctx.cwd],
                 ["MCP:", `${mcpServersCount} server(s)`],
+                ["AGENTS:", `${sddAgentsCount} phases`],
                 ["PLUGINS:", `${packagesCount} package(s)`],
-                ["AGENTS:", `${skills.length} loaded`],
+                ["SKILLS:", `${skills.length} loaded`],
                 ["EXTENSIONS:", `${extensionsCount} active`],
                 ["VER:", `v${VERSION}`],
                 ["TOOLS:", `${customTools.length} custom`],
@@ -752,22 +914,24 @@ export default function (pi: ExtensionAPI) {
                 );
                 addWideRow(
                   "AGENTS:",
-                  `${skills.length} loaded`,
+                  `${sddAgentsCount} phases`,
                   "EXTENSIONS:",
                   `${extensionsCount} active`,
                 );
                 addWideRow(
-                  "VER:",
-                  `v${VERSION}`,
+                  "SKILLS:",
+                  `${skills.length} loaded`,
                   "TOOLS:",
                   `${customTools.length} custom`,
                 );
+                addWideRow("VER:", `v${VERSION}`, "", "");
               } else {
                 addNarrowRow("GIT:", gitBranch);
                 addNarrowRow("PATH:", ctx.cwd);
                 addNarrowRow("MCP:", `${mcpServersCount} server(s)`);
                 addNarrowRow("PLUGINS:", `${packagesCount} package(s)`);
-                addNarrowRow("AGENTS:", `${skills.length} loaded`);
+                addNarrowRow("AGENTS:", `${sddAgentsCount} phases`);
+                addNarrowRow("SKILLS:", `${skills.length} loaded`);
                 addNarrowRow("EXTENSIONS:", `${extensionsCount} active`);
                 addNarrowRow("VER:", `v${VERSION}`);
                 addNarrowRow("TOOLS:", `${customTools.length} custom`);
@@ -834,9 +998,9 @@ export default function (pi: ExtensionAPI) {
                   const k = Math.max(0.01, roseOpacity * pulse);
                   const f = flashPhase ** 0.4;
 
-                  const rBase = Math.floor(255 * k);
-                  const gBase = Math.floor(118 * k);
-                  const bBase = Math.floor(195 * k);
+                  const rBase = Math.floor(palette.rose[0] * k);
+                  const gBase = Math.floor(palette.rose[1] * k);
+                  const bBase = Math.floor(palette.rose[2] * k);
 
                   if (f > 0.85) {
                     line += `\x1b[1m\x1b[38;2;255;255;255m${cell.char}\x1b[0m`;
@@ -874,22 +1038,22 @@ export default function (pi: ExtensionAPI) {
                     line += `\x1b[1m` + rgb(255, 205, 238, cell.char) + `\x1b[22m`;
                   } else if (cell.type === "logo-fresh") {
                     line += cell.char === "▒"
-                      ? rgb(110, 36, 70, cell.char)
-                      : rgb(255, 138, 206, cell.char);
+                      ? paletteColor(bannerConfig.color, "logoDim", cell.char)
+                      : paletteColor(bannerConfig.color, "logoFresh", cell.char);
                   } else {
                     line += cell.char === "▒"
-                      ? rgb(95, 30, 60, cell.char)
-                      : rgb(255, 120, 198, cell.char);
+                      ? paletteColor(bannerConfig.color, "logoDim", cell.char)
+                      : paletteColor(bannerConfig.color, "value", cell.char);
                   }
                   continue;
                 }
 
                 switch (cell.type) {
                   case "label":
-                    line += rgb(200, 100, 160, cell.char);
+                    line += paletteColor(bannerConfig.color, "label", cell.char);
                     break;
                   case "value":
-                    line += rgb(255, 140, 210, cell.char);
+                    line += paletteColor(bannerConfig.color, "value", cell.char);
                     break;
                   case "dim":
                     line += theme.fg("dim", cell.char);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gentle-pi",
-  "version": "0.3.10",
+  "version": "0.4.1",
   "description": "Turn Pi into el Gentleman: a senior-architect development harness with SDD/OpenSpec, subagents, strict TDD evidence, review guardrails, and skill discovery.",
   "license": "MIT",
   "type": "module",

package/scripts/verify-package-files.mjs

@@ -6,11 +6,13 @@ import { fileURLToPath } from "node:url";
 const root = join(fileURLToPath(new URL("..", import.meta.url)));
 
 const requiredPaths = [
+  "assets/orchestrator.md",
   "assets/agents/sdd-apply.md",
   "assets/agents/sdd-archive.md",
   "assets/agents/sdd-design.md",
   "assets/agents/sdd-explore.md",
   "assets/agents/sdd-init.md",
+  "assets/agents/sdd-onboard.md",
   "assets/agents/sdd-proposal.md",
   "assets/agents/sdd-spec.md",
   "assets/agents/sdd-sync.md",
@@ -29,7 +31,15 @@ const requiredPaths = [
   "prompts/gis.md",
   "prompts/gpr.md",
   "prompts/gwr.md",
+  "skills/branch-pr/SKILL.md",
+  "skills/chained-pr/SKILL.md",
+  "skills/cognitive-doc-design/SKILL.md",
+  "skills/comment-writer/SKILL.md",
   "skills/gentle-ai/SKILL.md",
+  "skills/issue-creation/SKILL.md",
+  "skills/judgment-day/SKILL.md",
+  "skills/release/SKILL.md",
+  "skills/skill-registry/SKILL.md",
   "skills/work-unit-commits/SKILL.md",
 ];
 

package/skills/comment-writer/SKILL.md

@@ -27,7 +27,7 @@ Use it for:
 | Keep it short | Prefer 1 to 3 short paragraphs or a tight bullet list. |
 | Explain why | Give the technical reason when asking for a change. |
 | Avoid pile-ons | Comment on the highest-value issue, not every tiny preference. |
-| Match thread language | Write in the thread/user language. If writing in Spanish, use Rioplatense Spanish/voseo: `podés`, `tenés`, `fijate`, `dale`. |
+| Match target context language | Write in the target context language by default: Spanish issue/thread -> Spanish comment, English issue/thread -> English comment, mixed context -> target message language. If the user explicitly requests a language or tone, follow that request. Do not use the active persona as the source of truth for public comments. For Spanish comments, use neutral/professional Spanish by default unless the user or target context clearly calls for regional tone. |
 | No em dashes | Use commas, periods, or parentheses instead. |
 
 ## Comment Formula
@@ -45,25 +45,25 @@ Use it for:
 ### Request change
 
 ```markdown
-Buenísimo el enfoque. Acá separaría este cambio en otro commit porque mezcla la validación con el wiring de UI.
+Good approach overall. I'd split this into a separate commit because it mixes validation logic with UI wiring.
 
-Eso le baja carga al reviewer y hace que el rollback sea más claro si falla la integración.
+That keeps the reviewer's focus narrower and makes rollback cleaner if the integration fails.
 ```
 
 ### Approve with a note
 
 ```markdown
-Está bien encaminado y el scope se entiende rápido.
+Approved. The scope is clear and the change is well-contained.
 
-Dejo aprobado. Para el próximo PR, agregá el link al anterior y al siguiente así la cadena queda navegable.
+For the next PR, add links to the previous and following PRs so the chain stays navigable.
 ```
 
 ### Ask for split
 
 ```markdown
-Este PR supera el presupuesto de 400 líneas cambiadas, así que necesitamos dividirlo o justificar `size:exception`.
+This PR exceeds the 400-line budget, so we need to split it or justify `size:exception`.
 
-Mi sugerencia: primero foundation + tests, después integración, después docs. Así cada review tiene inicio y fin claros.
+Suggested order: foundation + tests first, then integration, then docs. That gives each review a clear start and end.
 ```
 
 ## Commands

package/tests/artifact-language.test.ts

@@ -49,7 +49,14 @@ test("orchestrator keeps conversation language separate from generated artifact
 	);
 	assert.match(
 		orchestrator,
-		/Generated artifacts[\s\S]*default to English, regardless of the user's conversation language/,
+		/Generated technical artifacts[\s\S]*default to English, regardless of the user's conversation language or active persona/,
+	);
+	for (const artifactScope of ["code comments", "tests", "fixtures", "delegated phase outputs"]) {
+		assert.match(orchestrator, new RegExp(artifactScope));
+	}
+	assert.match(
+		orchestrator,
+		/Public\/contextual comments and replies[\s\S]*target context language by default/,
 	);
 });
 
@@ -89,3 +96,35 @@ test("persistent harness prompt assets do not hardcode Spanish SDD artifact copy
 
 	assert.deepEqual(failures, []);
 });
+
+test("comment-writer is context-reactive and neutral by default for Spanish comments", async () => {
+	const skill = await readFile(join(ROOT, "skills/comment-writer/SKILL.md"), "utf8");
+
+	for (const required of [
+		"target context language",
+		"explicitly requests a language",
+		"neutral/professional Spanish by default",
+	]) {
+		assert.match(skill, new RegExp(required.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+	}
+
+	for (const regionalDefault of [
+		/\bAcá\b/,
+		/\bagregá\b/,
+		/\bpodés\b/,
+		/\btenés\b/,
+		/\bfijate\b/,
+		/\bdale\b/,
+		/\bquerés\b/i,
+	]) {
+		assert.doesNotMatch(skill, regionalDefault);
+	}
+
+	for (const englishExample of [
+		"Good approach overall",
+		"Approved. The scope is clear",
+		"This PR exceeds the 400-line budget",
+	]) {
+		assert.match(skill, new RegExp(englishExample.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+	}
+});

package/tests/gentle-ai.test.ts

@@ -0,0 +1,36 @@
+import assert from "node:assert/strict";
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { dirname, join } from "node:path";
+import test from "node:test";
+import { __testing } from "../extensions/gentle-ai.ts";
+
+function writeMarkdown(path: string, content: string): void {
+	mkdirSync(dirname(path), { recursive: true });
+	writeFileSync(path, content);
+}
+
+test("agent discovery skips skills directories", async (t) => {
+	const root = mkdtempSync(join(tmpdir(), "gentle-pi-agents-"));
+	t.after(() => rmSync(root, { recursive: true, force: true }));
+	const dotAgents = join(root, ".agents");
+	writeMarkdown(join(dotAgents, "reviewer.md"), "name: reviewer\n");
+	writeMarkdown(join(dotAgents, "team", "worker.md"), "name: worker\n");
+	writeMarkdown(join(dotAgents, "skills", "ai-sdk", "SKILL.md"), "name: ai-sdk\n");
+	writeMarkdown(
+		join(dotAgents, "skills", "ai-sdk", "references", "evaluation.md"),
+		"name: Prompt Evaluation\n",
+	);
+
+	const syncAgents = __testing.listAgentsFromDir(dotAgents, "user");
+	const asyncAgents = await __testing.listAgentsFromDirAsync(dotAgents, "user");
+
+	assert.deepEqual(
+		syncAgents.map((agent) => agent.name),
+		["reviewer", "worker"],
+	);
+	assert.deepEqual(
+		asyncAgents.map((agent) => agent.name),
+		["reviewer", "worker"],
+	);
+});