geneseed 5.3.1 → 5.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +102 -0
- package/README.md +51 -18
- package/SHIPPED.md +7 -7
- package/adapters/bob/README.md +12 -1
- package/adapters/opencode/README.md +5 -3
- package/adapters/opencode/plugins/geneseed-context.js +77 -10
- package/adapters/opencode/plugins/geneseed-guard.js +106 -22
- package/adapters/opencode/plugins/geneseed-learn.js +641 -6
- package/bin/geneseed-cli.mjs +10 -0
- package/bin/geneseed-hook.mjs +5 -4
- package/docs/PRD.md +1 -1
- package/docs/README.md +1 -0
- package/docs/concepts/agents.md +14 -2
- package/docs/concepts/collaboration.md +2 -2
- package/docs/concepts/enforcement-table.md +5 -2
- package/docs/concepts/exclusions.md +16 -2
- package/docs/concepts/footprint.md +1 -1
- package/docs/concepts/foreman-mode.md +23 -4
- package/docs/concepts/hook-gates.md +4 -4
- package/docs/concepts/hooks.md +25 -7
- package/docs/concepts/host-matrix.md +4 -4
- package/docs/concepts/hosts.md +1 -1
- package/docs/concepts/kits.md +12 -2
- package/docs/concepts/loop-bricks.md +3 -3
- package/docs/concepts/loops.md +6 -4
- package/docs/concepts/ownership.md +1 -1
- package/docs/concepts/rules.md +2 -2
- package/docs/concepts/shared-tier.md +1 -1
- package/docs/concepts/skills.md +21 -1
- package/docs/concepts/themes.md +1 -1
- package/docs/extending.md +73 -29
- package/docs/guides/auto-merge.md +100 -0
- package/docs/guides/choose-your-setup.md +1 -1
- package/docs/guides/headless.md +1 -1
- package/docs/guides/install-clone.md +19 -1
- package/docs/guides/install-scripted.md +8 -2
- package/docs/guides/install.md +20 -2
- package/docs/guides/loop-finish.md +3 -3
- package/docs/guides/loop-running.md +4 -4
- package/docs/guides/project-context.md +1 -1
- package/docs/guides/run-a-factory.md +2 -2
- package/docs/guides/setup-doctrines.md +2 -2
- package/docs/guides/setup-footprint.md +1 -1
- package/docs/guides/uninstall.md +3 -3
- package/docs/guides/upgrade.md +2 -2
- package/docs/guides/worktree.md +1 -1
- package/docs/reference/env-context.md +1 -1
- package/docs/reference/environment.md +4 -2
- package/docs/reference/plugin-activity.md +1 -1
- package/docs/reference/plugin-guard.md +1 -1
- package/docs/reference/plugin-learn.md +5 -1
- package/docs/reference/plugin-workflow.md +1 -1
- package/docs/reference/profiles.md +142 -0
- package/docs/reference/troubleshoot-doctor.md +1 -1
- package/docs/reference/troubleshoot-hooks.md +2 -2
- package/docs/reference/troubleshoot-install.md +3 -3
- package/docs/reference/troubleshoot-tools.md +1 -1
- package/docs/token-footprint.md +11 -6
- package/docs/understand/design-choices-engineering.md +1 -1
- package/docs/understand/enforced-vs-asked.md +1 -1
- package/docs/understand/machine-claude.md +2 -2
- package/docs/understand/on-your-machine.md +1 -1
- package/docs/web-ui.md +8 -6
- package/harness.config.json +1 -1
- package/js/README.md +11 -3
- package/js/build/args.mjs +16 -4
- package/js/build/catalog.mjs +11 -1
- package/js/build/driver.mjs +74 -16
- package/js/build/emit-claude.mjs +32 -5
- package/js/build/emit-opencode.mjs +16 -9
- package/js/build/export.mjs +1 -1
- package/js/build/generate.mjs +12 -157
- package/js/build/notes-migrate.mjs +99 -0
- package/js/build/profile.mjs +326 -0
- package/js/build/render.mjs +110 -8
- package/js/build/retired-skills.mjs +60 -13
- package/js/build/source.mjs +100 -3
- package/js/build/stubs.mjs +4 -1
- package/js/cli-table.json +212 -7
- package/js/hosts/agent-runs.mjs +205 -0
- package/js/hosts/done-checks.mjs +3 -1
- package/js/hosts/hooks-done.mjs +428 -63
- package/js/hosts/hooks-learn.mjs +89 -3
- package/js/hosts/hooks-prims.mjs +44 -4
- package/js/hosts/hooks.mjs +159 -9
- package/js/hosts/hosts.mjs +10 -0
- package/js/hosts/installs.mjs +44 -2
- package/js/hosts/link.mjs +45 -10
- package/js/hosts/native.mjs +61 -7
- package/js/hosts/opencode.mjs +1 -1
- package/js/hosts/settings.mjs +101 -3
- package/js/hosts/spec-feedback.mjs +538 -0
- package/js/hosts/usage.mjs +67 -8
- package/js/inspect/agent-scores.mjs +118 -0
- package/js/inspect/checks-authoring.mjs +2 -1
- package/js/inspect/checks-build.mjs +20 -4
- package/js/inspect/checks-constitution.mjs +32 -0
- package/js/inspect/checks-repo.mjs +27 -2
- package/js/inspect/cost.mjs +6 -5
- package/js/inspect/diff.mjs +46 -8
- package/js/inspect/doctor.mjs +4 -0
- package/js/inspect/inventory.mjs +1 -1
- package/js/inspect/status.mjs +3 -1
- package/js/inspect/validate.mjs +1 -0
- package/js/lib/machine-dir.mjs +8 -0
- package/js/lib/paths.mjs +4 -1
- package/js/maintain/profile-scope.mjs +145 -0
- package/js/maintain/profiles.mjs +486 -0
- package/js/maintain/setup.mjs +413 -15
- package/js/maintain/uninstall.mjs +4 -1
- package/js/maintain/update.mjs +4 -2
- package/js/web/actions.mjs +44 -41
- package/js/web/api.mjs +13 -3
- package/js/web/handler.mjs +8 -0
- package/js/web/jobs.mjs +5 -4
- package/js/web/profiles-api.mjs +201 -0
- package/js/web/routes.mjs +5 -0
- package/package.json +2 -1
- package/profiles/guillaume-claude-global.json +16 -0
- package/profiles/starter.json +14 -0
- package/registry.json +14 -0
- package/src/AGENT.md.tmpl +16 -18
- package/src/agents/_self-improvement.md +15 -7
- package/src/agents/_template.md +4 -2
- package/src/agents/advocate.md +1 -1
- package/src/agents/architect.md +1 -1
- package/src/agents/developer.md +10 -3
- package/src/agents/devops-engineer.md +1 -1
- package/src/agents/docker-expert.md +1 -1
- package/src/agents/docs.md +1 -1
- package/src/agents/empiricist.md +1 -1
- package/src/agents/explorer.md +4 -2
- package/src/agents/framer.md +1 -1
- package/src/agents/historian.md +1 -1
- package/src/agents/kubernetes-specialist.md +1 -1
- package/src/agents/memory-curator.md +1 -1
- package/src/agents/operator.md +1 -1
- package/src/agents/performance.md +1 -1
- package/src/agents/pragmatist.md +1 -1
- package/src/agents/react-engineer.md +1 -1
- package/src/agents/react-reviewer.md +1 -1
- package/src/agents/researcher.md +1 -1
- package/src/agents/reviewer.md +10 -3
- package/src/agents/security.md +1 -1
- package/src/agents/skeptic.md +1 -1
- package/src/agents/spring-boot-engineer.md +1 -1
- package/src/agents/spring-reviewer.md +1 -1
- package/src/agents/spring-security.md +1 -1
- package/src/agents/steward.md +1 -1
- package/src/agents/tester.md +4 -2
- package/src/agents/user-advocate.md +1 -1
- package/src/agents/visionary.md +1 -1
- package/src/bricks/pr-open.md +3 -2
- package/src/doctrines/ops.md +2 -2
- package/src/doctrines/process.md +40 -36
- package/src/factories/analysis-to-build.json +1 -1
- package/src/factories/bug-report-to-fix.json +1 -1
- package/src/factories/issue-to-pr.json +1 -1
- package/src/kits/terminal-tools/rules.md +10 -0
- package/src/kits/terminal-tools.json +13 -0
- package/src/licenses/herdr.txt +201 -0
- package/src/memory/README.md +12 -2
- package/src/modes/foreman.md +25 -9
- package/src/skill-descriptions.json +63 -0
- package/src/skills/_self-improvement.md +42 -24
- package/src/skills/_template.md +3 -1
- package/src/skills/brainstorm.md +35 -22
- package/src/skills/commit.md +17 -17
- package/src/skills/daydream/VENDOR.md +6 -0
- package/src/skills/debug/ci.md +1 -1
- package/src/skills/dependencies.md +3 -3
- package/src/skills/diagram-design/VENDOR.md +4 -0
- package/src/skills/document-project.md +3 -2
- package/src/skills/explain-changes/VENDOR.md +5 -1
- package/src/skills/factory.md +13 -4
- package/src/skills/geneseed.md +4 -2
- package/src/skills/git-history.md +5 -7
- package/src/skills/herdr.md +135 -0
- package/src/skills/loop.md +3 -2
- package/src/skills/opencode-cli.md +84 -0
- package/src/skills/parallel-agents.md +11 -0
- package/src/skills/pipeline.md +3 -3
- package/src/skills/plan.md +5 -4
- package/src/skills/react-view-transitions/VENDOR.md +7 -1
- package/src/skills/release.md +11 -9
- package/src/skills/review-response.md +4 -2
- package/src/skills/rule/approve.md +2 -1
- package/src/skills/rule.md +27 -1
- package/src/skills/ship.md +54 -7
- package/src/skills/skill-forge.md +5 -3
- package/src/skills/token-report/VENDOR.md +5 -1
- package/src/skills/worktree.md +2 -2
- package/src/upstreams.json +9 -2
- package/themes/README.md +3 -1
- package/themes/_TEMPLATE.json +2 -0
- package/themes/biker.json +2 -0
- package/themes/commentator.json +2 -0
- package/themes/cyberpunk.json +2 -0
- package/themes/gamer.json +2 -0
- package/themes/imperial.json +2 -0
- package/themes/joker.json +2 -0
- package/themes/marvin.json +2 -0
- package/themes/mean.json +2 -0
- package/themes/military.json +2 -0
- package/themes/neutral.json +2 -0
- package/themes/pirate.json +2 -0
- package/themes/sports.json +2 -0
- package/themes/verstappen.json +2 -0
- package/themes/wizard.json +2 -0
- package/web/dist/assets/{ActiveLoops-BJJN3P-V.js → ActiveLoops-DOJCPPPc.js} +1 -1
- package/web/dist/assets/Activity-LKsDzsnK.js +1 -0
- package/web/dist/assets/ActivityDetail-DhwTfPm6.js +1 -0
- package/web/dist/assets/{Bonsai-BBl4XXqs.js → Bonsai-CePMLrpr.js} +1 -1
- package/web/dist/assets/{CopyButton-Beven8yn.js → CopyButton-CuoaJ6k7.js} +1 -1
- package/web/dist/assets/Dashboard-D1VKuvLe.js +2 -0
- package/web/dist/assets/Docs-CUrHJKaU.js +5 -0
- package/web/dist/assets/Factories-Ci1XfmSy.js +1 -0
- package/web/dist/assets/{GreenhouseView-Bce212qd.js → GreenhouseView-CNfH2lPK.js} +1 -1
- package/web/dist/assets/Installs-ZHQZM1iS.js +3 -0
- package/web/dist/assets/{JournalView-CV4omyww.js → JournalView-CMsWahkS.js} +1 -1
- package/web/dist/assets/Kits-CkliyK0n.js +1 -0
- package/web/dist/assets/Laws-hh4O3HZ4.js +4 -0
- package/web/dist/assets/{LibRows-Dag1s0ZX.js → LibRows-Brv0Hmkr.js} +1 -1
- package/web/dist/assets/Library-BYmiLjJr.js +3 -0
- package/web/dist/assets/Loops-ytm-xJ68.js +2 -0
- package/web/dist/assets/{OperatorHudView-JmYY1pBR.js → OperatorHudView-KaqCx_HP.js} +1 -1
- package/web/dist/assets/Personal-CmcnRKYE.js +2 -0
- package/web/dist/assets/Settings-tUrpdOfq.js +1 -0
- package/web/dist/assets/{Tabs-8zsyEPSK.js → Tabs-CD7etcGD.js} +1 -1
- package/web/dist/assets/api-CZ-x0iWG.js +1 -0
- package/web/dist/assets/{controls-D4wmg_pl.js → controls-CK7qHA8H.js} +1 -1
- package/web/dist/assets/{index-CRWqKxfY.css → index-Ba_Kg3Af.css} +1 -1
- package/web/dist/assets/index-COKbhFNo.js +6 -0
- package/web/dist/index.html +3 -3
- package/web/dist/assets/Activity-WQ3ykgxU.js +0 -1
- package/web/dist/assets/ActivityDetail-7rt04SkS.js +0 -1
- package/web/dist/assets/Dashboard-BgLArtgu.js +0 -2
- package/web/dist/assets/Docs-B5aHp86J.js +0 -5
- package/web/dist/assets/Factories-BjqzXAw8.js +0 -1
- package/web/dist/assets/Installs-B1OsrHXF.js +0 -3
- package/web/dist/assets/Kits-CW1e7xNa.js +0 -1
- package/web/dist/assets/Laws-1Ckf1lbs.js +0 -4
- package/web/dist/assets/Library-B3FuFLel.js +0 -3
- package/web/dist/assets/Loops-CwqgnLNw.js +0 -2
- package/web/dist/assets/Personal-DKLgLa7Z.js +0 -2
- package/web/dist/assets/Settings-BwErnh-R.js +0 -1
- package/web/dist/assets/api-DLDVY3K-.js +0 -1
- package/web/dist/assets/index-Ce6qF2nG.js +0 -6
package/src/AGENT.md.tmpl
CHANGED
|
@@ -24,19 +24,17 @@ Tool-agnostic: where the host has no sub-agents, each {{AGENT}} below is a
|
|
|
24
24
|
<!-- LEAN:end -->
|
|
25
25
|
|
|
26
26
|
<!-- LEAN:begin -->
|
|
27
|
-
**Readiness sigil
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
it
|
|
33
|
-
first:** when a request matches a {{SKILL}}, invoke it as your first tool
|
|
34
|
-
call — before loading context or touching files.
|
|
27
|
+
**Readiness sigil.** Before your first reply, read this file and its {{LAWS}}, then
|
|
28
|
+
load the project context (**Session start**, below). Begin that reply with the line
|
|
29
|
+
below, as written, before any other text. The user reads it as the sign that you
|
|
30
|
+
loaded the {{LAWS}} and the project context; a first reply without it tells them the
|
|
31
|
+
harness was not read. **{{SKILLS}} first:** when a request matches a {{SKILL}}, invoke
|
|
32
|
+
it as your first tool call, before you load context or touch files.
|
|
35
33
|
<!-- LEAN:else -->
|
|
36
|
-
**Readiness sigil
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
34
|
+
**Readiness sigil.** Before your first reply, read this file and its {{LAWS}} and load
|
|
35
|
+
`context.json` and its `eager` entries (§9); begin that reply with the line below, as
|
|
36
|
+
written. **{{SKILLS}} first:** when the request matches a {{SKILL}}, invoke it as your first
|
|
37
|
+
tool call, before you load context, read files or search.
|
|
40
38
|
<!-- LEAN:end -->
|
|
41
39
|
|
|
42
40
|
> {{LOADED_SIGIL}}
|
|
@@ -205,7 +203,7 @@ decompose it into independent subtasks, route each to the single owning {{AGENT}
|
|
|
205
203
|
above, and converge the results yourself. Every handoff carries an **envelope** —
|
|
206
204
|
the subtask goal, the inputs the {{AGENT}} needs, and its output contract — and the
|
|
207
205
|
constraints travel with it: dispatched {{AGENTS}} commit only in their own worktree, never
|
|
208
|
-
push, and never merge outside their own branch ({{DOCTRINE:consent-before-push}}
|
|
206
|
+
push, and never merge outside their own branch, so the push stays with you ({{DOCTRINE:consent-before-push}}), and an unfulfilled contract returns as a stated gap, never invented
|
|
209
207
|
content. Where the host exposes a `workflow` tool, prefer the saved `dispatch`
|
|
210
208
|
workflow ([workflow {{SKILL}}]({{DIR_SKILLS}}/workflow.md)); where it does not, run
|
|
211
209
|
the same shape model-driven via the [parallel-agents {{SKILL}}]({{DIR_SKILLS}}/parallel-agents.md).
|
|
@@ -217,7 +215,7 @@ dispatched alone; the [council {{SKILL}}]({{DIR_SKILLS}}/council.md) convenes th
|
|
|
217
215
|
subset that productively clashes on a given motion.
|
|
218
216
|
<!-- LEAN:else -->
|
|
219
217
|
Dispatched {{AGENTS}} commit only in their worktree, never push, never merge outside
|
|
220
|
-
their own branch ({{DOCTRINE:consent-before-push}}
|
|
218
|
+
their own branch, so the push stays with you ({{DOCTRINE:consent-before-push}}), and an unfulfilled contract returns as a stated gap, never invented content. A
|
|
221
219
|
multi-part goal goes through the [parallel-agents {{SKILL}}]({{DIR_SKILLS}}/parallel-agents.md)
|
|
222
220
|
(or the [workflow {{SKILL}}]({{DIR_SKILLS}}/workflow.md) where the host has a workflow tool);
|
|
223
221
|
the ten council seats are convened by the [council {{SKILL}}]({{DIR_SKILLS}}/council.md).
|
|
@@ -300,7 +298,7 @@ inventory — that list is the catalogue and it is authoritative, as is its
|
|
|
300
298
|
procedure is in [`{{DIR_SKILLS}}/`]({{DIR_SKILLS}}/) and the host loads it on
|
|
301
299
|
demand.
|
|
302
300
|
<!-- CATALOG:end -->
|
|
303
|
-
{{EXCLUDED_SKILLS_LINE}}{{KITS_LINE}}{{SHARED_TIER_LINE}}
|
|
301
|
+
{{EXCLUDED_SKILLS_LINE}}{{KITS_LINE}}{{SHARED_TIER_LINE}}{{CONTEXT_WINDOW_LINE}}
|
|
304
302
|
When a task repeats and no {{SKILL}} covers it, forge one through the
|
|
305
303
|
[skill-forge]({{DIR_SKILLS}}/skill-forge.md) {{SKILL}}: copy
|
|
306
304
|
[`{{DIR_SKILLS}}/_template.md`]({{DIR_SKILLS}}/_template.md), keep it to one coherent
|
|
@@ -359,7 +357,7 @@ tool you build for yourself — belongs in `{{DIR_NOTEBOOK}}/`, never in the hos
|
|
|
359
357
|
tree. `NOTEBOOK.md`, a session file, recalls what you keep here; keep the space referable across sessions — the seeded index
|
|
360
358
|
is one way; replace it with whatever scheme serves you better. When a note
|
|
361
359
|
hardens into a durable fact worth recalling verbatim, write it to {{MEMORY}}
|
|
362
|
-
|
|
360
|
+
in §5 ({{DOCTRINE:persist-insight}}). Keep the two stores distinct by *role*, not just by
|
|
363
361
|
format: {{MEMORY}} holds durable insight for future sessions, the {{NOTEBOOK}}
|
|
364
362
|
holds your working artifacts. The one fixed law: `{{DIR_NOTEBOOK}}/` is **personal and
|
|
365
363
|
git-ignored** — never committed or shared, and the `.gitignore` that guarantees
|
|
@@ -457,7 +455,7 @@ new note linked in. Cross-project facts go here via the
|
|
|
457
455
|
*{{EPI_CONTEXT}}*
|
|
458
456
|
|
|
459
457
|
<!-- LEAN:begin -->
|
|
460
|
-
|
|
458
|
+
Load `context.json` before your first reply. The
|
|
461
459
|
harness carries no project-specific knowledge; this manifest is how the project hands
|
|
462
460
|
you its own: the repo's own (`context.json` or `.harness/context.json` at its root),
|
|
463
461
|
else `{{AT_HARNESS}}context.json`. The hook injects its `eager` entries (**Session
|
|
@@ -475,7 +473,7 @@ comment carries its schema and setup notes.
|
|
|
475
473
|
**Reviewing code** — with any review command, built-in or not — first apply the nearest
|
|
476
474
|
`REVIEW.md` above each changed file. It overrides the review defaults, never a {{LAW}}.
|
|
477
475
|
<!-- LEAN:else -->
|
|
478
|
-
|
|
476
|
+
Load `context.json` before your first reply. The repo's own
|
|
479
477
|
(`context.json` or `.harness/context.json` at its root), else `{{AT_HARNESS}}context.json`,
|
|
480
478
|
is how the project hands you its own knowledge; the hook injects its `eager` entries
|
|
481
479
|
(**Session start**). `"eager"` entries are read now and are
|
|
@@ -3,10 +3,18 @@
|
|
|
3
3
|
If this spec misled you — an input you needed but were not given, a boundary
|
|
4
4
|
that proved wrong, a step you could not execute — end your report with one line:
|
|
5
5
|
`spec-feedback: [agent|general] <the one-line fix> [— situation: <when it applies>] — seen:
|
|
6
|
-
<what happened, against what this spec led you to expect>`.
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
6
|
+
<what happened, against what this spec led you to expect>`. Ask one question first: is it true
|
|
7
|
+
in any repo, or only here? Any repo: `[agent]`, or `[general]` for a fix other {{AGENTS}} need
|
|
8
|
+
too. Only here: `[agent:project]`, or `[general:project]`. Omit the line when there is no
|
|
9
|
+
friction. When the run ends, the harness hook copies each line, dated, into the machine notes
|
|
10
|
+
`{{PATH_NOTES}}/agent-notes/<name>.md` (a `general` line into `agent-notes/_general.md` there),
|
|
11
|
+
or a `project` line into `{{PATH_PROJECT_NOTES}}/agent-notes/` at the project root, the same two
|
|
12
|
+
files (in a linked worktree, the main checkout's) — no model call, and never into this rendered file, which
|
|
13
|
+
a rebuild overwrites. Step 0 reads those notes at every later dispatch of this {{AGENT}}, machine
|
|
14
|
+
first; the project notes win where they disagree. When a step-0 read is refused, or the brief
|
|
15
|
+
forbids that path, skip it, say so in one line of the report, and go on. The caller writes no
|
|
16
|
+
note itself, except on a host with no subagent-finished hook (Bob), where it copies the line
|
|
17
|
+
into the machine or the project file, in the same form. The caller
|
|
18
|
+
weighs the line, and folding a note into the source is the user's call, after the
|
|
19
|
+
skill-forge {{SKILL}}'s probe. The caller records the feedback to {{MEMORY}} only if it
|
|
20
|
+
clears {{DOCTRINE:persist-insight}}'s bar — most reports carry no feedback at all.
|
package/src/agents/_template.md
CHANGED
|
@@ -42,8 +42,10 @@
|
|
|
42
42
|
write-capable {{AGENT}}'s spec must not contain it, or its emit is locked down.
|
|
43
43
|
|
|
44
44
|
## Procedure
|
|
45
|
-
0.
|
|
46
|
-
|
|
45
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches
|
|
46
|
+
({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback
|
|
47
|
+
notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`,
|
|
48
|
+
then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
47
49
|
1. Step-by-step method this {{AGENT}} follows.
|
|
48
50
|
|
|
49
51
|
## Output contract
|
package/src/agents/advocate.md
CHANGED
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
- **Read-only.** Search and read, to ground the case in the real artifact. Never edits, never runs commands, never casts the verdict.
|
|
18
18
|
|
|
19
19
|
## Procedure
|
|
20
|
-
0.
|
|
20
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
21
21
|
1. Read the motion and the artifact so the case is concrete, not abstract ({{DOCTRINE:read-the-docs-first}}).
|
|
22
22
|
2. Steelman the proposal: make its strongest case — the upside, the opportunity, the cost of *not* acting ({{ONTOLOGY}}: {{ONT_CONDUCT}}).
|
|
23
23
|
3. Name the single objection the proposal must survive, and answer it; concede only what is genuinely indefensible.
|
package/src/agents/architect.md
CHANGED
|
@@ -22,7 +22,7 @@
|
|
|
22
22
|
<!-- bash: allow -->
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Establish the current state: data shapes, module boundaries, existing patterns.
|
|
27
27
|
2. Propose 2–3 approaches with trade-offs; recommend one with reasoning.
|
|
28
28
|
3. Break the chosen approach into isolated units, each with one purpose and a
|
package/src/agents/developer.md
CHANGED
|
@@ -22,16 +22,20 @@
|
|
|
22
22
|
decisions the developer approved, carried in the brief.
|
|
23
23
|
|
|
24
24
|
## Allowed tools
|
|
25
|
-
- **Read + write to the assigned worktree.** May run the project's own build
|
|
26
|
-
commands to self-check before handing off
|
|
25
|
+
- **Read + write to the assigned worktree.** May run the project's own build, lint and
|
|
26
|
+
test commands to self-check before handing off; installs dependencies (`npm ci` and
|
|
27
|
+
alike) only when the brief allows it.
|
|
27
28
|
<!-- bash: allow -->
|
|
29
|
+
- In an isolated worktree, run one plain command per call: `git -C <worktree>`, never
|
|
30
|
+
`cd <worktree> &&`, no heredocs. Change files with the edit and write tools; a `\u`
|
|
31
|
+
escape in source stays an escape — check it in the diff.
|
|
28
32
|
- Commits only in its own worktree, never pushes, and never merges outside its own branch
|
|
29
33
|
({{DOCTRINE:consent-before-push}}); into that branch it merges only the branches of
|
|
30
34
|
sub-workers it started. The parent re-runs the proof and merges beyond it once the user
|
|
31
35
|
accepts.
|
|
32
36
|
|
|
33
37
|
## Procedure
|
|
34
|
-
0.
|
|
38
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
35
39
|
1. Implement the smallest change that satisfies the scoped task ({{DOCTRINE:smallest-viable-diff}}) —
|
|
36
40
|
in the assigned worktree only, never touching the parent's own tree. In ownership mode,
|
|
37
41
|
write only what the approved decisions cover; on a choice none of them covers, stop and
|
|
@@ -61,6 +65,9 @@ in your own context, and after two repair rounds on your own red tests return re
|
|
|
61
65
|
findings ({{DOCTRINE:bound-the-loop}}). As a lead, hold every member's result before you end. Report `T<n> · <task> · files: <write set> · <state>`
|
|
62
66
|
at start and on each change, as the mode says. Return the branch, its commit list, any
|
|
63
67
|
uncommitted work, and the raw test + lint output — the parent re-runs it before any merge.
|
|
68
|
+
That output is a full run to completion, with the runner's own count line, never a
|
|
69
|
+
partial run. Call a failure pre-existing only after you reproduce it on a clean checkout
|
|
70
|
+
of BASE, and cite that run.
|
|
64
71
|
|
|
65
72
|
## Pipeline role
|
|
66
73
|
|
|
@@ -21,7 +21,7 @@ Builds CI/CD pipelines and delivery automation for Spring Boot applications.
|
|
|
21
21
|
- Never commits, pushes or triggers a deployment ({{DOCTRINE:consent-before-push}}).
|
|
22
22
|
|
|
23
23
|
## Procedure
|
|
24
|
-
0.
|
|
24
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
25
25
|
1. Detect the CI the project already uses (GitHub Actions, GitLab CI, Jenkins, other) and extend it; do not switch providers. With none present, ask the user which to use.
|
|
26
26
|
2. Pipeline order: checkout, restore build cache, `./mvnw verify` (or `./gradlew build`), publish test results, build image, scan, push, deploy.
|
|
27
27
|
3. Cache the Maven or Gradle repository keyed on the build files.
|
|
@@ -22,7 +22,7 @@ Builds small, safe container images for Spring Boot 4 applications.
|
|
|
22
22
|
- Never pushes images or commits ({{DOCTRINE:consent-before-push}}).
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Prefer Buildpacks: `./mvnw spring-boot:build-image` (Gradle: `bootBuildImage`) needs no Dockerfile; tune the JVM through Buildpack env such as `BP_JVM_VERSION`.
|
|
27
27
|
2. Use a Dockerfile only when Buildpacks do not fit. Build multi-stage and extract layers with `java -Djarmode=tools -jar app.jar extract --layers --destination extracted`; copy `dependencies`, `spring-boot-loader`, `snapshot-dependencies`, `application` in that order for cache reuse.
|
|
28
28
|
3. Run as a non-root user; pin base image tags or digests, never `latest`.
|
package/src/agents/docs.md
CHANGED
|
@@ -19,7 +19,7 @@
|
|
|
19
19
|
may run documented examples and commands to confirm they work as written.
|
|
20
20
|
|
|
21
21
|
## Procedure
|
|
22
|
-
0.
|
|
22
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
23
23
|
1. Read the actual code/behaviour before describing it — never document intent
|
|
24
24
|
that the code does not implement ({{LAW:verify-before-asserting}}).
|
|
25
25
|
2. Write for the stated audience; lead with what the reader needs to do.
|
package/src/agents/empiricist.md
CHANGED
|
@@ -20,7 +20,7 @@
|
|
|
20
20
|
<!-- bash: allow -->
|
|
21
21
|
|
|
22
22
|
## Procedure
|
|
23
|
-
0.
|
|
23
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
24
24
|
1. Read the motion and the arguments, then list the load-bearing claims on both sides ({{DOCTRINE:read-the-docs-first}}).
|
|
25
25
|
2. Mark each claim evidenced or unevidenced — and call out any asserted as fact without a source ({{LAW:verify-before-asserting}}).
|
|
26
26
|
3. For the decisive unknowns, name the cheapest experiment, benchmark, or check that would settle them.
|
package/src/agents/explorer.md
CHANGED
|
@@ -24,14 +24,16 @@
|
|
|
24
24
|
<!-- bash: allow -->
|
|
25
25
|
|
|
26
26
|
## Procedure
|
|
27
|
-
0.
|
|
27
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
28
|
+
When the brief says to answer from what it hands you alone, skip steps 0–2.
|
|
28
29
|
1. Search to locate the relevant files before reading them ({{DOCTRINE:context-economy}}).
|
|
29
30
|
2. Read only the slices that matter; follow references outward as needed.
|
|
30
31
|
3. Synthesize — return findings, not raw dumps.
|
|
31
32
|
|
|
32
33
|
## Output contract
|
|
33
34
|
- A concise answer: the conclusion, the key `file:line` references that support
|
|
34
|
-
it, and any open questions. Never the full contents of what was read.
|
|
35
|
+
it, and any open questions. Never the full contents of what was read. In a git repo, name
|
|
36
|
+
the commit the facts were read at (`git rev-parse --short HEAD`).
|
|
35
37
|
- If the search comes up empty, report what was searched and where, and answer
|
|
36
38
|
not-found — a confident wrong location costs more than an honest blank
|
|
37
39
|
({{LAW:verify-before-asserting}}).
|
package/src/agents/framer.md
CHANGED
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
- **Read-only.** Search and read, to ground the reframe in the real need. Never edits, never runs commands, never casts the verdict.
|
|
18
18
|
|
|
19
19
|
## Procedure
|
|
20
|
-
0.
|
|
20
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
21
21
|
1. Read the motion and what prompted it, then restate the underlying need in one plain sentence ({{DOCTRINE:read-the-docs-first}}).
|
|
22
22
|
2. Test whether the motion addresses that need or only a symptom of it; ask what problem it would leave unsolved.
|
|
23
23
|
3. If the framing is off, offer the reframed problem — the question the council should actually be debating.
|
package/src/agents/historian.md
CHANGED
|
@@ -20,7 +20,7 @@
|
|
|
20
20
|
<!-- bash: allow -->
|
|
21
21
|
|
|
22
22
|
## Procedure
|
|
23
|
-
0.
|
|
23
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
24
24
|
1. Read the motion, then search the codebase, changelog, and docs for prior attempts, reverts, and related decisions ({{DOCTRINE:read-the-docs-first}}).
|
|
25
25
|
2. Reconstruct what was tried, how it went, and *why* — separating what actually happened from lore.
|
|
26
26
|
3. Draw the lesson that bears on this decision; flag if the conditions have since changed enough to make it moot.
|
|
@@ -21,7 +21,7 @@ Deploys Spring Boot 4 applications on Kubernetes.
|
|
|
21
21
|
- Never applies to a live cluster and never pushes without the user's say-so ({{DOCTRINE:consent-before-push}}).
|
|
22
22
|
|
|
23
23
|
## Procedure
|
|
24
|
-
0.
|
|
24
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
25
25
|
1. Match the project's manifest style; do not introduce a new tool.
|
|
26
26
|
2. Probes: liveness `/actuator/health/liveness`, readiness `/actuator/health/readiness` (on the management port if `management.server.port` is set); add a startup probe for slow starts. Boot exposes these health groups by default; `management.endpoint.health.probes.enabled=false` turns them off.
|
|
27
27
|
3. Shutdown: `server.shutdown=graceful` with `spring.lifecycle.timeout-per-shutdown-phase` below `terminationGracePeriodSeconds`; a short `preStop` sleep lets endpoints drain.
|
|
@@ -29,7 +29,7 @@
|
|
|
29
29
|
approved by code ({{LAW:deletion-is-deliberate}}).
|
|
30
30
|
|
|
31
31
|
## Procedure
|
|
32
|
-
0.
|
|
32
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
33
33
|
1. Read the map (`MEMORY.md`), then one topic file at a time, then only the facts
|
|
34
34
|
that topic needs ({{DOCTRINE:context-economy}}). On a large store, work topic by
|
|
35
35
|
topic and report progress after each one (`3/14 topics: 4 merged, 2 archived`).
|
package/src/agents/operator.md
CHANGED
|
@@ -18,7 +18,7 @@
|
|
|
18
18
|
- **Read-only.** Search and read, to judge operability against the real system. Never edits, never runs commands, never casts the verdict.
|
|
19
19
|
|
|
20
20
|
## Procedure
|
|
21
|
-
0.
|
|
21
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
22
22
|
1. Read the motion and how it would run, so the concerns are this system's, not generic ({{DOCTRINE:read-the-docs-first}}).
|
|
23
23
|
2. Pre-mortem the 3am incident: how it fails under load, whether you can see it failing (metrics, logs), and how you roll it back. Treat a production deploy with no tested rollback or fix-forward path and no retained previous artifact as not ready to ship — there must be a way back before there is a way out.
|
|
24
24
|
3. Weigh the standing cost — the on-call burden, the toil, the new ways to be paged — against the benefit.
|
|
@@ -25,7 +25,7 @@
|
|
|
25
25
|
<!-- bash: allow -->
|
|
26
26
|
|
|
27
27
|
## Procedure
|
|
28
|
-
0.
|
|
28
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
29
29
|
1. Pin the question: which metric (wall time, p95 latency, peak memory, allocations,
|
|
30
30
|
query count), under which workload, and what number would count as fixed.
|
|
31
31
|
2. Take a baseline with the project's own tooling where it has some, run several
|
package/src/agents/pragmatist.md
CHANGED
|
@@ -18,7 +18,7 @@
|
|
|
18
18
|
- **Read-only.** Search and read, to size the work against the real codebase. Never edits, never runs commands, never casts the verdict.
|
|
19
19
|
|
|
20
20
|
## Procedure
|
|
21
|
-
0.
|
|
21
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
22
22
|
1. Read the motion and the artifact so the estimate is grounded, not guessed ({{DOCTRINE:read-the-docs-first}}).
|
|
23
23
|
2. Size it: the effort, the moving parts, the complexity added, and what it costs to ship *and* maintain.
|
|
24
24
|
3. Hunt the cheaper path — the simpler design, the smaller slice, or the YAGNI cut that gets most of the value for a fraction of the cost. Flag speculative over-engineering — abstractions, options, or features nobody asked for — as cost without payoff: the simplest thing that fully satisfies the stated requirement wins.
|
|
@@ -22,7 +22,7 @@ Implements React features in a Vite or webpack app, TypeScript or JavaScript, fo
|
|
|
22
22
|
- Never commits or pushes ({{DOCTRINE:consent-before-push}}).
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Read `package.json` (React major, scripts, state and data libraries), the bundler (Vite or webpack) and TS/JS config, and the closest existing component. Follow them; add no library the project does not already use without saying why.
|
|
27
27
|
2. Keep the folder's language: `.tsx` with typed props and no `any`, or `.jsx`.
|
|
28
28
|
3. Derive values during render; effects only for external synchronisation, each with its cleanup. Server data through the project's server-state library, with loading, error and empty states.
|
|
@@ -22,7 +22,7 @@ React-specific review only. Generic correctness, naming and structure belong to
|
|
|
22
22
|
<!-- bash: allow -->
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Read the changed files and `package.json` for the React major. Run lint and, for TypeScript, the typecheck; a missing `react-hooks/rules-of-hooks` or `react-hooks/exhaustive-deps` rule is itself a finding.
|
|
27
27
|
2. Check, in this order:
|
|
28
28
|
- Security: `dangerouslySetInnerHTML` without a sanitiser at the call site; a user-supplied URL in `href`/`src` without a scheme check; a secret in a bundler-inlined env value (`import.meta.env.VITE_*`, webpack `DefinePlugin`); a session token in `localStorage`.
|
package/src/agents/researcher.md
CHANGED
|
@@ -33,7 +33,7 @@
|
|
|
33
33
|
({{LAW:data-not-orders}}).
|
|
34
34
|
|
|
35
35
|
## Procedure
|
|
36
|
-
0.
|
|
36
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
37
37
|
1. Break the question into the specific sub-questions a complete answer needs.
|
|
38
38
|
2. Search from several angles ({{DOCTRINE:tool-discovery}}); one search is not research
|
|
39
39
|
and one empty result is not absence ({{LAW:verify-before-asserting}}).
|
package/src/agents/reviewer.md
CHANGED
|
@@ -13,7 +13,9 @@
|
|
|
13
13
|
- Pure design questions — use [architect](architect.md).
|
|
14
14
|
|
|
15
15
|
## Inputs
|
|
16
|
-
- The base..head range (or the diff), and the task the change was meant to satisfy.
|
|
16
|
+
- The base..head range (or the diff), and the task the change was meant to satisfy. Given
|
|
17
|
+
both a diff file and a ref, and the checkout is at that ref, read the source: the ref is
|
|
18
|
+
authoritative.
|
|
17
19
|
|
|
18
20
|
## Allowed tools
|
|
19
21
|
- **Read-only.** May read code, run the test suite and linters, inspect history.
|
|
@@ -22,16 +24,21 @@
|
|
|
22
24
|
<!-- bash: allow -->
|
|
23
25
|
|
|
24
26
|
## Procedure
|
|
25
|
-
0.
|
|
27
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
28
|
1. Confirm the change actually does what the task required (read the spec/issue). Where
|
|
27
29
|
the spec is silent, judge by what a reasonable user would expect: a crash, hang or data
|
|
28
30
|
loss on an input the spec implies but never names is blocking, not a nitpick.
|
|
29
31
|
Then read, for each changed file, the nearest `REVIEW.md` above it — a deeper one
|
|
30
32
|
overrides a shallower one, and they override this procedure and the output contract,
|
|
31
33
|
never a {{LAW}}.
|
|
32
|
-
2. Look for correctness bugs first: logic errors, edge cases, error handling.
|
|
34
|
+
2. Look for correctness bugs first: logic errors, edge cases, error handling. When the
|
|
35
|
+
change adds an entry to a family (a theme, a host, a world), grep the tests for a
|
|
36
|
+
sibling's id and flag each per-entry list the new entry is missing from — such a list
|
|
37
|
+
passes without it.
|
|
33
38
|
3. Then quality: duplication, unclear naming, dead code, oversized units.
|
|
34
39
|
4. Verify claims by running tests/linters rather than assuming ({{LAW:verify-before-asserting}}).
|
|
40
|
+
A diff with nothing to run (prompts, charters, docs): trace each path it changes against
|
|
41
|
+
its readers by hand, and say that this was the check.
|
|
35
42
|
|
|
36
43
|
## Output contract
|
|
37
44
|
- A list of findings, each a Conventional Comment, `label (decoration): file:line — problem
|
package/src/agents/security.md
CHANGED
|
@@ -18,7 +18,7 @@
|
|
|
18
18
|
<!-- bash: allow -->
|
|
19
19
|
|
|
20
20
|
## Procedure
|
|
21
|
-
0.
|
|
21
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
22
22
|
1. Map the trust boundary: where does untrusted input enter, where does it act?
|
|
23
23
|
2. Check for the common classes: injection, broken auth/authz, secret exposure,
|
|
24
24
|
unsafe deserialization, path traversal, vulnerable dependencies.
|
package/src/agents/skeptic.md
CHANGED
|
@@ -18,7 +18,7 @@
|
|
|
18
18
|
- **Read-only.** Search and read, to ground each objection in the real artifact. Never edits, never runs commands, never casts the verdict.
|
|
19
19
|
|
|
20
20
|
## Procedure
|
|
21
|
-
0.
|
|
21
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
22
22
|
1. Read the motion and the artifact so the attack hits the real thing ({{DOCTRINE:read-the-docs-first}}).
|
|
23
23
|
2. Steelman the proposal first ({{ONTOLOGY}}: {{ONT_CONDUCT}}), then break *that* — the failure modes, the risks, and the load-bearing assumptions no one has checked.
|
|
24
24
|
3. Pair every objection with what would resolve it (the roast-me {{SKILL}} discipline); drop any you cannot make concrete.
|
|
@@ -22,7 +22,7 @@ Implements Spring Boot 4 / Java 21+ features, following the spring-boot, spring-
|
|
|
22
22
|
- Never commits or pushes ({{DOCTRINE:consent-before-push}}).
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Follow the project's existing layout and build tool; match its group id, packages and CI. Lombok is fine when the project already uses it.
|
|
27
27
|
2. Constructor injection; records for request and response DTOs; `@Valid` on request bodies; one `@RestControllerAdvice` for errors.
|
|
28
28
|
3. Services: `@Transactional(readOnly = true)` on the class, `@Transactional` on mutating methods. Never call a transactional or `@Async` method through `this`.
|
|
@@ -22,7 +22,7 @@ Spring-specific review only. Generic correctness, naming and structure belong to
|
|
|
22
22
|
<!-- bash: allow -->
|
|
23
23
|
|
|
24
24
|
## Procedure
|
|
25
|
-
0.
|
|
25
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
26
26
|
1. Read the changed files and the build file to learn the Boot version.
|
|
27
27
|
2. Check, in this order:
|
|
28
28
|
- Injection: field `@Autowired`, circular dependencies.
|
|
@@ -21,7 +21,7 @@ Spring Security 7 audit only. The generic audit (injection, secrets, dependencie
|
|
|
21
21
|
<!-- bash: allow -->
|
|
22
22
|
|
|
23
23
|
## Procedure
|
|
24
|
-
0.
|
|
24
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
25
25
|
1. Read the `SecurityFilterChain` beans first, then method-security usage and config files.
|
|
26
26
|
2. Check:
|
|
27
27
|
- Filter chain: a bean, never `WebSecurityConfigurerAdapter`; `authorizeHttpRequests` ends in `anyRequest().authenticated()` or `denyAll()`; only health and login endpoints open.
|
package/src/agents/steward.md
CHANGED
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
- **Read-only.** Search and read, to judge fit against the real system. Never edits, never runs commands, never casts the verdict.
|
|
18
18
|
|
|
19
19
|
## Procedure
|
|
20
|
-
0.
|
|
20
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
21
21
|
1. Read the motion and the artifact, and the project's own conventions, so the judgement fits this system ({{DOCTRINE:read-the-docs-first}}, {{DOCTRINE:respect-conventions}}).
|
|
22
22
|
2. Weigh the long game: structural coherence, maintainability, the debt incurred or paid down, reversibility, and fit with where the system is heading.
|
|
23
23
|
3. Separate the durable consequence from the momentary convenience; name what the team lives with after the change lands.
|
package/src/agents/tester.md
CHANGED
|
@@ -18,11 +18,13 @@
|
|
|
18
18
|
- Does not change production code; if a fix is needed, it reports the diagnosis.
|
|
19
19
|
|
|
20
20
|
## Procedure
|
|
21
|
-
0.
|
|
21
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
22
22
|
1. For new tests: write the test, watch it fail with the behaviour absent or
|
|
23
23
|
deliberately broken, then confirm it passes against the implementation —
|
|
24
24
|
a test that has never failed verifies nothing ({{LAW:verify-before-asserting}}).
|
|
25
|
-
2. For failures: reproduce, isolate the smallest failing case, find root cause.
|
|
25
|
+
2. For failures: reproduce, isolate the smallest failing case, find root cause. A failure
|
|
26
|
+
seen in a concurrent run: re-run that file alone first. Green alone and red together is
|
|
27
|
+
load or a race, not the code — report it as such.
|
|
26
28
|
3. Cover edge cases and error paths, not just the happy path — including
|
|
27
29
|
adversarial inputs at any trust boundary the code under test exposes.
|
|
28
30
|
4. Run the project's linter alongside the suite and report both exit codes — the
|
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
- **Read-only.** Search and read, to ground the consumer's view in the real interface. Never edits, never runs commands, never casts the verdict.
|
|
18
18
|
|
|
19
19
|
## Procedure
|
|
20
|
-
0.
|
|
20
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
21
21
|
1. Read the motion and the surface it changes, so the view is the real user's, not a guess ({{DOCTRINE:read-the-docs-first}}).
|
|
22
22
|
2. Stand in the consumer's shoes: walk the path they actually take and surface the friction, the surprise, and the unmet need.
|
|
23
23
|
3. Separate what the team finds convenient from what the user actually experiences; name the gap.
|
package/src/agents/visionary.md
CHANGED
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
- **Read-only.** Search and read, to ground the vision in what exists. Never edits, never runs commands, never casts the verdict.
|
|
18
18
|
|
|
19
19
|
## Procedure
|
|
20
|
-
0.
|
|
20
|
+
0. Read first, each if it exists — your durable lessons from prior dispatches ({{DOCTRINE:persist-insight}}): `{{PATH_MEMORY}}/agents/<your-name>.md`, then the feedback notes `{{PATH_NOTES}}/agent-notes/<your-name>.md` and `{{PATH_NOTES}}/agent-notes/_general.md`, then this repo's `{{PATH_PROJECT_NOTES}}/agent-notes/<your-name>.md` and `_general.md` there, which win where they disagree.
|
|
21
21
|
1. Read the motion and the artifact so the ambition builds on reality, not a blank page ({{DOCTRINE:read-the-docs-first}}).
|
|
22
22
|
2. Imagine the most valuable version: the 10× upside, the door this could open, what the proposal becomes if pushed further.
|
|
23
23
|
3. Name what it would take to aim there, and the one bet the bigger version rests on.
|
package/src/bricks/pr-open.md
CHANGED
|
@@ -5,8 +5,9 @@ effect: read
|
|
|
5
5
|
skill: ship
|
|
6
6
|
outcomes: pass, fail
|
|
7
7
|
---
|
|
8
|
-
Follow the `ship` skill's pull-request path only: never merge, never enable auto-merge
|
|
9
|
-
|
|
8
|
+
Follow the `ship` skill's pull-request path only: never merge, never enable auto-merge here (the
|
|
9
|
+
`factory` skill's close step arms it, only as the user's standing rule allows), never push to any
|
|
10
|
+
branch but this worktree's own. First look for a PR already open on this branch
|
|
10
11
|
(`gh pr view --json url,state` or `glab mr view`): after a rework lap it exists, and this stage
|
|
11
12
|
only pushes the new commits to it.
|
|
12
13
|
|
package/src/doctrines/ops.md
CHANGED
|
@@ -65,8 +65,8 @@ form is reconciled — not the principal file alone, but the imports, hooks,
|
|
|
65
65
|
indices, cross-links, ignore-rules, and peer configs that point to it. A dangling
|
|
66
66
|
reference left behind breaks downstream in silence, long after the deed seemed
|
|
67
67
|
done. Before declaring a teardown complete, hunt each integration point and sever
|
|
68
|
-
or rewire it ({{DOCTRINE:search-before-creating}}
|
|
69
|
-
remove
|
|
68
|
+
or rewire it. A search first finds what already exists ({{DOCTRINE:search-before-creating}}); this
|
|
69
|
+
finishes what you remove. Total teardown, or none.
|
|
70
70
|
<!-- LEAN:else -->
|
|
71
71
|
A delete, a rename, or a move is finished only when every reference to the old form is
|
|
72
72
|
reconciled — imports, hooks, indices, cross-links, ignore-rules, peer configs. Before
|