geneseed 4.9.4 → 4.14.0

package/js/hosts/installs.mjs

@@ -36,7 +36,7 @@ import { existsSync, readdirSync } from 'node:fs';
 import path from 'node:path';
 
 import {
-  CONFIG, GATE_SWITCHES, PACK_ORDER, THEMES, discoverNames, resolveSkillNames,
+  CONFIG, GATE_SWITCHES, PACK_ORDER, RETIRED_KIT_IDS, THEMES, discoverNames, loadKits, resolveSkillNames,
 } from '../build/source.mjs';
 import {
   CLAUDE_STYLE, DISABLED_STASH, GLOBAL_MANIFEST, HOSTS, isHostGlobalDir, liveRecordedHooks,
@@ -585,6 +585,33 @@ export function excludedSkillsOfDir(d, host = null, notify = null) {
   }, [], host);
 }
 
+/** `Active kits: spring-boot` — written only when a kit is on; the skills line's shape. */
+const KITS_RE = /^Active kits:[ \t]*(.+?)[ \t]*$/m;
+
+/**
+ * The kits a DEPLOYED install has on, read back so `rebuild-all`, `upgrade`, `migrate`, `diff`, the wizard
+ * and the console re-render them (spec A3). A missing line is `[]`: no kits, the old install's
+ * state. Unlike `excludedSkillsOfDir`, a name this checkout does not ship drops ALONE, with a
+ * notice (spec R2): a retired kit must never reach `--kits`, which refuses it and would fail the
+ * whole `rebuild-all`, and the kits beside it are still the owner's choice. Silent without `notify`.
+ */
+export function kitsOfDir(d, host = null, notify = null) {
+  return firstCarrier(d, (carrierPath) => {
+    const text = readMaybe(carrierPath);
+    if (text === null) return undefined;
+    const m = KITS_RE.exec(text);
+    if (!m) return undefined;
+    const known = loadKits();
+    const names = [...new Set(m[1].split(',').map((s) => s.trim()).filter(Boolean))].sort();
+    for (const k of names.filter((n) => !known.has(n))) {
+      notify?.(Object.hasOwn(RETIRED_KIT_IDS, k)
+        ? `kit '${k}' was retired (${RETIRED_KIT_IDS[k]}) — dropped`
+        : `kit '${k}' is not shipped by this Geneseed — dropped`);
+    }
+    return names.filter((n) => known.has(n));
+  }, [], host);
+}
+
 /**
  * Whether a DEPLOYED install keeps one law's hook gate armed — `true` (armed) or `false` (its
  * `<marker>: off` line, written by a build with that gate's `--no-*-gate` flag; `GATE_SWITCHES`).
@@ -861,7 +888,7 @@ export function installsReferencingShim(shimPath = hookShimPath(), targets = ins
 export function installedDefaults() {
   const found = {
     theme: null, posture: null, mode: null, emit: null, footprint: null, doctrines: null,
-    excludeRules: null, excludeSkills: null,
+    excludeRules: null, excludeSkills: null, kits: null,
   };
   const candidates = [];
   for (const { host, configDir } of HOSTS) {
@@ -904,6 +931,12 @@ export function installedDefaults() {
     // indistinguishable here, which is exactly what the marker itself already says.
     if (!found.excludeRules?.length) found.excludeRules = excludedRulesOfDir(base);
     if (!found.excludeSkills?.length) found.excludeSkills = excludedSkillsOfDir(base);
+    // Kits walk the same two-state way: no line and `none` both read `[]`.
+    // A broken manifest must not crash the wizard here: the build that follows still fails loudly
+    // in `loadKits`. Not guarded inside `kitsOfDir`, which rebuild-all must keep failing on.
+    if (!found.kits?.length) {
+      try { found.kits = kitsOfDir(base); } catch { found.kits = []; }
+    }
   }
   return found;
 }

package/js/hosts/link.mjs

@@ -74,6 +74,7 @@
 import {
   chmodSync, existsSync, lstatSync, mkdirSync, readlinkSync, rmSync,
 } from 'node:fs';
+import { isatty } from 'node:tty';
 import { spawnSync } from 'node:child_process';
 import path from 'node:path';
 import os from 'node:os';
@@ -81,12 +82,84 @@ import os from 'node:os';
 import { ROOT } from '../build/source.mjs';
 import { readMaybe } from './installs.mjs';
 import { printOut, printErr, writeText } from '../lib/fs.mjs';
+import { confirm } from '../lib/prompt.mjs';
 import { toPlatformPath, which } from '../lib/paths.mjs';
 
 const IS_WIN = process.platform === 'win32';
 /** What `cmdUnlink` recognises a written Unix launcher by — see `isOurLauncher`. */
 const SHIM_MARKER = 'GENESEED_LINK_SHIM';
 
+/** The lines that open and close the PATH block `link` writes into a shell startup file. */
+const RC_BEGIN = '# >>> geneseed >>> (added by `geneseed link`; `geneseed unlink` removes it)';
+const RC_END = '# <<< geneseed <<<';
+
+/**
+ * The startup file to put the bin dir on PATH in, for this login shell — or null when it is
+ * not one we know how to edit (fish, csh, none), where `link` prints the line instead.
+ *
+ * zsh reads `$ZDOTDIR/.zshrc` (default `~`). bash reads `~/.bashrc` on Linux, but macOS
+ * Terminal opens LOGIN shells, which read `~/.bash_profile` and not `~/.bashrc`. Pure, for the
+ * test: nothing here may touch the real user's files.
+ */
+export function shellRcFile({
+  shell = process.env.SHELL || '', home = os.homedir(), zdotdir = process.env.ZDOTDIR,
+  platform = process.platform,
+} = {}) {
+  const name = path.basename(shell);
+  if (name === 'zsh') return path.join(zdotdir || home, '.zshrc');
+  if (name === 'bash') return path.join(home, platform === 'darwin' ? '.bash_profile' : '.bashrc');
+  return null;
+}
+
+/**
+ * `text` with the PATH block for `dir` appended, or unchanged when a block is already there.
+ *
+ * The dir goes inside double quotes with `\`, `"`, `$` and backtick escaped, so a home path
+ * holding any of them stays one literal word to the shell rather than becoming code.
+ */
+export function withPathBlock(text, dir) {
+  if (text.includes(RC_BEGIN)) return text;
+  const quoted = dir.replace(/[\\"$`]/g, (c) => `\\${c}`);
+  const sep = text === '' || text.endsWith('\n') ? '' : '\n';
+  return `${text}${sep}${RC_BEGIN}\nexport PATH="${quoted}:$PATH"\n${RC_END}\n`;
+}
+
+/** `text` without the PATH block `withPathBlock` wrote; unchanged when there is none. */
+export function withoutPathBlock(text) {
+  const start = text.indexOf(RC_BEGIN);
+  if (start < 0) return text;
+  const end = text.indexOf(RC_END, start);
+  if (end < 0) return text;
+  let stop = end + RC_END.length;
+  if (text[stop] === '\n') stop += 1;
+  return text.slice(0, start) + text.slice(stop);
+}
+
+/**
+ * Put `dir` on PATH for future shells, ASKING first — macOS zsh does not search
+ * `~/.local/bin`, so a linked `geneseed` was not found (reported 2026-10). Only in a terminal:
+ * the web console's button and every test run without one, and get the printed line instead,
+ * so no gate can edit the developer's own startup file. Returns whether it wrote.
+ */
+function offerShellPath(dir) {
+  const rc = shellRcFile();
+  if (!rc || !isatty(0)) return false;
+  const text = readMaybe(rc) ?? '';
+  if (text.includes(RC_BEGIN)) {
+    printOut(`geneseed: ${rc} already adds it — open a NEW terminal, then run 'geneseed'.\n`);
+    return true;
+  }
+  if (!confirm(`geneseed: add '${dir}' to your PATH in ${rc}?`, true)) return false;
+  try {
+    writeText(rc, withPathBlock(text, dir));
+  } catch (e) {
+    printErr(`geneseed: could not write ${rc} (${asOsError(e)})\n`);
+    return false;
+  }
+  printOut(`geneseed: added it to ${rc} — open a NEW terminal, then run 'geneseed'.\n`);
+  return true;
+}
+
 /** `_harness_lifecycle._win_bin_dir`. */
 function winBinDir() {
   // `os.environ.get(...) or str(Path.home())` — an EMPTY LOCALAPPDATA falls back too,
@@ -267,7 +340,7 @@ export function cmdLink(args) {
   printOut(`geneseed: linked ${dest} -> ${entry}\n`);
   if ((process.env.PATH || '').split(path.delimiter).includes(targetDir)) {
     printOut(`geneseed: '${targetDir}' is on PATH — run 'geneseed' from anywhere.\n`);
-  } else {
+  } else if (!offerShellPath(targetDir)) {
     printOut(`geneseed: NOTE '${targetDir}' is not on your PATH. Add it, e.g.:\n`);
     printOut(`  echo 'export PATH="${targetDir}:$PATH"' >> ~/.zshrc   # or ~/.bashrc\n`);
   }
@@ -311,6 +384,20 @@ export function cmdUnlink() {
       } catch { /* `except OSError: pass` */ }
     }
   }
+  // The PATH block `link` may have written, from each startup file it could have chosen.
+  const home = os.homedir();
+  const rcs = new Set([shellRcFile({ shell: 'zsh' }), path.join(home, '.bashrc'),
+    path.join(home, '.bash_profile')]);
+  for (const rc of rcs) {
+    const text = readMaybe(rc);
+    if (text === null || withoutPathBlock(text) === text) continue;
+    try {
+      writeText(rc, withoutPathBlock(text));
+      printOut(`geneseed: removed the PATH line from ${rc}\n`);
+    } catch (e) {
+      printErr(`geneseed: could not edit ${rc} (${asOsError(e)})\n`);
+    }
+  }
   if (!removed) printOut('geneseed: no linked launcher found on PATH\n');
   return 0;
 }

package/js/hosts/native.mjs

@@ -579,7 +579,7 @@ export function writeNativeLayer(items, agentsDir, skillsDir, overrides = null,
   let nAgents = 0;
   let nSkills = 0;
   const written = [];
-  const sideFiles = [];            // [stem, dest, text], written after the loop
+  const sideFiles = [];            // [stem, dest, text, source], written after the loop
   const claimedSkills = new Set(); // stems whose own SKILL.md claim held
   const userOnlySkills = [];       // claimed stems carrying the user-only marker
 
@@ -589,7 +589,13 @@ export function writeNativeLayer(items, agentsDir, skillsDir, overrides = null,
     written.push(dest);
   };
 
-  for (const { text, src: source } of items) {
+  for (const { text, src: source, rel, licenceOf } of items) {
+    // A credited skill's upstream licence: copied verbatim beside its SKILL.md, held like a side
+    // file until that claim holds. Routed by `licenceOf`, since `source` is the upstream's file.
+    if (licenceOf) {
+      sideFiles.push([licenceOf, path.join(skillsDir, licenceOf, path.posix.basename(rel)), null, source]);
+      continue;
+    }
     const sparts = relPosix(src, source).split('/');
 
     // Vendored third-party skill folders ride along verbatim, preserving their own
@@ -706,8 +712,12 @@ export function writeNativeLayer(items, agentsDir, skillsDir, overrides = null,
     if (kind === 'agent') nAgents += 1;
     else nSkills += 1;
   }
-  for (const [stem, dest, text] of sideFiles) {
-    if (claimedSkills.has(stem) && claim(dest)) write(dest, stripSkillBodyLinks(text));
+  for (const [stem, dest, text, source] of sideFiles) {
+    if (!claimedSkills.has(stem) || !claim(dest)) continue;
+    if (text !== null) { write(dest, stripSkillBodyLinks(text)); continue; }
+    mkdirSync(path.dirname(dest), { recursive: true });
+    copyFile(source, dest);
+    written.push(dest);
   }
   return { nAgents, nSkills, written, userOnlySkills };
 }

package/js/inspect/checks-authoring.mjs

@@ -21,11 +21,11 @@ import { blankCodeSpans } from '../lib/text.mjs';
 import { which } from '../lib/paths.mjs';
 import { NO_WINDOW } from '../lib/proc.mjs';
 import {
-  aliasProblems, folderSkillProblems, registryProblems, secretProblems, sideFileProblems,
+  aliasProblems, creditProblems, folderSkillProblems, registryProblems, secretProblems, sideFileProblems,
   vendorPinProblems,
 } from './checks-repo.mjs';
 import { constitutionProblems, leanBlockProblems } from './checks-constitution.mjs';
-import { countTableProblems } from './checks-counts.mjs';
+import { countTableProblems, kitProblems } from './checks-counts.mjs';
 import { catalogProblems } from '../loop/catalog.mjs';
 import { globSorted, isDir, isFile, rglob } from './scan.mjs';
 import { spawnSync } from 'node:child_process';
@@ -55,6 +55,7 @@ const ALLOWED_COMMENT_RES = [
   // js/web/docs.mjs HARNESS_OPEN_RE: `harness:` then one or more of its four ids, comma-separated.
   new RegExp(`^harness:\\s*(?:${HARNESS_IDS})(?:\\s*,\\s*(?:${HARNESS_IDS}))*$`),
   /^bash:\s*allow$/,                         // js/hosts/native.mjs BASH_MARKER
+  /^banned: ok$/,                            // checks-counts.mjs kitProblems: a kit line that names a banned string
 ];
 
 /**
@@ -114,7 +115,7 @@ export function authorNoteProblems(src = SRC) {
 export {
   HOOK_PINNED, constitutionProblems, doctrineMetaProblems, lawMetaProblems, leanBlockProblems,
 } from './checks-constitution.mjs';
-export { countTableProblems, proseMirrorProblems } from './checks-counts.mjs';
+export { countTableProblems, kitProblems, proseMirrorProblems } from './checks-counts.mjs';
 
 /**
  * The shipped loop catalogue parses and every shipped template passes the engine's own graph
@@ -192,10 +193,12 @@ export function authoringProblems() {
   problems.push(...vendorPinProblems());
   problems.push(...folderSkillProblems());
   problems.push(...aliasProblems());
+  problems.push(...creditProblems());
   problems.push(...sideFileProblems());
   problems.push(...constitutionProblems());
   problems.push(...leanBlockProblems());
   problems.push(...countTableProblems());
+  problems.push(...kitProblems());
   problems.push(...authorNoteProblems());
   return problems;
 }

package/js/inspect/checks-build.mjs

@@ -9,8 +9,8 @@
 import path from 'node:path';
 import { stripCapabilityLinks } from '../build/emit-common.mjs';
 import { STRUCTURE, renderAll } from '../build/render.mjs';
-import { CONFIG, makeCfg } from '../build/source.mjs';
-import { hostCatalogsNatively, resolvePath } from '../hosts/hosts.mjs';
+import { CONFIG, CREDIT_RE, makeCfg } from '../build/source.mjs';
+import { CLAUDE_STYLE, hostCatalogsNatively, resolvePath } from '../hosts/hosts.mjs';
 import { EMIT_HOST_SCOPE, footprintOfDir, themeFiles } from '../hosts/installs.mjs';
 import { isVendoredPath } from '../hosts/native.mjs';
 import { PALETTE_ROLES, colorThemeFiles } from '../hosts/opencode.mjs';
@@ -80,6 +80,12 @@ export function checkBuild(themeName, out, isVendored = isVendoredPath) {
     for (const tok of sortedUnique(text.match(TOKEN_RE) ?? [])) {
       problems.push(`[${themeName}] unresolved token ${tok} in ${rel}`);
     }
+    // `TOKEN_RE` cannot see a credit (colon, lowercase key): one left standing names no upstream.
+    if (text.includes('{{CREDIT:')) {
+      for (const tok of sortedUnique(text.match(CREDIT_RE) ?? ['{{CREDIT:'])) {
+        problems.push(`[${themeName}] unresolved token ${tok} in ${rel}`);
+      }
+    }
     for (const p of linkProblems(md, text, outAbs, rel)) problems.push(`[${themeName}] ${p}`);
     for (const p of descriptionProblems(text, rel)) problems.push(`[${themeName}] ${p}`);
   }
@@ -211,7 +217,13 @@ export function renderedProblems(bundle) {
   else themeName = 'neutral';
   let emit;
   try { emit = readText(path.join(bundle, '.geneseed-emit')).trim(); } catch { emit = ''; }
-  const host = (EMIT_HOST_SCOPE.get(emit) ?? ['', ''])[0];
+  const [host, scope] = EMIT_HOST_SCOPE.get(emit) ?? ['', ''];
+  // A Claude-shaped PROJECT install is not a bundle: its tree is `AGENTS.md`/`CLAUDE.md` plus a
+  // `.bob/`/`.claude/`/`.openclaude/` data dir, so every rendered file reads "missing" and no
+  // rebuild can clear it. The console's onboarding once put a Bob project install exactly here
+  // (`./Harness` under the checkout, reported 2026-10: 178 such lines). Its own drift is
+  // `geneseed diff`'s and `status`'s to report, not this committed-bundle check's.
+  if (scope === 'project' && CLAUDE_STYLE.includes(host)) return [];
   let items;
   try {
     // THE FIRST CALLER IN THE PORT THAT CATCHES A REFUSAL, and that is why the stderr is

package/js/inspect/checks-counts.mjs

@@ -7,7 +7,10 @@
  * is the reader that feeds it.
  */
 import path from 'node:path';
-import { DOCS, DOC_FOLDERS, PLUGIN_SRC, ROOT, SRC, ruleCanon } from '../build/source.mjs';
+import {
+  DOCS, DOC_FOLDERS, PLUGIN_SRC, RETIRED_KIT_IDS, ROOT, SRC, kitMembers, loadKits, makeCfg, ruleCanon, specLinks, upstreams,
+} from '../build/source.mjs';
+import { effectiveTheme, renderFile } from '../build/render.mjs';
 import { themeFiles } from '../hosts/installs.mjs';
 import { readText } from '../lib/fs.mjs';
 import { formatRepr } from '../lib/json.mjs';
@@ -25,7 +28,7 @@ import { existsSync, readdirSync } from 'node:fs';
  * so they drift silently — they already had. Pure over its inputs, so the corpus can feed it
  * crafted drift without touching the tree.
  */
-export function proseMirrorProblems(readme, web, counts, skillStems, shipped = '') {
+export function proseMirrorProblems(readme, web, counts, skillStems, shipped = '', upstreamKeys = undefined) {
   const problems = [];
   const { laws, agents, skills, plugins } = counts;
 
@@ -68,6 +71,32 @@ export function proseMirrorProblems(readme, web, counts, skillStems, shipped = '
     }
   }
 
+  // The README Credits section names EXACTLY the `src/upstreams.json` keys, both directions,
+  // as the skills row does. A missing section is a problem, or deleting it would turn the gate
+  // green. `upstreamKeys` is optional, like `plugins`, because the corpus predates it.
+  if (upstreamKeys !== undefined) {
+    const lines = readme.split('\n').map((ln) => ln.replace(/\r$/, ''));
+    const at = lines.findIndex((ln) => ln.trim() === '## 🙏 Credits');
+    if (at < 0) {
+      problems.push("[authoring] README has no '## 🙏 Credits' section — src/upstreams.json has "
+        + `${upstreamKeys.length} upstreams to credit`);
+    } else {
+      const end = lines.findIndex((ln, i) => i > at && ln.startsWith('## '));
+      const listed = new Set();
+      for (const ln of lines.slice(at + 1, end < 0 ? undefined : end).filter((l) => l.startsWith('- '))) {
+        const k = /^- `([^`]+)`/.exec(ln);
+        if (k) listed.add(k[1]);
+        else problems.push(`[authoring] README Credits bullet names no upstream key in backticks: '${ln}'`);
+      }
+      for (const key of [...upstreamKeys].filter((k) => !listed.has(k)).sort()) {
+        problems.push(`[authoring] README Credits omits upstream '${key}' (src/upstreams.json)`);
+      }
+      for (const key of [...listed].filter((k) => !upstreamKeys.includes(k)).sort()) {
+        problems.push(`[authoring] README Credits names '${key}', which src/upstreams.json does not define`);
+      }
+    }
+  }
+
   for (const m of web.matchAll(/(\d+) universal (?:laws|Rules)/g)) {
     if (Number(m[1]) !== laws) {
       problems.push(`[authoring] docs/ prose says '${m[1]} universal laws/Rules' but `
@@ -127,8 +156,13 @@ export function countTableProblems() {
     return [`[authoring] AGENT.md.tmpl unreadable: ${e.message}`];
   }
 
+  // A kit member's row lives in its kit's manifest, not the template (spec A6). A manifest that
+  // does not parse is `kitProblems`' to name; here it means no kit rows.
+  let kits;
+  try { kits = loadKits(); } catch { kits = new Map(); }
+  const kitRows = [...kits.values()].flatMap((m) => [...(m.catalogue?.skills ?? []), ...(m.catalogue?.agents ?? [])]);
   const linked = { agents: new Set(), skills: new Set() };
-  for (const m of ttext.matchAll(TMPL_SPEC_RE)) {
+  for (const m of [ttext, ...kitRows].join('\n').matchAll(TMPL_SPEC_RE)) {
     if (m[2] !== '_template') linked[m[1] === 'AGENTS' ? 'agents' : 'skills'].add(m[2]);
   }
   for (const folder of ['agents', 'skills']) {
@@ -173,11 +207,14 @@ export function countTableProblems() {
   // the SHIPPED.md triple count it. It is added HERE rather than in `srcStems`, whose other
   // readers above — the AGENT.md table links and SKILL_CLASS — are about flat specs only.
   const skillsDir = path.join(SRC, 'skills');
+  // Core only: a kit is off by default, so its members are in no badge, README list or SHIPPED triple.
+  const members = kitMembers(kits);
   const shippedSkills = new Set([...skillFiles, ...(isDir(skillsDir) ? readdirSync(skillsDir) : [])
-    .filter((d) => !d.startsWith('_') && isFile(path.join(skillsDir, d, 'SKILL.md')))]);
+    .filter((d) => !d.startsWith('_') && isFile(path.join(skillsDir, d, 'SKILL.md')))]
+    .filter((s) => !members.skills.has(s)));
 
   const counts = {
-    agents: srcStems('agents').size,
+    agents: [...srcStems('agents')].filter((a) => !members.agents.has(a)).length,
     skills: shippedSkills.size,
     laws: lawNums.length,
     // Every doctrine rule in every pack, opt-in ones included: the laws badge alone told a
@@ -242,6 +279,116 @@ export function countTableProblems() {
     problems.push('[authoring] SHIPPED.md carries no \'N laws, N agents, N skills\' line — '
       + 'deleting it is how that gate goes green while the count drifts');
   }
-  problems.push(...proseMirrorProblems(readme, web, counts, shippedSkills, shipped));
+  // A bad upstreams.json is creditProblems' to name; here it means no keys to hold the README to.
+  let upstreamKeys;
+  try { upstreamKeys = Object.keys(upstreams()); } catch { upstreamKeys = []; }
+  problems.push(...proseMirrorProblems(readme, web, counts, shippedSkills, shipped, upstreamKeys));
+  return problems;
+}
+
+/** The `.md` files directly in `d`, sorted; none for a missing folder. */
+const mdIn = (d) => { try { return readdirSync(d).filter((f) => f.endsWith('.md')).sort(); } catch { return []; } };
+
+/**
+ * The kit arm (spec A6, R3, R4, B7): each `src/kits/<kit>.json` against `src`. Refused: a
+ * manifest that does not parse or lacks `description`/`rules`/`skills`/`agents`; a reserved kit
+ * id (`RETIRED_KIT_IDS`); `rules` naming a missing file, or rendering (neutral theme) to more
+ * words than its `rulesWordBudget` (default 300); a member in two kits, or a core one (a row in
+ * AGENT.md.tmpl) — R3; a member with no spec (or a vendored folder skill) or no `registry.json` row; a catalogue row not of the shape `| [<m>]({{DIR_*}}/<m>.md) | <text> |`, or a member without exactly one; any `banned` string (manifest) in a member file or the rules, unless the line carries `<!-- banned: ok -->`; and a core file linking a
+ * kit member, which dangles with the kit off — R4. `registry.json` sits beside `src`, as at ROOT.
+ */
+export function kitProblems(src = SRC) {
+  let kits;
+  try { kits = loadKits(src); } catch (e) { return [`[authoring] ${e.message}`]; }
+  if (!kits.size) return [];
+  const problems = [];
+  const core = { agents: new Set(), skills: new Set() };
+  let tmpl = '';
+  try { tmpl = readText(path.join(src, 'AGENT.md.tmpl')); } catch { /* countTableProblems names it */ }
+  for (const m of tmpl.matchAll(TMPL_SPEC_RE)) core[m[1] === 'AGENTS' ? 'agents' : 'skills'].add(m[2]);
+  // null = no usable registry: `registryProblems` already names that (and every member it lacks a
+  // row for), so a member's missing row is only reported here when there IS an entities object.
+  let registry = null;
+  try { registry = JSON.parse(readText(path.join(path.dirname(src), 'registry.json'))).entities ?? null; } catch {
+    // registryProblems names an unreadable registry
+  }
+  const owner = new Map();
+  const cfg = { ...makeCfg(), src };
+  let theme = null;
+  for (const [kit, m] of kits) {
+    const at = `src/kits/${kit}.json`;
+    if (Object.hasOwn(RETIRED_KIT_IDS, kit)) {
+      problems.push(`[authoring] ${at}: kit id '${kit}' is reserved (${RETIRED_KIT_IDS[kit]})`);
+    }
+    const lacking = ['description', 'rules', 'skills', 'agents'].filter((k) => (
+      k === 'skills' || k === 'agents' ? !Array.isArray(m[k]) : typeof m[k] !== 'string'));
+    for (const k of lacking) problems.push(`[authoring] ${at} has no '${k}'`);
+    if (lacking.length) continue;
+    for (const kind of ['skills', 'agents']) {
+      for (const name of m[kind]) {
+        const key = `${kind}/${name}`;
+        if (owner.has(key)) problems.push(`[authoring] ${key} is in two kits: '${owner.get(key)}' and '${kit}'`);
+        else owner.set(key, kit);
+        if (core[kind].has(name)) problems.push(`[authoring] ${key} is core (AGENT.md.tmpl lists it), but kit '${kit}' claims it`);
+        if (!isFile(path.join(src, kind, `${name}.md`))) {
+          problems.push(kind === 'skills' && isFile(path.join(src, kind, name, 'SKILL.md'))
+            ? `[authoring] kit '${kit}' lists ${name}, a vendored folder skill; kit members must be flat specs`
+            : `[authoring] kit '${kit}' lists ${key}, but src/${key}.md does not exist`);
+        }
+        if (registry !== null && !Object.hasOwn(registry, key)) problems.push(`[authoring] ${key} (kit '${kit}') has no row in registry.json`);
+      }
+    }
+    // A6: a kit's catalogue rows are its own members' — a core row here would show twice with the
+    // kit on, or vanish with it off. Each row is `| [<m>]({{DIR_*}}/<m>.md) | <text> |`, one per member.
+    for (const kind of ['skills', 'agents']) {
+      const dir = kind === 'skills' ? 'SKILLS' : 'AGENTS';
+      const seen = new Map();
+      for (const row of m.catalogue?.[kind] ?? []) {
+        const hit = new RegExp(`^\\| \\[([a-z0-9-]+)\\]\\(\\{\\{DIR_${dir}\\}\\}/\\1\\.md\\) \\| \\S.* \\|$`).exec(row);
+        const named = hit?.[1] ?? row.match(/\{\{DIR_(?:AGENTS|SKILLS)\}\}\/([A-Za-z0-9_-]+)\.md/)?.[1];
+        if (named && !m[kind].includes(named)) {
+          problems.push(`[authoring] ${at} catalogue lists ${kind}/${named}, which is not a member of kit '${kit}'`);
+        } else if (!hit) {
+          problems.push(`[authoring] ${at} catalogue.${kind} row is not \`| [<member>]({{DIR_${dir}}}/<member>.md) | <text> |\`: ${row}`);
+        } else seen.set(named, (seen.get(named) ?? 0) + 1);
+      }
+      for (const name of m[kind]) {
+        const n = seen.get(name) ?? 0;
+        if (n !== 1) problems.push(`[authoring] ${at} catalogue.${kind} has ${n} rows for ${name}, want exactly one`);
+      }
+    }
+    // T4: strings no member file may contain; a line carrying the marker is exempt (a rule that names the construct to forbid it).
+    const files = [m.rules, ...m.skills.flatMap((n) => [`skills/${n}.md`, ...mdIn(path.join(src, 'skills', n)).map((f) => `skills/${n}/${f}`)]),
+      ...m.agents.map((n) => `agents/${n}.md`)];
+    for (const rel of files) {
+      if (!isFile(path.join(src, rel))) continue;
+      readText(path.join(src, rel)).split('\n').forEach((line, i) => {
+        if (line.includes('<!-- banned: ok -->')) return;
+        for (const b of m.banned ?? []) if (line.includes(b)) problems.push(`[authoring] src/${rel}:${i + 1} contains '${b}', banned by kit '${kit}'`);
+      });
+    }
+    const rules = path.join(src, m.rules);
+    if (!isFile(rules)) {
+      problems.push(`[authoring] ${at}: rules '${m.rules}' does not exist`);
+      continue;
+    }
+    theme ??= effectiveTheme(cfg, 'neutral');
+    const words = renderFile(cfg, rules, theme).split(/\s+/).filter(Boolean).length;
+    const budget = m.rulesWordBudget ?? 300;
+    if (words > budget) {
+      problems.push(`[authoring] src/${m.rules} renders to ${words} words, over kit '${kit}' rulesWordBudget of ${budget}`);
+    }
+  }
+  // R4. A core member (R3, named above) is left out: every core file linking it would repeat that.
+  const r4 = new Set();
+  for (const l of specLinks(src)) {
+    // Links run kit -> core only: a core file, or ANOTHER kit's file, linking a member dangles
+    // whenever that member's kit is off.
+    if (!l.owner || l.kit === l.owner || core[l.kind].has(l.name)) continue;
+    r4.add(l.kit
+      ? `[authoring] src/${l.rel} (kit '${l.kit}') links ${l.kind}/${l.name}, a member of kit '${l.owner}' — links run kit → core only`
+      : `[authoring] src/${l.rel} links ${l.kind}/${l.name}, a kit member — the link dangles when the kit is off`);
+  }
+  problems.push(...r4);
   return problems;
 }