geneseed 3.1.3 → 3.3.0

package/js/hosts/native.mjs

@@ -149,6 +149,20 @@ function isReadonly(text) {
   return text.includes('Read-only');
 }
 
+/**
+ * A skill only the USER may open. The marker is an HTML comment in the source spec
+ * (`<!-- invocation: user -->`, placed under the purpose blockquote), and it renders to
+ * Claude Code's `disable-model-invocation: true`: the skill still answers `/name`, but its
+ * description leaves the model's always-on catalogue and the model never self-triggers it.
+ * Same precedent as `isReadonly` — a phrase in the spec, not a second manifest to keep in
+ * step. Which skills carry it is an authoring decision: the teaching skills a human runs on
+ * themselves, and the ones gated on an environment the model cannot see (a herdr pane).
+ */
+const USER_INVOKED_RE = /<!--\s*invocation:\s*user\s*-->/;
+export function isUserInvokedOnly(text) {
+  return USER_INVOKED_RE.test(text);
+}
+
 /** `_build_emit._strip_skill_body_links`. */
 export function stripSkillBodyLinks(body) {
   return body.replace(SKILL_BODY_LINK_RE, '$1');
@@ -173,14 +187,14 @@ function agentColorMap(theme) {
       cleaned[k] = 'secondary';
     }
   }
-  if (!Object.prototype.hasOwnProperty.call(cleaned, '_default')) cleaned._default = 'secondary';
+  if (!Object.hasOwn(cleaned, '_default')) cleaned._default = 'secondary';
   return cleaned;
 }
 
 /** `_build_emit._agent_color`. */
 function agentColor(stem, theme) {
   const colors = agentColorMap(theme);
-  return Object.prototype.hasOwnProperty.call(colors, stem) ? colors[stem] : colors._default;
+  return Object.hasOwn(colors, stem) ? colors[stem] : colors._default;
 }
 
 function isPlainObject(v) {
@@ -195,7 +209,7 @@ function given(v) {
 /**
  * `overrides.get(stem) or {}`.
  *
- * The `hasOwnProperty` guard is not ceremony: a bare `overrides[stem]` reaches
+ * The `Object.hasOwn` guard is not ceremony: a bare `overrides[stem]` reaches
  * `Object.prototype` for an agent named `constructor`, `toString` or `valueOf`, and would
  * hand back a function where Python hands back `None`.
  *
@@ -206,7 +220,7 @@ function given(v) {
  * difference on any path the gate covers — a difference in which malformed input crashes.
  */
 function agentOverride(overrides, stem) {
-  return (Object.prototype.hasOwnProperty.call(overrides, stem) && overrides[stem]) || {};
+  return (Object.hasOwn(overrides, stem) && overrides[stem]) || {};
 }
 
 /**
@@ -230,30 +244,48 @@ export function pushOverrideLines(fm, ov) {
   if (given(ov.steps)) fm.push(`steps: ${formatValue(ov.steps)}`);
 }
 
-/** `_build_emit._claude_agent_frontmatter`. */
-function claudeAgentFrontmatter(stem, text, overrides) {
+/**
+ * The readonly-tool line `claudeAgentFrontmatter`/`copilotAgentFrontmatter` each emit — a
+ * DENYLIST for Claude, an ALLOWLIST for Copilot — differing only in the key, the base list,
+ * the one extra entry the `<!-- bash: allow -->` marker toggles, and whether the value is
+ * bracketed. `extraWhenBashAllowed` is `false` for Claude (Bash is denied UNLESS the marker
+ * allows it) and `true` for Copilot (`execute` is allowed ONLY IF the marker is present) —
+ * the same marker, read in the opposite sense a denylist and an allowlist require.
+ */
+const READONLY_TOOLS = {
+  claude: {
+    key: 'disallowedTools', tools: ['Write', 'Edit', 'NotebookEdit', 'WebFetch'],
+    extra: 'Bash', extraWhenBashAllowed: false, brackets: false,
+  },
+  copilot: {
+    key: 'tools', tools: ['read', 'search', 'todo', 'agent'],
+    extra: 'execute', extraWhenBashAllowed: true, brackets: true,
+  },
+};
+
+/** `_build_emit._claude_agent_frontmatter` / `._copilot_agent_frontmatter`. */
+function claudeCopilotAgentFrontmatter(host, stem, text, overrides) {
   const fm = [`name: ${stem}`, `description: ${jsonDumps(descOf(text))}`];
   const ov = agentOverride(overrides, stem);
   if (isTruthy(ov.model)) fm.push(`model: ${formatValue(ov.model)}`);
   if (isReadonly(text)) {
-    const denied = ['Write', 'Edit', 'NotebookEdit', 'WebFetch'];
-    if (!text.includes('<!-- bash: allow -->')) denied.push('Bash');
-    fm.push(`disallowedTools: ${denied.join(', ')}`);
+    const {
+      key, tools, extra, extraWhenBashAllowed, brackets,
+    } = READONLY_TOOLS[host];
+    const list = [...tools];
+    if (text.includes('<!-- bash: allow -->') === extraWhenBashAllowed) list.push(extra);
+    fm.push(`${key}: ${brackets ? `[${list.join(', ')}]` : list.join(', ')}`);
   }
   return fm;
 }
 
-/** `_build_emit._copilot_agent_frontmatter` — `tools:` is an ALLOWLIST, not a denylist. */
+function claudeAgentFrontmatter(stem, text, overrides) {
+  return claudeCopilotAgentFrontmatter('claude', stem, text, overrides);
+}
+
+/** `tools:` is an ALLOWLIST, not a denylist. */
 function copilotAgentFrontmatter(stem, text, overrides) {
-  const fm = [`name: ${stem}`, `description: ${jsonDumps(descOf(text))}`];
-  const ov = agentOverride(overrides, stem);
-  if (isTruthy(ov.model)) fm.push(`model: ${formatValue(ov.model)}`);
-  if (isReadonly(text)) {
-    const allowed = ['read', 'search', 'todo', 'agent'];
-    if (text.includes('<!-- bash: allow -->')) allowed.push('execute');
-    fm.push(`tools: [${allowed.join(', ')}]`);
-  }
-  return fm;
+  return claudeCopilotAgentFrontmatter('copilot', stem, text, overrides);
 }
 
 /** `_build_emit._opencode_agent_frontmatter`. */
@@ -401,7 +433,10 @@ export function writeNativeLayer(items, agentsDir, skillsDir, overrides = null,
       kind = 'agent';
     } else {
       // Skills are BYTE-IDENTICAL across hosts: name + description, body link-stripped.
+      // The user-only key is emitted for every host too — Claude Code and Bob honour it,
+      // OpenCode and Copilot ignore an unknown key — so the identity holds.
       fm = [`name: ${stem}`, `description: ${jsonDumps(descOf(text))}`];
+      if (isUserInvokedOnly(text)) fm.push('disable-model-invocation: true');
       body = stripSkillBodyLinks(body);
       dest = path.join(skillsDir, stem, 'SKILL.md');
       kind = 'skill';

package/js/hosts/opencode.mjs

@@ -115,36 +115,47 @@ export function sourceReleaseVersion(cfg) {
   return '0.0.0';
 }
 
+const GRAY = 8;
+const GREEN = 2;
+const RED = 1;
+const YEL = 3;
+const MAG = 5;
+const NONE = 'none';
+
+/**
+ * `_build_emit._theme_json`'s role -> value map, one entry per `PALETTE_ROLES` member (19 —
+ * not the 17 the plan that asked for this derivation guessed; logged as a wrong-plan-claim
+ * row). `acc` is the one theme-tinted value; `fn` and `type` happen to share it today but are
+ * kept as their own role entries rather than aliased to `accent`, since nothing requires a
+ * future theme to tint them together.
+ *
+ * ONE SLOT IS NOT A PURE FUNCTION OF ITS ROLE, and folding it in here would be wrong rather
+ * than tidy: `syntaxPunctuation` carries role `fgMuted`, the same role as `textMuted`,
+ * `diffContext`, `diffLineNumber` and `markdownBlockQuote` — all four of which render GRAY —
+ * but `syntaxPunctuation` alone has always rendered NONE. A real asymmetry this theme has
+ * shipped with, reproduced below as a one-slot override rather than smoothed away, the same
+ * pattern `colorThemeJson` already uses for its own `TRANSPARENT_NONE` slots.
+ */
+const roleAnsi = (acc) => ({
+  accent: acc, secondary: MAG, err: RED, warn: YEL, ok: GREEN,
+  fg: NONE, fgMuted: GRAY, border: GRAY,
+  bg: NONE, bgPanel: NONE, bgElement: NONE, addBg: NONE, delBg: NONE,
+  comment: GRAY, kw: MAG, fn: acc, str: GREEN, num: MAG, type: acc,
+});
+
+/** The one slot `roleAnsi`'s role lookup gets wrong on its own — forced to NONE after. */
+const THEME_JSON_NONE_OVERRIDE = new Set(['syntaxPunctuation']);
+
 /** `_build_emit._theme_json` — a COMPLETE terminal-native theme tinted by ACCENT. */
 export function themeJson(theme) {
   const raw = theme && theme.ACCENT !== undefined ? theme.ACCENT : 'cyan';
   const key = String(raw).toLowerCase();
-  const acc = Object.prototype.hasOwnProperty.call(ANSI, key) ? ANSI[key] : 6;
-  const GRAY = 8;
-  const GREEN = 2;
-  const RED = 1;
-  const YEL = 3;
-  const MAG = 5;
-  const NONE = 'none';
-  const t = {
-    primary: acc, secondary: MAG, accent: acc,
-    error: RED, warning: YEL, success: GREEN, info: acc,
-    text: NONE, textMuted: GRAY,
-    background: NONE, backgroundPanel: NONE, backgroundElement: NONE,
-    border: GRAY, borderActive: acc, borderSubtle: GRAY,
-    diffAdded: GREEN, diffRemoved: RED, diffContext: GRAY,
-    diffHunkHeader: acc, diffHighlightAdded: GREEN, diffHighlightRemoved: RED,
-    diffAddedBg: NONE, diffRemovedBg: NONE, diffContextBg: NONE,
-    diffLineNumber: GRAY, diffAddedLineNumberBg: NONE, diffRemovedLineNumberBg: NONE,
-    markdownText: NONE, markdownHeading: acc, markdownLink: MAG,
-    markdownLinkText: acc, markdownCode: GREEN, markdownBlockQuote: GRAY,
-    markdownEmph: YEL, markdownStrong: YEL, markdownHorizontalRule: GRAY,
-    markdownListItem: acc, markdownListEnumeration: acc, markdownImage: MAG,
-    markdownImageText: acc, markdownCodeBlock: NONE,
-    syntaxComment: GRAY, syntaxKeyword: MAG, syntaxFunction: acc,
-    syntaxVariable: NONE, syntaxString: GREEN, syntaxNumber: MAG,
-    syntaxType: acc, syntaxOperator: MAG, syntaxPunctuation: NONE,
-  };
+  const acc = Object.hasOwn(ANSI, key) ? ANSI[key] : 6;
+  const roles = roleAnsi(acc);
+  const t = {};
+  for (const [slot, role] of Object.entries(SLOT_ROLE)) {
+    t[slot] = THEME_JSON_NONE_OVERRIDE.has(slot) ? NONE : roles[role];
+  }
   return { $schema: 'https://opencode.ai/theme.json', theme: t };
 }
 
@@ -177,7 +188,7 @@ export function colorThemeJson(palette, transparent) {
     // `palette[role]` is a plain subscript in Python: a palette missing a role raises
     // KeyError and aborts the emit. A bare JS lookup would yield undefined, which
     // JSON.stringify DROPS — silently emitting a theme with missing slots.
-    if (!Object.prototype.hasOwnProperty.call(palette, role)) {
+    if (!Object.hasOwn(palette, role)) {
       throw new Error(`palette has no role '${role}' (slot '${slot}')`);
     }
     t[slot] = palette[role];
@@ -257,7 +268,7 @@ export function writePrimaryAgent(cfg, agentsDir, overrides) {
   const desc = 'Primary orchestrator — works by the harness Rules and delegates to the '
     + 'capability subagents.';
   const fm = [`description: ${jsonDumps(desc)}`, 'mode: primary', 'color: primary'];
-  const ov = (Object.prototype.hasOwnProperty.call(overrides, 'orchestrator')
+  const ov = (Object.hasOwn(overrides, 'orchestrator')
     && overrides.orchestrator) || {};
   pushOverrideLines(fm, ov);
   const dest = path.join(agentsDir, 'orchestrator.md');