geneseed 3.1.1 → 3.1.2

package/js/{link.mjs → hosts/link.mjs}

@@ -38,11 +38,10 @@
  * have run, and inventing one writes a shim that names an interpreter the user may not have.
  * P5b settled this shape for the hook shim — "Node bakes node" — and P3a settled the gate:
  * the shim is byte-comparable once runner and entry are ARGUMENTS. So this bakes
- * `process.execPath` + `bin/geneseed-cli.mjs`, `tests/harness_golden.py` normalises the
- * shim's argv line the way `js/web/jobs.mjs` normalises the job runner's, and each side's
- * real content is asserted ABSOLUTELY in `tests/test_win_user_path.py`. A shim written by
- * the Node CLI reaches sixteen verbs rather than twenty-four; that is the cost of the port
- * being a port, and it disappears when P7 lands `tui`/`menu`/`home`.
+ * `process.execPath` + `bin/geneseed-cli.mjs`, the cell harness normalises the shim's argv
+ * line the way `js/web/jobs.mjs` normalises the job runner's, and the real content is
+ * asserted ABSOLUTELY in `tests/unit/win_user_path.test.mjs`. The shim reaches every verb in
+ * the `VERBS` table, `tui`/`menu`/`home` included since P7 — the gap the port opened is closed.
  *
  * THE DOUBLE CARRIAGE RETURN IS NOT A TYPO. The reference builds the shim with explicit
  * `\r\n` and writes it with `Path.write_text`, whose default newline handling then turns
@@ -67,9 +66,10 @@
  *     and the verb takes its "removed the shim, said nothing about PATH" branch. A real arm,
  *     reached honestly, with the registry untouched.
  *
- * THE SUCCESS ARM OF `winUserPath` IS THEREFORE UNGATED, DELIBERATELY, IN BOTH
- * IMPLEMENTATIONS — declared here rather than faked, because the only way to gate it is to
- * edit the machine running the gate.
+ * THE SUCCESS ARM OF `winUserPath` IS THEREFORE UNGATED, DELIBERATELY — declared here and
+ * in `tests/unit/win_user_path.test.mjs`'s coverage row rather than faked, because the only
+ * way to gate it is to edit the machine running the gate. What stands in for it is
+ * source-level: that file asserts the spawn's shape without running it.
  */
 import {
   chmodSync, existsSync, lstatSync, mkdirSync, readlinkSync, rmSync,
@@ -78,9 +78,10 @@ import { spawnSync } from 'node:child_process';
 import path from 'node:path';
 import os from 'node:os';
 
-import { ROOT } from './checkout.mjs';
+import { ROOT } from '../build/source.mjs';
 import { readMaybe } from './installs.mjs';
-import { pyPathStr, pyPrint, pyPrintErr, writeText } from './lib/fs.mjs';
+import { printOut, printErr, writeText } from '../lib/fs.mjs';
+import { toPlatformPath } from '../lib/paths.mjs';
 
 const IS_WIN = process.platform === 'win32';
 
@@ -154,28 +155,28 @@ export function cmdLink(args) {
       writeText(shim, '@echo off\r\n'
         + `"${process.execPath}" "${path.join(here, 'bin', 'geneseed-cli.mjs')}" %*\r\n`);
     } catch (e) {
-      pyPrintErr(`geneseed: could not write ${shim} (${pyOsError(e)})\n`);
+      printErr(`geneseed: could not write ${shim} (${asOsError(e)})\n`);
       return 1;
     }
-    pyPrint(`geneseed: wrote shim ${shim}\n`);
+    printOut(`geneseed: wrote shim ${shim}\n`);
     const on_path = (process.env.PATH || '').toLowerCase().includes(bindir.toLowerCase());
     if (on_path || winUserPath('add', bindir)) {
-      pyPrint(`geneseed: '${bindir}' is on your user PATH — open a NEW terminal, then run \`geneseed\`.\n`);
+      printOut(`geneseed: '${bindir}' is on your user PATH — open a NEW terminal, then run \`geneseed\`.\n`);
     } else {
-      pyPrint(`geneseed: add '${bindir}' to your PATH manually, then run \`geneseed\` from anywhere.\n`);
+      printOut(`geneseed: add '${bindir}' to your PATH manually, then run \`geneseed\` from anywhere.\n`);
     }
     return 0;
   }
   // Unix: write a shim into a bin dir (default ~/.local/bin, no sudo). See the shim
   // comment below for why this is no longer a symlink to `ROOT/geneseed`.
-  // `Path(args.dir)` — and `pyPathStr` is that conversion, not decoration. The reference
+  // `Path(args.dir)` — and `toPlatformPath` is that conversion, not decoration. The reference
   // builds a `Path` here and prints `str(target_dir)` twice (the PATH notice and the `export
   // PATH=` line) as well as comparing it against `PATH.split(os.pathsep)`, so an argument
   // that is not already normalised diverges in three places at once. A trailing slash is the
   // cheapest one: `str(Path('/x/bin/'))` is `/x/bin` and the raw string is not.
   // `harness_golden`'s `link/an-explicit-dir-argument-is-used-instead-of-the-default` passes
   // one, and it is the cell that found this.
-  let targetDir = args.dir ? pyPathStr(args.dir) : null;
+  let targetDir = args.dir ? toPlatformPath(args.dir) : null;
   if (targetDir === null) {
     const local = path.join(os.homedir(), '.local', 'bin');
     try {
@@ -202,16 +203,16 @@ export function cmdLink(args) {
       + `exec "${process.execPath}" "${entry}" "$@"\n`);
     chmodSync(dest, 0o755);
   } catch (e) {
-    pyPrintErr(`geneseed: could not write ${dest} (${pyOsError(e)}) — pick a writable dir: `
+    printErr(`geneseed: could not write ${dest} (${asOsError(e)}) — pick a writable dir: `
       + 'geneseed link <dir>\n');
     return 1;
   }
-  pyPrint(`geneseed: linked ${dest} -> ${entry}\n`);
+  printOut(`geneseed: linked ${dest} -> ${entry}\n`);
   if ((process.env.PATH || '').split(path.delimiter).includes(targetDir)) {
-    pyPrint(`geneseed: '${targetDir}' is on PATH — run 'geneseed' from anywhere.\n`);
+    printOut(`geneseed: '${targetDir}' is on PATH — run 'geneseed' from anywhere.\n`);
   } else {
-    pyPrint(`geneseed: NOTE '${targetDir}' is not on your PATH. Add it, e.g.:\n`);
-    pyPrint(`  echo 'export PATH="${targetDir}:$PATH"' >> ~/.zshrc   # or ~/.bashrc\n`);
+    printOut(`geneseed: NOTE '${targetDir}' is not on your PATH. Add it, e.g.:\n`);
+    printOut(`  echo 'export PATH="${targetDir}:$PATH"' >> ~/.zshrc   # or ~/.bashrc\n`);
   }
   return 0;
 }
@@ -226,15 +227,15 @@ export function cmdUnlink() {
       try {
         rmSync(shim);
         removed = true;
-        pyPrint(`geneseed: removed ${shim}\n`);
+        printOut(`geneseed: removed ${shim}\n`);
       } catch (e) {
-        pyPrintErr(`geneseed: could not remove ${shim} (${pyOsError(e)})\n`);
+        printErr(`geneseed: could not remove ${shim} (${asOsError(e)})\n`);
       }
     }
     if (winUserPath('remove', bindir)) {
-      pyPrint(`geneseed: removed '${bindir}' from your user PATH (open a new terminal).\n`);
+      printOut(`geneseed: removed '${bindir}' from your user PATH (open a new terminal).\n`);
     }
-    if (!removed) pyPrint('geneseed: no linked launcher found.\n');
+    if (!removed) printOut('geneseed: no linked launcher found.\n');
     return 0;
   }
   let removed = false;
@@ -256,12 +257,12 @@ export function cmdUnlink() {
     if (ours) {
       try {
         rmSync(f);
-        pyPrint(`geneseed: removed ${f}\n`);
+        printOut(`geneseed: removed ${f}\n`);
         removed = true;
       } catch { /* `except OSError: pass` */ }
     }
   }
-  if (!removed) pyPrint('geneseed: no linked launcher found on PATH\n');
+  if (!removed) printOut('geneseed: no linked launcher found on PATH\n');
   return 0;
 }
 
@@ -281,6 +282,6 @@ function isSymlink(p) {
  * in a different order. Not byte-reproducible and not worth pretending otherwise: both cells
  * that can reach it assert the arm, not the errno text.
  */
-function pyOsError(e) {
+function asOsError(e) {
   return e && e.message ? e.message : String(e);
 }

package/js/{mcp.mjs → hosts/mcp.mjs}

@@ -24,7 +24,7 @@
  * `1` on the way back out. `readJsonc` already learned this; the strict-JSON fork has to
  * learn it separately, because it does not go through `readJsonc` at all.
  *
- * A PyNumber IS AN OBJECT TO `typeof`, which is why `isDict` is spelled out rather than
+ * A JsonNumber IS AN OBJECT TO `typeof`, which is why `isDict` is spelled out rather than
  * written as `typeof v === 'object'`. Python's `isinstance(x, dict)` is false for a float;
  * the JS twin has to be false for its wrapper.
  */
@@ -32,10 +32,11 @@ import { existsSync, mkdirSync, renameSync } from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
 
-import { bobConfigDir, copilotConfigDir, pyResolve } from './hosts.mjs';
+import { bobConfigDir, copilotConfigDir, resolvePath } from './hosts.mjs';
 import { installState, installTargets } from './installs.mjs';
-import { jsonDumpsIndent, parseJson, pyLjust, pyPrint, pyPrintErr, readText, writeText }
-  from './lib/fs.mjs';
+import { printOut, printErr, readText, writeText } from '../lib/fs.mjs';
+import { jsonDumpsIndent, parseJson } from '../lib/json.mjs';
+import { padEndToWidth } from '../lib/text.mjs';
 import { opencodeTarget, readJsonc } from './settings.mjs';
 
 /**
@@ -240,7 +241,7 @@ export function mcpConfigFor(host, scope, root) {
   if (host === 'opencode') return opencodeTarget(path.join(root, 'opencode.json'));
   if (host === 'claude') {
     return scope === 'project' ? path.join(root, '.mcp.json')
-      : pyResolve(path.join(os.homedir(), '.claude.json'));
+      : resolvePath(path.join(os.homedir(), '.claude.json'));
   }
   if (host === 'bob') {
     return scope === 'project' ? path.join(root, '.bob', 'settings.json')
@@ -305,18 +306,18 @@ export function cmdMcp() {
   const targets = mcpInstallTargets()
     .filter(([, , host, scope, root]) => installState(root, host, scope) === 'active');
   if (!targets.length) {
-    pyPrintErr('[mcp] no active Geneseed install found. Run `geneseed setup` first.\n');
+    printErr('[mcp] no active Geneseed install found. Run `geneseed setup` first.\n');
     return 1;
   }
   for (const [label, p, host] of targets) {
     const cfg = mcpLoad(p, host);
-    pyPrint(`[mcp] ${host} ${label}: ${p}${existsSync(p) ? '' : ' (not written yet)'}\n`);
+    printOut(`[mcp] ${host} ${label}: ${p}${existsSync(p) ? '' : ' (not written yet)'}\n`);
     if (mcpCommented(p)) {
-      pyPrint('  this config carries comments — edit it by hand so they survive.\n');
+      printOut('  this config carries comments — edit it by hand so they survive.\n');
     }
     for (const name of mcpKnownNames(cfg, host)) {
       const [lbl] = mcpMeta(name);
-      pyPrint(`  ${pyLjust(mcpState(cfg, name, host), 8)}  ${pyLjust(name, 12)}  ${lbl}\n`);
+      printOut(`  ${padEndToWidth(mcpState(cfg, name, host), 8)}  ${padEndToWidth(name, 12)}  ${lbl}\n`);
     }
   }
   return 0;

package/js/{native.mjs → hosts/native.mjs}

@@ -6,7 +6,7 @@
  * one dialect per host (OpenCode / Claude Code / Copilot), vendored skill folders copied
  * through verbatim, authoring templates shipped flat.
  *
- * WHY THIS IS THE HARD HALF. `js/render.mjs` is a pure function of `src/` and `themes/`;
+ * WHY THIS IS THE HARD HALF. `js/build/render.mjs` is a pure function of `src/` and `themes/`;
  * this file is not, in three separate ways, and each one is a place a port can be subtly
  * wrong while looking right:
  *
@@ -19,9 +19,9 @@
  *      (`<name>.agent.md`) that drags a link rewrite along with it.
  *
  * None of the three is reachable from the golden harness's happy path: golden emits into
- * a fresh tree with an empty overrides stub. `tests/test_native_layer_parity.py` drives
- * both implementations over the cells golden cannot construct, and byte-compares the
- * written trees, the returned values AND the warning stream.
+ * a fresh tree with an empty overrides stub. `tests/unit/user_files.test.mjs` drives
+ * claim-on-create over the states a clean fixture cannot produce, and asserts the written
+ * tree, the return value AND the warning stream.
  *
  * NOTHING HERE MAY WRITE TO STDOUT. Python's warnings all go to stderr, and the emitted
  * hook gates signal by printing JSON on stdout — a stray byte from a library on that path
@@ -30,8 +30,8 @@
  */
 import { existsSync, mkdirSync } from 'node:fs';
 import path from 'node:path';
-import { writeText, copyFile, jsonDumps, parseJson, pyStr, pyRepr, pyTruthy, readText }
-  from './lib/fs.mjs';
+import { writeText, copyFile, readText } from '../lib/fs.mjs';
+import { jsonDumps, parseJson, formatValue, formatRepr, isTruthy } from '../lib/json.mjs';
 
 /** Mirrors `_build_core.VENDORED_SKILL_DIRS`. */
 export const VENDORED_SKILL_DIRS = new Set(['react-view-transitions', 'daydream', 'token-report']);
@@ -125,7 +125,7 @@ const HTML_COMMENT_RE = /<!--[\s\S]*?-->/g;
  * comment is stripped.
  *
  * `.replace` with a `g` regex, matching `re.sub`'s replace-all; the Python's pattern is
- * non-global-looking but `re.sub` always is. `split('\n')` rather than `pySplitLines`: the
+ * non-global-looking but `re.sub` always is. `split('\n')` rather than `splitLines`: the
  * text has been through `readText`, and the reason `firstBlockquote` gives for the same
  * choice applies verbatim to the same files.
  */
@@ -133,12 +133,12 @@ export function descBlockProblem(text) {
   const nonblank = text.replace(HTML_COMMENT_RE, '').split('\n').filter((ln) => ln.trim());
   if (!nonblank.length) return 'file is empty (after stripping authoring comments)';
   if (!nonblank[0].replace(/^\s+/, '').startsWith('#')) {
-    return `first content line is not a title ('# ...'): ${pyRepr(nonblank[0].trim())}`;
+    return `first content line is not a title ('# ...'): ${formatRepr(nonblank[0].trim())}`;
   }
   if (nonblank.length < 2) return 'has a title but no purpose blockquote after it';
   const second = nonblank[1].trim();
   if (!second.startsWith('>')) {
-    return `first block after the title is not a '>' blockquote: ${pyRepr(second)}`;
+    return `first block after the title is not a '>' blockquote: ${formatRepr(second)}`;
   }
   if (!second.replace(/^>+/, '').trim()) return 'purpose blockquote is empty';
   return '';
@@ -167,7 +167,7 @@ function agentColorMap(theme) {
     if (VALID_AGENT_COLOR_SLOTS.has(v)) {
       cleaned[k] = v;
     } else {
-      warn(`[geneseed] WARN: AGENT_COLORS[${pyRepr(k)}] = ${pyRepr(v)} is not a valid `
+      warn(`[geneseed] WARN: AGENT_COLORS[${formatRepr(k)}] = ${formatRepr(v)} is not a valid `
         + `OpenCode theme slot (${[...VALID_AGENT_COLOR_SLOTS].sort().join(', ')}) — `
         + `falling back to 'secondary'`);
       cleaned[k] = 'secondary';
@@ -216,23 +216,25 @@ function agentOverride(overrides, stem) {
  * `model`/`variant` tests are truthiness and the `temperature`/`steps` tests are
  * `is not None` — a configured `temperature: 0` must survive, an empty model must not.
  *
- * Python spells these four ifs out twice, in `_opencode_agent_frontmatter` and in
- * `_write_primary_agent`. One owner here rather than a second copy: the two Python
- * bodies are identical today, and the parity gate drives BOTH call sites, so if they
- * ever diverge the gate says so instead of the copies silently rotting apart.
+ * Python spelled these four ifs out twice, in `_opencode_agent_frontmatter` and in
+ * `_write_primary_agent`. One owner here rather than a second copy, and the reason is
+ * sharper now than parity was: the two call sites are `opencodeAgentFrontmatter` below and
+ * `writePrimaryAgent` in `js/hosts/opencode.mjs`, and the second is behind
+ * `GENESEED_PRIMARY` — so only `tests/unit/agent_overrides.test.mjs` reaches it. Sharing the
+ * body is what stops the opt-in path rotting away from the default one unobserved.
  */
 export function pushOverrideLines(fm, ov) {
-  if (pyTruthy(ov.model)) fm.push(`model: ${pyStr(ov.model)}`);
-  if (given(ov.temperature)) fm.push(`temperature: ${pyStr(ov.temperature)}`);
-  if (pyTruthy(ov.variant)) fm.push(`variant: ${pyStr(ov.variant)}`);
-  if (given(ov.steps)) fm.push(`steps: ${pyStr(ov.steps)}`);
+  if (isTruthy(ov.model)) fm.push(`model: ${formatValue(ov.model)}`);
+  if (given(ov.temperature)) fm.push(`temperature: ${formatValue(ov.temperature)}`);
+  if (isTruthy(ov.variant)) fm.push(`variant: ${formatValue(ov.variant)}`);
+  if (given(ov.steps)) fm.push(`steps: ${formatValue(ov.steps)}`);
 }
 
 /** `_build_emit._claude_agent_frontmatter`. */
 function claudeAgentFrontmatter(stem, text, overrides) {
   const fm = [`name: ${stem}`, `description: ${jsonDumps(descOf(text))}`];
   const ov = agentOverride(overrides, stem);
-  if (pyTruthy(ov.model)) fm.push(`model: ${pyStr(ov.model)}`);
+  if (isTruthy(ov.model)) fm.push(`model: ${formatValue(ov.model)}`);
   if (isReadonly(text)) {
     const denied = ['Write', 'Edit', 'NotebookEdit', 'WebFetch'];
     if (!text.includes('<!-- bash: allow -->')) denied.push('Bash');
@@ -245,7 +247,7 @@ function claudeAgentFrontmatter(stem, text, overrides) {
 function copilotAgentFrontmatter(stem, text, overrides) {
   const fm = [`name: ${stem}`, `description: ${jsonDumps(descOf(text))}`];
   const ov = agentOverride(overrides, stem);
-  if (pyTruthy(ov.model)) fm.push(`model: ${pyStr(ov.model)}`);
+  if (isTruthy(ov.model)) fm.push(`model: ${formatValue(ov.model)}`);
   if (isReadonly(text)) {
     const allowed = ['read', 'search', 'todo', 'agent'];
     if (text.includes('<!-- bash: allow -->')) allowed.push('execute');
@@ -271,7 +273,7 @@ function opencodeAgentFrontmatter(stem, text, overrides, theme = null) {
 export function loadAgentOverrides(base) {
   let data;
   try {
-    // parseJson, not JSON.parse: the override values are rendered with `pyStr`, which
+    // parseJson, not JSON.parse: the override values are rendered with `formatValue`, which
     // needs the int/float distinction the raw literal carries and `JSON.parse` discards.
     data = parseJson(readText(path.join(base, 'agent-overrides.json')));
   } catch {
@@ -297,7 +299,7 @@ function relPosix(base, target) {
  * `items` are `render_all`'s, as `{ rel, text, src }` — `text` null for a binary that is
  * copied rather than rendered. `src` is the absolute source path; `opts.src` is the
  * source root it is relativised against (Python reads `_build_core.SRC` directly, which
- * is the module-level single owner; here it travels explicitly, as in `js/render.mjs`).
+ * is the module-level single owner; here it travels explicitly, as in `js/build/render.mjs`).
  *
  * Returns `{ nAgents, nSkills, written }` — Python's 3-tuple, with `written` as absolute
  * paths in write order.

package/js/{opencode.mjs → hosts/opencode.mjs}

@@ -1,6 +1,6 @@
 /**
  * The OpenCode-native extras, in Node — everything `emit_opencode` writes beyond the
- * agents and skills that `js/native.mjs` already owns.
+ * agents and skills that `js/hosts/native.mjs` already owns.
  *
  * A translation of the second half of `_build_emit.py`: the branded and curated colour
  * themes, the opt-in primary agent, the opt-in slash-command layer plus the always-on
@@ -15,17 +15,18 @@
  * indent is what switches Python's separators to the ones `JSON.stringify` already uses.
  *
  * TWO STREAMS, AND THE SPLIT IS NOT TIDY. `_warn_if_overrides_stale` prints to STDOUT
- * while every warning in `js/native.mjs` goes to stderr. That is the Python's own
+ * while every warning in `js/hosts/native.mjs` goes to stderr. That is the Python's own
  * inconsistency and it is reproduced, not corrected: the parity gate compares both
- * streams, so "fixing" it here would be a divergence. It is safe because this is the
+ * specification, and `tests/unit/agent_overrides.test.mjs` pins the stale notice to stdout.
+ * It is safe because this is the
  * generator's CLI, which prints progress to stdout by design — unlike a hook path, where
  * a stray stdout byte silently disarms a blocking gate.
  */
 import { existsSync, mkdirSync, readdirSync, statSync } from 'node:fs';
 import path from 'node:path';
-import {
-  writeText, readText, copyFile, jsonDumps, jsonDumpsIndent, parseJson, comparePaths,
-} from './lib/fs.mjs';
+import { writeText, readText, copyFile } from '../lib/fs.mjs';
+import { jsonDumps, jsonDumpsIndent, parseJson } from '../lib/json.mjs';
+import { comparePaths } from '../lib/paths.mjs';
 import { descOf, stripSkillBodyLinks, pushOverrideLines } from './native.mjs';
 
 /** ANSI colour-name -> integer (0-7). Mirrors `_build_emit._ANSI`. */
@@ -98,7 +99,11 @@ function truthyEnv(name) {
   return ['1', 'on', 'true', 'yes'].includes((process.env[name] || '').toLowerCase());
 }
 
-/** `_build_core.source_release_version`. Belongs to core; travels in `cfg` until core lands. */
+/**
+ * `_build_core.source_release_version`. It reads `cfg.config`, so it takes `cfg` rather than
+ * importing core — and it stayed HERE when core landed as `js/build/source.mjs`, which is why
+ * `js/build/version.mjs` reaches back into the OpenCode module for it.
+ */
 export function sourceReleaseVersion(cfg) {
   try {
     const data = parseJson(readText(cfg.config));