generator-jhipster 8.4.0 → 8.6.0

package/dist/generators/angular/templates/src/main/webapp/app/admin/health/health.component.spec.ts.ejs

@@ -17,8 +17,7 @@
  limitations under the License.
 -%>
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { HttpErrorResponse } from '@angular/common/http';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient, HttpErrorResponse } from '@angular/common/http';
 import { of, throwError } from 'rxjs';
 
 import HealthComponent from './health.component';
@@ -33,7 +32,8 @@ describe('HealthComponent', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, HealthComponent],
+        imports: [HealthComponent],
+        providers: [provideHttpClient()],
       })
         .overrideTemplate(HealthComponent, '')
         .compileComponents();
@@ -72,7 +72,7 @@ describe('HealthComponent', () => {
     it('should handle a 503 on refreshing health data', () => {
       // GIVEN
       const health: Health = { status: 'DOWN', components: { mail: { status: 'DOWN' } } };
-      jest.spyOn(service, 'checkHealth').mockReturnValue(throwError(new HttpErrorResponse({ status: 503, error: health })));
+      jest.spyOn(service, 'checkHealth').mockReturnValue(throwError(() => new HttpErrorResponse({ status: 503, error: health })));
 
       // WHEN
       comp.refresh();

package/dist/generators/angular/templates/src/main/webapp/app/admin/health/health.service.spec.ts.ejs

@@ -17,7 +17,8 @@
  limitations under the License.
 -%>
 import { TestBed } from '@angular/core/testing';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 
 import { HealthService } from './health.service';
 import { ApplicationConfigService } from 'app/core/config/application-config.service';
@@ -29,7 +30,7 @@ describe('HealthService Service', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      providers: [provideHttpClient(), provideHttpClientTesting()],
     });
 
     service = TestBed.inject(HealthService);

package/dist/generators/angular/templates/src/main/webapp/app/admin/health/modal/health-modal.component.spec.ts.ejs

@@ -1,5 +1,5 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 
 import HealthModalComponent from './health-modal.component';
@@ -12,8 +12,8 @@ describe('HealthModalComponent', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, HealthModalComponent],
-        providers: [NgbActiveModal],
+        imports: [HealthModalComponent],
+        providers: [provideHttpClient(), NgbActiveModal],
       })
         .overrideTemplate(HealthModalComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/logs/logs.component.spec.ts.ejs

@@ -17,7 +17,8 @@
  limitations under the License.
 -%>
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { of } from 'rxjs';
 
 import LogsComponent from './logs.component';
@@ -35,8 +36,8 @@ describe('LogsComponent', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, LogsComponent],
-        providers: [LogsService<%= applicationTypeGateway && serviceDiscoveryAny ? ', GatewayRoutesService' : '' %>],
+        imports: [LogsComponent],
+        providers: [provideHttpClient(), provideHttpClientTesting(), LogsService<%= applicationTypeGateway && serviceDiscoveryAny ? ', GatewayRoutesService' : '' %>],
       })
         .overrideTemplate(LogsComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/logs/logs.service.spec.ts.ejs

@@ -17,7 +17,8 @@
  limitations under the License.
 -%>
 import { TestBed } from '@angular/core/testing';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 
 import { LogsService } from './logs.service';
 
@@ -27,7 +28,7 @@ describe('Logs Service', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      providers: [provideHttpClient(), provideHttpClientTesting()],
     });
 
     service = TestBed.inject(LogsService);

package/dist/generators/angular/templates/src/main/webapp/app/admin/metrics/blocks/jvm-threads/jvm-threads.component.ts.ejs

@@ -67,7 +67,7 @@ export class JvmThreadsComponent {
 
   private _threads: Thread[] | undefined;
 
-  private modalService = inject(NgbModal);
+  private readonly modalService = inject(NgbModal);
 
   open(): void {
     const modalRef = this.modalService.open(MetricsModalThreadsComponent);

package/dist/generators/angular/templates/src/main/webapp/app/admin/metrics/blocks/metrics-modal-threads/metrics-modal-threads.component.html.ejs

@@ -19,45 +19,45 @@
 <div class="modal-header">
   <h4 class="modal-title">__jhiTranslateTag__('metrics.jvm.threads.dump.title')</h4>
 
-  <button type="button" class="btn-close" (click)="dismiss()">&times;</button>
+  <button type="button" class="btn-close" (click)="dismiss()">&nbsp;</button>
 </div>
 
 <div class="modal-body">
   <div class="mb-3">
-    <span class="badge bg-primary hand" (click)="threadStateFilter = undefined">
+    <button class="badge bg-primary hand" (click)="threadStateFilter = undefined" (keydown.enter)="threadStateFilter = undefined">
     @if (threadStateFilter === undefined) {
       <fa-icon icon="check"></fa-icon>
     }
       All&nbsp;<span class="badge rounded-pill bg-default">{{ threadDumpAll }}</span>
-    </span>
+    </button>
 
-    <span class="badge bg-success hand" (click)="threadStateFilter = ThreadState.Runnable">
+    <button class="badge bg-success hand" (click)="threadStateFilter = ThreadState.Runnable" (keydown.enter)="threadStateFilter = ThreadState.Runnable">
     @if (threadStateFilter === ThreadState.Runnable) {
       <fa-icon icon="check"></fa-icon>
     }
       Runnable&nbsp;<span class="badge rounded-pill bg-default">{{ threadDumpRunnable }}</span>
-    </span>
+    </button>
 
-    <span class="badge bg-info hand" (click)="threadStateFilter = ThreadState.Waiting">
+    <button class="badge bg-info hand" (click)="threadStateFilter = ThreadState.Waiting" (keydown.enter)="threadStateFilter = ThreadState.Waiting">
     @if (threadStateFilter === ThreadState.Waiting) {
       <fa-icon icon="check"></fa-icon>
     }
       Waiting&nbsp;<span class="badge rounded-pill bg-default">{{ threadDumpWaiting }}</span>
-    </span>
+    </button>
 
-    <span class="badge bg-warning hand" (click)="threadStateFilter = ThreadState.TimedWaiting">
+    <button class="badge bg-warning hand" (click)="threadStateFilter = ThreadState.TimedWaiting" (keydown.enter)="threadStateFilter = ThreadState.TimedWaiting">
     @if (threadStateFilter === ThreadState.TimedWaiting) {
       <fa-icon icon="check"></fa-icon>
     }
       Timed Waiting&nbsp;<span class="badge rounded-pill bg-default">{{ threadDumpTimedWaiting }}</span>
-    </span>
+    </button>
 
-    <span class="badge bg-danger hand" (click)="threadStateFilter = ThreadState.Blocked">
+    <button class="badge bg-danger hand" (click)="threadStateFilter = ThreadState.Blocked" (keydown.enter)="threadStateFilter = ThreadState.Blocked">
     @if (threadStateFilter === ThreadState.Blocked) {
       <fa-icon icon="check"></fa-icon>
     }
       Blocked&nbsp;<span class="badge rounded-pill bg-default">{{ threadDumpBlocked }}</span>
-    </span>
+    </button>
   </div>
 
 @for (thread of getThreads(); track $index) {

package/dist/generators/angular/templates/src/main/webapp/app/admin/metrics/blocks/metrics-modal-threads/metrics-modal-threads.component.spec.ts.ejs

@@ -17,7 +17,7 @@
  limitations under the License.
 -%>
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 
 import { MetricsModalThreadsComponent } from './metrics-modal-threads.component';
@@ -30,8 +30,8 @@ describe('MetricsModalThreadsComponent', () => {
 
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule, MetricsModalThreadsComponent],
-      providers: [NgbActiveModal],
+      imports: [MetricsModalThreadsComponent],
+      providers: [provideHttpClient(), NgbActiveModal],
     })
       .overrideTemplate(MetricsModalThreadsComponent, '')
       .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.component.spec.ts.ejs

@@ -18,7 +18,7 @@
 -%>
 import { ChangeDetectorRef } from '@angular/core';
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { of } from 'rxjs';
 
 import MetricsComponent from './metrics.component';
@@ -34,7 +34,8 @@ describe('MetricsComponent', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, MetricsComponent],
+        imports: [MetricsComponent],
+        providers: [provideHttpClient()],
       })
         .overrideTemplate(MetricsComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/metrics/metrics.service.spec.ts.ejs

@@ -17,7 +17,8 @@
  limitations under the License.
 -%>
 import { TestBed } from '@angular/core/testing';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 
 import { MetricsService } from './metrics.service';
 import { ThreadDump, ThreadState } from './metrics.model';
@@ -28,7 +29,7 @@ describe('Logs Service', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      providers: [provideHttpClient(), provideHttpClientTesting()],
     });
     service = TestBed.inject(MetricsService);
     httpMock = TestBed.inject(HttpTestingController);

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/delete/user-management-delete-dialog.component.html.ejs

@@ -20,8 +20,6 @@
 <form name="deleteForm" (ngSubmit)="confirmDelete(user.login!)">
   <div class="modal-header">
     <h4 class="modal-title">__jhiTranslateTag__('entity.delete.title')</h4>
-
-    <span class="btn btn-close" data-dismiss="modal" aria-hidden="true" (click)="cancel()"></span>
   </div>
 
   <div class="modal-body">

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/delete/user-management-delete-dialog.component.spec.ts.ejs

@@ -19,7 +19,7 @@
 jest.mock('@ng-bootstrap/ng-bootstrap');
 
 import { ComponentFixture, TestBed, waitForAsync, inject, fakeAsync, tick } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 import { of } from 'rxjs';
 
@@ -36,8 +36,8 @@ describe('User Management Delete Component', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, UserManagementDeleteDialogComponent],
-        providers: [NgbActiveModal],
+        imports: [UserManagementDeleteDialogComponent],
+        providers: [provideHttpClient(), NgbActiveModal],
       })
         .overrideTemplate(UserManagementDeleteDialogComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/list/user-management.component.html.ejs

@@ -22,7 +22,7 @@
 
     <div class="d-flex justify-content-end">
       <button class="btn btn-info me-2" (click)="loadAll()" [disabled]="isLoading()">
-        <fa-icon icon="sync" [spin]="isLoading()"></fa-icon>
+        <fa-icon icon="sync" [animation]="isLoading() ? 'spin' : undefined"></fa-icon>
         <span>__jhiTranslateTag__('userManagement.home.refreshListLabel')</span>
       </button>
       <button class="btn btn-primary jh-create-entity" [routerLink]="['./new']">

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/list/user-management.component.spec.ts.ejs

@@ -22,8 +22,7 @@ _%>
 jest.mock('app/core/auth/account.service');
 
 import { ComponentFixture, TestBed, waitForAsync, inject, fakeAsync, tick } from '@angular/core/testing';
-import { HttpHeaders, HttpResponse } from '@angular/common/http';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient, HttpHeaders, HttpResponse } from '@angular/common/http';
 import { ActivatedRoute } from '@angular/router';
 import { of } from 'rxjs';
 
@@ -52,8 +51,8 @@ describe('User Management Component', () => {
   beforeEach(
     waitForAsync(() => {
       TestBed.configureTestingModule({
-        imports: [HttpClientTestingModule, UserManagementComponent],
-        providers: [{ provide: ActivatedRoute, useValue: { data, queryParamMap } }, AccountService],
+        imports: [UserManagementComponent],
+        providers: [provideHttpClient(), { provide: ActivatedRoute, useValue: { data, queryParamMap } }, AccountService],
       })
         .overrideTemplate(UserManagementComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/service/user-management.service.spec.ts.ejs

@@ -20,8 +20,8 @@
 const tsKeyId = this.generateTestEntityId(user.primaryKey.type);
 _%>
 import { TestBed } from '@angular/core/testing';
-import { HttpErrorResponse } from '@angular/common/http';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient, HttpErrorResponse } from '@angular/common/http';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
 
 <%_ if (generateBuiltInAuthorityEntity) { _%>
 import { Authority } from 'app/config/authority.constants';
@@ -36,7 +36,7 @@ describe('User Service', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      providers: [provideHttpClient(), provideHttpClientTesting()],
     });
 
     service = TestBed.inject(UserManagementService);

package/dist/generators/angular/templates/src/main/webapp/app/admin/user-management/update/user-management-update.component.spec.ts.ejs

@@ -20,7 +20,7 @@
 const tsKeyId = this.generateTestEntityId(user.primaryKey.type);
 _%>
 import { ComponentFixture, TestBed, waitForAsync, inject, fakeAsync, tick } from '@angular/core/testing';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { FormBuilder } from '@angular/forms';
 import { ActivatedRoute } from '@angular/router';
 import { of } from 'rxjs';
@@ -38,8 +38,9 @@ describe('User Management Update Component', () => {
 
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule, UserManagementUpdateComponent],
+      imports: [UserManagementUpdateComponent],
       providers: [
+        provideHttpClient(),
         FormBuilder,
         {
           provide: ActivatedRoute,

package/dist/generators/angular/templates/src/main/webapp/app/app-page-title-strategy.ts.ejs

@@ -25,7 +25,7 @@ import { TranslateService } from "@ngx-translate/core";
 @Injectable()
 export class AppPageTitleStrategy extends TitleStrategy {
 <%_ if (enableTranslation) { _%>
-  private translateService = inject(TranslateService);
+  private readonly translateService = inject(TranslateService);
 <%_ } _%>
 
   override updateTitle(routerState: RouterStateSnapshot): void {

package/dist/generators/angular/templates/src/main/webapp/app/app.component.ts.ejs

@@ -23,7 +23,6 @@ import { FaIconLibrary } from '@fortawesome/angular-fontawesome';
 import { NgbDatepickerConfig } from '@ng-bootstrap/ng-bootstrap';
 import { provideRouter } from '@angular/router';
 import { registerLocaleData } from '@angular/common';
-import { HttpClientModule } from '@angular/common/http';
 import locale from '@angular/common/locales/<%= angularLocaleId %>';
 import { FaIconLibrary } from '@fortawesome/angular-fontawesome';
 import dayjs from 'dayjs/esm';

package/dist/generators/angular/templates/src/main/webapp/app/app.config.ts.ejs

@@ -20,7 +20,7 @@ import { ApplicationConfig, LOCALE_ID, importProvidersFrom, inject } from '@angu
 import { BrowserModule, Title } from '@angular/platform-browser';
 import { Router, RouterFeatures, TitleStrategy, provideRouter, withComponentInputBinding, withDebugTracing, withNavigationErrorHandler, NavigationError } from '@angular/router';
 import { ServiceWorkerModule } from '@angular/service-worker';
-import { HttpClientModule } from '@angular/common/http';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 
 import { NgbDateAdapter } from '@ng-bootstrap/ng-bootstrap';
 
@@ -62,7 +62,7 @@ export const appConfig: ApplicationConfig = {
 <%_ if (enableTranslation) { _%>
     importProvidersFrom(TranslationModule),
 <%_ } _%>
-    importProvidersFrom(HttpClientModule),
+    provideHttpClient(withInterceptorsFromDi()),
     Title,
     { provide: LOCALE_ID, useValue: '<%= angularLocaleId %>' },
     { provide: NgbDateAdapter, useClass: NgbDateDayjsAdapter },

package/dist/generators/angular/templates/src/main/webapp/app/config/uib-pagination.config.ts.ejs

@@ -23,7 +23,7 @@ import { ITEMS_PER_PAGE } from 'app/config/pagination.constants';
 
 @Injectable({ providedIn: 'root' })
 export class PaginationConfig {
-  private config = inject(NgbPaginationConfig);
+  private readonly config = inject(NgbPaginationConfig);
   constructor() {
     this.config.boundaryLinks = true;
     this.config.maxSize = 5;

package/dist/generators/angular/templates/src/main/webapp/app/core/auth/account.service.spec.ts.ejs

@@ -19,7 +19,8 @@
 jest.mock('app/core/auth/state-storage.service');
 
 import { Router } from '@angular/router';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { TestBed } from '@angular/core/testing';
 <%_ if (enableTranslation) { _%>
 import { TranslateModule, TranslateService } from '@ngx-translate/core';
@@ -62,13 +63,14 @@ describe('Account Service', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
+      <%_ if (enableTranslation) { _%>
       imports: [
-        HttpClientTestingModule,
-<%_ if (enableTranslation) { _%>
         TranslateModule.forRoot(),
-<%_ } _%>
       ],
+      <%_ } _%>
       providers: [
+        provideHttpClient(),
+        provideHttpClientTesting(),
         StateStorageService,
       ],
     });
@@ -214,7 +216,7 @@ describe('save', () => {
       it('should not navigate to the previous stored url when authentication fails', () => {
         // WHEN
         service.identity().subscribe();
-        httpMock.expectOne({ method: 'GET' }).error(new ErrorEvent(''));
+        httpMock.expectOne({ method: 'GET' }).error(new ProgressEvent(''));
 
         // THEN
         expect(mockStorageService.getUrl).not.toHaveBeenCalled();

package/dist/generators/angular/templates/src/main/webapp/app/core/auth/auth-jwt.service.spec.ts.ejs

@@ -17,7 +17,8 @@
  limitations under the License.
 -%>
 import { TestBed } from '@angular/core/testing';
-import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';
+import { provideHttpClient } from '@angular/common/http';
 import { AuthServerProvider } from 'app/core/auth/auth-jwt.service';
 import { StateStorageService } from './state-storage.service';
 
@@ -28,7 +29,7 @@ describe('Auth JWT', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule],
+      providers: [provideHttpClient(), provideHttpClientTesting()],
     });
 
     mockStorageService = TestBed.inject(StateStorageService);

package/dist/generators/angular/templates/src/main/webapp/app/core/auth/user-route-access.service.ts.ejs

@@ -43,7 +43,7 @@ export const UserRouteAccessService: CanActivateFn = (next: ActivatedRouteSnapsh
         }
 
         if (isDevMode()) {
-          console.error('User has not any of required authorities: ', authorities);
+          console.error('User does not have any of the required authorities:', authorities);
         }
         router.navigate(['accessdenied']);
         return false;

package/dist/generators/angular/templates/src/main/webapp/app/core/interceptor/auth-expired.interceptor.ts.ejs

@@ -27,9 +27,9 @@ import { StateStorageService } from 'app/core/auth/state-storage.service';
 
 @Injectable()
 export class AuthExpiredInterceptor implements HttpInterceptor {
-  private loginService = inject(LoginService);
-  private stateStorageService = inject(StateStorageService);
-  private router = inject(Router);
+  private readonly loginService = inject(LoginService);
+  private readonly stateStorageService = inject(StateStorageService);
+  private readonly router = inject(Router);
 
   intercept(request: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
     return next.handle(request).pipe(

package/dist/generators/angular/templates/src/main/webapp/app/core/interceptor/auth.interceptor.ts.ejs

@@ -25,8 +25,8 @@ import { ApplicationConfigService } from '../config/application-config.service';
 
 @Injectable()
 export class AuthInterceptor implements HttpInterceptor {
-  private stateStorageService = inject(StateStorageService);
-  private applicationConfigService = inject(ApplicationConfigService);
+  private readonly stateStorageService = inject(StateStorageService);
+  private readonly applicationConfigService = inject(ApplicationConfigService);
 
   intercept(request: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
     const serverApiUrl = this.applicationConfigService.getEndpointFor('');

package/dist/generators/angular/templates/src/main/webapp/app/core/interceptor/error-handler.interceptor.ts.ejs

@@ -25,7 +25,7 @@ import { EventManager, EventWithContent } from 'app/core/util/event-manager.serv
 
 @Injectable()
 export class ErrorHandlerInterceptor implements HttpInterceptor {
-  private eventManager = inject(EventManager);
+  private readonly eventManager = inject(EventManager);
 
   intercept(request: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
     return next.handle(request).pipe(

package/dist/generators/angular/templates/src/main/webapp/app/core/util/alert.service.spec.ts.ejs

@@ -123,10 +123,10 @@ describe('Alert service test', () => {
 
     it('should produce an alert object with correct id', inject([AlertService], (service: AlertService) => {
       service.addAlert({ type: 'info', message: 'Hello Jhipster info' });
-      expect(service.addAlert({ type: 'success', message: 'Hello Jhipster success' })).toEqual(
+      expect(service.addAlert({ type: 'success', message: 'Hello JHipster success' })).toEqual(
         expect.objectContaining({
           type: 'success',
-          message: 'Hello Jhipster success',
+          message: 'Hello JHipster success',
           id: 1,
         } as Alert)
       );
@@ -135,7 +135,7 @@ describe('Alert service test', () => {
       expect(service.get()[1]).toEqual(
         expect.objectContaining({
           type: 'success',
-          message: 'Hello Jhipster success',
+          message: 'Hello JHipster success',
           id: 1,
         } as Alert)
       );
@@ -144,11 +144,11 @@ describe('Alert service test', () => {
     it('should close an alert correctly', inject([AlertService], (service: AlertService) => {
       const alert0 = service.addAlert({ type: 'info', message: 'Hello Jhipster info' });
       const alert1 = service.addAlert({ type: 'info', message: 'Hello Jhipster info 2' });
-      const alert2 = service.addAlert({ type: 'success', message: 'Hello Jhipster success' });
+      const alert2 = service.addAlert({ type: 'success', message: 'Hello JHipster success' });
       expect(alert2).toEqual(
         expect.objectContaining({
           type: 'success',
-          message: 'Hello Jhipster success',
+          message: 'Hello JHipster success',
           id: 2,
         } as Alert)
       );
@@ -168,7 +168,7 @@ describe('Alert service test', () => {
       expect(service.get()[0]).not.toEqual(
         expect.objectContaining({
           type: 'success',
-          message: 'Hello Jhipster success',
+          message: 'Hello JHipster success',
           id: 2,
         } as Alert)
       );

package/dist/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/delete/_entityFile_-delete-dialog.component.html.ejs

@@ -20,9 +20,6 @@
 <form name="deleteForm" (ngSubmit)="confirmDelete(<%= entityInstance %>.<%= primaryKey.name %>!)">
     <div class="modal-header">
         <h4 class="modal-title" data-cy="<%= entityInstance %>DeleteDialogHeading">__jhiTranslateTag__('entity.delete.title')</h4>
-
-        <span class="btn btn-close" data-dismiss="modal" aria-hidden="true"
-                (click)="cancel()"></span>
     </div>
 
     <div class="modal-body">

package/dist/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/delete/_entityFile_-delete-dialog.component.spec.ts.ejs

@@ -22,8 +22,7 @@ _%>
 jest.mock('@ng-bootstrap/ng-bootstrap');
 
 import { ComponentFixture, TestBed, inject, fakeAsync, tick } from '@angular/core/testing';
-import { HttpResponse } from '@angular/common/http';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient, HttpResponse } from '@angular/common/http';
 import { of } from 'rxjs';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 
@@ -39,8 +38,8 @@ describe('<%= entityAngularName %> Management Delete Component', () => {
 
     beforeEach(() => {
         TestBed.configureTestingModule({
-            imports: [HttpClientTestingModule, <%= entityAngularName %>DeleteDialogComponent],
-            providers: [NgbActiveModal]
+            imports: [<%= entityAngularName %>DeleteDialogComponent],
+            providers: [provideHttpClient(), NgbActiveModal]
         })
         .overrideTemplate(<%= entityAngularName %>DeleteDialogComponent, '')
         .compileComponents();

package/dist/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/detail/_entityFile_-detail.component.spec.ts.ejs

@@ -96,7 +96,7 @@ describe('<%= entityAngularName %> Management Detail Component', () => {
       comp.byteSize(fakeBase64);
 
       // THEN
-      expect(dataUtils.byteSize).toBeCalledWith(fakeBase64);
+      expect(dataUtils.byteSize).toHaveBeenCalledWith(fakeBase64);
     });
   });
 
@@ -116,7 +116,7 @@ describe('<%= entityAngularName %> Management Detail Component', () => {
       comp.openFile(fakeBase64, fakeContentType);
 
       // THEN
-      expect(dataUtils.openFile).toBeCalledWith(fakeBase64, fakeContentType);
+      expect(dataUtils.openFile).toHaveBeenCalledWith(fakeBase64, fakeContentType);
     });
   });
 <%_ } _%>

package/dist/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/list/_entityFile_.component.html.ejs

@@ -22,7 +22,7 @@
 
         <div class="d-flex justify-content-end">
             <button class="btn btn-info me-2" (click)="load()" [disabled]="isLoading">
-                <fa-icon icon="sync" [spin]="isLoading"></fa-icon>
+                <fa-icon icon="sync" [animation]="isLoading ? 'spin' : undefined"></fa-icon>
                 <span>__jhiTranslateTag__('<%- i18nKeyPrefix %>.home.refreshListLabel')</span>
             </button>
             <%_ if (!readOnly) { _%>

package/dist/generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/list/_entityFile_.component.spec.ts.ejs

@@ -29,8 +29,7 @@ import {
   fakeAsync, inject, tick,
 <%_ } _%>
 } from '@angular/core/testing';
-import { HttpHeaders, HttpResponse } from '@angular/common/http';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClient, HttpHeaders, HttpResponse } from '@angular/common/http';
 import { ActivatedRoute } from '@angular/router';
 import {
   of,
@@ -59,10 +58,10 @@ describe('<%= entityAngularName %> Management Component', () => {
     beforeEach(() => {
         TestBed.configureTestingModule({
             imports: [
-              HttpClientTestingModule,
               <%= entityAngularName %>Component,
             ],
             providers: [
+                provideHttpClient(),
                 {
                     provide: ActivatedRoute,
                     useValue: {