gencow 0.1.266 → 0.1.268

package/lib/cli-command-runner.mjs

@@ -150,7 +150,7 @@ const SAFE_LOCAL_ERROR_CODES = new Map([
       action: (caught) => {
         const dir = safeDisplayDir(caught);
         const target = dir ?? "<build-output-dir>";
-        return `Retryable: yes, after the build writes an index.html with real content into ${target} — run \`ls -l ${target}/index.html\` to confirm its size is above 0 bytes and that it holds more than whitespace or HTML comments, then rerun \`gencow static ${target}\`.`;
+        return `Retryable: yes, after the build writes an index.html with real content into ${target} — run \`ls -l ${target}/index.html\` to confirm its size is above 0 bytes and that it holds more than whitespace or HTML comments, then rerun \`gencow static ${target}${safeRetryTargetFlags(caught)}\`.`;
       },
     },
   ],
@@ -162,7 +162,7 @@ const SAFE_LOCAL_ERROR_CODES = new Map([
       action: (caught) => {
         const dir = safeDisplayDir(caught);
         const target = dir ?? "<build-output-dir>";
-        return `Retryable: yes, after the build writes index.html into ${target} — run \`ls ${target}/index.html\` to confirm, then rerun \`gencow static ${target}\`.`;
+        return `Retryable: yes, after the build writes index.html into ${target} — run \`ls ${target}/index.html\` to confirm, then rerun \`gencow static ${target}${safeRetryTargetFlags(caught)}\`.`;
       },
     },
   ],
@@ -172,6 +172,11 @@ function safeDisplayDir(caught) {
   const { displayDir } = caught;
   return typeof displayDir === "string" && SAFE_DISPLAY_DIR.test(displayDir) ? displayDir : null;
 }
+
+// Only the production selector is carried into retry guidance; any other value is never printed.
+function safeRetryTargetFlags(caught) {
+  return caught.targetFlags === "--prod" ? " --prod" : "";
+}
 const SAFE_SOURCE_LOCATION_PATH = /^(?![/\\])(?!.*(?:^|\/)\.\.(?:\/|$))[^\u0000-\u001f\u007f]{1,240}$/u;
 
 const SAFE_IMPORT_NAME = /^[A-Za-z_$][\w$]{0,127}$/u;

package/lib/deploy-package-runtime.mjs

@@ -7,6 +7,7 @@ import { fetchAppDiagnosticLogsViaRest, normalizeDiagnosticLogLines } from "./ap
 import { createCloudAppIfNeeded as createCloudAppIfNeededImpl } from "./deploy-app-creation.mjs";
 import { rejectExplicitAppNotFound } from "./deploy-app-target.mjs";
 import { loadProjectConfigForDeploy } from "./deploy-project-config-load.mjs";
+import { loadPackageJson } from "./deploy-project-package-json.mjs";
 import { resolveConfiguredAuditorImplementation } from "./auditor-mode.mjs";
 import {
   loadDeployMigrationGenerationContext,
@@ -398,12 +399,13 @@ export function createDeployPackageRuntime({
     warnRuntimePathsOutsideBackendRoot({ entryPoint, projectRoot: cwd, backendRoot, warnImpl });
     let dependencyAuditManifest = null;
     let dependencyVersionMessage = "";
-    let projectPkg;
+    const packageJson = loadPackageJson({ cwd, readFileSyncImpl, resolvePathImpl, errorImpl, exitImpl });
+    if (!packageJson) return null;
+    const projectPkg = packageJson.pkg;
     try {
       const { auditDependencyVersions, formatDependencyVersionAuditError } = await (
         loadDeployAuditorImpl ?? loadDeployAuditorDefault
       )();
-      projectPkg = JSON.parse(readFileSyncImpl(resolvePathImpl(cwd, "package.json"), "utf8"));
       const auditOptions = { cwd, existsSyncImpl, readFileSyncImpl };
       const dependencyVersionResult = auditDependencyVersions(projectPkg, auditOptions);
       dependencyVersionMessage = formatDependencyVersionAuditError(dependencyVersionResult);
@@ -447,9 +449,6 @@ export function createDeployPackageRuntime({
       }
     }
 
-    // Keep the manifest byte-compatible with the canonical pnpm lock importer.
-    const stagedPackageJson = readFileSyncImpl(resolvePathImpl(cwd, "package.json"), "utf8");
-
     let bundleBackendRoot;
     let bundleFileRows = [];
     try {
@@ -472,7 +471,7 @@ export function createDeployPackageRuntime({
         readFileSyncImpl,
         resolvePathImpl,
         rmSyncImpl,
-        stagedPackageJson,
+        stagedPackageJson: packageJson.text,
         tarCreateImpl,
         tmpBundle,
         writeCronManifestForProjectImpl,

package/lib/deploy-project-package-json.mjs

@@ -0,0 +1,79 @@
+// Reads the project package.json for deploy packaging. A missing, unreadable or non-JSON file is reported
+// as a typed, secret-free diagnosis (no raw fs/parser text, no absolute workspace path) and returns null.
+
+export const DEPLOY_PACKAGE_JSON_CODES = Object.freeze({
+  MISSING: "DEPLOY_PACKAGE_JSON_MISSING",
+  UNREADABLE: "DEPLOY_PACKAGE_JSON_UNREADABLE",
+  INVALID: "DEPLOY_PACKAGE_JSON_INVALID",
+});
+
+const NEXT_ACTION_FOR_MISSING =
+  "Next action: for a static-only site, run `gencow static --prod <build-output-dir>` (for example `gencow static --prod dist/`); for a backend app, run `npx gencow@latest init` to create a project with a package.json, then rerun deploy.";
+
+const DIAGNOSES = Object.freeze({
+  [DEPLOY_PACKAGE_JSON_CODES.MISSING]: {
+    message: "DEPLOY BLOCKED — package.json was not found in the project root.",
+    retryable:
+      "Retryable: yes, after package.json exists in the project root — run `ls package.json` to confirm, then rerun the same deploy command.",
+    nextAction: NEXT_ACTION_FOR_MISSING,
+  },
+  [DEPLOY_PACKAGE_JSON_CODES.UNREADABLE]: {
+    message: "DEPLOY BLOCKED — package.json exists but could not be read.",
+    retryable:
+      "Retryable: yes, after package.json is readable by the current user — check its file permissions, then rerun the same deploy command.",
+    nextAction:
+      "Next action: make package.json a readable regular file in the project root, then rerun deploy.",
+  },
+  [DEPLOY_PACKAGE_JSON_CODES.INVALID]: {
+    message: "DEPLOY BLOCKED — package.json is not a valid JSON object.",
+    retryable:
+      "Retryable: yes, after package.json is fixed — run `node -p \"require('./package.json').name\"` to see the syntax error, correct the file, then rerun the same deploy command.",
+    nextAction:
+      "Next action: correct the JSON syntax of package.json in the project root, then rerun deploy.",
+  },
+});
+
+export function formatDeployPackageJsonDiagnostic(code) {
+  const diagnosis = DIAGNOSES[code];
+  return [
+    diagnosis.message,
+    `Code: ${code}`,
+    "Stage: packaging",
+    "Database mutation: NONE",
+    "Incumbent serving: PRESERVED",
+    diagnosis.retryable,
+    diagnosis.nextAction,
+  ].join("\n");
+}
+
+function isPlainObject(value) {
+  return value !== null && typeof value === "object" && !Array.isArray(value);
+}
+
+// Returns { pkg, text } (text is the exact file content, so the staged manifest stays byte-identical to what
+// was validated), or null after printing the typed diagnosis and exiting with code 1.
+export function loadPackageJson({ cwd, readFileSyncImpl, resolvePathImpl, errorImpl, exitImpl }) {
+  let text;
+  let code = null;
+  try {
+    text = readFileSyncImpl(resolvePathImpl(cwd, "package.json"), "utf8");
+  } catch (caught) {
+    code =
+      caught?.code === "ENOENT" ? DEPLOY_PACKAGE_JSON_CODES.MISSING : DEPLOY_PACKAGE_JSON_CODES.UNREADABLE;
+  }
+  let pkg;
+  if (code === null) {
+    try {
+      pkg = JSON.parse(text);
+    } catch {
+      pkg = undefined;
+    }
+    if (!isPlainObject(pkg)) code = DEPLOY_PACKAGE_JSON_CODES.INVALID;
+  }
+  if (code !== null) {
+    errorImpl(formatDeployPackageJsonDiagnostic(code));
+    exitImpl(1);
+    return null;
+  }
+  return { pkg, text };
+}

package/lib/deploy-runtime.mjs

@@ -402,6 +402,8 @@ export function createDeployCommand({
       try {
         staticArtifactPreflight = preflightStaticDeployArtifactImpl({
           staticDirArg: resolvedStaticDirArg,
+          // Explicit --prod only; an --app that implies prod is resolved after this point.
+          targetFlags: parsed.envTarget === "prod" ? "--prod" : null,
           // Display text is what the user typed or the client config says, never the resolved path.
           staticDirDisplay: parsed.staticDirArg ?? selectedClient?.static?.dir ?? null,
           staticDirSource: parsed.staticDirArg ? "argument" : "config",

package/lib/deploy-static-fullstack-runtime.mjs

@@ -319,6 +319,7 @@ export async function runStaticDeployFlow({
     try {
       artifactPreflight = preflightStaticDeployArtifactImpl({
         staticDirArg,
+        targetFlags: envTarget === "prod" ? "--prod" : null,
         cwd: frontendCwd,
         existsSyncImpl,
         resolvePathImpl,

package/lib/static-artifact-manifest.mjs

@@ -74,6 +74,7 @@ export function buildStaticArtifactManifest({
   rootDir,
   selection,
   displayDir = null,
+  targetFlags = null,
   lstatSyncImpl = lstatSync,
   readdirSyncImpl = readdirSync,
   readFileSyncImpl = readFileSync,
@@ -99,19 +100,22 @@ export function buildStaticArtifactManifest({
       : "Selected directory";
     // displayDir is the project-relative directory the user passed or the CLI detected. It is
     // attached as a field (not interpolated) so the public renderer decides what is safe to show.
+    // targetFlags carries only the production selector the user passed, so the retry guidance can keep
+    // it. Any other value (for example an app ID) is dropped here and never reaches the message.
+    const retryTarget = targetFlags === "--prod" ? { targetFlags } : {};
     if (entrypoint === "empty") {
       throw Object.assign(
         new Error(
           `${source} has an empty or blank index.html at its root (only whitespace or HTML comments). Refusing to replace the current frontend.`,
         ),
-        { code: "STATIC_ARTIFACT_INDEX_EMPTY", displayDir },
+        { code: "STATIC_ARTIFACT_INDEX_EMPTY", displayDir, ...retryTarget },
       );
     }
     throw Object.assign(
       new Error(
         `${source} does not contain index.html at its root. Refusing to replace the current frontend.`,
       ),
-      { code: "STATIC_ARTIFACT_INDEX_MISSING", displayDir },
+      { code: "STATIC_ARTIFACT_INDEX_MISSING", displayDir, ...retryTarget },
     );
   }
   return {

package/lib/static-command.mjs

@@ -263,12 +263,24 @@ export function createStaticCommand(options = {}) {
 
     // The display value is what the user typed or the client config says, never the resolved absolute path.
     const staticDirDisplay = parsed.staticDir || selectedClient?.static?.dir || null;
+    // The production selector the user asked for (--prod, or --app naming the prod app) is passed to the
+    // artifact error so its Retry line keeps it. The app ID itself is never passed.
+    const requestedTargetFlags =
+      resolveImplicitProdEnvironment({
+        explicitApp: Boolean(parsed.appId),
+        envTarget: parsed.isProd ? "prod" : "dev",
+        appId: parsed.appId,
+        prodApp: prodAppId,
+      }) === "prod"
+        ? "--prod"
+        : null;
     let artifactPreflight;
     try {
       artifactPreflight = preflightStaticDeployArtifactImpl({
         staticDirArg: configuredStaticDir,
         staticDirDisplay,
         staticDirSource: parsed.staticDir ? "argument" : "config",
+        targetFlags: requestedTargetFlags,
         cwd: selectedClient ? frontendRoot : cwdImpl(),
       });
     } catch (manifestError) {

package/lib/static-deploy-artifact-preflight.mjs

@@ -52,6 +52,7 @@ export function preflightStaticDeployArtifact({
   staticDirArg,
   staticDirDisplay = null,
   staticDirSource = "argument",
+  targetFlags = null,
   cwd = process.cwd(),
   autoDetectDirs,
   existsSyncImpl = existsSync,
@@ -78,6 +79,7 @@ export function preflightStaticDeployArtifact({
       rootDir: resolvePathImpl(cwd, targetDir),
       selection: staticDirArg ? "explicit" : `auto:${targetDir}`,
       displayDir: targetDir,
+      targetFlags,
       lstatSyncImpl,
       readdirSyncImpl,
     }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gencow",
-  "version": "0.1.266",
+  "version": "0.1.268",
   "description": "Gencow — AI Backend Engine",
   "type": "module",
   "bin": {
@@ -42,8 +42,8 @@
     "postgres": "^3.4.9",
     "@gencow/client": "0.2.8",
     "@gencow/react": "0.2.8",
-    "@gencow/server": "0.1.3",
     "@gencow/core": "0.1.47",
+    "@gencow/server": "0.1.3",
     "@gencow/shared": "0.0.0"
   },
   "scripts": {