genat-mcp 2.3.3 → 2.3.4

package/README.md

@@ -212,7 +212,7 @@ When creating run-genat.mjs: Use webhook-genat-login, NOT webhook-genat. Prefer
 
 - **url** (string): Page URL to analyze for accessibility.
 - **parentProjectFolder** (string): Path to the project root (TypeScript, JavaScript, or Python Playwright).
-- **writeToProject** (boolean, optional): If `true`, write generated files under `tests/accessibility/` by default; for **pytest-bdd** Python projects, files go under `features/` / `step_defs/` (or `tests/features`, `steps`, etc.) when those directories exist.
+- **writeToProject** (boolean, optional): If `true`, write generated files under `tests/accessibility/` by default; for **pytest-bdd** Python projects, files go under `features/` / `step_defs/` (or `tests/features`, `steps`, etc.) when those directories exist. New projects get **`step_defs/test_accessibility_steps.py`** when `accessibility_steps.py` is not already present.
 - **maxAssertions** (number, optional): Override default assertion count for complex pages (e.g. `25`).
 - **scopeToRegions** (string[], optional): Limit tests to specific regions (e.g. `["header", "main", "table"]`).
 - **analyzeStates** (boolean, optional): If `true`, run axe in expanded dropdown/combobox states and include state-specific violations. Increases analysis time.
@@ -234,10 +234,15 @@ Generated tests include keyboard accessibility checks (Tab order, focus) by defa
 GenAT does not guarantee that every Gherkin line has an implemented step. For **pytest-bdd** projects, the calling application or CI can:
 
 1. Parse `*.feature` step lines (after `Given`/`When`/`Then`/`And`/`But`).
-2. Confirm `accessibility_steps.py` (or your step module) defines matching `@given`/`@when`/`@then` patterns (or run `pytest --collect-only` / a dry run).
+2. Confirm `test_accessibility_steps.py` or `accessibility_steps.py` (your step module) defines matching `@given`/`@when`/`@then` patterns (or run `pytest --collect-only` / a dry run).
 
 Keep this as an optional pre-merge check alongside `_stepDefIncomplete`.
 
+### pytest-bdd discovery and axe-playwright-python
+
+- **Pytest** collects `test_*.py` by default. GenAT now prefers writing **`step_defs/test_accessibility_steps.py`** for new projects; if **`accessibility_steps.py`** already exists, that path is used. Ensure **`@scenario`** test functions are in a collected module (often the same file when named `test_*.py`) or import step defs from **`conftest.py`** / **`pytest_plugins`**.
+- **axe-playwright-python (sync):** `from axe_playwright_python.sync_playwright import Axe`; `axe = Axe()`; `results = axe.run(page)`; read **`results.response`** (axe-core JSON) and **`results.violations_count`**. Do not invent other APIs—see [axe-playwright-python docs](https://pamelafox.github.io/axe-playwright-python/).
+
 ## Sample prompts
 
 See [prompts.md](prompts.md) for a full list of prompts including specific parent folders, login, JIRA, and combined options.

package/detect-framework.js

@@ -77,15 +77,21 @@ function collectProjectLayoutHints(root, scriptType, bddFramework) {
   }
 
   if (existsSync(join(root, 'step_defs'))) {
-    parts.push('Put step definitions under step_defs/ (e.g. accessibility_steps.py)');
+    parts.push(
+      'Put step definitions under step_defs/; prefer test_accessibility_steps.py (test_*.py) so pytest discovers @scenario tests, or keep accessibility_steps.py and import that module from conftest.py'
+    );
   } else if (existsSync(join(root, 'steps'))) {
-    parts.push('Put step definitions under steps/');
+    parts.push('Put step definitions under steps/; prefer test_*.py naming for pytest collection or import via conftest.py');
   } else if (existsSync(join(root, 'tests', 'step_defs'))) {
-    parts.push('Put step definitions under tests/step_defs/');
+    parts.push('Put step definitions under tests/step_defs/; prefer test_accessibility_steps.py or conftest import');
   } else {
-    parts.push('Prefer step_defs/ for pytest-bdd step modules');
+    parts.push('Prefer step_defs/ for pytest-bdd; use test_accessibility_steps.py for pytest discovery of scenario tests');
   }
 
+  parts.push(
+    'Pytest collects test_*.py by default; ensure BDD scenario functions (@scenario) live in a collected module or are pulled in via conftest/pytest_plugins'
+  );
+
   const conftestPaths = walkWithPaths(root, (f) => f === 'conftest.py');
   const fixtureNames = new Set();
   for (const p of conftestPaths.slice(0, 3)) {

package/index.js

@@ -59,7 +59,7 @@ function insecureHttpsFetch(url, { method = 'GET', headers = {}, body, signal })
 const server = new McpServer(
   {
     name: 'GenAT',
-    version: '2.3.3',
+    version: '2.3.4',
   },
   {
     capabilities: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "genat-mcp",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "mcpName": "io.github.asokans@oclc.org/genat",
   "description": "MCP server GenAT: generate accessibility tests via n8n workflow (url + project folder)",
   "type": "module",

package/pytest-bdd-paths.js

@@ -1,11 +1,29 @@
 /**
  * Resolve pytest-bdd feature / step / spec paths from project layout (same rules as write-files).
+ * Step file: prefer legacy accessibility_steps.py if present; otherwise test_accessibility_steps.py
+ * so pytest discovers scenario tests (test_*.py).
  */
 import { existsSync } from 'fs';
 import { join } from 'path';
 
 const DEFAULT_DIR = 'tests/accessibility';
 
+const LEGACY_STEP = 'accessibility_steps.py';
+const TEST_STEP = 'test_accessibility_steps.py';
+
+/**
+ * @param {string} root
+ * @param {string[]} dirSegments - e.g. ['step_defs']
+ * @returns {string} relative path to step file
+ */
+function pickStepFileUnderDir(root, dirSegments) {
+  const legacy = join(...dirSegments, LEGACY_STEP);
+  const testNamed = join(...dirSegments, TEST_STEP);
+  if (existsSync(join(root, legacy))) return legacy;
+  if (existsSync(join(root, testNamed))) return testNamed;
+  return testNamed;
+}
+
 /**
  * @param {string} root
  * @returns {{ featureRel: string, stepRel: string, specRel: string }}
@@ -17,11 +35,11 @@ export function resolvePytestBddPaths(root) {
   else featureRel = join('features', 'accessibility.feature');
 
   let stepRel;
-  if (existsSync(join(root, 'step_defs'))) stepRel = join('step_defs', 'accessibility_steps.py');
-  else if (existsSync(join(root, 'steps'))) stepRel = join('steps', 'accessibility_steps.py');
-  else if (existsSync(join(root, 'tests', 'step_defs'))) stepRel = join('tests', 'step_defs', 'accessibility_steps.py');
-  else if (existsSync(join(root, 'tests', 'steps'))) stepRel = join('tests', 'steps', 'accessibility_steps.py');
-  else stepRel = join('step_defs', 'accessibility_steps.py');
+  if (existsSync(join(root, 'step_defs'))) stepRel = pickStepFileUnderDir(root, ['step_defs']);
+  else if (existsSync(join(root, 'steps'))) stepRel = pickStepFileUnderDir(root, ['steps']);
+  else if (existsSync(join(root, 'tests', 'step_defs'))) stepRel = pickStepFileUnderDir(root, ['tests', 'step_defs']);
+  else if (existsSync(join(root, 'tests', 'steps'))) stepRel = pickStepFileUnderDir(root, ['tests', 'steps']);
+  else stepRel = join('step_defs', TEST_STEP);
 
   const specRel = join(DEFAULT_DIR, 'accessibility_test.py');
   return { featureRel, stepRel, specRel };