genat-mcp 2.3.2 → 2.3.3

package/README.md

@@ -225,8 +225,19 @@ Login credentials: provide in the prompt (loginUsername, loginPassword) or in pr
 
 Framework detection: language (TypeScript vs JavaScript vs Python), BDD (Cucumber, pytest-bdd, Behave), and Page Object pattern (e.g. `pages/` directory or `*Page.ts`, `*Page.js`, `*_page.py` files). Returns JSON with `testCode`, `featureFile`, `stepDefCode`, `pageObjectCode` (and `_written` paths when writing).
 
+**Response fields for calling applications:** When `stepDefCode` is present, the MCP may set **`_stepDefIncomplete`** (boolean) and **`_stepDefIncompleteReason`** (string) using a lightweight heuristic (unclosed strings/delimiters, line continuation at EOF). Treat `true` as a signal to warn the user, retry generation, or block merge—do not assume the step file is runnable. Other optional fields from the workflow include **`usedLogin`** and **`loginReason`** when using login-capable workflows.
+
 Generated tests include keyboard accessibility checks (Tab order, focus) by default. For complex pages, the workflow uses page complexity (regions, tables, widgets) to scale assertion count.
 
+### Feature ↔ step parity (consumer CI)
+
+GenAT does not guarantee that every Gherkin line has an implemented step. For **pytest-bdd** projects, the calling application or CI can:
+
+1. Parse `*.feature` step lines (after `Given`/`When`/`Then`/`And`/`But`).
+2. Confirm `accessibility_steps.py` (or your step module) defines matching `@given`/`@when`/`@then` patterns (or run `pytest --collect-only` / a dry run).
+
+Keep this as an optional pre-merge check alongside `_stepDefIncomplete`.
+
 ## Sample prompts
 
 See [prompts.md](prompts.md) for a full list of prompts including specific parent folders, login, JIRA, and combined options.

package/detect-incomplete-step-def.js

@@ -0,0 +1,140 @@
+/**
+ * Lightweight heuristic: detect likely truncated or syntactically incomplete pytest-bdd step Python.
+ * For calling apps to surface _stepDefIncomplete and retry or warn.
+ */
+
+/**
+ * @param {string} code
+ * @returns {{ incomplete: boolean, reason: string | null }}
+ */
+export function detectStepDefIncomplete(code) {
+  if (code == null || typeof code !== 'string') {
+    return { incomplete: false, reason: null };
+  }
+  const t = code.replace(/\r\n/g, '\n').trimEnd();
+  if (t.length === 0) {
+    return { incomplete: true, reason: 'empty' };
+  }
+
+  const triples = (t.match(/"""/g) || []).length;
+  if (triples % 2 !== 0) {
+    return { incomplete: true, reason: 'unclosed_triple_double_quoted_string' };
+  }
+  const tripleSingle = (t.match(/'''/g) || []).length;
+  if (tripleSingle % 2 !== 0) {
+    return { incomplete: true, reason: 'unclosed_triple_single_quoted_string' };
+  }
+
+  const lines = t.split('\n');
+  const lastLine = lines[lines.length - 1];
+  if (/\\\s*$/.test(lastLine)) {
+    return { incomplete: true, reason: 'line_continuation_at_eof' };
+  }
+
+  const depth = bracketDepthAtEnd(t);
+  if (depth !== 0) {
+    return { incomplete: true, reason: 'unclosed_delimiters' };
+  }
+
+  return { incomplete: false, reason: null };
+}
+
+/**
+ * Rough balance of (), [], {} at end of file, skipping strings and comments.
+ * @param {string} s
+ * @returns {number} 0 if balanced, non-zero if likely incomplete
+ */
+function bracketDepthAtEnd(s) {
+  let i = 0;
+  const stack = [];
+  let state = 'code';
+
+  while (i < s.length) {
+    const c = s[i];
+
+    if (state === 'code') {
+      if (c === '#') {
+        while (i < s.length && s[i] !== '\n') i++;
+        continue;
+      }
+      if (s.slice(i, i + 3) === '"""') {
+        state = 'triple_double';
+        i += 3;
+        continue;
+      }
+      if (s.slice(i, i + 3) === "'''") {
+        state = 'triple_single';
+        i += 3;
+        continue;
+      }
+      if (c === '"' || c === "'") {
+        state = c === '"' ? 'string_double' : 'string_single';
+        i++;
+        continue;
+      }
+      if (c === '(') stack.push('(');
+      else if (c === '[') stack.push('[');
+      else if (c === '{') stack.push('{');
+      else if (c === ')' || c === ']' || c === '}') {
+        const want = c === ')' ? '(' : c === ']' ? '[' : '{';
+        if (stack.length === 0 || stack[stack.length - 1] !== want) {
+          return -1;
+        }
+        stack.pop();
+      }
+      i++;
+      continue;
+    }
+
+    if (state === 'string_single') {
+      if (c === '\\') {
+        i += 2;
+        continue;
+      }
+      if (c === "'") {
+        state = 'code';
+      }
+      i++;
+      continue;
+    }
+
+    if (state === 'string_double') {
+      if (c === '\\') {
+        i += 2;
+        continue;
+      }
+      if (c === '"') {
+        state = 'code';
+      }
+      i++;
+      continue;
+    }
+
+    if (state === 'triple_double') {
+      if (s.slice(i, i + 3) === '"""') {
+        state = 'code';
+        i += 3;
+        continue;
+      }
+      i++;
+      continue;
+    }
+
+    if (state === 'triple_single') {
+      if (s.slice(i, i + 3) === "'''") {
+        state = 'code';
+        i += 3;
+        continue;
+      }
+      i++;
+      continue;
+    }
+
+    i++;
+  }
+
+  if (state !== 'code') {
+    return 1;
+  }
+  return stack.length;
+}

package/index.js

@@ -11,6 +11,7 @@ import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js'
 import { z } from 'zod';
 import { detectFramework } from './detect-framework.js';
 import { detectLogin } from './detect-login.js';
+import { detectStepDefIncomplete } from './detect-incomplete-step-def.js';
 import { finalizePytestBddStepDef } from './finalize-pytest-bdd-steps.js';
 import { resolvePytestBddPaths } from './pytest-bdd-paths.js';
 import { writeGeneratedFiles } from './write-files.js';
@@ -58,7 +59,7 @@ function insecureHttpsFetch(url, { method = 'GET', headers = {}, body, signal })
 const server = new McpServer(
   {
     name: 'GenAT',
-    version: '2.3.2',
+    version: '2.3.3',
   },
   {
     capabilities: {
@@ -283,6 +284,12 @@ server.registerTool(
       if (data.testCode) data.testCode = finalizePytestBddStepDef(resolvedPath, data.testCode, pathOverrides);
     }
 
+    if (data.stepDefCode && typeof data.stepDefCode === 'string') {
+      const inc = detectStepDefIncomplete(data.stepDefCode);
+      data._stepDefIncomplete = inc.incomplete;
+      if (inc.reason) data._stepDefIncompleteReason = inc.reason;
+    }
+
     if (writeToProject && resolvedPath && data) {
       if (data.bddFramework == null) data.bddFramework = framework.bddFramework;
       try {

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "genat-mcp",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "mcpName": "io.github.asokans@oclc.org/genat",
   "description": "MCP server GenAT: generate accessibility tests via n8n workflow (url + project folder)",
   "type": "module",
   "main": "index.js",
   "bin": { "genat-mcp": "index.js" },
   "engines": { "node": ">=20" },
-  "files": ["index.js", "detect-framework.js", "detect-login.js", "write-files.js", "strip-gherkin-from-python-steps.js", "finalize-pytest-bdd-steps.js", "fix-pytest-bdd-scenario-path.js", "pytest-bdd-paths.js", "oclc-context.js", "oclc-accessibility-confluence-context.md", "run-genat.mjs", "rules/genat-mcp.mdc"],
+  "files": ["index.js", "detect-framework.js", "detect-login.js", "detect-incomplete-step-def.js", "write-files.js", "strip-gherkin-from-python-steps.js", "finalize-pytest-bdd-steps.js", "fix-pytest-bdd-scenario-path.js", "pytest-bdd-paths.js", "oclc-context.js", "oclc-accessibility-confluence-context.md", "run-genat.mjs", "rules/genat-mcp.mdc"],
   "keywords": ["mcp", "accessibility", "playwright", "n8n", "model-context-protocol", "a11y", "testing"],
   "repository": {
     "type": "git",